projects_spec.rb 55.1 KB
Newer Older
1
# -*- coding: utf-8 -*-
N
Nihad Abbasov 已提交
2 3
require 'spec_helper'

4
describe API::Projects do
5
  include Gitlab::CurrentSettings
6

7 8 9
  let(:user) { create(:user) }
  let(:user2) { create(:user) }
  let(:user3) { create(:user) }
A
Angus MacArthur 已提交
10
  let(:admin) { create(:admin) }
11 12
  let(:project) { create(:empty_project, creator_id: user.id, namespace: user.namespace) }
  let(:project2) { create(:empty_project, path: 'project2', creator_id: user.id, namespace: user.namespace) }
13
  let(:snippet) { create(:project_snippet, :public, author: user, project: project, title: 'example') }
14
  let(:project_member) { create(:project_member, :developer, user: user3, project: project) }
15
  let(:user4) { create(:user) }
16 17
  let(:project3) do
    create(:project,
18
    :private,
19
    :repository,
20 21 22 23 24 25
    name: 'second_project',
    path: 'second_project',
    creator_id: user.id,
    namespace: user.namespace,
    merge_requests_enabled: false,
    issues_enabled: false, wiki_enabled: false,
W
winniehell 已提交
26
    builds_enabled: false,
27
    snippets_enabled: false)
28
  end
29
  let(:project_member2) do
30 31 32 33 34 35
    create(:project_member,
    user: user4,
    project: project3,
    access_level: ProjectMember::MASTER)
  end
  let(:project4) do
36
    create(:empty_project,
37 38 39 40 41 42 43
    name: 'third_project',
    path: 'third_project',
    creator_id: user4.id,
    namespace: user4.namespace)
  end

  describe 'GET /projects' do
T
Toon Claes 已提交
44 45
    shared_examples_for 'projects response' do
      it 'returns an array of projects' do
46
        get api('/projects', current_user), filter
T
Toon Claes 已提交
47 48

        expect(response).to have_http_status(200)
49
        expect(response).to include_pagination_headers
T
Toon Claes 已提交
50 51 52 53 54 55 56 57 58 59 60 61
        expect(json_response).to be_an Array
        expect(json_response.map { |p| p['id'] }).to contain_exactly(*projects.map(&:id))
      end
    end

    let!(:public_project) { create(:empty_project, :public, name: 'public_project') }
    before do
      project
      project2
      project3
      project4
    end
D
Dmitriy Zaporozhets 已提交
62

63
    context 'when unauthenticated' do
T
Toon Claes 已提交
64
      it_behaves_like 'projects response' do
65
        let(:filter) { {} }
T
Toon Claes 已提交
66 67
        let(:current_user) { nil }
        let(:projects) { [public_project] }
68
      end
N
Nihad Abbasov 已提交
69 70
    end

M
Markus Koller 已提交
71
    context 'when authenticated as regular user' do
T
Toon Claes 已提交
72
      it_behaves_like 'projects response' do
73
        let(:filter) { {} }
T
Toon Claes 已提交
74 75
        let(:current_user) { user }
        let(:projects) { [public_project, project, project2, project3] }
N
Nihad Abbasov 已提交
76
      end
77

78
      it 'includes the project labels as the tag_list' do
79
        get api('/projects', user)
T
Toon Claes 已提交
80

81
        expect(response.status).to eq 200
82
        expect(response).to include_pagination_headers
83 84
        expect(json_response).to be_an Array
        expect(json_response.first.keys).to include('tag_list')
85
      end
86

87
      it 'includes open_issues_count' do
S
Stan Hu 已提交
88
        get api('/projects', user)
T
Toon Claes 已提交
89

S
Stan Hu 已提交
90
        expect(response.status).to eq 200
91
        expect(response).to include_pagination_headers
S
Stan Hu 已提交
92 93 94 95
        expect(json_response).to be_an Array
        expect(json_response.first.keys).to include('open_issues_count')
      end

T
Toon Claes 已提交
96
      it 'does not include open_issues_count if issues are disabled' do
F
Felipe Artur 已提交
97
        project.project_feature.update_attribute(:issues_access_level, ProjectFeature::DISABLED)
S
Stan Hu 已提交
98 99

        get api('/projects', user)
T
Toon Claes 已提交
100

S
Stan Hu 已提交
101
        expect(response.status).to eq 200
102
        expect(response).to include_pagination_headers
S
Stan Hu 已提交
103
        expect(json_response).to be_an Array
T
Toon Claes 已提交
104 105 106 107 108 109 110
        expect(json_response.find { |hash| hash['id'] == project.id }.keys).not_to include('open_issues_count')
      end

      it "does not include statistics by default" do
        get api('/projects', user)

        expect(response).to have_http_status(200)
111
        expect(response).to include_pagination_headers
T
Toon Claes 已提交
112 113
        expect(json_response).to be_an Array
        expect(json_response.first).not_to include('statistics')
S
Stan Hu 已提交
114 115
      end

T
Toon Claes 已提交
116 117 118 119
      it "includes statistics if requested" do
        get api('/projects', user), statistics: true

        expect(response).to have_http_status(200)
120
        expect(response).to include_pagination_headers
T
Toon Claes 已提交
121 122
        expect(json_response).to be_an Array
        expect(json_response.first).to include 'statistics'
S
Stan Hu 已提交
123 124
      end

T
Toon Claes 已提交
125
      context 'and with simple=true' do
T
tiagonbotelho 已提交
126
        it 'returns a simplified version of all the projects' do
D
Douwe Maan 已提交
127
          expected_keys = %w(id http_url_to_repo web_url name name_with_namespace path path_with_namespace)
128

129
          get api('/projects?simple=true', user)
T
tiagonbotelho 已提交
130

131
          expect(response).to have_http_status(200)
132
          expect(response).to include_pagination_headers
133
          expect(json_response).to be_an Array
134
          expect(json_response.first.keys).to match_array expected_keys
135 136 137
        end
      end

138
      context 'and using search' do
139 140 141 142 143 144
        it_behaves_like 'projects response' do
          let(:filter) { { search: project.name } }
          let(:current_user) { user }
          let(:projects) { [project] }
        end
      end
T
Toon Claes 已提交
145

146
      context 'and membership=true' do
147
        it_behaves_like 'projects response' do
148
          let(:filter) { { membership: true } }
149 150
          let(:current_user) { user }
          let(:projects) { [project, project2, project3] }
151 152 153
        end
      end

J
Josh Frye 已提交
154
      context 'and using the visibility filter' do
155
        it 'filters based on private visibility param' do
J
Josh Frye 已提交
156
          get api('/projects', user), { visibility: 'private' }
T
Toon Claes 已提交
157

Z
Z.J. van de Weg 已提交
158
          expect(response).to have_http_status(200)
159
          expect(response).to include_pagination_headers
J
Josh Frye 已提交
160
          expect(json_response).to be_an Array
T
Toon Claes 已提交
161
          expect(json_response.map { |p| p['id'] }).to contain_exactly(project.id, project2.id, project3.id)
J
Josh Frye 已提交
162 163
        end

164
        it 'filters based on internal visibility param' do
T
Toon Claes 已提交
165 166
          project2.update_attribute(:visibility_level, Gitlab::VisibilityLevel::INTERNAL)

J
Josh Frye 已提交
167
          get api('/projects', user), { visibility: 'internal' }
T
Toon Claes 已提交
168

Z
Z.J. van de Weg 已提交
169
          expect(response).to have_http_status(200)
170
          expect(response).to include_pagination_headers
J
Josh Frye 已提交
171
          expect(json_response).to be_an Array
T
Toon Claes 已提交
172
          expect(json_response.map { |p| p['id'] }).to contain_exactly(project2.id)
J
Josh Frye 已提交
173 174
        end

175
        it 'filters based on public visibility param' do
J
Josh Frye 已提交
176
          get api('/projects', user), { visibility: 'public' }
T
Toon Claes 已提交
177

Z
Z.J. van de Weg 已提交
178
          expect(response).to have_http_status(200)
179
          expect(response).to include_pagination_headers
J
Josh Frye 已提交
180
          expect(json_response).to be_an Array
T
Toon Claes 已提交
181
          expect(json_response.map { |p| p['id'] }).to contain_exactly(public_project.id)
J
Josh Frye 已提交
182 183 184
        end
      end

185
      context 'and using sorting' do
186
        it 'returns the correct order when sorted by id' do
187
          get api('/projects', user), { order_by: 'id', sort: 'desc' }
T
Toon Claes 已提交
188

Z
Z.J. van de Weg 已提交
189
          expect(response).to have_http_status(200)
190
          expect(response).to include_pagination_headers
191 192
          expect(json_response).to be_an Array
          expect(json_response.first['id']).to eq(project3.id)
193 194
        end
      end
D
Dmitriy Zaporozhets 已提交
195

T
Toon Claes 已提交
196 197 198
      context 'and with owned=true' do
        it 'returns an array of projects the user owns' do
          get api('/projects', user4), owned: true
D
Dmitriy Zaporozhets 已提交
199

T
Toon Claes 已提交
200
          expect(response).to have_http_status(200)
201
          expect(response).to include_pagination_headers
T
Toon Claes 已提交
202 203 204
          expect(json_response).to be_an Array
          expect(json_response.first['name']).to eq(project4.name)
          expect(json_response.first['owner']['username']).to eq(user4.username)
205
        end
D
Dmitriy Zaporozhets 已提交
206
      end
M
Markus Koller 已提交
207

T
Toon Claes 已提交
208 209
      context 'and with starred=true' do
        let(:public_project) { create(:empty_project, :public) }
210

T
Toon Claes 已提交
211
        before do
212
          project_member
T
Toon Claes 已提交
213 214
          user3.update_attributes(starred_projects: [project, project2, project3, public_project])
        end
M
Markus Koller 已提交
215

T
Toon Claes 已提交
216 217
        it 'returns the starred projects viewable by the user' do
          get api('/projects', user3), starred: true
M
Markus Koller 已提交
218

T
Toon Claes 已提交
219
          expect(response).to have_http_status(200)
220
          expect(response).to include_pagination_headers
T
Toon Claes 已提交
221 222 223
          expect(json_response).to be_an Array
          expect(json_response.map { |project| project['id'] }).to contain_exactly(project.id, public_project.id)
        end
M
Markus Koller 已提交
224
      end
225

T
Toon Claes 已提交
226
      context 'and with all query parameters' do
227
        let!(:project5) { create(:empty_project, :public, path: 'gitlab5', namespace: create(:namespace)) }
T
Toon Claes 已提交
228 229 230 231
        let!(:project6) { create(:empty_project, :public, path: 'project6', namespace: user.namespace) }
        let!(:project7) { create(:empty_project, :public, path: 'gitlab7', namespace: user.namespace) }
        let!(:project8) { create(:empty_project, path: 'gitlab8', namespace: user.namespace) }
        let!(:project9) { create(:empty_project, :public, path: 'gitlab9') }
232

T
Toon Claes 已提交
233
        before do
234
          user.update_attributes(starred_projects: [project5, project7, project8, project9])
T
Toon Claes 已提交
235
        end
236

237
        context 'including owned filter' do
238
          it 'returns only projects that satisfy all query parameters' do
239
            get api('/projects', user), { visibility: 'public', owned: true, starred: true, search: 'gitlab' }
240

241 242 243 244 245 246 247 248
            expect(response).to have_http_status(200)
            expect(response).to include_pagination_headers
            expect(json_response).to be_an Array
            expect(json_response.size).to eq(1)
            expect(json_response.first['id']).to eq(project7.id)
          end
        end

249
        context 'including membership filter' do
250 251 252 253 254 255 256
          before do
            create(:project_member,
                   user: user,
                   project: project5,
                   access_level: ProjectMember::MASTER)
          end

257 258
          it 'returns only projects that satisfy all query parameters' do
            get api('/projects', user), { visibility: 'public', membership: true, starred: true, search: 'gitlab' }
259 260 261 262 263

            expect(response).to have_http_status(200)
            expect(response).to include_pagination_headers
            expect(json_response).to be_an Array
            expect(json_response.size).to eq(2)
264
            expect(json_response.map { |project| project['id'] }).to contain_exactly(project5.id, project7.id)
265
          end
T
Toon Claes 已提交
266
        end
267 268
      end
    end
269

270
    context 'when authenticated as a different user' do
T
Toon Claes 已提交
271
      it_behaves_like 'projects response' do
272
        let(:filter) { {} }
273 274 275
        let(:current_user) { user2 }
        let(:projects) { [public_project] }
      end
276
    end
277

T
Toon Claes 已提交
278 279
    context 'when authenticated as admin' do
      it_behaves_like 'projects response' do
280
        let(:filter) { {} }
T
Toon Claes 已提交
281 282 283
        let(:current_user) { admin }
        let(:projects) { Project.all }
      end
284 285 286
    end
  end

287 288
  describe 'POST /projects' do
    context 'maximum number of projects reached' do
289
      it 'does not create new project and respond with 403' do
290
        allow_any_instance_of(User).to receive(:projects_limit_left).and_return(0)
291 292
        expect { post api('/projects', user2), name: 'foo' }.
          to change {Project.count}.by(0)
Z
Z.J. van de Weg 已提交
293
        expect(response).to have_http_status(403)
294 295 296
      end
    end

297 298
    it 'creates new project without path but with name and returns 201' do
      expect { post api('/projects', user), name: 'Foo Project' }.
299
        to change { Project.count }.by(1)
Z
Z.J. van de Weg 已提交
300
      expect(response).to have_http_status(201)
301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318

      project = Project.first

      expect(project.name).to eq('Foo Project')
      expect(project.path).to eq('foo-project')
    end

    it 'creates new project without name but with path and returns 201' do
      expect { post api('/projects', user), path: 'foo_project' }.
        to change { Project.count }.by(1)
      expect(response).to have_http_status(201)

      project = Project.first

      expect(project.name).to eq('foo_project')
      expect(project.path).to eq('foo_project')
    end

319 320
    it 'creates new project with name and path and returns 201' do
      expect { post api('/projects', user), path: 'path-project-Foo', name: 'Foo Project' }.
321 322 323 324 325 326
        to change { Project.count }.by(1)
      expect(response).to have_http_status(201)

      project = Project.first

      expect(project.name).to eq('Foo Project')
327
      expect(project.path).to eq('path-project-Foo')
328 329
    end

330
    it 'creates last project before reaching project limit' do
331
      allow_any_instance_of(User).to receive(:projects_limit_left).and_return(1)
332
      post api('/projects', user2), name: 'foo'
Z
Z.J. van de Weg 已提交
333
      expect(response).to have_http_status(201)
334 335
    end

336
    it 'does not create new project without name or path and returns 400' do
337
      expect { post api('/projects', user) }.not_to change { Project.count }
Z
Z.J. van de Weg 已提交
338
      expect(response).to have_http_status(400)
339
    end
A
Alex Denisov 已提交
340

341
    it "assigns attributes to project" do
342
      project = attributes_for(:project, {
343
        path: 'camelCasePath',
344
        issues_enabled: false,
W
winniehell 已提交
345
        jobs_enabled: false,
346
        merge_requests_enabled: false,
347
        wiki_enabled: false,
J
James Lopez 已提交
348
        only_allow_merge_if_pipeline_succeeds: false,
349 350
        request_access_enabled: true,
        only_allow_merge_if_all_discussions_are_resolved: false
A
Alex Denisov 已提交
351 352
      })

353
      post api('/projects', user), project
A
Alex Denisov 已提交
354

W
winniehell 已提交
355 356
      expect(response).to have_http_status(201)

357
      project.each_pair do |k, v|
358
        next if %i[has_external_issue_tracker issues_enabled merge_requests_enabled wiki_enabled].include?(k)
359
        expect(json_response[k.to_s]).to eq(v)
A
Alex Denisov 已提交
360
      end
F
Felipe Artur 已提交
361 362 363 364 365 366

      # Check feature permissions attributes
      project = Project.find_by_path(project[:path])
      expect(project.project_feature.issues_access_level).to eq(ProjectFeature::DISABLED)
      expect(project.project_feature.merge_requests_access_level).to eq(ProjectFeature::DISABLED)
      expect(project.project_feature.wiki_access_level).to eq(ProjectFeature::DISABLED)
367
    end
368

369
    it 'sets a project as public' do
370 371
      project = attributes_for(:project, visibility: 'public')

372
      post api('/projects', user), project
373 374

      expect(json_response['visibility']).to eq('public')
375 376
    end

377
    it 'sets a project as internal' do
378 379
      project = attributes_for(:project, visibility: 'internal')

380
      post api('/projects', user), project
381 382

      expect(json_response['visibility']).to eq('internal')
383 384
    end

385
    it 'sets a project as private' do
386 387
      project = attributes_for(:project, visibility: 'private')

388
      post api('/projects', user), project
389 390

      expect(json_response['visibility']).to eq('private')
391 392
    end

V
vanadium23 已提交
393 394 395 396 397 398 399 400
    it 'sets tag list to a project' do
      project = attributes_for(:project, tag_list: %w[tagFirst tagSecond])

      post api('/projects', user), project

      expect(json_response['tag_list']).to eq(%w[tagFirst tagSecond])
    end

401 402 403 404 405 406 407 408 409
    it 'uploads avatar for project a project' do
      project = attributes_for(:project, avatar: fixture_file_upload(Rails.root + 'spec/fixtures/banana_sample.gif', 'image/gif'))

      post api('/projects', user), project

      project_id = json_response['id']
      expect(json_response['avatar_url']).to eq("http://localhost/uploads/system/project/avatar/#{project_id}/banana_sample.gif")
    end

410
    it 'sets a project as allowing merge even if build fails' do
J
James Lopez 已提交
411
      project = attributes_for(:project, { only_allow_merge_if_pipeline_succeeds: false })
412
      post api('/projects', user), project
J
James Lopez 已提交
413
      expect(json_response['only_allow_merge_if_pipeline_succeeds']).to be_falsey
414 415
    end

J
James Lopez 已提交
416 417
    it 'sets a project as allowing merge only if merge_when_pipeline_succeeds' do
      project = attributes_for(:project, { only_allow_merge_if_pipeline_succeeds: true })
418
      post api('/projects', user), project
J
James Lopez 已提交
419
      expect(json_response['only_allow_merge_if_pipeline_succeeds']).to be_truthy
420 421
    end

422 423 424 425 426 427 428 429
    it 'sets a project as allowing merge even if discussions are unresolved' do
      project = attributes_for(:project, { only_allow_merge_if_all_discussions_are_resolved: false })

      post api('/projects', user), project

      expect(json_response['only_allow_merge_if_all_discussions_are_resolved']).to be_falsey
    end

430 431 432 433 434 435 436 437
    it 'sets a project as allowing merge if only_allow_merge_if_all_discussions_are_resolved is nil' do
      project = attributes_for(:project, only_allow_merge_if_all_discussions_are_resolved: nil)

      post api('/projects', user), project

      expect(json_response['only_allow_merge_if_all_discussions_are_resolved']).to be_falsey
    end

438 439 440 441 442 443 444 445
    it 'sets a project as allowing merge only if all discussions are resolved' do
      project = attributes_for(:project, { only_allow_merge_if_all_discussions_are_resolved: true })

      post api('/projects', user), project

      expect(json_response['only_allow_merge_if_all_discussions_are_resolved']).to be_truthy
    end

446 447 448 449 450 451 452 453
    it 'ignores import_url when it is nil' do
      project = attributes_for(:project, { import_url: nil })

      post api('/projects', user), project

      expect(response).to have_http_status(201)
    end

454
    context 'when a visibility level is restricted' do
455
      let(:project_param) { attributes_for(:project, visibility: 'public') }
456

457
      before do
458
        stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
459 460
      end

461
      it 'does not allow a non-admin to use a restricted visibility level' do
462
        post api('/projects', user), project_param
F
Felipe Artur 已提交
463

Z
Z.J. van de Weg 已提交
464
        expect(response).to have_http_status(400)
465 466 467 468 469
        expect(json_response['message']['visibility_level'].first).to(
          match('restricted by your GitLab administrator')
        )
      end

470
      it 'allows an admin to override restricted visibility settings' do
471 472
        post api('/projects', admin), project_param

473
        expect(json_response['visibility']).to eq('public')
474 475
      end
    end
476 477
  end

478
  describe 'POST /projects/user/:id' do
479 480 481
    before do
      expect(project).to be_persisted
    end
A
Angus MacArthur 已提交
482

483 484
    it 'creates new project without path but with name and return 201' do
      expect { post api("/projects/user/#{user.id}", admin), name: 'Foo Project' }.to change {Project.count}.by(1)
Z
Z.J. van de Weg 已提交
485
      expect(response).to have_http_status(201)
486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501

      project = Project.first

      expect(project.name).to eq('Foo Project')
      expect(project.path).to eq('foo-project')
    end

    it 'creates new project with name and path and returns 201' do
      expect { post api("/projects/user/#{user.id}", admin), path: 'path-project-Foo', name: 'Foo Project' }.
        to change { Project.count }.by(1)
      expect(response).to have_http_status(201)

      project = Project.first

      expect(project.name).to eq('Foo Project')
      expect(project.path).to eq('path-project-Foo')
A
Angus MacArthur 已提交
502 503
    end

504
    it 'responds with 400 on failure and not project' do
505 506
      expect { post api("/projects/user/#{user.id}", admin) }.
        not_to change { Project.count }
507

Z
Z.J. van de Weg 已提交
508
      expect(response).to have_http_status(400)
R
Robert Schilling 已提交
509
      expect(json_response['error']).to eq('name is missing')
A
Angus MacArthur 已提交
510 511
    end

512
    it 'assigns attributes to project' do
A
Angus MacArthur 已提交
513
      project = attributes_for(:project, {
514 515
        issues_enabled: false,
        merge_requests_enabled: false,
516 517
        wiki_enabled: false,
        request_access_enabled: true
A
Angus MacArthur 已提交
518 519 520 521
      })

      post api("/projects/user/#{user.id}", admin), project

R
Robert Schilling 已提交
522
      expect(response).to have_http_status(201)
523
      project.each_pair do |k, v|
524
        next if %i[has_external_issue_tracker path].include?(k)
525
        expect(json_response[k.to_s]).to eq(v)
A
Angus MacArthur 已提交
526 527
      end
    end
528

529
    it 'sets a project as public' do
530 531
      project = attributes_for(:project, visibility: 'public')

532
      post api("/projects/user/#{user.id}", admin), project
R
Robert Schilling 已提交
533 534

      expect(response).to have_http_status(201)
535
      expect(json_response['visibility']).to eq('public')
536 537
    end

538
    it 'sets a project as internal' do
539 540
      project = attributes_for(:project, visibility: 'internal')

541
      post api("/projects/user/#{user.id}", admin), project
R
Robert Schilling 已提交
542 543

      expect(response).to have_http_status(201)
544
      expect(json_response['visibility']).to eq('internal')
545 546
    end

547
    it 'sets a project as private' do
548 549
      project = attributes_for(:project, visibility: 'private')

550
      post api("/projects/user/#{user.id}", admin), project
551 552

      expect(json_response['visibility']).to eq('private')
553 554
    end

555
    it 'sets a project as allowing merge even if build fails' do
J
James Lopez 已提交
556
      project = attributes_for(:project, { only_allow_merge_if_pipeline_succeeds: false })
557
      post api("/projects/user/#{user.id}", admin), project
J
James Lopez 已提交
558
      expect(json_response['only_allow_merge_if_pipeline_succeeds']).to be_falsey
559 560
    end

J
James Lopez 已提交
561 562
    it 'sets a project as allowing merge only if merge_when_pipeline_succeeds' do
      project = attributes_for(:project, { only_allow_merge_if_pipeline_succeeds: true })
563
      post api("/projects/user/#{user.id}", admin), project
J
James Lopez 已提交
564
      expect(json_response['only_allow_merge_if_pipeline_succeeds']).to be_truthy
565
    end
566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581

    it 'sets a project as allowing merge even if discussions are unresolved' do
      project = attributes_for(:project, { only_allow_merge_if_all_discussions_are_resolved: false })

      post api("/projects/user/#{user.id}", admin), project

      expect(json_response['only_allow_merge_if_all_discussions_are_resolved']).to be_falsey
    end

    it 'sets a project as allowing merge only if all discussions are resolved' do
      project = attributes_for(:project, { only_allow_merge_if_all_discussions_are_resolved: true })

      post api("/projects/user/#{user.id}", admin), project

      expect(json_response['only_allow_merge_if_all_discussions_are_resolved']).to be_truthy
    end
A
Angus MacArthur 已提交
582 583
  end

D
Douwe Maan 已提交
584
  describe "POST /projects/:id/uploads" do
585 586 587
    before do
      project
    end
D
Douwe Maan 已提交
588 589 590 591

    it "uploads the file and returns its info" do
      post api("/projects/#{project.id}/uploads", user), file: fixture_file_upload(Rails.root + "spec/fixtures/dk.png", "image/png")

Z
Z.J. van de Weg 已提交
592
      expect(response).to have_http_status(201)
D
Douwe Maan 已提交
593 594 595 596 597 598
      expect(json_response['alt']).to eq("dk")
      expect(json_response['url']).to start_with("/uploads/")
      expect(json_response['url']).to end_with("/dk.png")
    end
  end

599
  describe 'GET /projects/:id' do
600 601
    context 'when unauthenticated' do
      it 'returns the public projects' do
602
        public_project = create(:empty_project, :public)
603

604
        get api("/projects/#{public_project.id}")
605

606 607 608 609 610
        expect(response).to have_http_status(200)
        expect(json_response['id']).to eq(public_project.id)
        expect(json_response['description']).to eq(public_project.description)
        expect(json_response.keys).not_to include('permissions')
      end
611
    end
N
Nihad Abbasov 已提交
612

613 614 615 616 617
    context 'when authenticated' do
      before do
        project
        project_member
      end
618

619 620 621
      it 'returns a project by id' do
        group = create(:group)
        link = create(:project_group_link, project: project, group: group)
622

623
        get api("/projects/#{project.id}", user)
624

625 626 627 628 629 630
        expect(response).to have_http_status(200)
        expect(json_response['id']).to eq(project.id)
        expect(json_response['description']).to eq(project.description)
        expect(json_response['default_branch']).to eq(project.default_branch)
        expect(json_response['tag_list']).to be_an Array
        expect(json_response['archived']).to be_falsey
631
        expect(json_response['visibility']).to be_present
632 633 634 635 636 637 638 639 640 641
        expect(json_response['ssh_url_to_repo']).to be_present
        expect(json_response['http_url_to_repo']).to be_present
        expect(json_response['web_url']).to be_present
        expect(json_response['owner']).to be_a Hash
        expect(json_response['owner']).to be_a Hash
        expect(json_response['name']).to eq(project.name)
        expect(json_response['path']).to be_present
        expect(json_response['issues_enabled']).to be_present
        expect(json_response['merge_requests_enabled']).to be_present
        expect(json_response['wiki_enabled']).to be_present
T
Toon Claes 已提交
642
        expect(json_response['jobs_enabled']).to be_present
643 644 645 646 647 648 649
        expect(json_response['snippets_enabled']).to be_present
        expect(json_response['container_registry_enabled']).to be_present
        expect(json_response['created_at']).to be_present
        expect(json_response['last_activity_at']).to be_present
        expect(json_response['shared_runners_enabled']).to be_present
        expect(json_response['creator_id']).to be_present
        expect(json_response['namespace']).to be_present
650 651
        expect(json_response['import_status']).to be_present
        expect(json_response).to include("import_error")
652 653 654
        expect(json_response['avatar_url']).to be_nil
        expect(json_response['star_count']).to be_present
        expect(json_response['forks_count']).to be_present
T
Toon Claes 已提交
655
        expect(json_response['public_jobs']).to be_present
656 657 658 659 660
        expect(json_response['shared_with_groups']).to be_an Array
        expect(json_response['shared_with_groups'].length).to eq(1)
        expect(json_response['shared_with_groups'][0]['group_id']).to eq(group.id)
        expect(json_response['shared_with_groups'][0]['group_name']).to eq(group.name)
        expect(json_response['shared_with_groups'][0]['group_access_level']).to eq(link.group_access)
J
James Lopez 已提交
661
        expect(json_response['only_allow_merge_if_pipeline_succeeds']).to eq(project.only_allow_merge_if_pipeline_succeeds)
662 663
        expect(json_response['only_allow_merge_if_all_discussions_are_resolved']).to eq(project.only_allow_merge_if_all_discussions_are_resolved)
      end
664

665 666 667 668 669
      it 'returns a project by path name' do
        get api("/projects/#{project.id}", user)
        expect(response).to have_http_status(200)
        expect(json_response['name']).to eq(project.name)
      end
670

671 672 673 674 675
      it 'returns a 404 error if not found' do
        get api('/projects/42', user)
        expect(response).to have_http_status(404)
        expect(json_response['message']).to eq('404 Project Not Found')
      end
676

677 678 679 680
      it 'returns a 404 error if user is not a member' do
        other_user = create(:user)
        get api("/projects/#{project.id}", other_user)
        expect(response).to have_http_status(404)
681 682
      end

683 684
      it 'handles users with dots' do
        dot_user = create(:user, username: 'dot.user')
685
        project = create(:empty_project, creator_id: dot_user.id, namespace: dot_user.namespace)
686

687 688 689 690 691
        get api("/projects/#{dot_user.namespace.name}%2F#{project.path}", dot_user)
        expect(response).to have_http_status(200)
        expect(json_response['name']).to eq(project.name)
      end

692 693 694 695 696 697 698 699 700
      it 'exposes namespace fields' do
        get api("/projects/#{project.id}", user)

        expect(response).to have_http_status(200)
        expect(json_response['namespace']).to eq({
          'id' => user.namespace.id,
          'name' => user.namespace.name,
          'path' => user.namespace.path,
          'kind' => user.namespace.kind,
701
          'full_path' => user.namespace.full_path
702 703 704
        })
      end

705 706 707 708 709 710 711 712 713 714 715 716 717 718
      it "does not include statistics by default" do
        get api("/projects/#{project.id}", user)

        expect(response).to have_http_status(200)
        expect(json_response).not_to include 'statistics'
      end

      it "includes statistics if requested" do
        get api("/projects/#{project.id}", user), statistics: true

        expect(response).to have_http_status(200)
        expect(json_response).to include 'statistics'
      end

719 720 721 722 723 724 725 726 727 728 729 730 731 732
      it "includes import_error if user can admin project" do
        get api("/projects/#{project.id}", user)

        expect(response).to have_http_status(200)
        expect(json_response).to include("import_error")
      end

      it "does not include import_error if user cannot admin project" do
        get api("/projects/#{project.id}", user3)

        expect(response).to have_http_status(200)
        expect(json_response).not_to include("import_error")
      end

733 734
      describe 'permissions' do
        context 'all projects' do
735 736 737
          before do
            project.team << [user, :master]
          end
738 739 740 741 742

          it 'contains permission information' do
            get api("/projects", user)

            expect(response).to have_http_status(200)
743 744
            expect(json_response.first['permissions']['project_access']['access_level']).
            to eq(Gitlab::Access::MASTER)
745 746 747 748 749 750 751 752 753 754
            expect(json_response.first['permissions']['group_access']).to be_nil
          end
        end

        context 'personal project' do
          it 'sets project access and returns 200' do
            project.team << [user, :master]
            get api("/projects/#{project.id}", user)

            expect(response).to have_http_status(200)
755 756
            expect(json_response['permissions']['project_access']['access_level']).
            to eq(Gitlab::Access::MASTER)
757 758
            expect(json_response['permissions']['group_access']).to be_nil
          end
759
        end
760

761
        context 'group project' do
762
          let(:project2) { create(:empty_project, group: create(:group)) }
763

764 765 766
          before do
            project2.group.add_owner(user)
          end
767

768 769
          it 'sets the owner and return 200' do
            get api("/projects/#{project2.id}", user)
770

771 772
            expect(response).to have_http_status(200)
            expect(json_response['permissions']['project_access']).to be_nil
773 774
            expect(json_response['permissions']['group_access']['access_level']).
            to eq(Gitlab::Access::OWNER)
775
          end
776
        end
777 778
      end
    end
N
Nihad Abbasov 已提交
779 780
  end

781 782 783 784
  describe 'GET /projects/:id/users' do
    shared_examples_for 'project users response' do
      it 'returns the project users' do
        get api("/projects/#{project.id}/users", current_user)
785

786 787
        user = project.namespace.owner

788
        expect(response).to have_http_status(200)
789
        expect(response).to include_pagination_headers
790 791 792 793
        expect(json_response).to be_an Array
        expect(json_response.size).to eq(1)

        first_user = json_response.first
794 795
        expect(first_user['username']).to eq(user.username)
        expect(first_user['name']).to eq(user.name)
796 797 798 799 800 801
        expect(first_user.keys).to contain_exactly(*%w[name username id state avatar_url web_url])
      end
    end

    context 'when unauthenticated' do
      it_behaves_like 'project users response' do
802
        let(:project) { create(:empty_project, :public) }
803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827
        let(:current_user) { nil }
      end
    end

    context 'when authenticated' do
      context 'valid request' do
        it_behaves_like 'project users response' do
          let(:current_user) { user }
        end
      end

      it 'returns a 404 error if not found' do
        get api('/projects/42/users', user)

        expect(response).to have_http_status(404)
        expect(json_response['message']).to eq('404 Project Not Found')
      end

      it 'returns a 404 error if user is not a member' do
        other_user = create(:user)

        get api("/projects/#{project.id}/users", other_user)

        expect(response).to have_http_status(404)
      end
D
Dmitriy Zaporozhets 已提交
828 829 830
    end
  end

831
  describe 'GET /projects/:id/snippets' do
832 833 834
    before do
      snippet
    end
D
Dmitriy Zaporozhets 已提交
835

836
    it 'returns an array of project snippets' do
837
      get api("/projects/#{project.id}/snippets", user)
838

Z
Z.J. van de Weg 已提交
839
      expect(response).to have_http_status(200)
840
      expect(response).to include_pagination_headers
841 842
      expect(json_response).to be_an Array
      expect(json_response.first['title']).to eq(snippet.title)
N
Nihad Abbasov 已提交
843 844 845
    end
  end

846
  describe 'GET /projects/:id/snippets/:snippet_id' do
847
    it 'returns a project snippet' do
848
      get api("/projects/#{project.id}/snippets/#{snippet.id}", user)
Z
Z.J. van de Weg 已提交
849
      expect(response).to have_http_status(200)
850
      expect(json_response['title']).to eq(snippet.title)
N
Nihad Abbasov 已提交
851
    end
852

853
    it 'returns a 404 error if snippet id not found' do
854
      get api("/projects/#{project.id}/snippets/1234", user)
Z
Z.J. van de Weg 已提交
855
      expect(response).to have_http_status(404)
856
    end
N
Nihad Abbasov 已提交
857 858
  end

859
  describe 'POST /projects/:id/snippets' do
860
    it 'creates a new project snippet' do
861
      post api("/projects/#{project.id}/snippets", user),
862
        title: 'api test', file_name: 'sample.rb', code: 'test', visibility: 'private'
Z
Z.J. van de Weg 已提交
863
      expect(response).to have_http_status(201)
864
      expect(json_response['title']).to eq('api test')
N
Nihad Abbasov 已提交
865
    end
866

867
    it 'returns a 400 error if invalid snippet is given' do
868 869
      post api("/projects/#{project.id}/snippets", user)
      expect(status).to eq(400)
870
    end
N
Nihad Abbasov 已提交
871 872
  end

873
  describe 'PUT /projects/:id/snippets/:snippet_id' do
874
    it 'updates an existing project snippet' do
875
      put api("/projects/#{project.id}/snippets/#{snippet.id}", user),
876
        code: 'updated code'
Z
Z.J. van de Weg 已提交
877
      expect(response).to have_http_status(200)
878 879
      expect(json_response['title']).to eq('example')
      expect(snippet.reload.content).to eq('updated code')
880
    end
881

882
    it 'updates an existing project snippet with new title' do
883
      put api("/projects/#{project.id}/snippets/#{snippet.id}", user),
884
        title: 'other api test'
Z
Z.J. van de Weg 已提交
885
      expect(response).to have_http_status(200)
886
      expect(json_response['title']).to eq('other api test')
887
    end
888 889
  end

890
  describe 'DELETE /projects/:id/snippets/:snippet_id' do
891 892 893
    before do
      snippet
    end
D
Dmitriy Zaporozhets 已提交
894

895
    it 'deletes existing project snippet' do
896
      expect do
897
        delete api("/projects/#{project.id}/snippets/#{snippet.id}", user)
898 899

        expect(response).to have_http_status(204)
900
      end.to change { Snippet.count }.by(-1)
901 902
    end

903
    it 'returns 404 when deleting unknown snippet id' do
904
      delete api("/projects/#{project.id}/snippets/1234", user)
Z
Z.J. van de Weg 已提交
905
      expect(response).to have_http_status(404)
N
Nihad Abbasov 已提交
906 907
    end
  end
908

909
  describe 'GET /projects/:id/snippets/:snippet_id/raw' do
910
    it 'gets a raw project snippet' do
911
      get api("/projects/#{project.id}/snippets/#{snippet.id}/raw", user)
Z
Z.J. van de Weg 已提交
912
      expect(response).to have_http_status(200)
913
    end
914

915
    it 'returns a 404 error if raw project snippet not found' do
916
      get api("/projects/#{project.id}/snippets/5555/raw", user)
Z
Z.J. van de Weg 已提交
917
      expect(response).to have_http_status(404)
918
    end
919
  end
920

921
  describe 'fork management' do
922 923
    let(:project_fork_target) { create(:empty_project) }
    let(:project_fork_source) { create(:empty_project, :public) }
924

925
    describe 'POST /projects/:id/fork/:forked_from_id' do
926
      let(:new_project_fork_source) { create(:empty_project, :public) }
927

928
      it "is not available for non admin users" do
929
        post api("/projects/#{project_fork_target.id}/fork/#{project_fork_source.id}", user)
Z
Z.J. van de Weg 已提交
930
        expect(response).to have_http_status(403)
931 932
      end

933
      it 'allows project to be forked from an existing project' do
934
        expect(project_fork_target.forked?).not_to be_truthy
935
        post api("/projects/#{project_fork_target.id}/fork/#{project_fork_source.id}", admin)
Z
Z.J. van de Weg 已提交
936
        expect(response).to have_http_status(201)
937
        project_fork_target.reload
938 939 940
        expect(project_fork_target.forked_from_project.id).to eq(project_fork_source.id)
        expect(project_fork_target.forked_project_link).not_to be_nil
        expect(project_fork_target.forked?).to be_truthy
941 942
      end

943
      it 'fails if forked_from project which does not exist' do
944
        post api("/projects/#{project_fork_target.id}/fork/9999", admin)
Z
Z.J. van de Weg 已提交
945
        expect(response).to have_http_status(404)
946 947
      end

948
      it 'fails with 409 if already forked' do
949 950
        post api("/projects/#{project_fork_target.id}/fork/#{project_fork_source.id}", admin)
        project_fork_target.reload
951
        expect(project_fork_target.forked_from_project.id).to eq(project_fork_source.id)
952
        post api("/projects/#{project_fork_target.id}/fork/#{new_project_fork_source.id}", admin)
Z
Z.J. van de Weg 已提交
953
        expect(response).to have_http_status(409)
954
        project_fork_target.reload
955 956
        expect(project_fork_target.forked_from_project.id).to eq(project_fork_source.id)
        expect(project_fork_target.forked?).to be_truthy
957 958 959
      end
    end

960
    describe 'DELETE /projects/:id/fork' do
961
      it "is not visible to users outside group" do
962
        delete api("/projects/#{project_fork_target.id}/fork", user)
Z
Z.J. van de Weg 已提交
963
        expect(response).to have_http_status(404)
964 965
      end

966
      context 'when users belong to project group' do
967
        let(:project_fork_target) { create(:empty_project, group: create(:group)) }
968

969 970 971 972 973
        before do
          project_fork_target.group.add_owner user
          project_fork_target.group.add_developer user2
        end

974
        it 'is forbidden to non-owner users' do
975
          delete api("/projects/#{project_fork_target.id}/fork", user2)
Z
Z.J. van de Weg 已提交
976
          expect(response).to have_http_status(403)
977 978
        end

979
        it 'makes forked project unforked' do
980 981 982 983
          post api("/projects/#{project_fork_target.id}/fork/#{project_fork_source.id}", admin)
          project_fork_target.reload
          expect(project_fork_target.forked_from_project).not_to be_nil
          expect(project_fork_target.forked?).to be_truthy
984

985
          delete api("/projects/#{project_fork_target.id}/fork", admin)
986 987

          expect(response).to have_http_status(204)
988 989 990 991 992
          project_fork_target.reload
          expect(project_fork_target.forked_from_project).to be_nil
          expect(project_fork_target.forked?).not_to be_truthy
        end

993
        it 'is idempotent if not forked' do
994 995
          expect(project_fork_target.forked_from_project).to be_nil
          delete api("/projects/#{project_fork_target.id}/fork", admin)
R
Robert Schilling 已提交
996
          expect(response).to have_http_status(304)
997 998
          expect(project_fork_target.reload.forked_from_project).to be_nil
        end
999 1000 1001
      end
    end
  end
1002

1003 1004 1005
  describe "POST /projects/:id/share" do
    let(:group) { create(:group) }

1006
    it "shares project with group" do
1007 1008
      expires_at = 10.days.from_now.to_date

1009
      expect do
1010
        post api("/projects/#{project.id}/share", user), group_id: group.id, group_access: Gitlab::Access::DEVELOPER, expires_at: expires_at
1011 1012
      end.to change { ProjectGroupLink.count }.by(1)

R
Robert Schilling 已提交
1013
      expect(response).to have_http_status(201)
1014 1015 1016
      expect(json_response['group_id']).to eq(group.id)
      expect(json_response['group_access']).to eq(Gitlab::Access::DEVELOPER)
      expect(json_response['expires_at']).to eq(expires_at.to_s)
1017 1018
    end

1019
    it "returns a 400 error when group id is not given" do
1020
      post api("/projects/#{project.id}/share", user), group_access: Gitlab::Access::DEVELOPER
R
Robert Schilling 已提交
1021
      expect(response).to have_http_status(400)
1022 1023
    end

1024
    it "returns a 400 error when access level is not given" do
1025
      post api("/projects/#{project.id}/share", user), group_id: group.id
R
Robert Schilling 已提交
1026
      expect(response).to have_http_status(400)
1027 1028
    end

1029
    it "returns a 400 error when sharing is disabled" do
1030 1031
      project.namespace.update(share_with_group_lock: true)
      post api("/projects/#{project.id}/share", user), group_id: group.id, group_access: Gitlab::Access::DEVELOPER
R
Robert Schilling 已提交
1032
      expect(response).to have_http_status(400)
1033 1034
    end

1035 1036 1037 1038 1039
    it 'returns a 404 error when user cannot read group' do
      private_group = create(:group, :private)

      post api("/projects/#{project.id}/share", user), group_id: private_group.id, group_access: Gitlab::Access::DEVELOPER

R
Robert Schilling 已提交
1040
      expect(response).to have_http_status(404)
1041 1042 1043 1044 1045
    end

    it 'returns a 404 error when group does not exist' do
      post api("/projects/#{project.id}/share", user), group_id: 1234, group_access: Gitlab::Access::DEVELOPER

R
Robert Schilling 已提交
1046
      expect(response).to have_http_status(404)
1047 1048
    end

R
Robert Schilling 已提交
1049
    it "returns a 400 error when wrong params passed" do
1050
      post api("/projects/#{project.id}/share", user), group_id: group.id, group_access: 1234
R
Robert Schilling 已提交
1051 1052 1053

      expect(response).to have_http_status(400)
      expect(json_response['error']).to eq 'group_access does not have a valid value'
1054 1055 1056
    end
  end

1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086
  describe 'DELETE /projects/:id/share/:group_id' do
    it 'returns 204 when deleting a group share' do
      group = create(:group, :public)
      create(:project_group_link, group: group, project: project)

      delete api("/projects/#{project.id}/share/#{group.id}", user)

      expect(response).to have_http_status(204)
      expect(project.project_group_links).to be_empty
    end

    it 'returns a 400 when group id is not an integer' do
      delete api("/projects/#{project.id}/share/foo", user)

      expect(response).to have_http_status(400)
    end

    it 'returns a 404 error when group link does not exist' do
      delete api("/projects/#{project.id}/share/1234", user)

      expect(response).to have_http_status(404)
    end

    it 'returns a 404 error when project does not exist' do
      delete api("/projects/123/share/1234", user)

      expect(response).to have_http_status(404)
    end
  end

1087
  describe 'PUT /projects/:id' do
1088 1089 1090 1091 1092 1093 1094 1095 1096 1097
    before do
      expect(project).to be_persisted
      expect(user).to be_persisted
      expect(user3).to be_persisted
      expect(user4).to be_persisted
      expect(project3).to be_persisted
      expect(project4).to be_persisted
      expect(project_member2).to be_persisted
      expect(project_member).to be_persisted
    end
1098

1099 1100
    it 'returns 400 when nothing sent' do
      project_param = {}
W
winniehell 已提交
1101

1102
      put api("/projects/#{project.id}", user), project_param
W
winniehell 已提交
1103

1104 1105 1106 1107
      expect(response).to have_http_status(400)
      expect(json_response['error']).to match('at least one parameter must be provided')
    end

1108
    context 'when unauthenticated' do
1109
      it 'returns authentication error' do
1110
        project_param = { name: 'bar' }
W
winniehell 已提交
1111

1112
        put api("/projects/#{project.id}"), project_param
W
winniehell 已提交
1113

Z
Z.J. van de Weg 已提交
1114
        expect(response).to have_http_status(401)
1115 1116 1117 1118
      end
    end

    context 'when authenticated as project owner' do
1119
      it 'updates name' do
1120
        project_param = { name: 'bar' }
W
winniehell 已提交
1121

1122
        put api("/projects/#{project.id}", user), project_param
W
winniehell 已提交
1123

Z
Z.J. van de Weg 已提交
1124
        expect(response).to have_http_status(200)
W
winniehell 已提交
1125

1126
        project_param.each_pair do |k, v|
1127
          expect(json_response[k.to_s]).to eq(v)
1128 1129 1130
        end
      end

1131
      it 'updates visibility_level' do
1132
        project_param = { visibility: 'public' }
W
winniehell 已提交
1133

1134
        put api("/projects/#{project3.id}", user), project_param
W
winniehell 已提交
1135

Z
Z.J. van de Weg 已提交
1136
        expect(response).to have_http_status(200)
W
winniehell 已提交
1137

1138
        project_param.each_pair do |k, v|
1139
          expect(json_response[k.to_s]).to eq(v)
1140 1141 1142
        end
      end

1143
      it 'updates visibility_level from public to private' do
1144
        project3.update_attributes({ visibility_level: Gitlab::VisibilityLevel::PUBLIC })
1145
        project_param = { visibility: 'private' }
W
winniehell 已提交
1146

1147
        put api("/projects/#{project3.id}", user), project_param
W
winniehell 已提交
1148

Z
Z.J. van de Weg 已提交
1149
        expect(response).to have_http_status(200)
W
winniehell 已提交
1150

1151 1152 1153
        project_param.each_pair do |k, v|
          expect(json_response[k.to_s]).to eq(v)
        end
W
winniehell 已提交
1154

1155
        expect(json_response['visibility']).to eq('private')
1156 1157
      end

1158
      it 'does not update name to existing name' do
1159
        project_param = { name: project3.name }
W
winniehell 已提交
1160

1161
        put api("/projects/#{project.id}", user), project_param
W
winniehell 已提交
1162

Z
Z.J. van de Weg 已提交
1163
        expect(response).to have_http_status(400)
1164
        expect(json_response['message']['name']).to eq(['has already been taken'])
1165 1166
      end

1167 1168 1169 1170 1171 1172 1173 1174 1175
      it 'updates request_access_enabled' do
        project_param = { request_access_enabled: false }

        put api("/projects/#{project.id}", user), project_param

        expect(response).to have_http_status(200)
        expect(json_response['request_access_enabled']).to eq(false)
      end

1176
      it 'updates path & name to existing path & name in different namespace' do
1177
        project_param = { path: project4.path, name: project4.name }
W
winniehell 已提交
1178

1179
        put api("/projects/#{project3.id}", user), project_param
W
winniehell 已提交
1180

Z
Z.J. van de Weg 已提交
1181
        expect(response).to have_http_status(200)
W
winniehell 已提交
1182

1183
        project_param.each_pair do |k, v|
1184
          expect(json_response[k.to_s]).to eq(v)
1185 1186
        end
      end
W
winniehell 已提交
1187 1188 1189

      it 'updates jobs_enabled' do
        project_param = { jobs_enabled: true }
W
winniehell 已提交
1190

W
winniehell 已提交
1191
        put api("/projects/#{project3.id}", user), project_param
W
winniehell 已提交
1192

W
winniehell 已提交
1193
        expect(response).to have_http_status(200)
W
winniehell 已提交
1194

W
winniehell 已提交
1195 1196 1197 1198
        project_param.each_pair do |k, v|
          expect(json_response[k.to_s]).to eq(v)
        end
      end
1199 1200 1201
    end

    context 'when authenticated as project master' do
1202
      it 'updates path' do
1203 1204
        project_param = { path: 'bar' }
        put api("/projects/#{project3.id}", user4), project_param
Z
Z.J. van de Weg 已提交
1205
        expect(response).to have_http_status(200)
1206
        project_param.each_pair do |k, v|
1207
          expect(json_response[k.to_s]).to eq(v)
1208 1209 1210
        end
      end

1211
      it 'updates other attributes' do
1212 1213 1214 1215 1216 1217 1218
        project_param = { issues_enabled: true,
                          wiki_enabled: true,
                          snippets_enabled: true,
                          merge_requests_enabled: true,
                          description: 'new description' }

        put api("/projects/#{project3.id}", user4), project_param
Z
Z.J. van de Weg 已提交
1219
        expect(response).to have_http_status(200)
1220
        project_param.each_pair do |k, v|
1221
          expect(json_response[k.to_s]).to eq(v)
1222 1223 1224
        end
      end

1225
      it 'does not update path to existing path' do
1226 1227
        project_param = { path: project.path }
        put api("/projects/#{project3.id}", user4), project_param
Z
Z.J. van de Weg 已提交
1228
        expect(response).to have_http_status(400)
1229
        expect(json_response['message']['path']).to eq(['has already been taken'])
1230 1231
      end

1232
      it 'does not update name' do
1233 1234
        project_param = { name: 'bar' }
        put api("/projects/#{project3.id}", user4), project_param
Z
Z.J. van de Weg 已提交
1235
        expect(response).to have_http_status(403)
1236 1237
      end

1238
      it 'does not update visibility_level' do
1239
        project_param = { visibility: 'public' }
1240
        put api("/projects/#{project3.id}", user4), project_param
Z
Z.J. van de Weg 已提交
1241
        expect(response).to have_http_status(403)
1242 1243 1244 1245
      end
    end

    context 'when authenticated as project developer' do
1246
      it 'does not update other attributes' do
1247 1248 1249 1250 1251
        project_param = { path: 'bar',
                          issues_enabled: true,
                          wiki_enabled: true,
                          snippets_enabled: true,
                          merge_requests_enabled: true,
1252 1253
                          description: 'new description',
                          request_access_enabled: true }
1254
        put api("/projects/#{project.id}", user3), project_param
Z
Z.J. van de Weg 已提交
1255
        expect(response).to have_http_status(403)
1256 1257 1258 1259
      end
    end
  end

1260
  describe 'POST /projects/:id/archive' do
1261 1262
    context 'on an unarchived project' do
      it 'archives the project' do
1263
        post api("/projects/#{project.id}/archive", user)
1264

Z
Z.J. van de Weg 已提交
1265
        expect(response).to have_http_status(201)
1266 1267 1268 1269 1270 1271 1272 1273 1274 1275
        expect(json_response['archived']).to be_truthy
      end
    end

    context 'on an archived project' do
      before do
        project.archive!
      end

      it 'remains archived' do
1276
        post api("/projects/#{project.id}/archive", user)
1277

Z
Z.J. van de Weg 已提交
1278
        expect(response).to have_http_status(201)
1279 1280
        expect(json_response['archived']).to be_truthy
      end
1281
    end
1282

1283 1284 1285 1286
    context 'user without archiving rights to the project' do
      before do
        project.team << [user3, :developer]
      end
1287

1288 1289 1290
      it 'rejects the action' do
        post api("/projects/#{project.id}/archive", user3)

Z
Z.J. van de Weg 已提交
1291
        expect(response).to have_http_status(403)
1292 1293 1294 1295
      end
    end
  end

1296
  describe 'POST /projects/:id/unarchive' do
1297 1298
    context 'on an unarchived project' do
      it 'remains unarchived' do
1299
        post api("/projects/#{project.id}/unarchive", user)
1300

Z
Z.J. van de Weg 已提交
1301
        expect(response).to have_http_status(201)
1302 1303 1304 1305 1306 1307 1308 1309 1310
        expect(json_response['archived']).to be_falsey
      end
    end

    context 'on an archived project' do
      before do
        project.archive!
      end

1311 1312
      it 'unarchives the project' do
        post api("/projects/#{project.id}/unarchive", user)
1313

Z
Z.J. van de Weg 已提交
1314
        expect(response).to have_http_status(201)
1315 1316
        expect(json_response['archived']).to be_falsey
      end
1317
    end
1318

1319 1320 1321 1322
    context 'user without archiving rights to the project' do
      before do
        project.team << [user3, :developer]
      end
1323

1324 1325 1326
      it 'rejects the action' do
        post api("/projects/#{project.id}/unarchive", user3)

Z
Z.J. van de Weg 已提交
1327
        expect(response).to have_http_status(403)
1328 1329 1330 1331
      end
    end
  end

1332 1333 1334
  describe 'POST /projects/:id/star' do
    context 'on an unstarred project' do
      it 'stars the project' do
1335
        expect { post api("/projects/#{project.id}/star", user) }.to change { project.reload.star_count }.by(1)
1336

Z
Z.J. van de Weg 已提交
1337
        expect(response).to have_http_status(201)
1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348
        expect(json_response['star_count']).to eq(1)
      end
    end

    context 'on a starred project' do
      before do
        user.toggle_star(project)
        project.reload
      end

      it 'does not modify the star count' do
1349
        expect { post api("/projects/#{project.id}/star", user) }.not_to change { project.reload.star_count }
1350

Z
Z.J. van de Weg 已提交
1351
        expect(response).to have_http_status(304)
1352 1353 1354 1355
      end
    end
  end

1356
  describe 'POST /projects/:id/unstar' do
1357 1358 1359 1360 1361 1362 1363
    context 'on a starred project' do
      before do
        user.toggle_star(project)
        project.reload
      end

      it 'unstars the project' do
1364
        expect { post api("/projects/#{project.id}/unstar", user) }.to change { project.reload.star_count }.by(-1)
1365

1366
        expect(response).to have_http_status(201)
1367 1368 1369 1370 1371 1372
        expect(json_response['star_count']).to eq(0)
      end
    end

    context 'on an unstarred project' do
      it 'does not modify the star count' do
1373
        expect { post api("/projects/#{project.id}/unstar", user) }.not_to change { project.reload.star_count }
1374

Z
Z.J. van de Weg 已提交
1375
        expect(response).to have_http_status(304)
1376 1377 1378 1379
      end
    end
  end

1380 1381
  describe 'DELETE /projects/:id' do
    context 'when authenticated as user' do
1382
      it 'removes project' do
1383
        delete api("/projects/#{project.id}", user)
1384 1385 1386

        expect(response).to have_http_status(202)
        expect(json_response['message']).to eql('202 Accepted')
1387 1388
      end

1389
      it 'does not remove a project if not an owner' do
1390 1391 1392
        user3 = create(:user)
        project.team << [user3, :developer]
        delete api("/projects/#{project.id}", user3)
Z
Z.J. van de Weg 已提交
1393
        expect(response).to have_http_status(403)
1394 1395
      end

1396
      it 'does not remove a non existing project' do
1397
        delete api('/projects/1328', user)
Z
Z.J. van de Weg 已提交
1398
        expect(response).to have_http_status(404)
1399 1400
      end

1401
      it 'does not remove a project not attached to user' do
1402
        delete api("/projects/#{project.id}", user2)
Z
Z.J. van de Weg 已提交
1403
        expect(response).to have_http_status(404)
1404 1405 1406
      end
    end

1407
    context 'when authenticated as admin' do
1408
      it 'removes any existing project' do
1409
        delete api("/projects/#{project.id}", admin)
1410 1411 1412

        expect(response).to have_http_status(202)
        expect(json_response['message']).to eql('202 Accepted')
1413 1414
      end

1415
      it 'does not remove a non existing project' do
1416
        delete api('/projects/1328', admin)
Z
Z.J. van de Weg 已提交
1417
        expect(response).to have_http_status(404)
1418 1419 1420
      end
    end
  end
1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446

  describe 'POST /projects/:id/fork' do
    let(:project) do
      create(:project, :repository, creator: user, namespace: user.namespace)
    end
    let(:group) { create(:group) }
    let(:group2) do
      group = create(:group, name: 'group2_name')
      group.add_owner(user2)
      group
    end

    before do
      project.add_reporter(user2)
    end

    context 'when authenticated' do
      it 'forks if user has sufficient access to project' do
        post api("/projects/#{project.id}/fork", user2)

        expect(response).to have_http_status(201)
        expect(json_response['name']).to eq(project.name)
        expect(json_response['path']).to eq(project.path)
        expect(json_response['owner']['id']).to eq(user2.id)
        expect(json_response['namespace']['id']).to eq(user2.namespace.id)
        expect(json_response['forked_from_project']['id']).to eq(project.id)
R
Rémy Coutable 已提交
1447
        expect(json_response['import_status']).to eq('scheduled')
1448
        expect(json_response).to include("import_error")
1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459
      end

      it 'forks if user is admin' do
        post api("/projects/#{project.id}/fork", admin)

        expect(response).to have_http_status(201)
        expect(json_response['name']).to eq(project.name)
        expect(json_response['path']).to eq(project.path)
        expect(json_response['owner']['id']).to eq(admin.id)
        expect(json_response['namespace']['id']).to eq(admin.namespace.id)
        expect(json_response['forked_from_project']['id']).to eq(project.id)
R
Rémy Coutable 已提交
1460
        expect(json_response['import_status']).to eq('scheduled')
1461
        expect(json_response).to include("import_error")
1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550
      end

      it 'fails on missing project access for the project to fork' do
        new_user = create(:user)
        post api("/projects/#{project.id}/fork", new_user)

        expect(response).to have_http_status(404)
        expect(json_response['message']).to eq('404 Project Not Found')
      end

      it 'fails if forked project exists in the user namespace' do
        post api("/projects/#{project.id}/fork", user)

        expect(response).to have_http_status(409)
        expect(json_response['message']['name']).to eq(['has already been taken'])
        expect(json_response['message']['path']).to eq(['has already been taken'])
      end

      it 'fails if project to fork from does not exist' do
        post api('/projects/424242/fork', user)

        expect(response).to have_http_status(404)
        expect(json_response['message']).to eq('404 Project Not Found')
      end

      it 'forks with explicit own user namespace id' do
        post api("/projects/#{project.id}/fork", user2), namespace: user2.namespace.id

        expect(response).to have_http_status(201)
        expect(json_response['owner']['id']).to eq(user2.id)
      end

      it 'forks with explicit own user name as namespace' do
        post api("/projects/#{project.id}/fork", user2), namespace: user2.username

        expect(response).to have_http_status(201)
        expect(json_response['owner']['id']).to eq(user2.id)
      end

      it 'forks to another user when admin' do
        post api("/projects/#{project.id}/fork", admin), namespace: user2.username

        expect(response).to have_http_status(201)
        expect(json_response['owner']['id']).to eq(user2.id)
      end

      it 'fails if trying to fork to another user when not admin' do
        post api("/projects/#{project.id}/fork", user2), namespace: admin.namespace.id

        expect(response).to have_http_status(404)
      end

      it 'fails if trying to fork to non-existent namespace' do
        post api("/projects/#{project.id}/fork", user2), namespace: 42424242

        expect(response).to have_http_status(404)
        expect(json_response['message']).to eq('404 Target Namespace Not Found')
      end

      it 'forks to owned group' do
        post api("/projects/#{project.id}/fork", user2), namespace: group2.name

        expect(response).to have_http_status(201)
        expect(json_response['namespace']['name']).to eq(group2.name)
      end

      it 'fails to fork to not owned group' do
        post api("/projects/#{project.id}/fork", user2), namespace: group.name

        expect(response).to have_http_status(404)
      end

      it 'forks to not owned group when admin' do
        post api("/projects/#{project.id}/fork", admin), namespace: group.name

        expect(response).to have_http_status(201)
        expect(json_response['namespace']['name']).to eq(group.name)
      end
    end

    context 'when unauthenticated' do
      it 'returns authentication error' do
        post api("/projects/#{project.id}/fork")

        expect(response).to have_http_status(401)
        expect(json_response['message']).to eq('401 Unauthorized')
      end
    end
  end
1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581

  describe 'POST /projects/:id/housekeeping' do
    let(:housekeeping) { Projects::HousekeepingService.new(project) }

    before do
      allow(Projects::HousekeepingService).to receive(:new).with(project).and_return(housekeeping)
    end

    context 'when authenticated as owner' do
      it 'starts the housekeeping process' do
        expect(housekeeping).to receive(:execute).once

        post api("/projects/#{project.id}/housekeeping", user)

        expect(response).to have_http_status(201)
      end

      context 'when housekeeping lease is taken' do
        it 'returns conflict' do
          expect(housekeeping).to receive(:execute).once.and_raise(Projects::HousekeepingService::LeaseTaken)

          post api("/projects/#{project.id}/housekeeping", user)

          expect(response).to have_http_status(409)
          expect(json_response['message']).to match(/Somebody already triggered housekeeping for this project/)
        end
      end
    end

    context 'when authenticated as developer' do
      before do
1582
        project_member
1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599
      end

      it 'returns forbidden error' do
        post api("/projects/#{project.id}/housekeeping", user3)

        expect(response).to have_http_status(403)
      end
    end

    context 'when unauthenticated' do
      it 'returns authentication error' do
        post api("/projects/#{project.id}/housekeeping")

        expect(response).to have_http_status(401)
      end
    end
  end
N
Nihad Abbasov 已提交
1600
end