Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
578adc9b
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
578adc9b
编写于
6月 02, 2017
作者:
A
Athar Hameed
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix missing optional path parameter in "Create project for user" API
上级
5cb8ad6c
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
26 addition
and
5 deletion
+26
-5
changelogs/unreleased/33242-create-project-for-user-api-ignores-path-parameter.yml
...42-create-project-for-user-api-ignores-path-parameter.yml
+4
-0
lib/api/projects.rb
lib/api/projects.rb
+1
-0
spec/requests/api/projects_spec.rb
spec/requests/api/projects_spec.rb
+21
-5
未找到文件。
changelogs/unreleased/33242-create-project-for-user-api-ignores-path-parameter.yml
0 → 100644
浏览文件 @
578adc9b
---
title
:
Fix missing optional path parameter in "Create project for user" API
merge_request
:
11868
author
:
lib/api/projects.rb
浏览文件 @
578adc9b
...
...
@@ -129,6 +129,7 @@ module API
params
do
requires
:name
,
type:
String
,
desc:
'The name of the project'
requires
:user_id
,
type:
Integer
,
desc:
'The ID of a user'
optional
:path
,
type:
String
,
desc:
'The path of the repository'
optional
:default_branch
,
type:
String
,
desc:
'The default branch of the project'
use
:optional_params
use
:create_params
...
...
spec/requests/api/projects_spec.rb
浏览文件 @
578adc9b
...
...
@@ -316,15 +316,15 @@ describe API::Projects do
expect
(
project
.
path
).
to
eq
(
'foo_project'
)
end
it
'creates new project name and path and returns 201'
do
expect
{
post
api
(
'/projects'
,
user
),
path:
'
foo-Project
'
,
name:
'Foo Project'
}.
it
'creates new project
with
name and path and returns 201'
do
expect
{
post
api
(
'/projects'
,
user
),
path:
'
path-project-Foo
'
,
name:
'Foo Project'
}.
to
change
{
Project
.
count
}.
by
(
1
)
expect
(
response
).
to
have_http_status
(
201
)
project
=
Project
.
first
expect
(
project
.
name
).
to
eq
(
'Foo Project'
)
expect
(
project
.
path
).
to
eq
(
'
foo-Project
'
)
expect
(
project
.
path
).
to
eq
(
'
path-project-Foo
'
)
end
it
'creates last project before reaching project limit'
do
...
...
@@ -470,9 +470,25 @@ describe API::Projects do
before
{
project
}
before
{
admin
}
it
'creates new project without path and return 201'
do
expect
{
post
api
(
"/projects/user/
#{
user
.
id
}
"
,
admin
),
name:
'
foo
'
}.
to
change
{
Project
.
count
}.
by
(
1
)
it
'creates new project without path
but with name
and return 201'
do
expect
{
post
api
(
"/projects/user/
#{
user
.
id
}
"
,
admin
),
name:
'
Foo Project
'
}.
to
change
{
Project
.
count
}.
by
(
1
)
expect
(
response
).
to
have_http_status
(
201
)
project
=
Project
.
first
expect
(
project
.
name
).
to
eq
(
'Foo Project'
)
expect
(
project
.
path
).
to
eq
(
'foo-project'
)
end
it
'creates new project with name and path and returns 201'
do
expect
{
post
api
(
"/projects/user/
#{
user
.
id
}
"
,
admin
),
path:
'path-project-Foo'
,
name:
'Foo Project'
}.
to
change
{
Project
.
count
}.
by
(
1
)
expect
(
response
).
to
have_http_status
(
201
)
project
=
Project
.
first
expect
(
project
.
name
).
to
eq
(
'Foo Project'
)
expect
(
project
.
path
).
to
eq
(
'path-project-Foo'
)
end
it
'responds with 400 on failure and not project'
do
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录