builtin-log.c 18.5 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11
/*
 * Builtin "git log" and related commands (show, whatchanged)
 *
 * (C) Copyright 2006 Linus Torvalds
 *		 2006 Junio Hamano
 */
#include "cache.h"
#include "commit.h"
#include "diff.h"
#include "revision.h"
#include "log-tree.h"
12
#include "builtin.h"
13
#include "tag.h"
L
Linus Torvalds 已提交
14
#include "reflog-walk.h"
15

16 17
static int default_show_root = 1;

18 19 20
/* this is in builtin-diff.c */
void add_head(struct rev_info *revs);

21
static void cmd_log_init(int argc, const char **argv, const char *prefix,
22 23
		      struct rev_info *rev)
{
J
Junio C Hamano 已提交
24 25
	int i;

26 27 28
	rev->abbrev = DEFAULT_ABBREV;
	rev->commit_format = CMIT_FMT_DEFAULT;
	rev->verbose_header = 1;
29
	rev->show_root_diff = default_show_root;
30
	argc = setup_revisions(argc, argv, rev, "HEAD");
31 32
	if (rev->diffopt.pickaxe || rev->diffopt.filter)
		rev->always_show_header = 0;
J
Junio C Hamano 已提交
33 34
	for (i = 1; i < argc; i++) {
		const char *arg = argv[i];
35
		if (!prefixcmp(arg, "--encoding=")) {
J
Junio C Hamano 已提交
36 37
			arg += 11;
			if (strcmp(arg, "none"))
38
				git_log_output_encoding = xstrdup(arg);
J
Junio C Hamano 已提交
39
			else
40
				git_log_output_encoding = "";
J
Junio C Hamano 已提交
41 42 43 44
		}
		else
			die("unrecognized argument: %s", arg);
	}
45 46 47 48 49
}

static int cmd_log_walk(struct rev_info *rev)
{
	struct commit *commit;
50 51 52 53

	prepare_revision_walk(rev);
	while ((commit = get_revision(rev)) != NULL) {
		log_tree_commit(rev, commit);
54 55 56 57 58
		if (!rev->reflog_info) {
			/* we allow cycles in reflog ancestry */
			free(commit->buffer);
			commit->buffer = NULL;
		}
L
Linus Torvalds 已提交
59 60
		free_commit_list(commit->parents);
		commit->parents = NULL;
61 62 63 64
	}
	return 0;
}

65 66 67 68 69 70 71 72 73
static int git_log_config(const char *var, const char *value)
{
	if (!strcmp(var, "log.showroot")) {
		default_show_root = git_config_bool(var, value);
		return 0;
	}
	return git_diff_ui_config(var, value);
}

74
int cmd_whatchanged(int argc, const char **argv, const char *prefix)
75 76 77
{
	struct rev_info rev;

78
	git_config(git_log_config);
79
	init_revisions(&rev, prefix);
80 81
	rev.diff = 1;
	rev.diffopt.recursive = 1;
L
Linus Torvalds 已提交
82
	rev.simplify_history = 0;
83
	cmd_log_init(argc, argv, prefix, &rev);
84 85 86
	if (!rev.diffopt.output_format)
		rev.diffopt.output_format = DIFF_FORMAT_RAW;
	return cmd_log_walk(&rev);
87 88
}

89 90 91
static int show_object(const unsigned char *sha1, int suppress_header)
{
	unsigned long size;
92 93
	enum object_type type;
	char *buf = read_sha1_file(sha1, &type, &size);
94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120
	int offset = 0;

	if (!buf)
		return error("Could not read object %s", sha1_to_hex(sha1));

	if (suppress_header)
		while (offset < size && buf[offset++] != '\n') {
			int new_offset = offset;
			while (new_offset < size && buf[new_offset++] != '\n')
				; /* do nothing */
			offset = new_offset;
		}

	if (offset < size)
		fwrite(buf + offset, size - offset, 1, stdout);
	free(buf);
	return 0;
}

static int show_tree_object(const unsigned char *sha1,
		const char *base, int baselen,
		const char *pathname, unsigned mode, int stage)
{
	printf("%s%s\n", pathname, S_ISDIR(mode) ? "/" : "");
	return 0;
}

121
int cmd_show(int argc, const char **argv, const char *prefix)
122 123
{
	struct rev_info rev;
124 125
	struct object_array_entry *objects;
	int i, count, ret = 0;
126

127
	git_config(git_log_config);
128
	init_revisions(&rev, prefix);
129 130 131 132 133 134 135
	rev.diff = 1;
	rev.diffopt.recursive = 1;
	rev.combine_merges = 1;
	rev.dense_combined_merges = 1;
	rev.always_show_header = 1;
	rev.ignore_merges = 0;
	rev.no_walk = 1;
136
	cmd_log_init(argc, argv, prefix, &rev);
137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182

	count = rev.pending.nr;
	objects = rev.pending.objects;
	for (i = 0; i < count && !ret; i++) {
		struct object *o = objects[i].item;
		const char *name = objects[i].name;
		switch (o->type) {
		case OBJ_BLOB:
			ret = show_object(o->sha1, 0);
			break;
		case OBJ_TAG: {
			struct tag *t = (struct tag *)o;

			printf("%stag %s%s\n\n",
					diff_get_color(rev.diffopt.color_diff,
						DIFF_COMMIT),
					t->tag,
					diff_get_color(rev.diffopt.color_diff,
						DIFF_RESET));
			ret = show_object(o->sha1, 1);
			objects[i].item = (struct object *)t->tagged;
			i--;
			break;
		}
		case OBJ_TREE:
			printf("%stree %s%s\n\n",
					diff_get_color(rev.diffopt.color_diff,
						DIFF_COMMIT),
					name,
					diff_get_color(rev.diffopt.color_diff,
						DIFF_RESET));
			read_tree_recursive((struct tree *)o, "", 0, 0, NULL,
					show_tree_object);
			break;
		case OBJ_COMMIT:
			rev.pending.nr = rev.pending.alloc = 0;
			rev.pending.objects = NULL;
			add_object_array(o, name, &rev.pending);
			ret = cmd_log_walk(&rev);
			break;
		default:
			ret = error("Unknown type: %d", o->type);
		}
	}
	free(objects);
	return ret;
183 184
}

L
Linus Torvalds 已提交
185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215
/*
 * This is equivalent to "git log -g --abbrev-commit --pretty=oneline"
 */
int cmd_log_reflog(int argc, const char **argv, const char *prefix)
{
	struct rev_info rev;

	git_config(git_log_config);
	init_revisions(&rev, prefix);
	init_reflog_walk(&rev.reflog_info);
	rev.abbrev_commit = 1;
	rev.verbose_header = 1;
	cmd_log_init(argc, argv, prefix, &rev);

	/*
	 * This means that we override whatever commit format the user gave
	 * on the cmd line.  Sad, but cmd_log_init() currently doesn't
	 * allow us to set a different default.
	 */
	rev.commit_format = CMIT_FMT_ONELINE;
	rev.always_show_header = 1;

	/*
	 * We get called through "git reflog", so unlike the other log
	 * routines, we need to set up our pager manually..
	 */
	setup_pager();

	return cmd_log_walk(&rev);
}

216
int cmd_log(int argc, const char **argv, const char *prefix)
217 218 219
{
	struct rev_info rev;

220
	git_config(git_log_config);
221
	init_revisions(&rev, prefix);
222
	rev.always_show_header = 1;
223
	cmd_log_init(argc, argv, prefix, &rev);
224
	return cmd_log_walk(&rev);
225
}
226

227 228 229
/* format-patch */
#define FORMAT_PATCH_NAME_MAX 64

230 231 232 233 234 235
static int istitlechar(char c)
{
	return (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z') ||
		(c >= '0' && c <= '9') || c == '.' || c == '_';
}

236 237
static char *extra_headers = NULL;
static int extra_headers_size = 0;
238
static const char *fmt_patch_suffix = ".patch";
239 240 241 242

static int git_format_config(const char *var, const char *value)
{
	if (!strcmp(var, "format.headers")) {
243 244 245 246 247
		int len;

		if (!value)
			die("format.headers without value");
		len = strlen(value);
248
		extra_headers_size += len + 1;
J
Jonas Fonseca 已提交
249
		extra_headers = xrealloc(extra_headers, extra_headers_size);
250 251 252 253
		extra_headers[extra_headers_size - len - 1] = 0;
		strcat(extra_headers, value);
		return 0;
	}
254 255 256 257 258 259
	if (!strcmp(var, "format.suffix")) {
		if (!value)
			die("format.suffix without value");
		fmt_patch_suffix = xstrdup(value);
		return 0;
	}
260
	if (!strcmp(var, "diff.color") || !strcmp(var, "color.diff")) {
261 262
		return 0;
	}
263
	return git_log_config(var, value);
264 265 266
}


267
static FILE *realstdout = NULL;
268
static const char *output_directory = NULL;
269

270
static int reopen_stdout(struct commit *commit, int nr, int keep_subject)
271
{
272
	char filename[PATH_MAX];
273
	char *sol;
274
	int len = 0;
275
	int suffix_len = strlen(fmt_patch_suffix) + 1;
276

277
	if (output_directory) {
278 279 280 281
		if (strlen(output_directory) >=
		    sizeof(filename) - FORMAT_PATCH_NAME_MAX - suffix_len)
			return error("name of output directory is too long");
		strlcpy(filename, output_directory, sizeof(filename) - suffix_len);
282 283 284 285
		len = strlen(filename);
		if (filename[len - 1] != '/')
			filename[len++] = '/';
	}
286

287
	sprintf(filename + len, "%04d", nr);
288 289 290 291 292 293 294 295
	len = strlen(filename);

	sol = strstr(commit->buffer, "\n\n");
	if (sol) {
		int j, space = 1;

		sol += 2;
		/* strip [PATCH] or [PATCH blabla] */
296
		if (!keep_subject && !prefixcmp(sol, "[PATCH")) {
297 298 299 300 301 302 303 304
			char *eos = strchr(sol + 6, ']');
			if (eos) {
				while (isspace(*eos))
					eos++;
				sol = eos;
			}
		}

305
		for (j = 0;
306 307
		     j < FORMAT_PATCH_NAME_MAX - suffix_len - 5 &&
			     len < sizeof(filename) - suffix_len &&
308 309
			     sol[j] && sol[j] != '\n';
		     j++) {
310 311 312 313 314 315 316 317 318 319 320 321 322 323
			if (istitlechar(sol[j])) {
				if (space) {
					filename[len++] = '-';
					space = 0;
				}
				filename[len++] = sol[j];
				if (sol[j] == '.')
					while (sol[j + 1] == '.')
						j++;
			} else
				space = 1;
		}
		while (filename[len - 1] == '.' || filename[len - 1] == '-')
			len--;
324
		filename[len] = 0;
325
	}
326 327
	if (len + suffix_len >= sizeof(filename))
		return error("Patch pathname too long");
328
	strcpy(filename + len, fmt_patch_suffix);
329
	fprintf(realstdout, "%s\n", filename);
330 331 332 333
	if (freopen(filename, "w", stdout) == NULL)
		return error("Cannot open patch file %s",filename);
	return 0;

334 335
}

336 337 338
static int get_patch_id(struct commit *commit, struct diff_options *options,
		unsigned char *sha1)
{
R
Rene Scharfe 已提交
339 340 341 342 343
	if (commit->parents)
		diff_tree_sha1(commit->parents->item->object.sha1,
		               commit->object.sha1, "", options);
	else
		diff_root_tree_sha1(commit->object.sha1, "", options);
344 345 346 347
	diffcore_std(options);
	return diff_flush_patch_id(options, sha1);
}

348
static void get_patch_ids(struct rev_info *rev, struct diff_options *options, const char *prefix)
349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372
{
	struct rev_info check_rev;
	struct commit *commit;
	struct object *o1, *o2;
	unsigned flags1, flags2;
	unsigned char sha1[20];

	if (rev->pending.nr != 2)
		die("Need exactly one range.");

	o1 = rev->pending.objects[0].item;
	flags1 = o1->flags;
	o2 = rev->pending.objects[1].item;
	flags2 = o2->flags;

	if ((flags1 & UNINTERESTING) == (flags2 & UNINTERESTING))
		die("Not a range.");

	diff_setup(options);
	options->recursive = 1;
	if (diff_setup_done(options) < 0)
		die("diff_setup_done failed");

	/* given a range a..b get all patch ids for b..a */
373
	init_revisions(&check_rev, prefix);
374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
	o1->flags ^= UNINTERESTING;
	o2->flags ^= UNINTERESTING;
	add_pending_object(&check_rev, o1, "o1");
	add_pending_object(&check_rev, o2, "o2");
	prepare_revision_walk(&check_rev);

	while ((commit = get_revision(&check_rev)) != NULL) {
		/* ignore merges */
		if (commit->parents && commit->parents->next)
			continue;

		if (!get_patch_id(commit, options, sha1))
			created_object(sha1, xcalloc(1, sizeof(struct object)));
	}

	/* reset for next revision walk */
390 391 392 393
	clear_commit_marks((struct commit *)o1,
			SEEN | UNINTERESTING | SHOWN | ADDED);
	clear_commit_marks((struct commit *)o2,
			SEEN | UNINTERESTING | SHOWN | ADDED);
394 395 396 397
	o1->flags = flags1;
	o2->flags = flags2;
}

398 399
static void gen_message_id(char *dest, unsigned int length, char *base)
{
400
	const char *committer = git_committer_info(-1);
401 402 403 404
	const char *email_start = strrchr(committer, '<');
	const char *email_end = strrchr(committer, '>');
	if(!email_start || !email_end || email_start > email_end - 1)
		die("Could not extract email from committer identity.");
405 406 407
	snprintf(dest, length, "%s.%lu.git.%.*s", base,
		 (unsigned long) time(NULL),
		 (int)(email_end - email_start - 1), email_start + 1);
408 409
}

410
int cmd_format_patch(int argc, const char **argv, const char *prefix)
411 412 413 414
{
	struct commit *commit;
	struct commit **list = NULL;
	struct rev_info rev;
415
	int nr = 0, total, i, j;
416
	int use_stdout = 0;
417
	int numbered = 0;
418
	int start_number = -1;
419
	int keep_subject = 0;
420
	int subject_prefix = 0;
421
	int ignore_if_in_upstream = 0;
422
	int thread = 0;
423
	const char *in_reply_to = NULL;
424
	struct diff_options patch_id_opts;
J
Junio C Hamano 已提交
425
	char *add_signoff = NULL;
426 427
	char message_id[1024];
	char ref_message_id[1024];
428

429
	git_config(git_format_config);
430
	init_revisions(&rev, prefix);
431 432 433 434 435
	rev.commit_format = CMIT_FMT_EMAIL;
	rev.verbose_header = 1;
	rev.diff = 1;
	rev.combine_merges = 0;
	rev.ignore_merges = 1;
436 437
	rev.diffopt.msg_sep = "";
	rev.diffopt.recursive = 1;
438
	rev.subject_prefix = "PATCH";
439

440 441
	rev.extra_headers = extra_headers;

442 443 444 445 446 447 448
	/*
	 * Parse the arguments before setup_revisions(), or something
	 * like "git fmt-patch -o a123 HEAD^.." may fail; a123 is
	 * possibly a valid SHA1.
	 */
	for (i = 1, j = 1; i < argc; i++) {
		if (!strcmp(argv[i], "--stdout"))
449
			use_stdout = 1;
450 451 452
		else if (!strcmp(argv[i], "-n") ||
				!strcmp(argv[i], "--numbered"))
			numbered = 1;
453
		else if (!prefixcmp(argv[i], "--start-number="))
454 455 456 457 458 459
			start_number = strtol(argv[i] + 15, NULL, 10);
		else if (!strcmp(argv[i], "--start-number")) {
			i++;
			if (i == argc)
				die("Need a number for --start-number");
			start_number = strtol(argv[i], NULL, 10);
J
Junio C Hamano 已提交
460 461
		}
		else if (!strcmp(argv[i], "-k") ||
462 463 464
				!strcmp(argv[i], "--keep-subject")) {
			keep_subject = 1;
			rev.total = -1;
J
Junio C Hamano 已提交
465
		}
466 467
		else if (!strcmp(argv[i], "--output-directory") ||
			 !strcmp(argv[i], "-o")) {
468
			i++;
469 470 471 472 473
			if (argc <= i)
				die("Which directory?");
			if (output_directory)
				die("Two output directories?");
			output_directory = argv[i];
474
		}
J
Junio C Hamano 已提交
475 476
		else if (!strcmp(argv[i], "--signoff") ||
			 !strcmp(argv[i], "-s")) {
E
Eric W. Biederman 已提交
477 478 479 480
			const char *committer;
			const char *endpos;
			committer = git_committer_info(1);
			endpos = strchr(committer, '>');
J
Junio C Hamano 已提交
481 482 483 484 485 486
			if (!endpos)
				die("bogos committer info %s\n", committer);
			add_signoff = xmalloc(endpos - committer + 2);
			memcpy(add_signoff, committer, endpos - committer + 1);
			add_signoff[endpos - committer + 1] = 0;
		}
487
		else if (!strcmp(argv[i], "--attach")) {
488
			rev.mime_boundary = git_version_string;
489 490 491 492 493 494 495 496 497 498 499
			rev.no_inline = 1;
		}
		else if (!prefixcmp(argv[i], "--attach=")) {
			rev.mime_boundary = argv[i] + 9;
			rev.no_inline = 1;
		}
		else if (!strcmp(argv[i], "--inline")) {
			rev.mime_boundary = git_version_string;
			rev.no_inline = 0;
		}
		else if (!prefixcmp(argv[i], "--inline=")) {
500
			rev.mime_boundary = argv[i] + 9;
501 502
			rev.no_inline = 0;
		}
503 504
		else if (!strcmp(argv[i], "--ignore-if-in-upstream"))
			ignore_if_in_upstream = 1;
505 506
		else if (!strcmp(argv[i], "--thread"))
			thread = 1;
507
		else if (!prefixcmp(argv[i], "--in-reply-to="))
508 509 510 511 512 513
			in_reply_to = argv[i] + 14;
		else if (!strcmp(argv[i], "--in-reply-to")) {
			i++;
			if (i == argc)
				die("Need a Message-Id for --in-reply-to");
			in_reply_to = argv[i];
514 515 516 517
		} else if (!prefixcmp(argv[i], "--subject-prefix=")) {
			subject_prefix = 1;
			rev.subject_prefix = argv[i] + 17;
		} else if (!prefixcmp(argv[i], "--suffix="))
518
			fmt_patch_suffix = argv[i] + 9;
519
		else
520
			argv[j++] = argv[i];
521
	}
522 523
	argc = j;

524
	if (start_number < 0)
525
		start_number = 1;
526
	if (numbered && keep_subject)
527
		die ("-n and -k are mutually exclusive.");
528 529
	if (keep_subject && subject_prefix)
		die ("--subject-prefix and -k are mutually exclusive.");
530

531 532 533
	argc = setup_revisions(argc, argv, &rev, "HEAD");
	if (argc > 1)
		die ("unrecognized argument: %s", argv[1]);
534

535
	if (!rev.diffopt.output_format)
536
		rev.diffopt.output_format = DIFF_FORMAT_DIFFSTAT | DIFF_FORMAT_SUMMARY | DIFF_FORMAT_PATCH;
537

538 539 540
	if (!rev.diffopt.text)
		rev.diffopt.binary = 1;

541
	if (!output_directory && !use_stdout)
542 543
		output_directory = prefix;

544 545 546 547 548 549 550 551
	if (output_directory) {
		if (use_stdout)
			die("standard output, or directory, which one?");
		if (mkdir(output_directory, 0777) < 0 && errno != EEXIST)
			die("Could not create directory %s",
			    output_directory);
	}

552
	if (rev.pending.nr == 1) {
J
Junio C Hamano 已提交
553 554 555 556 557 558 559
		if (rev.max_count < 0) {
			rev.pending.objects[0].item->flags |= UNINTERESTING;
			add_head(&rev);
		}
		/* Otherwise, it is "format-patch -22 HEAD", and
		 * get_revision() would return only the specified count.
		 */
560 561
	}

562
	if (ignore_if_in_upstream)
563
		get_patch_ids(&rev, &patch_id_opts, prefix);
564

565 566 567
	if (!use_stdout)
		realstdout = fdopen(dup(1), "w");

568 569
	prepare_revision_walk(&rev);
	while ((commit = get_revision(&rev)) != NULL) {
570 571
		unsigned char sha1[20];

572 573 574
		/* ignore merges */
		if (commit->parents && commit->parents->next)
			continue;
575 576 577 578 579 580

		if (ignore_if_in_upstream &&
				!get_patch_id(commit, &patch_id_opts, sha1) &&
				lookup_object(sha1))
			continue;

581
		nr++;
J
Jonas Fonseca 已提交
582
		list = xrealloc(list, nr * sizeof(list[0]));
583 584
		list[nr - 1] = commit;
	}
585
	total = nr;
586
	if (numbered)
587
		rev.total = total + start_number - 1;
J
Junio C Hamano 已提交
588
	rev.add_signoff = add_signoff;
589
	rev.ref_message_id = in_reply_to;
590 591 592
	while (0 <= --nr) {
		int shown;
		commit = list[nr];
593
		rev.nr = total - nr + (start_number - 1);
594
		/* Make the second and subsequent mails replies to the first */
595 596 597 598 599 600 601 602 603 604
		if (thread) {
			if (nr == (total - 2)) {
				strncpy(ref_message_id, message_id,
					sizeof(ref_message_id));
				ref_message_id[sizeof(ref_message_id)-1]='\0';
				rev.ref_message_id = ref_message_id;
			}
			gen_message_id(message_id, sizeof(message_id),
				       sha1_to_hex(commit->object.sha1));
			rev.message_id = message_id;
605
		}
606
		if (!use_stdout)
607 608
			if (reopen_stdout(commit, rev.nr, keep_subject))
				die("Failed to create output files");
609 610 611
		shown = log_tree_commit(&rev, commit);
		free(commit->buffer);
		commit->buffer = NULL;
612 613 614 615 616 617 618 619 620

		/* We put one extra blank line between formatted
		 * patches and this flag is used by log-tree code
		 * to see if it needs to emit a LF before showing
		 * the log; when using one file per patch, we do
		 * not want the extra blank line.
		 */
		if (!use_stdout)
			rev.shown_one = 0;
621 622 623 624 625 626 627 628
		if (shown) {
			if (rev.mime_boundary)
				printf("\n--%s%s--\n\n\n",
				       mime_boundary_leader,
				       rev.mime_boundary);
			else
				printf("-- \n%s\n\n", git_version_string);
		}
629 630
		if (!use_stdout)
			fclose(stdout);
631 632 633 634 635
	}
	free(list);
	return 0;
}

R
Rene Scharfe 已提交
636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741
static int add_pending_commit(const char *arg, struct rev_info *revs, int flags)
{
	unsigned char sha1[20];
	if (get_sha1(arg, sha1) == 0) {
		struct commit *commit = lookup_commit_reference(sha1);
		if (commit) {
			commit->object.flags |= flags;
			add_pending_object(revs, &commit->object, arg);
			return 0;
		}
	}
	return -1;
}

static const char cherry_usage[] =
"git-cherry [-v] <upstream> [<head>] [<limit>]";
int cmd_cherry(int argc, const char **argv, const char *prefix)
{
	struct rev_info revs;
	struct diff_options patch_id_opts;
	struct commit *commit;
	struct commit_list *list = NULL;
	const char *upstream;
	const char *head = "HEAD";
	const char *limit = NULL;
	int verbose = 0;

	if (argc > 1 && !strcmp(argv[1], "-v")) {
		verbose = 1;
		argc--;
		argv++;
	}

	switch (argc) {
	case 4:
		limit = argv[3];
		/* FALLTHROUGH */
	case 3:
		head = argv[2];
		/* FALLTHROUGH */
	case 2:
		upstream = argv[1];
		break;
	default:
		usage(cherry_usage);
	}

	init_revisions(&revs, prefix);
	revs.diff = 1;
	revs.combine_merges = 0;
	revs.ignore_merges = 1;
	revs.diffopt.recursive = 1;

	if (add_pending_commit(head, &revs, 0))
		die("Unknown commit %s", head);
	if (add_pending_commit(upstream, &revs, UNINTERESTING))
		die("Unknown commit %s", upstream);

	/* Don't say anything if head and upstream are the same. */
	if (revs.pending.nr == 2) {
		struct object_array_entry *o = revs.pending.objects;
		if (hashcmp(o[0].item->sha1, o[1].item->sha1) == 0)
			return 0;
	}

	get_patch_ids(&revs, &patch_id_opts, prefix);

	if (limit && add_pending_commit(limit, &revs, UNINTERESTING))
		die("Unknown commit %s", limit);

	/* reverse the list of commits */
	prepare_revision_walk(&revs);
	while ((commit = get_revision(&revs)) != NULL) {
		/* ignore merges */
		if (commit->parents && commit->parents->next)
			continue;

		commit_list_insert(commit, &list);
	}

	while (list) {
		unsigned char sha1[20];
		char sign = '+';

		commit = list->item;
		if (!get_patch_id(commit, &patch_id_opts, sha1) &&
		    lookup_object(sha1))
			sign = '-';

		if (verbose) {
			static char buf[16384];
			pretty_print_commit(CMIT_FMT_ONELINE, commit, ~0,
			                    buf, sizeof(buf), 0, NULL, NULL, 0);
			printf("%c %s %s\n", sign,
			       sha1_to_hex(commit->object.sha1), buf);
		}
		else {
			printf("%c %s\n", sign,
			       sha1_to_hex(commit->object.sha1));
		}

		list = list->next;
	}

	return 0;
}