提交 add5c8a5 编写于 作者: J Junio C Hamano

built-in format-patch: various fixups.

 - The --start-number handling introduced breakage in the normal
   code path.  It started numbering at 0 when not --numbered,
   for example.

 - When generating one file per patch, we needlessly added an
   extra blank line in front for second and subsequent files.
Signed-off-by: NJunio C Hamano <junkio@cox.net>
上级 88a15314
......@@ -201,7 +201,7 @@ int cmd_format_patch(int argc, const char **argv, char **envp)
}
argc = j;
if (numbered && start_number < 0)
if (start_number < 0)
start_number = 1;
if (numbered && keep_subject < 0)
die ("-n and -k are mutually exclusive.");
......@@ -233,12 +233,21 @@ int cmd_format_patch(int argc, const char **argv, char **envp)
while (0 <= --nr) {
int shown;
commit = list[nr];
rev.nr = rev.total - nr;
rev.nr = total - nr + (start_number - 1);
if (!use_stdout)
reopen_stdout(commit, rev.nr, keep_subject);
shown = log_tree_commit(&rev, commit);
free(commit->buffer);
commit->buffer = NULL;
/* We put one extra blank line between formatted
* patches and this flag is used by log-tree code
* to see if it needs to emit a LF before showing
* the log; when using one file per patch, we do
* not want the extra blank line.
*/
if (!use_stdout)
rev.shown_one = 0;
if (shown) {
if (rev.mime_boundary)
printf("\n--%s%s--\n\n\n",
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册