提交 b3c13314 编写于 作者: F fyrz

[RocksJava] Removed todo comment in portal.h

As jclass instances shall not be cached, both
todos are obsolete and can be removed.
上级 7ffcc457
...@@ -567,9 +567,6 @@ class WriteTypeJni { ...@@ -567,9 +567,6 @@ class WriteTypeJni {
private: private:
// Get the java class id of org.rocksdb.WBWIRocksIterator.WriteType. // Get the java class id of org.rocksdb.WBWIRocksIterator.WriteType.
static jclass getJClass(JNIEnv* env) { static jclass getJClass(JNIEnv* env) {
// TODO(AR) setting the jclazz var to static causes getEnum to fail
// occasionally (e.g. in WriteBatchWithIndex#iterator() test) with
// SIGSEGV but I have no idea why...
jclass jclazz = env->FindClass("org/rocksdb/WBWIRocksIterator$WriteType"); jclass jclazz = env->FindClass("org/rocksdb/WBWIRocksIterator$WriteType");
assert(jclazz != nullptr); assert(jclazz != nullptr);
return jclazz; return jclazz;
...@@ -577,9 +574,6 @@ class WriteTypeJni { ...@@ -577,9 +574,6 @@ class WriteTypeJni {
// Get an enum field of org.rocksdb.WBWIRocksIterator.WriteType // Get an enum field of org.rocksdb.WBWIRocksIterator.WriteType
static jobject getEnum(JNIEnv* env, const char name[]) { static jobject getEnum(JNIEnv* env, const char name[]) {
// TODO(AR) setting the jclazz var to static causes getEnum to fail
// occasionally (e.g. in WriteBatchWithIndex#iterator() test) with
// SIGSEGV but I have no idea why...
jclass jclazz = getJClass(env); jclass jclazz = getJClass(env);
jfieldID jfid = jfieldID jfid =
env->GetStaticFieldID(jclazz, name, env->GetStaticFieldID(jclazz, name,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册