From b3c1331488b573e741ae9fb53913af9ccb27c713 Mon Sep 17 00:00:00 2001 From: fyrz Date: Sat, 24 Jan 2015 23:43:46 +0100 Subject: [PATCH] [RocksJava] Removed todo comment in portal.h As jclass instances shall not be cached, both todos are obsolete and can be removed. --- java/rocksjni/portal.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/java/rocksjni/portal.h b/java/rocksjni/portal.h index 443761c52..234d338ff 100644 --- a/java/rocksjni/portal.h +++ b/java/rocksjni/portal.h @@ -567,9 +567,6 @@ class WriteTypeJni { private: // Get the java class id of org.rocksdb.WBWIRocksIterator.WriteType. static jclass getJClass(JNIEnv* env) { - // TODO(AR) setting the jclazz var to static causes getEnum to fail - // occasionally (e.g. in WriteBatchWithIndex#iterator() test) with - // SIGSEGV but I have no idea why... jclass jclazz = env->FindClass("org/rocksdb/WBWIRocksIterator$WriteType"); assert(jclazz != nullptr); return jclazz; @@ -577,9 +574,6 @@ class WriteTypeJni { // Get an enum field of org.rocksdb.WBWIRocksIterator.WriteType static jobject getEnum(JNIEnv* env, const char name[]) { - // TODO(AR) setting the jclazz var to static causes getEnum to fail - // occasionally (e.g. in WriteBatchWithIndex#iterator() test) with - // SIGSEGV but I have no idea why... jclass jclazz = getJClass(env); jfieldID jfid = env->GetStaticFieldID(jclazz, name, -- GitLab