• A
    std: Change assert_eq!() to use {} instead of {:?} · 02882fbd
    Alex Crichton 提交于
    Formatting via reflection has been a little questionable for some time now, and
    it's a little unfortunate that one of the standard macros will silently use
    reflection when you weren't expecting it. This adds small bits of code bloat to
    libraries, as well as not always being necessary. In light of this information,
    this commit switches assert_eq!() to using {} in the error message instead of
    {:?}.
    
    In updating existing code, there were a few error cases that I encountered:
    
    * It's impossible to define Show for [T, ..N]. I think DST will alleviate this
      because we can define Show for [T].
    * A few types here and there just needed a #[deriving(Show)]
    * Type parameters needed a Show bound, I often moved this to `assert!(a == b)`
    * `Path` doesn't implement `Show`, so assert_eq!() cannot be used on two paths.
      I don't think this is much of a regression though because {:?} on paths looks
      awful (it's a byte array).
    
    Concretely speaking, this shaved 10K off a 656K binary. Not a lot, but sometime
    significant for smaller binaries.
    02882fbd
json.rs 69.1 KB