builder.rs 90.5 KB
Newer Older
1
use std::any::{type_name, Any};
2
use std::cell::{Cell, RefCell};
3 4
use std::collections::BTreeSet;
use std::env;
5
use std::ffi::{OsStr, OsString};
6
use std::fmt::{Debug, Write};
7
use std::fs::{self, File};
8
use std::hash::Hash;
9
use std::io::{BufRead, BufReader, ErrorKind};
10
use std::ops::Deref;
11
use std::path::{Component, Path, PathBuf};
12
use std::process::{Command, Stdio};
S
Santiago Pastorino 已提交
13
use std::time::{Duration, Instant};
14

L
ljedrz 已提交
15
use crate::cache::{Cache, Interned, INTERNER};
16
use crate::config::{SplitDebuginfo, TargetSelection};
L
ljedrz 已提交
17 18
use crate::dist;
use crate::doc;
J
Joshua Nelson 已提交
19
use crate::flags::{Color, Subcommand};
L
ljedrz 已提交
20 21
use crate::install;
use crate::native;
22
use crate::run;
L
ljedrz 已提交
23
use crate::test;
24
use crate::tool::{self, SourceType};
B
bjorn3 已提交
25
use crate::util::{self, add_dylib_path, add_link_lib_path, exe, libdir, output, t};
26
use crate::EXTRA_CHECK_CFGS;
27
use crate::{check, Config};
28
use crate::{compile, Crate};
29
use crate::{Build, CLang, DocTests, GitRepo, Mode};
L
ljedrz 已提交
30 31

pub use crate::Compiler;
32
// FIXME: replace with std::lazy after it gets stabilized and reaches beta
33 34
use once_cell::sync::{Lazy, OnceCell};
use xz2::bufread::XzDecoder;
35

36 37 38 39 40
pub struct Builder<'a> {
    pub build: &'a Build,
    pub top_stage: u32,
    pub kind: Kind,
    cache: Cache,
41
    stack: RefCell<Vec<Box<dyn Any>>>,
42
    time_spent_on_dependencies: Cell<Duration>,
43
    pub paths: Vec<PathBuf>,
44 45 46 47 48 49 50 51 52 53
}

impl<'a> Deref for Builder<'a> {
    type Target = Build;

    fn deref(&self) -> &Self::Target {
        self.build
    }
}

54
pub trait Step: 'static + Clone + Debug + PartialEq + Eq + Hash {
55 56
    /// `PathBuf` when directories are created or to return a `Compiler` once
    /// it's been assembled.
57
    type Output: Clone;
58

R
Ralf Jung 已提交
59 60
    /// Whether this step is run by default as part of its respective phase.
    /// `true` here can still be overwritten by `should_run` calling `default_condition`.
61 62
    const DEFAULT: bool = false;

63
    /// If true, then this rule should be skipped if --target was specified, but --host was not
64 65
    const ONLY_HOSTS: bool = false;

A
Alexander Regueiro 已提交
66
    /// Primary function to execute this rule. Can call `builder.ensure()`
67
    /// with other steps to run those.
T
Taiki Endo 已提交
68
    fn run(self, builder: &Builder<'_>) -> Self::Output;
69

70 71
    /// When bootstrap is passed a set of paths, this controls whether this rule
    /// will execute. However, it does not get called in a "default" context
A
Alexander Regueiro 已提交
72
    /// when we are not passed any paths; in that case, `make_run` is called
73
    /// directly.
T
Taiki Endo 已提交
74
    fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_>;
75

A
Alexander Regueiro 已提交
76
    /// Builds up a "root" rule, either as a default rule or from a path passed
77 78 79 80 81
    /// to us.
    ///
    /// When path is `None`, we are executing in a context where no paths were
    /// passed. When `./x.py build` is run, for example, this rule could get
    /// called if it is in the correct list below with a path of `None`.
T
Taiki Endo 已提交
82
    fn make_run(_run: RunConfig<'_>) {
83 84 85 86 87 88
        // It is reasonable to not have an implementation of make_run for rules
        // who do not want to get called from the root context. This means that
        // they are likely dependencies (e.g., sysroot creation) or similar, and
        // as such calling them from ./x.py isn't logical.
        unimplemented!()
    }
89 90
}

91 92
pub struct RunConfig<'a> {
    pub builder: &'a Builder<'a>,
93
    pub target: TargetSelection,
94
    pub paths: Vec<PathSet>,
95 96
}

97 98 99 100 101 102
impl RunConfig<'_> {
    pub fn build_triple(&self) -> TargetSelection {
        self.builder.build.build
    }
}

103 104 105
struct StepDescription {
    default: bool,
    only_hosts: bool,
T
Taiki Endo 已提交
106 107
    should_run: fn(ShouldRun<'_>) -> ShouldRun<'_>,
    make_run: fn(RunConfig<'_>),
108
    name: &'static str,
109
    kind: Kind,
110 111
}

112
#[derive(Clone, PartialOrd, Ord, PartialEq, Eq)]
113 114
pub struct TaskPath {
    pub path: PathBuf,
115
    pub kind: Option<Kind>,
116 117 118 119
}

impl TaskPath {
    pub fn parse(path: impl Into<PathBuf>) -> TaskPath {
120 121 122 123 124 125 126 127 128 129
        let mut kind = None;
        let mut path = path.into();

        let mut components = path.components();
        if let Some(Component::Normal(os_str)) = components.next() {
            if let Some(str) = os_str.to_str() {
                if let Some((found_kind, found_prefix)) = str.split_once("::") {
                    if found_kind.is_empty() {
                        panic!("empty kind in task path {}", path.display());
                    }
130 131
                    kind = Kind::parse(found_kind);
                    assert!(kind.is_some());
132 133 134 135 136 137 138 139 140 141 142 143 144 145 146
                    path = Path::new(found_prefix).join(components.as_path());
                }
            }
        }

        TaskPath { path, kind }
    }
}

impl Debug for TaskPath {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        if let Some(kind) = &self.kind {
            write!(f, "{}::", kind.as_str())?;
        }
        write!(f, "{}", self.path.display())
147 148 149
    }
}

150
/// Collection of paths used to match a task rule.
151
#[derive(Debug, Clone, PartialOrd, Ord, PartialEq, Eq)]
152
pub enum PathSet {
153
    /// A collection of individual paths or aliases.
154 155
    ///
    /// These are generally matched as a path suffix. For example, a
156
    /// command-line value of `std` will match if `library/std` is in the
157
    /// set.
158 159 160 161 162
    ///
    /// NOTE: the paths within a set should always be aliases of one another.
    /// For example, `src/librustdoc` and `src/tools/rustdoc` should be in the same set,
    /// but `library/core` and `library/std` generally should not, unless there's no way (for that Step)
    /// to build them separately.
163
    Set(BTreeSet<TaskPath>),
164 165 166 167 168 169
    /// A "suite" of paths.
    ///
    /// These can match as a path suffix (like `Set`), or as a prefix. For
    /// example, a command-line value of `src/test/ui/abi/variadic-ffi.rs`
    /// will match `src/test/ui`. A command-line value of `ui` would also
    /// match `src/test/ui`.
170
    Suite(TaskPath),
171 172 173
}

impl PathSet {
174
    fn empty() -> PathSet {
175
        PathSet::Set(BTreeSet::new())
176 177
    }

178
    fn one<P: Into<PathBuf>>(path: P, kind: Kind) -> PathSet {
179
        let mut set = BTreeSet::new();
180
        set.insert(TaskPath { path: path.into(), kind: Some(kind) });
181
        PathSet::Set(set)
182 183
    }

184
    fn has(&self, needle: &Path, module: Option<Kind>) -> bool {
185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217
        match self {
            PathSet::Set(set) => set.iter().any(|p| Self::check(p, needle, module)),
            PathSet::Suite(suite) => Self::check(suite, needle, module),
        }
    }

    // internal use only
    fn check(p: &TaskPath, needle: &Path, module: Option<Kind>) -> bool {
        if let (Some(p_kind), Some(kind)) = (&p.kind, module) {
            p.path.ends_with(needle) && *p_kind == kind
        } else {
            p.path.ends_with(needle)
        }
    }

    /// Return all `TaskPath`s in `Self` that contain any of the `needles`, removing the
    /// matched needles.
    ///
    /// This is used for `StepDescription::krate`, which passes all matching crates at once to
    /// `Step::make_run`, rather than calling it many times with a single crate.
    /// See `tests.rs` for examples.
    fn intersection_removing_matches(
        &self,
        needles: &mut Vec<&Path>,
        module: Option<Kind>,
    ) -> PathSet {
        let mut check = |p| {
            for (i, n) in needles.iter().enumerate() {
                let matched = Self::check(p, n, module);
                if matched {
                    needles.remove(i);
                    return true;
                }
218
            }
219
            false
220
        };
221
        match self {
222 223 224 225 226 227 228 229
            PathSet::Set(set) => PathSet::Set(set.iter().filter(|&p| check(p)).cloned().collect()),
            PathSet::Suite(suite) => {
                if check(suite) {
                    self.clone()
                } else {
                    PathSet::empty()
                }
            }
230
        }
231 232
    }

233 234 235 236 237
    /// A convenience wrapper for Steps which know they have no aliases and all their sets contain only a single path.
    ///
    /// This can be used with [`ShouldRun::krate`], [`ShouldRun::path`], or [`ShouldRun::alias`].
    #[track_caller]
    pub fn assert_single_path(&self) -> &TaskPath {
238
        match self {
239
            PathSet::Set(set) => {
240 241
                assert_eq!(set.len(), 1, "called assert_single_path on multiple paths");
                set.iter().next().unwrap()
242
            }
243
            PathSet::Suite(_) => unreachable!("called assert_single_path on a Suite path"),
244
        }
245
    }
246 247 248
}

impl StepDescription {
249
    fn from<S: Step>(kind: Kind) -> StepDescription {
250 251 252 253 254
        StepDescription {
            default: S::DEFAULT,
            only_hosts: S::ONLY_HOSTS,
            should_run: S::should_run,
            make_run: S::make_run,
M
Mark Rousskov 已提交
255
            name: std::any::type_name::<S>(),
256
            kind,
257 258 259
        }
    }

260 261
    fn maybe_run(&self, builder: &Builder<'_>, pathsets: Vec<PathSet>) {
        if pathsets.iter().any(|set| self.is_excluded(builder, set)) {
262
            return;
263
        }
264

M
Mark Simulacrum 已提交
265
        // Determine the targets participating in this rule.
T
Tyler Mandry 已提交
266
        let targets = if self.only_hosts { &builder.hosts } else { &builder.targets };
267

268
        for target in targets {
269
            let run = RunConfig { builder, paths: pathsets.clone(), target: *target };
270
            (self.make_run)(run);
271 272 273
        }
    }

274
    fn is_excluded(&self, builder: &Builder<'_>, pathset: &PathSet) -> bool {
275
        if builder.config.exclude.iter().any(|e| pathset.has(&e.path, e.kind)) {
276
            println!("Skipping {:?} because it is excluded", pathset);
277 278 279 280
            return true;
        }

        if !builder.config.exclude.is_empty() {
281
            builder.verbose(&format!(
282 283
                "{:?} not skipped for {:?} -- not in {:?}",
                pathset, self.name, builder.config.exclude
284
            ));
285 286 287 288
        }
        false
    }

T
Taiki Endo 已提交
289
    fn run(v: &[StepDescription], builder: &Builder<'_>, paths: &[PathBuf]) {
290 291 292 293
        let should_runs = v
            .iter()
            .map(|desc| (desc.should_run)(ShouldRun::new(builder, desc.kind)))
            .collect::<Vec<_>>();
294 295 296

        // sanity checks on rules
        for (desc, should_run) in v.iter().zip(&should_runs) {
S
Santiago Pastorino 已提交
297 298 299 300 301
            assert!(
                !should_run.paths.is_empty(),
                "{:?} should have at least one pathset",
                desc.name
            );
302 303
        }

304 305
        if paths.is_empty() || builder.config.include_default_paths {
            for (desc, should_run) in v.iter().zip(&should_runs) {
306
                if desc.default && should_run.is_really_default() {
307
                    desc.maybe_run(builder, should_run.paths.iter().cloned().collect());
308 309
                }
            }
310
        }
311

312 313 314
        // strip CurDir prefix if present
        let mut paths: Vec<_> =
            paths.into_iter().map(|p| p.strip_prefix(".").unwrap_or(p)).collect();
315

316 317 318
        // Handle all test suite paths.
        // (This is separate from the loop below to avoid having to handle multiple paths in `is_suite_path` somehow.)
        paths.retain(|path| {
319
            for (desc, should_run) in v.iter().zip(&should_runs) {
320 321 322
                if let Some(suite) = should_run.is_suite_path(&path) {
                    desc.maybe_run(builder, vec![suite.clone()]);
                    return false;
323 324
                }
            }
325 326 327 328 329 330
            true
        });

        if paths.is_empty() {
            return;
        }
331

332 333 334 335 336
        // Handle all PathSets.
        for (desc, should_run) in v.iter().zip(&should_runs) {
            let pathsets = should_run.pathset_for_paths_removing_matches(&mut paths, desc.kind);
            if !pathsets.is_empty() {
                desc.maybe_run(builder, pathsets);
337
            }
338
        }
339 340 341 342 343 344 345 346 347 348

        if !paths.is_empty() {
            eprintln!("error: no `{}` rules matched {:?}", builder.kind.as_str(), paths,);
            eprintln!(
                "help: run `x.py {} --help --verbose` to show a list of available paths",
                builder.kind.as_str()
            );
            eprintln!(
                "note: if you are adding a new Step to bootstrap itself, make sure you register it with `describe!`"
            );
J
Joshua Nelson 已提交
349
            #[cfg(not(test))]
350
            std::process::exit(1);
J
Joshua Nelson 已提交
351 352 353
            #[cfg(test)]
            // so we can use #[should_panic]
            panic!()
354
        }
355 356 357
    }
}

358 359 360 361 362
enum ReallyDefault<'a> {
    Bool(bool),
    Lazy(Lazy<bool, Box<dyn Fn() -> bool + 'a>>),
}

363
pub struct ShouldRun<'a> {
364
    pub builder: &'a Builder<'a>,
365 366
    kind: Kind,

367
    // use a BTreeSet to maintain sort order
368
    paths: BTreeSet<PathSet>,
369 370

    // If this is a default rule, this is an additional constraint placed on
371
    // its run. Generally something like compiler docs being enabled.
372
    is_really_default: ReallyDefault<'a>,
373 374 375
}

impl<'a> ShouldRun<'a> {
376
    fn new(builder: &'a Builder<'_>, kind: Kind) -> ShouldRun<'a> {
377
        ShouldRun {
378
            builder,
379
            kind,
380
            paths: BTreeSet::new(),
381
            is_really_default: ReallyDefault::Bool(true), // by default no additional conditions
382 383 384
        }
    }

385
    pub fn default_condition(mut self, cond: bool) -> Self {
386 387 388 389 390 391
        self.is_really_default = ReallyDefault::Bool(cond);
        self
    }

    pub fn lazy_default_condition(mut self, lazy_cond: Box<dyn Fn() -> bool + 'a>) -> Self {
        self.is_really_default = ReallyDefault::Lazy(Lazy::new(lazy_cond));
392 393 394
        self
    }

395 396 397 398 399 400 401
    pub fn is_really_default(&self) -> bool {
        match &self.is_really_default {
            ReallyDefault::Bool(val) => *val,
            ReallyDefault::Lazy(lazy) => *lazy.deref(),
        }
    }

402 403 404 405 406 407 408 409 410
    /// Indicates it should run if the command-line selects the given crate or
    /// any of its (local) dependencies.
    ///
    /// Compared to `krate`, this treats the dependencies as aliases for the
    /// same job. Generally it is preferred to use `krate`, and treat each
    /// individual path separately. For example `./x.py test src/liballoc`
    /// (which uses `krate`) will test just `liballoc`. However, `./x.py check
    /// src/liballoc` (which uses `all_krates`) will check all of `libtest`.
    /// `all_krates` should probably be removed at some point.
411 412
    pub fn all_krates(mut self, name: &str) -> Self {
        let mut set = BTreeSet::new();
413
        for krate in self.builder.in_tree_crates(name, None) {
414
            let path = krate.local_path(self.builder);
415
            set.insert(TaskPath { path, kind: Some(self.kind) });
416
        }
417
        self.paths.insert(PathSet::Set(set));
418 419 420
        self
    }

421 422 423
    /// Indicates it should run if the command-line selects the given crate or
    /// any of its (local) dependencies.
    ///
424
    /// `make_run` will be called a single time with all matching command-line paths.
425 426 427 428 429 430 431 432 433 434
    pub fn crate_or_deps(self, name: &str) -> Self {
        let crates = self.builder.in_tree_crates(name, None);
        self.crates(crates)
    }

    /// Indicates it should run if the command-line selects any of the given crates.
    ///
    /// `make_run` will be called a single time with all matching command-line paths.
    pub(crate) fn crates(mut self, crates: Vec<&Crate>) -> Self {
        for krate in crates {
435
            let path = krate.local_path(self.builder);
436
            self.paths.insert(PathSet::one(path, self.kind));
437 438 439 440
        }
        self
    }

441 442 443 444 445 446 447 448 449 450 451 452 453
    // single alias, which does not correspond to any on-disk path
    pub fn alias(mut self, alias: &str) -> Self {
        assert!(
            !self.builder.src.join(alias).exists(),
            "use `builder.path()` for real paths: {}",
            alias
        );
        self.paths.insert(PathSet::Set(
            std::iter::once(TaskPath { path: alias.into(), kind: Some(self.kind) }).collect(),
        ));
        self
    }

454 455 456 457 458 459 460
    // single, non-aliased path
    pub fn path(self, path: &str) -> Self {
        self.paths(&[path])
    }

    // multiple aliases for the same job
    pub fn paths(mut self, paths: &[&str]) -> Self {
461
        self.paths.insert(PathSet::Set(
462 463 464
            paths
                .iter()
                .map(|p| {
465 466 467 468 469 470 471
                    // FIXME(#96188): make sure this is actually a path.
                    // This currently breaks for paths within submodules.
                    //assert!(
                    //    self.builder.src.join(p).exists(),
                    //    "`should_run.paths` should correspond to real on-disk paths - use `alias` if there is no relevant path: {}",
                    //    p
                    //);
472 473 474
                    TaskPath { path: p.into(), kind: Some(self.kind) }
                })
                .collect(),
475
        ));
476 477 478
        self
    }

479 480
    /// Handles individual files (not directories) within a test suite.
    fn is_suite_path(&self, requested_path: &Path) -> Option<&PathSet> {
S
Santiago Pastorino 已提交
481
        self.paths.iter().find(|pathset| match pathset {
482
            PathSet::Suite(suite) => requested_path.starts_with(&suite.path),
S
Santiago Pastorino 已提交
483
            PathSet::Set(_) => false,
484 485 486 487
        })
    }

    pub fn suite_path(mut self, suite: &str) -> Self {
488
        self.paths.insert(PathSet::Suite(TaskPath { path: suite.into(), kind: Some(self.kind) }));
489 490 491 492
        self
    }

    // allows being more explicit about why should_run in Step returns the value passed to it
493 494
    pub fn never(mut self) -> ShouldRun<'a> {
        self.paths.insert(PathSet::empty());
495 496 497
        self
    }

498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519
    /// Given a set of requested paths, return the subset which match the Step for this `ShouldRun`,
    /// removing the matches from `paths`.
    ///
    /// NOTE: this returns multiple PathSets to allow for the possibility of multiple units of work
    /// within the same step. For example, `test::Crate` allows testing multiple crates in the same
    /// cargo invocation, which are put into separate sets because they aren't aliases.
    ///
    /// The reason we return PathSet instead of PathBuf is to allow for aliases that mean the same thing
    /// (for now, just `all_krates` and `paths`, but we may want to add an `aliases` function in the future?)
    fn pathset_for_paths_removing_matches(
        &self,
        paths: &mut Vec<&Path>,
        kind: Kind,
    ) -> Vec<PathSet> {
        let mut sets = vec![];
        for pathset in &self.paths {
            let subset = pathset.intersection_removing_matches(paths, Some(kind));
            if subset != PathSet::empty() {
                sets.push(subset);
            }
        }
        sets
520 521 522
    }
}

523
#[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Debug)]
524 525
pub enum Kind {
    Build,
526
    Check,
L
ljedrz 已提交
527 528
    Clippy,
    Fix,
529
    Format,
530 531 532
    Test,
    Bench,
    Doc,
533 534
    Clean,
    Dist,
535
    Install,
536
    Run,
537
    Setup,
538 539
}

540
impl Kind {
541 542 543 544 545
    pub fn parse(string: &str) -> Option<Kind> {
        // these strings, including the one-letter aliases, must match the x.py help text
        Some(match string {
            "build" | "b" => Kind::Build,
            "check" | "c" => Kind::Check,
546 547
            "clippy" => Kind::Clippy,
            "fix" => Kind::Fix,
548 549
            "fmt" => Kind::Format,
            "test" | "t" => Kind::Test,
550
            "bench" => Kind::Bench,
551 552
            "doc" | "d" => Kind::Doc,
            "clean" => Kind::Clean,
553 554
            "dist" => Kind::Dist,
            "install" => Kind::Install,
555 556 557 558
            "run" | "r" => Kind::Run,
            "setup" => Kind::Setup,
            _ => return None,
        })
559 560
    }

561
    pub fn as_str(&self) -> &'static str {
562 563 564 565 566
        match self {
            Kind::Build => "build",
            Kind::Check => "check",
            Kind::Clippy => "clippy",
            Kind::Fix => "fix",
567
            Kind::Format => "fmt",
568 569 570
            Kind::Test => "test",
            Kind::Bench => "bench",
            Kind::Doc => "doc",
571 572
            Kind::Clean => "clean",
            Kind::Dist => "dist",
573 574
            Kind::Install => "install",
            Kind::Run => "run",
575
            Kind::Setup => "setup",
576 577 578 579
        }
    }
}

580 581 582
impl<'a> Builder<'a> {
    fn get_step_descriptions(kind: Kind) -> Vec<StepDescription> {
        macro_rules! describe {
T
Taiki Endo 已提交
583
            ($($rule:ty),+ $(,)?) => {{
584
                vec![$(StepDescription::from::<$rule>(kind)),+]
585
            }};
586
        }
587
        match kind {
S
Santiago Pastorino 已提交
588 589
            Kind::Build => describe!(
                compile::Std,
590
                compile::Rustc,
591
                compile::Assemble,
592
                compile::CodegenBackend,
S
Santiago Pastorino 已提交
593 594 595 596 597 598 599 600 601 602 603 604 605 606
                compile::StartupObjects,
                tool::BuildManifest,
                tool::Rustbook,
                tool::ErrorIndex,
                tool::UnstableBookGen,
                tool::Tidy,
                tool::Linkchecker,
                tool::CargoTest,
                tool::Compiletest,
                tool::RemoteTestServer,
                tool::RemoteTestClient,
                tool::RustInstaller,
                tool::Cargo,
                tool::Rls,
A
Aleksey Kladov 已提交
607
                tool::RustAnalyzer,
R
Rich Kadel 已提交
608
                tool::RustDemangler,
S
Santiago Pastorino 已提交
609 610
                tool::Rustdoc,
                tool::Clippy,
611
                tool::CargoClippy,
S
Santiago Pastorino 已提交
612
                native::Llvm,
613
                native::Sanitizers,
S
Santiago Pastorino 已提交
614 615
                tool::Rustfmt,
                tool::Miri,
616
                tool::CargoMiri,
617 618
                native::Lld,
                native::CrtBeginEnd
S
Santiago Pastorino 已提交
619
            ),
Y
Yuki Okushi 已提交
620
            Kind::Check | Kind::Clippy | Kind::Fix => describe!(
621 622 623 624 625
                check::Std,
                check::Rustc,
                check::Rustdoc,
                check::CodegenBackend,
                check::Clippy,
626 627
                check::Miri,
                check::Rls,
628
                check::Rustfmt,
629 630
                check::Bootstrap
            ),
S
Santiago Pastorino 已提交
631
            Kind::Test => describe!(
632
                crate::toolstate::ToolStateCheck,
633
                test::ExpandYamlAnchors,
S
Santiago Pastorino 已提交
634 635 636 637 638 639
                test::Tidy,
                test::Ui,
                test::RunPassValgrind,
                test::MirOpt,
                test::Codegen,
                test::CodegenUnits,
640
                test::Assembly,
S
Santiago Pastorino 已提交
641 642 643 644 645 646 647 648
                test::Incremental,
                test::Debuginfo,
                test::UiFullDeps,
                test::Rustdoc,
                test::Pretty,
                test::Crate,
                test::CrateLibrustc,
                test::CrateRustdoc,
649
                test::CrateRustdocJsonTypes,
S
Santiago Pastorino 已提交
650
                test::Linkcheck,
651
                test::TierCheck,
S
Santiago Pastorino 已提交
652 653 654 655 656
                test::Cargotest,
                test::Cargo,
                test::Rls,
                test::ErrorIndex,
                test::Distcheck,
657
                test::RunMakeFullDeps,
S
Santiago Pastorino 已提交
658 659 660 661 662 663 664
                test::Nomicon,
                test::Reference,
                test::RustdocBook,
                test::RustByExample,
                test::TheBook,
                test::UnstableBook,
                test::RustcBook,
665
                test::LintDocs,
666
                test::RustcGuide,
667
                test::EmbeddedBook,
E
Eric Huss 已提交
668
                test::EditionGuide,
S
Santiago Pastorino 已提交
669 670 671
                test::Rustfmt,
                test::Miri,
                test::Clippy,
R
Rich Kadel 已提交
672
                test::RustDemangler,
673
                test::CompiletestTest,
G
Guillaume Gomez 已提交
674
                test::RustdocJSStd,
G
Guillaume Gomez 已提交
675
                test::RustdocJSNotStd,
G
Guillaume Gomez 已提交
676
                test::RustdocGUI,
S
Santiago Pastorino 已提交
677
                test::RustdocTheme,
J
John Kåre Alsaker 已提交
678
                test::RustdocUi,
N
Nixon Enraght-Moony 已提交
679
                test::RustdocJson,
G
Guillaume Gomez 已提交
680
                test::HtmlCheck,
681 682
                // Run bootstrap close to the end as it's unlikely to fail
                test::Bootstrap,
683
                // Run run-make last, since these won't pass without make on Windows
S
Santiago Pastorino 已提交
684 685
                test::RunMake,
            ),
686
            Kind::Bench => describe!(test::Crate, test::CrateLibrustc),
S
Santiago Pastorino 已提交
687 688 689 690 691 692 693 694
            Kind::Doc => describe!(
                doc::UnstableBook,
                doc::UnstableBookGen,
                doc::TheBook,
                doc::Standalone,
                doc::Std,
                doc::Rustc,
                doc::Rustdoc,
695
                doc::Rustfmt,
S
Santiago Pastorino 已提交
696 697 698 699 700 701
                doc::ErrorIndex,
                doc::Nomicon,
                doc::Reference,
                doc::RustdocBook,
                doc::RustByExample,
                doc::RustcBook,
S
Steve Klabnik 已提交
702
                doc::CargoBook,
X
xFrednet 已提交
703
                doc::Clippy,
704
                doc::Miri,
J
James Munns 已提交
705
                doc::EmbeddedBook,
S
Steve Klabnik 已提交
706
                doc::EditionGuide,
S
Santiago Pastorino 已提交
707 708 709 710 711 712 713
            ),
            Kind::Dist => describe!(
                dist::Docs,
                dist::RustcDocs,
                dist::Mingw,
                dist::Rustc,
                dist::Std,
J
Josh Stone 已提交
714
                dist::RustcDev,
S
Santiago Pastorino 已提交
715 716 717 718
                dist::Analysis,
                dist::Src,
                dist::Cargo,
                dist::Rls,
A
Aleksey Kladov 已提交
719
                dist::RustAnalyzer,
S
Santiago Pastorino 已提交
720
                dist::Rustfmt,
R
Rich Kadel 已提交
721
                dist::RustDemangler,
722
                dist::Clippy,
723
                dist::Miri,
724
                dist::LlvmTools,
725
                dist::RustDev,
S
Santiago Pastorino 已提交
726
                dist::Extended,
727
                // It seems that PlainSourceTarball somehow changes how some of the tools
Y
Yuri Astrakhan 已提交
728
                // perceive their dependencies (see #93033) which would invalidate fingerprints
729 730 731
                // and force us to rebuild tools after vendoring dependencies.
                // To work around this, create the Tarball after building all the tools.
                dist::PlainSourceTarball,
732
                dist::BuildManifest,
733
                dist::ReproducibleArtifacts,
S
Santiago Pastorino 已提交
734 735 736 737 738 739
            ),
            Kind::Install => describe!(
                install::Docs,
                install::Std,
                install::Cargo,
                install::Rls,
A
Aleksey Kladov 已提交
740
                install::RustAnalyzer,
S
Santiago Pastorino 已提交
741
                install::Rustfmt,
R
Rich Kadel 已提交
742
                install::RustDemangler,
743
                install::Clippy,
744
                install::Miri,
S
Santiago Pastorino 已提交
745 746 747 748
                install::Analysis,
                install::Src,
                install::Rustc
            ),
749
            Kind::Run => describe!(run::ExpandYamlAnchors, run::BuildManifest, run::BumpStage0),
750
            // These commands either don't use paths, or they're special-cased in Build::build()
Y
Yuki Okushi 已提交
751
            Kind::Clean | Kind::Format | Kind::Setup => vec![],
752 753
        }
    }
754

755 756 757 758 759
    pub fn get_help(build: &Build, kind: Kind) -> Option<String> {
        let step_descriptions = Builder::get_step_descriptions(kind);
        if step_descriptions.is_empty() {
            return None;
        }
760

J
Joshua Nelson 已提交
761
        let builder = Self::new_internal(build, kind, vec![]);
762
        let builder = &builder;
763 764 765
        // The "build" kind here is just a placeholder, it will be replaced with something else in
        // the following statement.
        let mut should_run = ShouldRun::new(builder, Kind::Build);
766
        for desc in step_descriptions {
767
            should_run.kind = desc.kind;
768
            should_run = (desc.should_run)(should_run);
769 770
        }
        let mut help = String::from("Available paths:\n");
771
        let mut add_path = |path: &Path| {
772
            t!(write!(help, "    ./x.py {} {}\n", kind.as_str(), path.display()));
773
        };
774
        for pathset in should_run.paths {
775 776 777
            match pathset {
                PathSet::Set(set) => {
                    for path in set {
778
                        add_path(&path.path);
779 780 781
                    }
                }
                PathSet::Suite(path) => {
782
                    add_path(&path.path.join("..."));
783
                }
784
            }
785 786 787 788
        }
        Some(help)
    }

J
Joshua Nelson 已提交
789 790 791
    fn new_internal(build: &Build, kind: Kind, paths: Vec<PathBuf>) -> Builder<'_> {
        Builder {
            build,
792
            top_stage: build.config.stage,
J
Joshua Nelson 已提交
793 794 795 796 797 798 799 800
            kind,
            cache: Cache::new(),
            stack: RefCell::new(Vec::new()),
            time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
            paths,
        }
    }

T
Taiki Endo 已提交
801
    pub fn new(build: &Build) -> Builder<'_> {
M
Mark Simulacrum 已提交
802
        let (kind, paths) = match build.config.cmd {
803
            Subcommand::Build { ref paths } => (Kind::Build, &paths[..]),
804
            Subcommand::Check { ref paths } => (Kind::Check, &paths[..]),
J
Joshua Nelson 已提交
805
            Subcommand::Clippy { ref paths, .. } => (Kind::Clippy, &paths[..]),
L
ljedrz 已提交
806
            Subcommand::Fix { ref paths } => (Kind::Fix, &paths[..]),
807
            Subcommand::Doc { ref paths, .. } => (Kind::Doc, &paths[..]),
808 809 810 811
            Subcommand::Test { ref paths, .. } => (Kind::Test, &paths[..]),
            Subcommand::Bench { ref paths, .. } => (Kind::Bench, &paths[..]),
            Subcommand::Dist { ref paths } => (Kind::Dist, &paths[..]),
            Subcommand::Install { ref paths } => (Kind::Install, &paths[..]),
812
            Subcommand::Run { ref paths } => (Kind::Run, &paths[..]),
813 814
            Subcommand::Format { .. } => (Kind::Format, &[][..]),
            Subcommand::Clean { .. } | Subcommand::Setup { .. } => {
J
Joshua Nelson 已提交
815
                panic!()
816
            }
817
        };
818

819
        Self::new_internal(build, kind, paths.to_owned())
820 821
    }

822
    pub fn execute_cli(&self) {
M
Mark Simulacrum 已提交
823
        self.run_step_descriptions(&Builder::get_step_descriptions(self.kind), &self.paths);
824 825
    }

826
    pub fn default_doc(&self, paths: &[PathBuf]) {
M
Mark Simulacrum 已提交
827 828 829
        self.run_step_descriptions(&Builder::get_step_descriptions(Kind::Doc), paths);
    }

830 831 832 833 834 835 836 837 838 839 840 841
    /// NOTE: keep this in sync with `rustdoc::clean::utils::doc_rust_lang_org_channel`, or tests will fail on beta/stable.
    pub fn doc_rust_lang_org_channel(&self) -> String {
        let channel = match &*self.config.channel {
            "stable" => &self.version,
            "beta" => "beta",
            "nightly" | "dev" => "nightly",
            // custom build of rustdoc maybe? link to the latest stable docs just in case
            _ => "stable",
        };
        "https://doc.rust-lang.org/".to_owned() + channel
    }

M
Mark Simulacrum 已提交
842 843
    fn run_step_descriptions(&self, v: &[StepDescription], paths: &[PathBuf]) {
        StepDescription::run(v, self, paths);
844 845
    }

846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870
    /// Modifies the interpreter section of 'fname' to fix the dynamic linker,
    /// or the RPATH section, to fix the dynamic library search path
    ///
    /// This is only required on NixOS and uses the PatchELF utility to
    /// change the interpreter/RPATH of ELF executables.
    ///
    /// Please see https://nixos.org/patchelf.html for more information
    pub(crate) fn fix_bin_or_dylib(&self, fname: &Path) {
        // FIXME: cache NixOS detection?
        match Command::new("uname").arg("-s").stderr(Stdio::inherit()).output() {
            Err(_) => return,
            Ok(output) if !output.status.success() => return,
            Ok(output) => {
                let mut s = output.stdout;
                if s.last() == Some(&b'\n') {
                    s.pop();
                }
                if s != b"Linux" {
                    return;
                }
            }
        }

        // If the user has asked binaries to be patched for Nix, then
        // don't check for NixOS or `/lib`, just continue to the patching.
871 872 873
        // NOTE: this intentionally comes after the Linux check:
        // - patchelf only works with ELF files, so no need to run it on Mac or Windows
        // - On other Unix systems, there is no stable syscall interface, so Nix doesn't manage the global libc.
874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954
        if !self.config.patch_binaries_for_nix {
            // Use `/etc/os-release` instead of `/etc/NIXOS`.
            // The latter one does not exist on NixOS when using tmpfs as root.
            const NIX_IDS: &[&str] = &["ID=nixos", "ID='nixos'", "ID=\"nixos\""];
            let os_release = match File::open("/etc/os-release") {
                Err(e) if e.kind() == ErrorKind::NotFound => return,
                Err(e) => panic!("failed to access /etc/os-release: {}", e),
                Ok(f) => f,
            };
            if !BufReader::new(os_release).lines().any(|l| NIX_IDS.contains(&t!(l).trim())) {
                return;
            }
            if Path::new("/lib").exists() {
                return;
            }
        }

        // At this point we're pretty sure the user is running NixOS or using Nix
        println!("info: you seem to be using Nix. Attempting to patch {}", fname.display());

        // Only build `.nix-deps` once.
        static NIX_DEPS_DIR: OnceCell<PathBuf> = OnceCell::new();
        let mut nix_build_succeeded = true;
        let nix_deps_dir = NIX_DEPS_DIR.get_or_init(|| {
            // Run `nix-build` to "build" each dependency (which will likely reuse
            // the existing `/nix/store` copy, or at most download a pre-built copy).
            //
            // Importantly, we create a gc-root called `.nix-deps` in the `build/`
            // directory, but still reference the actual `/nix/store` path in the rpath
            // as it makes it significantly more robust against changes to the location of
            // the `.nix-deps` location.
            //
            // bintools: Needed for the path of `ld-linux.so` (via `nix-support/dynamic-linker`).
            // zlib: Needed as a system dependency of `libLLVM-*.so`.
            // patchelf: Needed for patching ELF binaries (see doc comment above).
            let nix_deps_dir = self.out.join(".nix-deps");
            const NIX_EXPR: &str = "
            with (import <nixpkgs> {});
            symlinkJoin {
                name = \"rust-stage0-dependencies\";
                paths = [
                    zlib
                    patchelf
                    stdenv.cc.bintools
                ];
            }
            ";
            nix_build_succeeded = self.try_run(Command::new("nix-build").args(&[
                Path::new("-E"),
                Path::new(NIX_EXPR),
                Path::new("-o"),
                &nix_deps_dir,
            ]));
            nix_deps_dir
        });
        if !nix_build_succeeded {
            return;
        }

        let mut patchelf = Command::new(nix_deps_dir.join("bin/patchelf"));
        let rpath_entries = {
            // ORIGIN is a relative default, all binary and dynamic libraries we ship
            // appear to have this (even when `../lib` is redundant).
            // NOTE: there are only two paths here, delimited by a `:`
            let mut entries = OsString::from("$ORIGIN/../lib:");
            entries.push(t!(fs::canonicalize(nix_deps_dir)));
            entries.push("/lib");
            entries
        };
        patchelf.args(&[OsString::from("--set-rpath"), rpath_entries]);
        if !fname.extension().map_or(false, |ext| ext == "so") {
            // Finally, set the corret .interp for binaries
            let dynamic_linker_path = nix_deps_dir.join("nix-support/dynamic-linker");
            // FIXME: can we support utf8 here? `args` doesn't accept Vec<u8>, only OsString ...
            let dynamic_linker = t!(String::from_utf8(t!(fs::read(dynamic_linker_path))));
            patchelf.args(&["--set-interpreter", dynamic_linker.trim_end()]);
        }

        self.try_run(patchelf.arg(fname));
    }

955
    pub(crate) fn download_component(&self, url: &str, dest_path: &Path, help_on_error: &str) {
956 957
        // Use a temporary file in case we crash while downloading, to avoid a corrupt download in cache/.
        let tempfile = self.tempdir().join(dest_path.file_name().unwrap());
958 959 960 961 962 963 964 965 966 967
        // While bootstrap itself only supports http and https downloads, downstream forks might
        // need to download components from other protocols. The match allows them adding more
        // protocols without worrying about merge conficts if we change the HTTP implementation.
        match url.split_once("://").map(|(proto, _)| proto) {
            Some("http") | Some("https") => {
                self.download_http_with_retries(&tempfile, url, help_on_error)
            }
            Some(other) => panic!("unsupported protocol {other} in {url}"),
            None => panic!("no protocol in {url}"),
        }
968 969 970
        t!(std::fs::rename(&tempfile, dest_path));
    }

971
    fn download_http_with_retries(&self, tempfile: &Path, url: &str, help_on_error: &str) {
972 973
        println!("downloading {}", url);
        // Try curl. If that fails and we are on windows, fallback to PowerShell.
974 975
        let mut curl = Command::new("curl");
        curl.args(&[
976 977 978 979 980 981 982 983 984 985 986
            "-#",
            "-y",
            "30",
            "-Y",
            "10", // timeout if speed is < 10 bytes/sec for > 30 seconds
            "--connect-timeout",
            "30", // timeout if cannot connect within 30 seconds
            "--retry",
            "3",
            "-Sf",
            "-o",
987 988 989 990
        ]);
        curl.arg(tempfile);
        curl.arg(url);
        if !self.check_run(&mut curl) {
991 992 993 994 995 996 997 998 999
            if self.build.build.contains("windows-msvc") {
                println!("Fallback to PowerShell");
                for _ in 0..3 {
                    if self.try_run(Command::new("PowerShell.exe").args(&[
                        "/nologo",
                        "-Command",
                        "[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12;",
                        &format!(
                            "(New-Object System.Net.WebClient).DownloadFile('{}', '{}')",
1000
                            url, tempfile.to_str().expect("invalid UTF-8 not supported with powershell downloads"),
1001 1002 1003 1004 1005 1006 1007
                        ),
                    ])) {
                        return;
                    }
                    println!("\nspurious failure, trying again");
                }
            }
1008 1009 1010
            if !help_on_error.is_empty() {
                eprintln!("{}", help_on_error);
            }
1011 1012 1013 1014
            std::process::exit(1);
        }
    }

1015
    pub(crate) fn unpack(&self, tarball: &Path, dst: &Path, pattern: &str) {
1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039
        println!("extracting {} to {}", tarball.display(), dst.display());
        if !dst.exists() {
            t!(fs::create_dir_all(dst));
        }

        // `tarball` ends with `.tar.xz`; strip that suffix
        // example: `rust-dev-nightly-x86_64-unknown-linux-gnu`
        let uncompressed_filename =
            Path::new(tarball.file_name().expect("missing tarball filename")).file_stem().unwrap();
        let directory_prefix = Path::new(Path::new(uncompressed_filename).file_stem().unwrap());

        // decompress the file
        let data = t!(File::open(tarball));
        let decompressor = XzDecoder::new(BufReader::new(data));

        let mut tar = tar::Archive::new(decompressor);
        for member in t!(tar.entries()) {
            let mut member = t!(member);
            let original_path = t!(member.path()).into_owned();
            // skip the top-level directory
            if original_path == directory_prefix {
                continue;
            }
            let mut short_path = t!(original_path.strip_prefix(directory_prefix));
1040
            if !short_path.starts_with(pattern) {
1041 1042
                continue;
            }
1043
            short_path = t!(short_path.strip_prefix(pattern));
1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057
            let dst_path = dst.join(short_path);
            self.verbose(&format!("extracting {} to {}", original_path.display(), dst.display()));
            if !t!(member.unpack_in(dst)) {
                panic!("path traversal attack ??");
            }
            let src_path = dst.join(original_path);
            if src_path.is_dir() && dst_path.exists() {
                continue;
            }
            t!(fs::rename(src_path, dst_path));
        }
        t!(fs::remove_dir_all(dst.join(directory_prefix)));
    }

1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079
    /// Returns whether the SHA256 checksum of `path` matches `expected`.
    pub(crate) fn verify(&self, path: &Path, expected: &str) -> bool {
        use sha2::Digest;

        self.verbose(&format!("verifying {}", path.display()));
        let mut hasher = sha2::Sha256::new();
        // FIXME: this is ok for rustfmt (4.1 MB large at time of writing), but it seems memory-intensive for rustc and larger components.
        // Consider using streaming IO instead?
        let contents = if self.config.dry_run { vec![] } else { t!(fs::read(path)) };
        hasher.update(&contents);
        let found = hex::encode(hasher.finalize().as_slice());
        let verified = found == expected;
        if !verified && !self.config.dry_run {
            println!(
                "invalid checksum: \n\
                found:    {found}\n\
                expected: {expected}",
            );
        }
        return verified;
    }

B
Bastien Orivel 已提交
1080
    /// Obtain a compiler at a given stage and for a given host. Explicitly does
1081 1082 1083
    /// not take `Compiler` since all `Compiler` instances are meant to be
    /// obtained through this function, since it ensures that they are valid
    /// (i.e., built and assembled).
1084
    pub fn compiler(&self, stage: u32, host: TargetSelection) -> Compiler {
M
Mark Rousskov 已提交
1085
        self.ensure(compile::Assemble { target_compiler: Compiler { stage, host } })
1086 1087
    }

1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098
    /// Similar to `compiler`, except handles the full-bootstrap option to
    /// silently use the stage1 compiler instead of a stage2 compiler if one is
    /// requested.
    ///
    /// Note that this does *not* have the side effect of creating
    /// `compiler(stage, host)`, unlike `compiler` above which does have such
    /// a side effect. The returned compiler here can only be used to compile
    /// new artifacts, it can't be used to rely on the presence of a particular
    /// sysroot.
    ///
    /// See `force_use_stage1` for documentation on what each argument is.
A
Alex Crichton 已提交
1099 1100 1101
    pub fn compiler_for(
        &self,
        stage: u32,
1102 1103
        host: TargetSelection,
        target: TargetSelection,
A
Alex Crichton 已提交
1104
    ) -> Compiler {
1105 1106 1107 1108 1109 1110 1111
        if self.build.force_use_stage1(Compiler { stage, host }, target) {
            self.compiler(1, self.config.build)
        } else {
            self.compiler(stage, host)
        }
    }

1112
    pub fn sysroot(&self, compiler: Compiler) -> Interned<PathBuf> {
1113 1114 1115 1116 1117
        self.ensure(compile::Sysroot { compiler })
    }

    /// Returns the libdir where the standard library and other artifacts are
    /// found for a compiler's sysroot.
1118
    pub fn sysroot_libdir(&self, compiler: Compiler, target: TargetSelection) -> Interned<PathBuf> {
1119 1120 1121
        #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
        struct Libdir {
            compiler: Compiler,
1122
            target: TargetSelection,
1123
        }
1124 1125
        impl Step for Libdir {
            type Output = Interned<PathBuf>;
1126

T
Taiki Endo 已提交
1127
            fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
1128
                run.never()
1129 1130
            }

T
Taiki Endo 已提交
1131
            fn run(self, builder: &Builder<'_>) -> Interned<PathBuf> {
O
O01eg 已提交
1132
                let lib = builder.sysroot_libdir_relative(self.compiler);
S
Santiago Pastorino 已提交
1133 1134 1135 1136
                let sysroot = builder
                    .sysroot(self.compiler)
                    .join(lib)
                    .join("rustlib")
1137
                    .join(self.target.triple)
S
Santiago Pastorino 已提交
1138
                    .join("lib");
1139 1140
                // Avoid deleting the rustlib/ directory we just copied
                // (in `impl Step for Sysroot`).
1141
                if !builder.download_rustc() {
1142 1143 1144
                    let _ = fs::remove_dir_all(&sysroot);
                    t!(fs::create_dir_all(&sysroot));
                }
1145
                INTERNER.intern_path(sysroot)
1146 1147 1148 1149 1150
            }
        }
        self.ensure(Libdir { compiler, target })
    }

1151 1152 1153 1154
    pub fn sysroot_codegen_backends(&self, compiler: Compiler) -> PathBuf {
        self.sysroot_libdir(compiler, compiler.host).with_file_name("codegen-backends")
    }

1155 1156 1157 1158 1159 1160 1161
    /// Returns the compiler's libdir where it stores the dynamic libraries that
    /// it itself links against.
    ///
    /// For example this returns `<sysroot>/lib` on Unix and `<sysroot>/bin` on
    /// Windows.
    pub fn rustc_libdir(&self, compiler: Compiler) -> PathBuf {
        if compiler.is_snapshot(self) {
1162
            self.rustc_snapshot_libdir()
1163
        } else {
O
O01eg 已提交
1164
            match self.config.libdir_relative() {
M
Mark Rousskov 已提交
1165 1166 1167
                Some(relative_libdir) if compiler.stage >= 1 => {
                    self.sysroot(compiler).join(relative_libdir)
                }
1168
                _ => self.sysroot(compiler).join(libdir(compiler.host)),
O
O01eg 已提交
1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179
            }
        }
    }

    /// Returns the compiler's relative libdir where it stores the dynamic libraries that
    /// it itself links against.
    ///
    /// For example this returns `lib` on Unix and `bin` on
    /// Windows.
    pub fn libdir_relative(&self, compiler: Compiler) -> &Path {
        if compiler.is_snapshot(self) {
1180
            libdir(self.config.build).as_ref()
O
O01eg 已提交
1181 1182
        } else {
            match self.config.libdir_relative() {
M
Mark Rousskov 已提交
1183
                Some(relative_libdir) if compiler.stage >= 1 => relative_libdir,
1184
                _ => libdir(compiler.host).as_ref(),
O
O01eg 已提交
1185
            }
1186 1187 1188
        }
    }

O
O01eg 已提交
1189 1190 1191 1192 1193 1194
    /// Returns the compiler's relative libdir where the standard library and other artifacts are
    /// found for a compiler's sysroot.
    ///
    /// For example this returns `lib` on Unix and Windows.
    pub fn sysroot_libdir_relative(&self, compiler: Compiler) -> &Path {
        match self.config.libdir_relative() {
M
Mark Rousskov 已提交
1195
            Some(relative_libdir) if compiler.stage >= 1 => relative_libdir,
O
O01eg 已提交
1196
            _ if compiler.stage == 0 => &self.build.initial_libdir,
M
Mark Rousskov 已提交
1197
            _ => Path::new("lib"),
O
O01eg 已提交
1198 1199 1200
        }
    }

1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
    pub fn rustc_lib_paths(&self, compiler: Compiler) -> Vec<PathBuf> {
        let mut dylib_dirs = vec![self.rustc_libdir(compiler)];

        // Ensure that the downloaded LLVM libraries can be found.
        if self.config.llvm_from_ci {
            let ci_llvm_lib = self.out.join(&*compiler.host.triple).join("ci-llvm").join("lib");
            dylib_dirs.push(ci_llvm_lib);
        }

        dylib_dirs
    }

1213 1214
    /// Adds the compiler's directory of dynamic libraries to `cmd`'s dynamic
    /// library lookup path.
1215
    pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Command) {
1216 1217 1218 1219
        // Windows doesn't need dylib path munging because the dlls for the
        // compiler live next to the compiler and the system will find them
        // automatically.
        if cfg!(windows) {
S
Santiago Pastorino 已提交
1220
            return;
1221 1222
        }

1223
        add_dylib_path(self.rustc_lib_paths(compiler), cmd);
1224 1225
    }

A
Alexander Regueiro 已提交
1226
    /// Gets a path to the compiler specified.
1227 1228 1229 1230
    pub fn rustc(&self, compiler: Compiler) -> PathBuf {
        if compiler.is_snapshot(self) {
            self.initial_rustc.clone()
        } else {
1231
            self.sysroot(compiler).join("bin").join(exe("rustc", compiler.host))
1232 1233 1234
        }
    }

1235 1236 1237 1238 1239 1240 1241 1242 1243
    /// Gets the paths to all of the compiler's codegen backends.
    fn codegen_backends(&self, compiler: Compiler) -> impl Iterator<Item = PathBuf> {
        fs::read_dir(self.sysroot_codegen_backends(compiler))
            .into_iter()
            .flatten()
            .filter_map(Result::ok)
            .map(|entry| entry.path())
    }

M
Mark Rousskov 已提交
1244 1245
    pub fn rustdoc(&self, compiler: Compiler) -> PathBuf {
        self.ensure(tool::Rustdoc { compiler })
M
Mark Simulacrum 已提交
1246 1247
    }

M
Mark Rousskov 已提交
1248
    pub fn rustdoc_cmd(&self, compiler: Compiler) -> Command {
1249
        let mut cmd = Command::new(&self.bootstrap_out.join("rustdoc"));
O
Oliver Schneider 已提交
1250
        cmd.env("RUSTC_STAGE", compiler.stage.to_string())
S
Santiago Pastorino 已提交
1251
            .env("RUSTC_SYSROOT", self.sysroot(compiler))
M
Mark Rousskov 已提交
1252 1253 1254
            // Note that this is *not* the sysroot_libdir because rustdoc must be linked
            // equivalently to rustc.
            .env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler))
S
Santiago Pastorino 已提交
1255
            .env("CFG_RELEASE_CHANNEL", &self.config.channel)
M
Mark Rousskov 已提交
1256
            .env("RUSTDOC_REAL", self.rustdoc(compiler))
1257 1258
            .env("RUSTC_BOOTSTRAP", "1");

M
Mark Rousskov 已提交
1259
        cmd.arg("-Wrustdoc::invalid_codeblock_attributes");
1260

G
Guillaume Gomez 已提交
1261 1262 1263
        if self.config.deny_warnings {
            cmd.arg("-Dwarnings");
        }
1264
        cmd.arg("-Znormalize-docs");
1265 1266 1267 1268 1269

        // Remove make-related flags that can cause jobserver problems.
        cmd.env_remove("MAKEFLAGS");
        cmd.env_remove("MFLAGS");

1270
        if let Some(linker) = self.linker(compiler.host) {
1271 1272
            cmd.env("RUSTDOC_LINKER", linker);
        }
1273
        if self.is_fuse_ld_lld(compiler.host) {
1274
            cmd.env("RUSTDOC_FUSE_LD_LLD", "1");
O
Oliver Schneider 已提交
1275
        }
M
Mark Simulacrum 已提交
1276
        cmd
1277 1278
    }

1279 1280 1281 1282
    /// Return the path to `llvm-config` for the target, if it exists.
    ///
    /// Note that this returns `None` if LLVM is disabled, or if we're in a
    /// check build or dry-run, where there's no need to build all of LLVM.
1283
    fn llvm_config(&self, target: TargetSelection) -> Option<PathBuf> {
1284 1285 1286 1287 1288 1289 1290 1291 1292
        if self.config.llvm_enabled() && self.kind != Kind::Check && !self.config.dry_run {
            let llvm_config = self.ensure(native::Llvm { target });
            if llvm_config.is_file() {
                return Some(llvm_config);
            }
        }
        None
    }

1293 1294 1295 1296 1297
    /// Convenience wrapper to allow `builder.llvm_link_shared()` instead of `builder.config.llvm_link_shared(&builder)`.
    pub(crate) fn llvm_link_shared(&self) -> bool {
        Config::llvm_link_shared(self)
    }

1298 1299 1300 1301
    pub(crate) fn download_rustc(&self) -> bool {
        Config::download_rustc(self)
    }

1302 1303 1304 1305
    pub(crate) fn initial_rustfmt(&self) -> Option<PathBuf> {
        Config::initial_rustfmt(self)
    }

1306 1307 1308 1309 1310 1311 1312
    /// Prepares an invocation of `cargo` to be run.
    ///
    /// This will create a `Command` that represents a pending execution of
    /// Cargo. This cargo will be configured to use `compiler` as the actual
    /// rustc compiler, its output will be scoped by `mode`'s output directory,
    /// it will pass the `--target` flag for the specified `target`, and will be
    /// executing the Cargo command `cmd`.
S
Santiago Pastorino 已提交
1313 1314 1315 1316
    pub fn cargo(
        &self,
        compiler: Compiler,
        mode: Mode,
1317
        source_type: SourceType,
1318
        target: TargetSelection,
S
Santiago Pastorino 已提交
1319
        cmd: &str,
1320
    ) -> Cargo {
M
Mark Simulacrum 已提交
1321 1322
        let mut cargo = Command::new(&self.initial_cargo);
        let out_dir = self.stage_out(compiler, mode);
1323

1324 1325 1326 1327 1328 1329
        // Codegen backends are not yet tracked by -Zbinary-dep-depinfo,
        // so we need to explicitly clear out if they've been updated.
        for backend in self.codegen_backends(compiler) {
            self.clear_if_dirty(&out_dir, &backend);
        }

1330
        if cmd == "doc" || cmd == "rustdoc" {
1331
            let my_out = match mode {
1332
                // This is the intended out directory for compiler documentation.
1333
                Mode::Rustc | Mode::ToolRustc => self.compiler_doc_out(target),
1334
                Mode::Std => out_dir.join(target.triple).join("doc"),
E
Eric Huss 已提交
1335
                _ => panic!("doc mode {:?} not expected", mode),
1336
            };
M
Mark Rousskov 已提交
1337
            let rustdoc = self.rustdoc(compiler);
1338 1339 1340
            self.clear_if_dirty(&my_out, &rustdoc);
        }

J
Jonas Schievink 已提交
1341
        cargo.env("CARGO_TARGET_DIR", &out_dir).arg(cmd);
1342 1343

        let profile_var = |name: &str| {
M
Mark Rousskov 已提交
1344
            let profile = if self.config.rust_optimize { "RELEASE" } else { "DEV" };
1345 1346
            format!("CARGO_PROFILE_{}_{}", profile, name)
        };
1347

1348
        // See comment in rustc_llvm/build.rs for why this is necessary, largely llvm-config
1349 1350 1351 1352 1353 1354
        // needs to not accidentally link to libLLVM in stage0/lib.
        cargo.env("REAL_LIBRARY_PATH_VAR", &util::dylib_path_var());
        if let Some(e) = env::var_os(util::dylib_path_var()) {
            cargo.env("REAL_LIBRARY_PATH", e);
        }

1355 1356 1357 1358
        // Found with `rg "init_env_logger\("`. If anyone uses `init_env_logger`
        // from out of tree it shouldn't matter, since x.py is only used for
        // building in-tree.
        let color_logs = ["RUSTDOC_LOG_COLOR", "RUSTC_LOG_COLOR", "RUST_LOG_COLOR"];
J
Joshua Nelson 已提交
1359 1360 1361
        match self.build.config.color {
            Color::Always => {
                cargo.arg("--color=always");
1362 1363 1364
                for log in &color_logs {
                    cargo.env(log, "always");
                }
J
Joshua Nelson 已提交
1365 1366 1367
            }
            Color::Never => {
                cargo.arg("--color=never");
1368 1369 1370
                for log in &color_logs {
                    cargo.env(log, "never");
                }
J
Joshua Nelson 已提交
1371 1372 1373 1374
            }
            Color::Auto => {} // nothing to do
        }

1375
        if cmd != "install" {
1376
            cargo.arg("--target").arg(target.rustc_target_arg());
1377 1378 1379
        } else {
            assert_eq!(target, compiler.host);
        }
1380

L
ljedrz 已提交
1381
        // Set a flag for `check`/`clippy`/`fix`, so that certain build
1382
        // scripts can do less work (i.e. not building/requiring LLVM).
L
ljedrz 已提交
1383
        if cmd == "check" || cmd == "clippy" || cmd == "fix" {
1384
            // If we've not yet built LLVM, or it's stale, then bust
1385
            // the rustc_llvm cache. That will always work, even though it
1386
            // may mean that on the next non-check build we'll need to rebuild
1387
            // rustc_llvm. But if LLVM is stale, that'll be a tiny amount
1388
            // of work comparatively, and we'd likely need to rebuild it anyway,
1389 1390 1391 1392
            // so that's okay.
            if crate::native::prebuilt_llvm_config(self, target).is_err() {
                cargo.env("RUST_CHECK", "1");
            }
V
varkor 已提交
1393 1394
        }

1395
        let stage = if compiler.stage == 0 && self.local_rebuild {
1396
            // Assume the local-rebuild rustc already has stage1 features.
1397
            1
1398
        } else {
1399 1400
            compiler.stage
        };
1401

1402
        let mut rustflags = Rustflags::new(target);
1403
        if stage != 0 {
1404 1405 1406
            if let Ok(s) = env::var("CARGOFLAGS_NOT_BOOTSTRAP") {
                cargo.args(s.split_whitespace());
            }
1407 1408
            rustflags.env("RUSTFLAGS_NOT_BOOTSTRAP");
        } else {
1409 1410 1411
            if let Ok(s) = env::var("CARGOFLAGS_BOOTSTRAP") {
                cargo.args(s.split_whitespace());
            }
1412
            rustflags.env("RUSTFLAGS_BOOTSTRAP");
J
Joshua Nelson 已提交
1413
            if cmd == "clippy" {
1414 1415
                // clippy overwrites sysroot if we pass it to cargo.
                // Pass it directly to clippy instead.
J
Joshua Nelson 已提交
1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428
                // NOTE: this can't be fixed in clippy because we explicitly don't set `RUSTC`,
                // so it has no way of knowing the sysroot.
                rustflags.arg("--sysroot");
                rustflags.arg(
                    self.sysroot(compiler)
                        .as_os_str()
                        .to_str()
                        .expect("sysroot must be valid UTF-8"),
                );
                // Only run clippy on a very limited subset of crates (in particular, not build scripts).
                cargo.arg("-Zunstable-options");
                // Explicitly does *not* set `--cfg=bootstrap`, since we're using a nightly clippy.
                let host_version = Command::new("rustc").arg("--version").output().map_err(|_| ());
1429
                let output = host_version.and_then(|output| {
1430
                    if output.status.success() {
J
Joshua Nelson 已提交
1431 1432 1433 1434
                        Ok(output)
                    } else {
                        Err(())
                    }
1435
                }).unwrap_or_else(|_| {
J
Joshua Nelson 已提交
1436
                    eprintln!(
1437
                        "error: `x.py clippy` requires a host `rustc` toolchain with the `clippy` component"
J
Joshua Nelson 已提交
1438
                    );
1439
                    eprintln!("help: try `rustup component add clippy`");
J
Joshua Nelson 已提交
1440
                    std::process::exit(1);
1441 1442 1443
                });
                if !t!(std::str::from_utf8(&output.stdout)).contains("nightly") {
                    rustflags.arg("--cfg=bootstrap");
J
Joshua Nelson 已提交
1444 1445 1446 1447
                }
            } else {
                rustflags.arg("--cfg=bootstrap");
            }
1448 1449
        }

1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465
        let use_new_symbol_mangling = match self.config.rust_new_symbol_mangling {
            Some(setting) => {
                // If an explicit setting is given, use that
                setting
            }
            None => {
                if mode == Mode::Std {
                    // The standard library defaults to the legacy scheme
                    false
                } else {
                    // The compiler and tools default to the new scheme
                    true
                }
            }
        };

P
Pietro Albini 已提交
1466 1467
        if use_new_symbol_mangling {
            rustflags.arg("-Csymbol-mangling-version=v0");
1468
        } else {
P
Pietro Albini 已提交
1469 1470
            rustflags.arg("-Csymbol-mangling-version=legacy");
            rustflags.arg("-Zunstable-options");
1471 1472
        }

1473 1474 1475 1476
        // FIXME(Urgau): This a hack as it shouldn't be gated on stage 0 but until `rustc_llvm`
        // is made to work with `--check-cfg` which is currently not easly possible until cargo
        // get some support for setting `--check-cfg` within build script, it's the least invasive
        // hack that still let's us have cfg checking for the vast majority of the codebase.
1477
        if stage != 0 {
1478 1479
            // Enable cfg checking of cargo features for everything but std and also enable cfg
            // checking of names and values.
1480 1481
            //
            // Note: `std`, `alloc` and `core` imports some dependencies by #[path] (like
1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492
            // backtrace, core_simd, std_float, ...), those dependencies have their own
            // features but cargo isn't involved in the #[path] process and so cannot pass the
            // complete list of features, so for that reason we don't enable checking of
            // features for std crates.
            cargo.arg(if mode != Mode::Std {
                "-Zcheck-cfg=names,values,features"
            } else {
                "-Zcheck-cfg=names,values"
            });

            // Add extra cfg not defined in/by rustc
U
Urgau 已提交
1493
            //
1494 1495 1496 1497
            // Note: Altrough it would seems that "-Zunstable-options" to `rustflags` is useless as
            // cargo would implicitly add it, it was discover that sometimes bootstrap only use
            // `rustflags` without `cargo` making it required.
            rustflags.arg("-Zunstable-options");
1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514
            for (restricted_mode, name, values) in EXTRA_CHECK_CFGS {
                if *restricted_mode == None || *restricted_mode == Some(mode) {
                    // Creating a string of the values by concatenating each value:
                    // ',"tvos","watchos"' or '' (nothing) when there are no values
                    let values = match values {
                        Some(values) => values
                            .iter()
                            .map(|val| [",", "\"", val, "\""])
                            .flatten()
                            .collect::<String>(),
                        None => String::new(),
                    };
                    rustflags.arg(&format!("--check-cfg=values({name}{values})"));
                }
            }
        }

1515 1516 1517
        // FIXME: It might be better to use the same value for both `RUSTFLAGS` and `RUSTDOCFLAGS`,
        // but this breaks CI. At the very least, stage0 `rustdoc` needs `--cfg bootstrap`. See
        // #71458.
1518
        let mut rustdocflags = rustflags.clone();
1519 1520 1521 1522 1523 1524
        rustdocflags.propagate_cargo_env("RUSTDOCFLAGS");
        if stage == 0 {
            rustdocflags.env("RUSTDOCFLAGS_BOOTSTRAP");
        } else {
            rustdocflags.env("RUSTDOCFLAGS_NOT_BOOTSTRAP");
        }
1525

1526 1527 1528 1529
        if let Ok(s) = env::var("CARGOFLAGS") {
            cargo.args(s.split_whitespace());
        }

J
John Kåre Alsaker 已提交
1530
        match mode {
M
Mark Rousskov 已提交
1531
            Mode::Std | Mode::ToolBootstrap | Mode::ToolStd => {}
1532
            Mode::Rustc | Mode::Codegen | Mode::ToolRustc => {
J
John Kåre Alsaker 已提交
1533 1534 1535
                // Build proc macros both for the host and the target
                if target != compiler.host && cmd != "check" {
                    cargo.arg("-Zdual-proc-macros");
1536
                    rustflags.arg("-Zdual-proc-macros");
J
John Kåre Alsaker 已提交
1537
                }
M
Mark Rousskov 已提交
1538
            }
J
John Kåre Alsaker 已提交
1539 1540
        }

1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552
        // This tells Cargo (and in turn, rustc) to output more complete
        // dependency information.  Most importantly for rustbuild, this
        // includes sysroot artifacts, like libstd, which means that we don't
        // need to track those in rustbuild (an error prone process!). This
        // feature is currently unstable as there may be some bugs and such, but
        // it represents a big improvement in rustbuild's reliability on
        // rebuilds, so we're using it here.
        //
        // For some additional context, see #63470 (the PR originally adding
        // this), as well as #63012 which is the tracking issue for this
        // feature on the rustc side.
        cargo.arg("-Zbinary-dep-depinfo");
1553 1554 1555 1556 1557 1558
        match mode {
            Mode::ToolBootstrap => {
                // Restrict the allowed features to those passed by rustbuild, so we don't depend on nightly accidentally.
                // HACK: because anyhow does feature detection in build.rs, we need to allow the backtrace feature too.
                rustflags.arg("-Zallow-features=binary-dep-depinfo,backtrace");
            }
1559 1560 1561 1562 1563 1564
            Mode::ToolStd => {
                // Right now this is just compiletest and a few other tools that build on stable.
                // Allow them to use `feature(test)`, but nothing else.
                rustflags.arg("-Zallow-features=binary-dep-depinfo,test,backtrace");
            }
            Mode::Std | Mode::Rustc | Mode::Codegen | Mode::ToolRustc => {}
1565
        }
1566

1567 1568 1569 1570
        cargo.arg("-j").arg(self.jobs().to_string());
        // Remove make-related flags to ensure Cargo can correctly set things up
        cargo.env_remove("MAKEFLAGS");
        cargo.env_remove("MFLAGS");
1571

1572 1573
        // FIXME: Temporary fix for https://github.com/rust-lang/cargo/issues/3005
        // Force cargo to output binaries with disambiguating hashes in the name
1574 1575
        let mut metadata = if compiler.stage == 0 {
            // Treat stage0 like a special channel, whether it's a normal prior-
1576 1577
            // release rustc or a local rebuild with the same version, so we
            // never mix these libraries by accident.
1578
            "bootstrap".to_string()
1579
        } else {
1580
            self.config.channel.to_string()
1581
        };
1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594
        // We want to make sure that none of the dependencies between
        // std/test/rustc unify with one another. This is done for weird linkage
        // reasons but the gist of the problem is that if librustc, libtest, and
        // libstd all depend on libc from crates.io (which they actually do) we
        // want to make sure they all get distinct versions. Things get really
        // weird if we try to unify all these dependencies right now, namely
        // around how many times the library is linked in dynamic libraries and
        // such. If rustc were a static executable or if we didn't ship dylibs
        // this wouldn't be a problem, but we do, so it is. This is in general
        // just here to make sure things build right. If you can remove this and
        // things still build right, please do!
        match mode {
            Mode::Std => metadata.push_str("std"),
M
Mark Rousskov 已提交
1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605
            // When we're building rustc tools, they're built with a search path
            // that contains things built during the rustc build. For example,
            // bitflags is built during the rustc build, and is a dependency of
            // rustdoc as well. We're building rustdoc in a different target
            // directory, though, which means that Cargo will rebuild the
            // dependency. When we go on to build rustdoc, we'll look for
            // bitflags, and find two different copies: one built during the
            // rustc step and one that we just built. This isn't always a
            // problem, somehow -- not really clear why -- but we know that this
            // fixes things.
            Mode::ToolRustc => metadata.push_str("tool-rustc"),
1606 1607
            // Same for codegen backends.
            Mode::Codegen => metadata.push_str("codegen"),
M
Mark Rousskov 已提交
1608
            _ => {}
1609
        }
1610
        cargo.env("__CARGO_DEFAULT_LIB_METADATA", &metadata);
1611

L
ljedrz 已提交
1612
        if cmd == "clippy" {
1613
            rustflags.arg("-Zforce-unstable-if-unmarked");
1614 1615
        }

J
Jonas Schievink 已提交
1616
        rustflags.arg("-Zmacro-backtrace");
1617

K
kennytm 已提交
1618
        let want_rustdoc = self.doc_tests != DocTests::No;
K
kennytm 已提交
1619

1620 1621 1622 1623 1624 1625
        // We synthetically interpret a stage0 compiler used to build tools as a
        // "raw" compiler in that it's the exact snapshot we download. Normally
        // the stage0 build means it uses libraries build by the stage0
        // compiler, but for tools we just use the precompiled libraries that
        // we've downloaded
        let use_snapshot = mode == Mode::ToolBootstrap;
1626
        assert!(!use_snapshot || stage == 0 || self.local_rebuild);
1627 1628

        let maybe_sysroot = self.sysroot(compiler);
M
Mark Rousskov 已提交
1629
        let sysroot = if use_snapshot { self.rustc_snapshot_sysroot() } else { &maybe_sysroot };
M
Mark Rousskov 已提交
1630
        let libdir = self.rustc_libdir(compiler);
1631

1632 1633 1634 1635 1636 1637 1638 1639
        // Clear the output directory if the real rustc we're using has changed;
        // Cargo cannot detect this as it thinks rustc is bootstrap/debug/rustc.
        //
        // Avoid doing this during dry run as that usually means the relevant
        // compiler is not yet linked/copied properly.
        //
        // Only clear out the directory if we're compiling std; otherwise, we
        // should let Cargo take care of things for us (via depdep info)
M
Mark Rousskov 已提交
1640
        if !self.config.dry_run && mode == Mode::Std && cmd == "build" {
1641 1642 1643
            self.clear_if_dirty(&out_dir, &self.rustc(compiler));
        }

1644 1645
        // Customize the compiler we're running. Specify the compiler to cargo
        // as our shim and then pass it some various options used to configure
M
Mark Simulacrum 已提交
1646
        // how the actual compiler itself is called.
1647 1648 1649
        //
        // These variables are primarily all read by
        // src/bootstrap/bin/{rustc.rs,rustdoc.rs}
S
Santiago Pastorino 已提交
1650 1651 1652 1653
        cargo
            .env("RUSTBUILD_NATIVE_DIR", self.native_dir(target))
            .env("RUSTC_REAL", self.rustc(compiler))
            .env("RUSTC_STAGE", stage.to_string())
1654 1655
            .env("RUSTC_SYSROOT", &sysroot)
            .env("RUSTC_LIBDIR", &libdir)
1656
            .env("RUSTDOC", self.bootstrap_out.join("rustdoc"))
S
Santiago Pastorino 已提交
1657 1658
            .env(
                "RUSTDOC_REAL",
1659
                if cmd == "doc" || cmd == "rustdoc" || (cmd == "test" && want_rustdoc) {
M
Mark Rousskov 已提交
1660
                    self.rustdoc(compiler)
S
Santiago Pastorino 已提交
1661 1662 1663 1664
                } else {
                    PathBuf::from("/path/to/nowhere/rustdoc/not/required")
                },
            )
1665 1666
            .env("RUSTC_ERROR_METADATA_DST", self.extended_error_dir())
            .env("RUSTC_BREAK_ON_ICE", "1");
J
Joshua Nelson 已提交
1667 1668 1669
        // Clippy support is a hack and uses the default `cargo-clippy` in path.
        // Don't override RUSTC so that the `cargo-clippy` in path will be run.
        if cmd != "clippy" {
1670
            cargo.env("RUSTC", self.bootstrap_out.join("rustc"));
J
Joshua Nelson 已提交
1671
        }
1672

1673 1674 1675 1676 1677 1678 1679 1680 1681
        // Dealing with rpath here is a little special, so let's go into some
        // detail. First off, `-rpath` is a linker option on Unix platforms
        // which adds to the runtime dynamic loader path when looking for
        // dynamic libraries. We use this by default on Unix platforms to ensure
        // that our nightlies behave the same on Windows, that is they work out
        // of the box. This can be disabled, of course, but basically that's why
        // we're gated on RUSTC_RPATH here.
        //
        // Ok, so the astute might be wondering "why isn't `-C rpath` used
K
KRAAI, MATTHEW [VISUS] 已提交
1682
        // here?" and that is indeed a good question to ask. This codegen
1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698
        // option is the compiler's current interface to generating an rpath.
        // Unfortunately it doesn't quite suffice for us. The flag currently
        // takes no value as an argument, so the compiler calculates what it
        // should pass to the linker as `-rpath`. This unfortunately is based on
        // the **compile time** directory structure which when building with
        // Cargo will be very different than the runtime directory structure.
        //
        // All that's a really long winded way of saying that if we use
        // `-Crpath` then the executables generated have the wrong rpath of
        // something like `$ORIGIN/deps` when in fact the way we distribute
        // rustc requires the rpath to be `$ORIGIN/../lib`.
        //
        // So, all in all, to set up the correct rpath we pass the linker
        // argument manually via `-C link-args=-Wl,-rpath,...`. Plus isn't it
        // fun to pass a flag to a tool to pass a flag to pass a flag to a tool
        // to change a flag in a binary?
1699
        if self.config.rust_rpath && util::use_host_linker(target) {
1700 1701 1702 1703 1704 1705 1706 1707
            let rpath = if target.contains("apple") {
                // Note that we need to take one extra step on macOS to also pass
                // `-Wl,-instal_name,@rpath/...` to get things to work right. To
                // do that we pass a weird flag to the compiler to get it to do
                // so. Note that this is definitely a hack, and we should likely
                // flesh out rpath support more fully in the future.
                rustflags.arg("-Zosx-rpath-install-name");
                Some("-Wl,-rpath,@loader_path/../lib")
1708
            } else if !target.contains("windows") {
1709
                rustflags.arg("-Clink-args=-Wl,-z,origin");
1710 1711 1712 1713 1714 1715 1716 1717 1718
                Some("-Wl,-rpath,$ORIGIN/../lib")
            } else {
                None
            };
            if let Some(rpath) = rpath {
                rustflags.arg(&format!("-Clink-args={}", rpath));
            }
        }

1719
        if let Some(host_linker) = self.linker(compiler.host) {
O
Oliver Schneider 已提交
1720 1721
            cargo.env("RUSTC_HOST_LINKER", host_linker);
        }
1722
        if self.is_fuse_ld_lld(compiler.host) {
1723
            cargo.env("RUSTC_HOST_FUSE_LD_LLD", "1");
1724
            cargo.env("RUSTDOC_FUSE_LD_LLD", "1");
1725
        }
1726

1727
        if let Some(target_linker) = self.linker(target) {
1728
            let target = crate::envify(&target.triple);
1729
            cargo.env(&format!("CARGO_TARGET_{}_LINKER", target), target_linker);
O
Oliver Schneider 已提交
1730
        }
1731
        if self.is_fuse_ld_lld(target) {
1732 1733
            rustflags.arg("-Clink-args=-fuse-ld=lld");
        }
1734 1735 1736
        self.lld_flags(target).for_each(|flag| {
            rustdocflags.arg(&flag);
        });
1737

L
ljedrz 已提交
1738
        if !(["build", "check", "clippy", "fix", "rustc"].contains(&cmd)) && want_rustdoc {
M
Mark Rousskov 已提交
1739
            cargo.env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler));
1740
        }
1741

1742
        let debuginfo_level = match mode {
1743
            Mode::Rustc | Mode::Codegen => self.config.rust_debuginfo_level_rustc,
1744
            Mode::Std => self.config.rust_debuginfo_level_std,
M
Mark Rousskov 已提交
1745 1746 1747
            Mode::ToolBootstrap | Mode::ToolStd | Mode::ToolRustc => {
                self.config.rust_debuginfo_level_tools
            }
1748
        };
1749
        cargo.env(profile_var("DEBUG"), debuginfo_level.to_string());
1750 1751 1752 1753 1754 1755 1756 1757
        cargo.env(
            profile_var("DEBUG_ASSERTIONS"),
            if mode == Mode::Std {
                self.config.rust_debug_assertions_std.to_string()
            } else {
                self.config.rust_debug_assertions.to_string()
            },
        );
1758 1759 1760 1761 1762 1763 1764 1765
        cargo.env(
            profile_var("OVERFLOW_CHECKS"),
            if mode == Mode::Std {
                self.config.rust_overflow_checks_std.to_string()
            } else {
                self.config.rust_overflow_checks.to_string()
            },
        );
1766

M
Mark Rousskov 已提交
1767
        if !target.contains("windows") {
1768 1769 1770
            let needs_unstable_opts = target.contains("linux")
                || target.contains("windows")
                || target.contains("bsd")
1771 1772
                || target.contains("dragonfly")
                || target.contains("illumos");
1773 1774

            if needs_unstable_opts {
1775
                rustflags.arg("-Zunstable-options");
1776
            }
1777 1778 1779 1780 1781
            match self.config.rust_split_debuginfo {
                SplitDebuginfo::Packed => rustflags.arg("-Csplit-debuginfo=packed"),
                SplitDebuginfo::Unpacked => rustflags.arg("-Csplit-debuginfo=unpacked"),
                SplitDebuginfo::Off => rustflags.arg("-Csplit-debuginfo=off"),
            };
1782 1783
        }

1784 1785 1786 1787 1788
        if self.config.cmd.bless() {
            // Bless `expect!` tests.
            cargo.env("UPDATE_EXPECT", "1");
        }

1789
        if !mode.is_tool() {
O
Oliver Schneider 已提交
1790
            cargo.env("RUSTC_FORCE_UNSTABLE", "1");
1791 1792
        }

1793
        if let Some(x) = self.crt_static(target) {
1794 1795 1796 1797 1798
            if x {
                rustflags.arg("-Ctarget-feature=+crt-static");
            } else {
                rustflags.arg("-Ctarget-feature=-crt-static");
            }
1799 1800
        }

1801 1802 1803 1804
        if let Some(x) = self.crt_static(compiler.host) {
            cargo.env("RUSTC_HOST_CRT_STATIC", x.to_string());
        }

1805 1806
        if let Some(map_to) = self.build.debuginfo_map_to(GitRepo::Rustc) {
            let map = format!("{}={}", self.build.src.display(), map_to);
1807
            cargo.env("RUSTC_DEBUGINFO_MAP", map);
1808 1809 1810 1811

            // `rustc` needs to know the virtual `/rustc/$hash` we're mapping to,
            // in order to opportunistically reverse it later.
            cargo.env("CFG_VIRTUAL_RUST_SOURCE_BASE_DIR", map_to);
1812 1813
        }

1814 1815
        // Enable usage of unstable features
        cargo.env("RUSTC_BOOTSTRAP", "1");
M
Mark Simulacrum 已提交
1816
        self.add_rust_test_threads(&mut cargo);
1817 1818 1819

        // Almost all of the crates that we compile as part of the bootstrap may
        // have a build script, including the standard library. To compile a
M
Mark Simulacrum 已提交
1820
        // build script, however, it itself needs a standard library! This
1821
        // introduces a bit of a pickle when we're compiling the standard
M
Mark Simulacrum 已提交
1822
        // library itself.
1823 1824
        //
        // To work around this we actually end up using the snapshot compiler
M
Mark Simulacrum 已提交
1825
        // (stage0) for compiling build scripts of the standard library itself.
1826 1827 1828 1829 1830
        // The stage0 compiler is guaranteed to have a libstd available for use.
        //
        // For other crates, however, we know that we've already got a standard
        // library up and running, so we can use the normal compiler to compile
        // build scripts in that situation.
B
bjorn3 已提交
1831
        if mode == Mode::Std {
S
Santiago Pastorino 已提交
1832 1833 1834
            cargo
                .env("RUSTC_SNAPSHOT", &self.initial_rustc)
                .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_snapshot_libdir());
1835
        } else {
S
Santiago Pastorino 已提交
1836 1837 1838
            cargo
                .env("RUSTC_SNAPSHOT", self.rustc(compiler))
                .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_libdir(compiler));
1839 1840
        }

1841 1842 1843 1844
        // Tools that use compiler libraries may inherit the `-lLLVM` link
        // requirement, but the `-L` library path is not propagated across
        // separate Cargo projects. We can add LLVM's library path to the
        // platform-specific environment variable as a workaround.
1845
        if mode == Mode::ToolRustc || mode == Mode::Codegen {
1846 1847 1848 1849
            if let Some(llvm_config) = self.llvm_config(target) {
                let llvm_libdir = output(Command::new(&llvm_config).arg("--libdir"));
                add_link_lib_path(vec![llvm_libdir.trim().into()], &mut cargo);
            }
1850 1851
        }

1852 1853 1854 1855
        // Compile everything except libraries and proc macros with the more
        // efficient initial-exec TLS model. This doesn't work with `dlopen`,
        // so we can't use it by default in general, but we can use it for tools
        // and our own internal libraries.
1856
        if !mode.must_support_dlopen() && !target.triple.starts_with("powerpc-") {
1857 1858 1859
            rustflags.arg("-Ztls-model=initial-exec");
        }

1860
        if self.config.incremental {
1861
            cargo.env("CARGO_INCREMENTAL", "1");
1862 1863 1864
        } else {
            // Don't rely on any default setting for incr. comp. in Cargo
            cargo.env("CARGO_INCREMENTAL", "0");
1865 1866
        }

M
Mark Simulacrum 已提交
1867
        if let Some(ref on_fail) = self.config.on_fail {
1868 1869 1870
            cargo.env("RUSTC_ON_FAIL", on_fail);
        }

1871 1872 1873 1874
        if self.config.print_step_timings {
            cargo.env("RUSTC_PRINT_STEP_TIMINGS", "1");
        }

1875 1876 1877 1878
        if self.config.print_step_rusage {
            cargo.env("RUSTC_PRINT_STEP_RUSAGE", "1");
        }

J
John Kåre Alsaker 已提交
1879 1880 1881 1882
        if self.config.backtrace_on_ice {
            cargo.env("RUSTC_BACKTRACE_ON_ICE", "1");
        }

L
ljedrz 已提交
1883
        cargo.env("RUSTC_VERBOSE", self.verbosity.to_string());
1884

1885
        if source_type == SourceType::InTree {
1886
            let mut lint_flags = Vec::new();
1887 1888 1889
            // When extending this list, add the new lints to the RUSTFLAGS of the
            // build_bootstrap function of src/bootstrap/bootstrap.py as well as
            // some code doesn't go through this `rustc` wrapper.
1890 1891
            lint_flags.push("-Wrust_2018_idioms");
            lint_flags.push("-Wunused_lifetimes");
1892
            lint_flags.push("-Wsemicolon_in_expressions_from_macros");
1893 1894

            if self.config.deny_warnings {
1895
                lint_flags.push("-Dwarnings");
1896
                rustdocflags.arg("-Dwarnings");
1897
            }
1898

1899 1900 1901 1902 1903 1904 1905 1906 1907
            // This does not use RUSTFLAGS due to caching issues with Cargo.
            // Clippy is treated as an "in tree" tool, but shares the same
            // cache as other "submodule" tools. With these options set in
            // RUSTFLAGS, that causes *every* shared dependency to be rebuilt.
            // By injecting this into the rustc wrapper, this circumvents
            // Cargo's fingerprint detection. This is fine because lint flags
            // are always ignored in dependencies. Eventually this should be
            // fixed via better support from Cargo.
            cargo.env("RUSTC_LINT_FLAGS", lint_flags.join(" "));
G
Guillaume Gomez 已提交
1908

M
Mark Rousskov 已提交
1909
            rustdocflags.arg("-Wrustdoc::invalid_codeblock_attributes");
1910 1911
        }

1912
        if mode == Mode::Rustc {
A
Alex Crichton 已提交
1913 1914
            rustflags.arg("-Zunstable-options");
            rustflags.arg("-Wrustc::internal");
1915 1916
        }

O
Oliver Schneider 已提交
1917 1918 1919 1920 1921
        // Throughout the build Cargo can execute a number of build scripts
        // compiling C/C++ code and we need to pass compilers, archivers, flags, etc
        // obtained previously to those build scripts.
        // Build scripts use either the `cc` crate or `configure/make` so we pass
        // the options through environment variables that are fetched and understood by both.
1922 1923
        //
        // FIXME: the guard against msvc shouldn't need to be here
1924 1925 1926 1927 1928
        if target.contains("msvc") {
            if let Some(ref cl) = self.config.llvm_clang_cl {
                cargo.env("CC", cl).env("CXX", cl);
            }
        } else {
1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945
            let ccache = self.config.ccache.as_ref();
            let ccacheify = |s: &Path| {
                let ccache = match ccache {
                    Some(ref s) => s,
                    None => return s.display().to_string(),
                };
                // FIXME: the cc-rs crate only recognizes the literal strings
                // `ccache` and `sccache` when doing caching compilations, so we
                // mirror that here. It should probably be fixed upstream to
                // accept a new env var or otherwise work with custom ccache
                // vars.
                match &ccache[..] {
                    "ccache" | "sccache" => format!("{} {}", ccache, s.display()),
                    _ => s.display().to_string(),
                }
            };
            let cc = ccacheify(&self.cc(target));
1946
            cargo.env(format!("CC_{}", target.triple), &cc);
O
Oliver Schneider 已提交
1947

1948
            let cflags = self.cflags(target, GitRepo::Rustc, CLang::C).join(" ");
1949
            cargo.env(format!("CFLAGS_{}", target.triple), &cflags);
O
Oliver Schneider 已提交
1950 1951 1952

            if let Some(ar) = self.ar(target) {
                let ranlib = format!("{} s", ar.display());
1953 1954 1955
                cargo
                    .env(format!("AR_{}", target.triple), ar)
                    .env(format!("RANLIB_{}", target.triple), ranlib);
O
Oliver Schneider 已提交
1956
            }
1957

M
Mark Simulacrum 已提交
1958
            if let Ok(cxx) = self.cxx(target) {
1959
                let cxx = ccacheify(&cxx);
1960
                let cxxflags = self.cflags(target, GitRepo::Rustc, CLang::Cxx).join(" ");
S
Santiago Pastorino 已提交
1961
                cargo
1962
                    .env(format!("CXX_{}", target.triple), &cxx)
1963
                    .env(format!("CXXFLAGS_{}", target.triple), cxxflags);
1964 1965 1966
            }
        }

M
Mark Rousskov 已提交
1967
        if mode == Mode::Std && self.config.extended && compiler.is_final_stage(self) {
1968
            rustflags.arg("-Zsave-analysis");
M
Mark Rousskov 已提交
1969 1970 1971
            cargo.env(
                "RUST_SAVE_ANALYSIS_CONFIG",
                "{\"output_file\": null,\"full_docs\": false,\
1972
                       \"pub_only\": true,\"reachable_only\": false,\
M
Mark Rousskov 已提交
1973 1974
                       \"distro_crate\": true,\"signatures\": false,\"borrow_data\": false}",
            );
1975 1976
        }

A
Andrew Paverd 已提交
1977
        // If Control Flow Guard is enabled, pass the `control-flow-guard` flag to rustc
1978 1979 1980 1981 1982 1983 1984 1985 1986 1987
        // when compiling the standard library, since this might be linked into the final outputs
        // produced by rustc. Since this mitigation is only available on Windows, only enable it
        // for the standard library in case the compiler is run on a non-Windows platform.
        // This is not needed for stage 0 artifacts because these will only be used for building
        // the stage 1 compiler.
        if cfg!(windows)
            && mode == Mode::Std
            && self.config.control_flow_guard
            && compiler.stage >= 1
        {
1988
            rustflags.arg("-Ccontrol-flow-guard");
1989 1990
        }

O
Oliver Schneider 已提交
1991
        // For `cargo doc` invocations, make rustdoc print the Rust version into the docs
1992 1993 1994 1995 1996
        // This replaces spaces with newlines because RUSTDOCFLAGS does not
        // support arguments with regular spaces. Hopefully someday Cargo will
        // have space support.
        let rust_version = self.rust_version().replace(' ', "\n");
        rustdocflags.arg("--crate-version").arg(&rust_version);
O
Oliver Schneider 已提交
1997

1998 1999 2000
        // Environment variables *required* throughout the build
        //
        // FIXME: should update code to not require this env var
2001
        cargo.env("CFG_COMPILER_HOST_TRIPLE", target.triple);
2002

2003
        // Set this for all builds to make sure doc builds also get it.
2004
        cargo.env("CFG_RELEASE_CHANNEL", &self.config.channel);
2005

2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023
        // This one's a bit tricky. As of the time of this writing the compiler
        // links to the `winapi` crate on crates.io. This crate provides raw
        // bindings to Windows system functions, sort of like libc does for
        // Unix. This crate also, however, provides "import libraries" for the
        // MinGW targets. There's an import library per dll in the windows
        // distribution which is what's linked to. These custom import libraries
        // are used because the winapi crate can reference Windows functions not
        // present in the MinGW import libraries.
        //
        // For example MinGW may ship libdbghelp.a, but it may not have
        // references to all the functions in the dbghelp dll. Instead the
        // custom import library for dbghelp in the winapi crates has all this
        // information.
        //
        // Unfortunately for us though the import libraries are linked by
        // default via `-ldylib=winapi_foo`. That is, they're linked with the
        // `dylib` type with a `winapi_` prefix (so the winapi ones don't
        // conflict with the system MinGW ones). This consequently means that
I
Irina Popa 已提交
2024
        // the binaries we ship of things like rustc_codegen_llvm (aka the rustc_codegen_llvm
2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036
        // DLL) when linked against *again*, for example with procedural macros
        // or plugins, will trigger the propagation logic of `-ldylib`, passing
        // `-lwinapi_foo` to the linker again. This isn't actually available in
        // our distribution, however, so the link fails.
        //
        // To solve this problem we tell winapi to not use its bundled import
        // libraries. This means that it will link to the system MinGW import
        // libraries by default, and the `-ldylib=foo` directives will still get
        // passed to the final linker, but they'll look like `-lfoo` which can
        // be resolved because MinGW has the import library. The downside is we
        // don't get newer functions from Windows, but we don't use any of them
        // anyway.
C
Collins Abitekaniza 已提交
2037
        if !mode.is_tool() {
A
Alex Crichton 已提交
2038 2039
            cargo.env("WINAPI_NO_BUNDLED_LIBRARIES", "1");
        }
2040

X
Ximin Luo 已提交
2041
        for _ in 0..self.verbosity {
2042 2043
            cargo.arg("-v");
        }
2044

2045
        match (mode, self.config.rust_codegen_units_std, self.config.rust_codegen_units) {
M
Mark Rousskov 已提交
2046
            (Mode::Std, Some(n), _) | (_, _, Some(n)) => {
2047
                cargo.env(profile_var("CODEGEN_UNITS"), n.to_string());
2048 2049 2050 2051
            }
            _ => {
                // Don't set anything
            }
2052 2053
        }

O
Oliver Schneider 已提交
2054
        if self.config.rust_optimize {
2055 2056
            // FIXME: cargo bench/install do not accept `--release`
            if cmd != "bench" && cmd != "install" {
O
Oliver Schneider 已提交
2057 2058
                cargo.arg("--release");
            }
2059
        }
2060

M
Mark Simulacrum 已提交
2061
        if self.config.locked_deps {
2062 2063
            cargo.arg("--locked");
        }
M
Mark Simulacrum 已提交
2064
        if self.config.vendor || self.is_sudo {
2065 2066 2067
            cargo.arg("--frozen");
        }

2068
        // Try to use a sysroot-relative bindir, in case it was configured absolutely.
2069
        cargo.env("RUSTC_INSTALL_BINDIR", self.config.bindir_relative());
2070

M
Mark Simulacrum 已提交
2071
        self.ci_env.force_coloring_in_ci(&mut cargo);
2072

2073 2074 2075
        // When we build Rust dylibs they're all intended for intermediate
        // usage, so make sure we pass the -Cprefer-dynamic flag instead of
        // linking all deps statically into the dylib.
2076
        if matches!(mode, Mode::Std | Mode::Rustc) {
A
Alex Crichton 已提交
2077
            rustflags.arg("-Cprefer-dynamic");
2078 2079
        }

2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094
        // When building incrementally we default to a lower ThinLTO import limit
        // (unless explicitly specified otherwise). This will produce a somewhat
        // slower code but give way better compile times.
        {
            let limit = match self.config.rust_thin_lto_import_instr_limit {
                Some(limit) => Some(limit),
                None if self.config.incremental => Some(10),
                _ => None,
            };

            if let Some(limit) = limit {
                rustflags.arg(&format!("-Cllvm-args=-import-instr-limit={}", limit));
            }
        }

2095
        Cargo { command: cargo, rustflags, rustdocflags }
2096 2097
    }

V
varkor 已提交
2098
    /// Ensure that a given step is built, returning its output. This will
2099 2100
    /// cache the step, so it is safe (and good!) to call this as often as
    /// needed to ensure that all dependencies are built.
2101
    pub fn ensure<S: Step>(&'a self, step: S) -> S::Output {
2102 2103
        {
            let mut stack = self.stack.borrow_mut();
2104 2105
            for stack_step in stack.iter() {
                // should skip
M
Mark Rousskov 已提交
2106
                if stack_step.downcast_ref::<S>().map_or(true, |stack_step| *stack_step != step) {
2107
                    continue;
2108
                }
2109
                let mut out = String::new();
2110
                out += &format!("\n\nCycle in build detected when adding {:?}\n", step);
2111 2112 2113
                for el in stack.iter().rev() {
                    out += &format!("\t{:?}\n", el);
                }
2114
                panic!("{}", out);
2115
            }
2116
            if let Some(out) = self.cache.get(&step) {
2117
                self.verbose_than(1, &format!("{}c {:?}", "  ".repeat(stack.len()), step));
2118 2119 2120

                return out;
            }
2121
            self.verbose_than(1, &format!("{}> {:?}", "  ".repeat(stack.len()), step));
2122
            stack.push(Box::new(step.clone()));
2123
        }
2124

2125 2126 2127
        #[cfg(feature = "build-metrics")]
        self.metrics.enter_step(&step);

2128 2129 2130 2131 2132 2133 2134 2135 2136 2137
        let (out, dur) = {
            let start = Instant::now();
            let zero = Duration::new(0, 0);
            let parent = self.time_spent_on_dependencies.replace(zero);
            let out = step.clone().run(self);
            let dur = start.elapsed();
            let deps = self.time_spent_on_dependencies.replace(parent + dur);
            (out, dur - deps)
        };

M
Mark Rousskov 已提交
2138
        if self.config.print_step_timings && !self.config.dry_run {
2139 2140 2141 2142 2143 2144 2145 2146 2147 2148
            let step_string = format!("{:?}", step);
            let brace_index = step_string.find("{").unwrap_or(0);
            let type_string = type_name::<S>();
            println!(
                "[TIMING] {} {} -- {}.{:03}",
                &type_string.strip_prefix("bootstrap::").unwrap_or(type_string),
                &step_string[brace_index..],
                dur.as_secs(),
                dur.subsec_millis()
            );
2149 2150
        }

2151 2152 2153
        #[cfg(feature = "build-metrics")]
        self.metrics.exit_step();

2154 2155
        {
            let mut stack = self.stack.borrow_mut();
2156 2157
            let cur_step = stack.pop().expect("step stack empty");
            assert_eq!(cur_step.downcast_ref(), Some(&step));
2158
        }
2159
        self.verbose_than(1, &format!("{}< {:?}", "  ".repeat(self.stack.borrow().len()), step));
2160 2161
        self.cache.put(step, out.clone());
        out
2162
    }
2163 2164 2165 2166 2167 2168 2169

    /// Ensure that a given step is built *only if it's supposed to be built by default*, returning
    /// its output. This will cache the step, so it's safe (and good!) to call this as often as
    /// needed to ensure that all dependencies are build.
    pub(crate) fn ensure_if_default<T, S: Step<Output = Option<T>>>(
        &'a self,
        step: S,
2170
        kind: Kind,
2171
    ) -> S::Output {
2172 2173
        let desc = StepDescription::from::<S>(kind);
        let should_run = (desc.should_run)(ShouldRun::new(self, desc.kind));
2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184

        // Avoid running steps contained in --exclude
        for pathset in &should_run.paths {
            if desc.is_excluded(self, pathset) {
                return None;
            }
        }

        // Only execute if it's supposed to run as default
        if desc.default && should_run.is_really_default() { self.ensure(step) } else { None }
    }
2185 2186

    /// Checks if any of the "should_run" paths is in the `Builder` paths.
2187 2188 2189
    pub(crate) fn was_invoked_explicitly<S: Step>(&'a self, kind: Kind) -> bool {
        let desc = StepDescription::from::<S>(kind);
        let should_run = (desc.should_run)(ShouldRun::new(self, desc.kind));
2190 2191

        for path in &self.paths {
2192 2193 2194
            if should_run.paths.iter().any(|s| s.has(path, Some(desc.kind)))
                && !desc.is_excluded(
                    self,
2195
                    &PathSet::Suite(TaskPath { path: path.clone(), kind: Some(desc.kind) }),
2196
                )
2197 2198 2199 2200 2201 2202 2203
            {
                return true;
            }
        }

        false
    }
2204
}
M
Mark Simulacrum 已提交
2205 2206

#[cfg(test)]
C
chansuke 已提交
2207
mod tests;
2208

2209
#[derive(Debug, Clone)]
2210
struct Rustflags(String, TargetSelection);
2211 2212

impl Rustflags {
2213
    fn new(target: TargetSelection) -> Rustflags {
2214 2215 2216 2217
        let mut ret = Rustflags(String::new(), target);
        ret.propagate_cargo_env("RUSTFLAGS");
        ret
    }
2218

2219
    /// By default, cargo will pick up on various variables in the environment. However, bootstrap
D
Dylan DPC 已提交
2220
    /// reuses those variables to pass additional flags to rustdoc, so by default they get overridden.
2221 2222 2223 2224
    /// Explicitly add back any previous value in the environment.
    ///
    /// `prefix` is usually `RUSTFLAGS` or `RUSTDOCFLAGS`.
    fn propagate_cargo_env(&mut self, prefix: &str) {
A
Alex Crichton 已提交
2225
        // Inherit `RUSTFLAGS` by default ...
2226
        self.env(prefix);
2227

2228 2229 2230
        // ... and also handle target-specific env RUSTFLAGS if they're configured.
        let target_specific = format!("CARGO_TARGET_{}_{}", crate::envify(&self.1.triple), prefix);
        self.env(&target_specific);
2231 2232 2233 2234
    }

    fn env(&mut self, env: &str) {
        if let Ok(s) = env::var(env) {
2235
            for part in s.split(' ') {
2236 2237 2238 2239 2240 2241
                self.arg(part);
            }
        }
    }

    fn arg(&mut self, arg: &str) -> &mut Self {
2242
        assert_eq!(arg.split(' ').count(), 1);
2243
        if !self.0.is_empty() {
M
Matthias Krüger 已提交
2244
            self.0.push(' ');
2245 2246 2247 2248 2249
        }
        self.0.push_str(arg);
        self
    }
}
2250 2251 2252 2253 2254

#[derive(Debug)]
pub struct Cargo {
    command: Command,
    rustflags: Rustflags,
2255
    rustdocflags: Rustflags,
2256 2257 2258
}

impl Cargo {
M
Mark Rousskov 已提交
2259 2260 2261 2262
    pub fn rustdocflag(&mut self, arg: &str) -> &mut Cargo {
        self.rustdocflags.arg(arg);
        self
    }
2263 2264 2265 2266 2267
    pub fn rustflag(&mut self, arg: &str) -> &mut Cargo {
        self.rustflags.arg(arg);
        self
    }

2268 2269 2270 2271 2272 2273
    pub fn arg(&mut self, arg: impl AsRef<OsStr>) -> &mut Cargo {
        self.command.arg(arg.as_ref());
        self
    }

    pub fn args<I, S>(&mut self, args: I) -> &mut Cargo
M
Mark Rousskov 已提交
2274 2275 2276
    where
        I: IntoIterator<Item = S>,
        S: AsRef<OsStr>,
2277 2278 2279 2280 2281 2282 2283 2284
    {
        for arg in args {
            self.arg(arg.as_ref());
        }
        self
    }

    pub fn env(&mut self, key: impl AsRef<OsStr>, value: impl AsRef<OsStr>) -> &mut Cargo {
M
Mark Rousskov 已提交
2285 2286 2287
        // These are managed through rustflag/rustdocflag interfaces.
        assert_ne!(key.as_ref(), "RUSTFLAGS");
        assert_ne!(key.as_ref(), "RUSTDOCFLAGS");
2288 2289 2290
        self.command.env(key.as_ref(), value.as_ref());
        self
    }
2291 2292 2293 2294

    pub fn add_rustc_lib_path(&mut self, builder: &Builder<'_>, compiler: Compiler) {
        builder.add_rustc_lib_path(compiler, &mut self.command);
    }
2295 2296 2297 2298 2299

    pub fn current_dir(&mut self, dir: &Path) -> &mut Cargo {
        self.command.current_dir(dir);
        self
    }
2300 2301 2302 2303
}

impl From<Cargo> for Command {
    fn from(mut cargo: Cargo) -> Command {
2304 2305 2306 2307 2308 2309 2310 2311 2312 2313
        let rustflags = &cargo.rustflags.0;
        if !rustflags.is_empty() {
            cargo.command.env("RUSTFLAGS", rustflags);
        }

        let rustdocflags = &cargo.rustdocflags.0;
        if !rustdocflags.is_empty() {
            cargo.command.env("RUSTDOCFLAGS", rustdocflags);
        }

2314 2315 2316
        cargo.command
    }
}