ipuv3-crtc.c 15.6 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14
/*
 * i.MX IPUv3 Graphics driver
 *
 * Copyright (C) 2011 Sascha Hauer, Pengutronix
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 */
15
#include <linux/component.h>
16 17 18 19 20
#include <linux/module.h>
#include <linux/export.h>
#include <linux/device.h>
#include <linux/platform_device.h>
#include <drm/drmP.h>
21
#include <drm/drm_atomic.h>
22
#include <drm/drm_atomic_helper.h>
23 24 25
#include <drm/drm_crtc_helper.h>
#include <linux/fb.h>
#include <linux/clk.h>
26
#include <linux/errno.h>
L
Lucas Stach 已提交
27 28
#include <linux/reservation.h>
#include <linux/dma-buf.h>
29 30 31
#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_fb_cma_helper.h>

32
#include <video/imx-ipu-v3.h>
33
#include "imx-drm.h"
34
#include "ipuv3-plane.h"
35 36 37

#define DRIVER_DESC		"i.MX IPUv3 Graphics"

38 39 40
enum ipu_flip_status {
	IPU_FLIP_NONE,
	IPU_FLIP_PENDING,
L
Lucas Stach 已提交
41
	IPU_FLIP_SUBMITTED,
42 43
};

44 45 46 47
struct ipu_flip_work {
	struct work_struct		unref_work;
	struct drm_gem_object		*bo;
	struct drm_pending_vblank_event *page_flip_event;
L
Lucas Stach 已提交
48 49 50 51 52
	struct work_struct		fence_work;
	struct ipu_crtc			*crtc;
	struct fence			*excl;
	unsigned			shared_count;
	struct fence			**shared;
53 54
};

55 56 57 58
struct ipu_crtc {
	struct device		*dev;
	struct drm_crtc		base;
	struct imx_drm_crtc	*imx_crtc;
59 60 61 62

	/* plane[0] is the full plane, plane[1] is the partial plane */
	struct ipu_plane	*plane[2];

63 64 65
	struct ipu_dc		*dc;
	struct ipu_di		*di;
	int			enabled;
66
	enum ipu_flip_status	flip_state;
67 68
	struct workqueue_struct *flip_queue;
	struct ipu_flip_work	*flip_work;
69
	int			irq;
70
	u32			bus_format;
71
	u32			bus_flags;
72 73
	int			di_hsync_pin;
	int			di_vsync_pin;
74 75 76 77
};

#define to_ipu_crtc(x) container_of(x, struct ipu_crtc, base)

78
static void ipu_crtc_enable(struct ipu_crtc *ipu_crtc)
79
{
80 81
	struct ipu_soc *ipu = dev_get_drvdata(ipu_crtc->dev->parent);

82 83 84
	if (ipu_crtc->enabled)
		return;

85
	ipu_dc_enable(ipu);
86 87
	ipu_dc_enable_channel(ipu_crtc->dc);
	ipu_di_enable(ipu_crtc->di);
88
	ipu_crtc->enabled = 1;
89 90 91 92 93 94

	/*
	 * In order not to be warned on enabling vblank failure,
	 * we should call drm_crtc_vblank_on() after ->enabled is set to 1.
	 */
	drm_crtc_vblank_on(&ipu_crtc->base);
95 96
}

97
static void ipu_crtc_disable(struct ipu_crtc *ipu_crtc)
98
{
99 100
	struct ipu_soc *ipu = dev_get_drvdata(ipu_crtc->dev->parent);

101 102 103 104 105
	if (!ipu_crtc->enabled)
		return;

	ipu_dc_disable_channel(ipu_crtc->dc);
	ipu_di_disable(ipu_crtc->di);
106
	ipu_dc_disable(ipu);
107
	ipu_crtc->enabled = 0;
108 109

	drm_crtc_vblank_off(&ipu_crtc->base);
110 111 112 113 114 115
}

static void ipu_crtc_dpms(struct drm_crtc *crtc, int mode)
{
	struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc);

116
	dev_dbg(ipu_crtc->dev, "%s mode: %d\n", __func__, mode);
117 118 119

	switch (mode) {
	case DRM_MODE_DPMS_ON:
120
		ipu_crtc_enable(ipu_crtc);
121 122 123 124
		break;
	case DRM_MODE_DPMS_STANDBY:
	case DRM_MODE_DPMS_SUSPEND:
	case DRM_MODE_DPMS_OFF:
125
		ipu_crtc_disable(ipu_crtc);
126 127 128 129
		break;
	}
}

130 131 132 133 134 135 136 137 138
static void ipu_flip_unref_work_func(struct work_struct *__work)
{
	struct ipu_flip_work *work =
			container_of(__work, struct ipu_flip_work, unref_work);

	drm_gem_object_unreference_unlocked(work->bo);
	kfree(work);
}

L
Lucas Stach 已提交
139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157
static void ipu_flip_fence_work_func(struct work_struct *__work)
{
	struct ipu_flip_work *work =
			container_of(__work, struct ipu_flip_work, fence_work);
	int i;

	/* wait for all fences attached to the FB obj to signal */
	if (work->excl) {
		fence_wait(work->excl, false);
		fence_put(work->excl);
	}
	for (i = 0; i < work->shared_count; i++) {
		fence_wait(work->shared[i], false);
		fence_put(work->shared[i]);
	}

	work->crtc->flip_state = IPU_FLIP_SUBMITTED;
}

158 159
static int ipu_page_flip(struct drm_crtc *crtc,
		struct drm_framebuffer *fb,
160 161
		struct drm_pending_vblank_event *event,
		uint32_t page_flip_flags)
162
{
L
Lucas Stach 已提交
163
	struct drm_gem_cma_object *cma_obj = drm_fb_cma_get_gem_obj(fb, 0);
164
	struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc);
165
	struct ipu_flip_work *flip_work;
166 167
	int ret;

168
	if (ipu_crtc->flip_state != IPU_FLIP_NONE)
169 170 171 172 173 174 175 176 177 178
		return -EBUSY;

	ret = imx_drm_crtc_vblank_get(ipu_crtc->imx_crtc);
	if (ret) {
		dev_dbg(ipu_crtc->dev, "failed to acquire vblank counter\n");
		list_del(&event->base.link);

		return ret;
	}

179 180 181 182 183 184 185 186 187 188 189 190 191
	flip_work = kzalloc(sizeof *flip_work, GFP_KERNEL);
	if (!flip_work) {
		ret = -ENOMEM;
		goto put_vblank;
	}
	INIT_WORK(&flip_work->unref_work, ipu_flip_unref_work_func);
	flip_work->page_flip_event = event;

	/* get BO backing the old framebuffer and take a reference */
	flip_work->bo = &drm_fb_cma_get_gem_obj(crtc->primary->fb, 0)->base;
	drm_gem_object_reference(flip_work->bo);

	ipu_crtc->flip_work = flip_work;
L
Lucas Stach 已提交
192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219
	/*
	 * If the object has a DMABUF attached, we need to wait on its fences
	 * if there are any.
	 */
	if (cma_obj->base.dma_buf) {
		INIT_WORK(&flip_work->fence_work, ipu_flip_fence_work_func);
		flip_work->crtc = ipu_crtc;

		ret = reservation_object_get_fences_rcu(
				cma_obj->base.dma_buf->resv, &flip_work->excl,
				&flip_work->shared_count, &flip_work->shared);

		if (unlikely(ret)) {
			DRM_ERROR("failed to get fences for buffer\n");
			goto free_flip_work;
		}

		/* No need to queue the worker if the are no fences */
		if (!flip_work->excl && !flip_work->shared_count) {
			ipu_crtc->flip_state = IPU_FLIP_SUBMITTED;
		} else {
			ipu_crtc->flip_state = IPU_FLIP_PENDING;
			queue_work(ipu_crtc->flip_queue,
				   &flip_work->fence_work);
		}
	} else {
		ipu_crtc->flip_state = IPU_FLIP_SUBMITTED;
	}
220

221 222 223
	if (crtc->primary->state)
		drm_atomic_set_fb_for_plane(crtc->primary->state, fb);

224
	return 0;
225

L
Lucas Stach 已提交
226 227 228 229
free_flip_work:
	drm_gem_object_unreference_unlocked(flip_work->bo);
	kfree(flip_work);
	ipu_crtc->flip_work = NULL;
230 231 232 233
put_vblank:
	imx_drm_crtc_vblank_put(ipu_crtc->imx_crtc);

	return ret;
234 235 236 237 238 239
}

static const struct drm_crtc_funcs ipu_crtc_funcs = {
	.set_config = drm_crtc_helper_set_config,
	.destroy = drm_crtc_cleanup,
	.page_flip = ipu_page_flip,
240 241 242
	.reset = drm_atomic_helper_crtc_reset,
	.atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
	.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
243 244 245 246 247 248
};

static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)
{
	unsigned long flags;
	struct drm_device *drm = ipu_crtc->base.dev;
249
	struct ipu_flip_work *work = ipu_crtc->flip_work;
250 251

	spin_lock_irqsave(&drm->event_lock, flags);
252
	if (work->page_flip_event)
253
		drm_crtc_send_vblank_event(&ipu_crtc->base,
254
					   work->page_flip_event);
255 256 257 258 259 260 261 262 263 264
	imx_drm_crtc_vblank_put(ipu_crtc->imx_crtc);
	spin_unlock_irqrestore(&drm->event_lock, flags);
}

static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
{
	struct ipu_crtc *ipu_crtc = dev_id;

	imx_drm_handle_vblank(ipu_crtc->imx_crtc);

L
Lucas Stach 已提交
265
	if (ipu_crtc->flip_state == IPU_FLIP_SUBMITTED) {
266 267
		struct ipu_plane *plane = ipu_crtc->plane[0];

268
		ipu_plane_set_base(plane, ipu_crtc->base.primary->fb);
269
		ipu_crtc_handle_pageflip(ipu_crtc);
270 271
		queue_work(ipu_crtc->flip_queue,
			   &ipu_crtc->flip_work->unref_work);
272
		ipu_crtc->flip_state = IPU_FLIP_NONE;
273 274 275 276 277 278 279 280 281
	}

	return IRQ_HANDLED;
}

static bool ipu_crtc_mode_fixup(struct drm_crtc *crtc,
				  const struct drm_display_mode *mode,
				  struct drm_display_mode *adjusted_mode)
{
282 283 284 285 286 287 288 289 290 291
	struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc);
	struct videomode vm;
	int ret;

	drm_display_mode_to_videomode(adjusted_mode, &vm);

	ret = ipu_di_adjust_videomode(ipu_crtc->di, &vm);
	if (ret)
		return false;

292 293 294
	if ((vm.vsync_len == 0) || (vm.hsync_len == 0))
		return false;

295 296
	drm_display_mode_from_videomode(&vm, adjusted_mode);

297 298 299 300 301 302 303
	return true;
}

static void ipu_crtc_prepare(struct drm_crtc *crtc)
{
	struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc);

304
	ipu_crtc_disable(ipu_crtc);
305 306 307 308 309 310
}

static void ipu_crtc_commit(struct drm_crtc *crtc)
{
	struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc);

311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368
	ipu_crtc_enable(ipu_crtc);
}

static int ipu_crtc_atomic_check(struct drm_crtc *crtc,
				 struct drm_crtc_state *state)
{
	return 0;
}

static void ipu_crtc_mode_set_nofb(struct drm_crtc *crtc)
{
	struct drm_device *dev = crtc->dev;
	struct drm_encoder *encoder;
	struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc);
	struct drm_display_mode *mode = &crtc->state->adjusted_mode;
	struct ipu_di_signal_cfg sig_cfg = {};
	unsigned long encoder_types = 0;

	dev_dbg(ipu_crtc->dev, "%s: mode->hdisplay: %d\n", __func__,
			mode->hdisplay);
	dev_dbg(ipu_crtc->dev, "%s: mode->vdisplay: %d\n", __func__,
			mode->vdisplay);

	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head)
		if (encoder->crtc == crtc)
			encoder_types |= BIT(encoder->encoder_type);

	dev_dbg(ipu_crtc->dev, "%s: attached to encoder types 0x%lx\n",
		__func__, encoder_types);

	/*
	 * If we have DAC or LDB, then we need the IPU DI clock to be
	 * the same as the LDB DI clock. For TVDAC, derive the IPU DI
	 * clock from 27 MHz TVE_DI clock, but allow to divide it.
	 */
	if (encoder_types & (BIT(DRM_MODE_ENCODER_DAC) |
			     BIT(DRM_MODE_ENCODER_LVDS)))
		sig_cfg.clkflags = IPU_DI_CLKMODE_SYNC | IPU_DI_CLKMODE_EXT;
	else if (encoder_types & BIT(DRM_MODE_ENCODER_TVDAC))
		sig_cfg.clkflags = IPU_DI_CLKMODE_EXT;
	else
		sig_cfg.clkflags = 0;

	sig_cfg.enable_pol = !(ipu_crtc->bus_flags & DRM_BUS_FLAG_DE_LOW);
	/* Default to driving pixel data on negative clock edges */
	sig_cfg.clk_pol = !!(ipu_crtc->bus_flags &
			     DRM_BUS_FLAG_PIXDATA_POSEDGE);
	sig_cfg.bus_format = ipu_crtc->bus_format;
	sig_cfg.v_to_h_sync = 0;
	sig_cfg.hsync_pin = ipu_crtc->di_hsync_pin;
	sig_cfg.vsync_pin = ipu_crtc->di_vsync_pin;

	drm_display_mode_to_videomode(mode, &sig_cfg.mode);

	ipu_dc_init_sync(ipu_crtc->dc, ipu_crtc->di,
			 mode->flags & DRM_MODE_FLAG_INTERLACE,
			 ipu_crtc->bus_format, mode->hdisplay);
	ipu_di_init_sync_panel(ipu_crtc->di, &sig_cfg);
369 370
}

371
static const struct drm_crtc_helper_funcs ipu_helper_funcs = {
372 373
	.dpms = ipu_crtc_dpms,
	.mode_fixup = ipu_crtc_mode_fixup,
374 375
	.mode_set = drm_helper_crtc_mode_set,
	.mode_set_nofb = ipu_crtc_mode_set_nofb,
376 377
	.prepare = ipu_crtc_prepare,
	.commit = ipu_crtc_commit,
378
	.atomic_check = ipu_crtc_atomic_check,
379 380 381 382
};

static int ipu_enable_vblank(struct drm_crtc *crtc)
{
383 384
	struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc);

385 386 387 388 389 390 391 392
	/*
	 * ->commit is done after ->mode_set in drm_crtc_helper_set_mode(),
	 * so waiting for vblank in drm_plane_helper_commit() will timeout.
	 * Check the state here to avoid the waiting.
	 */
	if (!ipu_crtc->enabled)
		return -EINVAL;

393 394
	enable_irq(ipu_crtc->irq);

395 396 397 398 399
	return 0;
}

static void ipu_disable_vblank(struct drm_crtc *crtc)
{
400 401 402
	struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc);

	disable_irq_nosync(ipu_crtc->irq);
403 404
}

405
static int ipu_set_interface_pix_fmt(struct drm_crtc *crtc,
406
		u32 bus_format, int hsync_pin, int vsync_pin, u32 bus_flags)
407 408 409
{
	struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc);

410
	ipu_crtc->bus_format = bus_format;
411
	ipu_crtc->bus_flags = bus_flags;
412 413
	ipu_crtc->di_hsync_pin = hsync_pin;
	ipu_crtc->di_vsync_pin = vsync_pin;
414 415 416 417 418 419 420 421 422 423 424 425 426 427

	return 0;
}

static const struct imx_drm_crtc_helper_funcs ipu_crtc_helper_funcs = {
	.enable_vblank = ipu_enable_vblank,
	.disable_vblank = ipu_disable_vblank,
	.set_interface_pix_fmt = ipu_set_interface_pix_fmt,
	.crtc_funcs = &ipu_crtc_funcs,
	.crtc_helper_funcs = &ipu_helper_funcs,
};

static void ipu_put_resources(struct ipu_crtc *ipu_crtc)
{
428 429
	if (!IS_ERR_OR_NULL(ipu_crtc->dc))
		ipu_dc_put(ipu_crtc->dc);
430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459
	if (!IS_ERR_OR_NULL(ipu_crtc->di))
		ipu_di_put(ipu_crtc->di);
}

static int ipu_get_resources(struct ipu_crtc *ipu_crtc,
		struct ipu_client_platformdata *pdata)
{
	struct ipu_soc *ipu = dev_get_drvdata(ipu_crtc->dev->parent);
	int ret;

	ipu_crtc->dc = ipu_dc_get(ipu, pdata->dc);
	if (IS_ERR(ipu_crtc->dc)) {
		ret = PTR_ERR(ipu_crtc->dc);
		goto err_out;
	}

	ipu_crtc->di = ipu_di_get(ipu, pdata->di);
	if (IS_ERR(ipu_crtc->di)) {
		ret = PTR_ERR(ipu_crtc->di);
		goto err_out;
	}

	return 0;
err_out:
	ipu_put_resources(ipu_crtc);

	return ret;
}

static int ipu_crtc_init(struct ipu_crtc *ipu_crtc,
460
	struct ipu_client_platformdata *pdata, struct drm_device *drm)
461
{
462
	struct ipu_soc *ipu = dev_get_drvdata(ipu_crtc->dev->parent);
463
	int dp = -EINVAL;
464 465 466 467 468 469 470 471 472
	int ret;

	ret = ipu_get_resources(ipu_crtc, pdata);
	if (ret) {
		dev_err(ipu_crtc->dev, "getting resources failed with %d.\n",
				ret);
		return ret;
	}

473 474 475 476
	if (pdata->dp >= 0)
		dp = IPU_DP_FLOW_SYNC_BG;
	ipu_crtc->plane[0] = ipu_plane_init(drm, ipu, pdata->dma[0], dp, 0,
					    DRM_PLANE_TYPE_PRIMARY);
477 478 479 480
	if (IS_ERR(ipu_crtc->plane[0])) {
		ret = PTR_ERR(ipu_crtc->plane[0]);
		goto err_put_resources;
	}
481

482
	ret = imx_drm_add_crtc(drm, &ipu_crtc->base, &ipu_crtc->imx_crtc,
483
			&ipu_crtc->plane[0]->base, &ipu_crtc_helper_funcs,
484
			pdata->of_node);
485 486 487 488 489
	if (ret) {
		dev_err(ipu_crtc->dev, "adding crtc failed with %d.\n", ret);
		goto err_put_resources;
	}

490 491 492 493 494 495 496 497 498
	ret = ipu_plane_get_resources(ipu_crtc->plane[0]);
	if (ret) {
		dev_err(ipu_crtc->dev, "getting plane 0 resources failed with %d.\n",
			ret);
		goto err_remove_crtc;
	}

	/* If this crtc is using the DP, add an overlay plane */
	if (pdata->dp >= 0 && pdata->dma[1] > 0) {
499 500 501 502
		ipu_crtc->plane[1] = ipu_plane_init(drm, ipu, pdata->dma[1],
						IPU_DP_FLOW_SYNC_FG,
						drm_crtc_mask(&ipu_crtc->base),
						DRM_PLANE_TYPE_OVERLAY);
503
		if (IS_ERR(ipu_crtc->plane[1])) {
504
			ipu_crtc->plane[1] = NULL;
505 506 507 508 509 510 511 512
		} else {
			ret = ipu_plane_get_resources(ipu_crtc->plane[1]);
			if (ret) {
				dev_err(ipu_crtc->dev, "getting plane 1 "
					"resources failed with %d.\n", ret);
				goto err_put_plane0_res;
			}
		}
513 514 515
	}

	ipu_crtc->irq = ipu_plane_irq(ipu_crtc->plane[0]);
516 517 518 519
	ret = devm_request_irq(ipu_crtc->dev, ipu_crtc->irq, ipu_irq_handler, 0,
			"imx_drm", ipu_crtc);
	if (ret < 0) {
		dev_err(ipu_crtc->dev, "irq request failed with %d.\n", ret);
520
		goto err_put_plane1_res;
521
	}
522 523
	/* Only enable IRQ when we actually need it to trigger work. */
	disable_irq(ipu_crtc->irq);
524

525 526
	ipu_crtc->flip_queue = create_singlethread_workqueue("ipu-crtc-flip");

527 528
	return 0;

529 530 531 532
err_put_plane1_res:
	if (ipu_crtc->plane[1])
		ipu_plane_put_resources(ipu_crtc->plane[1]);
err_put_plane0_res:
533 534 535
	ipu_plane_put_resources(ipu_crtc->plane[0]);
err_remove_crtc:
	imx_drm_remove_crtc(ipu_crtc->imx_crtc);
536 537 538 539 540 541
err_put_resources:
	ipu_put_resources(ipu_crtc);

	return ret;
}

542
static int ipu_drm_bind(struct device *dev, struct device *master, void *data)
543
{
544
	struct ipu_client_platformdata *pdata = dev->platform_data;
545
	struct drm_device *drm = data;
546 547 548
	struct ipu_crtc *ipu_crtc;
	int ret;

549
	ipu_crtc = devm_kzalloc(dev, sizeof(*ipu_crtc), GFP_KERNEL);
550 551 552
	if (!ipu_crtc)
		return -ENOMEM;

553
	ipu_crtc->dev = dev;
554

555
	ret = ipu_crtc_init(ipu_crtc, pdata, drm);
556 557
	if (ret)
		return ret;
558

559
	dev_set_drvdata(dev, ipu_crtc);
560 561 562 563

	return 0;
}

564 565
static void ipu_drm_unbind(struct device *dev, struct device *master,
	void *data)
566
{
567
	struct ipu_crtc *ipu_crtc = dev_get_drvdata(dev);
568 569 570

	imx_drm_remove_crtc(ipu_crtc->imx_crtc);

571
	destroy_workqueue(ipu_crtc->flip_queue);
572
	ipu_put_resources(ipu_crtc);
573 574 575
	if (ipu_crtc->plane[1])
		ipu_plane_put_resources(ipu_crtc->plane[1]);
	ipu_plane_put_resources(ipu_crtc->plane[0]);
576 577 578 579 580 581
}

static const struct component_ops ipu_crtc_ops = {
	.bind = ipu_drm_bind,
	.unbind = ipu_drm_unbind,
};
582

583 584
static int ipu_drm_probe(struct platform_device *pdev)
{
585
	struct device *dev = &pdev->dev;
586 587
	int ret;

588
	if (!dev->platform_data)
589 590
		return -EINVAL;

591
	ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
592 593 594
	if (ret)
		return ret;

595
	return component_add(dev, &ipu_crtc_ops);
596 597 598 599 600
}

static int ipu_drm_remove(struct platform_device *pdev)
{
	component_del(&pdev->dev, &ipu_crtc_ops);
601 602 603 604 605 606 607 608
	return 0;
}

static struct platform_driver ipu_drm_driver = {
	.driver = {
		.name = "imx-ipuv3-crtc",
	},
	.probe = ipu_drm_probe,
609
	.remove = ipu_drm_remove,
610 611 612 613 614 615
};
module_platform_driver(ipu_drm_driver);

MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>");
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL");
616
MODULE_ALIAS("platform:imx-ipuv3-crtc");