- 23 3月, 2011 1 次提交
-
-
由 Tom Lane 提交于
Opening a catcache's index could require reading from that cache's own catalog, which of course would acquire AccessShareLock on the catalog. So the original coding here risks locking index before heap, which could deadlock against another backend trying to get exclusive locks in the normal order. Because InitCatCachePhase2 is only called when a backend has to start up without a relcache init file, the deadlock was seldom seen in the field. (And by the same token, there's no need to worry about any performance disadvantage; so not much point in trying to distinguish exactly which catalogs have the risk.) Bug report, diagnosis, and patch by Nikhil Sontakke. Additional commentary by me. Back-patch to all supported branches.
-
- 17 3月, 2011 2 次提交
-
-
由 Alvaro Herrera 提交于
Report and patch from Daniel Popowich, bug #5842 (with some debugging help from Alex Hunsaker)
-
由 Andrew Dunstan 提交于
This has been broken for years, and I'm not sure why it has not been noticed before, but now a very modern Cygwin breaks on it, and the fix is clearly correct. Backpatching to all live branches.
-
- 12 3月, 2011 2 次提交
-
-
由 Tom Lane 提交于
We previously heard of the same problem in int24div(), so there's not a good reason to suppose the problem is confined to cases involving int8.
-
由 Tom Lane 提交于
Add dummy returns before every potential division-by-zero in int8.c, because apparently further "improvements" in gcc's optimizer have enabled it to break functions that weren't broken before. Aurelien Jarno, via Martin Pitt
-
- 22 2月, 2011 1 次提交
-
-
由 Tom Lane 提交于
ExecUpdate checked for whether ExecBRUpdateTriggers had returned a new tuple value by seeing if the returned tuple was pointer-equal to the old one. But the "old one" was in estate->es_junkFilter's result slot, which would be scribbled on if we had done an EvalPlanQual update in response to a concurrent update of the target tuple; therefore we were comparing a dangling pointer to a live one. Given the right set of circumstances we could get a false match, resulting in not forcing the tuple to be stored in the slot we thought it was stored in. In the case reported by Maxim Boguk in bug #5798, this led to "cannot extract system attribute from virtual tuple" failures when trying to do "RETURNING ctid". I believe there is a very-low-probability chance of more serious errors, such as generating incorrect index entries based on the original rather than the trigger-modified version of the row. In HEAD, change all of ExecBRInsertTriggers, ExecIRInsertTriggers, ExecBRUpdateTriggers, and ExecIRUpdateTriggers so that they continue to have similar APIs. In the back branches I just changed ExecBRUpdateTriggers, since there is no bug in the ExecBRInsertTriggers case.
-
- 16 2月, 2011 1 次提交
-
-
由 Tom Lane 提交于
Recent releases had a check on rel->rd_refcnt in heap_drop_with_catalog, but failed to cover the possibility of pending trigger events at DROP time. (Before 8.4 we didn't even check the refcnt.) When the trigger events were eventually fired, you'd get "could not open relation with OID nnn" errors, as in recent report from strk. Better to throw a suitable error when the DROP is attempted. Also add a similar check in DROP INDEX. Back-patch to all supported branches.
-
- 01 2月, 2011 2 次提交
-
-
由 Magnus Hagander 提交于
New versions of libintl redefine setlocale() to a macro which causes problems when the backend and libintl are linked against different versions of the runtime, which is often the case in msvc builds. Hiroshi Inoue, slightly updated comment by me
-
由 Itagaki Takahiro 提交于
maximum allowed' messages, that have reported one-less dimensions. Alexey Klyukin
-
- 28 1月, 2011 6 次提交
-
-
由 Marc G. Fournier 提交于
-
由 Tom Lane 提交于
Security: CVE-2010-4015
-
由 Tom Lane 提交于
contrib/intarray's gettoken() uses a fixed-size buffer to collect an integer's digits, and did not guard against overrunning the buffer. This is at least a backend crash risk, and in principle might allow arbitrary code execution. The code didn't check for overflow of the integer value either, which while not presenting a crash risk was still bad. Thanks to Apple Inc's security team for reporting this issue and supplying the fix. Security: CVE-2010-4015
-
由 Tom Lane 提交于
We only need that header when compiling with icc, since the gcc variant of ia64_get_bsp() uses in-line assembly code. Per report from Frank Brendel, the header doesn't exist on all IA64 platforms; so don't include it unless we need it.
-
由 Peter Eisentraut 提交于
-
由 Tom Lane 提交于
-
- 22 1月, 2011 1 次提交
-
-
由 Tom Lane 提交于
Specifically, this makes the workflow pg_dump -Fc -> pg_restore -> file produce correct output for BLOBs when the source database has standard_conforming_strings turned on. It was already okay when that was off, or if pg_restore was told to restore directly into a database. This is a back-port of commit b1732111 of 2009-08-04, with additional changes to emit old-style escaped bytea data instead of hex-style. At the time, we had not heard of anyone encountering the problem in the field, so I judged it not worth the risk of changing back branches. Now we do have a report, from Bosco Rama, so back-patch into 8.2 through 8.4. 9.0 and up are okay already.
-
- 18 1月, 2011 1 次提交
-
-
由 Tom Lane 提交于
If the slice to be assigned to was before the existing array lower bound (requiring at least one null element to spring into existence to fill the gap), the code miscalculated how many entries needed to be copied from the old array's null bitmap. This could result in trashing the array's data area (as seen in bug #5840 from Karsten Loesing), or worse. This has been broken since we first allowed the behavior of assigning to non-adjacent slices, in 8.2. Back-patch to all affected versions.
-
- 11 1月, 2011 1 次提交
-
-
由 Magnus Hagander 提交于
To make the buildfarm green again, since there is no file to copy on msvc, and also given discussion about the necessity of the file at all...
-
- 10 1月, 2011 1 次提交
-
-
由 Magnus Hagander 提交于
Result of bad testing of my last commit.
-
- 09 1月, 2011 1 次提交
-
-
由 Magnus Hagander 提交于
This file is now needed by pgAdmin builds, which started failing since it was missing in the installer builds.
-
- 05 1月, 2011 1 次提交
-
-
由 Andrew Dunstan 提交于
Allow older branches to be built with Visual Studio 2008. This is a backport of commit df0cdd53 to the 8.2, 8.3 and 8.4 branches.
-
- 04 1月, 2011 1 次提交
-
-
由 Andrew Dunstan 提交于
Work around header misdefines in modern Windows SDK when _WIN32_WINNT is less than 0x0501. Only required for versions 8.2, 8.3 and 8.4., as we defined _WIN32_WINNT as 0x0501 after that.
-
- 29 12月, 2010 2 次提交
-
-
由 Tom Lane 提交于
I heard the siren call of git cherry-pick, but should have lashed myself to the mast.
-
由 Tom Lane 提交于
The "date" type supports a wider range of dates than int64 timestamps do. However, there is pre-int64-timestamp code in the planner that assumes that all date values can be converted to timestamp with impunity. Fortunately, what we really need out of the conversion is always a double (float8) value; so even when the date is out of timestamp's range it's possible to produce a sane answer. All we need is a code path that doesn't try to force the result into int64. Per trouble report from David Rericha. Back-patch to all supported versions. Although this is surely a corner case, there's not much point in advertising a date range wider than timestamp's if we will choke on such values in unexpected places.
-
- 20 12月, 2010 2 次提交
-
-
由 Tom Lane 提交于
eval_const_expressions() can replace CaseTestExprs with constants when the surrounding CASE's test expression is a constant. This confuses ruleutils.c's heuristic for deparsing simple-form CASEs, leading to Assert failures or "unexpected CASE WHEN clause" errors. I had put in a hack solution for that years ago (see commit 514ce7a3 of 2006-10-01), but bug #5794 from Peter Speck shows that that solution failed to cover all cases. Fortunately, there's a much better way, which came to me upon reflecting that Peter's "CASE TRUE WHEN" seemed pretty redundant: we can "simplify" the simple-form CASE to the general form of CASE, by simply omitting the constant test expression from the rebuilt CASE construct. This is intuitively valid because there is no need for the executor to evaluate the test expression at runtime; it will never be referenced, because any CaseTestExprs that would have referenced it are now replaced by constants. This won't save a whole lot of cycles, since evaluating a Const is pretty cheap, but a cycle saved is a cycle earned. In any case it beats kluging ruleutils.c still further. So this patch improves const-simplification and reverts the previous change in ruleutils.c. Back-patch to all supported branches. The bug exists in 8.1 too, but it's out of warranty.
-
由 Tom Lane 提交于
After parsing a parenthesized subexpression, we must pop all pending ANDs and NOTs off the stack, just like the case for a simple operand. Per bug #5793. Also fix clones of this routine in contrib/intarray and contrib/ltree, where input of types query_int and ltxtquery had the same problem. Back-patch to all supported versions.
-
- 18 12月, 2010 1 次提交
-
-
由 Magnus Hagander 提交于
Add a note to user-facing parameters that can be removed completely (and not just empty) by #ifdef's depending on build configuration.
-
- 16 12月, 2010 2 次提交
-
-
由 Tom Lane 提交于
The mingw people don't appear to care about compatibility with non-GNU versions of getopt, so force use of our own copy of getopt on Windows. Also, ensure that we make use of optreset when using our own copy. Per report from Andrew Dunstan. Back-patch to all versions supported on Windows.
-
由 Tom Lane 提交于
Fix the same size_alpha versus size_beta typo that was recently fixed in contrib/cube. Noted by Alexander Korotkov. Back-patch to all supported branches (there is a more invasive fix in HEAD).
-
- 14 12月, 2010 5 次提交
-
-
由 Marc G. Fournier 提交于
-
由 Marc G. Fournier 提交于
-
由 Tom Lane 提交于
-
由 Peter Eisentraut 提交于
-
由 Tom Lane 提交于
Fiji and Samoa. Historical corrections for Hong Kong.
-
- 09 12月, 2010 1 次提交
-
-
由 Tom Lane 提交于
Recent versions of the Linux system header files cause xlogdefs.h to believe that open_datasync should be the default sync method, whereas formerly fdatasync was the default on Linux. open_datasync is a bad choice, first because it doesn't actually outperform fdatasync (in fact the reverse), and second because we try to use O_DIRECT with it, causing failures on certain filesystems (e.g., ext4 with data=journal option). This part of the patch is largely per a proposal from Marti Raudsepp. More extensive changes are likely to follow in HEAD, but this is as much change as we want to back-patch. Also clean up confusing code and incorrect documentation surrounding the fsync_writethrough option. Those changes shouldn't result in any actual behavioral change, but I chose to back-patch them anyway to keep the branches looking similar in this area. In 9.0 and HEAD, also do some copy-editing on the WAL Reliability documentation section. Back-patch to all supported branches, since any of them might get used on modern Linux versions.
-
- 07 12月, 2010 1 次提交
-
-
由 Tom Lane 提交于
There are some code paths, such as SPI_execute(), where we invoke copyObject() on raw parse trees before doing parse analysis on them. Since the bison grammar is capable of building heavily nested parsetrees while itself using only minimal stack depth, this means that copyObject() can be the front-line function that hits stack overflow before anything else does. Accordingly, it had better have a check_stack_depth() call. I did a bit of performance testing and found that this slows down copyObject() by only a few percent, so the hit ought to be negligible in the context of complete processing of a query. Per off-list report from Toshihide Katayama. Back-patch to all supported branches.
-
- 01 12月, 2010 1 次提交
-
-
由 Tom Lane 提交于
There were corner cases in which the planner would attempt to inline such a function, which would result in a failure at runtime due to loss of information about exactly what the result record type is. Fix by disabling inlining when the function's recorded result type is RECORD. There might be some sub-cases where inlining could still be allowed, but this is a simple and backpatchable fix, so leave refinements for another day. Per bug #5777 from Nate Carson. Back-patch to all supported branches. 8.1 happens to avoid a core-dump here, but it still does the wrong thing.
-
- 27 11月, 2010 1 次提交
-
-
由 Tom Lane 提交于
Most of the functions that execute XPath queries leaked the data structures created by libxml2. This memory would not be recovered until end of session, so it mounts up pretty quickly in any serious use of the feature. Per report from Pavel Stehule, though this isn't his patch. Back-patch to all supported branches.
-
- 25 11月, 2010 1 次提交
-
-
由 Itagaki Takahiro 提交于
except creating new connections.
-
- 20 11月, 2010 1 次提交
-
-
由 Tom Lane 提交于
When using default autovacuum_vac_cost_limit, autovac_balance_cost relied on VacuumCostLimit to contain the correct global value ... but after the first time through in a particular worker process, it didn't, because we'd trashed it in previous iterations. Depending on the state of other autovac workers, this could result in a steady reduction of the effective cost_limit setting as a particular worker processed more and more tables, causing it to go slower and slower. Spotted by Simon Poole (bug #5759). Fix by saving and restoring the GUC variables in the loop in do_autovacuum. In passing, improve a few comments. Back-patch to 8.3 ... the cost rebalancing code has been buggy since it was put in.
-