1. 21 4月, 2017 5 次提交
    • B
      Bump ORCA to 2.24 · 74b77e7a
      Bhuvnesh Chaudhary 提交于
      74b77e7a
    • A
      Fix partition_locking test that fails intermittently · 1cfb8183
      Asim R P 提交于
      Objective of the test is only to check if DDL/DML on partition tables lock only
      the root table on QD.  Child partitions are locked on QE as needed.  The
      intermittent failures are due to more locks acquired than expected.  In all
      such cases, the additional locks were AccessShare locks on some catalog table.
      This commit filters out locks on catalog tables from expected output.
      
      The intermittent failures merit investigation but that can happen regardless of
      this test fix.
      1cfb8183
    • C
      gpperfmon and coverity: resolve issues with `make distclean` · 0da09faf
      C.J. Jameson 提交于
      The coverity build was failing on the gpperfmon `make distclean` step
      
      Fixed on both sides:
      - Don't call `make distclean` in the coverity build script -- not
        necessary
      - Don't clean gpperfmon from `gpAux/Makefile`: this Makefile's clean
        targets are for enterprise-build related artifacts. General developers
        should be running `make clean distclean` from the top level directory of
        this repository.
      
      Additional fix -- doesn't address the coverity red but a similar
      cleanup:
      - Add cleanup of gpperfmon to the top level makefile's `distclean`
        target. Not sure why it wasn't there; probably just an accidental
        omission.
      - Add note explaining why the top level makefile has to circumvent
        `gpAux/Makefile`
      Signed-off-by: NMelanie Plageman <mplageman@pivotal.io>
      0da09faf
    • D
      Fix infinite execution of partition selector · a7694674
      This fixes a bug introduced in e378d84b
      where the partition selector may go in an infinite loop because it never
      got a chance to actually _select_ the partitions.
      a7694674
    • D
      Revert "Avoid null pointer deref in partition selection" · 3416a948
      Dhanashree Kashid and Jesse Zhang 提交于
      Commit 7b6dc9bf was well-intentioned,
      but wrong: in cases where `outerPlan` is NULL, inputSlot should be
      `NULL`, but the execution of the partition selector should *NOT*
      prematurely end there, instead, a static partition selection should
      happen (once) before this operator was exhausted (returning NULL).
      
      This is a pure revert commit. The `NULL` initialization will follow.
      
      This reverts commit 7b6dc9bf.
      3416a948
  2. 20 4月, 2017 15 次提交
    • D
      Fix typo in bfv_aggregate test · f3980f36
      Daniel Gustafsson 提交于
      My OCD prevented me from glossing over this one..
      f3980f36
    • D
      Add missing include · 16f6a491
      Daniel Gustafsson 提交于
      FileRepPrimary_IsResyncManagerOrWorker() is implicitly declared via
      the MIRROREDLOCK_BUFMGR_LOCK macro unless cdb/cdbfilerepprimary.h is
      included. Add to avoid warning.
      16f6a491
    • D
      Fix misleading indentation · 5be66c7c
      Daniel Gustafsson 提交于
      This codepath triggered a misleading-indentation warning in GCC and
      I can agree with that. Re-indent to make reading easier.
      5be66c7c
    • D
      Initialize numeric_rels to avoid deref warning · ce9a841f
      Daniel Gustafsson 提交于
      It's not crystal clear from the code that the numeric_rel_num
      counter is guarding the pointer deref on numeric_rels, so init
      the pointer and add a guard check in the if-statement.
      ce9a841f
    • D
      Avoid using an uninitialized value · b4d0b84d
      Daniel Gustafsson 提交于
      statVal is uninitialized in the case of an unknown property, skip
      using it in that case.
      b4d0b84d
    • D
      Wrap Assert helpers in USE_ASSERT_CHECKING · 859d6592
      Daniel Gustafsson 提交于
      Functions only used in Assertions yields warnings on unused code
      in non-cassert enabled builds.  Wrap the functions in the macro
      defined in assertion builds to avoid warning and make the intent
      with the code clearer.
      859d6592
    • D
      Add contrib/pgcrypto to the default contrib set · 122b24b2
      Daniel Gustafsson 提交于
      We want to make pgcrypto part of the default set of contrib modules
      shipped with Greenplum. Add to the default set building.
      122b24b2
    • D
      Sync contrib/pgcrypto with upstream 8.4.22 · 16d26ee9
      Daniel Gustafsson 提交于
      We had previously backported most of contrib/pgcrypto from
      upstream PostgreSQL 8.4, but not all. This brings in the
      remaining bits to get us in line with REL8_4_STABLE, as well
      as removes a few local patches to minimize diff to upstream
      (only affecting style and some unused includes).
      
      Among others, this commit completely merges:
      
        commit df2e62603ebc59a8fff5b6cd21b844370a95b061
        Author: Bruce Momjian <bruce@momjian.us>
        Date:   Thu Apr 17 12:37:53 2014 -0400
      
          pgcrypto:  fix memset() calls that might be optimized away
      
          Specifically, on-stack memset() might be removed, so:
      
          	* Replace memset() with px_memset()
          	* Add px_memset to copy_crlf()
          	* Add px_memset to pgp-s2k.c
      
          Patch by Marko Kreen
      
          Report by PVS-Studio
      
          Backpatch through 8.4.
      
      This commit partially merges:
      
        commit 99058cfc634ad59fa80f802f96c334be313faefb
        Author: Bruce Momjian <bruce@momjian.us>
        Date:   Tue May 6 11:26:24 2014 -0400
      
          Remove tabs after spaces in C comments
      
          This was not changed in HEAD, but will be done later as part of a
          pgindent run.  Future pgindent runs will also do this.
      
          Report by Tom Lane
      
          Backpatch through all supported branches, but not HEAD
      
      With this, we are at parity with REL8_4_STABLE plus the below
      commits which have been backported from higher up due to them
      containing security and/or important bugfixes:
      
        commit 4a9710e6edd1a23f6a053eb4b58b2b784245dc7e
        Author: Tom Lane <tgl@sss.pgh.pa.us>
        Date:   Tue Nov 11 17:22:15 2014 -0500
        Loop when necessary in contrib/pgcrypto's pktreader_pull().
      
        commit d95ebe0ac39b946c207ed0c37bba0365132ba3c6
        Author: Noah Misch <noah@leadboat.com>
        Date:   Mon Feb 2 10:00:45 2015 -0500
        Fix buffer overrun after incomplete read in pullf_read_max().
        Security: CVE-2015-0243
      
        commit d1972da8ce5857cec09645c11d8c7ac81b87d887
        Author: Noah Misch <noah@leadboat.com>
        Date:   Mon Feb 2 10:00:45 2015 -0500
        Cherry-pick security-relevant fixes from upstream imath library.
        Security: CVE-2015-0243
      
        commit 0ba20043129280c6d076c80cc60e3f73880b9ea4
        Author: Noah Misch <noah@leadboat.com>
        Date:   Mon May 18 10:02:31 2015 -0400
        pgcrypto: Report errant decryption as "Wrong key or corrupt data".
        Security: CVE-2015-3167
      16d26ee9
    • A
      Correct LOG ERRORS document · 3738dd83
      Adam Lee 提交于
      Error table feature was removed, but `\h CREATE EXTERNAL TABLE` still
      has the description. This commit corrects it.
      3738dd83
    • F
    • M
      Remove deprecated utility, gpcheckdb · 016f4ce4
      Melanie Plageman 提交于
      - Remove Makefile definitions only used by gpcheckdb
      Signed-off-by: NLarry Hamel <lhamel@pivotal.io>
      016f4ce4
    • F
      Updating ans file to fix broken runaway test. · 520d94b6
      Foyzur Rahman 提交于
      520d94b6
    • F
      Modifying runaway tinc udf to trigger runaway detection only on one segment. (#2251) · ad43b80c
      foyzur 提交于
      We add one more udf that only allocates on one specific segment and modify the hit_vlim_crit_section test to use the new udf. The original generic UDF uses an union all which creates one extra slice on segment 0. This allowed existence of two QE processes on segment 0.
      
      The test checks if we successfully ignore runaway termination as long as we are in critical section. The critical section is a per-process state and therefore a second runaway detector on the same segment can still mark the session as runaway. This causes the session to eventually trigger a runaway cleanup after it comes out of critical section. We still don't PANIC as runaway termination successfully ignores. But, the runaway detection couldn't ignore the critical section because of per-process critical section state and this eventually produces a diff in concourse occasionally.
      
      An alternative to introducing a new UDF is to modify the test to trigger it on a different segment other than segment 0, where the extra QE process currently gets created. I am waiting someone from QO to explain why we need an extra slice on segment 0. Until then I would rather not patch the test to trigger it on a different segment without having a guarantee that in the future planner will not generate the extra slice on another segment.
      ad43b80c
    • A
      Fix issues reported by Coverity · 272add75
      Asim R P 提交于
      ## CID 130007 Resource leak (file descriptor) in XlogFillZero()
      
      Coverity thinks that a file descriptor with value 0 may be leaked (no
      matching close() for an open()).  But open() will never return a file
      descriptor 0 in this case.  Change the code still to make Coverity happy.
      
      ## CID 129351 Dead code in XLogAddRecordsToChangeTracking()
      
      This is a legitimate case.  The `while (1)` loop already scans xlog
      until the end, so that (record == NULL) is true.  There is no point in
      trying to traverse till the end of xlog yet another time aftre
      breaking out of the `while (1)`.  So replace the code and add assert
      instead.
      272add75
    • H
      Don't ignore "application_name" in the startup packet in GPDB. · fabc35d5
      Heikki Linnakangas 提交于
      This reverts upstream commit 3c77fbd2 that we got as part of the 8.3
      merge. We have back-ported the full application_name feature from
      PostgreSQL 9.0 earlier already, so we don't need the hack to ignore
      application_name.
      fabc35d5
  3. 19 4月, 2017 17 次提交
  4. 18 4月, 2017 3 次提交