- 21 4月, 2017 5 次提交
-
-
由 Bhuvnesh Chaudhary 提交于
-
由 Asim R P 提交于
Objective of the test is only to check if DDL/DML on partition tables lock only the root table on QD. Child partitions are locked on QE as needed. The intermittent failures are due to more locks acquired than expected. In all such cases, the additional locks were AccessShare locks on some catalog table. This commit filters out locks on catalog tables from expected output. The intermittent failures merit investigation but that can happen regardless of this test fix.
-
由 C.J. Jameson 提交于
The coverity build was failing on the gpperfmon `make distclean` step Fixed on both sides: - Don't call `make distclean` in the coverity build script -- not necessary - Don't clean gpperfmon from `gpAux/Makefile`: this Makefile's clean targets are for enterprise-build related artifacts. General developers should be running `make clean distclean` from the top level directory of this repository. Additional fix -- doesn't address the coverity red but a similar cleanup: - Add cleanup of gpperfmon to the top level makefile's `distclean` target. Not sure why it wasn't there; probably just an accidental omission. - Add note explaining why the top level makefile has to circumvent `gpAux/Makefile` Signed-off-by: NMelanie Plageman <mplageman@pivotal.io>
-
This fixes a bug introduced in e378d84b where the partition selector may go in an infinite loop because it never got a chance to actually _select_ the partitions.
-
Commit 7b6dc9bf was well-intentioned, but wrong: in cases where `outerPlan` is NULL, inputSlot should be `NULL`, but the execution of the partition selector should *NOT* prematurely end there, instead, a static partition selection should happen (once) before this operator was exhausted (returning NULL). This is a pure revert commit. The `NULL` initialization will follow. This reverts commit 7b6dc9bf.
-
- 20 4月, 2017 15 次提交
-
-
由 Daniel Gustafsson 提交于
My OCD prevented me from glossing over this one..
-
由 Daniel Gustafsson 提交于
FileRepPrimary_IsResyncManagerOrWorker() is implicitly declared via the MIRROREDLOCK_BUFMGR_LOCK macro unless cdb/cdbfilerepprimary.h is included. Add to avoid warning.
-
由 Daniel Gustafsson 提交于
This codepath triggered a misleading-indentation warning in GCC and I can agree with that. Re-indent to make reading easier.
-
由 Daniel Gustafsson 提交于
It's not crystal clear from the code that the numeric_rel_num counter is guarding the pointer deref on numeric_rels, so init the pointer and add a guard check in the if-statement.
-
由 Daniel Gustafsson 提交于
statVal is uninitialized in the case of an unknown property, skip using it in that case.
-
由 Daniel Gustafsson 提交于
Functions only used in Assertions yields warnings on unused code in non-cassert enabled builds. Wrap the functions in the macro defined in assertion builds to avoid warning and make the intent with the code clearer.
-
由 Daniel Gustafsson 提交于
We want to make pgcrypto part of the default set of contrib modules shipped with Greenplum. Add to the default set building.
-
由 Daniel Gustafsson 提交于
We had previously backported most of contrib/pgcrypto from upstream PostgreSQL 8.4, but not all. This brings in the remaining bits to get us in line with REL8_4_STABLE, as well as removes a few local patches to minimize diff to upstream (only affecting style and some unused includes). Among others, this commit completely merges: commit df2e62603ebc59a8fff5b6cd21b844370a95b061 Author: Bruce Momjian <bruce@momjian.us> Date: Thu Apr 17 12:37:53 2014 -0400 pgcrypto: fix memset() calls that might be optimized away Specifically, on-stack memset() might be removed, so: * Replace memset() with px_memset() * Add px_memset to copy_crlf() * Add px_memset to pgp-s2k.c Patch by Marko Kreen Report by PVS-Studio Backpatch through 8.4. This commit partially merges: commit 99058cfc634ad59fa80f802f96c334be313faefb Author: Bruce Momjian <bruce@momjian.us> Date: Tue May 6 11:26:24 2014 -0400 Remove tabs after spaces in C comments This was not changed in HEAD, but will be done later as part of a pgindent run. Future pgindent runs will also do this. Report by Tom Lane Backpatch through all supported branches, but not HEAD With this, we are at parity with REL8_4_STABLE plus the below commits which have been backported from higher up due to them containing security and/or important bugfixes: commit 4a9710e6edd1a23f6a053eb4b58b2b784245dc7e Author: Tom Lane <tgl@sss.pgh.pa.us> Date: Tue Nov 11 17:22:15 2014 -0500 Loop when necessary in contrib/pgcrypto's pktreader_pull(). commit d95ebe0ac39b946c207ed0c37bba0365132ba3c6 Author: Noah Misch <noah@leadboat.com> Date: Mon Feb 2 10:00:45 2015 -0500 Fix buffer overrun after incomplete read in pullf_read_max(). Security: CVE-2015-0243 commit d1972da8ce5857cec09645c11d8c7ac81b87d887 Author: Noah Misch <noah@leadboat.com> Date: Mon Feb 2 10:00:45 2015 -0500 Cherry-pick security-relevant fixes from upstream imath library. Security: CVE-2015-0243 commit 0ba20043129280c6d076c80cc60e3f73880b9ea4 Author: Noah Misch <noah@leadboat.com> Date: Mon May 18 10:02:31 2015 -0400 pgcrypto: Report errant decryption as "Wrong key or corrupt data". Security: CVE-2015-3167
-
由 Adam Lee 提交于
Error table feature was removed, but `\h CREATE EXTERNAL TABLE` still has the description. This commit corrects it.
-
由 Foyzur Rahman 提交于
-
由 Melanie Plageman 提交于
- Remove Makefile definitions only used by gpcheckdb Signed-off-by: NLarry Hamel <lhamel@pivotal.io>
-
由 Foyzur Rahman 提交于
-
由 foyzur 提交于
We add one more udf that only allocates on one specific segment and modify the hit_vlim_crit_section test to use the new udf. The original generic UDF uses an union all which creates one extra slice on segment 0. This allowed existence of two QE processes on segment 0. The test checks if we successfully ignore runaway termination as long as we are in critical section. The critical section is a per-process state and therefore a second runaway detector on the same segment can still mark the session as runaway. This causes the session to eventually trigger a runaway cleanup after it comes out of critical section. We still don't PANIC as runaway termination successfully ignores. But, the runaway detection couldn't ignore the critical section because of per-process critical section state and this eventually produces a diff in concourse occasionally. An alternative to introducing a new UDF is to modify the test to trigger it on a different segment other than segment 0, where the extra QE process currently gets created. I am waiting someone from QO to explain why we need an extra slice on segment 0. Until then I would rather not patch the test to trigger it on a different segment without having a guarantee that in the future planner will not generate the extra slice on another segment.
-
由 Asim R P 提交于
## CID 130007 Resource leak (file descriptor) in XlogFillZero() Coverity thinks that a file descriptor with value 0 may be leaked (no matching close() for an open()). But open() will never return a file descriptor 0 in this case. Change the code still to make Coverity happy. ## CID 129351 Dead code in XLogAddRecordsToChangeTracking() This is a legitimate case. The `while (1)` loop already scans xlog until the end, so that (record == NULL) is true. There is no point in trying to traverse till the end of xlog yet another time aftre breaking out of the `while (1)`. So replace the code and add assert instead.
-
由 Heikki Linnakangas 提交于
This reverts upstream commit 3c77fbd2 that we got as part of the 8.3 merge. We have back-ported the full application_name feature from PostgreSQL 9.0 earlier already, so we don't need the hack to ignore application_name.
-
- 19 4月, 2017 17 次提交
-
-
由 Daniel Gustafsson 提交于
Commit 7143309f exposed find_option to outside callers, with a prototype declared in guc_gp.c. This cause compiler warning on guc.c so expose it in guc.h as it is now an exported symbol. This fixes: guc.c:3231:1: warning: no previous prototype for function 'find_option' [-Wmissing-prototypes] find_option(const char *name, bool create_placeholders, int elevel) ^
-
由 Christopher Hajas 提交于
The DDVE only supports a maximum of 15 streams. If a higher number is provided, the replication will fail.
-
This reverts commit cd2cfa7d.
-
This reverts commit 83a2f870.
-
This reverts commit 3aa7de6a.
-
由 Larry Hamel 提交于
-- including all text references Signed-off-by: NMelanie Plageman <mplageman@pivotal.io>
-
由 Christopher Hajas 提交于
These are nightly triggers. Full Duration: 1.5 hours Incremental Duration: 3.5 hours MFR Duration: 40 mins
-
由 Christopher Hajas 提交于
Renames 4.3 sql and answer files since these tests are now versioned with the code and deletes old 4.2 files.
-
由 Christopher Hajas 提交于
-
由 Christopher Hajas 提交于
-
由 Melanie Plageman 提交于
Signed-off-by: NMarbin Tan <mtan@pivotal.io>
-
由 Melanie Plageman 提交于
The file postgresql.conf contains GUC settings which are applied upon GPDB restart. --file-compare contrasts the current GPDB settings (stored in the database) to settings in the file which would be applied upon restart. For almost all GUCs, all segments should have the same value; the --file-compare flag either summarizes success (when synchronized) or, in the case of unexpected differences, outputs detailed information about a given GUC on all segments. Signed-off-by: NMarbin Tan <mtan@pivotal.io>
-
由 Melanie Plageman 提交于
Signed-off-by: NMarbin Tan <mtan@pivotal.io>
-
由 Melanie Plageman 提交于
On our normal workstations, gpsmon comes up within 5 seconds very consistently, but in other environments, it might need more time Signed-off-by: NC.J. Jameson <cjameson@pivotal.io>
-
由 Jesse Zhang 提交于
The xpath test in general is fairly questionable: - it largely overlaps in coverage with the xml test from upstream - it contains a few negative assertions that depend on an error message that doesn't even come from our (Postgres) code: it's an implementation detail of libxml2. On CentOS, a few Red Hat patches to libxml2 always make those tests fail. This commit removes the xpath test.
-
由 mkiyama 提交于
[ci skip]
-
由 Ekta Khanna 提交于
`optimizer_explain_show_status` GUC is guarding the optimizer status string in the explain output. There is no added value for guarding the optimizer status output with a GUC. Therefore, we are removing it. Signed-off-by: NOmer Arap <oarap@pivotal.io>
-
- 18 4月, 2017 3 次提交
-
-
由 Ning Wu 提交于
-
由 Ning Wu 提交于
1. fix an error if the quote and escape options are not specified in the CSV format. 2. add codes for delimiter, escape and quote options to process a ASCII, unicode-encoded or escaped single character in order to find the correct table to reuse when load external data.
-
由 xiong-gang 提交于
1. Support num_running, num_queueing, num_queued, num_executed and total_queue_duration in gp_toolkit.gp_resgroup_status. 2. Reflect status in pg_stat_activity when transaction is queued in resource group. Signed-off-by: NRichard Guo <riguo@pivotal.io> Signed-off-by: NKenan Yao <kyao@pivotal.io>
-