1. 29 8月, 2016 11 次提交
  2. 28 8月, 2016 1 次提交
  3. 26 8月, 2016 8 次提交
  4. 25 8月, 2016 20 次提交
    • H
    • H
      Reformat some GPDB-specific files. · 31b4c867
      Heikki Linnakangas 提交于
      Whitespace and comment fixes, to follow the usual project style.
      
      Remove duplicated function comments between the .h and .c files. Per the
      usual project convention, all explanations of a function and its arguments
      are in the .c file, and the .h file only contains the prototypes. There
      were some additional comments about the "sections" of the files that
      seemed useful, but were only in the .h files. I moved those to the .c
      files instead.
      31b4c867
    • H
      Change AO block checksum algorithm to match that of 4.3. · b2ba0062
      Heikki Linnakangas 提交于
      Turns out that commit 6c025b52 subtly
      changed the CRC calculation. The old crc32cFinish() inline function
      returned the final checksum, while the new FIN_CRC32C() macro modifies
      the variable in place. The old calls to crc32cFinish() discarded the
      return value, and were therefore in fact no-ops. That was surely not
      intentional, but it doesn't make any difference to the strength of
      the checksum, so it doesn't seem worth changing from previous releases.
      b2ba0062
    • H
      Remove obsolete upgrade-handling code. · 8b37b2d9
      Heikki Linnakangas 提交于
      8b37b2d9
    • H
      Remove gp_flush_buffer_pages_when_evicted GUC. · 668d4af8
      Heikki Linnakangas 提交于
      Looking at old git history, this was added back in 2009. The related
      ticket on adding it said:
      
          Add GUC that make every buffer page from the buffer pool flushed on
          eviction.
      
          Note that this will NOT necessarily flush all buffer pages when the
          postmaster is shutdown. I think this is acceptable for our purposes.
      
          (Our purpose is to make sure that overwrites of the buffer pages are not
          lost and instead are always written to disk so we can catch errors)
      
      I'm not sure what errors that was meant to catch, or how, but I don't
      think we have any regression tests or anything that uses it anymore.
      Let's remove it, to make merging with upstream easier.
      668d4af8
    • H
      Remove dead catcore stuff. · 1978dff7
      Heikki Linnakangas 提交于
      These were only used by CaQL. I didn't realize that earlier..
      1978dff7
    • D
      Fix incorrect memorized output in information_schema test · 1db4dbd3
      Daniel Gustafsson 提交于
      This actually returns 6 rows and not 5, not sure why that hasn't
      triggered before but the reorganisation of gpdiff uncovered it.
      1db4dbd3
    • D
      Move GPDB specific test from the upstream schedule file · 6dc675c9
      Daniel Gustafsson 提交于
      The variadic and default parameters tests are specific to GPDB so
      move them to our own regress schedule file.
      6dc675c9
    • D
      Avoid string interpolation · 5b4012d3
      Daniel Gustafsson 提交于
      Not invoking string interpolation when it's not needed is quite a
      micro optimization but over the course of many iterations it can
      still be worthwhile. Only strings containing variables or escape
      sequences need to be within quote marks.
      5b4012d3
    • D
      Perform micro optimizations of atmsort · d2e44db1
      Daniel Gustafsson 提交于
      This commit contains a collection of tricks to perform some level
      of micro optimizations of mostly the regex code for matching output
      lines in the test parsing but also some of the logic.
      
       * Avoid capturing parens grouped matches that we dont use: when
         matching with m/(foo|bar)/ where the match isn't used with $1
         the cost of allocating the match in memory can be avoided by
         instead matching for m/(?:foo|bar)/ which instructs Perl to
         throw away the exact match.
       * Break out early in logic: when possible reorder such that a
         static check might skip over the regex entirely. Where we
         match for line with a comment marker we can for example do
         a first check for the comment marker and only perform the
         subsequent checks if that was found. Also assist Perl with
         branch prediction in case that can be beneficial.
       * Remove case insensitive matching where possible: if we
         know that we can provide the right case in the regex instead
         there is a lot of save on processing.
       * Collapse regexes: where possible ensure that a single regex
         does more by collapsing regexes together with more logic in
         figuring out what matched.
       * Remove regexes: where possible, remove the regex entirely and
         instead use the index() function which for short strings is
         much faster (short is around 10k chars).
       * Rather than looping over arrays with foreach for trivial
         operations, use map() instead.
      d2e44db1
    • D
      Remove support for ignore_headers command in gpdiff · 3168a627
      Daniel Gustafsson 提交于
      gpdiff had support for ignoring header lines in query output which
      we aren't using in any testsuite at all. Since this required regex
      checking for each line in the output (it could be turned on for a
      section of the output) this feature has a non-trivial cost. Remove
      as an optimization for the tests that we do have.
      3168a627
    • D
      Fix typos in greenplum_schedule documentation · bbf54980
      Daniel Gustafsson 提交于
      bbf54980
    • H
      32ca9880
    • H
      Remove CaQL. · 1a2a02a6
      Heikki Linnakangas 提交于
      The previous commits have removed all usage of CaQL. It's no longer
      needed.
      1a2a02a6
    • H
      Remove CaQL call from gphdfs. · 5ae8d6d1
      Heikki Linnakangas 提交于
      Use the get_type_name() lsyscache function directly.
      5ae8d6d1
    • H
      Refactor IndexInfo struct population code. · 0cd6c41e
      Heikki Linnakangas 提交于
      The IndexInfo structs are used by ORCA to decide which indexes match an
      expression, and there may be some other similar use for them too. This patch
      changes it to fetch the index expressions and predicates from the relcache,
      rather than deparsing them directly from the pg_index catalog. The versions
      stored in the relcache have been run through const-evaluation and
      canonicalization passes, so they are slightly different. I believe the
      versions stored in the relcache are what we actually want here, for the
      reasons explained in RelationGetIndexPredicate() and
      RelationGetIndexExpressions().
      0cd6c41e
    • H
      Replace CaQL calls with systable scans. · 778205a7
      Heikki Linnakangas 提交于
      778205a7
    • H
    • H
      Eliminate caql_getcount(). · 9bf5a8e3
      Heikki Linnakangas 提交于
      It was used for DELETEs, and SELECT COUNT(*). Replace with the usual
      syscache lookups, systable scans, and simple_heap_update/delete calls,
      like these things are done in the upstream.
      9bf5a8e3
    • H
      Get rid of caql_getattname and similar functions. · e0f59a56
      Heikki Linnakangas 提交于
      There were only a few callers using it. Use the upstream
      SearchSysCacheAttName() function instead.
      e0f59a56