The following code has been removed in the new version of
function PROCESS_QE in commit ce4d96b6, but the function
UPDATE_MPP definition used in it has not been deleted.

This reverts commit 0b55a443.

This reverts commit c242c8b5.

The following pipeline:

    $CAT $SED_TMP_FILE | $TRUSTED_SHELL ${SED_HOST} $DD of=$SED_TMP_FILE > /dev/null 2>&1

when run with a TRUSTED_SHELL that executed the command on the local
host, suffered from a race where cat was reading from the file as dd was
attempting to truncate it. In situations where dd won that race, the
resulting sed command file would be empty, and no change would be made.

Simplify the logic by removing all temporary files, and forwarding the
sed command file contents to TRUSTED_SHELL via the stdin pipe.
Co-authored-by: NShoaib Lari <slari@pivotal.io>

Rather than hardcoding to require /bin/bash, move to using a lookup
via "/usr/bin/env bash" to allow for greater portability of the code.
This also changes the Bash test to checking if the current shell is
actually Bash, rather than looking if bash is available on the file
system (since we by the above mentioned changes no longer need that).

We will not be supporting these utilities in GPDB 6.

References to gpcrondump and gpdbrestore in the gpdb-doc directory have been left
intact, as the documentation will be updated to refer to gpbackup and gprestore
in a separate commit.

Author: Jamie McAtamney <jmcatamney@pivotal.io>

- use the new fact that datadirs are in the gp_segment_configuration
- fix a few things with the gpperfmon behave tests (mostly for macOS)
   --> the change to mgmt_utils.py is to do the config file manipulation
   natively in python
   --> the change to the gp_bash_functions.sh is to use ASCII '
   characters so that python string comparison is happier

Author: C.J. Jameson <cjameson@pivotal.io>

LOG_MSG is called a lot during gpinitsystem (>400 times on my machine),
and the (echo | awk | tr | grep) dance gets expensive, especially when
we do it four times per call. We can do all this stuff with a single
pass in native bash, which saves ten to fifteen seconds of runtime for
me when creating a demo-cluster.

Along the same lines, call `date` only once for a timestamp.

Workaround a problem discovered by a client that noticed intermittent errors for gpssh when some nodes became very cpu-bound.

In particular, we override the way the ssh command prompt is validated
on a remote machine, within gpssh. The vendored module 'pexpect' tries to match 2 successive prompts
from an interactive bash shell.  However, if the target host is slow from
CPU loading or network loading, these prompts may return late.

In that case, the override retries several times, extending the timeout from the
default 1 second to up to 125 times that duration.

Experimentally, these added retries seem to tolerate about 1 second delay, testing with a 'tc' command that slows network traffic artificially.

The number of retries can be configured.

--add unit tests to verify happy path of ssh-ing to localhost
--add module for gpssh, for overriding pexpect (pxxssh)
--add readme to describe testing technique using 'tc' to delay network
Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

Commit a8f956c6 removed the old SAN
failover code but left the catalogs in place due to catalog change
freeze. This removes the no longer used catalogs and the relevant
doc entries.

Signed-off-by: NLarry Hamel <lhamel@pivotal.io>

* Fortify SED_PG_CONF() shell function, as called by gpinitsystem

It's also called via gpcreateseg.sh

There is a chance where gpinitsystem may miss a GUC change in one of the
segments and left undetected. This would cause failures down the line.

More robust in three ways:
- Retry ssh calls in case they fail
- Actually error exit if it does fail, for quicker diagnosis if the
  value in postgres.conf did not get updated
- When keeping a version of the key-value pair in a comment, only
  archive the first-matched key-value (otherwise you get comments on
  your comments)

Use trap for retrying failed ssh
Use trap in a limited scope for now

There is a lot of tab/space confusion in the code, this fixes some
of the worst offenders but there is lots of low-hanging fruit left.

There was a lot of unused code in the gpMgmt bash code that hasn't
been running for quite some time. On top of really dead code, some
codepaths were reachable, but useless (like printing a non-existing
version string). Remove the dead code and replace the version print
with working code which pulls the version from the canonical source.

`gpinitsystem`, `gpstart` and `gpstop` had different prompting before:

$ gpinitsystem -c gpinitsystem_config 
...
Continue with Greenplum creation **Yy/Nn>**
n
...

$ gpstart
...

Continue with Greenplum instance startup **Yy|Nn (default=N):**
**>** n
...

$ gpstop
...

Continue with Greenplum instance shutdown **Yy|Nn (default=N):**
**>** n
...

This commit makes them consistent:

$ gpinitsystem -c gpinitsystem_config 
...

Continue with Greenplum creation Yy|Nn (default=N):
> n

This removes all utilities which are known to be deprecated from
gpMgmt and it also clears out any command line switches marked as
deprecated along with code marked deprecated. It also removes the
leftovers from previously removed utilities such as gpsuspend and
gpcheck_hostdump etc and fixes mentions of renamed utilities.

There should be no functional change from this commit as the only
removed utils have been marked deprecated for some time.

This will no longer spill logfiles from the demo cluster into
the users ~/gpAdminLogs directory. Also it makes it easier to
identify which logfile was created by the last regression test run.

Closes #689
Closes #523

Along the way, fix trailing tabs and split a long error
message into two lines.

This will fix #524

The gpssh utility can have issues during the initial ssh connection
step due to different network configurations that may cause delay.
This commit exposes two key pxssh variables, delaybeforesend and
sync_multiplier, into configurables so that users can change them
as needed to ensure their gpssh works as intended in their network.

Authors: Christopher Hajas and Jimmy Yih

cleanup of syntax around inet4 v inet6 parsing to match

changing spacing in piped commands

fixing case semicolons

Adding freebsd IP detection commands

While GNU TAR is used throughout GPDB this definition doesn't seem
to be used so avoid spending cycles performing it.

when the add-on config file contains GUCs which exist in postgresql.conf.sample,
and are commented out(e.g, #max_resource_queues), these GUC settings would not
take effect because incorrect posgresql.conf would be generated by gpinitsystem.

README.debian to remove "ed" dependency.

Replace "ed" with "sed" in ED_PG_CONF function.  ED_PG_CONF and
supporting variables are renamed with "SED" as needed.