1. 10 4月, 2019 1 次提交
  2. 23 1月, 2019 2 次提交
    • A
      Delete gpsetdbid.py and gp_dbid.py. · 549cd61c
      Ashwin Agrawal 提交于
      Co-authored-by: NAlexandra Wang <lewang@pivotal.io>
      549cd61c
    • A
      Store gp_dbid and gp_contentid in conf files. · 4eaeb7bc
      Ashwin Agrawal 提交于
      Currently, gp_dbid and gp_contentid is passed as command line
      arguments for starting QD and QE. Since, the values are stored in
      master's catalog table, to get the right values, must start the master
      first. Hence, hard-coded dbid=1 was used for starting the master in
      admin mode always. This worked fine till dbid was not used for
      anything on-disk. But given dbid is used for tablespace path in GPDB
      6, startting the instance with wrong dbid, means inviting recovery
      time failues, data corruption or data loss situations. Dbid=1 will go
      wrong after failover to standby master as it has dbid != 1. This
      commit hence eliminate the need of passing the gp_dbid and
      gp_contentid on command line, instead while creating the instance the
      values are stored in conf files for the instance.
      
      This also helps to avoid passing gp_dbid as argument to pg_rewind,
      which needs to start target instance in single user mode to complete
      recovery before performing rewind operation.
      
      Plus, this eases during development to just use pg_ctl start and not
      require to correctly pass these values.
      
       - gp_contentid is stored in postgresql.conf file.
      
       - gp_dbid is stored in internal.auto.conf.
      
       - Introduce internal.auto.conf file created during
         initdb. internal.auto.conf is included from postgresql.conf file.
      
       - Separate file is chosen to write gp_dbid for ease handling during
         pg_rewind and pg_basebackup, as can exclude copying this file from
         primary to mirror, instead of trying to edit the contents of the
         same after copy during these operations. gp_contentid remains same
         for primary and mirror hence having it in postgresql.conf file
         makes senes. If gp_contentid is also stored in this new file
         internal.auto.conf then pg_basebackup needs to be passed contentid
         as well to write to this file.
      
       - pg_basebackup: write the gp_dbid after backup. Since, gp_dbid is
         unique for primary and mirror, pg_basebackup excludes copying
         internal.auto.conf file storing the gp_dbid. pg_basebackup explicit
         (over)writes the file with value passed as
         --target-gp-dbid. --target-gp-dbid due to this is mandatory
         argument to pg_basebackup now.
      
       - gpexpand: update gp_dbid and gp_contentid post directory copy.
      
       - pg_upgrade: retain all configuration files for
         segment. postgresql.auto.conf and internal.auto.conf are also
         internal configuration files which should be restored back after
         directory copy. Similar, change is required in gp_upgrade repo in
         restoreSegmentFiles() after copyMasterDirOverSegment().
      
       - Update tests to avoid passing gp_dbid and gp_contentid.
      Co-authored-by: NAlexandra Wang <lewang@pivotal.io>
      4eaeb7bc
  3. 08 9月, 2018 2 次提交
  4. 30 8月, 2018 1 次提交
  5. 03 8月, 2018 3 次提交
  6. 10 7月, 2018 2 次提交
  7. 13 1月, 2018 3 次提交
    • J
      Remove gpcrondump, gpdbrestore, and related files · 8922315e
      Jamie McAtamney 提交于
      We will not be supporting these utilities in GPDB 6.
      
      References to gpcrondump and gpdbrestore in the gpdb-doc directory have been left
      intact, as the documentation will be updated to refer to gpbackup and gprestore
      in a separate commit.
      
      Author: Jamie McAtamney <jmcatamney@pivotal.io>
      8922315e
    • C
      Remove use of pg_filespace from gpperfmon · 081e7176
      C.J. Jameson 提交于
      - use the new fact that datadirs are in the gp_segment_configuration
      - fix a few things with the gpperfmon behave tests (mostly for macOS)
         --> the change to mgmt_utils.py is to do the config file manipulation
         natively in python
         --> the change to the gp_bash_functions.sh is to use ASCII '
         characters so that python string comparison is happier
      
      Author: C.J. Jameson <cjameson@pivotal.io>
      081e7176
    • H
      Remove some unused bash code. · 01bc7247
      Heikki Linnakangas 提交于
      01bc7247
  8. 22 12月, 2017 1 次提交
  9. 01 11月, 2017 1 次提交
    • J
      gp_bash_functions: avoid expensive calls in LOG_MSG · ea770b51
      Jacob Champion 提交于
      LOG_MSG is called a lot during gpinitsystem (>400 times on my machine),
      and the (echo | awk | tr | grep) dance gets expensive, especially when
      we do it four times per call. We can do all this stuff with a single
      pass in native bash, which saves ten to fifteen seconds of runtime for
      me when creating a demo-cluster.
      
      Along the same lines, call `date` only once for a timestamp.
      ea770b51
  10. 11 7月, 2017 1 次提交
    • N
      Adapt pexpect override to handle delays up to 10 second · f7aa215a
      Nadeem Ghani 提交于
      Workaround a problem discovered by a client that noticed intermittent errors for gpssh when some nodes became very cpu-bound.
      
      In particular, we override the way the ssh command prompt is validated
      on a remote machine, within gpssh. The vendored module 'pexpect' tries to match 2 successive prompts
      from an interactive bash shell.  However, if the target host is slow from
      CPU loading or network loading, these prompts may return late.
      
      In that case, the override retries several times, extending the timeout from the
      default 1 second to up to 125 times that duration.
      
      Experimentally, these added retries seem to tolerate about 1 second delay, testing with a 'tc' command that slows network traffic artificially.
      
      The number of retries can be configured.
      
      --add unit tests to verify happy path of ssh-ing to localhost
      --add module for gpssh, for overriding pexpect (pxxssh)
      --add readme to describe testing technique using 'tc' to delay network
      Signed-off-by: NLarry Hamel <lhamel@pivotal.io>
      f7aa215a
  11. 06 7月, 2017 1 次提交
  12. 08 6月, 2017 1 次提交
  13. 17 5月, 2017 1 次提交
    • C
      Fortify SED_PG_CONF() shell function, as called by gpinitsystem (#2389) · 259cd785
      C.J. Jameson 提交于
      * Fortify SED_PG_CONF() shell function, as called by gpinitsystem
      
      It's also called via gpcreateseg.sh
      
      There is a chance where gpinitsystem may miss a GUC change in one of the
      segments and left undetected. This would cause failures down the line.
      
      More robust in three ways:
      - Retry ssh calls in case they fail
      - Actually error exit if it does fail, for quicker diagnosis if the
        value in postgres.conf did not get updated
      - When keeping a version of the key-value pair in a comment, only
        archive the first-matched key-value (otherwise you get comments on
        your comments)
      
      Use trap for retrying failed ssh
      Use trap in a limited scope for now
      259cd785
  14. 05 5月, 2017 3 次提交
    • D
      Fix spelling in logmessages · e4b831e4
      Daniel Gustafsson 提交于
      e4b831e4
    • D
      Fix up a bit of whitespace · c1588a7a
      Daniel Gustafsson 提交于
      There is a lot of tab/space confusion in the code, this fixes some
      of the worst offenders but there is lots of low-hanging fruit left.
      c1588a7a
    • D
      Remove dead code · b2c759ca
      Daniel Gustafsson 提交于
      There was a lot of unused code in the gpMgmt bash code that hasn't
      been running for quite some time. On top of really dead code, some
      codepaths were reachable, but useless (like printing a non-existing
      version string). Remove the dead code and replace the version print
      with working code which pulls the version from the canonical source.
      b2c759ca
  15. 07 3月, 2017 1 次提交
    • Y
      Make gpinitsystem similar to gpstart and gpstop prompting (#1942) · 0701a77b
      yanchaozhong 提交于
      `gpinitsystem`, `gpstart` and `gpstop` had different prompting before:
      
      $ gpinitsystem -c gpinitsystem_config 
      ...
      Continue with Greenplum creation **Yy/Nn>**
      n
      ...
      
      $ gpstart
      ...
      
      Continue with Greenplum instance startup **Yy|Nn (default=N):**
      **>** n
      ...
      
      $ gpstop
      ...
      
      Continue with Greenplum instance shutdown **Yy|Nn (default=N):**
      **>** n
      ...
      
      This commit makes them consistent:
      
      $ gpinitsystem -c gpinitsystem_config 
      ...
      
      Continue with Greenplum creation Yy|Nn (default=N):
      > n
      0701a77b
  16. 23 8月, 2016 1 次提交
    • D
      Remove deprecated functionality and leftovers from removed utils · f8488849
      Daniel Gustafsson 提交于
      This removes all utilities which are known to be deprecated from
      gpMgmt and it also clears out any command line switches marked as
      deprecated along with code marked deprecated. It also removes the
      leftovers from previously removed utilities such as gpsuspend and
      gpcheck_hostdump etc and fixes mentions of renamed utilities.
      
      There should be no functional change from this commit as the only
      removed utils have been marked deprecated for some time.
      f8488849
  17. 19 5月, 2016 1 次提交
  18. 12 4月, 2016 1 次提交
  19. 06 2月, 2016 1 次提交
    • C
      Expose gpssh's pexpect.pxssh settings in a configurable file. · 7220b548
      Chris Hajas 提交于
      The gpssh utility can have issues during the initial ssh connection
      step due to different network configurations that may cause delay.
      This commit exposes two key pxssh variables, delaybeforesend and
      sync_multiplier, into configurables so that users can change them
      as needed to ensure their gpssh works as intended in their network.
      
      Authors: Christopher Hajas and Jimmy Yih
      7220b548
  20. 05 1月, 2016 1 次提交
  21. 18 12月, 2015 1 次提交
  22. 10 12月, 2015 1 次提交
    • K
      gpinitsystem -p does not produce correct postgresql.conf file · 3636746b
      Kenan Yao 提交于
      when the add-on config file contains GUCs which exist in postgresql.conf.sample,
      and are commented out(e.g, #max_resource_queues), these GUC settings would not
      take effect because incorrect posgresql.conf would be generated by gpinitsystem.
      3636746b
  23. 10 11月, 2015 2 次提交
  24. 28 10月, 2015 1 次提交