Remove disabled code in set_plan_references_input_asserts()
This commit removes GPDB_93_MERGE_FIXME introduced while including 46c508fb from upstream. The intention of the upstream commit is to keep planner params separated so that they don't get reused incorrectly. In doing so, it removed the need for a global list of PlannerParamItems. The removed assertion in this commit was verifying that each Param in the tree was included in a global list of PlannerParamItems, and that each datatype of each Param matches that in the global list. At the time of the assertion, we simply don't have the necessary information to be able to verify properly. An argument could be made for re-introducing such a global list PlannerParamItems. However this assertion would not verify that a parameter is ancored in the right place and it would introduce additional code to maintain. Reviewed-by: NHeikki Linnakangas <hlinnakangas@pivotal.io>
Showing
想要评论请 注册 或 登录