提交 9baf5269 编写于 作者: G Georgios Kokolatos

Remove fixme comment as it is not relative to the merge itself

However, it correctly identifies that xidWarnLimit should not be
configurable. The same should also apply for xidStopLimit. The GUCs
for those were added in time immemorial, i.e. significantly before
greenplum was opensourced, with a commit message clearly identifying
their addition as a one shot hotfix.

A proposal for their depracation has been made in the forum.
Co-authored-by: NDaniel Gustafsson <dgustafsson@pivotal.io>
Reviewed-by: NHeikki Linnakangas <hlinnakangas@pivotal.io>
上级 cb5d1db9
......@@ -368,8 +368,6 @@ SetTransactionIdLimit(TransactionId oldest_datfrozenxid, Oid oldest_datoid)
* clients that won't pay attention to warnings. (No, we're not gonna make
* this configurable. If you know enough to configure it, you know enough
* to not get in this kind of trouble in the first place.)
*
* GPDB_94_MERGE_FIXME: well, we've made it configurable anyway. Not sure why.
*/
xidWarnLimit = xidStopLimit - (TransactionId)xid_warn_limit;
if (xidWarnLimit < FirstNormalTransactionId)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册