提交 1c8f8c11 编写于 作者: J Jingwen Owen Ou

Make knowHosts and defaultHost private

上级 d497dc94
......@@ -151,7 +151,7 @@ func (c *Configs) DefaultCredentials() (credentials *Credentials) {
} else if len(c.Credentials) > 0 {
credentials = c.selectCredentials()
} else {
credentials = c.PromptFor(DefaultHost())
credentials = c.PromptFor(defaultHost())
}
return
......
......@@ -23,20 +23,20 @@ func (h Hosts) Include(host string) bool {
return false
}
func KnownHosts() (hosts Hosts) {
func knownHosts() (hosts Hosts) {
ghHosts, _ := git.Config("gh.host")
for _, ghHost := range strings.Split(ghHosts, "\n") {
hosts = append(hosts, ghHost)
}
defaultHost := DefaultHost()
defaultHost := defaultHost()
hosts = append(hosts, defaultHost)
hosts = append(hosts, fmt.Sprintf("ssh.%s", defaultHost))
return
}
func DefaultHost() string {
func defaultHost() string {
defaultHost := GitHubHostEnv
if defaultHost == "" {
defaultHost = GitHubHost
......
......@@ -127,7 +127,7 @@ func CurrentProject() *Project {
}
func NewProjectFromURL(url *url.URL) (p *Project, err error) {
if !KnownHosts().Include(url.Host) {
if !knownHosts().Include(url.Host) {
err = fmt.Errorf("Invalid GitHub URL: %s", url)
return
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册