From 1c8f8c11ef50f159a900027ddf54ad7bdb87a3dc Mon Sep 17 00:00:00 2001 From: Jingwen Owen Ou Date: Sun, 15 Dec 2013 09:03:44 -0800 Subject: [PATCH] Make knowHosts and defaultHost private --- github/configs.go | 2 +- github/hosts.go | 6 +++--- github/project.go | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/github/configs.go b/github/configs.go index 90a8d744..7822dfaa 100644 --- a/github/configs.go +++ b/github/configs.go @@ -151,7 +151,7 @@ func (c *Configs) DefaultCredentials() (credentials *Credentials) { } else if len(c.Credentials) > 0 { credentials = c.selectCredentials() } else { - credentials = c.PromptFor(DefaultHost()) + credentials = c.PromptFor(defaultHost()) } return diff --git a/github/hosts.go b/github/hosts.go index aa54b369..8b8288c7 100644 --- a/github/hosts.go +++ b/github/hosts.go @@ -23,20 +23,20 @@ func (h Hosts) Include(host string) bool { return false } -func KnownHosts() (hosts Hosts) { +func knownHosts() (hosts Hosts) { ghHosts, _ := git.Config("gh.host") for _, ghHost := range strings.Split(ghHosts, "\n") { hosts = append(hosts, ghHost) } - defaultHost := DefaultHost() + defaultHost := defaultHost() hosts = append(hosts, defaultHost) hosts = append(hosts, fmt.Sprintf("ssh.%s", defaultHost)) return } -func DefaultHost() string { +func defaultHost() string { defaultHost := GitHubHostEnv if defaultHost == "" { defaultHost = GitHubHost diff --git a/github/project.go b/github/project.go index 44f7d690..ac301129 100644 --- a/github/project.go +++ b/github/project.go @@ -127,7 +127,7 @@ func CurrentProject() *Project { } func NewProjectFromURL(url *url.URL) (p *Project, err error) { - if !KnownHosts().Include(url.Host) { + if !knownHosts().Include(url.Host) { err = fmt.Errorf("Invalid GitHub URL: %s", url) return } -- GitLab