Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
github
hub
提交
03b29816
H
hub
项目概览
github
/
hub
大约 1 年 前同步成功
通知
3
Star
22523
Fork
2406
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
H
hub
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
03b29816
编写于
10月 30, 2019
作者:
M
Mislav Marohnić
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[release] Retry attaching release assets on 5xx server errors
Fixes #2197
上级
adaa53e4
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
48 addition
and
4 deletion
+48
-4
features/release.feature
features/release.feature
+27
-0
github/client.go
github/client.go
+21
-4
未找到文件。
features/release.feature
浏览文件 @
03b29816
...
...
@@ -456,6 +456,33 @@ MARKDOWN
Attaching 1 asset...\n
"""
Scenario
:
Retry attaching assets on 5xx errors
Given the GitHub API server
:
"""
attempt = 0
post('/repos/mislav/will_paginate/releases') {
status 201
json :html_url => "https://github.com/mislav/will_paginate/releases/v1.2.0",
:upload_url => "https://uploads.github.com/uploads/assets{?name,label}"
}
post('/uploads/assets', :host_name => 'uploads.github.com') {
attempt += 1
halt 400 unless request.body.read.to_s == "TARBALL"
halt 502 if attempt == 1
status 201
}
"""
And a file named "hello-1.2.0.tar.gz" with
:
"""
TARBALL
"""
When
I successfully run `hub release create -m
"hello"
v1.2.0 -a hello-1.2.0.tar.gz`
Then the output should contain exactly
:
"""
https://github.com/mislav/will_paginate/releases/v1.2.0
Attaching 1 asset...\n
"""
Scenario
:
Create a release with some assets failing
Given the GitHub API server
:
"""
...
...
github/client.go
浏览文件 @
03b29816
...
...
@@ -412,11 +412,28 @@ func (client *Client) UploadReleaseAssets(release *Release, assets []LocalAsset)
}
uploadPath
:=
addQuery
(
uploadURL
,
params
)
// TODO: retry failed assets
var
res
*
simpleResponse
res
,
err
=
api
.
PostFile
(
uploadPath
,
asset
.
Contents
,
asset
.
Size
)
if
err
=
checkStatus
(
201
,
"uploading release asset"
,
res
,
err
);
err
!=
nil
{
return
attempts
:=
0
maxAttempts
:=
3
body
:=
asset
.
Contents
for
{
res
,
err
=
api
.
PostFile
(
uploadPath
,
body
,
asset
.
Size
)
if
err
==
nil
&&
res
.
StatusCode
>=
500
&&
res
.
StatusCode
<
600
&&
attempts
<
maxAttempts
{
attempts
++
time
.
Sleep
(
time
.
Second
*
time
.
Duration
(
attempts
))
var
f
*
os
.
File
f
,
err
=
os
.
Open
(
asset
.
Name
)
if
err
!=
nil
{
return
}
defer
f
.
Close
()
body
=
f
continue
}
if
err
=
checkStatus
(
201
,
"uploading release asset"
,
res
,
err
);
err
!=
nil
{
return
}
break
}
newAsset
:=
ReleaseAsset
{}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录