pull_request.feature 30.8 KB
Newer Older
1 2
Feature: hub pull-request
  Background:
3
    Given I am in "git://github.com/mislav/coral.git" git repo
4
    And I am "mislav" on github.com with OAuth token "OTOKEN"
5
    And the git commit editor is "vim"
6

7
  Scenario: Detached HEAD
8
    Given I am in detached HEAD
9 10 11 12
    When I run `hub pull-request`
    Then the stderr should contain "Aborted: not currently on any branch.\n"
    And the exit status should be 1

13 14 15 16 17 18 19 20 21 22 23 24
  Scenario: Non-GitHub repo
    Given the "origin" remote has url "mygh:Manganeez/repo.git"
    When I run `hub pull-request`
    Then the stderr should contain "Aborted: the origin remote doesn't point to a GitHub repository.\n"
    And the exit status should be 1

  Scenario: Create pull request respecting "insteadOf" configuration
    Given the "origin" remote has url "mygh:Manganeez/repo.git"
    When I successfully run `git config url."git@github.com:".insteadOf mygh:`
    Given the GitHub API server:
      """
      post('/repos/Manganeez/repo/pulls') {
25
        assert :base  => 'master',
26
               :head  => 'Manganeez:master',
27
               :title => 'here we go'
28
        status 201
29 30 31
        json :html_url => "https://github.com/Manganeez/repo/pull/12"
      }
      """
32
    When I successfully run `hub pull-request -m "here we go"`
33
    Then the output should contain exactly "https://github.com/Manganeez/repo/pull/12\n"
34 35 36 37 38 39

  Scenario: With Unicode characters
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        halt 400 if request.content_charset != 'utf-8'
40
        assert :title => 'ăéñøü'
41
        status 201
42 43 44
        json :html_url => "the://url"
      }
      """
45
    When I successfully run `hub pull-request -m ăéñøü`
46
    Then the output should contain exactly "the://url\n"
47

48 49 50
  Scenario: Invalid flag
    When I run `hub pull-request -yelp`
    Then the stderr should contain "unknown shorthand flag: 'y' in -yelp\n"
J
Jingwen Owen Ou 已提交
51
    And the exit status should be 1
52

53 54 55 56 57 58 59 60 61 62 63
  Scenario: With Unicode characters in the changelog
    Given the text editor adds:
      """
      I <3 encodings
      """
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        halt 400 if request.content_charset != 'utf-8'
        assert :title => 'I <3 encodings',
               :body => 'ăéñøü'
64
        status 201
65 66 67 68 69 70 71 72 73 74
        json :html_url => "the://url"
      }
      """
    Given I am on the "master" branch pushed to "origin/master"
    When I successfully run `git checkout --quiet -b topic`
    Given I make a commit with message "ăéñøü"
    And the "topic" branch is pushed to "origin/topic"
    When I successfully run `hub pull-request`
    Then the output should contain exactly "the://url\n"

75 76 77 78 79 80 81 82
  Scenario: Default message for single-commit pull request
    Given the text editor adds:
      """
      """
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        halt 400 if request.content_charset != 'utf-8'
83
        assert :title => 'This is somewhat of a longish title that does not get wrapped & references #1234',
84
               :body => nil
85
        status 201
86 87 88 89 90
        json :html_url => "the://url"
      }
      """
    Given I am on the "master" branch pushed to "origin/master"
    When I successfully run `git checkout --quiet -b topic`
91
    Given I make a commit with message "This is somewhat of a longish title that does not get wrapped & references #1234"
92 93 94 95
    And the "topic" branch is pushed to "origin/topic"
    When I successfully run `hub pull-request`
    Then the output should contain exactly "the://url\n"

96 97 98 99 100 101 102 103
  Scenario: Single-commit with pull request template
    Given the git commit editor is "true"
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        halt 400 if request.content_charset != 'utf-8'
        assert :title => 'Commit title',
               :body => <<BODY.chomp
104 105
Commit body

106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131
This is the pull request template

Another line of template
BODY
        status 201
        json :html_url => "the://url"
      }
      """
    Given I am on the "master" branch pushed to "origin/master"
    When I successfully run `git checkout --quiet -b topic`
    And I make a commit with message:
      """
      Commit title

      Commit body
      """
    And the "topic" branch is pushed to "origin/topic"
    Given a file named "pull_request_template.md" with:
      """
      This is the pull request template

      Another line of template
      """
    When I successfully run `hub pull-request`
    Then the output should contain exactly "the://url\n"

132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162
  Scenario: Message template should include git log summary between base and head
    Given the text editor adds:
      """
      Hello
      """
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        status 500
      }
      """
    Given I am on the "master" branch
    And I make a commit with message "One on master"
    And I make a commit with message "Two on master"
    And the "master" branch is pushed to "origin/master"
    Given I successfully run `git reset --hard HEAD~2`
    And I successfully run `git checkout --quiet -B topic origin/master`
    Given I make a commit with message "One on topic"
    And I make a commit with message "Two on topic"
    Given the "topic" branch is pushed to "origin/topic"
    And I successfully run `git reset --hard HEAD~1`
    When I run `hub pull-request`
    Given the SHAs and timestamps are normalized in ".git/PULLREQ_EDITMSG"
    Then the file ".git/PULLREQ_EDITMSG" should contain exactly:
      """
      Hello


# Requesting a pull to mislav:master from mislav:topic
#
# Write a message for this pull request. The first block
J
Justin Campbell 已提交
163
# of text is the title and the rest is the description.
164 165 166 167 168 169 170 171 172 173 174
#
# Changes:
#
# SHA1SHA (Hub, 0 seconds ago)
#    Two on topic
#
# SHA1SHA (Hub, 0 seconds ago)
#    One on topic

      """

175 176 177 178 179
  Scenario: Non-existing base
    Given the GitHub API server:
      """
      post('/repos/origin/coral/pulls') { 404 }
      """
180
    When I run `hub pull-request -b origin:master -m here`
181 182 183 184 185 186
    Then the exit status should be 1
    Then the stderr should contain:
      """
      Error creating pull request: Not Found (HTTP 404)
      Are you sure that github.com/origin/coral exists?
      """
187 188 189 190 191 192

  Scenario: Supplies User-Agent string to API calls
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        halt 400 unless request.user_agent.include?('Hub')
193
        status 201
194 195 196
        json :html_url => "the://url"
      }
      """
197
    When I successfully run `hub pull-request -m useragent`
198
    Then the output should contain exactly "the://url\n"
199 200

  Scenario: Text editor adds title and body
201
    Given the text editor adds:
202 203 204 205 206 207 208 209
      """
      This title comes from vim!

      This body as well.
      """
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
210 211
        assert :title => 'This title comes from vim!',
               :body  => 'This body as well.'
212
        status 201
213 214 215 216 217 218
        json :html_url => "https://github.com/mislav/coral/pull/12"
      }
      """
    When I successfully run `hub pull-request`
    Then the output should contain exactly "https://github.com/mislav/coral/pull/12\n"
    And the file ".git/PULLREQ_EDITMSG" should not exist
219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239

  Scenario: Text editor adds title and body with multiple lines
    Given the text editor adds:
      """


      This title is on the third line


      This body


      has multiple
      lines.

      """
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :title => 'This title is on the third line',
               :body  => "This body\n\n\nhas multiple\nlines."
240
        status 201
241 242 243 244 245 246
        json :html_url => "https://github.com/mislav/coral/pull/12"
      }
      """
    When I successfully run `hub pull-request`
    Then the output should contain exactly "https://github.com/mislav/coral/pull/12\n"
    And the file ".git/PULLREQ_EDITMSG" should not exist
247

248 249 250 251 252 253 254 255 256 257 258 259 260 261 262
  Scenario: Text editor with custom commentchar
    Given git "core.commentchar" is set to "/"
    And the text editor adds:
      """
      # Dat title

      / This line is commented out.

      Dem body.
      """
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :title => '# Dat title',
               :body  => 'Dem body.'
263
        status 201
264 265 266 267 268 269
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request`
    Then the output should contain exactly "the://url\n"

270
  Scenario: Failed pull request preserves previous message
271
    Given the text editor adds:
272 273 274 275 276 277 278
      """
      This title will fail
      """
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        halt 422 if params[:title].include?("fail")
279 280
        assert :body => "This title will fail",
               :title => "But this title will prevail"
281
        status 201
282 283 284 285 286 287 288
        json :html_url => "https://github.com/mislav/coral/pull/12"
      }
      """
    When I run `hub pull-request`
    Then the exit status should be 1
    And the stderr should contain exactly:
      """
289
      Error creating pull request: Unprocessable Entity (HTTP 422)\n
290 291 292 293 294 295 296 297 298
      """
    Given the text editor adds:
      """
      But this title will prevail
      """
    When I successfully run `hub pull-request`
    Then the file ".git/PULLREQ_EDITMSG" should not exist

  Scenario: Text editor fails
299
    Given the text editor exits with error status
300 301 302 303 304
    And an empty file named ".git/PULLREQ_EDITMSG"
    When I run `hub pull-request`
    Then the stderr should contain "error using text editor for pull request message"
    And the exit status should be 1
    And the file ".git/PULLREQ_EDITMSG" should not exist
305 306 307 308 309

  Scenario: Title and body from file
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
310 311
        assert :title => 'Title from file',
               :body  => "Body from file as well.\n\nMultiline, even!"
312
        status 201
313 314 315 316 317 318 319 320 321 322 323 324 325 326 327
        json :html_url => "https://github.com/mislav/coral/pull/12"
      }
      """
    And a file named "pullreq-msg" with:
      """
      Title from file

      Body from file as well.

      Multiline, even!
      """
    When I successfully run `hub pull-request -F pullreq-msg`
    Then the output should contain exactly "https://github.com/mislav/coral/pull/12\n"
    And the file ".git/PULLREQ_EDITMSG" should not exist

M
m_nakamura145 已提交
328 329 330 331
  Scenario: Edit title and body from file
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
332 333 334
        assert :title => 'Hello from editor',
               :body  => "Title from file\n\nBody from file as well."
        status 201
M
m_nakamura145 已提交
335 336 337 338 339 340 341 342 343
        json :html_url => "https://github.com/mislav/coral/pull/12"
      }
      """
    And a file named "pullreq-msg" with:
      """
      Title from file

      Body from file as well.
      """
344
    And the text editor adds:
M
m_nakamura145 已提交
345
      """
346
      Hello from editor
M
m_nakamura145 已提交
347
      """
348 349
    When I successfully run `hub pull-request -F pullreq-msg --edit`
    Then the file ".git/PULLREQ_EDITMSG" should not exist
M
m_nakamura145 已提交
350

351 352 353 354
  Scenario: Title and body from stdin
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
355
        assert :title => 'Unix piping is great',
356
               :body  => 'Just look at this ăéñøü'
357
        status 201
358 359 360 361 362 363 364 365
        json :html_url => "https://github.com/mislav/coral/pull/12"
      }
      """
    When I run `hub pull-request -F -` interactively
    And I pass in:
      """
      Unix piping is great

366
      Just look at this ăéñøü
367 368 369 370 371 372 373 374 375
      """
    Then the output should contain exactly "https://github.com/mislav/coral/pull/12\n"
    And the exit status should be 0
    And the file ".git/PULLREQ_EDITMSG" should not exist

  Scenario: Title and body from command-line argument
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
376 377
        assert :title => 'I am just a pull',
               :body  => 'A little pull'
378
        status 201
379 380 381 382 383 384
        json :html_url => "https://github.com/mislav/coral/pull/12"
      }
      """
    When I successfully run `hub pull-request -m "I am just a pull\n\nA little pull"`
    Then the output should contain exactly "https://github.com/mislav/coral/pull/12\n"
    And the file ".git/PULLREQ_EDITMSG" should not exist
385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400

  Scenario: Error when implicit head is the same as base
    Given I am on the "master" branch with upstream "origin/master"
    When I run `hub pull-request`
    Then the stderr should contain exactly:
      """
      Aborted: head branch is the same as base ("master")
      (use `-h <branch>` to specify an explicit pull request head)\n
      """

  Scenario: Explicit head
    Given I am on the "master" branch
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :head => 'mislav:feature'
401
        status 201
402 403 404 405 406 407 408 409 410 411 412 413
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -h feature -m message`
    Then the output should contain exactly "the://url\n"

  Scenario: Explicit head with owner
    Given I am on the "master" branch
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :head => 'mojombo:feature'
414
        status 201
415 416 417 418 419 420 421 422 423 424 425 426
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -h mojombo:feature -m message`
    Then the output should contain exactly "the://url\n"

  Scenario: Explicit base
    Given I am on the "feature" branch
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :base => 'develop'
427
        status 201
428 429 430 431 432 433
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -b develop -m message`
    Then the output should contain exactly "the://url\n"

434 435
  Scenario: Implicit base by detecting main branch
    Given the default branch for "origin" is "develop"
436
    And I make a commit
437 438 439 440 441
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :base => 'develop',
               :head => 'mislav:master'
442
        status 201
443 444 445 446 447 448
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m message`
    Then the output should contain exactly "the://url\n"

449 450 451 452 453 454
  Scenario: Explicit base with owner
    Given I am on the "master" branch
    Given the GitHub API server:
      """
      post('/repos/mojombo/coral/pulls') {
        assert :base => 'develop'
455
        status 201
456 457 458 459 460 461 462 463 464 465 466 467
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -b mojombo:develop -m message`
    Then the output should contain exactly "the://url\n"

  Scenario: Explicit base with owner and repo name
    Given I am on the "master" branch
    Given the GitHub API server:
      """
      post('/repos/mojombo/coralify/pulls') {
        assert :base => 'develop'
468
        status 201
469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -b mojombo/coralify:develop -m message`
    Then the output should contain exactly "the://url\n"

  Scenario: Error when there are unpushed commits
    Given I am on the "feature" branch with upstream "origin/feature"
    When I make 2 commits
    And I run `hub pull-request`
    Then the stderr should contain exactly:
      """
      Aborted: 2 commits are not yet pushed to origin/feature
      (use `-f` to force submit a pull request anyway)\n
      """

  Scenario: Ignore unpushed commits with `-f`
    Given I am on the "feature" branch with upstream "origin/feature"
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :head => 'mislav:feature'
491
        status 201
492 493 494 495 496 497 498 499 500 501 502
        json :html_url => "the://url"
      }
      """
    When I make 2 commits
    And I successfully run `hub pull-request -f -m message`
    Then the output should contain exactly "the://url\n"

  Scenario: Pull request fails on the server
    Given I am on the "feature" branch with upstream "origin/feature"
    Given the GitHub API server:
      """
503
      tries = 0
504
      post('/repos/mislav/coral/pulls') {
505 506 507 508 509 510 511 512 513 514 515 516
        tries += 1
        if tries == 1
          status 422
          json :message => 'Validation Failed',
               :errors => [{
                 :resource => 'PullRequest',
                 :code => 'invalid',
                 :field => 'head'
               }]
        else
          status 400
        end
517 518 519 520 521 522
      }
      """
    When I run `hub pull-request -m message`
    Then the stderr should contain exactly:
      """
      Error creating pull request: Unprocessable Entity (HTTP 422)
523
      Invalid value for "head"\n
524
      """
525
    And the exit status should be 1
526 527 528 529 530 531

  Scenario: Convert issue to pull request
    Given I am on the "feature" branch with upstream "origin/feature"
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
532
        assert :issue => 92
533
        status 201
534 535 536 537
        json :html_url => "https://github.com/mislav/coral/pull/92"
      }
      """
    When I successfully run `hub pull-request -i 92`
538 539 540 541 542
    Then the output should contain exactly:
      """
      https://github.com/mislav/coral/pull/92
      Warning: Issue to pull request conversion is deprecated and might not work in the future.\n
      """
543 544 545 546 547 548

  Scenario: Convert issue URL to pull request
    Given I am on the "feature" branch with upstream "origin/feature"
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
549
        assert :issue => 92
550
        status 201
551 552 553 554
        json :html_url => "https://github.com/mislav/coral/pull/92"
      }
      """
    When I successfully run `hub pull-request https://github.com/mislav/coral/issues/92`
555 556 557 558 559
    Then the output should contain exactly:
      """
      https://github.com/mislav/coral/pull/92
      Warning: Issue to pull request conversion is deprecated and might not work in the future.\n
      """
560 561 562 563 564 565 566

  Scenario: Enterprise host
    Given the "origin" remote has url "git@git.my.org:mislav/coral.git"
    And I am "mislav" on git.my.org with OAuth token "FITOKEN"
    And "git.my.org" is a whitelisted Enterprise host
    Given the GitHub API server:
      """
567 568 569
      post('/api/v3/repos/mislav/coral/pulls', :host_name => 'git.my.org') {
        assert :base => 'master',
               :head => 'mislav:master'
570
        status 201
571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m enterprisey`
    Then the output should contain exactly "the://url\n"

  Scenario: Enterprise remote witch matching branch but no tracking
    Given the "origin" remote has url "git@git.my.org:mislav/coral.git"
    And I am "mislav" on git.my.org with OAuth token "FITOKEN"
    And "git.my.org" is a whitelisted Enterprise host
    And I am on the "feature" branch pushed to "origin/feature"
    Given the GitHub API server:
      """
      post('/api/v3/repos/mislav/coral/pulls', :host_name => 'git.my.org') {
        assert :base => 'master',
               :head => 'mislav:feature'
587
        status 201
588 589 590 591 592
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m enterprisey`
    Then the output should contain exactly "the://url\n"
593 594 595 596 597 598 599 600 601 602 603

  Scenario: Create pull request from branch on the same remote
    Given the "origin" remote has url "git://github.com/github/coral.git"
    And the "mislav" remote has url "git://github.com/mislav/coral.git"
    And I am on the "feature" branch pushed to "origin/feature"
    Given the GitHub API server:
      """
      post('/repos/github/coral/pulls') {
        assert :base  => 'master',
               :head  => 'github:feature',
               :title => 'hereyougo'
604
        status 201
605 606 607 608 609
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m hereyougo`
    Then the output should contain exactly "the://url\n"
610 611 612 613 614 615 616 617 618 619 620

  Scenario: Create pull request from branch on the personal fork case sensitive
    Given the "origin" remote has url "git://github.com/github/coral.git"
    And the "doge" remote has url "git://github.com/Mislav/coral.git"
    And I am on the "feature" branch pushed to "doge/feature"
    Given the GitHub API server:
      """
      post('/repos/github/coral/pulls') {
        assert :base  => 'master',
               :head  => 'Mislav:feature',
               :title => 'hereyougo'
621
        status 201
622 623 624 625 626
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m hereyougo`
    Then the output should contain exactly "the://url\n"
627 628 629 630 631 632 633 634 635 636 637

  Scenario: Create pull request from branch on the personal fork
    Given the "origin" remote has url "git://github.com/github/coral.git"
    And the "doge" remote has url "git://github.com/mislav/coral.git"
    And I am on the "feature" branch pushed to "doge/feature"
    Given the GitHub API server:
      """
      post('/repos/github/coral/pulls') {
        assert :base  => 'master',
               :head  => 'mislav:feature',
               :title => 'hereyougo'
638
        status 201
639 640 641 642 643 644
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m hereyougo`
    Then the output should contain exactly "the://url\n"

645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662
  Scenario: Create pull request from branch on the personal fork, capitalized
    Given the "origin" remote has url "git://github.com/LightAlf/FirstRepo.git"
    And the "Kristinita" remote has url "git@github.com:Kristinita/FirstRepo.git"
    And I am on the "add-py3kwarn" branch pushed to "Kristinita/add-py3kwarn"
    And I am "Kristinita" on github.com with OAuth token "OTOKEN"
    Given the GitHub API server:
      """
      post('/repos/LightAlf/FirstRepo/pulls') {
        assert :base  => 'master',
               :head  => 'Kristinita:add-py3kwarn',
               :title => 'hereyougo'
        status 201
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m hereyougo`
    Then the output should contain exactly "the://url\n"

663 664 665 666 667 668 669 670 671
  Scenario: Create pull request to "upstream" remote
    Given the "upstream" remote has url "git://github.com/github/coral.git"
    And I am on the "master" branch pushed to "origin/master"
    Given the GitHub API server:
      """
      post('/repos/github/coral/pulls') {
        assert :base  => 'master',
               :head  => 'mislav:master',
               :title => 'hereyougo'
672
        status 201
673 674 675 676 677
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m hereyougo`
    Then the output should contain exactly "the://url\n"
678 679 680 681 682

  Scenario: Open pull request in web browser
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
683
        status 201
684 685 686 687 688
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -o -m hereyougo`
    Then "open the://url" should be run
689 690 691

  Scenario: Current branch is tracking local branch
    Given git "push.default" is set to "upstream"
692
    And I make a commit
693 694 695 696 697 698
    And I am on the "feature" branch with upstream "refs/heads/master"
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :base  => 'master',
               :head  => 'mislav:feature'
699
        status 201
700 701 702 703 704
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m hereyougo`
    Then the output should contain exactly "the://url\n"
J
Jingwen Owen Ou 已提交
705 706 707 708

  Scenario: Branch with quotation mark in name
    Given I am on the "feat'ure" branch with upstream "origin/feat'ure"
    Given the GitHub API server:
709 710 711
      """
      post('/repos/mislav/coral/pulls') {
        assert :head  => "mislav:feat'ure"
712
        status 201
713 714 715
        json :html_url => "the://url"
      }
      """
J
Jingwen Owen Ou 已提交
716 717
    When I successfully run `hub pull-request -m hereyougo`
    Then the output should contain exactly "the://url\n"
M
Marko Mikulicic 已提交
718

719
  Scenario: Pull request with assignees
M
Marko Mikulicic 已提交
720 721 722 723 724
    Given I am on the "feature" branch with upstream "origin/feature"
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :head  => "mislav:feature"
725
        status 201
M
Marko Mikulicic 已提交
726 727 728
        json :html_url => "the://url", :number => 1234
      }
      patch('/repos/mislav/coral/issues/1234') {
729
        assert :assignees => ["mislav", "josh", "pcorpet"], :labels => :no
M
Marko Mikulicic 已提交
730 731 732
        json :html_url => "the://url"
      }
      """
733
    When I successfully run `hub pull-request -m hereyougo -a mislav,josh -apcorpet`
M
Marko Mikulicic 已提交
734
    Then the output should contain exactly "the://url\n"
735

736 737 738 739 740 741 742 743 744 745
  Scenario: Pull request with reviewers
    Given I am on the "feature" branch with upstream "origin/feature"
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :head  => "mislav:feature"
        status 201
        json :html_url => "the://url", :number => 1234
      }
      post('/repos/mislav/coral/pulls/1234/requested_reviewers') {
746
        halt 415 unless request.accept?('application/vnd.github.thor-preview+json')
747
        assert :reviewers => ["mislav", "josh", "pcorpet"]
748
        assert :team_reviewers => ["robots", "js"]
749
        status 201
750 751 752
        json :html_url => "the://url"
      }
      """
753
    When I successfully run `hub pull-request -m hereyougo -r mislav,josh -rgithub/robots -rpcorpet -r github/js`
754 755
    Then the output should contain exactly "the://url\n"

756 757 758 759 760 761
  Scenario: Pull request with milestone
    Given I am on the "feature" branch with upstream "origin/feature"
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :head  => "mislav:feature"
762
        status 201
763 764 765 766 767 768 769 770 771 772 773
        json :html_url => "the://url", :number => 1234
      }
      patch('/repos/mislav/coral/issues/1234') {
        assert :milestone => 1234
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m hereyougo -M 1234`
    Then the output should contain exactly "the://url\n"

  Scenario: Pull request with labels
M
Marko Mikulicic 已提交
774 775 776 777 778
    Given I am on the "feature" branch with upstream "origin/feature"
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        assert :head  => "mislav:feature"
779
        status 201
M
Marko Mikulicic 已提交
780 781 782
        json :html_url => "the://url", :number => 1234
      }
      patch('/repos/mislav/coral/issues/1234') {
783
        assert :labels => ["feature", "release", "docs"], :assignees => :no
784 785 786
        json :html_url => "the://url"
      }
      """
787
    When I successfully run `hub pull-request -m hereyougo -l feature,release -ldocs`
788
    Then the output should contain exactly "the://url\n"
789 790 791 792 793 794 795 796 797 798 799

  Scenario: Pull request to a fetch-only upstream
    Given the "upstream" remote has url "git://github.com/github/coral.git"
    And the "upstream" remote has push url "no_push"
    And I am on the "master" branch pushed to "origin/master"
    Given the GitHub API server:
      """
      post('/repos/github/coral/pulls') {
        assert :base  => 'master',
               :head  => 'mislav:master',
               :title => 'hereyougo'
800
        status 201
M
Marko Mikulicic 已提交
801 802 803
        json :html_url => "the://url"
      }
      """
804
    When I successfully run `hub pull-request -m hereyougo`
M
Marko Mikulicic 已提交
805
    Then the output should contain exactly "the://url\n"
806 807 808 809 810 811

  Scenario: Pull request with redirect
    Given the "origin" remote has url "https://github.com/mislav/coral.git"
    And I am on the "feature" branch pushed to "origin/feature"
    Given the GitHub API server:
      """
812 813 814 815 816 817
      get('/repos/mislav/coral') {
        redirect 'https://api.github.com/repositories/12345', 301
      }
      get('/repositories/12345') {
        json :name => 'coralify', :owner => { :login => 'coral-org' }
      }
818 819 820 821 822
      post('/repos/mislav/coral/pulls') {
        redirect 'https://api.github.com/repositories/12345', 307
      }
      post('/repositories/12345', :host_name => 'api.github.com') {
        assert :base  => 'master',
823
               :head  => 'coral-org:feature',
824
               :title => 'hereyougo'
825
        status 201
826 827 828 829 830 831
        json :html_url => "the://url"
      }
      """
    When I successfully run `hub pull-request -m hereyougo`
    Then the output should contain exactly "the://url\n"

832
  Scenario: Default message with --push
N
Natalie Weizenbaum 已提交
833
    Given the git commit editor is "true"
834 835 836
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
M
Mislav Marohnić 已提交
837
        assert :title => 'The commit I never pushed',
838 839 840 841 842 843 844
               :body => nil
        status 201
        json :html_url => "the://url"
      }
      """
    Given I am on the "master" branch pushed to "origin/master"
    When I successfully run `git checkout --quiet -b topic`
M
Mislav Marohnić 已提交
845
    Given I make a commit with message "The commit I never pushed"
846 847
    When I successfully run `hub pull-request -p`
    Then the output should contain exactly "the://url\n"
848
    And "git push --set-upstream origin HEAD:topic" should be run
849 850 851 852 853 854

  Scenario: Text editor fails with --push
    Given the text editor exits with error status
    And I am on the "master" branch pushed to "origin/master"
    And an empty file named ".git/PULLREQ_EDITMSG"
    When I successfully run `git checkout --quiet -b topic`
N
Natalie Weizenbaum 已提交
855
    Given I make a commit
856 857 858 859
    When I run `hub pull-request -p`
    Then the stderr should contain "error using text editor for pull request message"
    And the exit status should be 1
    And the file ".git/PULLREQ_EDITMSG" should not exist
860
    And "git push --set-upstream origin HEAD:topic" should not be run
861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897

  Scenario: Automatically retry when --push resulted in 422
    Given The default aruba timeout is 7 seconds
    And the text editor adds:
      """
      hello!
      """
    Given the GitHub API server:
      """
      first_try_at = nil
      tries = 0

      post('/repos/mislav/coral/pulls') {
        tries += 1
        assert :title => 'hello!', :head => 'mislav:topic'

        if !first_try_at || (Time.now - first_try_at) < 5
          first_try_at ||= Time.now
          status 422
          json :message => 'Validation Failed',
               :errors => [{
                 :resource => 'PullRequest',
                 :code => 'invalid',
                 :field => 'head'
               }]
        else
          status 201
          json :html_url => "the://url?tries=#{tries}"
        end
      }
      """
    Given I am on the "topic" branch
    When I successfully run `hub pull-request -p`
    Then the output should contain exactly "the://url?tries=3\n"
    And the file ".git/PULLREQ_EDITMSG" should not exist

  Scenario: Eventually give up on retries for --push
M
Mislav Marohnić 已提交
898
    Given The default aruba timeout is 7 seconds
899 900 901 902
    And the text editor adds:
      """
      hello!
      """
M
Mislav Marohnić 已提交
903
    And $HUB_RETRY_TIMEOUT is "5"
904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922
    Given the GitHub API server:
      """
      post('/repos/mislav/coral/pulls') {
        status 422
        json :message => 'Validation Failed',
             :errors => [{
               :resource => 'PullRequest',
               :code => 'invalid',
               :field => 'head'
             }]
      }
      """
    Given I am on the "topic" branch
    When I run `hub pull-request -p`
    Then the stderr should contain:
      """
      Error creating pull request: Unprocessable Entity (HTTP 422)
      Invalid value for "head"\n
      """
M
Mislav Marohnić 已提交
923
    And the output should match /Given up after retrying for 5\.\d seconds\./
924
    And a file named ".git/PULLREQ_EDITMSG" should exist