Exit with error if command-line flag parsing fails

commands/commands.go

@@ -3,8 +3,9 @@ package commands
 import (
 	"bytes"
 	"fmt"
-	flag "github.com/ogier/pflag"
 	"strings"
+
+	flag "github.com/ogier/pflag"
 )
 
 var (
@@ -49,11 +50,8 @@ func (c *Command) Call(args *Args) (err error) {
 
 func (c *Command) parseArguments(args *Args) (err error) {
 	c.Flag.SetInterspersed(true)
-
-	if !c.GitExtension {
-		c.Flag.Usage = c.PrintUsage
-	}
-
+	c.Flag.Init(c.Name(), flag.ContinueOnError)
+	c.Flag.Usage = c.PrintUsage
 	if err = c.Flag.Parse(args.Params); err == nil {
 		args.Params = c.Flag.Args()
 	}

features/pull_request.feature

@@ -43,9 +43,9 @@ Feature: hub pull-request
     When I successfully run `hub pull-request -m ăéñøü`
     Then the output should contain exactly "the://url\n"
 
-  Scenario: Deprecated title argument can't start with a dash
-    When I run `hub pull-request -help`
-    Then the stderr should contain "invalid argument: -help\n"
+  Scenario: Invalid flag
+    When I run `hub pull-request -yelp`
+    Then the stderr should contain "unknown shorthand flag: 'y' in -yelp\n"
     And the exit status should be 1
 
   Scenario: Non-existing base