- 27 3月, 2022 2 次提交
-
-
由 Egor Bogatov 提交于
-
由 Theodore Tsirpanis 提交于
-
- 26 3月, 2022 21 次提交
-
-
由 Tomáš Rylek 提交于
I originally hit this bug when testing my Crossgen2 perf optimization change involving only registering composite code range once but I managed to disprove the bug was caused by this change. Indeed, it was caused by my earlier change improving component assembly caching. In my overzealous attempt to make sure the assembly gets always registered I added a new method NativeImage::AddComponentAssemblyToCache that registered the assembly which had triggered the native image load in the first place. This was incorrect, by that point the assembly wasn't yet fully initialized and putting it in the cache made it visible to other threads that subsequently crashed trying to access the assembly before it was fully loaded. Furthermore it was unnecessary, once the assembly gets loaded, it gets stored in the cache via the call to SetNativeMetadataAssemblyRefInCache from ZapSig::DecodeModuleFromIndex. Before the fix I was able to repro the bug locally typically after about 500 iterations of the thread14 unit test, with the fix I was unable to repro after 4500 iterations. Thanks Tomas Fixes: https://github.com/dotnet/runtime/issues/66954 Probably also fixes: https://github.com/dotnet/runtime/issues/66210
-
由 Noah Falk 提交于
Fixes #66715 We are seeing exceptions thrown at shutdown turn into hangs because the debugger lock suspends threads at that point. We are mitigating that problem by disabling the jit attach setup work and allowing WatsonLastChance to continue.
-
由 Maryam Ariyan 提交于
- alongside LoggerMessageAttribute Fixes #67167
-
由 Kevin Jones 提交于
-
由 Eirik Tsarpalis 提交于
* Refactor HandleCollectionsAsync to a Theory * add small buffer testing in StreamTests * redisable test for mono/wasm platforms
-
由 Elinor Fung 提交于
-
由 Jeremy Koritzinsky 提交于
Co-authored-by: NElinor Fung <elfung@microsoft.com>
-
由 Andy Gocke 提交于
16.04 and 18.04 are out of support, but we always support the latest Ubuntu LTS
-
由 Tomas Weinfurt 提交于
* TLS resume on client * shim functions introduced in 1.1.1 * add missing struct * disable resume on old OpenSSL * feedback from review * fix source build * update comment * feedback from review * feedback from review * avoild client resume on old OpenSSL
-
由 Ankit Jain 提交于
Some library tests fail to AOT on helix by getting oomkill'ed. Since the build machine have more resources than helix, we can AOT these specific library tests there, and send the built output to helix to run. Specifically: - `System.Text.Json.SourceGeneration.Roslyn3.11.Tests` - `System.Text.Json.SourceGeneration.Roslyn4.0.Tests` - `System.Text.Json.Tests` - `Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests` This adds two new jobs to `runtime-wasm`, and for rolling builds - `LibraryTests_HighResource_AOT` for linux, and windows. Fixes #65356 Fixes #65411 Fixes #61524 Fixes #66647
-
由 Stephen Toub 提交于
No parameters is very common. Avoid a `new Type[0]` array in such cases.
-
由 Stephen Toub 提交于
- It's commonly used with zero args; we can use Type.EmptyTypes rather than new Type[0] - It calls GetConstructors, which internally uses ListBuilder and then resizes if the created array isn't filled, but since we don't need the correctly sized array, we can just use the ListBuilder and avoid the resize - It creates a List and then ToArray's it, but if none of the constructors are filtered out, it's better to just use the array we built up directly.
-
由 Ankit Jain 提交于
job.yml uses name instead of displayName to set the job's name. But perf jobs don't set that. Without this, pre-defined variables like System.PhaseName get value Job1. This will help with differentiating builds in kusto.
-
由 Maksym Koshovyi 提交于
-
由 Nikola Milosavljevic 提交于
* Infra for regeneration of third-party-notices file * Update eng/regenerate-third-party-notices.proj Co-authored-by: NDavis Goodin <dagood@users.noreply.github.com> * Addressing PR comments * Updated copyright in all .cs files * Update dotnet/liner repo name * Add dotnet/emsdk to the list Co-authored-by: NDavis Goodin <dagood@users.noreply.github.com>
-
由 Tomáš Rylek 提交于
This is a somewhat annoying aspect hitting less than 10% of the JIT/Methodical subtree: as the new merged wrapper logic is based on simple assembly names, we cannot merge multiple test projects that produce a test assembly with the same name otherwise such assemblies stomp over each other when getting copied to the merged wrapper folder. I have added a new option to ILTransform to include the directory name in the project names in these cases. We can remove some of this in the future when selectively merging actual test source code (compiling multiple tests into a single asssembly). Thanks Tomas
-
由 Adeel Mujahid 提交于
* Delete unused native code in src/native * Delete set_* functions from version types
-
由 Larry Ewing 提交于
This reverts commit 4e7ccfa1.
-
由 Larry Ewing 提交于
* Add wasm workload for win-arm64 using emulation * Add aliases for win-arm64 to all the win-x64 cases as well (android, ios)
-
由 Ankit Jain 提交于
This ensures that the the benchmarks project is always built with the same dotnet, avoid corrupted builds.
-
由 Eirik Tsarpalis 提交于
* Fix error reporting for objects with unsupported property types * refactor dictionary tests to use xunit theories * lift test class to abstracted test harness
-
- 25 3月, 2022 17 次提交
-
-
由 Andy Ayers 提交于
This undoes part of #65903. OSR methods can't rely solely on their own analysis for struct promotion as they only see parts of methods.
-
由 Michal Strehovský 提交于
* Disable multimodule test Can't use issues.targets because this is a compile failure and compilation runs during test build, not execution. * Update MultiModule.csproj
-
由 Michal Strehovský 提交于
I was trying to repro #66191 and assumed determinism is the root cause. I used `CoreRT_DeterminismSeed` to perturb the dependency node evaluation and it found differences. Now, I don't think the differences really matter. We already seem to be deterministic in the multithreaded compilation (the outputs are always the same no matter how many times I try). `CoreRT_DeterminismSeed` perturbs the order in which node dependencies are evaluated and that exposes more ordering issues than we practically have. In normal multithreaded compilation we grab nodes in different order from the `NodeFactory` as part of method compilation, but the order in which those nodes are evaluated is still fixed. This means the nodes we grabbed are still getting marked in a deterministic order and we get stable ordering even without an explicit sort in this spot. But maybe as part of https://github.com/dotnet/runtimelab/issues/1631 we should enable `CoreRT_Determinism` in our testing and for that we need this extra sorting.
-
由 Maksym Koshovyi 提交于
Related to #43605
-
由 Stephen Toub 提交于
When we emit a bitmap lookup for character classes containing only ASCII characters, we currently bound the check by 128, e.g. ```C# if (ch < 128 && lookupTable[...]) ``` but we can easily lower that 128 to instead be the actual exclusive upper bound based on the char set. Doing so means we don't need to hit the lookup table for a larger set of characters. (We could also actually shrink the size of the lookup table itself, but doing so would only save a few bytes, and it didn't seem worth the complexity right now. We could also add a lower range check, but that's also additional checks to execute whereas this one is just improving an existing check that's also required for correctness.)
-
由 Marek Safar 提交于
-
由 Radek Zikmund 提交于
-
由 Zoltan Varga 提交于
-
由 Kunal Pathak 提交于
-
由 Stephen Toub 提交于
The XML deserializer tracks for each property whether it's already been seen in the input being deserialized, and to do that the reader allocates a bool[] array. We can instead stackalloc that for a reasonable number of properties.
-
由 Dan Moseley 提交于
-
由 Radek Zikmund 提交于
This works around ABI breaking change made between OpenSSL 1.1 and 3.0 where argument type and return type was changed from unsigned long to uint64_t, which caused issues on arm32 architectures with OpenSSL 3.0 installed. Co-authored-by: NJeremy Barton <jbarton@microsoft.com> Co-authored-by: NTomas Weinfurt <tweinfurt@yahoo.com>
-
由 Elinor Fung 提交于
-
由 Kevin Jones 提交于
Historically, the asymmetric algorithm base classes have had the hashing routines as abstract (or virtual+throw). Now the base classes provide an implementation for these methods, reducing the amount of redundant effort on the part of derived types.
-
由 Dan Roberts 提交于
-
由 Steve Pfister 提交于
The crypto test suites were originally disabled as they would run out of memory on both emulators and devices somewhat frequently. This change enables them again, with the difference being that xunit will run tests on a single thread. Addresses #62547
-
由 Miha Zupan 提交于
* Avoid issuing connection attempts for already canceled requests * Cancelled => Canceled * Guard SocketsHttpHandler tests under SocketsHttpHandler.IsSupported
-