* Making ILVersionInfo a struct

* Fixing tests

* spacing for commas and colons

* code review

* cleanup semicolons (ugh)

* fix build

* a little more cleanup

* little bit more cleanup

* little bit more cleanup

* little bit more documentation

* little bit more docs

* whitespace cleanup and docs

* more whitespace and code formatting

* little bit more docs

* add diagnostics

* add diagnostics

* add diagnostics

* diagnostics

* diagnostics

* diagnostics

* add diagnostics and possible fix for tp smoke tests

* fix build

* fix build

* Replace hats

* Add spaces

* Microsoft.FSharp.Comiler --> FSharp.Compiler

* Microsoft.FSharp.Build --> FSharp.Build

* fix small mistakes

* fix build

* fix flakey test (?)

* reduce memory allocations

* remove memory allocations

* Add decoded ILAttribute representation

* Remove ILAttribute.Data

* Add docs

* Use ordinal string comparison in string manipulation methods

StartsWith, EndsWith, Compare, etc

* Add StartsWithOrdinal, EndsWithOrdinal extension methods

* typ --> ty

* typ --> ty

* typ --> ty

* comments

* comments

* Update ConstraintSolver.fs

* Update README.md

* Update README.md

* Update README.md

* [RFCs FS-1051, FS-1052, FS-1053] support for span, readonly refs, byref-like structs (#4888)

* initial support for span, readonly refs, byref-like structs

* fix proto build

* make proto work with previous FSharp.Core

* make proto work with previous FSharp.Core

* update baselines

* integrate code cleanup

* integrate code cleanup

* integrate code cleanup

* integrate code cleanup

* fix build

* fix build

* implicit deref of byref returns

* add tests for Memory, ReadOnlySpan and ReadOnlyMemory

* fix tests

* simplify diff

* simplify diff

* remove duplicate error messages

* fix build

* test updates

* fix build

* fix build

* update baselines

* fix uses of NativePtr.toByRef

* switch to inference using byref pointer capabilities

* fix proto build

* update baselines, byref extension methods

* fix test errors

* emit in,out,modreq attributes correctly

* update tests

* fix build

* fix build

* fix tests

* fix tests

* get it right silly boy

* fix test

* minor cleanup

* add more tests

* clarify overloading behaviour + test case

* fix build break

* fix build of tests

* update tests

* add more tests

* byref fixes

* updates for subsumption calls, error message, assign-to-return-byref

* test updates, implicit deref on byref return for normal functions

* update baseline

* improve debug formatting, better error message on implicit deref, improve error messages

* add more tests for recursive functions

* update baselines

* fix baselines

* updates for new test cases

* updates for new test cases

* test updates and byref-to-byreflike

* deal with 'M() <- expr'

* restrict addresses of immutable top-level things

* fix IsByRefLike on struct

* update tests

* fix test

* fix test

* improve check for no-return-of-struct-field-addresses

* fix test case

* Provide fast generic comparer for bool values (#5076)

* provide fast generic comparer for bool values

* formatting

* no completion on name of value and function declaration (#5083)

* LOC CHECKIN | Microsoft/visualfsharp master | 20180604 | Termchange (#5082)

* fix merge

* initial support for span, readonly refs, byref-like structs

* fix proto build

* make proto work with previous FSharp.Core

* make proto work with previous FSharp.Core

* update baselines

* integrate code cleanup

* integrate code cleanup

* integrate code cleanup

* integrate code cleanup

* fix build

* fix build

* implicit deref of byref returns

* add tests for Memory, ReadOnlySpan and ReadOnlyMemory

* fix tests

* simplify diff

* simplify diff

* remove duplicate error messages

* fix build

* test updates

* fix build

* fix build

* update baselines

* fix uses of NativePtr.toByRef

* switch to inference using byref pointer capabilities

* fix proto build

* update baselines, byref extension methods

* fix test errors

* emit in,out,modreq attributes correctly

* update tests

* fix build

* fix build

* fix tests

* fix tests

* get it right silly boy

* fix test

* minor cleanup

* add more tests

* clarify overloading behaviour + test case

* fix build break

* fix build of tests

* update tests

* add more tests

* byref fixes

* updates for subsumption calls, error message, assign-to-return-byref

* test updates, implicit deref on byref return for normal functions

* update baseline

* improve debug formatting, better error message on implicit deref, improve error messages

* add more tests for recursive functions

* update baselines

* fix baselines

* updates for new test cases

* updates for new test cases

* test updates and byref-to-byreflike

* deal with 'M() <- expr'

* restrict addresses of immutable top-level things

* fix IsByRefLike on struct

* update tests

* fix test

* fix test

* improve check for no-return-of-struct-field-addresses

* fix test case

Thanks for this.

* Read/store ILCustomAttrs, ILSecurityDecls, ILTypeDef sensibly (#4597)

* hide representation of ILPreTypeDef

* fix build

* remove unnecessary use of lists with repeated tail-appends

* add comment

* fix test

* weak ByteFile

* cleanup, only use in VS

* cleanup flags

* some comments

* some comments

* use Roslyn memory manager for metadata in VS

* report statistics only with --times, clarify flags2

* minor updates

* us in VS

* fix build

* fix build

* fix build

* add SFH to FileSystem

* fix build

* fix build

* fix build

* fix build

* add some comments

* reduce ILEventDef ILPropertyDef and ILFieldDef memory

* Update IlxGen.fs

* reduce ILMethodDef memory

* reduce ILTypeDef memory

* clean redundant functions

* make tuples support Item* with warning

* add deactivated tests for struct tuple

* proper return types for Rest, prototype ctors

* fix SRTP

* fix tests

* fix tests

* add more protection

* improve code for decompiling types

* fix unit tests

* don't rebuild

* make infos systematic to reduce use of tcrefOfAppTy

* update test cases

* fix build

* update test cases

* bump FCS version consistently

* use consistent names

* code review

* Generate source for .resx files on build. (#3607)

* add build task to generate *.fs from *.resx files

* generate source for embedded resources in tests

* generate source for embedded resources in FSharp.Editor

* generate source for embedded resources in FSharp.LanguageService

* generate source for embedded resources in FSharp.ProjectSystem.FSharp

* generate source for embedded resources in FSharp.VS.FSI

* don't generate non-string resources when <=netstandard1.6

* update baseline error message for tests

The error output should be the exception message, not the exception type.

* perform up-to-date check before generating *.fs from *.resx

* remove non-idiomatic fold for an array comprehension

* correct newline replacement

* output more friendly error message

* throw if boolean value isn't explicitly `true` or `false`

* only generate object resource code on non `netstandard1.*` and `netcoreapp1.*` platforms

* ensure FSharp.Core specifies a target framework for resource generaton

* rename attributes to be non-ambiguous and properly include them

* fix order of file items in FSharp.Core

* Fix build.cmd for certain always-shown errors (like "unable to find registry key"), improve finding of VS2017 tools, fix DEVGUIDE.md (#3635)

* Fix build.com displaying the following error on each run "ERROR: The system was unable to find the specified registry key or value."

* Remove warning about reg.exe errors introduced in #3614 (in commit b548bd7, but unrelated to that fix), it is no longer necessary.

* Fix #3638, VS2017 Preview installation was not found when VS2017RTM is not installed. Remove comment introduced in #3614 (through commit 966bd7f7)

* Fixing JaroWinkler tests with InvariantCulture and fixing async tests by removing Debugger.Break() (#3627)

* Fixing JaroWinkler tests to use InvariantCulture for number-to-string

* Fixing the crashing of test runners because of a Debugger.Break() in a test

* update to System.Collections.Immutable 1.3.1 (#3641)

* update to System.Collections.Immutable 1.3.1

* fixes

* fix assembly reference

* [WIP] Adds optimized emit for int64 constants (#3620)

* Adds optimized emit for int64 constants.

* Adds comment linking to the changing PR.

Thanks for this PR.

Kevin

* fix assembly reference (#3646)

* Remove a few more build warnings (#3647)

* fix assembly reference

* remove more build warnings

* fix build

* move BuildFromSource projects to their own directory

* Adds tests for emitted IL for new Int64 constants. (#3650)

* Enable FS as prefix and ignore invalid values for warnings (#3631)

* enable fs as prefix and ignore invalid values for warnings + tests

* Allow #pragma to validate warnings

* do it right

* use ordinal compare

* In both places

* Add fs prefix to warnaserror

* Fixup tests

* Fix stack overflow on assembly resolution (#3658)

* Fix stack overflow on tp assembly resolution

* Feedback

* Add impl files to file check results (#3659)

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project

* add ImplementationFiles to FSharpCheckFileResults

* make FSharpImplementationFileContents ctor internal

* throw if ImplementationFiles is called having keepAssemblyContents flag set to false

* add a test

* spelling and cosmetics

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd (#3672)

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* Remove ambiguous an irrelevant instruction, improved help and instructions

* Fix a scenario where the return code wasn't nonzero for error conditions, fixes not creating backup dir when not backing up

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project (#3657)

* bump FCS version (#3676)

* bump version

* Update RELEASE_NOTES.md

* Parsing improvements: no reactor, add parsing options, error severity options (#3601)

* Parse without reactor, add parsing options, error severity options

* Revert parsing APIs (fallback to the new ones), fix VFT projects

* Cache parse results after type check

* Add impl files to file check results (#3659)

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project

* add ImplementationFiles to FSharpCheckFileResults

* make FSharpImplementationFileContents ctor internal

* throw if ImplementationFiles is called having keepAssemblyContents flag set to false

* add a test

* spelling and cosmetics

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd (#3672)

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* Remove ambiguous an irrelevant instruction, improved help and instructions

* Fix a scenario where the return code wasn't nonzero for error conditions, fixes not creating backup dir when not backing up

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project (#3657)

* bump FCS version (#3676)

* bump version

* Update RELEASE_NOTES.md

* updates to make tests pass

* restore old behaviour of CheckFileInProjectAllowingStaleCachedResults (builder had been created by ParseFileInProject)

* restore use of CheckFileInProjectAllowingStaleCachedResults

* deprecate test relying on whacky behaviour of deprecated GetCheckResultsBeforeFileInProjectEvenIfStale

* Use ParseFile and FSharpParsingOptions instead of ParseFileInProject

* prepare FCS release with this feature

* whitespace cleanup (#3682)

* whitespace and docs (#3684)

* Preserve XML docs for in-memory project references (#3683)

* fix xmldocs for in-memory project references

* add test

* fix tests

* whitespace and comments (#3686)

* fix assembly reference

* whitespace and comments

* whitespace and comments

* whitespace and comments

* cherry pick two PRs from FCS (#3687)

* fix assembly reference

* remove line endings from all *.nuspec files

* ProjectCracker returns *.fsi files in FSharpProjectOptions.SourceFiles array (in addition to *.fs files, in right order)

* ProjectCracker raises exception if ProjectCrackerTool returns non null ProjectCrackerOptions.Error (new field)

* fix build on linux

* fix a test

* slashes

* revert slashes

* Update FSharp.Compiler.Service.ProjectCracker.nuspec

* try to fix travis

* try to fix travis

* list dependencies

* no obsolete pdb in nuget

* list dependencies

* cherry pick of fsharp/fsharp change

* bump FCS version number (#3688)

* Update FSharp.Compiler.Service.MSBuild.v12.nuspec

* fix FCS nuget on windows

* fix-resource (#3690)

* Bump FSharp.Compiler.Tools to 4.1.27 and align mono build files (#3693)

* ri change from fsharp

* fix test

* bump FSC tools to 4.1.27

* remove fsharp.core from Mono GAC

* align mono directory

* fix typo

* install back versions with Mono

* fix typo

* update FCS doc generation (#3694)

* update DEVGUIDE to add addiitional steps before running build (#3725)

* Split templates out into a seperate vsix (#3720)

* merge error

* Merge issues

* fix assembly reference

* whitespace and comments

* whitespace and comments

* whitespace and comments

* Implement `MethodImplOptions.AggressiveInlining` flag - fixes #1637

* More inlining

* remove change to TAST

* fix build

* add test

* Don't call length if not needed

* Use hasLengthGreaterThen

* Use isNilOrSingleton

* Use isNilOrSingleton

* no double negations are not bad

* fix resolution to always prefer unification once an assembly has been referenced

* improve diagnostics

* fix proto

* fix unintended change

* fix 2871

* fix 2871

* fix 2871 (2)

* clarify code

* reverse integrate some changes from fsharp\fsharp

* reverse integrate some changes from fsharp\fsharp

* Spelling typos (of Comments in src/*.fs{i} files)

* Typo (illib.fs)

Mono changed

Looks like the problem is due to this commit to
Mono https://github.com/mono/mono/commit/efd53c8e2f1823568309a2920091b724be0feff8
Mono's internal System.Reflection.Emit.MonoGenericClass was renamed
to System.Reflection.Emit.TypeBuilderInstantiation

That broke the workaround in https://github.com/fsharp/fsharp/blob/5a942daf930d7023c78f578ec6876b86a6f13f1e/src/absil/ilreflect.fs#L619-L623 .

* Add a test to reproduce the issue

* proposed fix for #2411

* do not try to check non nominal argument types

* move local functions out (temporarily)

* try other fsimode???

* * try to move back local functions, adding type annotation might help with proto compiler
* disable test through pipe, no clue why it fails in fsharqa, works locally

* fix naming for policheck

* in queryableTypeGetMethodBySearch, do not map parameter types if the expected length is not matching

* tame concurrency draft

* tame-conc

* fix tests

* fix build

* This is tiny optimization and code cleaning around empty list checks

* inline function AbstractIL.IL.isNil used to call to List.isEmpty, replace it with property access list.Length
* harmonize empty list comparison `list.Length = 0` across the code (only in places which had AbstractIL.IL open already) to always use isNil

* Update illib.fs

fix back isNil, this PR still fix consistency over `list.Length = 0` which is lot less efficient than `List.isEmpty`

The compiler has some logic to search for known types amongst available DLLs.

With this PR we get to enable several tests that uses F# Interactive on .NET Core and more tests for the F# compiler on .NET Core

Some of the known-type-search logic is OK, but swathes of it are not so good, e.g. this stuff

This improves the search by

just having one function to do the search

moving many "known types" out of Abstract IL (ILGlobals) and into the F# Compiler TcGlobals. THe advantages of this is that getting started with ILGlobals is much simpler if the set of referenced types is simpler - in particular if the small set of types known to Abstract IL are all always in the primary assembly (Int32, String, Array etc.).

This is particularly important for .NET Core. I don't trust the current code to correctly find some of the more obscure types for .NET Core, since the searching was based around various assumptions for Profile 7, 78, 259.

Overall this removes a fair chunk of fragile code from the compiler.

Separately this refactors TcGlobals to be a class instead of a record (which requires fewer lines of code)