Scope of types for named values in attributes improperly set as assembly where attribute is defined

fixes https://github.com/Microsoft/visualfsharp/issues/82
closes https://github.com/Microsoft/visualfsharp/pull/568

commit a7e74c8cba301d39bb5b1d07f448dc4bcef88967
Author: latkin <latkin@microsoft.com>
Date:   Thu Aug 13 16:55:32 2015 -0700

    Add tests

commit 6c6cb0e0ebae07c1e55847e2ddbab72bdcffef54
Merge: d2a25c8 01dc5083
Author: Don Syme <donsyme@fastmail.fm>
Date:   Tue Aug 4 20:05:22 2015 +0100

    update

commit d2a25c8db9c55d1ee0bd78c140355ccaa9130fee
Author: Don Syme <donsyme@fastmail.fm>
Date:   Mon May 11 12:44:15 2015 +0100

    updates to fix (3)

commit 1097c068a457585c1e303e788d6bbb792a71e32d
Author: Don Syme <donsyme@fastmail.fm>
Date:   Mon May 11 12:42:43 2015 +0100

    updates to fix (2)

commit 27c926891d1671edc6c174ee676eece370cbdc78
Author: Don Syme <donsyme@fastmail.fm>
Date:   Mon May 11 12:40:47 2015 +0100

    updates to fix

commit fb3a470b9ec90bc81f4c2289d0c0c7a6c7e3cebe
Author: Don Syme <donsyme@fastmail.fm>
Date:   Mon May 11 12:36:13 2015 +0100

    fix for 82

This is a pass of cleanup that renames some files to get rid of most cryptic abbreviations like "csolve", and does some other code cleanup and documentation too.

  - commenting in "detuple.fs"
  - removing ExtensibleDumper.fs which is an old adhoc debug mechanism barely used in the codebase
  - removing some dead code in fsc.fs (some code was already duplicated in fscmain.fs too!)
  - renaming check.{fs,fsi} --> PostInferenceChecks.{fs,fsi}
  - renaming tc.{fs,fsi} --> TypeChecker.{fs,fsi}
  - renaming opt.{fs,fsi} --> Optimizer.{fs,fsi}
  - renaming est.{fs,fsi} --> ExtensionTyping.{fs,fsi}
  - renaming build.{fs,fsi} --> CompileOps.{fs,fsi}
  - renaming fscopts.{fs,fsi} --> CompileOptions.{fs,fsi}
  - moving the option parser to CompileOptions.fs (where it belongs!)
  - marking some record types as RequireQualifiedAccess (to give better errors when editing the compiler)
  - removed a whole bunch of semicolons
  - removed some old debugging output (verboseStamps etc.)

closes https://github.com/Microsoft/visualfsharp/pull/357

commit 5e692365e8fb01f279aa7836dbd3e4d6e96fff0c
Author: Don Syme <donsyme@fastmail.fm>
Date:   Mon Aug 3 14:09:33 2015 +0100

    restore code that should not have been removed

commit 7e8eda59c2929b2cfc55f24a7c96cec28994e892
Author: latkin <latkin@microsoft.com>
Date:   Fri Jul 31 18:15:49 2015 -0700

    Fix expected text in Watson test

commit 248a14c766e48e42e8c6c354ba28eaaaba650ac6
Merge: 4767d5b dd8252eb
Author: Don Syme <donsyme@fastmail.fm>
Date:   Thu Jul 9 16:42:28 2015 +0100

    integrate & merge with latest HEAD

commit 4767d5b506b3023de5e172b4dd636cbbd726873d
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 17:25:23 2015 +0200

    update to force appveyor

commit 0600f3eff57b1a378bb888ae52156d7eee9f53ce
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 16:52:21 2015 +0200

    update to force appveyor

commit 02c6c6cb2659b9b37e99066f9517ad00bb697702
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 16:38:12 2015 +0200

    update to fix build

commit 877a1d2083328bbc0f6e65626ebd22a7da05f568
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 16:30:50 2015 +0200

    update to fix build

commit dd886be184867f7ee404bd3aa7b2f45480702186
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 14:03:02 2015 +0200

    update to fix build

commit 4f73a2b1363a1dd1d9ba1e72d6eb856a50cf078b
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 13:46:02 2015 +0200

    update proto (4)

commit 5430936c1deae5258f3ba5d393435b12619752cf
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 13:44:10 2015 +0200

    update to fix build

commit 93d94c9918886a7a555e514287d84139f9acd915
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 13:35:15 2015 +0200

    update proto ()

commit 77fa7acf7d4eacb8602a0e61ef130a3482ca85c6
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 13:31:35 2015 +0200

    update proto and renamings

commit 8797a81bfc8009412d6875b9091b9cb786e785ba
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 13:05:09 2015 +0200

    integrate cleanup with  fsharp4 (2)

commit 31777c7fbf0f8e59fd8ef8967b618ecf76aa2b7b
Merge: c6ffdb62 bb09bb3
Author: Don Syme <donsyme@fastmail.fm>
Date:   Fri Apr 10 12:43:00 2015 +0200

    integrate cleanup with  fsharp4

commit bb09bb38641fc19a2e520930ab655a047341808b
Author: Don Syme <dsyme@microsoft.com>
Date:   Mon Dec 1 09:53:04 2014 +0000

    remove more semicolons in ilwrite.fs

commit a3ca1554da44bbd3563aa727d1e75f7f5ad1596e
Author: Don Syme <dsyme@microsoft.com>
Date:   Sun Nov 30 20:23:14 2014 +0000

    code cleanup inn ilwrite.fs and il.fs

commit f2e301e85ded692434319b09e69250eca7a37c26
Author: Don Syme <dsyme@microsoft.com>
Date:   Sun Nov 30 15:54:21 2014 +0000

    cleanup and rename build.fs and fscopts.fs

commit 20cb9b0bf32d01cce556e37edee1ab075051c4a5
Author: Don Syme <dsyme@microsoft.com>
Date:   Sun Nov 30 00:19:12 2014 +0000

    make some more functions into members in tast.fs

commit ddadb30cd4dea8649464a3ca461a516dd0e89b16
Author: Don Syme <dsyme@microsoft.com>
Date:   Sat Nov 29 23:31:17 2014 +0000

    additional cleanup in tast.fs (2)

commit 662d87c9ac87ac6e8aaf0e3694653585c722d3fc
Author: Don Syme <dsyme@microsoft.com>
Date:   Sat Nov 29 23:25:14 2014 +0000

    additional cleanup and comments in tast.fs

commit a27f527bc5f13ac561dc9b6ac7c880b17f6df7c2
Merge: 79b8293 4f943472
Author: Don Syme <dsyme@microsoft.com>
Date:   Sat Nov 29 20:37:10 2014 +0000

    Merge branch 'master' of https://git01.codeplex.com/visualfsharp into master-cleanup-1

commit 79b8293c6c0b48482de3d7b208489f2ce9c9ec9d
Author: Don Syme <dsyme@microsoft.com>
Date:   Sat Nov 29 20:35:26 2014 +0000

    code cleanup and file rename

fixes #316
closes #433

commit 6d9584caf54e0655c8c67375bc622dc3e38c2c28
Author: Don Syme <donsyme@fastmail.fm>
Date:   Sat May 9 18:14:42 2015 +0100

    fix 316

commit da567164f7c5d79119c13f5f5c2373b0dedd77d3
Author: Don Syme <donsyme@fastmail.fm>
Date:   Sat May 9 17:45:54 2015 +0100

    Fix 316

See spec at https://gist.github.com/latkin/cba4187a99db9747d0bf
closes #225

commit b8ea6f617f32e44f29a22afd7aa4f2d09bb1a091
Author: latkin <latkin@microsoft.com>
Date:   Tue Feb 24 17:12:04 2015 -0800

    Touch-ups after rebase

commit 26ff24562bfb49de79c44342105f2946898c2f1e
Author: latkin <latkin@microsoft.com>
Date:   Wed Feb 18 12:54:36 2015 -0800

    Add capability to auto-break on first executable line

commit 675a27298d687cb8c3240af64069cc22accefe02
Author: latkin <latkin@microsoft.com>
Date:   Wed Feb 18 12:53:27 2015 -0800

    Change menu text, use more sensible hotkeys

commit ab73f78ca8bfc4b433152aa3e173fc22b74786a0
Author: latkin <latkin@microsoft.com>
Date:   Wed Feb 18 12:52:39 2015 -0800

    Small whitespace alignment

commit f551344b09fdfb94bfd813100d6065032bd92520
Author: latkin <latkin@microsoft.com>
Date:   Thu Feb 12 19:29:16 2015 -0800

    Output symbol info for locals

commit d6a0faac99bd33fec0c4be24d13009127b8ff420
Author: latkin <latkin@microsoft.com>
Date:   Thu Feb 12 18:00:14 2015 -0800

    Use same whitespace style as existing code

commit a4003c17a006d7eeda1c3920ad05aef788db846e
Author: latkin <latkin@microsoft.com>
Date:   Wed Feb 11 11:06:22 2015 -0800

    Add 'detach' item for tool window, and give 'attach'/'detach' smart visibility

commit c5a64605aca53cdfd742975225c8fa4e665b9f84
Author: latkin <latkin@microsoft.com>
Date:   Wed Feb 11 07:39:34 2015 -0800

    Enable basic script debugging

Fixes #10, internal error: binding null type in envBindTypeRef

Both issues were caused by the same underlying issue.  RefEmit automagically applies escaping to names that contain a ','  So ``,`` becomes ``\,``.  When we tried to create a ref to a nested type we didn't add the ',' escaping so we couldnot bind to the created type.

The fix is very straightforward, change BasicQualifiedName to correctly escape names with comma's.

commit 8f1dcd1c760ce7ab2ae9de706bf12763038f2257
Author: latkin <latkin@microsoft.com>
Date:   Thu Oct 23 14:43:21 2014 -0700

    Updating tests to use proper env variables, adding .gitignore, renaming .cmd to .bat

commit 6097fc2b506c7b61130cf87643ba09f3740e05d5
Merge: 94c895db 0fc7b47
Author: latkin <latkin@microsoft.com>
Date:   Thu Oct 23 14:09:37 2014 -0700

    Merge branch 'pcl_inlining' of https://git01.codeplex.com/forks/vladima/primary into crossmodule

commit 0fc7b4707146d0cf198af1863dcc307d017ede45
Author: desco <desco.by@gmail.com>
Date:   Wed Oct 8 10:30:58 2014 -0700

    remove PrimaryAssembly.NamedMscorlib

commit b84ff88dce143bfd746e214acd806a839aa2903a
Author: desco <desco.by@gmail.com>
Date:   Sat Oct 4 14:13:44 2014 -0700

    added test to list

commit ee32d77d825cf57202135eb40eff9269aaa20c31
Author: desco <desco.by@gmail.com>
Date:   Fri Oct 3 23:24:30 2014 -0700

    Added tests

commit 7f0a59be92f544e4d04c5e41db1679490c419b3a
Author: desco <desco.by@gmail.com>
Date:   Fri Oct 3 16:27:13 2014 -0700

    consider both mscorlib and System.Runtime as candidate names of primary assembly

commit fef49e9f293499c24b30d919b7f5717f150b2c1c
Author: latkin <latkin@microsoft.com>
Date:   Wed Oct 15 15:38:35 2014 -0700

    Updating tests to use List/Seq.item

commit beffde30280cdf7e03ddaf03f3830547e7c1616a
Author: latkin <latkin@microsoft.com>
Date:   Wed Oct 15 15:19:45 2014 -0700

    Change codebase to use List.item, Seq.item, to avoid deprecated warning. #nowarn added for those files which are proto-compiled (so we can't change to item yet)

commit db122cc5416e106a8f2b1b32ad283b76e6741ff0
Author: latkin <latkin@microsoft.com>
Date:   Wed Oct 15 14:18:41 2014 -0700

    Validate input for Seq before calling GetEnumerator()

commit e71caf605179083527617937941b7332c57b2f8e
Author: latkin <latkin@microsoft.com>
Date:   Wed Oct 15 14:11:13 2014 -0700

    Minor fixups to XML documentation

commit a42c5f1354c77caeab0a792f683712dc91720c61
Merge: 321dcde0 4d20814
Author: latkin <latkin@microsoft.com>
Date:   Sun Oct 12 13:24:42 2014 -0700

    Merge branch 'item' of https://git01.codeplex.com/forks/mexx24/visualfsharp into PR

    Conflicts:
    	src/fsharp/FSharp.Core.Unittests/SurfaceArea.4.0.fs
    	src/fsharp/FSharp.Core.Unittests/SurfaceArea.Portable.fs
    	src/fsharp/FSharp.Core/array.fsi

commit 4d20814a858a054a92545571c5f99501a26c1974
Author: Max Malook <community@malook.de>
Date:   Thu Jul 10 02:03:36 2014 +0200

    mark Seq.nth, List.nth and Array.get as obsolete

commit 73a6a55a6482a58be1da32a322e7743e41125125
Author: Max Malook <community@malook.de>
Date:   Thu Jul 10 01:26:35 2014 +0200

    add Array.item function

commit d1dd69283ce3a8f6f6581313aff3fc9f3e4536d5
Author: Max Malook <community@malook.de>
Date:   Thu Jul 10 01:09:00 2014 +0200

    add List.item function

commit a9c613e3b0c68155194fa7e8cd4badc3cfd4591c
Author: Max Malook <community@malook.de>
Date:   Wed Jul 9 18:27:46 2014 +0200

    add Seq.item function

as requested in #27