* clean option module in illib

* Update NicePrint.fs

* Update NicePrint.fs

* Update NicePrint.fs

* Update NicePrint.fs

* Update NicePrint.fs

* reduce ILEventDef ILPropertyDef and ILFieldDef memory

* Update IlxGen.fs

* reduce ILMethodDef memory

* reduce ILTypeDef memory

* clean redundant functions

* make tuples support Item* with warning

* add deactivated tests for struct tuple

* proper return types for Rest, prototype ctors

* fix SRTP

* fix tests

* fix tests

* add more protection

* improve code for decompiling types

* fix unit tests

* don't rebuild

* make infos systematic to reduce use of tcrefOfAppTy

* update test cases

* fix build

* update test cases

* bump FCS version consistently

* use consistent names

* code review

* rename src/fsharp/vs --> src/fsharp/service

* move unit tests to tests"

* remove some namespace opens

* remove COMPILER_PUBLIC_API

* remove COMPILER_PUBLIC_API

* fix compiler generated flag for auto properties fields

* Remove unused mapFold and mapFoldBack functions (#4038)

* Fixed readonly property appearing in obj initialization (#4036)

* fix compiler generated flag for auto properties fields

* Fixed readonly property appearing in obj initialization

* Updating IL baselines

* Using IsMember instead of MemberInfo.IsNone

* Removed unneeded parens

* Fix typo (#4048)

* Use NO_EXTENSIONTYPING for better compiler debugging in normal case

* Update Fsc.fsproj

* Use UTC timestamps in compiler and service

* Fix tests

* Generate source for .resx files on build. (#3607)

* add build task to generate *.fs from *.resx files

* generate source for embedded resources in tests

* generate source for embedded resources in FSharp.Editor

* generate source for embedded resources in FSharp.LanguageService

* generate source for embedded resources in FSharp.ProjectSystem.FSharp

* generate source for embedded resources in FSharp.VS.FSI

* don't generate non-string resources when <=netstandard1.6

* update baseline error message for tests

The error output should be the exception message, not the exception type.

* perform up-to-date check before generating *.fs from *.resx

* remove non-idiomatic fold for an array comprehension

* correct newline replacement

* output more friendly error message

* throw if boolean value isn't explicitly `true` or `false`

* only generate object resource code on non `netstandard1.*` and `netcoreapp1.*` platforms

* ensure FSharp.Core specifies a target framework for resource generaton

* rename attributes to be non-ambiguous and properly include them

* fix order of file items in FSharp.Core

* Fix build.cmd for certain always-shown errors (like "unable to find registry key"), improve finding of VS2017 tools, fix DEVGUIDE.md (#3635)

* Fix build.com displaying the following error on each run "ERROR: The system was unable to find the specified registry key or value."

* Remove warning about reg.exe errors introduced in #3614 (in commit b548bd7, but unrelated to that fix), it is no longer necessary.

* Fix #3638, VS2017 Preview installation was not found when VS2017RTM is not installed. Remove comment introduced in #3614 (through commit 966bd7f7)

* Fixing JaroWinkler tests with InvariantCulture and fixing async tests by removing Debugger.Break() (#3627)

* Fixing JaroWinkler tests to use InvariantCulture for number-to-string

* Fixing the crashing of test runners because of a Debugger.Break() in a test

* update to System.Collections.Immutable 1.3.1 (#3641)

* update to System.Collections.Immutable 1.3.1

* fixes

* fix assembly reference

* [WIP] Adds optimized emit for int64 constants (#3620)

* Adds optimized emit for int64 constants.

* Adds comment linking to the changing PR.

Thanks for this PR.

Kevin

* fix assembly reference (#3646)

* Remove a few more build warnings (#3647)

* fix assembly reference

* remove more build warnings

* fix build

* move BuildFromSource projects to their own directory

* Adds tests for emitted IL for new Int64 constants. (#3650)

* Enable FS as prefix and ignore invalid values for warnings (#3631)

* enable fs as prefix and ignore invalid values for warnings + tests

* Allow #pragma to validate warnings

* do it right

* use ordinal compare

* In both places

* Add fs prefix to warnaserror

* Fixup tests

* Fix stack overflow on assembly resolution (#3658)

* Fix stack overflow on tp assembly resolution

* Feedback

* Add impl files to file check results (#3659)

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project

* add ImplementationFiles to FSharpCheckFileResults

* make FSharpImplementationFileContents ctor internal

* throw if ImplementationFiles is called having keepAssemblyContents flag set to false

* add a test

* spelling and cosmetics

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd (#3672)

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* Remove ambiguous an irrelevant instruction, improved help and instructions

* Fix a scenario where the return code wasn't nonzero for error conditions, fixes not creating backup dir when not backing up

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project (#3657)

* bump FCS version (#3676)

* bump version

* Update RELEASE_NOTES.md

* Parsing improvements: no reactor, add parsing options, error severity options (#3601)

* Parse without reactor, add parsing options, error severity options

* Revert parsing APIs (fallback to the new ones), fix VFT projects

* Cache parse results after type check

* Add impl files to file check results (#3659)

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project

* add ImplementationFiles to FSharpCheckFileResults

* make FSharpImplementationFileContents ctor internal

* throw if ImplementationFiles is called having keepAssemblyContents flag set to false

* add a test

* spelling and cosmetics

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd (#3672)

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* Remove ambiguous an irrelevant instruction, improved help and instructions

* Fix a scenario where the return code wasn't nonzero for error conditions, fixes not creating backup dir when not backing up

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project (#3657)

* bump FCS version (#3676)

* bump version

* Update RELEASE_NOTES.md

* updates to make tests pass

* restore old behaviour of CheckFileInProjectAllowingStaleCachedResults (builder had been created by ParseFileInProject)

* restore use of CheckFileInProjectAllowingStaleCachedResults

* deprecate test relying on whacky behaviour of deprecated GetCheckResultsBeforeFileInProjectEvenIfStale

* Use ParseFile and FSharpParsingOptions instead of ParseFileInProject

* prepare FCS release with this feature

* whitespace cleanup (#3682)

* whitespace and docs (#3684)

* Preserve XML docs for in-memory project references (#3683)

* fix xmldocs for in-memory project references

* add test

* fix tests

* whitespace and comments (#3686)

* fix assembly reference

* whitespace and comments

* whitespace and comments

* whitespace and comments

* cherry pick two PRs from FCS (#3687)

* fix assembly reference

* remove line endings from all *.nuspec files

* ProjectCracker returns *.fsi files in FSharpProjectOptions.SourceFiles array (in addition to *.fs files, in right order)

* ProjectCracker raises exception if ProjectCrackerTool returns non null ProjectCrackerOptions.Error (new field)

* fix build on linux

* fix a test

* slashes

* revert slashes

* Update FSharp.Compiler.Service.ProjectCracker.nuspec

* try to fix travis

* try to fix travis

* list dependencies

* no obsolete pdb in nuget

* list dependencies

* cherry pick of fsharp/fsharp change

* bump FCS version number (#3688)

* Update FSharp.Compiler.Service.MSBuild.v12.nuspec

* fix FCS nuget on windows

* fix-resource (#3690)

* Bump FSharp.Compiler.Tools to 4.1.27 and align mono build files (#3693)

* ri change from fsharp

* fix test

* bump FSC tools to 4.1.27

* remove fsharp.core from Mono GAC

* align mono directory

* fix typo

* install back versions with Mono

* fix typo

* update FCS doc generation (#3694)

* update DEVGUIDE to add addiitional steps before running build (#3725)

* Split templates out into a seperate vsix (#3720)

* merge error

* Merge issues

* fix assembly reference

* whitespace and comments

* whitespace and comments

* whitespace and comments

* Fix MethodDebugTable for portablePDBs

* ensure that pdb gets a record for abstract methods

* minimise diff

* improve debugging

* add missing files

* update baselines

* update baselines

* update test baselines

Issue opened:  https://github.com/Microsoft/visualfsharp/issues/3539

* Fix attribute references

* For attributes with type arguments only add reference to Nominal types

* simplify key and value access

* Remove unused function

* Directly use from list - saves couple of Map Ctors

* Revert "Remove unused function"

This reverts commit a2f6dc54a5d64842d7a66d24b4b28629db77d90f.

# Conflicts:
#	src/absil/zmap.fs

* Implement `MethodImplOptions.AggressiveInlining` flag - fixes #1637

* More inlining

* remove change to TAST

* fix build

* add test

* Add IL output option for deterministic output

Thread a new option through the options to the code writing the IL.
For the moment just use a constant for deterministic timestamp, and use 0 as the timestamp in the MVID

* Basic check to prevent wildcard version + deterministic at the same time

* Hash the code, data and metadata, and use for mvid + timestamp

* Fix fsc & fsci help tests by adding in new command line option for deterministic

* tests for command line, wildcard versions, normal non-deterministic behaviour

* Attempt to get CI to support timeout

* Allow PRECMD to call FSI more than once, and use this for copying files and pausing to prevent race-condition

* PortablePdbBuilder use consistent id 

If compiling deterministically, use deterministic id provider support in 
making a pdb builder. see https://github.com/dotnet/roslyn/blob/master/src/Compilers/Core/Portable/PEWriter/PeWriter.cs#L132

* Portable and Embedded pdb now deterministic

* wip: fix up timestamp in pdb, but mvids still out of sequence

* Fix breaking change from rebasing on master

* Add notes about determinism with non portable pdbs
Make the checks for finding embedded guids more
strict and unique

* Throw error if determinsitc build and non-portable pdb specified

* Don't convert attributes to array and then to list

* Don't convert attributes to array and then to list

* fix config change

* Fix configuration changes

* Fix colorization cache for changing defines

* fix config switching

* add manual test cases

* Fix test

* minor nit

* use correct reference count

* cleanup decrement logic

* fix build

* Update CompileOps.fs

* adjust unit tests mocks

* adjust unit tests mocks

* fix test

* add new misc project test

* do ComputeSourcesAndFlags later

* do ComputeSourcesAndFlags once

* variations

* keep dialog open

* import remaining FCS code

* add missing files

* fix some parts of build

* more FCS integration work

* build fcs.dll and vs targets

* revert changes to proj files

* update sig files

* various cleanup items

* simplify #ifs

* fix various tests

* enable scripting testing

* fix build

* fix build

* fix tests and build

* fix tests and build

* fix build

* fix tests

* fix tests

* add diagnostic and fix coreclr build

* fix printing tests

* test updates

* improve error logging

* integrate visualfsharp master

* dependency files

* proj file

* dependency files

* fix build

* fix fsi.exe in GUI mode

* add end of line to source text if needed as before

* fix many tests

* fix remaining tests

* better strong name logic to fix final test

* reinstate all strong names

* fix last tests

* fix last test again

* Don't call length if not needed

* Use hasLengthGreaterThen

* Use isNilOrSingleton

* Use isNilOrSingleton

* no double negations are not bad