1. 13 6月, 2009 1 次提交
    • A
      i2c: OMAP2/3: Fix scll/sclh calculations · baf46b4e
      Aaro Koskinen 提交于
      Fix scll/sclh calculations for HS and fast modes. Currently the driver
      uses equal (roughly) low/high times which will result in too short
      low time.
      
      OMAP3430 TRM gives the following equations:
      
      	F/S: tLow  = (scll + 7) * internal_clk
      	     tHigh = (sclh + 5) * internal_clk
      	HS:  tLow  = (scll + 7) * fclk
      	     tHigh = (sclh + 5) * fclk
      
      Furthermore, the I2C specification sets the following minimum values
      for HS tLow/tHigh for capacitive bus loads 100 pF (maximum speed 3400)
      and 400 pF (maximum speed 1700):
      
      	speed	tLow		tHigh
      	3400	160 ns		60 ns
      	1700	320 ns		120 ns
      
      and for F/S:
      
      	speed	tLow		tHigh
      	400	1300 ns		600 ns
      	100	4700 ns		4000 ns
      
      By using duty cycles 33/66 (HS, F) and 50/50 (S) we stay above these
      minimum values.
      Signed-off-by: NAaro Koskinen <aaro.koskinen@nokia.com>
      Acked-by: NTony Lindgren <tony@atomide.com>
      Signed-off-by: NBen Dooks <ben-linux@fluff.org>
      baf46b4e
  2. 09 2月, 2009 3 次提交
  3. 17 12月, 2008 1 次提交
  4. 22 11月, 2008 12 次提交
  5. 06 9月, 2008 1 次提交
  6. 23 4月, 2008 1 次提交
  7. 24 3月, 2008 1 次提交
    • T
      i2c-omap: Fix unhandled fault · f08ac4e7
      Tony Lindgren 提交于
      If an I2C interrupt happens between disabling interface clock
      and functional clock, the interrupt handler will produce an
      external abort on non-linefetch error when trying to access
      driver registers while interface clock is disabled.
      
      This patch fixes the problem by saving and disabling i2c-omap
      interrupt before turning off the clocks. Also disable functional
      clock before the interface clock as suggested by Paul Walmsley.
      
      Patch also renames enable/disable_clocks functions to unidle/idle
      functions. Note that the driver is currently not taking advantage
      of the idle interrupts. To use the idle interrupts, driver would
      have to enable interface clock based on the idle interrupt
      and dev->idle flag.
      
      This patch has been tested in linux-omap tree with various omaps.
      
      Cc: Paul Walmsley <paul@pwsan.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      f08ac4e7
  8. 28 1月, 2008 1 次提交
  9. 15 1月, 2008 1 次提交
  10. 12 12月, 2007 1 次提交
  11. 20 10月, 2007 1 次提交
  12. 02 5月, 2007 1 次提交
  13. 11 12月, 2006 1 次提交
  14. 05 10月, 2006 1 次提交
    • D
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells 提交于
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: NDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  15. 27 9月, 2006 2 次提交