未验证 提交 892c1584 编写于 作者: H Haoran Meng 提交者: GitHub

Close connection after heart beat detection complete #control-panel-cluster (#5843)

* close connection after heart beat detection complete

* remove unused imports
上级 6cb06a16
...@@ -22,6 +22,7 @@ import org.apache.shardingsphere.cluster.configuration.config.HeartbeatConfigura ...@@ -22,6 +22,7 @@ import org.apache.shardingsphere.cluster.configuration.config.HeartbeatConfigura
import org.apache.shardingsphere.cluster.heartbeat.response.HeartbeatResult; import org.apache.shardingsphere.cluster.heartbeat.response.HeartbeatResult;
import javax.sql.DataSource; import javax.sql.DataSource;
import java.sql.Connection;
import java.sql.PreparedStatement; import java.sql.PreparedStatement;
import java.sql.ResultSet; import java.sql.ResultSet;
import java.sql.SQLException; import java.sql.SQLException;
...@@ -53,10 +54,11 @@ public final class HeartbeatDetect extends AbstractHeartbeatDetect { ...@@ -53,10 +54,11 @@ public final class HeartbeatDetect extends AbstractHeartbeatDetect {
@Override @Override
protected Boolean detect() { protected Boolean detect() {
try { try (Connection connection = dataSource.getConnection();
PreparedStatement preparedStatement = dataSource.getConnection().prepareStatement(sql); PreparedStatement preparedStatement = connection.prepareStatement(sql)) {
ResultSet result = preparedStatement.executeQuery(); try (ResultSet result = preparedStatement.executeQuery()) {
return Objects.nonNull(result) && result.next(); return Objects.nonNull(result) && result.next();
}
} catch (SQLException ex) { } catch (SQLException ex) {
log.error("Heart beat detect error", ex); log.error("Heart beat detect error", ex);
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册