From 892c158409c412e65392a8e84d1bfceb29417086 Mon Sep 17 00:00:00 2001 From: Haoran Meng Date: Mon, 1 Jun 2020 13:16:44 +0800 Subject: [PATCH] Close connection after heart beat detection complete #control-panel-cluster (#5843) * close connection after heart beat detection complete * remove unused imports --- .../proxy/backend/cluster/HeartbeatDetect.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/cluster/HeartbeatDetect.java b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/cluster/HeartbeatDetect.java index a9b90dabf0..ea4bb7f9c1 100644 --- a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/cluster/HeartbeatDetect.java +++ b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/cluster/HeartbeatDetect.java @@ -22,6 +22,7 @@ import org.apache.shardingsphere.cluster.configuration.config.HeartbeatConfigura import org.apache.shardingsphere.cluster.heartbeat.response.HeartbeatResult; import javax.sql.DataSource; +import java.sql.Connection; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; @@ -53,10 +54,11 @@ public final class HeartbeatDetect extends AbstractHeartbeatDetect { @Override protected Boolean detect() { - try { - PreparedStatement preparedStatement = dataSource.getConnection().prepareStatement(sql); - ResultSet result = preparedStatement.executeQuery(); - return Objects.nonNull(result) && result.next(); + try (Connection connection = dataSource.getConnection(); + PreparedStatement preparedStatement = connection.prepareStatement(sql)) { + try (ResultSet result = preparedStatement.executeQuery()) { + return Objects.nonNull(result) && result.next(); + } } catch (SQLException ex) { log.error("Heart beat detect error", ex); } -- GitLab