tscSQLParser.c 234.6 KB
Newer Older
H
hzcheng 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

16 17
#define _BSD_SOURCE
#define _XOPEN_SOURCE 500
S
slguan 已提交
18
#define _DEFAULT_SOURCE
19
#define _GNU_SOURCE
H
hzcheng 已提交
20

S
slguan 已提交
21
#include "os.h"
22
#include "ttype.h"
H
Haojun Liao 已提交
23
#include "qAst.h"
H
hzcheng 已提交
24
#include "taos.h"
S
slguan 已提交
25
#include "taosmsg.h"
H
Haojun Liao 已提交
26 27
#include "tcompare.h"
#include "tname.h"
S
slguan 已提交
28
#include "tscLog.h"
H
hzcheng 已提交
29 30 31
#include "tscUtil.h"
#include "tschemautil.h"
#include "tsclient.h"
H
Haojun Liao 已提交
32 33
#include "tstoken.h"
#include "tstrbuild.h"
34
#include "ttokendef.h"
H
hjxilinx 已提交
35

S
slguan 已提交
36 37
#define DEFAULT_PRIMARY_TIMESTAMP_COL_NAME "_c0"

Y
TD-1230  
yihaoDeng 已提交
38 39
#define TSWINDOW_IS_EQUAL(t1, t2) (((t1).skey == (t2).skey) && ((t1).ekey == (t2).ekey))

H
Haojun Liao 已提交
40 41
// -1 is tbname column index, so here use the -3 as the initial value
#define COLUMN_INDEX_INITIAL_VAL (-3)
S
slguan 已提交
42 43 44 45
#define COLUMN_INDEX_INITIALIZER \
  { COLUMN_INDEX_INITIAL_VAL, COLUMN_INDEX_INITIAL_VAL }
#define COLUMN_INDEX_VALIDE(index) (((index).tableIndex >= 0) && ((index).columnIndex >= TSDB_TBNAME_COLUMN_INDEX))
#define TBNAME_LIST_SEP ","
H
hzcheng 已提交
46

H
Haojun Liao 已提交
47
typedef struct SColumnList {  // todo refactor
S
slguan 已提交
48 49
  int32_t      num;
  SColumnIndex ids[TSDB_MAX_COLUMNS];
H
hzcheng 已提交
50 51
} SColumnList;

Y
TD-1230  
yihaoDeng 已提交
52 53 54 55
typedef struct SConvertFunc {
  int32_t originFuncId;
  int32_t execFuncId;
} SConvertFunc;
H
Haojun Liao 已提交
56 57

static SSqlExpr* doAddProjectCol(SQueryInfo* pQueryInfo, int32_t colIndex, int32_t tableIndex);
H
hzcheng 已提交
58 59

static int32_t setShowInfo(SSqlObj* pSql, SSqlInfo* pInfo);
H
hjxilinx 已提交
60
static char*   getAccountId(SSqlObj* pSql);
H
hzcheng 已提交
61

H
Haojun Liao 已提交
62
static bool has(SArray* pFieldList, int32_t startIdx, const char* name);
H
Haojun Liao 已提交
63 64
static void getCurrentDBName(SSqlObj* pSql, SStrToken* pDBToken);
static bool hasSpecifyDB(SStrToken* pTableName);
H
Haojun Liao 已提交
65 66
static bool validateTableColumnInfo(SArray* pFieldList, SSqlCmd* pCmd);
static bool validateTagParams(SArray* pTagsList, SArray* pFieldList, SSqlCmd* pCmd);
H
hzcheng 已提交
67

H
Haojun Liao 已提交
68
static int32_t setObjFullName(char* fullName, const char* account, SStrToken* pDB, SStrToken* tableName, int32_t* len);
H
hzcheng 已提交
69

H
Haojun Liao 已提交
70
static void getColumnName(tSqlExprItem* pItem, char* resultFieldName, int32_t nameLength);
H
hzcheng 已提交
71

H
Haojun Liao 已提交
72
static int32_t addExprAndResultField(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, int32_t colIndex, tSqlExprItem* pItem, bool finalResult);
73
static int32_t insertResultField(SQueryInfo* pQueryInfo, int32_t outputIndex, SColumnList* pIdList, int16_t bytes,
H
hjxilinx 已提交
74
                                 int8_t type, char* fieldName, SSqlExpr* pSqlExpr);
H
Haojun Liao 已提交
75 76 77 78

static int32_t convertFunctionId(int32_t optr, int16_t* functionId);
static uint8_t convertOptr(SStrToken *pToken);

D
fix bug  
dapan1121 已提交
79
static int32_t parseSelectClause(SSqlCmd* pCmd, int32_t clauseIndex, tSQLExprList* pSelection, bool isSTable, bool joinQuery, bool intervalQuery);
H
hzcheng 已提交
80

81
static bool validateIpAddress(const char* ip, size_t size);
82
static bool hasUnsupportFunctionsForSTableQuery(SSqlCmd* pCmd, SQueryInfo* pQueryInfo);
D
fix bug  
dapan1121 已提交
83
static bool functionCompatibleCheck(SQueryInfo* pQueryInfo, bool joinQuery, bool intervalQuery);
H
hzcheng 已提交
84

H
Haojun Liao 已提交
85
static int32_t parseGroupbyClause(SQueryInfo* pQueryInfo, SArray* pList, SSqlCmd* pCmd);
H
hzcheng 已提交
86

87
static int32_t parseIntervalClause(SSqlObj* pSql, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql);
88
static int32_t parseOffsetClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql);
89
static int32_t parseSlidingClause(SSqlObj* pSql, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql);
H
hzcheng 已提交
90

H
Haojun Liao 已提交
91
static int32_t addProjectionExprAndResultField(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSqlExprItem* pItem);
H
hzcheng 已提交
92

93
static int32_t parseWhereClause(SQueryInfo* pQueryInfo, tSQLExpr** pExpr, SSqlObj* pSql);
94 95
static int32_t parseFillClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySQL);
static int32_t parseOrderbyClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql, SSchema* pSchema);
H
hzcheng 已提交
96

97
static int32_t tsRewriteFieldNameIfNecessary(SSqlCmd* pCmd, SQueryInfo* pQueryInfo);
H
hzcheng 已提交
98
static int32_t setAlterTableInfo(SSqlObj* pSql, struct SSqlInfo* pInfo);
99 100 101
static int32_t validateSqlFunctionInStreamSql(SSqlCmd* pCmd, SQueryInfo* pQueryInfo);
static int32_t validateFunctionsInIntervalOrGroupbyQuery(SSqlCmd* pCmd, SQueryInfo* pQueryInfo);
static int32_t validateArithmeticSQLExpr(SSqlCmd* pCmd, tSQLExpr* pExpr, SQueryInfo* pQueryInfo, SColumnList* pList, int32_t* type);
H
Hui Li 已提交
102
static int32_t validateEp(char* ep);
H
hzcheng 已提交
103
static int32_t validateDNodeConfig(tDCLSQL* pOptions);
S
slguan 已提交
104
static int32_t validateLocalConfig(tDCLSQL* pOptions);
H
hzcheng 已提交
105
static int32_t validateColumnName(char* name);
106
static int32_t setKillInfo(SSqlObj* pSql, struct SSqlInfo* pInfo, int32_t killType);
S
slguan 已提交
107

H
hjxilinx 已提交
108
static bool validateOneTags(SSqlCmd* pCmd, TAOS_FIELD* pTagField);
109
static bool hasTimestampForPointInterpQuery(SQueryInfo* pQueryInfo);
110
static bool hasNormalColumnFilter(SQueryInfo* pQueryInfo);
H
hjxilinx 已提交
111

112
static int32_t parseLimitClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, int32_t index, SQuerySQL* pQuerySql, SSqlObj* pSql);
H
hjxilinx 已提交
113
static int32_t parseCreateDBOptions(SSqlCmd* pCmd, SCreateDBInfo* pCreateDbSql);
H
Haojun Liao 已提交
114 115
static int32_t getColumnIndexByName(SSqlCmd* pCmd, const SStrToken* pToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex);
static int32_t getTableIndexByName(SStrToken* pToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex);
S
slguan 已提交
116 117
static int32_t optrToString(tSQLExpr* pExpr, char** exprString);

H
Haojun Liao 已提交
118
static int32_t getTableIndexImpl(SStrToken* pTableToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex);
119
static int32_t doFunctionsCompatibleCheck(SSqlCmd* pCmd, SQueryInfo* pQueryInfo);
120
static int32_t doLocalQueryProcess(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql);
S
TD-1732  
Shengliang Guan 已提交
121
static int32_t tscCheckCreateDbParams(SSqlCmd* pCmd, SCreateDbMsg* pCreate);
H
hjxilinx 已提交
122

S
slguan 已提交
123
static SColumnList getColumnList(int32_t num, int16_t tableIndex, int32_t columnIndex);
H
hjxilinx 已提交
124

125
static int32_t doCheckForCreateTable(SSqlObj* pSql, int32_t subClauseIndex, SSqlInfo* pInfo);
126 127 128
static int32_t doCheckForCreateFromStable(SSqlObj* pSql, SSqlInfo* pInfo);
static int32_t doCheckForStream(SSqlObj* pSql, SSqlInfo* pInfo);
static int32_t doCheckForQuery(SSqlObj* pSql, SQuerySQL* pQuerySql, int32_t index);
H
Haojun Liao 已提交
129
static int32_t exprTreeFromSqlExpr(SSqlCmd* pCmd, tExprNode **pExpr, const tSQLExpr* pSqlExpr, SQueryInfo* pQueryInfo, SArray* pCols, int64_t *uid);
H
hjxilinx 已提交
130

H
Haojun Liao 已提交
131 132 133 134
int16_t getNewResColId(SQueryInfo* pQueryInfo) {
  return pQueryInfo->resColumnId--;
}

H
Haojun Liao 已提交
135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173
static uint8_t convertOptr(SStrToken *pToken) {
  switch (pToken->type) {
    case TK_LT:
      return TSDB_RELATION_LESS;
    case TK_LE:
      return TSDB_RELATION_LESS_EQUAL;
    case TK_GT:
      return TSDB_RELATION_GREATER;
    case TK_GE:
      return TSDB_RELATION_GREATER_EQUAL;
    case TK_NE:
      return TSDB_RELATION_NOT_EQUAL;
    case TK_AND:
      return TSDB_RELATION_AND;
    case TK_OR:
      return TSDB_RELATION_OR;
    case TK_EQ:
      return TSDB_RELATION_EQUAL;
    case TK_PLUS:
      return TSDB_BINARY_OP_ADD;
    case TK_MINUS:
      return TSDB_BINARY_OP_SUBTRACT;
    case TK_STAR:
      return TSDB_BINARY_OP_MULTIPLY;
    case TK_SLASH:
    case TK_DIVIDE:
      return TSDB_BINARY_OP_DIVIDE;
    case TK_REM:
      return TSDB_BINARY_OP_REMAINDER;
    case TK_LIKE:
      return TSDB_RELATION_LIKE;
    case TK_ISNULL:
      return TSDB_RELATION_ISNULL;
    case TK_NOTNULL:
      return TSDB_RELATION_NOTNULL;
    default: { return 0; }
  }
}

H
hjxilinx 已提交
174 175 176 177
/*
 * Used during parsing query sql. Since the query sql usually small in length, error position
 * is not needed in the final error message.
 */
178 179
static int32_t invalidSqlErrMsg(char* dstBuffer, const char* errMsg) {
  return tscInvalidSQLErrMsg(dstBuffer, errMsg, NULL);
H
hjxilinx 已提交
180 181
}

182
static int setColumnFilterInfoForTimestamp(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tVariant* pVar) {
S
slguan 已提交
183 184 185 186 187
  int64_t     time = 0;
  const char* msg = "invalid timestamp";

  strdequote(pVar->pz);
  char*           seg = strnchr(pVar->pz, '-', pVar->nLen, false);
H
hjxilinx 已提交
188
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
S
slguan 已提交
189

H
hjxilinx 已提交
190
  STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);
H
hjxilinx 已提交
191
  
S
slguan 已提交
192
  if (seg != NULL) {
dengyihao's avatar
dengyihao 已提交
193
    if (taosParseTime(pVar->pz, &time, pVar->nLen, tinfo.precision, tsDaylight) != TSDB_CODE_SUCCESS) {
194
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
S
slguan 已提交
195 196
    }
  } else {
197
    if (tVariantDump(pVar, (char*)&time, TSDB_DATA_TYPE_BIGINT, true)) {
198
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
S
slguan 已提交
199 200 201 202 203 204 205 206 207
    }
  }

  tVariantDestroy(pVar);
  tVariantCreateFromBinary(pVar, (char*)&time, 0, TSDB_DATA_TYPE_BIGINT);

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
208
static int32_t handlePassword(SSqlCmd* pCmd, SStrToken* pPwd) {
209 210 211 212 213
  const char* msg1 = "password can not be empty";
  const char* msg2 = "name or password too long";
  const char* msg3 = "password needs single quote marks enclosed";

  if (pPwd->type != TK_STRING) {
214
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
215 216 217
  }

  strdequote(pPwd->z);
S
TD-1057  
Shengliang Guan 已提交
218
  pPwd->n = (uint32_t)strtrim(pPwd->z);  // trim space before and after passwords
219 220

  if (pPwd->n <= 0) {
221
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
222 223
  }

B
Bomin Zhang 已提交
224
  if (pPwd->n >= TSDB_PASSWORD_LEN) {
225
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
226 227 228 229 230
  }

  return TSDB_CODE_SUCCESS;
}

H
hzcheng 已提交
231 232
int32_t tscToSQLCmd(SSqlObj* pSql, struct SSqlInfo* pInfo) {
  if (pInfo == NULL || pSql == NULL || pSql->signature != pSql) {
233
    return TSDB_CODE_TSC_APP_ERROR;
H
hzcheng 已提交
234 235
  }

236 237
  SSqlCmd* pCmd = &pSql->cmd;
  SSqlRes* pRes = &pSql->res;
H
hzcheng 已提交
238

239
  int32_t code = TSDB_CODE_SUCCESS;
H
Haojun Liao 已提交
240 241
  if (!pInfo->valid || terrno == TSDB_CODE_TSC_SQL_SYNTAX_ERROR) {
    terrno = TSDB_CODE_SUCCESS;  // clear the error number
Y
TD-934  
yihaoDeng 已提交
242
    return tscSQLSyntaxErrMsg(tscGetErrorMsgPayload(pCmd), NULL, pInfo->pzErrMsg);
H
hzcheng 已提交
243 244
  }

245 246 247 248 249
  SQueryInfo* pQueryInfo = tscGetQueryInfoDetailSafely(pCmd, pCmd->clauseIndex);
  if (pQueryInfo == NULL) {
    pRes->code = terrno;
    return pRes->code;
  }
H
hjxilinx 已提交
250

251 252 253 254
  STableMetaInfo* pTableMetaInfo = (pQueryInfo->numOfTables == 0)? tscAddEmptyMetaInfo(pQueryInfo) : pQueryInfo->pTableMetaInfo[0];
  if (pTableMetaInfo == NULL) {
    pRes->code = TSDB_CODE_TSC_OUT_OF_MEMORY;
    return pRes->code;
H
hjxilinx 已提交
255
  }
256

257 258 259 260 261 262 263 264
  pCmd->command = pInfo->type;

  switch (pInfo->type) {
    case TSDB_SQL_DROP_TABLE:
    case TSDB_SQL_DROP_USER:
    case TSDB_SQL_DROP_ACCT:
    case TSDB_SQL_DROP_DNODE:
    case TSDB_SQL_DROP_DB: {
265
      const char* msg2 = "invalid name";
266
      const char* msg3 = "param name too long";
H
hzcheng 已提交
267

H
Haojun Liao 已提交
268
      SStrToken* pzName = &pInfo->pDCLInfo->a[0];
269
      if ((pInfo->type != TSDB_SQL_DROP_DNODE) && (tscValidateName(pzName) != TSDB_CODE_SUCCESS)) {
270
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
271 272
      }

273 274
      if (pInfo->type == TSDB_SQL_DROP_DB) {
        assert(pInfo->pDCLInfo->nTokens == 1);
H
hzcheng 已提交
275

H
hjxilinx 已提交
276
        code = setObjFullName(pTableMetaInfo->name, getAccountId(pSql), pzName, NULL, NULL);
H
hzcheng 已提交
277
        if (code != TSDB_CODE_SUCCESS) {
278
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
279 280
        }

281 282
      } else if (pInfo->type == TSDB_SQL_DROP_TABLE) {
        assert(pInfo->pDCLInfo->nTokens == 1);
H
hzcheng 已提交
283

Y
TD-1039  
yihaoDeng 已提交
284 285 286
        code = tscSetTableFullName(pTableMetaInfo, pzName, pSql);
        if(code != TSDB_CODE_SUCCESS) {
          return code; 
H
hzcheng 已提交
287
        }
288
      } else if (pInfo->type == TSDB_SQL_DROP_DNODE) {
S
slguan 已提交
289
        pzName->n = strdequote(pzName->z);
H
hjxilinx 已提交
290
        strncpy(pTableMetaInfo->name, pzName->z, pzName->n);
291
      } else {  // drop user
B
Bomin Zhang 已提交
292
        if (pzName->n >= TSDB_USER_LEN) {
293
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
294 295
        }

H
hjxilinx 已提交
296
        strncpy(pTableMetaInfo->name, pzName->z, pzName->n);
H
hzcheng 已提交
297 298
      }

299 300
      break;
    }
H
hzcheng 已提交
301

302 303
    case TSDB_SQL_USE_DB: {
      const char* msg = "invalid db name";
H
Haojun Liao 已提交
304
      SStrToken*  pToken = &pInfo->pDCLInfo->a[0];
S
slguan 已提交
305 306

      if (tscValidateName(pToken) != TSDB_CODE_SUCCESS) {
307
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
308 309
      }

H
hjxilinx 已提交
310
      int32_t ret = setObjFullName(pTableMetaInfo->name, getAccountId(pSql), pToken, NULL, NULL);
H
hzcheng 已提交
311
      if (ret != TSDB_CODE_SUCCESS) {
312
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
313 314 315 316 317
      }

      break;
    }

318 319
    case TSDB_SQL_RESET_CACHE: {
      return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
320 321
    }

322 323
    case TSDB_SQL_SHOW: {
      if (setShowInfo(pSql, pInfo) != TSDB_CODE_SUCCESS) {
324
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
325 326
      }

327 328 329 330 331 332 333 334
      break;
    }

    case TSDB_SQL_ALTER_DB:
    case TSDB_SQL_CREATE_DB: {
      const char* msg1 = "invalid db name";
      const char* msg2 = "name too long";

335
      SCreateDBInfo* pCreateDB = &(pInfo->pDCLInfo->dbOpt);
H
hzcheng 已提交
336
      if (tscValidateName(&pCreateDB->dbname) != TSDB_CODE_SUCCESS) {
337
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
338 339
      }

H
hjxilinx 已提交
340
      int32_t ret = setObjFullName(pTableMetaInfo->name, getAccountId(pSql), &(pCreateDB->dbname), NULL, NULL);
H
hzcheng 已提交
341
      if (ret != TSDB_CODE_SUCCESS) {
342
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
343 344
      }

H
hjxilinx 已提交
345
      if (parseCreateDBOptions(pCmd, pCreateDB) != TSDB_CODE_SUCCESS) {
346
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
347 348 349 350 351
      }

      break;
    }

352 353
    case TSDB_SQL_CREATE_DNODE: {  // todo hostname
      const char* msg = "invalid host name (ip address)";
S
slguan 已提交
354

355
      if (pInfo->pDCLInfo->nTokens > 1) {
356
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
S
slguan 已提交
357 358
      }

H
Haojun Liao 已提交
359
      SStrToken* pIpAddr = &pInfo->pDCLInfo->a[0];
S
slguan 已提交
360
      pIpAddr->n = strdequote(pIpAddr->z);
S
slguan 已提交
361 362 363
      break;
    }

364 365 366 367 368
    case TSDB_SQL_CREATE_ACCT:
    case TSDB_SQL_ALTER_ACCT: {
      const char* msg1 = "invalid state option, available options[no, r, w, all]";
      const char* msg2 = "invalid user/account name";
      const char* msg3 = "name too long";
H
hzcheng 已提交
369

H
Haojun Liao 已提交
370 371
      SStrToken* pName = &pInfo->pDCLInfo->user.user;
      SStrToken* pPwd = &pInfo->pDCLInfo->user.passwd;
H
hzcheng 已提交
372

373
      if (handlePassword(pCmd, pPwd) != TSDB_CODE_SUCCESS) {
374
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
375 376
      }

B
Bomin Zhang 已提交
377
      if (pName->n >= TSDB_USER_LEN) {
378
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
379 380
      }

381
      if (tscValidateName(pName) != TSDB_CODE_SUCCESS) {
382
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
383 384 385
      }

      SCreateAcctSQL* pAcctOpt = &pInfo->pDCLInfo->acctOpt;
386
      if (pAcctOpt->stat.n > 0) {
H
hzcheng 已提交
387 388 389 390 391
        if (pAcctOpt->stat.z[0] == 'r' && pAcctOpt->stat.n == 1) {
        } else if (pAcctOpt->stat.z[0] == 'w' && pAcctOpt->stat.n == 1) {
        } else if (strncmp(pAcctOpt->stat.z, "all", 3) == 0 && pAcctOpt->stat.n == 3) {
        } else if (strncmp(pAcctOpt->stat.z, "no", 2) == 0 && pAcctOpt->stat.n == 2) {
        } else {
392
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
393 394
        }
      }
395

H
hzcheng 已提交
396 397 398
      break;
    }

399
    case TSDB_SQL_DESCRIBE_TABLE: {
H
Haojun Liao 已提交
400
      SStrToken*  pToken = &pInfo->pDCLInfo->a[0];
H
hjxilinx 已提交
401
      const char* msg1 = "invalid table name";
H
Haojun Liao 已提交
402
      const char* msg2 = "table name too long";
H
hzcheng 已提交
403

S
slguan 已提交
404
      if (tscValidateName(pToken) != TSDB_CODE_SUCCESS) {
405
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
406
      }
S
slguan 已提交
407

H
Haojun Liao 已提交
408
      if (!tscValidateTableNameLength(pToken->n)) {
409
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
410 411
      }

H
Haojun Liao 已提交
412
      // additional msg has been attached already
H
Haojun Liao 已提交
413 414 415
      code = tscSetTableFullName(pTableMetaInfo, pToken, pSql);
      if (code != TSDB_CODE_SUCCESS) {
        return code;
H
hzcheng 已提交
416 417
      }

H
hjxilinx 已提交
418
      return tscGetTableMeta(pSql, pTableMetaInfo);
H
hzcheng 已提交
419
    }
420 421 422 423
    case TSDB_SQL_SHOW_CREATE_TABLE: {
      SStrToken*  pToken = &pInfo->pDCLInfo->a[0];
      const char* msg1 = "invalid table name";
      const char* msg2 = "table name is too long";
H
hzcheng 已提交
424

425 426 427
      if (tscValidateName(pToken) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
      }
H
hzcheng 已提交
428

429 430 431 432
      if (!tscValidateTableNameLength(pToken->n)) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
      }

H
Haojun Liao 已提交
433 434 435
      code = tscSetTableFullName(pTableMetaInfo, pToken, pSql);
      if (code != TSDB_CODE_SUCCESS) {
        return code;
436
      }
H
Haojun Liao 已提交
437

438 439 440 441 442 443 444 445 446 447 448 449
      return tscGetTableMeta(pSql, pTableMetaInfo);
    }
    case TSDB_SQL_SHOW_CREATE_DATABASE: {
      const char* msg1 = "invalid database name";
      SStrToken*  pToken = &pInfo->pDCLInfo->a[0];

      if (tscValidateName(pToken) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
      }
      if (pToken->n > TSDB_DB_NAME_LEN) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
      }
H
Haojun Liao 已提交
450 451 452

      return tscSetTableFullName(pTableMetaInfo, pToken, pSql);
    }
453
    case TSDB_SQL_CFG_DNODE: {
S
Shengliang Guan 已提交
454
      const char* msg2 = "invalid configure options or values, such as resetlog / debugFlag 135 / balance 'vnode:2-dnode:2' / monitor 1 ";
H
Hui Li 已提交
455
      const char* msg3 = "invalid dnode ep";
H
hzcheng 已提交
456

457 458
      /* validate the ip address */
      tDCLSQL* pDCL = pInfo->pDCLInfo;
H
hzcheng 已提交
459

460 461
      /* validate the parameter names and options */
      if (validateDNodeConfig(pDCL) != TSDB_CODE_SUCCESS) {
462
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
463 464
      }

guanshengliang's avatar
guanshengliang 已提交
465
      char* pMsg = pCmd->payload;
H
hzcheng 已提交
466

S
TD-1732  
Shengliang Guan 已提交
467
      SCfgDnodeMsg* pCfg = (SCfgDnodeMsg*)pMsg;
guanshengliang's avatar
guanshengliang 已提交
468 469
      pDCL->a[0].n = strdequote(pDCL->a[0].z);
      
J
jtao1735 已提交
470
      strncpy(pCfg->ep, pDCL->a[0].z, pDCL->a[0].n);
H
hzcheng 已提交
471

H
Hui Li 已提交
472 473 474 475
      if (validateEp(pCfg->ep) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
      }

476
      strncpy(pCfg->config, pDCL->a[1].z, pDCL->a[1].n);
H
hzcheng 已提交
477

478 479 480 481
      if (pDCL->nTokens == 3) {
        pCfg->config[pDCL->a[1].n] = ' ';  // add sep
        strncpy(&pCfg->config[pDCL->a[1].n + 1], pDCL->a[2].z, pDCL->a[2].n);
      }
H
hzcheng 已提交
482

483 484
      break;
    }
H
hzcheng 已提交
485

486 487 488 489
    case TSDB_SQL_CREATE_USER:
    case TSDB_SQL_ALTER_USER: {
      const char* msg2 = "invalid user/account name";
      const char* msg3 = "name too long";
490 491
      const char* msg5 = "invalid user rights";
      const char* msg7 = "not support options";
H
hzcheng 已提交
492

493
      pCmd->command = pInfo->type;
H
hzcheng 已提交
494

495
      SUserInfo* pUser = &pInfo->pDCLInfo->user;
H
Haojun Liao 已提交
496 497
      SStrToken* pName = &pUser->user;
      SStrToken* pPwd = &pUser->passwd;
H
hzcheng 已提交
498

B
Bomin Zhang 已提交
499
      if (pName->n >= TSDB_USER_LEN) {
500
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
501
      }
H
hzcheng 已提交
502

503
      if (tscValidateName(pName) != TSDB_CODE_SUCCESS) {
504
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
505
      }
H
hzcheng 已提交
506

507 508
      if (pCmd->command == TSDB_SQL_CREATE_USER) {
        if (handlePassword(pCmd, pPwd) != TSDB_CODE_SUCCESS) {
509
          return TSDB_CODE_TSC_INVALID_SQL;
510 511 512 513
        }
      } else {
        if (pUser->type == TSDB_ALTER_USER_PASSWD) {
          if (handlePassword(pCmd, pPwd) != TSDB_CODE_SUCCESS) {
514
            return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
515
          }
516
        } else if (pUser->type == TSDB_ALTER_USER_PRIVILEGES) {
L
lihui 已提交
517 518
          assert(pPwd->type == TSDB_DATA_TYPE_NULL);

H
Haojun Liao 已提交
519
          SStrToken* pPrivilege = &pUser->privilege;
H
hzcheng 已提交
520

L
lihui 已提交
521
          if (strncasecmp(pPrivilege->z, "super", 5) == 0 && pPrivilege->n == 5) {
H
hzcheng 已提交
522
            pCmd->count = 1;
L
lihui 已提交
523
          } else if (strncasecmp(pPrivilege->z, "read", 4) == 0 && pPrivilege->n == 4) {
H
hzcheng 已提交
524
            pCmd->count = 2;
L
lihui 已提交
525
          } else if (strncasecmp(pPrivilege->z, "write", 5) == 0 && pPrivilege->n == 5) {
H
hzcheng 已提交
526 527
            pCmd->count = 3;
          } else {
528
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
529 530
          }
        } else {
531
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
H
hzcheng 已提交
532 533
        }
      }
534

H
hzcheng 已提交
535 536
      break;
    }
537 538

    case TSDB_SQL_CFG_LOCAL: {
S
slguan 已提交
539 540 541 542 543
      tDCLSQL*    pDCL = pInfo->pDCLInfo;
      const char* msg = "invalid configure options or values";

      // validate the parameter names and options
      if (validateLocalConfig(pDCL) != TSDB_CODE_SUCCESS) {
544
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
S
slguan 已提交
545 546 547 548 549 550 551
      }

      strncpy(pCmd->payload, pDCL->a[0].z, pDCL->a[0].n);
      if (pDCL->nTokens == 2) {
        pCmd->payload[pDCL->a[0].n] = ' ';  // add sep
        strncpy(&pCmd->payload[pDCL->a[0].n + 1], pDCL->a[1].z, pDCL->a[1].n);
      }
H
hzcheng 已提交
552 553 554 555

      break;
    }

556 557
    case TSDB_SQL_CREATE_TABLE: {
      SCreateTableSQL* pCreateTable = pInfo->pCreateTableInfo;
H
hzcheng 已提交
558

559
      if (pCreateTable->type == TSQL_CREATE_TABLE || pCreateTable->type == TSQL_CREATE_STABLE) {
560
        if ((code = doCheckForCreateTable(pSql, 0, pInfo)) != TSDB_CODE_SUCCESS) {
561
          return code;
H
hzcheng 已提交
562 563
        }

564
      } else if (pCreateTable->type == TSQL_CREATE_TABLE_FROM_STABLE) {
565
        assert(pCmd->numOfCols == 0);
566 567
        if ((code = doCheckForCreateFromStable(pSql, pInfo)) != TSDB_CODE_SUCCESS) {
          return code;
H
hzcheng 已提交
568 569
        }

570 571 572
      } else if (pCreateTable->type == TSQL_CREATE_STREAM) {
        if ((code = doCheckForStream(pSql, pInfo)) != TSDB_CODE_SUCCESS) {
          return code;
S
slguan 已提交
573
        }
H
hzcheng 已提交
574 575 576 577 578
      }

      break;
    }

579
    case TSDB_SQL_SELECT: {
H
hjxilinx 已提交
580
      const char* msg1 = "columns in select clause not identical";
H
hjxilinx 已提交
581

582
      for (int32_t i = pCmd->numOfClause; i < pInfo->subclauseInfo.numOfClause; ++i) {
583 584 585 586
        SQueryInfo* pqi = tscGetQueryInfoDetailSafely(pCmd, i);
        if (pqi == NULL) {
          pRes->code = terrno;
          return pRes->code;
587
        }
588 589 590
      }

      assert(pCmd->numOfClause == pInfo->subclauseInfo.numOfClause);
H
Haojun Liao 已提交
591
      for (int32_t i = pCmd->clauseIndex; i < pInfo->subclauseInfo.numOfClause; ++i) {
592
        SQuerySQL* pQuerySql = pInfo->subclauseInfo.pClause[i];
H
Haojun Liao 已提交
593
        tscTrace("%p start to parse %dth subclause, total:%d", pSql, i, pInfo->subclauseInfo.numOfClause);
594 595
        if ((code = doCheckForQuery(pSql, pQuerySql, i)) != TSDB_CODE_SUCCESS) {
          return code;
H
hzcheng 已提交
596
        }
H
hjxilinx 已提交
597

H
hjxilinx 已提交
598
        tscPrintSelectClause(pSql, i);
H
Haojun Liao 已提交
599
        pCmd->clauseIndex += 1;
H
hzcheng 已提交
600
      }
H
hjxilinx 已提交
601

H
Haojun Liao 已提交
602 603
      // restore the clause index
      pCmd->clauseIndex = 0;
H
hjxilinx 已提交
604
      // set the command/global limit parameters from the first subclause to the sqlcmd object
605 606
      SQueryInfo* pQueryInfo1 = tscGetQueryInfoDetail(pCmd, 0);
      pCmd->command = pQueryInfo1->command;
H
hjxilinx 已提交
607

608
      // if there is only one element, the limit of clause is the limit of global result.
H
hjxilinx 已提交
609
      for (int32_t i = 1; i < pCmd->numOfClause; ++i) {
610
        SQueryInfo* pQueryInfo2 = tscGetQueryInfoDetail(pCmd, i);
H
hjxilinx 已提交
611

612 613 614
        int32_t ret = tscFieldInfoCompare(&pQueryInfo1->fieldsInfo, &pQueryInfo2->fieldsInfo);
        if (ret != 0) {
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
615
        }
616
      }
617

618
      pCmd->parseFinished = 1;
619
      return TSDB_CODE_SUCCESS;  // do not build query message here
620
    }
H
hzcheng 已提交
621

622 623 624
    case TSDB_SQL_ALTER_TABLE: {
      if ((code = setAlterTableInfo(pSql, pInfo)) != TSDB_CODE_SUCCESS) {
        return code;
H
hzcheng 已提交
625 626 627 628 629
      }

      break;
    }

630 631 632
    case TSDB_SQL_KILL_QUERY:
    case TSDB_SQL_KILL_STREAM:
    case TSDB_SQL_KILL_CONNECTION: {
633
      if ((code = setKillInfo(pSql, pInfo, pInfo->type)) != TSDB_CODE_SUCCESS) {
H
hzcheng 已提交
634 635 636 637 638 639 640
        return code;
      }

      break;
    }

    default:
641
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "not support sql expression");
H
hzcheng 已提交
642 643
  }

dengyihao's avatar
dengyihao 已提交
644
  pSql->cmd.parseFinished = 1;
645
  return tscBuildMsg[pCmd->command](pSql, pInfo);
H
hzcheng 已提交
646 647
}

S
slguan 已提交
648 649 650 651
/*
 * if the top/bottom exists, only tags columns, tbname column, and primary timestamp column
 * are available.
 */
652
static bool isTopBottomQuery(SQueryInfo* pQueryInfo) {
H
hjxilinx 已提交
653 654 655
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  
  for (int32_t i = 0; i < size; ++i) {
656
    int32_t functionId = tscSqlExprGet(pQueryInfo, i)->functionId;
S
slguan 已提交
657 658 659 660

    if (functionId == TSDB_FUNC_TOP || functionId == TSDB_FUNC_BOTTOM) {
      return true;
    }
H
hzcheng 已提交
661 662
  }

S
slguan 已提交
663
  return false;
H
hzcheng 已提交
664 665
}

666
int32_t parseIntervalClause(SSqlObj* pSql, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql) {
S
slguan 已提交
667 668
  const char* msg1 = "invalid query expression";
  const char* msg2 = "interval cannot be less than 10 ms";
669
  const char* msg3 = "sliding cannot be used without interval";
670
  const char* msg4 = "top/bottom query does not support order by value in interval query";
671

672 673
  SSqlCmd* pCmd = &pSql->cmd;

H
hjxilinx 已提交
674
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hjxilinx 已提交
675
  STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);
H
hjxilinx 已提交
676
  
H
hjxilinx 已提交
677
  if (pQuerySql->interval.type == 0 || pQuerySql->interval.n == 0) {
678 679 680
    if (pQuerySql->sliding.n > 0) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }
H
hzcheng 已提交
681 682 683
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
684 685 686 687 688
  // orderby column not set yet, set it to be the primary timestamp column
  if (pQueryInfo->order.orderColId == INT32_MIN) {
    pQueryInfo->order.orderColId = PRIMARYKEY_TIMESTAMP_COL_INDEX;
  }

H
hzcheng 已提交
689
  // interval is not null
690
  SStrToken* t = &pQuerySql->interval;
691
  if (parseNatualDuration(t->z, t->n, &pQueryInfo->interval.interval, &pQueryInfo->interval.intervalUnit) != TSDB_CODE_SUCCESS) {
692
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
693 694
  }

695
  if (pQueryInfo->interval.intervalUnit != 'n' && pQueryInfo->interval.intervalUnit != 'y') {
B
Bomin Zhang 已提交
696 697
    // if the unit of time window value is millisecond, change the value from microsecond
    if (tinfo.precision == TSDB_TIME_PRECISION_MILLI) {
698
      pQueryInfo->interval.interval = pQueryInfo->interval.interval / 1000;
B
Bomin Zhang 已提交
699
    }
H
hzcheng 已提交
700

B
Bomin Zhang 已提交
701
    // interval cannot be less than 10 milliseconds
702
    if (pQueryInfo->interval.interval < tsMinIntervalTime) {
B
Bomin Zhang 已提交
703 704
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    }
H
hzcheng 已提交
705 706 707
  }

  // for top/bottom + interval query, we do not add additional timestamp column in the front
708
  if (isTopBottomQuery(pQueryInfo)) {
709 710 711 712
    if (parseOffsetClause(pCmd, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
      return TSDB_CODE_TSC_INVALID_SQL;
    }

713
    if (parseSlidingClause(pSql, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
714
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
715
    }
H
hjxilinx 已提交
716

717 718 719 720 721
    int32_t colId = pQueryInfo->order.orderColId;
    if (pQueryInfo->interval.interval > 0 && colId != PRIMARYKEY_TIMESTAMP_COL_INDEX) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
    }

H
hzcheng 已提交
722 723 724
    return TSDB_CODE_SUCCESS;
  }

H
hjxilinx 已提交
725 726 727
  /*
   * check invalid SQL:
   * select count(tbname)/count(tag1)/count(tag2) from super_table_name interval(1d);
H
hjxilinx 已提交
728
   */
H
hjxilinx 已提交
729 730
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t i = 0; i < size; ++i) {
731
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
732
    if (pExpr->functionId == TSDB_FUNC_COUNT && TSDB_COL_IS_TAG(pExpr->colInfo.flag)) {
733
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
734 735
    }
  }
H
hjxilinx 已提交
736

H
hjxilinx 已提交
737 738 739
  /*
   * check invalid SQL:
   * select tbname, tags_fields from super_table_name interval(1s)
H
hjxilinx 已提交
740
   */
741
  if (tscQueryTags(pQueryInfo) && pQueryInfo->interval.interval > 0) {
742
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hjxilinx 已提交
743
  }
S
slguan 已提交
744 745

  // need to add timestamp column in result set, if interval is existed
746
  uint64_t uid = tscSqlExprGet(pQueryInfo, 0)->uid;
S
slguan 已提交
747 748

  int32_t tableIndex = COLUMN_INDEX_INITIAL_VAL;
749
  for (int32_t i = 0; i < pQueryInfo->numOfTables; ++i) {
H
hjxilinx 已提交
750
    pTableMetaInfo = tscGetMetaInfo(pQueryInfo, i);
751
    if (pTableMetaInfo->pTableMeta->id.uid == uid) {
S
slguan 已提交
752 753 754 755 756 757
      tableIndex = i;
      break;
    }
  }

  if (tableIndex == COLUMN_INDEX_INITIAL_VAL) {
758
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
759 760
  }

H
Haojun Liao 已提交
761 762
  SSchema s = {.bytes = TSDB_KEYSIZE, .type = TSDB_DATA_TYPE_TIMESTAMP, .colId = PRIMARYKEY_TIMESTAMP_COL_INDEX};
  tstrncpy(s.name, aAggs[TSDB_FUNC_TS].aName, sizeof(s.name));
763

H
Haojun Liao 已提交
764 765
  SColumnIndex index = {tableIndex, PRIMARYKEY_TIMESTAMP_COL_INDEX};
  tscAddSpecialColumnForSelect(pQueryInfo, 0, TSDB_FUNC_TS, &index, &s, TSDB_COL_NORMAL);
H
hjxilinx 已提交
766

767 768 769 770
  if (parseOffsetClause(pCmd, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
    return TSDB_CODE_TSC_INVALID_SQL;
  }

771
  if (parseSlidingClause(pSql, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
772
    return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
773
  }
H
hjxilinx 已提交
774

H
hjxilinx 已提交
775
  return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
776 777
}

778
int32_t parseOffsetClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql) {
779 780 781 782
  const char* msg1 = "interval offset cannot be negative";
  const char* msg2 = "interval offset should be shorter than interval";
  const char* msg3 = "cannot use 'year' as offset when interval is 'month'";

783 784 785
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
  STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);

786 787 788 789
  SStrToken* t = &pQuerySql->offset;
  if (t->n == 0) {
    pQueryInfo->interval.offsetUnit = pQueryInfo->interval.intervalUnit;
    pQueryInfo->interval.offset = 0;
790 791 792
    return TSDB_CODE_SUCCESS;
  }

793
  if (parseNatualDuration(t->z, t->n, &pQueryInfo->interval.offset, &pQueryInfo->interval.offsetUnit) != TSDB_CODE_SUCCESS) {
794
    return TSDB_CODE_TSC_INVALID_SQL;
795 796
  }

797
  if (pQueryInfo->interval.offset < 0) {
798 799 800
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
  }

801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823
  if (pQueryInfo->interval.offsetUnit != 'n' && pQueryInfo->interval.offsetUnit != 'y') {
    // if the unit of time window value is millisecond, change the value from microsecond
    if (tinfo.precision == TSDB_TIME_PRECISION_MILLI) {
      pQueryInfo->interval.offset = pQueryInfo->interval.offset / 1000;
    }
    if (pQueryInfo->interval.intervalUnit != 'n' && pQueryInfo->interval.intervalUnit != 'y') {
      if (pQueryInfo->interval.offset >= pQueryInfo->interval.interval) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
      }
    }
  } else if (pQueryInfo->interval.offsetUnit == pQueryInfo->interval.intervalUnit) {
    if (pQueryInfo->interval.offset >= pQueryInfo->interval.interval) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    }
  } else if (pQueryInfo->interval.intervalUnit == 'n' && pQueryInfo->interval.offsetUnit == 'y') {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
  } else if (pQueryInfo->interval.intervalUnit == 'y' && pQueryInfo->interval.offsetUnit == 'n') {
    if (pQueryInfo->interval.interval * 12 <= pQueryInfo->interval.offset) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    }
  } else {
    // TODO: offset should be shorter than interval, but how to check
    // conflicts like 30days offset and 1 month interval
824 825 826 827 828
  }

  return TSDB_CODE_SUCCESS;
}

829
int32_t parseSlidingClause(SSqlObj* pSql, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql) {
830 831
  const char* msg0 = "sliding value too small";
  const char* msg1 = "sliding value no larger than the interval value";
H
Haojun Liao 已提交
832
  const char* msg2 = "sliding value can not less than 1% of interval value";
833
  const char* msg3 = "does not support sliding when interval is natural month/year";
H
Haojun Liao 已提交
834
//  const char* msg4 = "sliding not support yet in ordinary query";
H
Haojun Liao 已提交
835 836

  const static int32_t INTERVAL_SLIDING_FACTOR = 100;
837
  SSqlCmd* pCmd = &pSql->cmd;
H
hzcheng 已提交
838

H
hjxilinx 已提交
839
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hjxilinx 已提交
840
  STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);
H
hzcheng 已提交
841

842
  SStrToken* pSliding = &pQuerySql->sliding;
B
Bomin Zhang 已提交
843
  if (pSliding->n == 0) {
844 845
    pQueryInfo->interval.slidingUnit = pQueryInfo->interval.intervalUnit;
    pQueryInfo->interval.sliding = pQueryInfo->interval.interval;
B
Bomin Zhang 已提交
846 847
    return TSDB_CODE_SUCCESS;
  }
H
hzcheng 已提交
848

849
  if (pQueryInfo->interval.intervalUnit == 'n' || pQueryInfo->interval.intervalUnit == 'y') {
B
Bomin Zhang 已提交
850 851
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
  }
H
hzcheng 已提交
852

853
  parseAbsoluteDuration(pSliding->z, pSliding->n, &pQueryInfo->interval.sliding);
B
Bomin Zhang 已提交
854
  if (tinfo.precision == TSDB_TIME_PRECISION_MILLI) {
855
    pQueryInfo->interval.sliding /= 1000;
B
Bomin Zhang 已提交
856 857
  }

858
  if (pQueryInfo->interval.sliding < tsMinSlidingTime) {
B
Bomin Zhang 已提交
859 860 861
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
  }

862
  if (pQueryInfo->interval.sliding > pQueryInfo->interval.interval) {
B
Bomin Zhang 已提交
863
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
864 865
  }

866
  if ((pQueryInfo->interval.interval != 0) && (pQueryInfo->interval.interval/pQueryInfo->interval.sliding > INTERVAL_SLIDING_FACTOR)) {
H
Haojun Liao 已提交
867 868 869
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
  }

H
Haojun Liao 已提交
870 871 872
//  if (pQueryInfo->interval.sliding != pQueryInfo->interval.interval && pSql->pStream == NULL) {
//    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
//  }
873

H
hzcheng 已提交
874 875 876
  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
877
int32_t tscSetTableFullName(STableMetaInfo* pTableMetaInfo, SStrToken* pzTableName, SSqlObj* pSql) {
Y
TD-1039  
yihaoDeng 已提交
878
  const char* msg1 = "name too long";
H
hzcheng 已提交
879

880 881
  SSqlCmd* pCmd = &pSql->cmd;
  int32_t  code = TSDB_CODE_SUCCESS;
S
slguan 已提交
882

H
hjxilinx 已提交
883
  // backup the old name in pTableMetaInfo
H
Haojun Liao 已提交
884 885
  char oldName[TSDB_TABLE_FNAME_LEN] = {0};
  tstrncpy(oldName, pTableMetaInfo->name, tListLen(oldName));
H
hjxilinx 已提交
886

H
Haojun Liao 已提交
887
  if (hasSpecifyDB(pzTableName)) { // db has been specified in sql string so we ignore current db path
H
hjxilinx 已提交
888
    code = setObjFullName(pTableMetaInfo->name, getAccountId(pSql), NULL, pzTableName, NULL);
H
Haojun Liao 已提交
889 890 891
    if (code != 0) {
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
    }
H
Haojun Liao 已提交
892
  } else {  // get current DB name first, and then set it into path
H
Haojun Liao 已提交
893
    SStrToken t = {0};
H
hzcheng 已提交
894
    getCurrentDBName(pSql, &t);
H
Haojun Liao 已提交
895
    if (t.n == 0) {  // current database not available or not specified
896
      code = TSDB_CODE_TSC_DB_NOT_SELECTED;
H
Haojun Liao 已提交
897 898 899 900 901
    } else {
      code = setObjFullName(pTableMetaInfo->name, NULL, &t, pzTableName, NULL);
      if (code != 0) {
        invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
      }
H
Haojun Liao 已提交
902
    }
H
hzcheng 已提交
903
  }
H
Haojun Liao 已提交
904

S
slguan 已提交
905
  if (code != TSDB_CODE_SUCCESS) {
906 907
    return code;
  }
H
hjxilinx 已提交
908

909
  /*
H
Haojun Liao 已提交
910
   * the old name exists and is not equalled to the new name. Release the table meta
911 912
   * that are corresponding to the old name for the new table name.
   */
H
Haojun Liao 已提交
913
  if (strlen(oldName) > 0 && strncasecmp(oldName, pTableMetaInfo->name, tListLen(pTableMetaInfo->name)) != 0) {
914
    tscClearTableMetaInfo(pTableMetaInfo);
915
  }
H
hjxilinx 已提交
916

917
  return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
918 919
}

H
Haojun Liao 已提交
920
static bool validateTableColumnInfo(SArray* pFieldList, SSqlCmd* pCmd) {
H
hzcheng 已提交
921 922
  assert(pFieldList != NULL);

923 924 925 926 927 928 929
  const char* msg = "illegal number of columns";
  const char* msg1 = "first column must be timestamp";
  const char* msg2 = "row length exceeds max length";
  const char* msg3 = "duplicated column names";
  const char* msg4 = "invalid data types";
  const char* msg5 = "invalid binary/nchar column length";
  const char* msg6 = "invalid column name";
H
hzcheng 已提交
930 931

  // number of fields no less than 2
H
Haojun Liao 已提交
932 933
  size_t numOfCols = taosArrayGetSize(pFieldList);
  if (numOfCols <= 1 || numOfCols > TSDB_MAX_COLUMNS) {
934
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
935 936 937 938
    return false;
  }

  // first column must be timestamp
H
Haojun Liao 已提交
939 940
  TAOS_FIELD* pField = taosArrayGet(pFieldList, 0);
  if (pField->type != TSDB_DATA_TYPE_TIMESTAMP) {
941
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
942 943 944 945
    return false;
  }

  int32_t nLen = 0;
H
Haojun Liao 已提交
946 947
  for (int32_t i = 0; i < numOfCols; ++i) {
    pField = taosArrayGet(pFieldList, i);
B
Bomin Zhang 已提交
948 949

    if (pField->bytes == 0) {
dengyihao's avatar
dengyihao 已提交
950 951 952
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
      return false;
    }
H
hzcheng 已提交
953

954
    if (!isValidDataType(pField->type)) {
955
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
H
hzcheng 已提交
956 957 958 959 960
      return false;
    }

    if ((pField->type == TSDB_DATA_TYPE_BINARY && (pField->bytes <= 0 || pField->bytes > TSDB_MAX_BINARY_LEN)) ||
        (pField->type == TSDB_DATA_TYPE_NCHAR && (pField->bytes <= 0 || pField->bytes > TSDB_MAX_NCHAR_LEN))) {
961
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
962 963 964 965
      return false;
    }

    if (validateColumnName(pField->name) != TSDB_CODE_SUCCESS) {
966
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
967 968 969
      return false;
    }

B
Bomin Zhang 已提交
970
    // field name must be unique
H
Haojun Liao 已提交
971
    if (has(pFieldList, i + 1, pField->name) == true) {
972
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
973 974
      return false;
    }
B
Bomin Zhang 已提交
975 976 977 978 979 980 981 982

    nLen += pField->bytes;
  }

  // max row length must be less than TSDB_MAX_BYTES_PER_ROW
  if (nLen > TSDB_MAX_BYTES_PER_ROW) {
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    return false;
H
hzcheng 已提交
983 984 985 986 987
  }

  return true;
}

H
Haojun Liao 已提交
988
static bool validateTagParams(SArray* pTagsList, SArray* pFieldList, SSqlCmd* pCmd) {
H
hzcheng 已提交
989 990
  assert(pTagsList != NULL);

991 992 993 994 995 996 997
  const char* msg1 = "invalid number of tag columns";
  const char* msg2 = "tag length too long";
  const char* msg3 = "duplicated column names";
  const char* msg4 = "timestamp not allowed in tags";
  const char* msg5 = "invalid data type in tags";
  const char* msg6 = "invalid tag name";
  const char* msg7 = "invalid binary/nchar tag length";
H
hzcheng 已提交
998 999

  // number of fields at least 1
H
Haojun Liao 已提交
1000 1001
  size_t numOfTags = taosArrayGetSize(pTagsList);
  if (numOfTags < 1 || numOfTags > TSDB_MAX_TAGS) {
1002
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1003 1004 1005 1006
    return false;
  }

  /* timestamp in tag is not allowed */
H
Haojun Liao 已提交
1007 1008 1009 1010
  for (int32_t i = 0; i < numOfTags; ++i) {
    TAOS_FIELD* p = taosArrayGet(pTagsList, i);

    if (p->type == TSDB_DATA_TYPE_TIMESTAMP) {
1011
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
H
hzcheng 已提交
1012 1013 1014
      return false;
    }

1015
    if (!isValidDataType(p->type)) {
1016
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
1017 1018 1019
      return false;
    }

H
Haojun Liao 已提交
1020 1021
    if ((p->type == TSDB_DATA_TYPE_BINARY && p->bytes <= 0) ||
        (p->type == TSDB_DATA_TYPE_NCHAR && p->bytes <= 0)) {
1022
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
H
hzcheng 已提交
1023 1024 1025
      return false;
    }

H
Haojun Liao 已提交
1026
    if (validateColumnName(p->name) != TSDB_CODE_SUCCESS) {
1027
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
1028 1029 1030
      return false;
    }

H
Haojun Liao 已提交
1031
    if (has(pTagsList, i + 1, p->name) == true) {
1032
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
1033 1034 1035 1036
      return false;
    }
  }

D
fix bug  
dapan1121 已提交
1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063
  int32_t nLen = 0;
  for (int32_t i = 0; i < numOfTags; ++i) {
    TAOS_FIELD* p = taosArrayGet(pTagsList, i);
    if (p->bytes == 0) {
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
      return false;
    }

    nLen += p->bytes;
  }

  // max tag row length must be less than TSDB_MAX_TAGS_LEN
  if (nLen > TSDB_MAX_TAGS_LEN) {
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    return false;
  }

  // field name must be unique
  for (int32_t i = 0; i < numOfTags; ++i) {
    TAOS_FIELD* p = taosArrayGet(pTagsList, i);

    if (has(pFieldList, 0, p->name) == true) {
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
      return false;
    }
  }

H
hzcheng 已提交
1064 1065 1066 1067 1068 1069 1070
  return true;
}

/*
 * tags name /column name is truncated in sql.y
 */
bool validateOneTags(SSqlCmd* pCmd, TAOS_FIELD* pTagField) {
1071 1072 1073 1074 1075 1076
  const char* msg1 = "timestamp not allowed in tags";
  const char* msg2 = "duplicated column names";
  const char* msg3 = "tag length too long";
  const char* msg4 = "invalid tag name";
  const char* msg5 = "invalid binary/nchar tag length";
  const char* msg6 = "invalid data type in tags";
H
hzcheng 已提交
1077

1078
  assert(pCmd->numOfClause == 1);
H
hjxilinx 已提交
1079

1080
  STableMetaInfo* pTableMetaInfo = tscGetTableMetaInfoFromCmd(pCmd, pCmd->clauseIndex, 0);
H
hjxilinx 已提交
1081
  STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;
H
hzcheng 已提交
1082

H
hjxilinx 已提交
1083 1084 1085
  int32_t numOfTags = tscGetNumOfTags(pTableMeta);
  int32_t numOfCols = tscGetNumOfColumns(pTableMeta);
  
H
hzcheng 已提交
1086
  // no more than 6 tags
H
hjxilinx 已提交
1087
  if (numOfTags == TSDB_MAX_TAGS) {
H
hzcheng 已提交
1088 1089 1090
    char msg[128] = {0};
    sprintf(msg, "tags no more than %d", TSDB_MAX_TAGS);

1091
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
1092 1093 1094 1095 1096
    return false;
  }

  // no timestamp allowable
  if (pTagField->type == TSDB_DATA_TYPE_TIMESTAMP) {
1097
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1098 1099 1100
    return false;
  }

L
[#1236]  
lihui 已提交
1101
  if ((pTagField->type < TSDB_DATA_TYPE_BOOL) || (pTagField->type > TSDB_DATA_TYPE_NCHAR)) {
1102
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
1103 1104 1105
    return false;
  }

H
hjxilinx 已提交
1106
  SSchema* pTagSchema = tscGetTableTagSchema(pTableMetaInfo->pTableMeta);
H
hzcheng 已提交
1107 1108
  int32_t  nLen = 0;

H
hjxilinx 已提交
1109
  for (int32_t i = 0; i < numOfTags; ++i) {
H
hzcheng 已提交
1110 1111 1112 1113 1114
    nLen += pTagSchema[i].bytes;
  }

  // length less than TSDB_MAX_TASG_LEN
  if (nLen + pTagField->bytes > TSDB_MAX_TAGS_LEN) {
1115
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
1116 1117 1118 1119 1120
    return false;
  }

  // tags name can not be a keyword
  if (validateColumnName(pTagField->name) != TSDB_CODE_SUCCESS) {
1121
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
H
hzcheng 已提交
1122 1123 1124 1125 1126
    return false;
  }

  // binary(val), val can not be equalled to or less than 0
  if ((pTagField->type == TSDB_DATA_TYPE_BINARY || pTagField->type == TSDB_DATA_TYPE_NCHAR) && pTagField->bytes <= 0) {
1127
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
1128 1129 1130 1131
    return false;
  }

  // field name must be unique
H
hjxilinx 已提交
1132
  SSchema* pSchema = tscGetTableSchema(pTableMeta);
H
hzcheng 已提交
1133

H
hjxilinx 已提交
1134
  for (int32_t i = 0; i < numOfTags + numOfCols; ++i) {
B
Bomin Zhang 已提交
1135
    if (strncasecmp(pTagField->name, pSchema[i].name, sizeof(pTagField->name) - 1) == 0) {
1136
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1137 1138 1139 1140 1141 1142 1143 1144
      return false;
    }
  }

  return true;
}

bool validateOneColumn(SSqlCmd* pCmd, TAOS_FIELD* pColField) {
1145 1146 1147 1148 1149 1150
  const char* msg1 = "too many columns";
  const char* msg2 = "duplicated column names";
  const char* msg3 = "column length too long";
  const char* msg4 = "invalid data types";
  const char* msg5 = "invalid column name";
  const char* msg6 = "invalid column length";
H
hzcheng 已提交
1151

1152
  assert(pCmd->numOfClause == 1);
1153
  STableMetaInfo* pTableMetaInfo = tscGetTableMetaInfoFromCmd(pCmd, pCmd->clauseIndex, 0);
H
hjxilinx 已提交
1154 1155 1156 1157 1158
  STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;
  
  int32_t numOfTags = tscGetNumOfTags(pTableMeta);
  int32_t numOfCols = tscGetNumOfColumns(pTableMeta);
  
H
hzcheng 已提交
1159
  // no more max columns
H
hjxilinx 已提交
1160
  if (numOfCols >= TSDB_MAX_COLUMNS || numOfTags + numOfCols >= TSDB_MAX_COLUMNS) {
1161
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1162 1163 1164 1165
    return false;
  }

  if (pColField->type < TSDB_DATA_TYPE_BOOL || pColField->type > TSDB_DATA_TYPE_NCHAR) {
1166
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
H
hzcheng 已提交
1167 1168 1169 1170
    return false;
  }

  if (validateColumnName(pColField->name) != TSDB_CODE_SUCCESS) {
1171
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
1172 1173 1174
    return false;
  }

H
hjxilinx 已提交
1175
  SSchema* pSchema = tscGetTableSchema(pTableMeta);
H
hzcheng 已提交
1176 1177
  int32_t  nLen = 0;

H
hjxilinx 已提交
1178
  for (int32_t i = 0; i < numOfCols; ++i) {
H
hzcheng 已提交
1179 1180 1181 1182
    nLen += pSchema[i].bytes;
  }

  if (pColField->bytes <= 0) {
1183
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
1184 1185 1186 1187 1188
    return false;
  }

  // length less than TSDB_MAX_BYTES_PER_ROW
  if (nLen + pColField->bytes > TSDB_MAX_BYTES_PER_ROW) {
1189
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
1190 1191 1192 1193
    return false;
  }

  // field name must be unique
H
hjxilinx 已提交
1194
  for (int32_t i = 0; i < numOfTags + numOfCols; ++i) {
B
Bomin Zhang 已提交
1195
    if (strncasecmp(pColField->name, pSchema[i].name, sizeof(pColField->name) - 1) == 0) {
1196
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1197 1198 1199 1200 1201 1202 1203 1204
      return false;
    }
  }

  return true;
}

/* is contained in pFieldList or not */
H
Haojun Liao 已提交
1205 1206 1207 1208
static bool has(SArray* pFieldList, int32_t startIdx, const char* name) {
  size_t numOfCols = taosArrayGetSize(pFieldList);
  for (int32_t j = startIdx; j < numOfCols; ++j) {
    TAOS_FIELD* field = taosArrayGet(pFieldList, j);
B
Bomin Zhang 已提交
1209
    if (strncasecmp(name, field->name, sizeof(field->name) - 1) == 0) return true;
H
hzcheng 已提交
1210 1211 1212 1213 1214 1215 1216
  }

  return false;
}

static char* getAccountId(SSqlObj* pSql) { return pSql->pTscObj->acctId; }

H
Haojun Liao 已提交
1217
static void getCurrentDBName(SSqlObj* pSql, SStrToken* pDBToken) {
H
hzcheng 已提交
1218
  pDBToken->z = pSql->pTscObj->db;
S
TD-1057  
Shengliang Guan 已提交
1219
  pDBToken->n = (uint32_t)strlen(pSql->pTscObj->db);
H
hzcheng 已提交
1220 1221 1222
}

/* length limitation, strstr cannot be applied */
H
Haojun Liao 已提交
1223
static bool hasSpecifyDB(SStrToken* pTableName) {
S
TD-1057  
Shengliang Guan 已提交
1224
  for (uint32_t i = 0; i < pTableName->n; ++i) {
H
hzcheng 已提交
1225 1226 1227 1228 1229 1230 1231 1232
    if (pTableName->z[i] == TS_PATH_DELIMITER[0]) {
      return true;
    }
  }

  return false;
}

H
Haojun Liao 已提交
1233
int32_t setObjFullName(char* fullName, const char* account, SStrToken* pDB, SStrToken* tableName, int32_t* xlen) {
H
hzcheng 已提交
1234 1235 1236
  int32_t totalLen = 0;

  if (account != NULL) {
S
TD-1057  
Shengliang Guan 已提交
1237
    int32_t len = (int32_t)strlen(account);
H
hzcheng 已提交
1238 1239 1240 1241 1242 1243 1244
    strcpy(fullName, account);
    fullName[len] = TS_PATH_DELIMITER[0];
    totalLen += (len + 1);
  }

  /* db name is not specified, the tableName dose not include db name */
  if (pDB != NULL) {
Y
TD-1039  
yihaoDeng 已提交
1245
    if (pDB->n >= TSDB_ACCT_LEN + TSDB_DB_NAME_LEN || pDB->n == 0) {
1246
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258
    }

    memcpy(&fullName[totalLen], pDB->z, pDB->n);
    totalLen += pDB->n;
  }

  if (tableName != NULL) {
    if (pDB != NULL) {
      fullName[totalLen] = TS_PATH_DELIMITER[0];
      totalLen += 1;

      /* here we only check the table name length limitation */
H
Haojun Liao 已提交
1259
      if (!tscValidateTableNameLength(tableName->n)) {
1260
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1261 1262 1263
      }
    } else {  // pDB == NULL, the db prefix name is specified in tableName
      /* the length limitation includes tablename + dbname + sep */
B
Bomin Zhang 已提交
1264
      if (tableName->n >= TSDB_TABLE_NAME_LEN + TSDB_DB_NAME_LEN) {
1265
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1266 1267 1268 1269 1270 1271 1272 1273 1274 1275
      }
    }

    memcpy(&fullName[totalLen], tableName->z, tableName->n);
    totalLen += tableName->n;
  }

  if (xlen != NULL) {
    *xlen = totalLen;
  }
S
slguan 已提交
1276

H
Haojun Liao 已提交
1277
  if (totalLen < TSDB_TABLE_FNAME_LEN) {
S
slguan 已提交
1278 1279 1280
    fullName[totalLen] = 0;
  }

H
Haojun Liao 已提交
1281
  return (totalLen < TSDB_TABLE_FNAME_LEN) ? TSDB_CODE_SUCCESS : TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1282 1283
}

Y
TD-1688  
yihaoDeng 已提交
1284 1285 1286 1287
static void tscInsertPrimaryTSSourceColumn(SQueryInfo* pQueryInfo, SColumnIndex* pIndex) {
  SColumnIndex tsCol = {.tableIndex = pIndex->tableIndex, .columnIndex = PRIMARYKEY_TIMESTAMP_COL_INDEX};
  tscColumnListInsert(pQueryInfo->colList, &tsCol);
}
H
Haojun Liao 已提交
1288

H
Haojun Liao 已提交
1289
static int32_t handleArithmeticExpr(SSqlCmd* pCmd, int32_t clauseIndex, int32_t exprIndex, tSqlExprItem* pItem) {
1290
  const char* msg1 = "invalid column name, illegal column type, or columns in arithmetic expression from two tables";
1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319
  const char* msg2 = "invalid arithmetic expression in select clause";
  const char* msg3 = "tag columns can not be used in arithmetic expression";
  const char* msg4 = "columns from different table mixed up in arithmetic expression";

  // arithmetic function in select clause
  SQueryInfo* pQueryInfo = tscGetQueryInfoDetail(pCmd, clauseIndex);

  SColumnList columnList = {0};
  int32_t     arithmeticType = NON_ARITHMEIC_EXPR;

  if (validateArithmeticSQLExpr(pCmd, pItem->pNode, pQueryInfo, &columnList, &arithmeticType) != TSDB_CODE_SUCCESS) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
  }

  int32_t tableIndex = columnList.ids[0].tableIndex;
  if (arithmeticType == NORMAL_ARITHMETIC) {
    pQueryInfo->type |= TSDB_QUERY_TYPE_PROJECTION_QUERY;

    // all columns in arithmetic expression must belong to the same table
    for (int32_t f = 1; f < columnList.num; ++f) {
      if (columnList.ids[f].tableIndex != tableIndex) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
      }
    }

    // expr string is set as the parameter of function
    SColumnIndex index = {.tableIndex = tableIndex};

    SSqlExpr* pExpr = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_ARITHM, &index, TSDB_DATA_TYPE_DOUBLE, sizeof(double),
H
Haojun Liao 已提交
1320
                                       getNewResColId(pQueryInfo), sizeof(double), false);
1321

H
Haojun Liao 已提交
1322 1323 1324
    char* name = (pItem->aliasName != NULL)? pItem->aliasName:pItem->pNode->token.z;
    size_t len = MIN(sizeof(pExpr->aliasName), pItem->pNode->token.n + 1);
    tstrncpy(pExpr->aliasName, name, len);
1325 1326 1327 1328

    tExprNode* pNode = NULL;
    SArray* colList = taosArrayInit(10, sizeof(SColIndex));

H
Haojun Liao 已提交
1329
    int32_t ret = exprTreeFromSqlExpr(pCmd, &pNode, pItem->pNode, pQueryInfo, colList, NULL);
1330
    if (ret != TSDB_CODE_SUCCESS) {
1331 1332
      taosArrayDestroy(colList);
      tExprTreeDestroy(&pNode, NULL);
1333 1334 1335
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    }

H
Haojun Liao 已提交
1336
    // check for if there is a tag in the arithmetic express
1337 1338 1339
    size_t numOfNode = taosArrayGetSize(colList);
    for(int32_t k = 0; k < numOfNode; ++k) {
      SColIndex* pIndex = taosArrayGet(colList, k);
1340 1341
      if (TSDB_COL_IS_TAG(pIndex->flag)) {
        tExprTreeDestroy(&pNode, NULL);
1342 1343
        taosArrayDestroy(colList);
        tExprTreeDestroy(&pNode, NULL);
1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
      }
    }

    SBufferWriter bw = tbufInitWriter(NULL, false);

    TRY(0) {
        exprTreeToBinary(&bw, pNode);
      } CATCH(code) {
        tbufCloseWriter(&bw);
        UNUSED(code);
        // TODO: other error handling
      } END_TRY

H
Haojun Liao 已提交
1358
    len = tbufTell(&bw);
H
Haojun Liao 已提交
1359
    char* c = tbufGetData(&bw, false);
1360 1361

    // set the serialized binary string as the parameter of arithmetic expression
H
Haojun Liao 已提交
1362
    addExprParams(pExpr, c, TSDB_DATA_TYPE_BINARY, (int32_t)len);
1363
    insertResultField(pQueryInfo, exprIndex, &columnList, sizeof(double), TSDB_DATA_TYPE_DOUBLE, pExpr->aliasName, pExpr);
H
Haojun Liao 已提交
1364

Y
TD-1688  
yihaoDeng 已提交
1365 1366
    // add ts column
    tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
1367

H
Haojun Liao 已提交
1368
    tbufCloseWriter(&bw);
1369 1370 1371 1372 1373 1374
    taosArrayDestroy(colList);
    tExprTreeDestroy(&pNode, NULL);
  } else {
    columnList.num = 0;
    columnList.ids[0] = (SColumnIndex) {0, 0};

H
Haojun Liao 已提交
1375 1376 1377 1378 1379 1380 1381
    char aliasName[TSDB_COL_NAME_LEN] = {0};
    if (pItem->aliasName != NULL) {
      tstrncpy(aliasName, pItem->aliasName, TSDB_COL_NAME_LEN);
    } else {
      int32_t nameLen = MIN(TSDB_COL_NAME_LEN, pItem->pNode->token.n + 1);
      tstrncpy(aliasName, pItem->pNode->token.z, nameLen);
    }
H
Haojun Liao 已提交
1382

H
Haojun Liao 已提交
1383
    insertResultField(pQueryInfo, exprIndex, &columnList, sizeof(double), TSDB_DATA_TYPE_DOUBLE, aliasName, NULL);
1384 1385

    int32_t slot = tscNumOfFields(pQueryInfo) - 1;
H
Haojun Liao 已提交
1386
    SInternalField* pInfo = tscFieldInfoGetInternalField(&pQueryInfo->fieldsInfo, slot);
1387 1388 1389 1390 1391

    if (pInfo->pSqlExpr == NULL) {
      SExprInfo* pArithExprInfo = calloc(1, sizeof(SExprInfo));

      // arithmetic expression always return result in the format of double float
H
Haojun Liao 已提交
1392
      pArithExprInfo->bytes      = sizeof(double);
1393
      pArithExprInfo->interBytes = sizeof(double);
H
Haojun Liao 已提交
1394
      pArithExprInfo->type       = TSDB_DATA_TYPE_DOUBLE;
1395

H
Haojun Liao 已提交
1396 1397 1398 1399
      pArithExprInfo->base.functionId = TSDB_FUNC_ARITHM;
      pArithExprInfo->base.numOfParams = 1;
      pArithExprInfo->base.resColId = getNewResColId(pQueryInfo);

H
Haojun Liao 已提交
1400
      int32_t ret = exprTreeFromSqlExpr(pCmd, &pArithExprInfo->pExpr, pItem->pNode, pQueryInfo, NULL, &pArithExprInfo->uid);
1401 1402 1403 1404 1405 1406 1407
      if (ret != TSDB_CODE_SUCCESS) {
        tExprTreeDestroy(&pArithExprInfo->pExpr, NULL);
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "invalid expression in select clause");
      }

      pInfo->pArithExprInfo = pArithExprInfo;
    }
H
Haojun Liao 已提交
1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418

    SBufferWriter bw = tbufInitWriter(NULL, false);

    TRY(0) {
      exprTreeToBinary(&bw, pInfo->pArithExprInfo->pExpr);
    } CATCH(code) {
      tbufCloseWriter(&bw);
      UNUSED(code);
      // TODO: other error handling
    } END_TRY

H
Haojun Liao 已提交
1419 1420 1421 1422 1423 1424
    SSqlFuncMsg* pFuncMsg = &pInfo->pArithExprInfo->base;
    pFuncMsg->arg[0].argBytes = (int16_t) tbufTell(&bw);
    pFuncMsg->arg[0].argValue.pz = tbufGetData(&bw, true);
    pFuncMsg->arg[0].argType = TSDB_DATA_TYPE_BINARY;

//    tbufCloseWriter(&bw); // TODO there is a memory leak
1425 1426 1427 1428 1429
  }

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
1430
static void addProjectQueryCol(SQueryInfo* pQueryInfo, int32_t startPos, SColumnIndex* pIndex, tSqlExprItem* pItem) {
H
Haojun Liao 已提交
1431
  SSqlExpr* pExpr = doAddProjectCol(pQueryInfo, pIndex->columnIndex, pIndex->tableIndex);
H
Haojun Liao 已提交
1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452

  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, pIndex->tableIndex);
  STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;

  SSchema* pSchema = tscGetTableColumnSchema(pTableMeta, pIndex->columnIndex);

  char* colName = (pItem->aliasName == NULL) ? pSchema->name : pItem->aliasName;
  tstrncpy(pExpr->aliasName, colName, sizeof(pExpr->aliasName));

  SColumnList ids = {0};
  ids.num = 1;
  ids.ids[0] = *pIndex;

  if (pIndex->columnIndex == TSDB_TBNAME_COLUMN_INDEX || pIndex->columnIndex == TSDB_UD_COLUMN_INDEX ||
      pIndex->columnIndex >= tscGetNumOfColumns(pTableMeta)) {
    ids.num = 0;
  }

  insertResultField(pQueryInfo, startPos, &ids, pExpr->resBytes, (int8_t)pExpr->resType, pExpr->aliasName, pExpr);
}

H
Haojun Liao 已提交
1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468
static void addPrimaryTsColIntoResult(SQueryInfo* pQueryInfo) {
  // primary timestamp column has been added already
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t i = 0; i < size; ++i) {
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
    if (pExpr->functionId == TSDB_FUNC_PRJ && pExpr->colInfo.colId == PRIMARYKEY_TIMESTAMP_COL_INDEX) {
      return;
    }
  }


  // set the constant column value always attached to first table.
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
  SSchema* pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, PRIMARYKEY_TIMESTAMP_COL_INDEX);

  // add the timestamp column into the output columns
H
Haojun Liao 已提交
1469
  SColumnIndex index = {0};  // primary timestamp column info
H
Haojun Liao 已提交
1470 1471 1472
  int32_t numOfCols = (int32_t)tscSqlExprNumOfExprs(pQueryInfo);
  tscAddSpecialColumnForSelect(pQueryInfo, numOfCols, TSDB_FUNC_PRJ, &index, pSchema, TSDB_COL_NORMAL);

H
Haojun Liao 已提交
1473
  SInternalField* pSupInfo = tscFieldInfoGetInternalField(&pQueryInfo->fieldsInfo, numOfCols);
H
Haojun Liao 已提交
1474 1475 1476 1477 1478
  pSupInfo->visible = false;

  pQueryInfo->type |= TSDB_QUERY_TYPE_PROJECTION_QUERY;
}

D
fix bug  
dapan1121 已提交
1479
int32_t parseSelectClause(SSqlCmd* pCmd, int32_t clauseIndex, tSQLExprList* pSelection, bool isSTable, bool joinQuery, bool intervalQuery) {
H
hzcheng 已提交
1480 1481
  assert(pSelection != NULL && pCmd != NULL);

1482 1483
  const char* msg2 = "functions can not be mixed up";
  const char* msg3 = "not support query expression";
H
hjxilinx 已提交
1484
  const char* msg5 = "invalid function name";
H
hjxilinx 已提交
1485

1486
  SQueryInfo* pQueryInfo = tscGetQueryInfoDetail(pCmd, clauseIndex);
H
Haojun Liao 已提交
1487

1488 1489 1490
  if (pQueryInfo->colList == NULL) {
    pQueryInfo->colList = taosArrayInit(4, POINTER_BYTES);
  }
H
Haojun Liao 已提交
1491

H
hzcheng 已提交
1492
  for (int32_t i = 0; i < pSelection->nExpr; ++i) {
S
Shengliang Guan 已提交
1493
    int32_t outputIndex = (int32_t)tscSqlExprNumOfExprs(pQueryInfo);
H
Haojun Liao 已提交
1494
    tSqlExprItem* pItem = &pSelection->a[i];
H
hzcheng 已提交
1495

S
slguan 已提交
1496
    // project on all fields
H
Haojun Liao 已提交
1497 1498
    int32_t optr = pItem->pNode->nSQLOptr;

1499
    if (optr == TK_ALL || optr == TK_ID || optr == TK_STRING || optr == TK_INTEGER || optr == TK_FLOAT) {
S
slguan 已提交
1500
      // it is actually a function, but the function name is invalid
H
hzcheng 已提交
1501
      if (pItem->pNode->nSQLOptr == TK_ID && (pItem->pNode->colInfo.z == NULL && pItem->pNode->colInfo.n == 0)) {
H
hjxilinx 已提交
1502
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
1503 1504
      }

S
slguan 已提交
1505
      // select table_name1.field_name1, table_name2.field_name2  from table_name1, table_name2
1506
      if (addProjectionExprAndResultField(pCmd, pQueryInfo, pItem) != TSDB_CODE_SUCCESS) {
1507
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1508
      }
1509
    } else if (pItem->pNode->nSQLOptr >= TK_COUNT && pItem->pNode->nSQLOptr <= TK_TBID) {
S
slguan 已提交
1510
      // sql function in selection clause, append sql function info in pSqlCmd structure sequentially
1511
      if (addExprAndResultField(pCmd, pQueryInfo, outputIndex, pItem, true) != TSDB_CODE_SUCCESS) {
1512
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1513 1514 1515
      }

    } else if (pItem->pNode->nSQLOptr >= TK_PLUS && pItem->pNode->nSQLOptr <= TK_REM) {
1516 1517 1518
      int32_t code = handleArithmeticExpr(pCmd, clauseIndex, i, pItem);
      if (code != TSDB_CODE_SUCCESS) {
        return code;
H
hzcheng 已提交
1519 1520
      }
    } else {
1521
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
1522 1523
    }

H
hjxilinx 已提交
1524
    if (pQueryInfo->fieldsInfo.numOfOutput > TSDB_MAX_COLUMNS) {
1525
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1526 1527 1528
    }
  }

1529 1530 1531
  // there is only one user-defined column in the final result field, add the timestamp column.
  size_t numOfSrcCols = taosArrayGetSize(pQueryInfo->colList);
  if (numOfSrcCols <= 0 && !tscQueryTags(pQueryInfo)) {
H
Haojun Liao 已提交
1532
    addPrimaryTsColIntoResult(pQueryInfo);
1533 1534
  }

D
fix bug  
dapan1121 已提交
1535
  if (!functionCompatibleCheck(pQueryInfo, joinQuery, intervalQuery)) {
1536
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1537 1538
  }

H
Haojun Liao 已提交
1539 1540
  /*
   * transfer sql functions that need secondary merge into another format
1541
   * in dealing with super table queries such as: count/first/last
H
Haojun Liao 已提交
1542
   */
1543
  if (isSTable) {
H
hjxilinx 已提交
1544
    tscTansformSQLFuncForSTableQuery(pQueryInfo);
H
hzcheng 已提交
1545

1546
    if (hasUnsupportFunctionsForSTableQuery(pCmd, pQueryInfo)) {
1547
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1548 1549 1550 1551 1552 1553
    }
  }

  return TSDB_CODE_SUCCESS;
}

H
hjxilinx 已提交
1554 1555
int32_t insertResultField(SQueryInfo* pQueryInfo, int32_t outputIndex, SColumnList* pIdList, int16_t bytes,
    int8_t type, char* fieldName, SSqlExpr* pSqlExpr) {
1556
  
S
slguan 已提交
1557
  for (int32_t i = 0; i < pIdList->num; ++i) {
1558 1559 1560 1561 1562 1563 1564 1565
    int32_t tableId = pIdList->ids[i].tableIndex;
    STableMetaInfo* pTableMetaInfo = pQueryInfo->pTableMetaInfo[tableId];
    
    int32_t numOfCols = tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
    if (pIdList->ids[i].columnIndex >= numOfCols) {
      continue;
    }
    
1566
    tscColumnListInsert(pQueryInfo->colList, &(pIdList->ids[i]));
H
hzcheng 已提交
1567
  }
H
hjxilinx 已提交
1568 1569
  
  TAOS_FIELD f = tscCreateField(type, fieldName, bytes);
H
Haojun Liao 已提交
1570
  SInternalField* pInfo = tscFieldInfoInsert(&pQueryInfo->fieldsInfo, outputIndex, &f);
H
hjxilinx 已提交
1571
  pInfo->pSqlExpr = pSqlExpr;
H
hjxilinx 已提交
1572
  
H
hzcheng 已提交
1573 1574 1575
  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
1576
SSqlExpr* doAddProjectCol(SQueryInfo* pQueryInfo, int32_t colIndex, int32_t tableIndex) {
H
hjxilinx 已提交
1577
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, tableIndex);
H
hjxilinx 已提交
1578 1579 1580
  STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;
  int32_t numOfCols = tscGetNumOfColumns(pTableMeta);
  
1581
  SSchema* pSchema = tscGetTableColumnSchema(pTableMeta, colIndex);
H
hzcheng 已提交
1582

1583
  int16_t functionId = (int16_t)((colIndex >= numOfCols) ? TSDB_FUNC_TAGPRJ : TSDB_FUNC_PRJ);
1584 1585 1586 1587
  SColumnIndex index = {.tableIndex = tableIndex,};
  
  if (functionId == TSDB_FUNC_TAGPRJ) {
    index.columnIndex = colIndex - tscGetNumOfColumns(pTableMeta);
H
hjxilinx 已提交
1588
    tscColumnListInsert(pTableMetaInfo->tagColList, &index);
1589 1590 1591
  } else {
    index.columnIndex = colIndex;
  }
H
Haojun Liao 已提交
1592 1593 1594 1595

  int16_t colId = getNewResColId(pQueryInfo);
  return tscSqlExprAppend(pQueryInfo, functionId, &index, pSchema->type, pSchema->bytes, colId, pSchema->bytes,
                          (functionId == TSDB_FUNC_TAGPRJ));
H
hzcheng 已提交
1596 1597
}

H
Haojun Liao 已提交
1598
SSqlExpr* tscAddSpecialColumnForSelect(SQueryInfo* pQueryInfo, int32_t outputColIndex, int16_t functionId,
S
slguan 已提交
1599
                                  SColumnIndex* pIndex, SSchema* pColSchema, int16_t flag) {
H
Haojun Liao 已提交
1600 1601
  int16_t colId = getNewResColId(pQueryInfo);

H
Haojun Liao 已提交
1602
  SSqlExpr* pExpr = tscSqlExprInsert(pQueryInfo, outputColIndex, functionId, pIndex, pColSchema->type,
H
Haojun Liao 已提交
1603
                                     pColSchema->bytes, colId, pColSchema->bytes, TSDB_COL_IS_TAG(flag));
H
Haojun Liao 已提交
1604
  tstrncpy(pExpr->aliasName, pColSchema->name, sizeof(pExpr->aliasName));
H
hzcheng 已提交
1605

S
slguan 已提交
1606 1607 1608 1609
  SColumnList ids = getColumnList(1, pIndex->tableIndex, pIndex->columnIndex);
  if (TSDB_COL_IS_TAG(flag)) {
    ids.num = 0;
  }
H
hzcheng 已提交
1610

H
hjxilinx 已提交
1611
  insertResultField(pQueryInfo, outputColIndex, &ids, pColSchema->bytes, pColSchema->type, pColSchema->name, pExpr);
S
slguan 已提交
1612 1613

  pExpr->colInfo.flag = flag;
1614 1615
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, pIndex->tableIndex);
  
S
slguan 已提交
1616
  if (TSDB_COL_IS_TAG(flag)) {
H
hjxilinx 已提交
1617
    tscColumnListInsert(pTableMetaInfo->tagColList, pIndex);
S
slguan 已提交
1618
  }
H
Haojun Liao 已提交
1619 1620

  return pExpr;
S
slguan 已提交
1621 1622
}

1623
static int32_t doAddProjectionExprAndResultFields(SQueryInfo* pQueryInfo, SColumnIndex* pIndex, int32_t startPos) {
H
hjxilinx 已提交
1624
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, pIndex->tableIndex);
S
slguan 已提交
1625 1626

  int32_t     numOfTotalColumns = 0;
H
hjxilinx 已提交
1627 1628
  STableMeta* pTableMeta = pTableMetaInfo->pTableMeta;
  SSchema*    pSchema = tscGetTableSchema(pTableMeta);
S
slguan 已提交
1629

H
hjxilinx 已提交
1630
  STableComInfo tinfo = tscGetTableInfo(pTableMeta);
H
hjxilinx 已提交
1631
  
weixin_48148422's avatar
weixin_48148422 已提交
1632
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
hjxilinx 已提交
1633
    numOfTotalColumns = tinfo.numOfColumns + tinfo.numOfTags;
S
slguan 已提交
1634
  } else {
H
hjxilinx 已提交
1635
    numOfTotalColumns = tinfo.numOfColumns;
S
slguan 已提交
1636 1637 1638
  }

  for (int32_t j = 0; j < numOfTotalColumns; ++j) {
H
Haojun Liao 已提交
1639
    SSqlExpr* pExpr = doAddProjectCol(pQueryInfo, j, pIndex->tableIndex);
B
Bomin Zhang 已提交
1640
    tstrncpy(pExpr->aliasName, pSchema[j].name, sizeof(pExpr->aliasName));
S
slguan 已提交
1641 1642 1643 1644

    pIndex->columnIndex = j;
    SColumnList ids = {0};
    ids.ids[0] = *pIndex;
H
hjxilinx 已提交
1645
    ids.num = 1;
S
slguan 已提交
1646

H
hjxilinx 已提交
1647
    insertResultField(pQueryInfo, startPos + j, &ids, pSchema[j].bytes, pSchema[j].type, pSchema[j].name, pExpr);
S
slguan 已提交
1648 1649 1650 1651 1652
  }

  return numOfTotalColumns;
}

H
Haojun Liao 已提交
1653
int32_t addProjectionExprAndResultField(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSqlExprItem* pItem) {
S
slguan 已提交
1654
  const char* msg0 = "invalid column name";
H
hjxilinx 已提交
1655
  const char* msg1 = "tag for normal table query is not allowed";
S
slguan 已提交
1656

1657
  int32_t startPos = (int32_t)tscSqlExprNumOfExprs(pQueryInfo);
H
Haojun Liao 已提交
1658 1659 1660 1661 1662
  int32_t optr = pItem->pNode->nSQLOptr;

  if (optr == TK_ALL) {  // project on all fields
    TSDB_QUERY_SET_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_PROJECTION_QUERY);

S
slguan 已提交
1663
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
1664
    if (getTableIndexByName(&pItem->pNode->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
1665
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
S
slguan 已提交
1666 1667 1668 1669
    }

    // all meters columns are required
    if (index.tableIndex == COLUMN_INDEX_INITIAL_VAL) {  // all table columns are required.
1670
      for (int32_t i = 0; i < pQueryInfo->numOfTables; ++i) {
S
slguan 已提交
1671
        index.tableIndex = i;
1672
        int32_t inc = doAddProjectionExprAndResultFields(pQueryInfo, &index, startPos);
S
slguan 已提交
1673
        startPos += inc;
H
hzcheng 已提交
1674 1675
      }
    } else {
1676
      doAddProjectionExprAndResultFields(pQueryInfo, &index, startPos);
S
slguan 已提交
1677
    }
H
Haojun Liao 已提交
1678 1679 1680

    // add the primary timestamp column even though it is not required by user
    tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
1681
  } else if (optr == TK_STRING || optr == TK_INTEGER || optr == TK_FLOAT) {  // simple column projection query
S
slguan 已提交
1682 1683
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;

H
Haojun Liao 已提交
1684
    // user-specified constant value as a new result column
1685 1686
    index.columnIndex = (pQueryInfo->udColumnId--);
    index.tableIndex = 0;
H
hzcheng 已提交
1687

H
Haojun Liao 已提交
1688
    SSchema colSchema = tGetUserSpecifiedColumnSchema(&pItem->pNode->val, &pItem->pNode->token, pItem->aliasName);
1689 1690
    SSqlExpr* pExpr =
        tscAddSpecialColumnForSelect(pQueryInfo, startPos, TSDB_FUNC_PRJ, &index, &colSchema, TSDB_COL_UDC);
H
hzcheng 已提交
1691

1692 1693 1694 1695 1696
    // NOTE: the first parameter is reserved for the tag column id during join query process.
    pExpr->numOfParams = 2;
    tVariantAssign(&pExpr->param[1], &pItem->pNode->val);
  } else if (optr == TK_ID) {
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
H
Haojun Liao 已提交
1697

1698 1699 1700
    if (getColumnIndexByName(pCmd, &pItem->pNode->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
    }
H
Haojun Liao 已提交
1701

1702 1703 1704 1705 1706 1707
    if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
      SSchema colSchema = tGetTableNameColumnSchema();
      tscAddSpecialColumnForSelect(pQueryInfo, startPos, TSDB_FUNC_TAGPRJ, &index, &colSchema, TSDB_COL_TAG);
    } else {
      STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
      STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;
H
Haojun Liao 已提交
1708

1709 1710
      if (index.columnIndex >= tscGetNumOfColumns(pTableMeta) && UTIL_TABLE_IS_NORMAL_TABLE(pTableMetaInfo)) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1711 1712
      }

1713
      addProjectQueryCol(pQueryInfo, startPos, &index, pItem);
H
Haojun Liao 已提交
1714
      pQueryInfo->type |= TSDB_QUERY_TYPE_PROJECTION_QUERY;
H
hzcheng 已提交
1715
    }
H
Haojun Liao 已提交
1716

1717 1718
    // add the primary timestamp column even though it is not required by user
    tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
H
hzcheng 已提交
1719
  } else {
1720
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1721 1722 1723 1724 1725
  }

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
1726
static int32_t setExprInfoForFunctions(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SSchema* pSchema, SConvertFunc cvtFunc,
1727
                                       const char* name, int32_t resColIdx, SColumnIndex* pColIndex, bool finalResult) {
1728 1729
  const char* msg1 = "not support column types";

H
hzcheng 已提交
1730 1731
  int16_t type = 0;
  int16_t bytes = 0;
Y
TD-1230  
yihaoDeng 已提交
1732
  int32_t functionID = cvtFunc.execFuncId;
H
hzcheng 已提交
1733 1734

  if (functionID == TSDB_FUNC_SPREAD) {
1735
    int32_t t1 = pSchema->type;
1736
    if (t1 == TSDB_DATA_TYPE_BINARY || t1 == TSDB_DATA_TYPE_NCHAR || t1 == TSDB_DATA_TYPE_BOOL) {
1737
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1738 1739 1740 1741 1742 1743
      return -1;
    } else {
      type = TSDB_DATA_TYPE_DOUBLE;
      bytes = tDataTypeDesc[type].nSize;
    }
  } else {
1744 1745
    type = pSchema->type;
    bytes = pSchema->bytes;
H
hzcheng 已提交
1746
  }
Y
TD-1230  
yihaoDeng 已提交
1747
  
H
Haojun Liao 已提交
1748
  SSqlExpr* pExpr = tscSqlExprAppend(pQueryInfo, functionID, pColIndex, type, bytes, getNewResColId(pQueryInfo), bytes, false);
1749
  tstrncpy(pExpr->aliasName, name, tListLen(pExpr->aliasName));
1750

Y
TD-1230  
yihaoDeng 已提交
1751 1752 1753 1754
  if (cvtFunc.originFuncId == TSDB_FUNC_LAST_ROW && cvtFunc.originFuncId != functionID) {
    pExpr->colInfo.flag |= TSDB_COL_NULL;
  }

1755 1756 1757
  // set reverse order scan data blocks for last query
  if (functionID == TSDB_FUNC_LAST) {
    pExpr->numOfParams = 1;
1758
    pExpr->param[0].i64 = TSDB_ORDER_DESC;
1759 1760
    pExpr->param[0].nType = TSDB_DATA_TYPE_INT;
  }
H
hjxilinx 已提交
1761
  
H
hjxilinx 已提交
1762
  // for all queries, the timestamp column needs to be loaded
S
slguan 已提交
1763
  SColumnIndex index = {.tableIndex = pColIndex->tableIndex, .columnIndex = PRIMARYKEY_TIMESTAMP_COL_INDEX};
1764
  tscColumnListInsert(pQueryInfo->colList, &index);
H
hzcheng 已提交
1765

H
Haojun Liao 已提交
1766
  // if it is not in the final result, do not add it
S
slguan 已提交
1767
  SColumnList ids = getColumnList(1, pColIndex->tableIndex, pColIndex->columnIndex);
H
Haojun Liao 已提交
1768
  if (finalResult) {
1769
    insertResultField(pQueryInfo, resColIdx, &ids, bytes, (int8_t)type, pExpr->aliasName, pExpr);
H
Haojun Liao 已提交
1770 1771 1772
  } else {
    tscColumnListInsert(pQueryInfo->colList, &(ids.ids[0]));
  }
H
hzcheng 已提交
1773 1774 1775 1776

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
1777
void setResultColName(char* name, tSqlExprItem* pItem, int32_t functionId, SStrToken* pToken, bool multiCols) {
1778 1779
  if (pItem->aliasName != NULL) {
    tstrncpy(name, pItem->aliasName, TSDB_COL_NAME_LEN);
H
Haojun Liao 已提交
1780
  } else if (multiCols) {
1781 1782 1783 1784
    char uname[TSDB_COL_NAME_LEN] = {0};
    int32_t len = MIN(pToken->n + 1, TSDB_COL_NAME_LEN);
    tstrncpy(uname, pToken->z, len);

1785 1786 1787 1788 1789 1790
    if (tsKeepOriginalColumnName) { // keep the original column name
      tstrncpy(name, uname, TSDB_COL_NAME_LEN);
    } else {
      int32_t size = TSDB_COL_NAME_LEN + tListLen(aAggs[functionId].aName) + 2 + 1;
      char tmp[TSDB_COL_NAME_LEN + tListLen(aAggs[functionId].aName) + 2 + 1] = {0};
      snprintf(tmp, size, "%s(%s)", aAggs[functionId].aName, uname);
H
Haojun Liao 已提交
1791

1792 1793
      tstrncpy(name, tmp, TSDB_COL_NAME_LEN);
    }
H
Haojun Liao 已提交
1794 1795 1796
  } else  { // use the user-input result column name
    int32_t len = MIN(pItem->pNode->token.n + 1, TSDB_COL_NAME_LEN);
    tstrncpy(name, pItem->pNode->token.z, len);
1797 1798 1799
  }
}

H
Haojun Liao 已提交
1800
int32_t addExprAndResultField(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, int32_t colIndex, tSqlExprItem* pItem, bool finalResult) {
H
hjxilinx 已提交
1801
  STableMetaInfo* pTableMetaInfo = NULL;
1802
  int32_t optr = pItem->pNode->nSQLOptr;
S
slguan 已提交
1803

1804
  const char* msg1 = "not support column types";
S
slguan 已提交
1805
  const char* msg2 = "invalid parameters";
1806
  const char* msg3 = "illegal column name";
S
slguan 已提交
1807
  const char* msg4 = "invalid table name";
1808
  const char* msg5 = "parameter is out of range [0, 100]";
S
slguan 已提交
1809
  const char* msg6 = "function applied to tags not allowed";
1810
  const char* msg7 = "normal table can not apply this function";
H
Haojun Liao 已提交
1811
  const char* msg8 = "multi-columns selection does not support alias column name";
B
Bomin Zhang 已提交
1812
  const char* msg9 = "invalid function";
H
Haojun Liao 已提交
1813

H
hzcheng 已提交
1814 1815 1816
  switch (optr) {
    case TK_COUNT: {
        /* more than one parameter for count() function */
H
Haojun Liao 已提交
1817
      if (pItem->pNode->pParam != NULL && pItem->pNode->pParam->nExpr != 1) {
1818
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1819 1820 1821
      }

      int16_t functionID = 0;
H
Haojun Liao 已提交
1822
      if (convertFunctionId(optr, &functionID) != TSDB_CODE_SUCCESS) {
1823
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1824 1825
      }

H
hjxilinx 已提交
1826
      SSqlExpr* pExpr = NULL;
S
slguan 已提交
1827
      SColumnIndex index = COLUMN_INDEX_INITIALIZER;
H
hzcheng 已提交
1828 1829

      if (pItem->pNode->pParam != NULL) {
H
Haojun Liao 已提交
1830
        tSqlExprItem* pParamElem = &pItem->pNode->pParam->a[0];
Y
TD-1370  
yihaoDeng 已提交
1831
        SStrToken* pToken = &pParamElem->pNode->colInfo;
S
TD-1530  
Shengliang Guan 已提交
1832
        int16_t sqlOptr = pParamElem->pNode->nSQLOptr;
Y
TD-1370  
yihaoDeng 已提交
1833 1834 1835 1836 1837
        if ((pToken->z == NULL || pToken->n == 0) 
            && (TK_INTEGER != sqlOptr)) /*select count(1) from table*/ {
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
        } 
        if (sqlOptr == TK_ALL) {
S
slguan 已提交
1838 1839
          // select table.*
          // check if the table name is valid or not
H
Haojun Liao 已提交
1840
          SStrToken tmpToken = pParamElem->pNode->colInfo;
S
slguan 已提交
1841

1842
          if (getTableIndexByName(&tmpToken, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
1843
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
1844 1845 1846 1847
          }

          index = (SColumnIndex){0, PRIMARYKEY_TIMESTAMP_COL_INDEX};
          int32_t size = tDataTypeDesc[TSDB_DATA_TYPE_BIGINT].nSize;
H
Haojun Liao 已提交
1848
          pExpr = tscSqlExprAppend(pQueryInfo, functionID, &index, TSDB_DATA_TYPE_BIGINT, size, getNewResColId(pQueryInfo), size, false);
Y
TD-1370  
yihaoDeng 已提交
1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859
        } else if (sqlOptr == TK_INTEGER) { // select count(1) from table1
          char buf[8] = {0};  
          int64_t val = -1;
          tVariant* pVariant = &pParamElem->pNode->val;
          if (pVariant->nType == TSDB_DATA_TYPE_BIGINT) {
            tVariantDump(pVariant, buf, TSDB_DATA_TYPE_BIGINT, true);
            val = GET_INT64_VAL(buf); 
          }
          if (val == 1) {
            index = (SColumnIndex){0, PRIMARYKEY_TIMESTAMP_COL_INDEX};
            int32_t size = tDataTypeDesc[TSDB_DATA_TYPE_BIGINT].nSize;
H
Haojun Liao 已提交
1860
            pExpr = tscSqlExprAppend(pQueryInfo, functionID, &index, TSDB_DATA_TYPE_BIGINT, size, getNewResColId(pQueryInfo), size, false);
Y
TD-1370  
yihaoDeng 已提交
1861 1862 1863
          } else {
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
          }
H
hzcheng 已提交
1864
        } else {
H
hjxilinx 已提交
1865
          // count the number of meters created according to the super table
1866 1867
          if (getColumnIndexByName(pCmd, pToken, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
1868 1869
          }

H
hjxilinx 已提交
1870
          pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
S
slguan 已提交
1871 1872

          // count tag is equalled to count(tbname)
H
Haojun Liao 已提交
1873 1874
          bool isTag = false;
          if (index.columnIndex >= tscGetNumOfColumns(pTableMetaInfo->pTableMeta) || index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
S
slguan 已提交
1875
            index.columnIndex = TSDB_TBNAME_COLUMN_INDEX;
H
Haojun Liao 已提交
1876
            isTag = true;
H
hzcheng 已提交
1877 1878
          }

S
slguan 已提交
1879
          int32_t size = tDataTypeDesc[TSDB_DATA_TYPE_BIGINT].nSize;
H
Haojun Liao 已提交
1880
          pExpr = tscSqlExprAppend(pQueryInfo, functionID, &index, TSDB_DATA_TYPE_BIGINT, size, getNewResColId(pQueryInfo), size, isTag);
H
hzcheng 已提交
1881
        }
S
slguan 已提交
1882 1883 1884
      } else {  // count(*) is equalled to count(primary_timestamp_key)
        index = (SColumnIndex){0, PRIMARYKEY_TIMESTAMP_COL_INDEX};
        int32_t size = tDataTypeDesc[TSDB_DATA_TYPE_BIGINT].nSize;
H
Haojun Liao 已提交
1885
        pExpr = tscSqlExprAppend(pQueryInfo, functionID, &index, TSDB_DATA_TYPE_BIGINT, size, getNewResColId(pQueryInfo), size, false);
H
hzcheng 已提交
1886
      }
H
Haojun Liao 已提交
1887 1888 1889

      pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);

H
hjxilinx 已提交
1890
      memset(pExpr->aliasName, 0, tListLen(pExpr->aliasName));
B
Bomin Zhang 已提交
1891
      getColumnName(pItem, pExpr->aliasName, sizeof(pExpr->aliasName) - 1);
H
hjxilinx 已提交
1892
      
S
slguan 已提交
1893
      SColumnList ids = getColumnList(1, index.tableIndex, index.columnIndex);
H
hjxilinx 已提交
1894 1895 1896 1897 1898
      if (finalResult) {
        int32_t numOfOutput = tscNumOfFields(pQueryInfo);
        insertResultField(pQueryInfo, numOfOutput, &ids, sizeof(int64_t), TSDB_DATA_TYPE_BIGINT, pExpr->aliasName, pExpr);
      } else {
        for (int32_t i = 0; i < ids.num; ++i) {
1899
          tscColumnListInsert(pQueryInfo->colList, &(ids.ids[i]));
H
hjxilinx 已提交
1900 1901
        }
      }
H
Haojun Liao 已提交
1902 1903

      // the time stamp may be always needed
H
Haojun Liao 已提交
1904 1905
      if (index.tableIndex < tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) {
        tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
H
Haojun Liao 已提交
1906 1907
      }

S
slguan 已提交
1908
      return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
1909 1910 1911
    }
    case TK_SUM:
    case TK_AVG:
L
lihui 已提交
1912 1913 1914 1915 1916 1917
    case TK_RATE:
    case TK_IRATE:
    case TK_SUM_RATE:
    case TK_SUM_IRATE:
    case TK_AVG_RATE:
    case TK_AVG_IRATE:
S
slguan 已提交
1918
    case TK_TWA:
H
hzcheng 已提交
1919 1920 1921 1922 1923 1924 1925 1926 1927
    case TK_MIN:
    case TK_MAX:
    case TK_DIFF:
    case TK_STDDEV:
    case TK_LEASTSQUARES: {
      // 1. valid the number of parameters
      if (pItem->pNode->pParam == NULL || (optr != TK_LEASTSQUARES && pItem->pNode->pParam->nExpr != 1) ||
          (optr == TK_LEASTSQUARES && pItem->pNode->pParam->nExpr != 3)) {
        /* no parameters or more than one parameter for function */
1928
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1929 1930
      }

H
Haojun Liao 已提交
1931
      tSqlExprItem* pParamElem = &(pItem->pNode->pParam->a[0]);
H
hzcheng 已提交
1932
      if (pParamElem->pNode->nSQLOptr != TK_ALL && pParamElem->pNode->nSQLOptr != TK_ID) {
1933
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1934 1935
      }

S
slguan 已提交
1936
      SColumnIndex index = COLUMN_INDEX_INITIALIZER;
Y
yihaoDeng 已提交
1937
      if ((getColumnIndexByName(pCmd, &pParamElem->pNode->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS)) {
1938
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
1939
      }
Y
yihaoDeng 已提交
1940 1941 1942
      if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
      }
H
hzcheng 已提交
1943 1944

      // 2. check if sql function can be applied on this column data type
H
hjxilinx 已提交
1945
      pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
1946
      SSchema* pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, index.columnIndex);
S
slguan 已提交
1947 1948
      int16_t  colType = pSchema->type;

1949
      if (!IS_NUMERIC_TYPE(colType)) {
1950
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1951 1952 1953 1954
      }

      int16_t resultType = 0;
      int16_t resultSize = 0;
1955
      int32_t intermediateResSize = 0;
H
hzcheng 已提交
1956 1957

      int16_t functionID = 0;
H
Haojun Liao 已提交
1958
      if (convertFunctionId(optr, &functionID) != TSDB_CODE_SUCCESS) {
1959
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1960 1961
      }

S
slguan 已提交
1962 1963
      if (getResultDataInfo(pSchema->type, pSchema->bytes, functionID, 0, &resultType, &resultSize,
                            &intermediateResSize, 0, false) != TSDB_CODE_SUCCESS) {
1964
        return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
1965
      }
H
hzcheng 已提交
1966

S
slguan 已提交
1967
      // set the first column ts for diff query
H
hzcheng 已提交
1968
      if (optr == TK_DIFF) {
1969
        colIndex += 1;
S
slguan 已提交
1970
        SColumnIndex indexTS = {.tableIndex = index.tableIndex, .columnIndex = 0};
H
hjxilinx 已提交
1971
        SSqlExpr* pExpr = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_TS_DUMMY, &indexTS, TSDB_DATA_TYPE_TIMESTAMP, TSDB_KEYSIZE,
H
Haojun Liao 已提交
1972
                                           getNewResColId(pQueryInfo), TSDB_KEYSIZE, false);
H
hzcheng 已提交
1973

S
slguan 已提交
1974
        SColumnList ids = getColumnList(1, 0, 0);
H
hjxilinx 已提交
1975
        insertResultField(pQueryInfo, 0, &ids, TSDB_KEYSIZE, TSDB_DATA_TYPE_TIMESTAMP, aAggs[TSDB_FUNC_TS_DUMMY].aName, pExpr);
H
hzcheng 已提交
1976 1977
      }

S
slguan 已提交
1978
      // functions can not be applied to tags
H
hjxilinx 已提交
1979
      if (index.columnIndex >= tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) {
1980
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
S
slguan 已提交
1981 1982
      }

H
Haojun Liao 已提交
1983
      SSqlExpr* pExpr = tscSqlExprAppend(pQueryInfo, functionID, &index, resultType, resultSize, getNewResColId(pQueryInfo), resultSize, false);
H
hzcheng 已提交
1984 1985 1986 1987

      if (optr == TK_LEASTSQUARES) {
        /* set the leastsquares parameters */
        char val[8] = {0};
1988
        if (tVariantDump(&pParamElem[1].pNode->val, val, TSDB_DATA_TYPE_DOUBLE, true) < 0) {
1989
          return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1990 1991
        }

H
Haojun Liao 已提交
1992
        addExprParams(pExpr, val, TSDB_DATA_TYPE_DOUBLE, DOUBLE_BYTES);
H
hzcheng 已提交
1993 1994

        memset(val, 0, tListLen(val));
1995
        if (tVariantDump(&pParamElem[2].pNode->val, val, TSDB_DATA_TYPE_DOUBLE, true) < 0) {
1996
          return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1997 1998
        }

H
Haojun Liao 已提交
1999
        addExprParams(pExpr, val, TSDB_DATA_TYPE_DOUBLE, sizeof(double));
H
hzcheng 已提交
2000 2001
      }

S
slguan 已提交
2002 2003 2004
      SColumnList ids = {0};
      ids.num = 1;
      ids.ids[0] = index;
H
hjxilinx 已提交
2005 2006
  
      memset(pExpr->aliasName, 0, tListLen(pExpr->aliasName));
B
Bomin Zhang 已提交
2007
      getColumnName(pItem, pExpr->aliasName, sizeof(pExpr->aliasName) - 1);
H
hjxilinx 已提交
2008 2009 2010
  
      if (finalResult) {
        int32_t numOfOutput = tscNumOfFields(pQueryInfo);
S
TD-1057  
Shengliang Guan 已提交
2011
        insertResultField(pQueryInfo, numOfOutput, &ids, pExpr->resBytes, (int32_t)pExpr->resType, pExpr->aliasName, pExpr);
H
hjxilinx 已提交
2012 2013
      } else {
        for (int32_t i = 0; i < ids.num; ++i) {
2014
          tscColumnListInsert(pQueryInfo->colList, &(ids.ids[i]));
H
hjxilinx 已提交
2015 2016
        }
      }
H
Haojun Liao 已提交
2017 2018

      tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
S
slguan 已提交
2019
      return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
2020 2021 2022 2023 2024 2025 2026 2027 2028
    }
    case TK_FIRST:
    case TK_LAST:
    case TK_SPREAD:
    case TK_LAST_ROW:
    case TK_INTERP: {
      bool requireAllFields = (pItem->pNode->pParam == NULL);

      int16_t functionID = 0;
H
Haojun Liao 已提交
2029
      if (convertFunctionId(optr, &functionID) != TSDB_CODE_SUCCESS) {
2030
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg9);
B
Bomin Zhang 已提交
2031
      }
2032 2033

      // NOTE: has time range condition or normal column filter condition, the last_row query will be transferred to last query
Y
TD-1230  
yihaoDeng 已提交
2034
      SConvertFunc cvtFunc = {.originFuncId = functionID, .execFuncId = functionID};
2035
      if (functionID == TSDB_FUNC_LAST_ROW && ((!TSWINDOW_IS_EQUAL(pQueryInfo->window, TSWINDOW_INITIALIZER)) || (hasNormalColumnFilter(pQueryInfo)))) {
Y
TD-1230  
yihaoDeng 已提交
2036 2037
        cvtFunc.execFuncId = TSDB_FUNC_LAST;
      }
2038

H
hzcheng 已提交
2039 2040
      if (!requireAllFields) {
        if (pItem->pNode->pParam->nExpr < 1) {
2041
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
2042 2043
        }

H
Haojun Liao 已提交
2044
        if (pItem->pNode->pParam->nExpr > 1 && (pItem->aliasName != NULL && strlen(pItem->aliasName) > 0)) {
2045
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg8);
H
Haojun Liao 已提交
2046 2047
        }

H
hzcheng 已提交
2048 2049
        /* in first/last function, multiple columns can be add to resultset */
        for (int32_t i = 0; i < pItem->pNode->pParam->nExpr; ++i) {
H
Haojun Liao 已提交
2050
          tSqlExprItem* pParamElem = &(pItem->pNode->pParam->a[i]);
H
hzcheng 已提交
2051
          if (pParamElem->pNode->nSQLOptr != TK_ALL && pParamElem->pNode->nSQLOptr != TK_ID) {
2052
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
2053 2054
          }

S
slguan 已提交
2055 2056
          SColumnIndex index = COLUMN_INDEX_INITIALIZER;

2057
          if (pParamElem->pNode->nSQLOptr == TK_ALL) { // select table.*
H
Haojun Liao 已提交
2058
            SStrToken tmpToken = pParamElem->pNode->colInfo;
S
slguan 已提交
2059

2060
            if (getTableIndexByName(&tmpToken, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
2061
              return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
2062 2063
            }

H
hjxilinx 已提交
2064
            pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
2065
            SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
2066

2067
            char name[TSDB_COL_NAME_LEN] = {0};
H
hjxilinx 已提交
2068
            for (int32_t j = 0; j < tscGetNumOfColumns(pTableMetaInfo->pTableMeta); ++j) {
S
slguan 已提交
2069
              index.columnIndex = j;
S
Shengliang Guan 已提交
2070
              SStrToken t = {.z = pSchema[j].name, .n = (uint32_t)strnlen(pSchema[j].name, TSDB_COL_NAME_LEN)};
H
Haojun Liao 已提交
2071
              setResultColName(name, pItem, cvtFunc.originFuncId, &t, true);
2072 2073

              if (setExprInfoForFunctions(pCmd, pQueryInfo, &pSchema[j], cvtFunc, name, colIndex++, &index, finalResult) != 0) {
2074
                return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2075 2076
              }
            }
H
hzcheng 已提交
2077

S
slguan 已提交
2078
          } else {
2079 2080
            if (getColumnIndexByName(pCmd, &pParamElem->pNode->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
              return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
2081 2082
            }

H
hjxilinx 已提交
2083
            pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
S
slguan 已提交
2084 2085

            // functions can not be applied to tags
H
hjxilinx 已提交
2086
            if ((index.columnIndex >= tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) || (index.columnIndex < 0)) {
2087
              return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
S
slguan 已提交
2088
            }
H
Haojun Liao 已提交
2089

2090 2091 2092
            char name[TSDB_COL_NAME_LEN] = {0};

            SSchema* pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, index.columnIndex);
H
Haojun Liao 已提交
2093 2094 2095

            bool multiColOutput = pItem->pNode->pParam->nExpr > 1;
            setResultColName(name, pItem, cvtFunc.originFuncId, &pParamElem->pNode->colInfo, multiColOutput);
2096 2097

            if (setExprInfoForFunctions(pCmd, pQueryInfo, pSchema, cvtFunc, name, colIndex + i, &index, finalResult) != 0) {
2098
              return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2099
            }
2100 2101 2102 2103 2104 2105 2106 2107 2108

            if (optr == TK_LAST) {  // todo refactor
              SSqlGroupbyExpr* pGroupBy = &pQueryInfo->groupbyExpr;
              if (pGroupBy->numOfGroupCols > 0) {
                for(int32_t k = 0; k < pGroupBy->numOfGroupCols; ++k) {
                  SColIndex* pIndex = taosArrayGet(pGroupBy->columnInfo, k);
                  if (!TSDB_COL_IS_TAG(pIndex->flag) && pIndex->colIndex < tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) { // group by normal columns
                    SSqlExpr* pExpr = taosArrayGetP(pQueryInfo->exprList, colIndex + i);
                    pExpr->numOfParams = 1;
2109
                    pExpr->param->i64 = TSDB_ORDER_ASC;
2110 2111 2112 2113 2114 2115

                    break;
                  }
                }
              }
            }
H
hzcheng 已提交
2116 2117
          }
        }
2118
        
S
slguan 已提交
2119 2120 2121 2122
        return TSDB_CODE_SUCCESS;
      } else {  // select * from xxx
        int32_t numOfFields = 0;

H
Haojun Liao 已提交
2123
        // multicolumn selection does not support alias name
H
Haojun Liao 已提交
2124
        if (pItem->aliasName != NULL && strlen(pItem->aliasName) > 0) {
2125
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg8);
H
Haojun Liao 已提交
2126 2127
        }

2128
        for (int32_t j = 0; j < pQueryInfo->numOfTables; ++j) {
H
hjxilinx 已提交
2129
          pTableMetaInfo = tscGetMetaInfo(pQueryInfo, j);
H
hjxilinx 已提交
2130
          SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
2131

H
hjxilinx 已提交
2132
          for (int32_t i = 0; i < tscGetNumOfColumns(pTableMetaInfo->pTableMeta); ++i) {
S
slguan 已提交
2133
            SColumnIndex index = {.tableIndex = j, .columnIndex = i};
2134 2135

            char name[TSDB_COL_NAME_LEN] = {0};
2136
            SStrToken t = {.z = pSchema[i].name, .n = (uint32_t)strnlen(pSchema[i].name, TSDB_COL_NAME_LEN)};
H
Haojun Liao 已提交
2137
            setResultColName(name, pItem, cvtFunc.originFuncId, &t, true);
2138 2139

            if (setExprInfoForFunctions(pCmd, pQueryInfo, &pSchema[index.columnIndex], cvtFunc, name, colIndex, &index, finalResult) != 0) {
2140
              return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2141
            }
H
Haojun Liao 已提交
2142 2143

            colIndex++;
H
hzcheng 已提交
2144
          }
S
slguan 已提交
2145

H
hjxilinx 已提交
2146
          numOfFields += tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
H
hzcheng 已提交
2147 2148
        }

2149
        
S
slguan 已提交
2150
        return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
2151 2152 2153 2154 2155 2156 2157 2158 2159
      }
    }
    case TK_TOP:
    case TK_BOTTOM:
    case TK_PERCENTILE:
    case TK_APERCENTILE: {
      // 1. valid the number of parameters
      if (pItem->pNode->pParam == NULL || pItem->pNode->pParam->nExpr != 2) {
        /* no parameters or more than one parameter for function */
2160
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
2161 2162
      }

H
Haojun Liao 已提交
2163
      tSqlExprItem* pParamElem = &(pItem->pNode->pParam->a[0]);
H
hzcheng 已提交
2164
      if (pParamElem->pNode->nSQLOptr != TK_ID) {
2165
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
2166
      }
H
hjxilinx 已提交
2167
      
S
slguan 已提交
2168
      SColumnIndex index = COLUMN_INDEX_INITIALIZER;
2169 2170
      if (getColumnIndexByName(pCmd, &pParamElem->pNode->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
2171
      }
Y
yihaoDeng 已提交
2172 2173 2174 2175
      if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
      }
      
H
hjxilinx 已提交
2176
      pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
2177
      SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
2178 2179

      // functions can not be applied to tags
H
hjxilinx 已提交
2180
      if (index.columnIndex >= tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) {
2181
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
2182 2183 2184
      }

      // 2. valid the column type
S
slguan 已提交
2185
      int16_t colType = pSchema[index.columnIndex].type;
2186
      if (!IS_NUMERIC_TYPE(colType)) {
2187
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
2188 2189 2190 2191
      }

      // 3. valid the parameters
      if (pParamElem[1].pNode->nSQLOptr == TK_ID) {
2192
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
2193 2194 2195 2196
      }

      tVariant* pVariant = &pParamElem[1].pNode->val;

S
slguan 已提交
2197 2198
      int8_t  resultType = pSchema[index.columnIndex].type;
      int16_t resultSize = pSchema[index.columnIndex].bytes;
H
hzcheng 已提交
2199

H
hjxilinx 已提交
2200
      char    val[8] = {0};
H
hjxilinx 已提交
2201 2202
      SSqlExpr* pExpr = NULL;
      
H
hzcheng 已提交
2203
      if (optr == TK_PERCENTILE || optr == TK_APERCENTILE) {
2204
        tVariantDump(pVariant, val, TSDB_DATA_TYPE_DOUBLE, true);
H
hzcheng 已提交
2205

L
lihui 已提交
2206
        double dp = GET_DOUBLE_VAL(val);
S
slguan 已提交
2207
        if (dp < 0 || dp > TOP_BOTTOM_QUERY_LIMIT) {
2208
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219
        }

        resultSize = sizeof(double);
        resultType = TSDB_DATA_TYPE_DOUBLE;

        /*
         * sql function transformation
         * for dp = 0, it is actually min,
         * for dp = 100, it is max,
         */
        int16_t functionId = 0;
H
Haojun Liao 已提交
2220
        if (convertFunctionId(optr, &functionId) != TSDB_CODE_SUCCESS) {
2221
          return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2222
        }
dengyihao's avatar
dengyihao 已提交
2223 2224
        tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
        colIndex += 1;  // the first column is ts
H
hzcheng 已提交
2225

H
Haojun Liao 已提交
2226 2227
        pExpr = tscSqlExprAppend(pQueryInfo, functionId, &index, resultType, resultSize, getNewResColId(pQueryInfo), resultSize, false);
        addExprParams(pExpr, val, TSDB_DATA_TYPE_DOUBLE, sizeof(double));
H
hzcheng 已提交
2228
      } else {
2229
        tVariantDump(pVariant, val, TSDB_DATA_TYPE_BIGINT, true);
H
hzcheng 已提交
2230

H
Haojun Liao 已提交
2231
        int64_t nTop = GET_INT32_VAL(val);
H
hzcheng 已提交
2232
        if (nTop <= 0 || nTop > 100) {  // todo use macro
2233
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
2234 2235 2236
        }

        int16_t functionId = 0;
H
Haojun Liao 已提交
2237
        if (convertFunctionId(optr, &functionId) != TSDB_CODE_SUCCESS) {
2238
          return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2239
        }
S
slguan 已提交
2240

H
Haojun Liao 已提交
2241
        // todo REFACTOR
H
hzcheng 已提交
2242
        // set the first column ts for top/bottom query
S
slguan 已提交
2243
        SColumnIndex index1 = {0, PRIMARYKEY_TIMESTAMP_COL_INDEX};
H
Haojun Liao 已提交
2244 2245
        pExpr = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_TS, &index1, TSDB_DATA_TYPE_TIMESTAMP, TSDB_KEYSIZE, getNewResColId(pQueryInfo),
                                 TSDB_KEYSIZE, false);
H
Haojun Liao 已提交
2246
        tstrncpy(pExpr->aliasName, aAggs[TSDB_FUNC_TS].aName, sizeof(pExpr->aliasName));
S
slguan 已提交
2247

H
Haojun Liao 已提交
2248
        const int32_t TS_COLUMN_INDEX = PRIMARYKEY_TIMESTAMP_COL_INDEX;
S
slguan 已提交
2249
        SColumnList   ids = getColumnList(1, 0, TS_COLUMN_INDEX);
2250
        insertResultField(pQueryInfo, TS_COLUMN_INDEX, &ids, TSDB_KEYSIZE, TSDB_DATA_TYPE_TIMESTAMP,
H
hjxilinx 已提交
2251
                          aAggs[TSDB_FUNC_TS].aName, pExpr);
H
hzcheng 已提交
2252

2253
        colIndex += 1;  // the first column is ts
H
hzcheng 已提交
2254

H
Haojun Liao 已提交
2255 2256
        pExpr = tscSqlExprAppend(pQueryInfo, functionId, &index, resultType, resultSize, getNewResColId(pQueryInfo), resultSize, false);
        addExprParams(pExpr, val, TSDB_DATA_TYPE_BIGINT, sizeof(int64_t));
H
hzcheng 已提交
2257
      }
H
hjxilinx 已提交
2258 2259
  
      memset(pExpr->aliasName, 0, tListLen(pExpr->aliasName));
B
Bomin Zhang 已提交
2260
      getColumnName(pItem, pExpr->aliasName, sizeof(pExpr->aliasName) - 1);
H
hjxilinx 已提交
2261
  
S
slguan 已提交
2262
      SColumnList ids = getColumnList(1, 0, index.columnIndex);
H
hjxilinx 已提交
2263
      if (finalResult) {
2264
        insertResultField(pQueryInfo, colIndex, &ids, resultSize, resultType, pExpr->aliasName, pExpr);
H
hjxilinx 已提交
2265 2266
      } else {
        for (int32_t i = 0; i < ids.num; ++i) {
2267
          tscColumnListInsert(pQueryInfo->colList, &(ids.ids[i]));
H
hjxilinx 已提交
2268 2269
        }
      }
S
slguan 已提交
2270

2271 2272 2273 2274 2275
      return TSDB_CODE_SUCCESS;
    };
    
    case TK_TBID: {
      pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
weixin_48148422's avatar
weixin_48148422 已提交
2276
      if (UTIL_TABLE_IS_NORMAL_TABLE(pTableMetaInfo)) {
2277
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
2278 2279 2280 2281
      }
    
      // no parameters or more than one parameter for function
      if (pItem->pNode->pParam == NULL || pItem->pNode->pParam->nExpr != 1) {
2282
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
2283 2284 2285 2286 2287
      }
      
      tSQLExpr* pParam = pItem->pNode->pParam->a[0].pNode;
    
      SColumnIndex index = COLUMN_INDEX_INITIALIZER;
2288 2289
      if (getColumnIndexByName(pCmd, &pParam->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
2290 2291 2292 2293 2294 2295 2296
      }
    
      pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
      SSchema* pSchema = tscGetTableTagSchema(pTableMetaInfo->pTableMeta);
  
      // functions can not be applied to normal columns
      int32_t numOfCols = tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
2297
      if (index.columnIndex < numOfCols && index.columnIndex != TSDB_TBNAME_COLUMN_INDEX) {
2298
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
2299 2300
      }
    
2301 2302 2303
      if (index.columnIndex > 0) {
        index.columnIndex -= numOfCols;
      }
2304 2305
      
      // 2. valid the column type
2306 2307 2308 2309 2310 2311 2312 2313
      int16_t colType = 0;
      if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
        colType = TSDB_DATA_TYPE_BINARY;
      } else {
        colType = pSchema[index.columnIndex].type;
      }
      
      if (colType == TSDB_DATA_TYPE_BOOL) {
2314
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
2315 2316 2317 2318
      }

      tscColumnListInsert(pTableMetaInfo->tagColList, &index);
      SSchema* pTagSchema = tscGetTableTagSchema(pTableMetaInfo->pTableMeta);
2319 2320 2321
      
      SSchema s = {0};
      if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
H
Haojun Liao 已提交
2322
        s = tGetTableNameColumnSchema();
2323 2324 2325 2326
      } else {
        s = pTagSchema[index.columnIndex];
      }
      
2327 2328
      int16_t bytes = 0;
      int16_t type  = 0;
2329
      int32_t inter = 0;
2330 2331 2332 2333

      int32_t ret = getResultDataInfo(s.type, s.bytes, TSDB_FUNC_TID_TAG, 0, &type, &bytes, &inter, 0, 0);
      assert(ret == TSDB_CODE_SUCCESS);
      
S
TD-1057  
Shengliang Guan 已提交
2334
      s.type = (uint8_t)type;
2335 2336 2337 2338 2339
      s.bytes = bytes;

      TSDB_QUERY_SET_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_TAG_FILTER_QUERY);
      tscAddSpecialColumnForSelect(pQueryInfo, 0, TSDB_FUNC_TID_TAG, &index, &s, TSDB_COL_TAG);
      
S
slguan 已提交
2340
      return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
2341
    }
2342
    
H
hzcheng 已提交
2343
    default:
2344
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2345
  }
2346
  
H
hzcheng 已提交
2347 2348
}

S
slguan 已提交
2349 2350
// todo refactor
static SColumnList getColumnList(int32_t num, int16_t tableIndex, int32_t columnIndex) {
2351
  assert(num == 1 && tableIndex >= 0);
S
slguan 已提交
2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362

  SColumnList columnList = {0};
  columnList.num = num;

  int32_t index = num - 1;
  columnList.ids[index].tableIndex = tableIndex;
  columnList.ids[index].columnIndex = columnIndex;

  return columnList;
}

H
Haojun Liao 已提交
2363
void getColumnName(tSqlExprItem* pItem, char* resultFieldName, int32_t nameLength) {
H
hzcheng 已提交
2364 2365 2366
  if (pItem->aliasName != NULL) {
    strncpy(resultFieldName, pItem->aliasName, nameLength);
  } else {
S
TD-1057  
Shengliang Guan 已提交
2367
    int32_t len = ((int32_t)pItem->pNode->operand.n < nameLength) ? (int32_t)pItem->pNode->operand.n : nameLength;
H
hzcheng 已提交
2368 2369 2370 2371
    strncpy(resultFieldName, pItem->pNode->operand.z, len);
  }
}

H
Haojun Liao 已提交
2372 2373 2374
static bool isTablenameToken(SStrToken* token) {
  SStrToken tmpToken = *token;
  SStrToken tableToken = {0};
S
slguan 已提交
2375 2376 2377 2378 2379 2380

  extractTableNameFromToken(&tmpToken, &tableToken);

  return (strncasecmp(TSQL_TBNAME_L, tmpToken.z, tmpToken.n) == 0 && tmpToken.n == strlen(TSQL_TBNAME_L));
}

H
Haojun Liao 已提交
2381
static int16_t doGetColumnIndex(SQueryInfo* pQueryInfo, int32_t index, SStrToken* pToken) {
H
hjxilinx 已提交
2382
  STableMeta* pTableMeta = tscGetMetaInfo(pQueryInfo, index)->pTableMeta;
S
slguan 已提交
2383

H
hjxilinx 已提交
2384 2385
  int32_t  numOfCols = tscGetNumOfColumns(pTableMeta) + tscGetNumOfTags(pTableMeta);
  SSchema* pSchema = tscGetTableSchema(pTableMeta);
S
slguan 已提交
2386 2387 2388 2389 2390 2391 2392 2393 2394 2395

  int16_t columnIndex = COLUMN_INDEX_INITIAL_VAL;

  for (int16_t i = 0; i < numOfCols; ++i) {
    if (pToken->n != strlen(pSchema[i].name)) {
      continue;
    }

    if (strncasecmp(pSchema[i].name, pToken->z, pToken->n) == 0) {
      columnIndex = i;
H
Hui Li 已提交
2396
      break;
S
slguan 已提交
2397 2398 2399 2400 2401 2402
    }
  }

  return columnIndex;
}

H
Haojun Liao 已提交
2403
int32_t doGetColumnIndexByName(SSqlCmd* pCmd, SStrToken* pToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex) {
S
slguan 已提交
2404 2405 2406 2407 2408 2409 2410 2411 2412 2413
  const char* msg0 = "ambiguous column name";
  const char* msg1 = "invalid column name";

  if (isTablenameToken(pToken)) {
    pIndex->columnIndex = TSDB_TBNAME_COLUMN_INDEX;
  } else if (strncasecmp(pToken->z, DEFAULT_PRIMARY_TIMESTAMP_COL_NAME, pToken->n) == 0) {
    pIndex->columnIndex = PRIMARYKEY_TIMESTAMP_COL_INDEX;
  } else {
    // not specify the table name, try to locate the table index by column name
    if (pIndex->tableIndex == COLUMN_INDEX_INITIAL_VAL) {
2414 2415
      for (int16_t i = 0; i < pQueryInfo->numOfTables; ++i) {
        int16_t colIndex = doGetColumnIndex(pQueryInfo, i, pToken);
S
slguan 已提交
2416 2417 2418

        if (colIndex != COLUMN_INDEX_INITIAL_VAL) {
          if (pIndex->columnIndex != COLUMN_INDEX_INITIAL_VAL) {
2419
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
S
slguan 已提交
2420 2421 2422 2423 2424 2425 2426
          } else {
            pIndex->tableIndex = i;
            pIndex->columnIndex = colIndex;
          }
        }
      }
    } else {  // table index is valid, get the column index
2427
      int16_t colIndex = doGetColumnIndex(pQueryInfo, pIndex->tableIndex, pToken);
S
slguan 已提交
2428 2429 2430 2431 2432 2433
      if (colIndex != COLUMN_INDEX_INITIAL_VAL) {
        pIndex->columnIndex = colIndex;
      }
    }

    if (pIndex->columnIndex == COLUMN_INDEX_INITIAL_VAL) {
2434
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
2435 2436 2437 2438 2439 2440
    }
  }

  if (COLUMN_INDEX_VALIDE(*pIndex)) {
    return TSDB_CODE_SUCCESS;
  } else {
2441
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2442 2443 2444
  }
}

H
Haojun Liao 已提交
2445
int32_t getTableIndexImpl(SStrToken* pTableToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex) {
S
slguan 已提交
2446
  if (pTableToken->n == 0) {  // only one table and no table name prefix in column name
2447
    if (pQueryInfo->numOfTables == 1) {
S
slguan 已提交
2448
      pIndex->tableIndex = 0;
2449 2450
    } else {
      pIndex->tableIndex = COLUMN_INDEX_INITIAL_VAL;
S
slguan 已提交
2451 2452 2453 2454 2455 2456
    }

    return TSDB_CODE_SUCCESS;
  }

  pIndex->tableIndex = COLUMN_INDEX_INITIAL_VAL;
2457
  for (int32_t i = 0; i < pQueryInfo->numOfTables; ++i) {
H
hjxilinx 已提交
2458
    STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, i);
H
Haojun Liao 已提交
2459 2460
    char* name = pTableMetaInfo->aliasName;
    if (strncasecmp(name, pTableToken->z, pTableToken->n) == 0 && strlen(name) == pTableToken->n) {
S
slguan 已提交
2461 2462 2463 2464 2465 2466
      pIndex->tableIndex = i;
      break;
    }
  }

  if (pIndex->tableIndex < 0) {
2467
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2468 2469 2470 2471 2472
  }

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
2473 2474
int32_t getTableIndexByName(SStrToken* pToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex) {
  SStrToken tableToken = {0};
S
slguan 已提交
2475 2476
  extractTableNameFromToken(pToken, &tableToken);

H
hjxilinx 已提交
2477
  if (getTableIndexImpl(&tableToken, pQueryInfo, pIndex) != TSDB_CODE_SUCCESS) {
2478
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2479 2480
  }

S
slguan 已提交
2481 2482
  return TSDB_CODE_SUCCESS;
}
H
hzcheng 已提交
2483

H
Haojun Liao 已提交
2484
int32_t getColumnIndexByName(SSqlCmd* pCmd, const SStrToken* pToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex) {
H
hjxilinx 已提交
2485
  if (pQueryInfo->pTableMetaInfo == NULL || pQueryInfo->numOfTables == 0) {
2486
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2487 2488
  }

H
Haojun Liao 已提交
2489
  SStrToken tmpToken = *pToken;
S
slguan 已提交
2490

2491
  if (getTableIndexByName(&tmpToken, pQueryInfo, pIndex) != TSDB_CODE_SUCCESS) {
2492
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2493 2494
  }

2495
  return doGetColumnIndexByName(pCmd, &tmpToken, pQueryInfo, pIndex);
H
hzcheng 已提交
2496 2497
}

H
Haojun Liao 已提交
2498
int32_t convertFunctionId(int32_t optr, int16_t* functionId) {
H
hzcheng 已提交
2499 2500 2501 2502 2503 2504 2505 2506 2507 2508
  switch (optr) {
    case TK_COUNT:
      *functionId = TSDB_FUNC_COUNT;
      break;
    case TK_SUM:
      *functionId = TSDB_FUNC_SUM;
      break;
    case TK_AVG:
      *functionId = TSDB_FUNC_AVG;
      break;
L
lihui 已提交
2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526
    case TK_RATE:
      *functionId = TSDB_FUNC_RATE;
      break;
    case TK_IRATE:
      *functionId = TSDB_FUNC_IRATE;
      break;
    case TK_SUM_RATE:
      *functionId = TSDB_FUNC_SUM_RATE;
      break;
    case TK_SUM_IRATE:
      *functionId = TSDB_FUNC_SUM_IRATE;
      break;
    case TK_AVG_RATE:
      *functionId = TSDB_FUNC_AVG_RATE;
      break;
    case TK_AVG_IRATE:
      *functionId = TSDB_FUNC_AVG_IRATE;
      break;
H
hzcheng 已提交
2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562
    case TK_MIN:
      *functionId = TSDB_FUNC_MIN;
      break;
    case TK_MAX:
      *functionId = TSDB_FUNC_MAX;
      break;
    case TK_STDDEV:
      *functionId = TSDB_FUNC_STDDEV;
      break;
    case TK_PERCENTILE:
      *functionId = TSDB_FUNC_PERCT;
      break;
    case TK_APERCENTILE:
      *functionId = TSDB_FUNC_APERCT;
      break;
    case TK_FIRST:
      *functionId = TSDB_FUNC_FIRST;
      break;
    case TK_LAST:
      *functionId = TSDB_FUNC_LAST;
      break;
    case TK_LEASTSQUARES:
      *functionId = TSDB_FUNC_LEASTSQR;
      break;
    case TK_TOP:
      *functionId = TSDB_FUNC_TOP;
      break;
    case TK_BOTTOM:
      *functionId = TSDB_FUNC_BOTTOM;
      break;
    case TK_DIFF:
      *functionId = TSDB_FUNC_DIFF;
      break;
    case TK_SPREAD:
      *functionId = TSDB_FUNC_SPREAD;
      break;
S
slguan 已提交
2563 2564
    case TK_TWA:
      *functionId = TSDB_FUNC_TWA;
H
hzcheng 已提交
2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579
      break;
    case TK_INTERP:
      *functionId = TSDB_FUNC_INTERP;
      break;
    case TK_LAST_ROW:
      *functionId = TSDB_FUNC_LAST_ROW;
      break;
    default:
      return -1;
  }

  return TSDB_CODE_SUCCESS;
}

int32_t setShowInfo(SSqlObj* pSql, struct SSqlInfo* pInfo) {
S
slguan 已提交
2580
  SSqlCmd*        pCmd = &pSql->cmd;
2581
  STableMetaInfo* pTableMetaInfo = tscGetTableMetaInfoFromCmd(pCmd, pCmd->clauseIndex, 0);
2582
  assert(pCmd->numOfClause == 1);
H
hjxilinx 已提交
2583

H
hzcheng 已提交
2584 2585
  pCmd->command = TSDB_SQL_SHOW;

2586
  const char* msg1 = "invalid name";
2587
  const char* msg2 = "pattern filter string too long";
2588 2589 2590 2591
  const char* msg3 = "database name too long";
  const char* msg4 = "invalid ip address";
  const char* msg5 = "database name is empty";
  const char* msg6 = "pattern string is empty";
H
hzcheng 已提交
2592 2593 2594 2595 2596

  /*
   * database prefix in pInfo->pDCLInfo->a[0]
   * wildcard in like clause in pInfo->pDCLInfo->a[1]
   */
2597 2598 2599
  SShowInfo* pShowInfo = &pInfo->pDCLInfo->showOpt;
  int16_t    showType = pShowInfo->showType;
  if (showType == TSDB_MGMT_TABLE_TABLE || showType == TSDB_MGMT_TABLE_METRIC || showType == TSDB_MGMT_TABLE_VGROUP) {
H
hzcheng 已提交
2600
    // db prefix in tagCond, show table conds in payload
H
Haojun Liao 已提交
2601
    SStrToken* pDbPrefixToken = &pShowInfo->prefix;
2602
    if (pDbPrefixToken->type != 0) {
H
hzcheng 已提交
2603

B
Bomin Zhang 已提交
2604
      if (pDbPrefixToken->n >= TSDB_DB_NAME_LEN) {  // db name is too long
2605
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
2606 2607
      }

2608
      if (pDbPrefixToken->n <= 0) {
2609
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
2610 2611
      }

2612
      if (tscValidateName(pDbPrefixToken) != TSDB_CODE_SUCCESS) {
2613
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
2614 2615
      }

H
hjxilinx 已提交
2616
      int32_t ret = setObjFullName(pTableMetaInfo->name, getAccountId(pSql), pDbPrefixToken, NULL, NULL);
H
hzcheng 已提交
2617
      if (ret != TSDB_CODE_SUCCESS) {
2618
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
2619
      }
2620
    }
H
hzcheng 已提交
2621

2622
    // show table/stable like 'xxxx', set the like pattern for show tables
H
Haojun Liao 已提交
2623
    SStrToken* pPattern = &pShowInfo->pattern;
2624 2625
    if (pPattern->type != 0) {
      pPattern->n = strdequote(pPattern->z);
S
slguan 已提交
2626

2627
      if (pPattern->n <= 0) {
2628
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
2629
      }
H
hzcheng 已提交
2630

H
Haojun Liao 已提交
2631
      if (!tscValidateTableNameLength(pCmd->payloadLen)) {
2632
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
2633 2634
      }
    }
2635 2636
  } else if (showType == TSDB_MGMT_TABLE_VNODES) {
    if (pShowInfo->prefix.type == 0) {
2637
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "No specified ip of dnode");
L
lihui 已提交
2638 2639
    }

L
lihui 已提交
2640
    // show vnodes may be ip addr of dnode in payload
H
Haojun Liao 已提交
2641
    SStrToken* pDnodeIp = &pShowInfo->prefix;
B
Bomin Zhang 已提交
2642
    if (pDnodeIp->n >= TSDB_IPv4ADDR_LEN) {  // ip addr is too long
2643
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
2644
    }
L
lihui 已提交
2645

2646
    if (!validateIpAddress(pDnodeIp->z, pDnodeIp->n)) {
2647
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
L
lihui 已提交
2648
    }
H
hzcheng 已提交
2649 2650 2651 2652 2653
  }

  return TSDB_CODE_SUCCESS;
}

2654 2655 2656 2657
int32_t setKillInfo(SSqlObj* pSql, struct SSqlInfo* pInfo, int32_t killType) {
  const char* msg1 = "invalid connection ID";
  const char* msg2 = "invalid query ID";
  const char* msg3 = "invalid stream ID";
H
hzcheng 已提交
2658

2659 2660
  SSqlCmd* pCmd = &pSql->cmd;
  pCmd->command = pInfo->type;
2661
  
H
Haojun Liao 已提交
2662
  SStrToken* idStr = &(pInfo->pDCLInfo->ip);
2663
  if (idStr->n > TSDB_KILL_MSG_LEN) {
2664
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2665 2666
  }

2667
  strncpy(pCmd->payload, idStr->z, idStr->n);
2668

H
hzcheng 已提交
2669
  const char delim = ':';
2670 2671
  char* connIdStr = strtok(idStr->z, &delim);
  char* queryIdStr = strtok(NULL, &delim);
H
hzcheng 已提交
2672

2673 2674 2675 2676 2677
  int32_t connId = (int32_t)strtol(connIdStr, NULL, 10);
  if (connId <= 0) {
    memset(pCmd->payload, 0, strlen(pCmd->payload));
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
  }
2678

2679 2680 2681 2682 2683 2684
  if (killType == TSDB_SQL_KILL_CONNECTION) {
    return TSDB_CODE_SUCCESS;
  }

  int32_t queryId = (int32_t)strtol(queryIdStr, NULL, 10);
  if (queryId <= 0) {
sangshuduo's avatar
sangshuduo 已提交
2685
    memset(pCmd->payload, 0, strlen(pCmd->payload));
2686 2687 2688 2689 2690
    if (killType == TSDB_SQL_KILL_QUERY) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    } else {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }
H
hzcheng 已提交
2691
  }
2692
  
H
hzcheng 已提交
2693 2694 2695
  return TSDB_CODE_SUCCESS;
}

2696 2697 2698 2699 2700 2701
bool validateIpAddress(const char* ip, size_t size) {
  char tmp[128] = {0};  // buffer to build null-terminated string
  assert(size < 128);

  strncpy(tmp, ip, size);

2702
  in_addr_t epAddr = taosInetAddr(tmp);
2703

2704
  return epAddr != INADDR_NONE;
H
hzcheng 已提交
2705 2706
}

H
hjxilinx 已提交
2707
int32_t tscTansformSQLFuncForSTableQuery(SQueryInfo* pQueryInfo) {
H
hjxilinx 已提交
2708
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
S
slguan 已提交
2709

weixin_48148422's avatar
weixin_48148422 已提交
2710
  if (pTableMetaInfo->pTableMeta == NULL || !UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
2711
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2712 2713
  }

H
hjxilinx 已提交
2714
  assert(tscGetNumOfTags(pTableMetaInfo->pTableMeta) >= 0);
H
hzcheng 已提交
2715 2716 2717

  int16_t bytes = 0;
  int16_t type = 0;
2718
  int32_t interBytes = 0;
H
hjxilinx 已提交
2719 2720 2721
  
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t k = 0; k < size; ++k) {
2722
    SSqlExpr*   pExpr = tscSqlExprGet(pQueryInfo, k);
S
slguan 已提交
2723 2724
    int16_t functionId = aAggs[pExpr->functionId].stableFuncId;

2725
    int32_t colIndex = pExpr->colInfo.colIndex;
H
hjxilinx 已提交
2726
    SSchema* pSrcSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, colIndex);
H
hjxilinx 已提交
2727
    
S
slguan 已提交
2728
    if ((functionId >= TSDB_FUNC_SUM && functionId <= TSDB_FUNC_TWA) ||
L
lihui 已提交
2729 2730
        (functionId >= TSDB_FUNC_FIRST_DST && functionId <= TSDB_FUNC_LAST_DST) ||
        (functionId >= TSDB_FUNC_RATE && functionId <= TSDB_FUNC_AVG_IRATE)) {
2731
      if (getResultDataInfo(pSrcSchema->type, pSrcSchema->bytes, functionId, (int32_t)pExpr->param[0].i64, &type, &bytes,
2732
                            &interBytes, 0, true) != TSDB_CODE_SUCCESS) {
2733
        return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2734
      }
H
hzcheng 已提交
2735

2736
      tscSqlExprUpdate(pQueryInfo, k, functionId, pExpr->colInfo.colIndex, TSDB_DATA_TYPE_BINARY, bytes);
S
slguan 已提交
2737
      // todo refactor
2738
      pExpr->interBytes = interBytes;
H
hzcheng 已提交
2739 2740 2741
    }
  }

H
Haojun Liao 已提交
2742
  tscFieldInfoUpdateOffset(pQueryInfo);
S
slguan 已提交
2743
  return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
2744 2745 2746
}

/* transfer the field-info back to original input format */
H
hjxilinx 已提交
2747
void tscRestoreSQLFuncForSTableQuery(SQueryInfo* pQueryInfo) {
H
hjxilinx 已提交
2748
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
weixin_48148422's avatar
weixin_48148422 已提交
2749
  if (!UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
hzcheng 已提交
2750 2751
    return;
  }
H
hjxilinx 已提交
2752 2753 2754
  
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t i = 0; i < size; ++i) {
2755
    SSqlExpr*   pExpr = tscSqlExprGet(pQueryInfo, i);
2756
    SSchema* pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, pExpr->colInfo.colIndex);
H
hjxilinx 已提交
2757
    
2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774
    // the final result size and type in the same as query on single table.
    // so here, set the flag to be false;
    int32_t inter = 0;
    
    int32_t functionId = pExpr->functionId;
    if (functionId >= TSDB_FUNC_TS && functionId <= TSDB_FUNC_DIFF) {
      continue;
    }
    
    if (functionId == TSDB_FUNC_FIRST_DST) {
      functionId = TSDB_FUNC_FIRST;
    } else if (functionId == TSDB_FUNC_LAST_DST) {
      functionId = TSDB_FUNC_LAST;
    }
    
    getResultDataInfo(pSchema->type, pSchema->bytes, functionId, 0, &pExpr->resType, &pExpr->resBytes,
                      &inter, 0, false);
H
hzcheng 已提交
2775 2776 2777
  }
}

2778
bool hasUnsupportFunctionsForSTableQuery(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
S
slguan 已提交
2779
  const char* msg1 = "TWA not allowed to apply to super table directly";
H
hjxilinx 已提交
2780
  const char* msg2 = "TWA only support group by tbname for super table query";
2781
  const char* msg3 = "function not support for super table query";
H
hjxilinx 已提交
2782

S
slguan 已提交
2783
  // filter sql function not supported by metric query yet.
H
hjxilinx 已提交
2784 2785
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t i = 0; i < size; ++i) {
2786
    int32_t functionId = tscSqlExprGet(pQueryInfo, i)->functionId;
2787
    if ((aAggs[functionId].nStatus & TSDB_FUNCSTATE_STABLE) == 0) {
2788
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
2789
      return true;
H
hzcheng 已提交
2790 2791 2792
    }
  }

2793 2794
  if (tscIsTWAQuery(pQueryInfo)) {
    if (pQueryInfo->groupbyExpr.numOfGroupCols == 0) {
2795
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
2796 2797
      return true;
    }
H
hzcheng 已提交
2798

2799
    if (pQueryInfo->groupbyExpr.numOfGroupCols != 1) {
2800
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
2801
      return true;
2802 2803 2804
    } else {
      SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, 0);
      if (pColIndex->colIndex != TSDB_TBNAME_COLUMN_INDEX) {
2805
        invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
2806 2807
        return true;
      }
H
hzcheng 已提交
2808 2809
    }
  }
S
slguan 已提交
2810

H
hzcheng 已提交
2811 2812 2813
  return false;
}

D
fix bug  
dapan1121 已提交
2814
static bool functionCompatibleCheck(SQueryInfo* pQueryInfo, bool joinQuery, bool intervalQuery) {
H
hzcheng 已提交
2815
  int32_t startIdx = 0;
2816 2817 2818 2819

  size_t numOfExpr = tscSqlExprNumOfExprs(pQueryInfo);
  assert(numOfExpr > 0);

H
hjxilinx 已提交
2820 2821
  SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, startIdx);
  int32_t functionID = pExpr->functionId;
S
slguan 已提交
2822 2823

  // ts function can be simultaneously used with any other functions.
H
hzcheng 已提交
2824
  if (functionID == TSDB_FUNC_TS || functionID == TSDB_FUNC_TS_DUMMY) {
S
slguan 已提交
2825
    startIdx++;
H
hzcheng 已提交
2826 2827
  }

H
Haojun Liao 已提交
2828
  int32_t factor = functionCompatList[tscSqlExprGet(pQueryInfo, startIdx)->functionId];
H
hzcheng 已提交
2829

D
fix bug  
dapan1121 已提交
2830
  if (tscSqlExprGet(pQueryInfo, 0)->functionId == TSDB_FUNC_LAST_ROW && (joinQuery || intervalQuery)) {
2831
    return false;
D
fix bug  
dapan1121 已提交
2832 2833
  }

H
hzcheng 已提交
2834 2835
  // diff function cannot be executed with other function
  // arithmetic function can be executed with other arithmetic functions
H
hjxilinx 已提交
2836 2837 2838
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  
  for (int32_t i = startIdx + 1; i < size; ++i) {
H
hjxilinx 已提交
2839
    SSqlExpr* pExpr1 = tscSqlExprGet(pQueryInfo, i);
2840

H
hjxilinx 已提交
2841
    int16_t functionId = pExpr1->functionId;
2842 2843 2844 2845
    if (functionId == TSDB_FUNC_TAGPRJ || functionId == TSDB_FUNC_TAG || functionId == TSDB_FUNC_TS) {
      continue;
    }

H
Haojun Liao 已提交
2846
    if (functionId == TSDB_FUNC_PRJ && (pExpr1->colInfo.colId == PRIMARYKEY_TIMESTAMP_COL_INDEX || TSDB_COL_IS_UD_COL(pExpr1->colInfo.flag))) {
S
slguan 已提交
2847 2848 2849
      continue;
    }

H
Haojun Liao 已提交
2850
    if (functionCompatList[functionId] != factor) {
H
hzcheng 已提交
2851
      return false;
2852 2853 2854 2855
    } else {
      if (factor == -1) { // two functions with the same -1 flag
        return false;
      }
H
hzcheng 已提交
2856
    }
H
Haojun Liao 已提交
2857

D
fix bug  
dapan1121 已提交
2858
    if (functionId == TSDB_FUNC_LAST_ROW && (joinQuery || intervalQuery)) {
H
Haojun Liao 已提交
2859 2860
      return false;
    }
H
hzcheng 已提交
2861 2862 2863 2864 2865
  }

  return true;
}

H
Haojun Liao 已提交
2866
int32_t parseGroupbyClause(SQueryInfo* pQueryInfo, SArray* pList, SSqlCmd* pCmd) {
2867 2868
  const char* msg1 = "too many columns in group by clause";
  const char* msg2 = "invalid column name in group by clause";
2869
  const char* msg3 = "columns from one table allowed as group by columns";
2870
  const char* msg4 = "join query does not support group by";
S
slguan 已提交
2871 2872 2873
  const char* msg7 = "not support group by expression";
  const char* msg8 = "not allowed column type for group by";
  const char* msg9 = "tags not allowed for table query";
H
hzcheng 已提交
2874

2875
  // todo : handle two tables situation
H
hjxilinx 已提交
2876
  STableMetaInfo* pTableMetaInfo = NULL;
H
hzcheng 已提交
2877 2878 2879 2880 2881

  if (pList == NULL) {
    return TSDB_CODE_SUCCESS;
  }

2882 2883 2884 2885
  if (pQueryInfo->colList == NULL) {
    pQueryInfo->colList = taosArrayInit(4, POINTER_BYTES);
  }
  
S
Shengliang Guan 已提交
2886
  pQueryInfo->groupbyExpr.numOfGroupCols = (int16_t)taosArrayGetSize(pList);
H
Haojun Liao 已提交
2887
  if (pQueryInfo->groupbyExpr.numOfGroupCols > TSDB_MAX_TAGS) {
2888
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
2889 2890
  }

2891 2892 2893 2894
  if (pQueryInfo->numOfTables > 1) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
  }

H
hjxilinx 已提交
2895
  STableMeta* pTableMeta = NULL;
S
slguan 已提交
2896
  SSchema*    pSchema = NULL;
H
hjxilinx 已提交
2897
  SSchema     s = tscGetTbnameColumnSchema();
H
hzcheng 已提交
2898

S
slguan 已提交
2899
  int32_t tableIndex = COLUMN_INDEX_INITIAL_VAL;
H
Haojun Liao 已提交
2900 2901 2902 2903 2904 2905

  size_t num = taosArrayGetSize(pList);
  for (int32_t i = 0; i < num; ++i) {
    tVariantListItem * pItem = taosArrayGet(pList, i);
    tVariant* pVar = &pItem->pVar;

H
Haojun Liao 已提交
2906
    SStrToken token = {pVar->nLen, pVar->nType, pVar->pz};
H
hzcheng 已提交
2907

S
slguan 已提交
2908
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
2909 2910
    if (getColumnIndexByName(pCmd, &token, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
2911
    }
H
hzcheng 已提交
2912

2913 2914 2915 2916 2917
    if (tableIndex == COLUMN_INDEX_INITIAL_VAL) {
      tableIndex = index.tableIndex;
    } else if (tableIndex != index.tableIndex) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }
H
hzcheng 已提交
2918

H
hjxilinx 已提交
2919
    pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
2920
    pTableMeta = pTableMetaInfo->pTableMeta;
2921 2922
  
    int32_t numOfCols = tscGetNumOfColumns(pTableMeta);
S
slguan 已提交
2923 2924 2925
    if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
      pSchema = &s;
    } else {
H
hjxilinx 已提交
2926
      pSchema = tscGetTableColumnSchema(pTableMeta, index.columnIndex);
S
slguan 已提交
2927
    }
H
hzcheng 已提交
2928

S
slguan 已提交
2929
    bool groupTag = false;
2930
    if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX || index.columnIndex >= numOfCols) {
S
slguan 已提交
2931
      groupTag = true;
H
hzcheng 已提交
2932
    }
2933 2934 2935 2936 2937 2938
  
    SSqlGroupbyExpr* pGroupExpr = &pQueryInfo->groupbyExpr;
    if (pGroupExpr->columnInfo == NULL) {
      pGroupExpr->columnInfo = taosArrayInit(4, sizeof(SColIndex));
    }
    
S
slguan 已提交
2939
    if (groupTag) {
weixin_48148422's avatar
weixin_48148422 已提交
2940
      if (!UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
2941
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg9);
S
slguan 已提交
2942 2943
      }

2944 2945 2946 2947
      int32_t relIndex = index.columnIndex;
      if (index.columnIndex != TSDB_TBNAME_COLUMN_INDEX) {
        relIndex -= numOfCols;
      }
S
slguan 已提交
2948

H
hjxilinx 已提交
2949
      SColIndex colIndex = { .colIndex = relIndex, .flag = TSDB_COL_TAG, .colId = pSchema->colId, };
2950
      taosArrayPush(pGroupExpr->columnInfo, &colIndex);
H
hjxilinx 已提交
2951 2952 2953
      
      index.columnIndex = relIndex;
      tscColumnListInsert(pTableMetaInfo->tagColList, &index);
S
slguan 已提交
2954 2955
    } else {
      // check if the column type is valid, here only support the bool/tinyint/smallint/bigint group by
H
Haojun Liao 已提交
2956
      if (pSchema->type == TSDB_DATA_TYPE_TIMESTAMP || pSchema->type == TSDB_DATA_TYPE_FLOAT || pSchema->type == TSDB_DATA_TYPE_DOUBLE) {
2957
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg8);
S
slguan 已提交
2958 2959
      }

2960
      tscColumnListInsert(pQueryInfo->colList, &index);
2961
      
2962
      SColIndex colIndex = { .colIndex = index.columnIndex, .flag = TSDB_COL_NORMAL, .colId = pSchema->colId };
2963
      taosArrayPush(pGroupExpr->columnInfo, &colIndex);
2964
      pQueryInfo->groupbyExpr.orderType = TSDB_ORDER_ASC;
S
slguan 已提交
2965

H
Haojun Liao 已提交
2966
      if (i == 0 && num > 1) {
2967
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
S
slguan 已提交
2968
      }
H
hzcheng 已提交
2969 2970 2971
    }
  }

2972
  pQueryInfo->groupbyExpr.tableIndex = tableIndex;
H
hzcheng 已提交
2973 2974 2975
  return TSDB_CODE_SUCCESS;
}

2976
static SColumnFilterInfo* addColumnFilterInfo(SColumn* pColumn) {
S
slguan 已提交
2977 2978 2979
  if (pColumn == NULL) {
    return NULL;
  }
2980

S
slguan 已提交
2981
  int32_t size = pColumn->numOfFilters + 1;
2982 2983

  char* tmp = (char*) realloc((void*)(pColumn->filterInfo), sizeof(SColumnFilterInfo) * (size));
S
slguan 已提交
2984 2985
  if (tmp != NULL) {
    pColumn->filterInfo = (SColumnFilterInfo*)tmp;
2986 2987
  } else {
    return NULL;
2988 2989
  }

S
slguan 已提交
2990
  pColumn->numOfFilters++;
2991

S
slguan 已提交
2992 2993 2994 2995
  SColumnFilterInfo* pColFilterInfo = &pColumn->filterInfo[pColumn->numOfFilters - 1];
  memset(pColFilterInfo, 0, sizeof(SColumnFilterInfo));

  return pColFilterInfo;
2996 2997
}

2998
static int32_t doExtractColumnFilterInfo(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SColumnFilterInfo* pColumnFilter,
2999
                                         SColumnIndex* columnIndex, tSQLExpr* pExpr) {
S
slguan 已提交
3000
  const char* msg = "not supported filter condition";
H
hzcheng 已提交
3001

S
slguan 已提交
3002
  tSQLExpr*       pRight = pExpr->pRight;
H
hjxilinx 已提交
3003
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, columnIndex->tableIndex);
H
hzcheng 已提交
3004

H
hjxilinx 已提交
3005
  SSchema* pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, columnIndex->columnIndex);
H
hzcheng 已提交
3006

S
slguan 已提交
3007
  int16_t colType = pSchema->type;
3008
  if (colType >= TSDB_DATA_TYPE_TINYINT && colType <= TSDB_DATA_TYPE_BIGINT) {
H
hzcheng 已提交
3009 3010 3011
    colType = TSDB_DATA_TYPE_BIGINT;
  } else if (colType == TSDB_DATA_TYPE_FLOAT || colType == TSDB_DATA_TYPE_DOUBLE) {
    colType = TSDB_DATA_TYPE_DOUBLE;
3012
  } else if ((colType == TSDB_DATA_TYPE_TIMESTAMP) && (TSDB_DATA_TYPE_BINARY == pRight->val.nType)) {
3013
    int retVal = setColumnFilterInfoForTimestamp(pCmd, pQueryInfo, &pRight->val);
3014 3015 3016
    if (TSDB_CODE_SUCCESS != retVal) {
      return retVal;
    }
H
hzcheng 已提交
3017 3018
  }

B
Bomin Zhang 已提交
3019
  int32_t retVal = TSDB_CODE_SUCCESS;
H
hzcheng 已提交
3020
  if (pExpr->nSQLOptr == TK_LE || pExpr->nSQLOptr == TK_LT) {
B
Bomin Zhang 已提交
3021
    retVal = tVariantDump(&pRight->val, (char*)&pColumnFilter->upperBndd, colType, false);
H
hzcheng 已提交
3022

B
Bomin Zhang 已提交
3023 3024 3025 3026 3027
  // TK_GT,TK_GE,TK_EQ,TK_NE are based on the pColumn->lowerBndd
  } else if (colType == TSDB_DATA_TYPE_BINARY) {
    pColumnFilter->pz = (int64_t)calloc(1, pRight->val.nLen + TSDB_NCHAR_SIZE);
    pColumnFilter->len = pRight->val.nLen;
    retVal = tVariantDump(&pRight->val, (char*)pColumnFilter->pz, colType, false);
S
slguan 已提交
3028

B
Bomin Zhang 已提交
3029 3030 3031 3032 3033 3034
  } else if (colType == TSDB_DATA_TYPE_NCHAR) {
    // pRight->val.nLen + 1 is larger than the actual nchar string length
    pColumnFilter->pz = (int64_t)calloc(1, (pRight->val.nLen + 1) * TSDB_NCHAR_SIZE);
    retVal = tVariantDump(&pRight->val, (char*)pColumnFilter->pz, colType, false);
    size_t len = twcslen((wchar_t*)pColumnFilter->pz);
    pColumnFilter->len = len * TSDB_NCHAR_SIZE;
S
slguan 已提交
3035

B
Bomin Zhang 已提交
3036 3037
  } else {
    retVal = tVariantDump(&pRight->val, (char*)&pColumnFilter->lowerBndd, colType, false);
H
hzcheng 已提交
3038 3039
  }

B
Bomin Zhang 已提交
3040 3041 3042 3043
  if (retVal != TSDB_CODE_SUCCESS) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
  } 

H
hzcheng 已提交
3044 3045
  switch (pExpr->nSQLOptr) {
    case TK_LE:
S
slguan 已提交
3046
      pColumnFilter->upperRelOptr = TSDB_RELATION_LESS_EQUAL;
H
hzcheng 已提交
3047 3048
      break;
    case TK_LT:
S
slguan 已提交
3049
      pColumnFilter->upperRelOptr = TSDB_RELATION_LESS;
H
hzcheng 已提交
3050 3051
      break;
    case TK_GT:
3052
      pColumnFilter->lowerRelOptr = TSDB_RELATION_GREATER;
H
hzcheng 已提交
3053 3054
      break;
    case TK_GE:
3055
      pColumnFilter->lowerRelOptr = TSDB_RELATION_GREATER_EQUAL;
H
hzcheng 已提交
3056 3057
      break;
    case TK_EQ:
S
slguan 已提交
3058
      pColumnFilter->lowerRelOptr = TSDB_RELATION_EQUAL;
H
hzcheng 已提交
3059 3060
      break;
    case TK_NE:
S
slguan 已提交
3061
      pColumnFilter->lowerRelOptr = TSDB_RELATION_NOT_EQUAL;
H
hzcheng 已提交
3062 3063
      break;
    case TK_LIKE:
S
slguan 已提交
3064
      pColumnFilter->lowerRelOptr = TSDB_RELATION_LIKE;
H
hzcheng 已提交
3065
      break;
H
Haojun Liao 已提交
3066 3067 3068 3069 3070 3071
    case TK_ISNULL:
      pColumnFilter->lowerRelOptr = TSDB_RELATION_ISNULL;
      break;
    case TK_NOTNULL:
      pColumnFilter->lowerRelOptr = TSDB_RELATION_NOTNULL;
      break;
S
slguan 已提交
3072
    default:
3073
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
3074
  }
S
slguan 已提交
3075

3076
  return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
3077 3078
}

S
slguan 已提交
3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092
typedef struct SCondExpr {
  tSQLExpr* pTagCond;
  tSQLExpr* pTimewindow;

  tSQLExpr* pColumnCond;

  tSQLExpr* pTableCond;
  int16_t   relType;  // relation between table name in expression and other tag
                      // filter condition expression, TK_AND or TK_OR
  int16_t tableCondIndex;

  tSQLExpr* pJoinExpr;  // join condition
  bool      tsJoin;
} SCondExpr;
H
hzcheng 已提交
3093

H
hjxilinx 已提交
3094
static int32_t getTimeRange(STimeWindow* win, tSQLExpr* pRight, int32_t optr, int16_t timePrecision);
S
slguan 已提交
3095 3096

static int32_t tSQLExprNodeToString(tSQLExpr* pExpr, char** str) {
H
hzcheng 已提交
3097
  if (pExpr->nSQLOptr == TK_ID) {  // column name
S
slguan 已提交
3098 3099
    strncpy(*str, pExpr->colInfo.z, pExpr->colInfo.n);
    *str += pExpr->colInfo.n;
H
hzcheng 已提交
3100 3101

  } else if (pExpr->nSQLOptr >= TK_BOOL && pExpr->nSQLOptr <= TK_STRING) {  // value
S
slguan 已提交
3102 3103
    *str += tVariantToString(&pExpr->val, *str);

H
hjxilinx 已提交
3104 3105 3106 3107 3108 3109 3110
  } else if (pExpr->nSQLOptr >= TK_COUNT && pExpr->nSQLOptr <= TK_AVG_IRATE) {
    /*
     * arithmetic expression of aggregation, such as count(ts) + count(ts) *2
     */
    strncpy(*str, pExpr->operand.z, pExpr->operand.n);
    *str += pExpr->operand.n;
  } else {  // not supported operation
S
slguan 已提交
3111 3112 3113 3114 3115 3116
    assert(false);
  }

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
3117
// pExpr->nSQLOptr == 0 while handling "is null" query
S
slguan 已提交
3118 3119
static bool isExprLeafNode(tSQLExpr* pExpr) {
  return (pExpr->pRight == NULL && pExpr->pLeft == NULL) &&
H
Haojun Liao 已提交
3120
         (pExpr->nSQLOptr == 0 || pExpr->nSQLOptr == TK_ID || (pExpr->nSQLOptr >= TK_BOOL && pExpr->nSQLOptr <= TK_NCHAR) || pExpr->nSQLOptr == TK_SET);
S
slguan 已提交
3121 3122
}

H
Haojun Liao 已提交
3123
static bool isExprDirectParentOfLeafNode(tSQLExpr* pExpr) {
S
slguan 已提交
3124 3125 3126 3127 3128
  return (pExpr->pLeft != NULL && pExpr->pRight != NULL) &&
         (isExprLeafNode(pExpr->pLeft) && isExprLeafNode(pExpr->pRight));
}

static int32_t tSQLExprLeafToString(tSQLExpr* pExpr, bool addParentheses, char** output) {
H
Haojun Liao 已提交
3129
  if (!isExprDirectParentOfLeafNode(pExpr)) {
3130
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3131 3132
  }

S
slguan 已提交
3133 3134 3135 3136 3137 3138 3139 3140 3141 3142
  tSQLExpr* pLeft = pExpr->pLeft;
  tSQLExpr* pRight = pExpr->pRight;

  if (addParentheses) {
    *(*output) = '(';
    *output += 1;
  }

  tSQLExprNodeToString(pLeft, output);
  if (optrToString(pExpr, output) != TSDB_CODE_SUCCESS) {
3143
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
3144 3145 3146 3147 3148 3149 3150 3151 3152
  }

  tSQLExprNodeToString(pRight, output);

  if (addParentheses) {
    *(*output) = ')';
    *output += 1;
  }

H
hzcheng 已提交
3153 3154 3155 3156
  return TSDB_CODE_SUCCESS;
}

static int32_t optrToString(tSQLExpr* pExpr, char** exprString) {
S
slguan 已提交
3157 3158 3159 3160
  const char* le = "<=";
  const char* ge = ">=";
  const char* ne = "<>";
  const char* likeOptr = "LIKE";
H
hzcheng 已提交
3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208

  switch (pExpr->nSQLOptr) {
    case TK_LE: {
      *(int16_t*)(*exprString) = *(int16_t*)le;
      *exprString += 1;
      break;
    }
    case TK_GE: {
      *(int16_t*)(*exprString) = *(int16_t*)ge;
      *exprString += 1;
      break;
    }
    case TK_NE: {
      *(int16_t*)(*exprString) = *(int16_t*)ne;
      *exprString += 1;
      break;
    }

    case TK_LT:
      *(*exprString) = '<';
      break;
    case TK_GT:
      *(*exprString) = '>';
      break;
    case TK_EQ:
      *(*exprString) = '=';
      break;
    case TK_PLUS:
      *(*exprString) = '+';
      break;
    case TK_MINUS:
      *(*exprString) = '-';
      break;
    case TK_STAR:
      *(*exprString) = '*';
      break;
    case TK_DIVIDE:
      *(*exprString) = '/';
      break;
    case TK_REM:
      *(*exprString) = '%';
      break;
    case TK_LIKE: {
      int32_t len = sprintf(*exprString, " %s ", likeOptr);
      *exprString += (len - 1);
      break;
    }
    default:
3209
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3210 3211 3212 3213 3214 3215 3216
  }

  *exprString += 1;

  return TSDB_CODE_SUCCESS;
}

H
hjxilinx 已提交
3217
static int32_t tablenameListToString(tSQLExpr* pExpr, SStringBuilder* sb) {
H
hzcheng 已提交
3218 3219
  tSQLExprList* pList = pExpr->pParam;
  if (pList->nExpr <= 0) {
3220
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3221 3222
  }

S
slguan 已提交
3223
  if (pList->nExpr > 0) {
H
hjxilinx 已提交
3224
    taosStringBuilderAppendStringLen(sb, QUERY_COND_REL_PREFIX_IN, QUERY_COND_REL_PREFIX_IN_LEN);
S
slguan 已提交
3225 3226
  }

H
hzcheng 已提交
3227 3228
  for (int32_t i = 0; i < pList->nExpr; ++i) {
    tSQLExpr* pSub = pList->a[i].pNode;
H
hjxilinx 已提交
3229
    taosStringBuilderAppendStringLen(sb, pSub->val.pz, pSub->val.nLen);
S
slguan 已提交
3230 3231

    if (i < pList->nExpr - 1) {
H
hjxilinx 已提交
3232
      taosStringBuilderAppendString(sb, TBNAME_LIST_SEP);
S
slguan 已提交
3233
    }
H
hzcheng 已提交
3234

H
Haojun Liao 已提交
3235
    if (pSub->val.nLen <= 0 || !tscValidateTableNameLength(pSub->val.nLen)) {
3236
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3237 3238 3239 3240 3241 3242
    }
  }

  return TSDB_CODE_SUCCESS;
}

H
hjxilinx 已提交
3243
static int32_t tablenameCondToString(tSQLExpr* pExpr, SStringBuilder* sb) {
H
hjxilinx 已提交
3244 3245
  taosStringBuilderAppendStringLen(sb, QUERY_COND_REL_PREFIX_LIKE, QUERY_COND_REL_PREFIX_LIKE_LEN);
  taosStringBuilderAppendString(sb, pExpr->val.pz);
S
slguan 已提交
3246 3247

  return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
3248 3249
}

S
slguan 已提交
3250 3251 3252 3253 3254 3255
enum {
  TSQL_EXPR_TS = 0,
  TSQL_EXPR_TAG = 1,
  TSQL_EXPR_COLUMN = 2,
  TSQL_EXPR_TBNAME = 3,
};
H
hzcheng 已提交
3256

3257
static int32_t extractColumnFilterInfo(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SColumnIndex* pIndex, tSQLExpr* pExpr, int32_t sqlOptr) {
H
hjxilinx 已提交
3258
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, pIndex->tableIndex);
S
slguan 已提交
3259

H
hjxilinx 已提交
3260 3261
  STableMeta* pTableMeta = pTableMetaInfo->pTableMeta;
  SSchema*    pSchema = tscGetTableColumnSchema(pTableMeta, pIndex->columnIndex);
H
hzcheng 已提交
3262

S
slguan 已提交
3263
  const char* msg1 = "non binary column not support like operator";
H
Hui Li 已提交
3264 3265
  const char* msg2 = "binary column not support this operator";  
  const char* msg3 = "bool column not support this operator";
S
slguan 已提交
3266

H
hjxilinx 已提交
3267
  SColumn* pColumn = tscColumnListInsert(pQueryInfo->colList, pIndex);
S
slguan 已提交
3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280
  SColumnFilterInfo* pColFilter = NULL;

  /*
   * in case of TK_AND filter condition, we first find the corresponding column and build the query condition together
   * the already existed condition.
   */
  if (sqlOptr == TK_AND) {
    // this is a new filter condition on this column
    if (pColumn->numOfFilters == 0) {
      pColFilter = addColumnFilterInfo(pColumn);
    } else {  // update the existed column filter information, find the filter info here
      pColFilter = &pColumn->filterInfo[0];
    }
3281 3282 3283 3284

    if (pColFilter == NULL) {
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
    }
S
slguan 已提交
3285 3286 3287
  } else if (sqlOptr == TK_OR) {
    // TODO fixme: failed to invalid the filter expression: "col1 = 1 OR col2 = 2"
    pColFilter = addColumnFilterInfo(pColumn);
3288 3289 3290
    if (pColFilter == NULL) {
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
    }
S
slguan 已提交
3291
  } else {  // error;
3292
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
3293 3294
  }

3295
  pColFilter->filterstr =
S
slguan 已提交
3296 3297
      ((pSchema->type == TSDB_DATA_TYPE_BINARY || pSchema->type == TSDB_DATA_TYPE_NCHAR) ? 1 : 0);

3298
  if (pColFilter->filterstr) {
3299 3300 3301 3302 3303 3304
    if (pExpr->nSQLOptr != TK_EQ
      && pExpr->nSQLOptr != TK_NE
      && pExpr->nSQLOptr != TK_ISNULL
      && pExpr->nSQLOptr != TK_NOTNULL
      && pExpr->nSQLOptr != TK_LIKE
      ) {
3305
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
3306
    }
S
slguan 已提交
3307 3308
  } else {
    if (pExpr->nSQLOptr == TK_LIKE) {
3309
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
3310
    }
H
Hui Li 已提交
3311 3312 3313
    
    if (pSchema->type == TSDB_DATA_TYPE_BOOL) {
      if (pExpr->nSQLOptr != TK_EQ && pExpr->nSQLOptr != TK_NE) {
3314
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
Hui Li 已提交
3315 3316
      }
    }
S
slguan 已提交
3317 3318 3319
  }

  pColumn->colIndex = *pIndex;
3320
  return doExtractColumnFilterInfo(pCmd, pQueryInfo, pColFilter, pIndex, pExpr);
S
slguan 已提交
3321 3322
}

3323
static void relToString(tSQLExpr* pExpr, char** str) {
S
slguan 已提交
3324 3325 3326 3327 3328
  assert(pExpr->nSQLOptr == TK_AND || pExpr->nSQLOptr == TK_OR);

  const char* or = "OR";
  const char*and = "AND";

3329
  //    if (pQueryInfo->tagCond.relType == TSQL_STABLE_QTYPE_COND) {
S
slguan 已提交
3330 3331 3332 3333 3334 3335 3336 3337 3338
  if (pExpr->nSQLOptr == TK_AND) {
    strcpy(*str, and);
    *str += strlen(and);
  } else {
    strcpy(*str, or);
    *str += strlen(or);
  }
}

3339
UNUSED_FUNC
3340
static int32_t getTagCondString(tSQLExpr* pExpr, char** str) {
S
slguan 已提交
3341 3342 3343 3344
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
3345
  if (!isExprDirectParentOfLeafNode(pExpr)) {
S
slguan 已提交
3346 3347
    *(*str) = '(';
    *str += 1;
H
hzcheng 已提交
3348

3349
    int32_t ret = getTagCondString(pExpr->pLeft, str);
H
hzcheng 已提交
3350
    if (ret != TSDB_CODE_SUCCESS) {
S
slguan 已提交
3351
      return ret;
H
hzcheng 已提交
3352
    }
S
slguan 已提交
3353

3354
    relToString(pExpr, str);
S
slguan 已提交
3355

3356
    ret = getTagCondString(pExpr->pRight, str);
S
slguan 已提交
3357 3358 3359 3360

    *(*str) = ')';
    *str += 1;

H
hzcheng 已提交
3361 3362 3363
    return ret;
  }

S
slguan 已提交
3364 3365 3366
  return tSQLExprLeafToString(pExpr, true, str);
}

3367
static int32_t getTablenameCond(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr* pTableCond, SStringBuilder* sb) {
S
slguan 已提交
3368 3369 3370 3371
  const char* msg0 = "invalid table name list";

  if (pTableCond == NULL) {
    return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
3372 3373
  }

S
slguan 已提交
3374 3375
  tSQLExpr* pLeft = pTableCond->pLeft;
  tSQLExpr* pRight = pTableCond->pRight;
H
hzcheng 已提交
3376

S
slguan 已提交
3377
  if (!isTablenameToken(&pLeft->colInfo)) {
3378
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3379 3380
  }

S
slguan 已提交
3381
  int32_t ret = TSDB_CODE_SUCCESS;
H
hzcheng 已提交
3382

S
slguan 已提交
3383
  if (pTableCond->nSQLOptr == TK_IN) {
H
hjxilinx 已提交
3384
    ret = tablenameListToString(pRight, sb);
S
slguan 已提交
3385
  } else if (pTableCond->nSQLOptr == TK_LIKE) {
H
hjxilinx 已提交
3386
    ret = tablenameCondToString(pRight, sb);
S
slguan 已提交
3387
  }
H
hzcheng 已提交
3388

S
slguan 已提交
3389
  if (ret != TSDB_CODE_SUCCESS) {
3390
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
S
slguan 已提交
3391
  }
H
hzcheng 已提交
3392

S
slguan 已提交
3393 3394 3395
  return ret;
}

3396
static int32_t getColumnQueryCondInfo(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr* pExpr, int32_t relOptr) {
S
slguan 已提交
3397 3398 3399 3400
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
3401
  if (!isExprDirectParentOfLeafNode(pExpr)) {  // internal node
3402
    int32_t ret = getColumnQueryCondInfo(pCmd, pQueryInfo, pExpr->pLeft, pExpr->nSQLOptr);
S
slguan 已提交
3403 3404 3405 3406
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }

3407
    return getColumnQueryCondInfo(pCmd, pQueryInfo, pExpr->pRight, pExpr->nSQLOptr);
S
slguan 已提交
3408 3409
  } else {  // handle leaf node
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
3410
    if (getColumnIndexByName(pCmd, &pExpr->pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
3411
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3412
    }
S
slguan 已提交
3413

3414
    return extractColumnFilterInfo(pCmd, pQueryInfo, &index, pExpr, relOptr);
H
hzcheng 已提交
3415
  }
S
slguan 已提交
3416
}
H
hzcheng 已提交
3417

3418
static int32_t getJoinCondInfo(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr* pExpr) {
H
Haojun Liao 已提交
3419 3420 3421
  const char* msg1 = "invalid join query condition";
  const char* msg3 = "type of join columns must be identical";
  const char* msg4 = "invalid column name in join condition";
H
hzcheng 已提交
3422

S
slguan 已提交
3423 3424 3425
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }
H
hzcheng 已提交
3426

H
Haojun Liao 已提交
3427
  if (!isExprDirectParentOfLeafNode(pExpr)) {
3428
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
3429 3430
  }

3431
  STagCond*  pTagCond = &pQueryInfo->tagCond;
S
slguan 已提交
3432 3433 3434 3435
  SJoinNode* pLeft = &pTagCond->joinInfo.left;
  SJoinNode* pRight = &pTagCond->joinInfo.right;

  SColumnIndex index = COLUMN_INDEX_INITIALIZER;
3436 3437
  if (getColumnIndexByName(pCmd, &pExpr->pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
3438 3439
  }

H
hjxilinx 已提交
3440
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
Haojun Liao 已提交
3441
  SSchema* pTagSchema1 = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, index.columnIndex);
S
slguan 已提交
3442

3443
  pLeft->uid = pTableMetaInfo->pTableMeta->id.uid;
H
Haojun Liao 已提交
3444
  pLeft->tagColId = pTagSchema1->colId;
H
hjxilinx 已提交
3445
  strcpy(pLeft->tableId, pTableMetaInfo->name);
S
slguan 已提交
3446 3447

  index = (SColumnIndex)COLUMN_INDEX_INITIALIZER;
3448 3449
  if (getColumnIndexByName(pCmd, &pExpr->pRight->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
3450 3451
  }

H
hjxilinx 已提交
3452
  pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
Haojun Liao 已提交
3453
  SSchema* pTagSchema2 = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, index.columnIndex);
S
slguan 已提交
3454

3455
  pRight->uid = pTableMetaInfo->pTableMeta->id.uid;
H
Haojun Liao 已提交
3456
  pRight->tagColId = pTagSchema2->colId;
H
hjxilinx 已提交
3457
  strcpy(pRight->tableId, pTableMetaInfo->name);
S
slguan 已提交
3458

H
Haojun Liao 已提交
3459
  if (pTagSchema1->type != pTagSchema2->type) {
3460
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
Haojun Liao 已提交
3461 3462
  }

S
slguan 已提交
3463
  pTagCond->joinInfo.hasJoin = true;
H
hzcheng 已提交
3464 3465 3466 3467
  return TSDB_CODE_SUCCESS;
}

// todo error handle / such as and /or mixed with +/-/*/
3468
int32_t doArithmeticExprToString(tSQLExpr* pExpr, char** exprString) {
H
hzcheng 已提交
3469 3470 3471
  tSQLExpr* pLeft = pExpr->pLeft;
  tSQLExpr* pRight = pExpr->pRight;

H
hjxilinx 已提交
3472
  *(*exprString)++ = '(';
H
hzcheng 已提交
3473 3474

  if (pLeft->nSQLOptr >= TK_PLUS && pLeft->nSQLOptr <= TK_REM) {
3475
    doArithmeticExprToString(pLeft, exprString);
H
hzcheng 已提交
3476
  } else {
S
slguan 已提交
3477
    int32_t ret = tSQLExprNodeToString(pLeft, exprString);
H
hzcheng 已提交
3478
    if (ret != TSDB_CODE_SUCCESS) {
3479
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3480 3481 3482 3483 3484 3485
    }
  }

  optrToString(pExpr, exprString);

  if (pRight->nSQLOptr >= TK_PLUS && pRight->nSQLOptr <= TK_REM) {
3486
    doArithmeticExprToString(pRight, exprString);
H
hzcheng 已提交
3487
  } else {
S
slguan 已提交
3488
    int32_t ret = tSQLExprNodeToString(pRight, exprString);
H
hzcheng 已提交
3489
    if (ret != TSDB_CODE_SUCCESS) {
3490
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3491 3492 3493
    }
  }

H
hjxilinx 已提交
3494
  *(*exprString)++ = ')';
H
hzcheng 已提交
3495 3496 3497 3498

  return TSDB_CODE_SUCCESS;
}

3499 3500
static int32_t validateSQLExpr(SSqlCmd* pCmd, tSQLExpr* pExpr, SQueryInfo* pQueryInfo, SColumnList* pList,
    int32_t* type, uint64_t* uid) {
H
hzcheng 已提交
3501
  if (pExpr->nSQLOptr == TK_ID) {
H
hjxilinx 已提交
3502 3503 3504
    if (*type == NON_ARITHMEIC_EXPR) {
      *type = NORMAL_ARITHMETIC;
    } else if (*type == AGG_ARIGHTMEIC) {
3505
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3506
    }
L
lihui 已提交
3507

H
hjxilinx 已提交
3508
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
3509
    if (getColumnIndexByName(pCmd, &pExpr->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
3510
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3511 3512 3513
    }

    // if column is timestamp, bool, binary, nchar, not support arithmetic, so return invalid sql
H
hjxilinx 已提交
3514
    STableMeta* pTableMeta = tscGetMetaInfo(pQueryInfo, index.tableIndex)->pTableMeta;
H
hjxilinx 已提交
3515 3516
    SSchema*    pSchema = tscGetTableSchema(pTableMeta) + index.columnIndex;
    
H
hjxilinx 已提交
3517 3518
    if ((pSchema->type == TSDB_DATA_TYPE_TIMESTAMP) || (pSchema->type == TSDB_DATA_TYPE_BOOL) ||
        (pSchema->type == TSDB_DATA_TYPE_BINARY) || (pSchema->type == TSDB_DATA_TYPE_NCHAR)) {
3519
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3520 3521 3522
    }

    pList->ids[pList->num++] = index;
H
hzcheng 已提交
3523
  } else if (pExpr->nSQLOptr == TK_FLOAT && (isnan(pExpr->val.dKey) || isinf(pExpr->val.dKey))) {
3524
    return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3525 3526 3527 3528
  } else if (pExpr->nSQLOptr >= TK_COUNT && pExpr->nSQLOptr <= TK_AVG_IRATE) {
    if (*type == NON_ARITHMEIC_EXPR) {
      *type = AGG_ARIGHTMEIC;
    } else if (*type == NORMAL_ARITHMETIC) {
3529
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3530 3531
    }

S
TD-1057  
Shengliang Guan 已提交
3532
    int32_t outputIndex = (int32_t)tscSqlExprNumOfExprs(pQueryInfo);
H
hjxilinx 已提交
3533
  
H
Haojun Liao 已提交
3534
    tSqlExprItem item = {.pNode = pExpr, .aliasName = NULL};
H
hjxilinx 已提交
3535
  
H
Haojun Liao 已提交
3536 3537
    // sql function list in selection clause.
    // Append the sqlExpr into exprList of pQueryInfo structure sequentially
3538
    if (addExprAndResultField(pCmd, pQueryInfo, outputIndex, &item, false) != TSDB_CODE_SUCCESS) {
3539
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3540
    }
H
Haojun Liao 已提交
3541 3542 3543 3544 3545 3546 3547 3548

    // It is invalid in case of more than one sqlExpr, such as first(ts, k) - last(ts, k)
    int32_t inc = (int32_t) tscSqlExprNumOfExprs(pQueryInfo) - outputIndex;
    if (inc > 1) {
      return TSDB_CODE_TSC_INVALID_SQL;
    }

    // Not supported data type in arithmetic expression
3549
    uint64_t id = -1;
H
Haojun Liao 已提交
3550 3551 3552 3553 3554 3555
    for(int32_t i = 0; i < inc; ++i) {
      SSqlExpr* p1 = tscSqlExprGet(pQueryInfo, i + outputIndex);
      int16_t t = p1->resType;
      if (t == TSDB_DATA_TYPE_BINARY || t == TSDB_DATA_TYPE_NCHAR || t == TSDB_DATA_TYPE_BOOL || t == TSDB_DATA_TYPE_TIMESTAMP) {
        return TSDB_CODE_TSC_INVALID_SQL;
      }
3556 3557 3558

      if (i == 0) {
        id = p1->uid;
H
Haojun Liao 已提交
3559
      } else if (id != p1->uid) {
3560 3561
        return TSDB_CODE_TSC_INVALID_SQL;
      }
H
Haojun Liao 已提交
3562
    }
3563 3564

    *uid = id;
H
hzcheng 已提交
3565 3566 3567 3568 3569
  }

  return TSDB_CODE_SUCCESS;
}

3570
static int32_t validateArithmeticSQLExpr(SSqlCmd* pCmd, tSQLExpr* pExpr, SQueryInfo* pQueryInfo, SColumnList* pList, int32_t* type) {
H
hzcheng 已提交
3571 3572 3573 3574 3575
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

  tSQLExpr* pLeft = pExpr->pLeft;
3576 3577 3578
  uint64_t uidLeft = 0;
  uint64_t uidRight = 0;

H
hzcheng 已提交
3579
  if (pLeft->nSQLOptr >= TK_PLUS && pLeft->nSQLOptr <= TK_REM) {
3580
    int32_t ret = validateArithmeticSQLExpr(pCmd, pLeft, pQueryInfo, pList, type);
H
hzcheng 已提交
3581 3582 3583 3584
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
  } else {
3585
    int32_t ret = validateSQLExpr(pCmd, pLeft, pQueryInfo, pList, type, &uidLeft);
H
hzcheng 已提交
3586 3587 3588 3589 3590 3591 3592
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
  }

  tSQLExpr* pRight = pExpr->pRight;
  if (pRight->nSQLOptr >= TK_PLUS && pRight->nSQLOptr <= TK_REM) {
3593
    int32_t ret = validateArithmeticSQLExpr(pCmd, pRight, pQueryInfo, pList, type);
H
hzcheng 已提交
3594 3595 3596 3597
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
  } else {
3598
    int32_t ret = validateSQLExpr(pCmd, pRight, pQueryInfo, pList, type, &uidRight);
H
hzcheng 已提交
3599 3600 3601
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
3602 3603

    // the expression not from the same table, return error
3604
    if (uidLeft != uidRight && uidLeft != 0 && uidRight != 0) {
3605 3606
      return TSDB_CODE_TSC_INVALID_SQL;
    }
H
hzcheng 已提交
3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618
  }

  return TSDB_CODE_SUCCESS;
}

static bool isValidExpr(tSQLExpr* pLeft, tSQLExpr* pRight, int32_t optr) {
  if (pLeft == NULL || (pRight == NULL && optr != TK_IN)) {
    return false;
  }

  /*
   * filter illegal expression in where clause:
S
slguan 已提交
3619 3620 3621
   * 1. count(*) > 12
   * 2. sum(columnA) > sum(columnB)
   * 3. 4 < 5,  'ABC'>'abc'
H
hzcheng 已提交
3622 3623 3624
   *
   * However, columnA < 4+12 is valid
   */
B
Bomin Zhang 已提交
3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640
  if (pLeft->nSQLOptr >= TK_COUNT && pLeft->nSQLOptr <= TK_AVG_IRATE) {
    return false;
  }

  if (pRight == NULL) {
    return true;
  }

  if (pRight->nSQLOptr >= TK_COUNT && pRight->nSQLOptr <= TK_AVG_IRATE) {
    return false;
  }
  
  if (pLeft->nSQLOptr >= TK_BOOL
    && pLeft->nSQLOptr <= TK_BINARY
    && pRight->nSQLOptr >= TK_BOOL
    && pRight->nSQLOptr <= TK_BINARY) {
H
hzcheng 已提交
3641 3642 3643 3644 3645 3646
    return false;
  }

  return true;
}

S
slguan 已提交
3647 3648 3649
static void exchangeExpr(tSQLExpr* pExpr) {
  tSQLExpr* pLeft = pExpr->pLeft;
  tSQLExpr* pRight = pExpr->pRight;
H
hzcheng 已提交
3650

S
slguan 已提交
3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675
  if (pRight->nSQLOptr == TK_ID && (pLeft->nSQLOptr == TK_INTEGER || pLeft->nSQLOptr == TK_FLOAT ||
                                    pLeft->nSQLOptr == TK_STRING || pLeft->nSQLOptr == TK_BOOL)) {
    /*
     * exchange value of the left handside and the value of the right-handside
     * to make sure that the value of filter expression always locates in
     * right-handside and
     * the column-id is at the left handside.
     */
    uint32_t optr = 0;
    switch (pExpr->nSQLOptr) {
      case TK_LE:
        optr = TK_GE;
        break;
      case TK_LT:
        optr = TK_GT;
        break;
      case TK_GT:
        optr = TK_LT;
        break;
      case TK_GE:
        optr = TK_LE;
        break;
      default:
        optr = pExpr->nSQLOptr;
    }
H
hzcheng 已提交
3676

S
slguan 已提交
3677 3678 3679 3680 3681
    pExpr->nSQLOptr = optr;
    SWAP(pExpr->pLeft, pExpr->pRight, void*);
  }
}

3682
static bool validateJoinExprNode(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr* pExpr, SColumnIndex* pLeftIndex) {
S
slguan 已提交
3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695
  const char* msg1 = "illegal column name";
  const char* msg2 = "= is expected in join expression";
  const char* msg3 = "join column must have same type";
  const char* msg4 = "self join is not allowed";
  const char* msg5 = "join table must be the same type(table to table, super table to super table)";

  tSQLExpr* pRight = pExpr->pRight;

  if (pRight->nSQLOptr != TK_ID) {
    return true;
  }

  if (pExpr->nSQLOptr != TK_EQ) {
3696
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
3697 3698 3699 3700 3701
    return false;
  }

  SColumnIndex rightIndex = COLUMN_INDEX_INITIALIZER;

3702 3703
  if (getColumnIndexByName(pCmd, &pRight->colInfo, pQueryInfo, &rightIndex) != TSDB_CODE_SUCCESS) {
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
3704
    return false;
H
hzcheng 已提交
3705 3706
  }

S
slguan 已提交
3707
  // todo extract function
H
hjxilinx 已提交
3708
  STableMetaInfo* pLeftMeterMeta = tscGetMetaInfo(pQueryInfo, pLeftIndex->tableIndex);
H
hjxilinx 已提交
3709
  SSchema*        pLeftSchema = tscGetTableSchema(pLeftMeterMeta->pTableMeta);
S
slguan 已提交
3710 3711
  int16_t         leftType = pLeftSchema[pLeftIndex->columnIndex].type;

H
hjxilinx 已提交
3712
  STableMetaInfo* pRightMeterMeta = tscGetMetaInfo(pQueryInfo, rightIndex.tableIndex);
H
hjxilinx 已提交
3713
  SSchema*        pRightSchema = tscGetTableSchema(pRightMeterMeta->pTableMeta);
S
slguan 已提交
3714 3715 3716
  int16_t         rightType = pRightSchema[rightIndex.columnIndex].type;

  if (leftType != rightType) {
3717
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
3718 3719
    return false;
  } else if (pLeftIndex->tableIndex == rightIndex.tableIndex) {
3720
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
3721
    return false;
H
hzcheng 已提交
3722 3723
  }

S
slguan 已提交
3724
  // table to table/ super table to super table are allowed
weixin_48148422's avatar
weixin_48148422 已提交
3725
  if (UTIL_TABLE_IS_SUPER_TABLE(pLeftMeterMeta) != UTIL_TABLE_IS_SUPER_TABLE(pRightMeterMeta)) {
3726
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
S
slguan 已提交
3727 3728
    return false;
  }
H
hzcheng 已提交
3729

S
slguan 已提交
3730 3731
  return true;
}
H
hzcheng 已提交
3732

S
slguan 已提交
3733 3734 3735 3736 3737 3738
static bool validTableNameOptr(tSQLExpr* pExpr) {
  const char nameFilterOptr[] = {TK_IN, TK_LIKE};

  for (int32_t i = 0; i < tListLen(nameFilterOptr); ++i) {
    if (pExpr->nSQLOptr == nameFilterOptr[i]) {
      return true;
H
hzcheng 已提交
3739 3740 3741
    }
  }

S
slguan 已提交
3742
  return false;
H
hzcheng 已提交
3743 3744
}

3745
static int32_t setExprToCond(tSQLExpr** parent, tSQLExpr* pExpr, const char* msg, int32_t parentOptr, char* msgBuf) {
S
slguan 已提交
3746 3747
  if (*parent != NULL) {
    if (parentOptr == TK_OR && msg != NULL) {
3748
      return invalidSqlErrMsg(msgBuf, msg);
S
slguan 已提交
3749
    }
H
hzcheng 已提交
3750

H
Haojun Liao 已提交
3751
    *parent = tSqlExprCreate((*parent), pExpr, parentOptr);
S
slguan 已提交
3752 3753 3754
  } else {
    *parent = pExpr;
  }
H
hzcheng 已提交
3755

S
slguan 已提交
3756 3757
  return TSDB_CODE_SUCCESS;
}
H
hzcheng 已提交
3758

3759 3760
static int32_t handleExprInQueryCond(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr** pExpr, SCondExpr* pCondExpr,
                                     int32_t* type, int32_t parentOptr) {
3761
  const char* msg1 = "table query cannot use tags filter";
S
slguan 已提交
3762 3763 3764
  const char* msg2 = "illegal column name";
  const char* msg3 = "only one query time range allowed";
  const char* msg4 = "only one join condition allowed";
H
hjxilinx 已提交
3765 3766 3767
  const char* msg5 = "not support ordinary column join";
  const char* msg6 = "only one query condition on tbname allowed";
  const char* msg7 = "only in/like allowed in filter table name";
3768 3769
  const char* msg8 = "wildcard string should be less than 20 characters";
  
S
slguan 已提交
3770 3771
  tSQLExpr* pLeft = (*pExpr)->pLeft;
  tSQLExpr* pRight = (*pExpr)->pRight;
H
hzcheng 已提交
3772

S
slguan 已提交
3773 3774 3775
  int32_t ret = TSDB_CODE_SUCCESS;

  SColumnIndex index = COLUMN_INDEX_INITIALIZER;
3776 3777
  if (getColumnIndexByName(pCmd, &pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
3778 3779
  }

H
Haojun Liao 已提交
3780
  assert(isExprDirectParentOfLeafNode(*pExpr));
S
slguan 已提交
3781

H
hjxilinx 已提交
3782
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
3783
  STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;
S
slguan 已提交
3784 3785

  if (index.columnIndex == PRIMARYKEY_TIMESTAMP_COL_INDEX) {  // query on time range
3786
    if (!validateJoinExprNode(pCmd, pQueryInfo, *pExpr, &index)) {
3787
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3788
    }
S
slguan 已提交
3789 3790 3791

    // set join query condition
    if (pRight->nSQLOptr == TK_ID) {  // no need to keep the timestamp join condition
H
hjxilinx 已提交
3792
      TSDB_QUERY_SET_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_JOIN_QUERY);
S
slguan 已提交
3793 3794 3795 3796 3797 3798
      pCondExpr->tsJoin = true;

      /*
       * to release expression, e.g., m1.ts = m2.ts,
       * since this expression is used to set the join query type
       */
H
Haojun Liao 已提交
3799
      tSqlExprDestroy(*pExpr);
S
slguan 已提交
3800
    } else {
3801
      ret = setExprToCond(&pCondExpr->pTimewindow, *pExpr, msg3, parentOptr, pQueryInfo->msg);
S
slguan 已提交
3802 3803 3804 3805
    }

    *pExpr = NULL;  // remove this expression
    *type = TSQL_EXPR_TS;
3806 3807
  } else if (index.columnIndex >= tscGetNumOfColumns(pTableMeta) || index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
    // query on tags, check for tag query condition
weixin_48148422's avatar
weixin_48148422 已提交
3808
    if (UTIL_TABLE_IS_NORMAL_TABLE(pTableMetaInfo)) {
3809
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
3810 3811 3812 3813 3814
    }

    // check for like expression
    if ((*pExpr)->nSQLOptr == TK_LIKE) {
      if (pRight->val.nLen > TSDB_PATTERN_STRING_MAX_LEN) {
3815
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg8);
S
slguan 已提交
3816 3817
      }

H
hjxilinx 已提交
3818
      SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
3819 3820 3821

      if ((!isTablenameToken(&pLeft->colInfo)) && pSchema[index.columnIndex].type != TSDB_DATA_TYPE_BINARY &&
          pSchema[index.columnIndex].type != TSDB_DATA_TYPE_NCHAR) {
3822
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
3823 3824 3825
      }
    }

H
Haojun Liao 已提交
3826
    // in case of in operator, keep it in a seprate attribute
S
slguan 已提交
3827 3828
    if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
      if (!validTableNameOptr(*pExpr)) {
3829
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
S
slguan 已提交
3830
      }
3831 3832
  
      if (!UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
3833
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
3834
      }
S
slguan 已提交
3835 3836 3837 3838 3839 3840

      if (pCondExpr->pTableCond == NULL) {
        pCondExpr->pTableCond = *pExpr;
        pCondExpr->relType = parentOptr;
        pCondExpr->tableCondIndex = index.tableIndex;
      } else {
3841
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
S
slguan 已提交
3842 3843 3844 3845 3846
      }

      *type = TSQL_EXPR_TBNAME;
      *pExpr = NULL;
    } else {
H
Haojun Liao 已提交
3847
      if (pRight != NULL && pRight->nSQLOptr == TK_ID) {  // join on tag columns for stable query
3848
        if (!validateJoinExprNode(pCmd, pQueryInfo, *pExpr, &index)) {
3849
          return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
3850 3851 3852
        }

        if (pCondExpr->pJoinExpr != NULL) {
3853
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
3854 3855
        }

3856 3857
        pQueryInfo->type |= TSDB_QUERY_TYPE_JOIN_QUERY;
        ret = setExprToCond(&pCondExpr->pJoinExpr, *pExpr, NULL, parentOptr, pQueryInfo->msg);
S
slguan 已提交
3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871
        *pExpr = NULL;
      } else {
        // do nothing
        //                ret = setExprToCond(pCmd, &pCondExpr->pTagCond,
        //                *pExpr, NULL, parentOptr);
      }

      *type = TSQL_EXPR_TAG;
    }

  } else {  // query on other columns
    *type = TSQL_EXPR_COLUMN;

    if (pRight->nSQLOptr == TK_ID) {  // other column cannot be served as the join column
3872
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
3873 3874
    }

3875
    ret = setExprToCond(&pCondExpr->pColumnCond, *pExpr, NULL, parentOptr, pQueryInfo->msg);
S
slguan 已提交
3876 3877
    *pExpr = NULL;  // remove it from expr tree
  }
H
hzcheng 已提交
3878

S
slguan 已提交
3879
  return ret;
H
hzcheng 已提交
3880 3881
}

3882 3883
int32_t getQueryCondExpr(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr** pExpr, SCondExpr* pCondExpr,
                        int32_t* type, int32_t parentOptr) {
H
hzcheng 已提交
3884 3885 3886 3887
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

S
slguan 已提交
3888
  const char* msg1 = "query condition between different columns must use 'AND'";
H
hzcheng 已提交
3889

S
slguan 已提交
3890 3891 3892 3893
  tSQLExpr* pLeft = (*pExpr)->pLeft;
  tSQLExpr* pRight = (*pExpr)->pRight;

  if (!isValidExpr(pLeft, pRight, (*pExpr)->nSQLOptr)) {
3894
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3895 3896
  }

S
slguan 已提交
3897 3898
  int32_t leftType = -1;
  int32_t rightType = -1;
H
hzcheng 已提交
3899

H
Haojun Liao 已提交
3900
  if (!isExprDirectParentOfLeafNode(*pExpr)) {
3901
    int32_t ret = getQueryCondExpr(pCmd, pQueryInfo, &(*pExpr)->pLeft, pCondExpr, &leftType, (*pExpr)->nSQLOptr);
H
hzcheng 已提交
3902 3903 3904 3905
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }

3906
    ret = getQueryCondExpr(pCmd, pQueryInfo, &(*pExpr)->pRight, pCondExpr, &rightType, (*pExpr)->nSQLOptr);
S
slguan 已提交
3907 3908 3909
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
H
hzcheng 已提交
3910

S
slguan 已提交
3911 3912 3913 3914 3915 3916
    /*
     *  if left child and right child do not belong to the same group, the sub
     *  expression is not valid for parent node, it must be TK_AND operator.
     */
    if (leftType != rightType) {
      if ((*pExpr)->nSQLOptr == TK_OR && (leftType + rightType != TSQL_EXPR_TBNAME + TSQL_EXPR_TAG)) {
3917
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
3918
      }
H
hzcheng 已提交
3919 3920
    }

S
slguan 已提交
3921 3922 3923
    *type = rightType;
    return TSDB_CODE_SUCCESS;
  }
H
hzcheng 已提交
3924

S
slguan 已提交
3925
  exchangeExpr(*pExpr);
H
hzcheng 已提交
3926

3927
  return handleExprInQueryCond(pCmd, pQueryInfo, pExpr, pCondExpr, type, parentOptr);
S
slguan 已提交
3928
}
H
hzcheng 已提交
3929

S
slguan 已提交
3930
static void doCompactQueryExpr(tSQLExpr** pExpr) {
3931
  if (*pExpr == NULL || isExprDirectParentOfLeafNode(*pExpr)) {
S
slguan 已提交
3932 3933
    return;
  }
H
hzcheng 已提交
3934

S
slguan 已提交
3935 3936 3937
  if ((*pExpr)->pLeft) {
    doCompactQueryExpr(&(*pExpr)->pLeft);
  }
H
hzcheng 已提交
3938

S
slguan 已提交
3939 3940 3941
  if ((*pExpr)->pRight) {
    doCompactQueryExpr(&(*pExpr)->pRight);
  }
H
hzcheng 已提交
3942

S
slguan 已提交
3943 3944
  if ((*pExpr)->pLeft == NULL && (*pExpr)->pRight == NULL &&
      ((*pExpr)->nSQLOptr == TK_OR || (*pExpr)->nSQLOptr == TK_AND)) {
H
Haojun Liao 已提交
3945
    tSqlExprNodeDestroy(*pExpr);
S
slguan 已提交
3946
    *pExpr = NULL;
H
hzcheng 已提交
3947

S
slguan 已提交
3948 3949
  } else if ((*pExpr)->pLeft == NULL && (*pExpr)->pRight != NULL) {
    tSQLExpr* tmpPtr = (*pExpr)->pRight;
H
Haojun Liao 已提交
3950
    tSqlExprNodeDestroy(*pExpr);
H
hzcheng 已提交
3951

S
slguan 已提交
3952 3953 3954
    (*pExpr) = tmpPtr;
  } else if ((*pExpr)->pRight == NULL && (*pExpr)->pLeft != NULL) {
    tSQLExpr* tmpPtr = (*pExpr)->pLeft;
H
Haojun Liao 已提交
3955
    tSqlExprNodeDestroy(*pExpr);
H
hzcheng 已提交
3956

S
slguan 已提交
3957
    (*pExpr) = tmpPtr;
H
hzcheng 已提交
3958
  }
S
slguan 已提交
3959
}
H
hzcheng 已提交
3960

3961
static void doExtractExprForSTable(SSqlCmd* pCmd, tSQLExpr** pExpr, SQueryInfo* pQueryInfo, tSQLExpr** pOut, int32_t tableIndex) {
H
Haojun Liao 已提交
3962
  if (isExprDirectParentOfLeafNode(*pExpr)) {
S
slguan 已提交
3963 3964 3965
    tSQLExpr* pLeft = (*pExpr)->pLeft;

    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
3966
    if (getColumnIndexByName(pCmd, &pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
3967
      return;
H
hzcheng 已提交
3968 3969
    }

S
slguan 已提交
3970 3971 3972 3973 3974 3975 3976 3977
    if (index.tableIndex != tableIndex) {
      return;
    }

    *pOut = *pExpr;
    (*pExpr) = NULL;

  } else {
H
Haojun Liao 已提交
3978
    *pOut = tSqlExprCreate(NULL, NULL, (*pExpr)->nSQLOptr);
S
slguan 已提交
3979

3980 3981
    doExtractExprForSTable(pCmd, &(*pExpr)->pLeft, pQueryInfo, &((*pOut)->pLeft), tableIndex);
    doExtractExprForSTable(pCmd, &(*pExpr)->pRight, pQueryInfo, &((*pOut)->pRight), tableIndex);
S
slguan 已提交
3982 3983 3984
  }
}

3985
static tSQLExpr* extractExprForSTable(SSqlCmd* pCmd, tSQLExpr** pExpr, SQueryInfo* pQueryInfo, int32_t tableIndex) {
S
slguan 已提交
3986
  tSQLExpr* pResExpr = NULL;
H
hzcheng 已提交
3987

S
slguan 已提交
3988
  if (*pExpr != NULL) {
3989
    doExtractExprForSTable(pCmd, pExpr, pQueryInfo, &pResExpr, tableIndex);
S
slguan 已提交
3990
    doCompactQueryExpr(&pResExpr);
H
hzcheng 已提交
3991 3992
  }

S
slguan 已提交
3993
  return pResExpr;
H
hzcheng 已提交
3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008
}

int tableNameCompar(const void* lhs, const void* rhs) {
  char* left = *(char**)lhs;
  char* right = *(char**)rhs;

  int32_t ret = strcmp(left, right);

  if (ret == 0) {
    return 0;
  }

  return ret > 0 ? 1 : -1;
}

4009 4010
static int32_t setTableCondForSTableQuery(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, const char* account,
                                          tSQLExpr* pExpr, int16_t tableCondIndex, SStringBuilder* sb) {
4011
  const char* msg = "table name too long";
H
hzcheng 已提交
4012

S
slguan 已提交
4013 4014 4015 4016
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

H
hjxilinx 已提交
4017
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, tableCondIndex);
S
slguan 已提交
4018

4019
  STagCond* pTagCond = &pQueryInfo->tagCond;
4020
  pTagCond->tbnameCond.uid = pTableMetaInfo->pTableMeta->id.uid;
S
slguan 已提交
4021 4022 4023 4024

  assert(pExpr->nSQLOptr == TK_LIKE || pExpr->nSQLOptr == TK_IN);

  if (pExpr->nSQLOptr == TK_LIKE) {
H
hjxilinx 已提交
4025
    char* str = taosStringBuilderGetResult(sb, NULL);
4026
    pQueryInfo->tagCond.tbnameCond.cond = strdup(str);
H
Haojun Liao 已提交
4027
    pQueryInfo->tagCond.tbnameCond.len = (int32_t) strlen(str);
S
slguan 已提交
4028 4029 4030
    return TSDB_CODE_SUCCESS;
  }

S
Shuduo Sang 已提交
4031
  SStringBuilder sb1; memset(&sb1, 0, sizeof(sb1));
H
hjxilinx 已提交
4032
  taosStringBuilderAppendStringLen(&sb1, QUERY_COND_REL_PREFIX_IN, QUERY_COND_REL_PREFIX_IN_LEN);
H
hzcheng 已提交
4033

H
Haojun Liao 已提交
4034
  char db[TSDB_TABLE_FNAME_LEN] = {0};
H
hzcheng 已提交
4035

S
slguan 已提交
4036
  // remove the duplicated input table names
H
hzcheng 已提交
4037
  int32_t num = 0;
H
hjxilinx 已提交
4038 4039 4040
  char*   tableNameString = taosStringBuilderGetResult(sb, NULL);

  char** segments = strsplit(tableNameString + QUERY_COND_REL_PREFIX_IN_LEN, TBNAME_LIST_SEP, &num);
H
hjxilinx 已提交
4041
  qsort(segments, num, POINTER_BYTES, tableNameCompar);
H
hzcheng 已提交
4042 4043 4044 4045 4046 4047 4048 4049 4050

  int32_t j = 1;
  for (int32_t i = 1; i < num; ++i) {
    if (strcmp(segments[i], segments[i - 1]) != 0) {
      segments[j++] = segments[i];
    }
  }
  num = j;

H
hjxilinx 已提交
4051
  char* name = extractDBName(pTableMetaInfo->name, db);
H
Haojun Liao 已提交
4052
  SStrToken dbToken = { .type = TK_STRING, .z = name, .n = (uint32_t)strlen(name) };
H
hjxilinx 已提交
4053
  
H
hzcheng 已提交
4054 4055
  for (int32_t i = 0; i < num; ++i) {
    if (i >= 1) {
H
hjxilinx 已提交
4056
      taosStringBuilderAppendStringLen(&sb1, TBNAME_LIST_SEP, 1);
H
hzcheng 已提交
4057
    }
H
hjxilinx 已提交
4058

H
Haojun Liao 已提交
4059
    char      idBuf[TSDB_TABLE_FNAME_LEN] = {0};
S
TD-1057  
Shengliang Guan 已提交
4060
    int32_t   xlen = (int32_t)strlen(segments[i]);
H
Haojun Liao 已提交
4061
    SStrToken t = {.z = segments[i], .n = xlen, .type = TK_STRING};
H
hzcheng 已提交
4062

4063
    int32_t ret = setObjFullName(idBuf, account, &dbToken, &t, &xlen);
H
hzcheng 已提交
4064
    if (ret != TSDB_CODE_SUCCESS) {
H
hjxilinx 已提交
4065
      taosStringBuilderDestroy(&sb1);
S
TD-1848  
Shengliang Guan 已提交
4066
      tfree(segments);
H
hjxilinx 已提交
4067

4068
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
4069 4070
      return ret;
    }
H
hjxilinx 已提交
4071

H
hjxilinx 已提交
4072
    taosStringBuilderAppendString(&sb1, idBuf);
H
hzcheng 已提交
4073
  }
H
hjxilinx 已提交
4074

H
hjxilinx 已提交
4075
  char* str = taosStringBuilderGetResult(&sb1, NULL);
4076
  pQueryInfo->tagCond.tbnameCond.cond = strdup(str);
H
Haojun Liao 已提交
4077
  pQueryInfo->tagCond.tbnameCond.len = (int32_t) strlen(str);
H
hjxilinx 已提交
4078

H
hjxilinx 已提交
4079
  taosStringBuilderDestroy(&sb1);
S
TD-1848  
Shengliang Guan 已提交
4080
  tfree(segments);
H
hzcheng 已提交
4081 4082 4083
  return TSDB_CODE_SUCCESS;
}

4084
static bool validateFilterExpr(SQueryInfo* pQueryInfo) {
4085 4086 4087 4088 4089 4090
  SArray* pColList = pQueryInfo->colList;
  
  size_t num = taosArrayGetSize(pColList);
  
  for (int32_t i = 0; i < num; ++i) {
    SColumn* pCol = taosArrayGetP(pColList, i);
4091

4092 4093
    for (int32_t j = 0; j < pCol->numOfFilters; ++j) {
      SColumnFilterInfo* pColFilter = &pCol->filterInfo[j];
S
slguan 已提交
4094 4095
      int32_t            lowerOptr = pColFilter->lowerRelOptr;
      int32_t            upperOptr = pColFilter->upperRelOptr;
4096

4097
      if ((lowerOptr == TSDB_RELATION_GREATER_EQUAL || lowerOptr == TSDB_RELATION_GREATER) &&
4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111
          (upperOptr == TSDB_RELATION_LESS_EQUAL || upperOptr == TSDB_RELATION_LESS)) {
        continue;
      }

      // there must be at least two range, not support yet.
      if (lowerOptr * upperOptr != TSDB_RELATION_INVALID) {
        return false;
      }
    }
  }

  return true;
}

4112
static int32_t getTimeRangeFromExpr(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr* pExpr) {
S
slguan 已提交
4113 4114
  const char* msg0 = "invalid timestamp";
  const char* msg1 = "only one time stamp window allowed";
H
hzcheng 已提交
4115 4116 4117 4118 4119

  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
4120
  if (!isExprDirectParentOfLeafNode(pExpr)) {
S
slguan 已提交
4121
    if (pExpr->nSQLOptr == TK_OR) {
4122
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
4123
    }
H
hzcheng 已提交
4124

4125
    getTimeRangeFromExpr(pCmd, pQueryInfo, pExpr->pLeft);
S
slguan 已提交
4126

4127
    return getTimeRangeFromExpr(pCmd, pQueryInfo, pExpr->pRight);
S
slguan 已提交
4128 4129
  } else {
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
4130
    if (getColumnIndexByName(pCmd, &pExpr->pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
4131
      return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
4132 4133
    }

H
hjxilinx 已提交
4134
    STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
4135
    STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);
H
hjxilinx 已提交
4136
    
S
slguan 已提交
4137 4138
    tSQLExpr* pRight = pExpr->pRight;

H
hjxilinx 已提交
4139 4140
    STimeWindow win = {.skey = INT64_MIN, .ekey = INT64_MAX};
    if (getTimeRange(&win, pRight, pExpr->nSQLOptr, tinfo.precision) != TSDB_CODE_SUCCESS) {
4141
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
S
slguan 已提交
4142 4143 4144
    }

    // update the timestamp query range
H
hjxilinx 已提交
4145 4146
    if (pQueryInfo->window.skey < win.skey) {
      pQueryInfo->window.skey = win.skey;
S
slguan 已提交
4147 4148
    }

H
hjxilinx 已提交
4149 4150
    if (pQueryInfo->window.ekey > win.ekey) {
      pQueryInfo->window.ekey = win.ekey;
S
slguan 已提交
4151 4152 4153 4154 4155 4156
    }
  }

  return TSDB_CODE_SUCCESS;
}

4157
static int32_t validateJoinExpr(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SCondExpr* pCondExpr) {
S
slguan 已提交
4158 4159 4160 4161
  const char* msg1 = "super table join requires tags column";
  const char* msg2 = "timestamp join condition missing";
  const char* msg3 = "condition missing for join query";

4162 4163
  if (!QUERY_IS_JOIN_QUERY(pQueryInfo->type)) {
    if (pQueryInfo->numOfTables == 1) {
S
slguan 已提交
4164 4165
      return TSDB_CODE_SUCCESS;
    } else {
4166
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
4167 4168 4169
    }
  }

H
hjxilinx 已提交
4170
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
weixin_48148422's avatar
weixin_48148422 已提交
4171
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {  // for stable join, tag columns
4172
                                                   // must be present for join
S
slguan 已提交
4173
    if (pCondExpr->pJoinExpr == NULL) {
4174
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
4175 4176 4177 4178
    }
  }

  if (!pCondExpr->tsJoin) {
4179
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4180 4181
  }

S
slguan 已提交
4182 4183 4184 4185 4186
  return TSDB_CODE_SUCCESS;
}

static void cleanQueryExpr(SCondExpr* pCondExpr) {
  if (pCondExpr->pTableCond) {
H
Haojun Liao 已提交
4187
    tSqlExprDestroy(pCondExpr->pTableCond);
S
slguan 已提交
4188 4189 4190
  }

  if (pCondExpr->pTagCond) {
H
Haojun Liao 已提交
4191
    tSqlExprDestroy(pCondExpr->pTagCond);
S
slguan 已提交
4192 4193 4194
  }

  if (pCondExpr->pColumnCond) {
H
Haojun Liao 已提交
4195
    tSqlExprDestroy(pCondExpr->pColumnCond);
S
slguan 已提交
4196 4197 4198
  }

  if (pCondExpr->pTimewindow) {
H
Haojun Liao 已提交
4199
    tSqlExprDestroy(pCondExpr->pTimewindow);
S
slguan 已提交
4200 4201 4202
  }

  if (pCondExpr->pJoinExpr) {
H
Haojun Liao 已提交
4203
    tSqlExprDestroy(pCondExpr->pJoinExpr);
S
slguan 已提交
4204 4205 4206
  }
}

4207
static void doAddJoinTagsColumnsIntoTagList(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SCondExpr* pCondExpr) {
H
hjxilinx 已提交
4208
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
weixin_48148422's avatar
weixin_48148422 已提交
4209
  if (QUERY_IS_JOIN_QUERY(pQueryInfo->type) && UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
Haojun Liao 已提交
4210
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
H
hjxilinx 已提交
4211

4212
    if (getColumnIndexByName(pCmd, &pCondExpr->pJoinExpr->pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
B
Bomin Zhang 已提交
4213 4214
      tscError("%p: invalid column name (left)", pQueryInfo);
    }
H
hjxilinx 已提交
4215
    pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
4216 4217
  
    index.columnIndex = index.columnIndex - tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
H
hjxilinx 已提交
4218 4219
    tscColumnListInsert(pTableMetaInfo->tagColList, &index);
  
4220
    if (getColumnIndexByName(pCmd, &pCondExpr->pJoinExpr->pRight->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
B
Bomin Zhang 已提交
4221 4222
      tscError("%p: invalid column name (right)", pQueryInfo);
    }
H
hjxilinx 已提交
4223
    pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
4224 4225
  
    index.columnIndex = index.columnIndex - tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
H
hjxilinx 已提交
4226
    tscColumnListInsert(pTableMetaInfo->tagColList, &index);
S
slguan 已提交
4227
  }
H
hjxilinx 已提交
4228
}
S
slguan 已提交
4229

4230
static int32_t getTagQueryCondExpr(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SCondExpr* pCondExpr, tSQLExpr** pExpr) {
H
hjxilinx 已提交
4231
  int32_t ret = TSDB_CODE_SUCCESS;
H
hjxilinx 已提交
4232

4233 4234 4235 4236 4237
  if (pCondExpr->pTagCond == NULL) {
    return ret;
  }
  
  for (int32_t i = 0; i < pQueryInfo->numOfTables; ++i) {
4238
    tSQLExpr* p1 = extractExprForSTable(pCmd, pExpr, pQueryInfo, i);
H
Haojun Liao 已提交
4239 4240 4241 4242
    if (p1 == NULL) {  // no query condition on this table
      continue;
    }

4243
    tExprNode* p = NULL;
4244 4245
  
    SArray* colList = taosArrayInit(10, sizeof(SColIndex));
H
Haojun Liao 已提交
4246
    ret = exprTreeFromSqlExpr(pCmd, &p, p1, pQueryInfo, colList, NULL);
4247 4248 4249 4250 4251 4252 4253 4254 4255
    SBufferWriter bw = tbufInitWriter(NULL, false);

    TRY(0) {
      exprTreeToBinary(&bw, p);
    } CATCH(code) {
      tbufCloseWriter(&bw);
      UNUSED(code);
      // TODO: more error handling
    } END_TRY
4256
    
4257 4258
    // add to source column list
    STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, i);
4259
    int64_t uid = pTableMetaInfo->pTableMeta->id.uid;
4260 4261 4262 4263 4264 4265
    int32_t numOfCols = tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
    
    size_t num = taosArrayGetSize(colList);
    for(int32_t j = 0; j < num; ++j) {
      SColIndex* pIndex = taosArrayGet(colList, j);
      SColumnIndex index = {.tableIndex = i, .columnIndex = pIndex->colIndex - numOfCols};
H
hjxilinx 已提交
4266
      tscColumnListInsert(pTableMetaInfo->tagColList, &index);
4267 4268
    }
    
4269
    tsSetSTableQueryCond(&pQueryInfo->tagCond, uid, &bw);
4270
    doCompactQueryExpr(pExpr);
H
Haojun Liao 已提交
4271 4272

    tSqlExprDestroy(p1);
4273
    tExprTreeDestroy(&p, NULL);
4274 4275
    
    taosArrayDestroy(colList);
H
Haojun Liao 已提交
4276
    if (pQueryInfo->tagCond.pCond != NULL && taosArrayGetSize(pQueryInfo->tagCond.pCond) > 0 && !UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
Haojun Liao 已提交
4277 4278
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "filter on tag not supported for normal table");
    }
H
hjxilinx 已提交
4279
  }
H
hjxilinx 已提交
4280

4281
  pCondExpr->pTagCond = NULL;
S
slguan 已提交
4282 4283
  return ret;
}
H
Haojun Liao 已提交
4284

4285
int32_t parseWhereClause(SQueryInfo* pQueryInfo, tSQLExpr** pExpr, SSqlObj* pSql) {
H
hjxilinx 已提交
4286 4287 4288
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }
H
hjxilinx 已提交
4289

H
hjxilinx 已提交
4290
  const char* msg1 = "invalid expression";
H
hjxilinx 已提交
4291
  const char* msg2 = "invalid filter expression";
H
hjxilinx 已提交
4292

H
hjxilinx 已提交
4293
  int32_t ret = TSDB_CODE_SUCCESS;
S
slguan 已提交
4294

H
hjxilinx 已提交
4295
  // tags query condition may be larger than 512bytes, therefore, we need to prepare enough large space
S
Shuduo Sang 已提交
4296
  SStringBuilder sb; memset(&sb, 0, sizeof(sb));
H
hjxilinx 已提交
4297
  SCondExpr      condExpr = {0};
S
slguan 已提交
4298

H
hjxilinx 已提交
4299
  if ((*pExpr)->pLeft == NULL || (*pExpr)->pRight == NULL) {
4300
    return invalidSqlErrMsg(tscGetErrorMsgPayload(&pSql->cmd), msg1);
S
slguan 已提交
4301 4302
  }

H
hjxilinx 已提交
4303
  int32_t type = 0;
4304
  if ((ret = getQueryCondExpr(&pSql->cmd, pQueryInfo, pExpr, &condExpr, &type, (*pExpr)->nSQLOptr)) != TSDB_CODE_SUCCESS) {
H
hjxilinx 已提交
4305 4306
    return ret;
  }
H
hjxilinx 已提交
4307

S
slguan 已提交
4308
  doCompactQueryExpr(pExpr);
H
hjxilinx 已提交
4309

S
slguan 已提交
4310
  // after expression compact, the expression tree is only include tag query condition
H
hjxilinx 已提交
4311
  condExpr.pTagCond = (*pExpr);
H
hjxilinx 已提交
4312

S
slguan 已提交
4313
  // 1. check if it is a join query
4314
  if ((ret = validateJoinExpr(&pSql->cmd, pQueryInfo, &condExpr)) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
4315 4316
    return ret;
  }
H
hjxilinx 已提交
4317

S
slguan 已提交
4318
  // 2. get the query time range
4319
  if ((ret = getTimeRangeFromExpr(&pSql->cmd, pQueryInfo, condExpr.pTimewindow)) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
4320 4321
    return ret;
  }
H
hjxilinx 已提交
4322

S
slguan 已提交
4323
  // 3. get the tag query condition
4324
  if ((ret = getTagQueryCondExpr(&pSql->cmd, pQueryInfo, &condExpr, pExpr)) != TSDB_CODE_SUCCESS) {
H
hjxilinx 已提交
4325
    return ret;
S
slguan 已提交
4326
  }
H
hjxilinx 已提交
4327

S
slguan 已提交
4328
  // 4. get the table name query condition
4329
  if ((ret = getTablenameCond(&pSql->cmd, pQueryInfo, condExpr.pTableCond, &sb)) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
4330 4331
    return ret;
  }
H
hjxilinx 已提交
4332

S
slguan 已提交
4333
  // 5. other column query condition
4334
  if ((ret = getColumnQueryCondInfo(&pSql->cmd, pQueryInfo, condExpr.pColumnCond, TK_AND)) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
4335 4336
    return ret;
  }
H
hjxilinx 已提交
4337

S
slguan 已提交
4338
  // 6. join condition
4339
  if ((ret = getJoinCondInfo(&pSql->cmd, pQueryInfo, condExpr.pJoinExpr)) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
4340
    return ret;
H
hzcheng 已提交
4341
  }
H
hjxilinx 已提交
4342

S
slguan 已提交
4343
  // 7. query condition for table name
4344
  pQueryInfo->tagCond.relType = (condExpr.relType == TK_AND) ? TSDB_RELATION_AND : TSDB_RELATION_OR;
H
hjxilinx 已提交
4345

4346
  ret = setTableCondForSTableQuery(&pSql->cmd, pQueryInfo, getAccountId(pSql), condExpr.pTableCond, condExpr.tableCondIndex, &sb);
H
hjxilinx 已提交
4347
  taosStringBuilderDestroy(&sb);
H
hjxilinx 已提交
4348

4349
  if (!validateFilterExpr(pQueryInfo)) {
4350
    return invalidSqlErrMsg(tscGetErrorMsgPayload(&pSql->cmd), msg2);
4351
  }
H
hjxilinx 已提交
4352

4353
  doAddJoinTagsColumnsIntoTagList(&pSql->cmd, pQueryInfo, &condExpr);
H
hjxilinx 已提交
4354

H
hjxilinx 已提交
4355
  cleanQueryExpr(&condExpr);
H
hzcheng 已提交
4356 4357 4358
  return ret;
}

H
hjxilinx 已提交
4359
int32_t getTimeRange(STimeWindow* win, tSQLExpr* pRight, int32_t optr, int16_t timePrecision) {
S
slguan 已提交
4360 4361 4362 4363 4364
  // this is join condition, do nothing
  if (pRight->nSQLOptr == TK_ID) {
    return TSDB_CODE_SUCCESS;
  }

S
slguan 已提交
4365 4366
  /*
   * filter primary ts filter expression like:
S
slguan 已提交
4367
   * where ts in ('2015-12-12 4:8:12')
S
slguan 已提交
4368 4369
   */
  if (pRight->nSQLOptr == TK_SET || optr == TK_IN) {
4370
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
4371
  }
H
hzcheng 已提交
4372 4373 4374 4375

  int64_t val = 0;
  bool    parsed = false;
  if (pRight->val.nType == TSDB_DATA_TYPE_BINARY) {
S
slguan 已提交
4376 4377
    pRight->val.nLen = strdequote(pRight->val.pz);

S
slguan 已提交
4378
    char* seg = strnchr(pRight->val.pz, '-', pRight->val.nLen, false);
H
hzcheng 已提交
4379
    if (seg != NULL) {
dengyihao's avatar
dengyihao 已提交
4380
      if (taosParseTime(pRight->val.pz, &val, pRight->val.nLen, TSDB_TIME_PRECISION_MICRO, tsDaylight) == TSDB_CODE_SUCCESS) {
H
hzcheng 已提交
4381 4382
        parsed = true;
      } else {
4383
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4384
      }
S
slguan 已提交
4385
    } else {
H
Haojun Liao 已提交
4386
      SStrToken token = {.z = pRight->val.pz, .n = pRight->val.nLen, .type = TK_ID};
S
slguan 已提交
4387 4388 4389
      int32_t   len = tSQLGetToken(pRight->val.pz, &token.type);

      if ((token.type != TK_INTEGER && token.type != TK_FLOAT) || len != pRight->val.nLen) {
4390
        return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
4391
      }
H
hzcheng 已提交
4392 4393 4394 4395
    }
  } else if (pRight->nSQLOptr == TK_INTEGER && timePrecision == TSDB_TIME_PRECISION_MILLI) {
    /*
     * if the pRight->nSQLOptr == TK_INTEGER/TK_FLOAT, the value is adaptive, we
S
slguan 已提交
4396
     * need the time precision in metermeta to transfer the value in MICROSECOND
H
hzcheng 已提交
4397 4398 4399
     *
     * Additional check to avoid data overflow
     */
4400 4401
    if (pRight->val.i64 <= INT64_MAX / 1000) {
      pRight->val.i64 *= 1000;
H
hzcheng 已提交
4402 4403 4404 4405 4406 4407 4408 4409 4410 4411
    }
  } else if (pRight->nSQLOptr == TK_FLOAT && timePrecision == TSDB_TIME_PRECISION_MILLI) {
    pRight->val.dKey *= 1000;
  }

  if (!parsed) {
    /*
     * failed to parse timestamp in regular formation, try next
     * it may be a epoch time in string format
     */
4412
    tVariantDump(&pRight->val, (char*)&val, TSDB_DATA_TYPE_BIGINT, true);
H
hzcheng 已提交
4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433

    /*
     * transfer it into MICROSECOND format if it is a string, since for
     * TK_INTEGER/TK_FLOAT the value has been transferred
     *
     * additional check to avoid data overflow
     */
    if (pRight->nSQLOptr == TK_STRING && timePrecision == TSDB_TIME_PRECISION_MILLI) {
      if (val <= INT64_MAX / 1000) {
        val *= 1000;
      }
    }
  }

  int32_t delta = 1;
  /* for millisecond, delta is 1ms=1000us */
  if (timePrecision == TSDB_TIME_PRECISION_MILLI) {
    delta *= 1000;
  }

  if (optr == TK_LE) {
H
hjxilinx 已提交
4434
    win->ekey = val;
H
hzcheng 已提交
4435
  } else if (optr == TK_LT) {
H
hjxilinx 已提交
4436
    win->ekey = val - delta;
H
hzcheng 已提交
4437
  } else if (optr == TK_GT) {
H
hjxilinx 已提交
4438
    win->skey = val + delta;
H
hzcheng 已提交
4439
  } else if (optr == TK_GE) {
H
hjxilinx 已提交
4440
    win->skey = val;
H
hzcheng 已提交
4441
  } else if (optr == TK_EQ) {
H
hjxilinx 已提交
4442
    win->ekey = win->skey = val;
H
hzcheng 已提交
4443 4444 4445 4446
  }
  return TSDB_CODE_SUCCESS;
}

H
hjxilinx 已提交
4447
// todo error !!!!
4448
int32_t tsRewriteFieldNameIfNecessary(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
S
slguan 已提交
4449 4450
  const char rep[] = {'(', ')', '*', ',', '.', '/', '\\', '+', '-', '%', ' '};

H
hjxilinx 已提交
4451 4452
  for (int32_t i = 0; i < pQueryInfo->fieldsInfo.numOfOutput; ++i) {
    char* fieldName = tscFieldInfoGetField(&pQueryInfo->fieldsInfo, i)->name;
B
Bomin Zhang 已提交
4453
    for (int32_t j = 0; j < (TSDB_COL_NAME_LEN - 1) && fieldName[j] != 0; ++j) {
S
slguan 已提交
4454 4455 4456 4457 4458
      for (int32_t k = 0; k < tListLen(rep); ++k) {
        if (fieldName[j] == rep[k]) {
          fieldName[j] = '_';
          break;
        }
H
hzcheng 已提交
4459 4460
      }
    }
S
slguan 已提交
4461

H
hzcheng 已提交
4462 4463 4464 4465
    fieldName[TSDB_COL_NAME_LEN - 1] = 0;
  }

  // the column name may be identical, here check again
H
hjxilinx 已提交
4466 4467 4468
  for (int32_t i = 0; i < pQueryInfo->fieldsInfo.numOfOutput; ++i) {
    char* fieldName = tscFieldInfoGetField(&pQueryInfo->fieldsInfo, i)->name;
    for (int32_t j = i + 1; j < pQueryInfo->fieldsInfo.numOfOutput; ++j) {
B
Bomin Zhang 已提交
4469
      if (strncasecmp(fieldName, tscFieldInfoGetField(&pQueryInfo->fieldsInfo, j)->name, (TSDB_COL_NAME_LEN - 1)) == 0) {
4470
        const char* msg = "duplicated column name in new table";
4471
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
4472 4473 4474 4475 4476 4477 4478
      }
    }
  }

  return TSDB_CODE_SUCCESS;
}

4479
int32_t parseFillClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySQL) {
H
Haojun Liao 已提交
4480 4481
  SArray*     pFillToken = pQuerySQL->fillType;
  tVariantListItem* pItem = taosArrayGet(pFillToken, 0);
H
hzcheng 已提交
4482 4483

  const int32_t START_INTERPO_COL_IDX = 1;
4484 4485 4486 4487

  const char* msg = "illegal value or data overflow";
  const char* msg1 = "value is expected";
  const char* msg2 = "invalid fill option";
D
fix bug  
dapan1121 已提交
4488
  const char* msg3 = "top/bottom not support fill";
H
hzcheng 已提交
4489 4490

  if (pItem->pVar.nType != TSDB_DATA_TYPE_BINARY) {
4491
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4492
  }
H
hjxilinx 已提交
4493
  
H
Haojun Liao 已提交
4494
  size_t size = tscNumOfFields(pQueryInfo);
H
hjxilinx 已提交
4495
  
4496 4497 4498
  if (pQueryInfo->fillVal == NULL) {
    pQueryInfo->fillVal = calloc(size, sizeof(int64_t));
    if (pQueryInfo->fillVal == NULL) {
4499
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
4500 4501 4502
    }
  }

H
hzcheng 已提交
4503
  if (strncasecmp(pItem->pVar.pz, "none", 4) == 0 && pItem->pVar.nLen == 4) {
4504
    pQueryInfo->fillType = TSDB_FILL_NONE;
H
hzcheng 已提交
4505
  } else if (strncasecmp(pItem->pVar.pz, "null", 4) == 0 && pItem->pVar.nLen == 4) {
4506
    pQueryInfo->fillType = TSDB_FILL_NULL;
H
hjxilinx 已提交
4507
    for (int32_t i = START_INTERPO_COL_IDX; i < size; ++i) {
H
Haojun Liao 已提交
4508 4509
      TAOS_FIELD* pField = tscFieldInfoGetField(&pQueryInfo->fieldsInfo, i);
      setNull((char*)&pQueryInfo->fillVal[i], pField->type, pField->bytes);
H
hzcheng 已提交
4510 4511
    }
  } else if (strncasecmp(pItem->pVar.pz, "prev", 4) == 0 && pItem->pVar.nLen == 4) {
4512
    pQueryInfo->fillType = TSDB_FILL_PREV;
H
hzcheng 已提交
4513
  } else if (strncasecmp(pItem->pVar.pz, "linear", 6) == 0 && pItem->pVar.nLen == 6) {
4514
    pQueryInfo->fillType = TSDB_FILL_LINEAR;
H
hzcheng 已提交
4515
  } else if (strncasecmp(pItem->pVar.pz, "value", 5) == 0 && pItem->pVar.nLen == 5) {
4516
    pQueryInfo->fillType = TSDB_FILL_SET_VALUE;
H
hzcheng 已提交
4517

H
Haojun Liao 已提交
4518 4519
    size_t num = taosArrayGetSize(pFillToken);
    if (num == 1) {
4520
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
4521 4522 4523
    }

    int32_t startPos = 1;
S
Shengliang Guan 已提交
4524
    int32_t numOfFillVal = (int32_t)(num - 1);
H
hzcheng 已提交
4525 4526

    /* for point interpolation query, we do not have the timestamp column */
4527
    if (tscIsPointInterpQuery(pQueryInfo)) {
H
hzcheng 已提交
4528 4529
      startPos = 0;

H
hjxilinx 已提交
4530
      if (numOfFillVal > size) {
S
TD-1057  
Shengliang Guan 已提交
4531
        numOfFillVal = (int32_t)size;
H
hzcheng 已提交
4532 4533
      }
    } else {
S
Shengliang Guan 已提交
4534
      numOfFillVal = (int16_t)((num >  (int32_t)size) ? (int32_t)size : num);
H
hzcheng 已提交
4535 4536 4537 4538 4539
    }

    int32_t j = 1;

    for (int32_t i = startPos; i < numOfFillVal; ++i, ++j) {
H
Haojun Liao 已提交
4540
      TAOS_FIELD* pField = tscFieldInfoGetField(&pQueryInfo->fieldsInfo, i);
H
hjxilinx 已提交
4541

H
Haojun Liao 已提交
4542 4543
      if (pField->type == TSDB_DATA_TYPE_BINARY || pField->type == TSDB_DATA_TYPE_NCHAR) {
        setVardataNull((char*) &pQueryInfo->fillVal[i], pField->type);
4544 4545
        continue;
      }
H
hjxilinx 已提交
4546

H
Haojun Liao 已提交
4547
      tVariant* p = taosArrayGet(pFillToken, j);
H
Haojun Liao 已提交
4548
      int32_t ret = tVariantDump(p, (char*)&pQueryInfo->fillVal[i], pField->type, true);
H
hzcheng 已提交
4549
      if (ret != TSDB_CODE_SUCCESS) {
4550
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
4551 4552
      }
    }
H
hjxilinx 已提交
4553
    
H
Haojun Liao 已提交
4554 4555
    if ((num < size) || ((num - 1 < size) && (tscIsPointInterpQuery(pQueryInfo)))) {
      tVariantListItem* lastItem = taosArrayGetLast(pFillToken);
H
hzcheng 已提交
4556

H
hjxilinx 已提交
4557
      for (int32_t i = numOfFillVal; i < size; ++i) {
H
Haojun Liao 已提交
4558
        TAOS_FIELD* pField = tscFieldInfoGetField(&pQueryInfo->fieldsInfo, i);
H
hzcheng 已提交
4559

H
Haojun Liao 已提交
4560 4561
        if (pField->type == TSDB_DATA_TYPE_BINARY || pField->type == TSDB_DATA_TYPE_NCHAR) {
          setVardataNull((char*) &pQueryInfo->fillVal[i], pField->type);
H
hjxilinx 已提交
4562
        } else {
H
Haojun Liao 已提交
4563
          tVariantDump(&lastItem->pVar, (char*)&pQueryInfo->fillVal[i], pField->type, true);
H
hzcheng 已提交
4564 4565 4566 4567
        }
      }
    }
  } else {
4568
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4569 4570
  }

D
dapan1121 已提交
4571
  size_t numOfExprs = tscSqlExprNumOfExprs(pQueryInfo);
D
dapan1121 已提交
4572
  for(int32_t i = 0; i < numOfExprs; ++i) {
D
fix bug  
dapan1121 已提交
4573
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
D
dapan1121 已提交
4574
    if (pExpr->functionId == TSDB_FUNC_TOP || pExpr->functionId == TSDB_FUNC_BOTTOM) {
D
fix bug  
dapan1121 已提交
4575 4576 4577 4578
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }
  }

H
hzcheng 已提交
4579 4580 4581
  return TSDB_CODE_SUCCESS;
}

4582
static void setDefaultOrderInfo(SQueryInfo* pQueryInfo) {
H
hzcheng 已提交
4583
  /* set default timestamp order information for all queries */
H
hjxilinx 已提交
4584
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hzcheng 已提交
4585

H
Haojun Liao 已提交
4586
  pQueryInfo->order.order = TSDB_ORDER_ASC;
H
Haojun Liao 已提交
4587 4588 4589 4590 4591
  if (isTopBottomQuery(pQueryInfo)) {
    pQueryInfo->order.orderColId = PRIMARYKEY_TIMESTAMP_COL_INDEX;
  } else { // in case of select tbname from super_table, the defualt order column can not be the primary ts column
    pQueryInfo->order.orderColId = INT32_MIN;
  }
H
hzcheng 已提交
4592

H
hjxilinx 已提交
4593
  /* for super table query, set default ascending order for group output */
weixin_48148422's avatar
weixin_48148422 已提交
4594
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
4595
    pQueryInfo->groupbyExpr.orderType = TSDB_ORDER_ASC;
H
hzcheng 已提交
4596 4597 4598
  }
}

4599
int32_t parseOrderbyClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql, SSchema* pSchema) {
S
slguan 已提交
4600 4601
  const char* msg0 = "only support order by primary timestamp";
  const char* msg1 = "invalid column name";
4602
  const char* msg2 = "only support order by primary timestamp or first tag in groupby clause allowed";
4603
  const char* msg3 = "invalid column in order by clause, only primary timestamp or first tag in groupby clause allowed";
H
hzcheng 已提交
4604

4605
  setDefaultOrderInfo(pQueryInfo);
H
hjxilinx 已提交
4606
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hzcheng 已提交
4607 4608 4609 4610 4611

  if (pQuerySql->pSortOrder == NULL) {
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
4612
  SArray* pSortorder = pQuerySql->pSortOrder;
S
slguan 已提交
4613 4614 4615 4616 4617 4618 4619

  /*
   * for table query, there is only one or none order option is allowed, which is the
   * ts or values(top/bottom) order is supported.
   *
   * for super table query, the order option must be less than 3.
   */
H
Haojun Liao 已提交
4620
  size_t size = taosArrayGetSize(pSortorder);
weixin_48148422's avatar
weixin_48148422 已提交
4621
  if (UTIL_TABLE_IS_NORMAL_TABLE(pTableMetaInfo)) {
H
Haojun Liao 已提交
4622
    if (size > 1) {
4623
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
H
hzcheng 已提交
4624 4625
    }
  } else {
H
Haojun Liao 已提交
4626
    if (size > 2) {
4627
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
4628 4629 4630 4631
    }
  }

  // handle the first part of order by
H
Haojun Liao 已提交
4632
  tVariant* pVar = taosArrayGet(pSortorder, 0);
H
hzcheng 已提交
4633 4634 4635 4636 4637 4638

  // e.g., order by 1 asc, return directly with out further check.
  if (pVar->nType >= TSDB_DATA_TYPE_TINYINT && pVar->nType <= TSDB_DATA_TYPE_BIGINT) {
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
4639
  SStrToken    columnName = {pVar->nLen, pVar->nType, pVar->pz};
4640
  SColumnIndex index = COLUMN_INDEX_INITIALIZER;
S
slguan 已提交
4641

weixin_48148422's avatar
weixin_48148422 已提交
4642
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {  // super table query
4643 4644
    if (getColumnIndexByName(pCmd, &columnName, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
4645 4646 4647 4648
    }

    bool orderByTags = false;
    bool orderByTS = false;
H
hzcheng 已提交
4649

H
hjxilinx 已提交
4650 4651
    if (index.columnIndex >= tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) {
      int32_t relTagIndex = index.columnIndex - tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
4652
      
4653 4654
      // it is a tag column
      if (pQueryInfo->groupbyExpr.columnInfo == NULL) {
4655
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
4656
      }
4657 4658
      SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, 0);
      if (relTagIndex == pColIndex->colIndex) {
H
hzcheng 已提交
4659 4660
        orderByTags = true;
      }
S
slguan 已提交
4661 4662
    } else if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
      orderByTags = true;
H
hzcheng 已提交
4663 4664
    }

S
slguan 已提交
4665
    if (PRIMARYKEY_TIMESTAMP_COL_INDEX == index.columnIndex) {
H
hzcheng 已提交
4666 4667 4668
      orderByTS = true;
    }

4669
    if (!(orderByTags || orderByTS) && !isTopBottomQuery(pQueryInfo)) {
4670
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
4671
    } else {  // order by top/bottom result value column is not supported in case of interval query.
H
hzcheng 已提交
4672 4673 4674
      assert(!(orderByTags && orderByTS));
    }

H
Haojun Liao 已提交
4675 4676
    size_t s = taosArrayGetSize(pSortorder);
    if (s == 1) {
H
hzcheng 已提交
4677
      if (orderByTags) {
H
hjxilinx 已提交
4678
        pQueryInfo->groupbyExpr.orderIndex = index.columnIndex - tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
H
Haojun Liao 已提交
4679 4680 4681

        tVariantListItem* p1 = taosArrayGet(pQuerySql->pSortOrder, 0);
        pQueryInfo->groupbyExpr.orderType = p1->sortOrder;
4682
      } else if (isTopBottomQuery(pQueryInfo)) {
S
slguan 已提交
4683
        /* order of top/bottom query in interval is not valid  */
4684
        SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, 0);
S
slguan 已提交
4685 4686
        assert(pExpr->functionId == TSDB_FUNC_TS);

4687
        pExpr = tscSqlExprGet(pQueryInfo, 1);
4688
        if (pExpr->colInfo.colIndex != index.columnIndex && index.columnIndex != PRIMARYKEY_TIMESTAMP_COL_INDEX) {
4689
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
4690
        }
4691

H
Haojun Liao 已提交
4692 4693
        tVariantListItem* p1 = taosArrayGet(pQuerySql->pSortOrder, 0);
        pQueryInfo->order.order = p1->sortOrder;
4694
        pQueryInfo->order.orderColId = pSchema[index.columnIndex].colId;
S
slguan 已提交
4695
        return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
4696
      } else {
H
Haojun Liao 已提交
4697 4698 4699
        tVariantListItem* p1 = taosArrayGet(pQuerySql->pSortOrder, 0);

        pQueryInfo->order.order = p1->sortOrder;
4700
        pQueryInfo->order.orderColId = PRIMARYKEY_TIMESTAMP_COL_INDEX;
H
Haojun Liao 已提交
4701 4702 4703 4704 4705

        // orderby ts query on super table
        if (tscOrderedProjectionQueryOnSTable(pQueryInfo, 0)) {
          addPrimaryTsColIntoResult(pQueryInfo);
        }
H
hzcheng 已提交
4706 4707 4708
      }
    }

H
Haojun Liao 已提交
4709 4710
    if (s == 2) {
      tVariantListItem *pItem = taosArrayGet(pQuerySql->pSortOrder, 0);
S
slguan 已提交
4711
      if (orderByTags) {
H
hjxilinx 已提交
4712
        pQueryInfo->groupbyExpr.orderIndex = index.columnIndex - tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
H
Haojun Liao 已提交
4713
        pQueryInfo->groupbyExpr.orderType = pItem->sortOrder;
S
slguan 已提交
4714
      } else {
H
Haojun Liao 已提交
4715
        pQueryInfo->order.order = pItem->sortOrder;
4716
        pQueryInfo->order.orderColId = PRIMARYKEY_TIMESTAMP_COL_INDEX;
S
slguan 已提交
4717 4718
      }

H
Haojun Liao 已提交
4719 4720
      pItem = taosArrayGet(pQuerySql->pSortOrder, 1);
      tVariant* pVar2 = &pItem->pVar;
H
Haojun Liao 已提交
4721
      SStrToken cname = {pVar2->nLen, pVar2->nType, pVar2->pz};
4722 4723
      if (getColumnIndexByName(pCmd, &cname, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
4724 4725 4726
      }

      if (index.columnIndex != PRIMARYKEY_TIMESTAMP_COL_INDEX) {
4727
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4728
      } else {
H
Haojun Liao 已提交
4729 4730
        tVariantListItem* p1 = taosArrayGet(pSortorder, 1);
        pQueryInfo->order.order = p1->sortOrder;
4731
        pQueryInfo->order.orderColId = PRIMARYKEY_TIMESTAMP_COL_INDEX;
H
hzcheng 已提交
4732 4733 4734 4735
      }
    }

  } else {  // meter query
4736 4737
    if (getColumnIndexByName(pCmd, &columnName, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
4738 4739
    }

4740
    if (index.columnIndex != PRIMARYKEY_TIMESTAMP_COL_INDEX && !isTopBottomQuery(pQueryInfo)) {
4741
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4742 4743
    }

4744
    if (isTopBottomQuery(pQueryInfo)) {
H
hzcheng 已提交
4745
      /* order of top/bottom query in interval is not valid  */
4746
      SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, 0);
S
slguan 已提交
4747
      assert(pExpr->functionId == TSDB_FUNC_TS);
H
hzcheng 已提交
4748

4749
      pExpr = tscSqlExprGet(pQueryInfo, 1);
4750
      if (pExpr->colInfo.colIndex != index.columnIndex && index.columnIndex != PRIMARYKEY_TIMESTAMP_COL_INDEX) {
4751
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4752
      }
4753

H
Haojun Liao 已提交
4754 4755
      tVariantListItem* pItem = taosArrayGet(pQuerySql->pSortOrder, 0);
      pQueryInfo->order.order = pItem->sortOrder;
4756
      pQueryInfo->order.orderColId = pSchema[index.columnIndex].colId;
H
hzcheng 已提交
4757 4758
      return TSDB_CODE_SUCCESS;
    }
4759

H
Haojun Liao 已提交
4760 4761
    tVariantListItem* pItem = taosArrayGet(pQuerySql->pSortOrder, 0);
    pQueryInfo->order.order = pItem->sortOrder;
H
hzcheng 已提交
4762 4763 4764 4765 4766 4767
  }

  return TSDB_CODE_SUCCESS;
}

int32_t setAlterTableInfo(SSqlObj* pSql, struct SSqlInfo* pInfo) {
S
slguan 已提交
4768
  const int32_t DEFAULT_TABLE_INDEX = 0;
4769

4770 4771 4772 4773 4774
  const char* msg1 = "invalid table name";
  const char* msg3 = "manipulation of tag available for super table";
  const char* msg4 = "set tag value only available for table";
  const char* msg5 = "only support add one tag";
  const char* msg6 = "column can only be modified by super table";
H
hjxilinx 已提交
4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789
  
  const char* msg7 = "no tags can be dropped";
  const char* msg8 = "only support one tag";
  const char* msg9 = "tag name too long";
  
  const char* msg10 = "invalid tag name";
  const char* msg11 = "primary tag cannot be dropped";
  const char* msg12 = "update normal column not supported";
  const char* msg13 = "invalid tag value";
  const char* msg14 = "tag value too long";
  
  const char* msg15 = "no columns can be dropped";
  const char* msg16 = "only support one column";
  const char* msg17 = "invalid column name";
  const char* msg18 = "primary timestamp column cannot be dropped";
H
Haojun Liao 已提交
4790 4791
  const char* msg19 = "invalid new tag name";

H
Haojun Liao 已提交
4792 4793
  int32_t code = TSDB_CODE_SUCCESS;

S
slguan 已提交
4794
  SSqlCmd*        pCmd = &pSql->cmd;
H
hzcheng 已提交
4795
  SAlterTableSQL* pAlterSQL = pInfo->pAlterInfo;
4796 4797
  SQueryInfo*     pQueryInfo = tscGetQueryInfoDetail(pCmd, 0);

H
hjxilinx 已提交
4798
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, DEFAULT_TABLE_INDEX);
H
hzcheng 已提交
4799

4800
  if (tscValidateName(&(pAlterSQL->name)) != TSDB_CODE_SUCCESS) {
4801
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
4802
  }
P
plum-lihui 已提交
4803

H
Haojun Liao 已提交
4804 4805 4806
  code = tscSetTableFullName(pTableMetaInfo, &(pAlterSQL->name), pSql);
  if (code != TSDB_CODE_SUCCESS) {
    return code;
H
hzcheng 已提交
4807 4808
  }

H
Haojun Liao 已提交
4809 4810 4811
  code = tscGetTableMeta(pSql, pTableMetaInfo);
  if (code != TSDB_CODE_SUCCESS) {
    return code;
H
hzcheng 已提交
4812 4813
  }

H
hjxilinx 已提交
4814
  STableMeta* pTableMeta = pTableMetaInfo->pTableMeta;
H
hzcheng 已提交
4815

4816 4817
  if (pAlterSQL->type == TSDB_ALTER_TABLE_ADD_TAG_COLUMN || pAlterSQL->type == TSDB_ALTER_TABLE_DROP_TAG_COLUMN ||
      pAlterSQL->type == TSDB_ALTER_TABLE_CHANGE_TAG_COLUMN) {
weixin_48148422's avatar
weixin_48148422 已提交
4818
    if (UTIL_TABLE_IS_NORMAL_TABLE(pTableMetaInfo)) {
4819
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
4820
    }
weixin_48148422's avatar
weixin_48148422 已提交
4821
  } else if ((pAlterSQL->type == TSDB_ALTER_TABLE_UPDATE_TAG_VAL) && (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo))) {
4822
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
4823
  } else if ((pAlterSQL->type == TSDB_ALTER_TABLE_ADD_COLUMN || pAlterSQL->type == TSDB_ALTER_TABLE_DROP_COLUMN) &&
4824
             UTIL_TABLE_IS_CHILD_TABLE(pTableMetaInfo)) {
4825
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
4826 4827
  }

4828
  if (pAlterSQL->type == TSDB_ALTER_TABLE_ADD_TAG_COLUMN) {
H
Haojun Liao 已提交
4829 4830
    SArray* pFieldList = pAlterSQL->pAddColumns;
    if (taosArrayGetSize(pFieldList) > 1) {
4831
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
4832 4833
    }

H
Haojun Liao 已提交
4834 4835
    TAOS_FIELD* p = taosArrayGet(pFieldList, 0);
    if (!validateOneTags(pCmd, p)) {
4836
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4837
    }
H
hjxilinx 已提交
4838
  
H
Haojun Liao 已提交
4839
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, p);
4840
  } else if (pAlterSQL->type == TSDB_ALTER_TABLE_DROP_TAG_COLUMN) {
H
hjxilinx 已提交
4841
    if (tscGetNumOfTags(pTableMeta) == 1) {
4842
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
H
hzcheng 已提交
4843 4844 4845
    }

    // numOfTags == 1
H
Haojun Liao 已提交
4846
    if (taosArrayGetSize(pAlterSQL->varList) > 1) {
4847
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg8);
H
hzcheng 已提交
4848 4849
    }

H
Haojun Liao 已提交
4850
    tVariantListItem* pItem = taosArrayGet(pAlterSQL->varList, 0);
B
Bomin Zhang 已提交
4851
    if (pItem->pVar.nLen >= TSDB_COL_NAME_LEN) {
4852
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg9);
H
hzcheng 已提交
4853
    }
4854

4855
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
H
Haojun Liao 已提交
4856
    SStrToken    name = {.z = pItem->pVar.pz, .n = pItem->pVar.nLen, .type = TK_STRING};
4857

4858
    if (getColumnIndexByName(pCmd, &name, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
4859
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4860 4861
    }

H
Haojun Liao 已提交
4862 4863
    int32_t numOfCols = tscGetNumOfColumns(pTableMeta);
    if (index.columnIndex < numOfCols) {
4864
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg10);
H
Haojun Liao 已提交
4865
    } else if (index.columnIndex == numOfCols) {
4866
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg11);
H
hzcheng 已提交
4867 4868
    }

4869 4870
    char name1[128] = {0};
    strncpy(name1, pItem->pVar.pz, pItem->pVar.nLen);
H
hjxilinx 已提交
4871 4872 4873
  
    TAOS_FIELD f = tscCreateField(TSDB_DATA_TYPE_INT, name1, tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize);
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, &f);
4874
  } else if (pAlterSQL->type == TSDB_ALTER_TABLE_CHANGE_TAG_COLUMN) {
H
Haojun Liao 已提交
4875 4876
    SArray* pVarList = pAlterSQL->varList;
    if (taosArrayGetSize(pVarList) > 2) {
4877
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4878 4879
    }

H
Haojun Liao 已提交
4880 4881
    tVariantListItem* pSrcItem = taosArrayGet(pAlterSQL->varList, 0);
    tVariantListItem* pDstItem = taosArrayGet(pAlterSQL->varList, 1);
4882 4883

    if (pSrcItem->pVar.nLen >= TSDB_COL_NAME_LEN || pDstItem->pVar.nLen >= TSDB_COL_NAME_LEN) {
4884
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg9);
H
hzcheng 已提交
4885 4886
    }

4887
    if (pSrcItem->pVar.nType != TSDB_DATA_TYPE_BINARY || pDstItem->pVar.nType != TSDB_DATA_TYPE_BINARY) {
4888
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg10);
4889
    }
H
hzcheng 已提交
4890

S
slguan 已提交
4891 4892
    SColumnIndex srcIndex = COLUMN_INDEX_INITIALIZER;
    SColumnIndex destIndex = COLUMN_INDEX_INITIALIZER;
H
hzcheng 已提交
4893

H
Haojun Liao 已提交
4894
    SStrToken srcToken = {.z = pSrcItem->pVar.pz, .n = pSrcItem->pVar.nLen, .type = TK_STRING};
4895
    if (getColumnIndexByName(pCmd, &srcToken, pQueryInfo, &srcIndex) != TSDB_CODE_SUCCESS) {
H
Haojun Liao 已提交
4896
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg17);
H
hzcheng 已提交
4897 4898
    }

H
Haojun Liao 已提交
4899
    SStrToken destToken = {.z = pDstItem->pVar.pz, .n = pDstItem->pVar.nLen, .type = TK_STRING};
4900
    if (getColumnIndexByName(pCmd, &destToken, pQueryInfo, &destIndex) == TSDB_CODE_SUCCESS) {
H
Haojun Liao 已提交
4901
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg19);
H
hzcheng 已提交
4902 4903
    }

H
Haojun Liao 已提交
4904 4905
    tVariantListItem* pItem = taosArrayGet(pVarList, 0);

B
Bomin Zhang 已提交
4906
    char name[TSDB_COL_NAME_LEN] = {0};
H
Haojun Liao 已提交
4907
    strncpy(name, pItem->pVar.pz, pItem->pVar.nLen);
H
hjxilinx 已提交
4908 4909
    TAOS_FIELD f = tscCreateField(TSDB_DATA_TYPE_INT, name, tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize);
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, &f);
H
hzcheng 已提交
4910

H
Haojun Liao 已提交
4911
    pItem = taosArrayGet(pVarList, 1);
H
hzcheng 已提交
4912
    memset(name, 0, tListLen(name));
H
Haojun Liao 已提交
4913 4914

    strncpy(name, pItem->pVar.pz, pItem->pVar.nLen);
H
hjxilinx 已提交
4915 4916
    f = tscCreateField(TSDB_DATA_TYPE_INT, name, tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize);
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, &f);
4917 4918
  } else if (pAlterSQL->type == TSDB_ALTER_TABLE_UPDATE_TAG_VAL) {
    // Note: update can only be applied to table not super table.
4919 4920 4921
    // the following is used to handle tags value for table created according to super table
    pCmd->command = TSDB_SQL_UPDATE_TAGS_VAL;
    
H
Haojun Liao 已提交
4922 4923
    SArray* pVarList = pAlterSQL->varList;
    tVariantListItem* item = taosArrayGet(pVarList, 0);
4924
    int16_t       numOfTags = tscGetNumOfTags(pTableMeta);
H
hzcheng 已提交
4925

4926
    SColumnIndex columnIndex = COLUMN_INDEX_INITIALIZER;
H
Haojun Liao 已提交
4927
    SStrToken    name = {.type = TK_STRING, .z = item->pVar.pz, .n = item->pVar.nLen};
4928
    if (getColumnIndexByName(pCmd, &name, pQueryInfo, &columnIndex) != TSDB_CODE_SUCCESS) {
4929
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4930 4931
    }

H
hjxilinx 已提交
4932
    if (columnIndex.columnIndex < tscGetNumOfColumns(pTableMeta)) {
4933
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg12);
S
slguan 已提交
4934 4935
    }

H
Haojun Liao 已提交
4936
    tVariantListItem* pItem = taosArrayGet(pVarList, 1);
H
hjxilinx 已提交
4937
    SSchema* pTagsSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, columnIndex.columnIndex);
4938 4939
    pAlterSQL->tagData.data = calloc(1, pTagsSchema->bytes * TSDB_NCHAR_SIZE + VARSTR_HEADER_SIZE);

H
Haojun Liao 已提交
4940
    if (tVariantDump(&pItem->pVar, pAlterSQL->tagData.data, pTagsSchema->type, true) != TSDB_CODE_SUCCESS) {
4941
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg13);
H
hzcheng 已提交
4942
    }
4943
    
4944
    pAlterSQL->tagData.dataLen = pTagsSchema->bytes;
H
hzcheng 已提交
4945 4946

    // validate the length of binary
4947
    if ((pTagsSchema->type == TSDB_DATA_TYPE_BINARY || pTagsSchema->type == TSDB_DATA_TYPE_NCHAR) &&
H
Haojun Liao 已提交
4948
        varDataTLen(pAlterSQL->tagData.data) > pTagsSchema->bytes) {
4949
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg14);
H
hzcheng 已提交
4950
    }
4951 4952 4953 4954

    int32_t schemaLen = sizeof(STColumn) * numOfTags;
    int32_t size = sizeof(SUpdateTableTagValMsg) + pTagsSchema->bytes + schemaLen + TSDB_EXTRA_PAYLOAD_SIZE;

4955 4956
    if (TSDB_CODE_SUCCESS != tscAllocPayload(pCmd, size)) {
      tscError("%p failed to malloc for alter table msg", pSql);
4957
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
4958 4959
    }

4960
    SUpdateTableTagValMsg* pUpdateMsg = (SUpdateTableTagValMsg*) pCmd->payload;
4961
    pUpdateMsg->head.vgId = htonl(pTableMeta->vgId);
4962 4963
    pUpdateMsg->tid       = htonl(pTableMeta->id.tid);
    pUpdateMsg->uid       = htobe64(pTableMeta->id.uid);
H
Haojun Liao 已提交
4964
    pUpdateMsg->colId     = htons(pTagsSchema->colId);
H
Hongze Cheng 已提交
4965
    pUpdateMsg->type      = pTagsSchema->type;
H
Haojun Liao 已提交
4966 4967
    pUpdateMsg->bytes     = htons(pTagsSchema->bytes);
    pUpdateMsg->tversion  = htons(pTableMeta->tversion);
4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984
    pUpdateMsg->numOfTags = htons(numOfTags);
    pUpdateMsg->schemaLen = htonl(schemaLen);

    // the schema is located after the msg body, then followed by true tag value
    char* d = pUpdateMsg->data;
    SSchema* pTagCols = tscGetTableTagSchema(pTableMeta);
    for (int i = 0; i < numOfTags; ++i) {
      STColumn* pCol = (STColumn*) d;
      pCol->colId = htons(pTagCols[i].colId);
      pCol->bytes = htons(pTagCols[i].bytes);
      pCol->type  = pTagCols[i].type;
      pCol->offset = 0;

      d += sizeof(STColumn);
    }

    // copy the tag value to msg body
H
Haojun Liao 已提交
4985 4986
    pItem = taosArrayGet(pVarList, 1);
    tVariantDump(&pItem->pVar, pUpdateMsg->data + schemaLen, pTagsSchema->type, true);
4987 4988 4989 4990 4991
    
    int32_t len = 0;
    if (pTagsSchema->type != TSDB_DATA_TYPE_BINARY && pTagsSchema->type != TSDB_DATA_TYPE_NCHAR) {
      len = tDataTypeDesc[pTagsSchema->type].nSize;
    } else {
4992
      len = varDataTLen(pUpdateMsg->data + schemaLen);
4993 4994 4995 4996
    }
    
    pUpdateMsg->tagValLen = htonl(len);  // length may be changed after dump data
    
4997
    int32_t total = sizeof(SUpdateTableTagValMsg) + len + schemaLen;
4998
    pUpdateMsg->head.contLen = htonl(total);
H
hjxilinx 已提交
4999
    
5000
  } else if (pAlterSQL->type == TSDB_ALTER_TABLE_ADD_COLUMN) {
H
Haojun Liao 已提交
5001 5002
    SArray* pFieldList = pAlterSQL->pAddColumns;
    if (taosArrayGetSize(pFieldList) > 1) {
5003
      const char* msg = "only support add one column";
5004
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
5005 5006
    }

H
Haojun Liao 已提交
5007 5008
    TAOS_FIELD* p = taosArrayGet(pFieldList, 0);
    if (!validateOneColumn(pCmd, p)) {
5009
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5010
    }
H
hjxilinx 已提交
5011
  
H
Haojun Liao 已提交
5012
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, p);
5013
  } else if (pAlterSQL->type == TSDB_ALTER_TABLE_DROP_COLUMN) {
H
hjxilinx 已提交
5014
    if (tscGetNumOfColumns(pTableMeta) == TSDB_MIN_COLUMNS) {  //
H
hjxilinx 已提交
5015
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg15);
H
hzcheng 已提交
5016 5017
    }

H
Haojun Liao 已提交
5018 5019
    size_t size = taosArrayGetSize(pAlterSQL->varList);
    if (size > 1) {
H
hjxilinx 已提交
5020
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg16);
H
hzcheng 已提交
5021 5022
    }

H
Haojun Liao 已提交
5023
    tVariantListItem* pItem = taosArrayGet(pAlterSQL->varList, 0);
H
hzcheng 已提交
5024

5025
    SColumnIndex columnIndex = COLUMN_INDEX_INITIALIZER;
H
Haojun Liao 已提交
5026
    SStrToken    name = {.type = TK_STRING, .z = pItem->pVar.pz, .n = pItem->pVar.nLen};
5027 5028
    if (getColumnIndexByName(pCmd, &name, pQueryInfo, &columnIndex) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg17);
H
hzcheng 已提交
5029 5030
    }

5031
    if (columnIndex.columnIndex == PRIMARYKEY_TIMESTAMP_COL_INDEX) {
5032
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg18);
5033
    }
H
hzcheng 已提交
5034

B
Bomin Zhang 已提交
5035 5036
    char name1[TSDB_COL_NAME_LEN] = {0};
    tstrncpy(name1, pItem->pVar.pz, sizeof(name1));
H
hjxilinx 已提交
5037 5038
    TAOS_FIELD f = tscCreateField(TSDB_DATA_TYPE_INT, name1, tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize);
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, &f);
H
hzcheng 已提交
5039 5040 5041 5042 5043
  }

  return TSDB_CODE_SUCCESS;
}

5044
int32_t validateSqlFunctionInStreamSql(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
5045 5046
  const char* msg0 = "sample interval can not be less than 10ms.";
  const char* msg1 = "functions not allowed in select clause";
H
hzcheng 已提交
5047

5048 5049 5050
  if (pQueryInfo->interval.interval != 0 && pQueryInfo->interval.interval < 10 &&
     pQueryInfo->interval.intervalUnit != 'n' &&
     pQueryInfo->interval.intervalUnit != 'y') {
5051
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
H
hzcheng 已提交
5052
  }
H
hjxilinx 已提交
5053
  
H
hjxilinx 已提交
5054
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5055
  for (int32_t i = 0; i < size; ++i) {
5056
    int32_t functId = tscSqlExprGet(pQueryInfo, i)->functionId;
H
hzcheng 已提交
5057
    if (!IS_STREAM_QUERY_VALID(aAggs[functId].nStatus)) {
5058
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
5059 5060 5061 5062 5063 5064
    }
  }

  return TSDB_CODE_SUCCESS;
}

5065
int32_t validateFunctionsInIntervalOrGroupbyQuery(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
S
slguan 已提交
5066
  bool        isProjectionFunction = false;
5067
  const char* msg1 = "column projection is not compatible with interval";
H
hjxilinx 已提交
5068

H
hzcheng 已提交
5069
  // multi-output set/ todo refactor
H
hjxilinx 已提交
5070
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5071 5072
  
  for (int32_t k = 0; k < size; ++k) {
5073
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, k);
H
hjxilinx 已提交
5074

5075 5076 5077
    // projection query on primary timestamp, the selectivity function needs to be present.
    if (pExpr->functionId == TSDB_FUNC_PRJ && pExpr->colInfo.colId == PRIMARYKEY_TIMESTAMP_COL_INDEX) {
      bool hasSelectivity = false;
H
hjxilinx 已提交
5078
      for (int32_t j = 0; j < size; ++j) {
5079
        SSqlExpr* pEx = tscSqlExprGet(pQueryInfo, j);
5080 5081 5082 5083 5084
        if ((aAggs[pEx->functionId].nStatus & TSDB_FUNCSTATE_SELECTIVITY) == TSDB_FUNCSTATE_SELECTIVITY) {
          hasSelectivity = true;
          break;
        }
      }
H
hjxilinx 已提交
5085

5086 5087 5088 5089
      if (hasSelectivity) {
        continue;
      }
    }
H
hjxilinx 已提交
5090

5091
    if ((pExpr->functionId == TSDB_FUNC_PRJ && pExpr->numOfParams == 0) || pExpr->functionId == TSDB_FUNC_DIFF ||
H
hjxilinx 已提交
5092
        pExpr->functionId == TSDB_FUNC_ARITHM) {
H
hzcheng 已提交
5093 5094 5095
      isProjectionFunction = true;
    }
  }
S
slguan 已提交
5096 5097

  if (isProjectionFunction) {
5098
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
5099 5100
  }

5101
  return isProjectionFunction == true ? TSDB_CODE_TSC_INVALID_SQL : TSDB_CODE_SUCCESS;
H
hzcheng 已提交
5102 5103 5104
}

typedef struct SDNodeDynConfOption {
H
hjxilinx 已提交
5105 5106
  char*   name;  // command name
  int32_t len;   // name string length
H
hzcheng 已提交
5107 5108
} SDNodeDynConfOption;

H
Hui Li 已提交
5109

5110
int32_t validateEp(char* ep) {  
H
Hui Li 已提交
5111 5112 5113
  char buf[TSDB_EP_LEN + 1] = {0};
  tstrncpy(buf, ep, TSDB_EP_LEN);

5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124
  char* pos = strchr(buf, ':');
  if (NULL == pos) {
    int32_t val = strtol(ep, NULL, 10);
    if (val <= 0 || val > 65536) {
      return TSDB_CODE_TSC_INVALID_SQL;
    }
  } else {
    uint16_t port = atoi(pos + 1);
    if (0 == port) {
      return TSDB_CODE_TSC_INVALID_SQL;
    }
H
Hui Li 已提交
5125 5126
  }

5127
  return TSDB_CODE_SUCCESS;
H
Hui Li 已提交
5128 5129
}

H
hzcheng 已提交
5130 5131
int32_t validateDNodeConfig(tDCLSQL* pOptions) {
  if (pOptions->nTokens < 2 || pOptions->nTokens > 3) {
5132
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5133 5134
  }

5135 5136 5137 5138 5139 5140 5141
  const int tokenLogEnd = 2;
  const int tokenBalance = 2;
  const int tokenMonitor = 3;
  const int tokenDebugFlag = 4;
  const int tokenDebugFlagEnd = 20;
  const SDNodeDynConfOption cfgOptions[] = {
      {"resetLog", 8},    {"resetQueryCache", 15},  {"balance", 7},     {"monitor", 7},
S
Shengliang Guan 已提交
5142
      {"debugFlag", 9},   {"monDebugFlag", 12},     {"vDebugFlag", 10}, {"mDebugFlag", 10},
5143 5144 5145
      {"cDebugFlag", 10}, {"httpDebugFlag", 13},    {"qDebugflag", 10}, {"sdbDebugFlag", 12},
      {"uDebugFlag", 10}, {"tsdbDebugFlag", 13},    {"sDebugflag", 10}, {"rpcDebugFlag", 12},
      {"dDebugFlag", 10}, {"mqttDebugFlag", 13},    {"wDebugFlag", 10}, {"tmrDebugFlag", 12},
S
TD-1520  
Shengliang Guan 已提交
5146
      {"cqDebugFlag", 11},
5147
  };
H
hzcheng 已提交
5148

H
Haojun Liao 已提交
5149
  SStrToken* pOptionToken = &pOptions->a[1];
H
hzcheng 已提交
5150 5151 5152

  if (pOptions->nTokens == 2) {
    // reset log and reset query cache does not need value
5153 5154
    for (int32_t i = 0; i < tokenLogEnd; ++i) {
      const SDNodeDynConfOption* pOption = &cfgOptions[i];
H
hzcheng 已提交
5155 5156 5157 5158
      if ((strncasecmp(pOption->name, pOptionToken->z, pOptionToken->n) == 0) && (pOption->len == pOptionToken->n)) {
        return TSDB_CODE_SUCCESS;
      }
    }
5159 5160
  } else if ((strncasecmp(cfgOptions[tokenBalance].name, pOptionToken->z, pOptionToken->n) == 0) &&
             (cfgOptions[tokenBalance].len == pOptionToken->n)) {
H
Haojun Liao 已提交
5161
    SStrToken* pValToken = &pOptions->a[2];
S
Shengliang Guan 已提交
5162 5163
    int32_t vnodeId = 0;
    int32_t dnodeId = 0;
5164
    strdequote(pValToken->z);
S
Shengliang Guan 已提交
5165
    bool parseOk = taosCheckBalanceCfgOptions(pValToken->z, &vnodeId, &dnodeId);
5166 5167 5168 5169 5170 5171
    if (!parseOk) {
      return TSDB_CODE_TSC_INVALID_SQL;  // options value is invalid
    }
    return TSDB_CODE_SUCCESS;
  } else if ((strncasecmp(cfgOptions[tokenMonitor].name, pOptionToken->z, pOptionToken->n) == 0) &&
             (cfgOptions[tokenMonitor].len == pOptionToken->n)) {
H
Haojun Liao 已提交
5172
    SStrToken* pValToken = &pOptions->a[2];
S
slguan 已提交
5173 5174
    int32_t    val = strtol(pValToken->z, NULL, 10);
    if (val != 0 && val != 1) {
5175
      return TSDB_CODE_TSC_INVALID_SQL;  // options value is invalid
S
slguan 已提交
5176 5177
    }
    return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
5178
  } else {
H
Haojun Liao 已提交
5179
    SStrToken* pValToken = &pOptions->a[2];
H
hzcheng 已提交
5180 5181

    int32_t val = strtol(pValToken->z, NULL, 10);
5182
    if (val < 0 || val > 256) {
H
hzcheng 已提交
5183
      /* options value is out of valid range */
5184
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5185 5186
    }

5187 5188
    for (int32_t i = tokenDebugFlag; i < tokenDebugFlagEnd; ++i) {
      const SDNodeDynConfOption* pOption = &cfgOptions[i];
H
hzcheng 已提交
5189 5190 5191 5192 5193 5194 5195 5196

      if ((strncasecmp(pOption->name, pOptionToken->z, pOptionToken->n) == 0) && (pOption->len == pOptionToken->n)) {
        /* options is valid */
        return TSDB_CODE_SUCCESS;
      }
    }
  }

5197
  return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5198 5199
}

S
slguan 已提交
5200 5201
int32_t validateLocalConfig(tDCLSQL* pOptions) {
  if (pOptions->nTokens < 1 || pOptions->nTokens > 2) {
5202
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
5203 5204
  }

H
hjxilinx 已提交
5205 5206
  SDNodeDynConfOption LOCAL_DYNAMIC_CFG_OPTIONS[6] = {{"resetLog", 8},    {"rpcDebugFlag", 12}, {"tmrDebugFlag", 12},
                                                      {"cDebugFlag", 10}, {"uDebugFlag", 10},   {"debugFlag", 9}};
S
slguan 已提交
5207

H
Haojun Liao 已提交
5208
  SStrToken* pOptionToken = &pOptions->a[0];
S
slguan 已提交
5209 5210 5211 5212 5213 5214 5215 5216 5217 5218

  if (pOptions->nTokens == 1) {
    // reset log does not need value
    for (int32_t i = 0; i < 1; ++i) {
      SDNodeDynConfOption* pOption = &LOCAL_DYNAMIC_CFG_OPTIONS[i];
      if ((strncasecmp(pOption->name, pOptionToken->z, pOptionToken->n) == 0) && (pOption->len == pOptionToken->n)) {
        return TSDB_CODE_SUCCESS;
      }
    }
  } else {
H
Haojun Liao 已提交
5219
    SStrToken* pValToken = &pOptions->a[1];
S
slguan 已提交
5220 5221 5222 5223

    int32_t val = strtol(pValToken->z, NULL, 10);
    if (val < 131 || val > 199) {
      // options value is out of valid range
5224
      return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
5225 5226 5227 5228 5229 5230 5231 5232 5233 5234
    }

    for (int32_t i = 1; i < tListLen(LOCAL_DYNAMIC_CFG_OPTIONS); ++i) {
      SDNodeDynConfOption* pOption = &LOCAL_DYNAMIC_CFG_OPTIONS[i];
      if ((strncasecmp(pOption->name, pOptionToken->z, pOptionToken->n) == 0) && (pOption->len == pOptionToken->n)) {
        // options is valid
        return TSDB_CODE_SUCCESS;
      }
    }
  }
5235
  return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
5236 5237
}

H
hzcheng 已提交
5238
int32_t validateColumnName(char* name) {
S
TD-1057  
Shengliang Guan 已提交
5239
  bool ret = isKeyWord(name, (int32_t)strlen(name));
H
hzcheng 已提交
5240
  if (ret) {
5241
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5242 5243
  }

H
Haojun Liao 已提交
5244
  SStrToken token = {.z = name};
H
hzcheng 已提交
5245 5246 5247
  token.n = tSQLGetToken(name, &token.type);

  if (token.type != TK_STRING && token.type != TK_ID) {
5248
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5249 5250 5251 5252
  }

  if (token.type == TK_STRING) {
    strdequote(token.z);
S
TD-1057  
Shengliang Guan 已提交
5253
    token.n = (uint32_t)strtrim(token.z);
H
hzcheng 已提交
5254 5255 5256

    int32_t k = tSQLGetToken(token.z, &token.type);
    if (k != token.n) {
5257
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5258 5259 5260 5261 5262
    }

    return validateColumnName(token.z);
  } else {
    if (isNumber(&token)) {
5263
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5264 5265 5266 5267 5268 5269
    }
  }

  return TSDB_CODE_SUCCESS;
}

5270 5271
bool hasTimestampForPointInterpQuery(SQueryInfo* pQueryInfo) {
  if (!tscIsPointInterpQuery(pQueryInfo)) {
H
hzcheng 已提交
5272 5273 5274
    return true;
  }

H
hjxilinx 已提交
5275
  return (pQueryInfo->window.skey == pQueryInfo->window.ekey) && (pQueryInfo->window.skey != 0);
H
hzcheng 已提交
5276 5277
}

5278
int32_t parseLimitClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, int32_t clauseIndex, SQuerySQL* pQuerySql, SSqlObj* pSql) {
H
hjxilinx 已提交
5279
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hzcheng 已提交
5280

S
slguan 已提交
5281 5282
  const char* msg0 = "soffset/offset can not be less than 0";
  const char* msg1 = "slimit/soffset only available for STable query";
5283
  const char* msg2 = "slimit/soffset can not apply to projection query";
H
hjxilinx 已提交
5284

H
hzcheng 已提交
5285
  // handle the limit offset value, validate the limit
5286
  pQueryInfo->limit = pQuerySql->limit;
5287
  pQueryInfo->clauseLimit = pQueryInfo->limit.limit;
5288
  pQueryInfo->slimit = pQuerySql->slimit;
5289
  
5290
  tscDebug("%p limit:%" PRId64 ", offset:%" PRId64 " slimit:%" PRId64 ", soffset:%" PRId64, pSql, pQueryInfo->limit.limit,
5291 5292
      pQueryInfo->limit.offset, pQueryInfo->slimit.limit, pQueryInfo->slimit.offset);
  
5293
  if (pQueryInfo->slimit.offset < 0 || pQueryInfo->limit.offset < 0) {
5294
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
S
slguan 已提交
5295 5296
  }

5297
  if (pQueryInfo->limit.limit == 0) {
5298
    tscDebug("%p limit 0, no output result", pSql);
5299
    pQueryInfo->command = TSDB_SQL_RETRIEVE_EMPTY_RESULT;
H
hjxilinx 已提交
5300
    return TSDB_CODE_SUCCESS;
S
slguan 已提交
5301 5302
  }

H
hjxilinx 已提交
5303
  // todo refactor
weixin_48148422's avatar
weixin_48148422 已提交
5304
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
hjxilinx 已提交
5305
    if (!tscQueryTags(pQueryInfo)) {  // local handle the super table tag query
5306
      if (tscIsProjectionQueryOnSTable(pQueryInfo, 0)) {
H
hjxilinx 已提交
5307
        if (pQueryInfo->slimit.limit > 0 || pQueryInfo->slimit.offset > 0) {
5308
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hjxilinx 已提交
5309
        }
H
hjxilinx 已提交
5310

5311
        // for projection query on super table, all queries are subqueries
H
hjxilinx 已提交
5312 5313
        if (tscNonOrderedProjectionQueryOnSTable(pQueryInfo, 0) &&
            !TSDB_QUERY_HAS_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_JOIN_QUERY)) {
5314
          pQueryInfo->type |= TSDB_QUERY_TYPE_SUBQUERY;
5315
        }
S
slguan 已提交
5316
      }
H
hzcheng 已提交
5317 5318
    }

5319
    if (pQueryInfo->slimit.limit == 0) {
5320
      tscDebug("%p slimit 0, no output result", pSql);
5321
      pQueryInfo->command = TSDB_SQL_RETRIEVE_EMPTY_RESULT;
H
hzcheng 已提交
5322 5323 5324 5325
      return TSDB_CODE_SUCCESS;
    }

    /*
5326 5327 5328 5329
     * Get the distribution of all tables among all available virtual nodes that are qualified for the query condition
     * and created according to this super table from management node.
     * And then launching multiple async-queries against all qualified virtual nodes, during the first-stage
     * query operation.
H
hzcheng 已提交
5330
     */
H
hjxilinx 已提交
5331
    int32_t code = tscGetSTableVgroupInfo(pSql, clauseIndex);
H
hzcheng 已提交
5332 5333 5334 5335
    if (code != TSDB_CODE_SUCCESS) {
      return code;
    }

S
slguan 已提交
5336
    // No tables included. No results generated. Query results are empty.
5337
    if (pTableMetaInfo->vgroupList->numOfVgroups == 0) {
5338
      tscDebug("%p no table in super table, no output result", pSql);
5339
      pQueryInfo->command = TSDB_SQL_RETRIEVE_EMPTY_RESULT;
H
hjxilinx 已提交
5340
      return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
5341 5342 5343
    }

    // keep original limitation value in globalLimit
5344
    pQueryInfo->clauseLimit = pQueryInfo->limit.limit;
H
Haojun Liao 已提交
5345
    pQueryInfo->prjOffset   = pQueryInfo->limit.offset;
H
Haojun Liao 已提交
5346
    pQueryInfo->vgroupLimit = -1;
H
hjxilinx 已提交
5347

5348 5349
    if (tscOrderedProjectionQueryOnSTable(pQueryInfo, 0)) {
      /*
5350 5351 5352 5353
       * the offset value should be removed during retrieve data from virtual node, since the
       * global order are done in client side, so the offset is applied at the client side
       * However, note that the maximum allowed number of result for each table should be less
       * than or equal to the value of limit.
5354 5355
       */
      if (pQueryInfo->limit.limit > 0) {
H
Haojun Liao 已提交
5356
        pQueryInfo->vgroupLimit = pQueryInfo->limit.limit + pQueryInfo->limit.offset;
5357 5358
        pQueryInfo->limit.limit = -1;
      }
H
hjxilinx 已提交
5359

5360 5361
      pQueryInfo->limit.offset = 0;
    }
H
hzcheng 已提交
5362
  } else {
5363
    if (pQueryInfo->slimit.limit != -1 || pQueryInfo->slimit.offset != 0) {
5364
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
5365 5366 5367 5368 5369
    }
  }

  return TSDB_CODE_SUCCESS;
}
5370

S
TD-1732  
Shengliang Guan 已提交
5371
static int32_t setKeepOption(SSqlCmd* pCmd, SCreateDbMsg* pMsg, SCreateDBInfo* pCreateDb) {
H
hjxilinx 已提交
5372
  const char* msg = "invalid number of options";
H
hjxilinx 已提交
5373

5374 5375 5376
  pMsg->daysToKeep = htonl(-1);
  pMsg->daysToKeep1 = htonl(-1);
  pMsg->daysToKeep2 = htonl(-1);
H
hjxilinx 已提交
5377

H
Haojun Liao 已提交
5378
  SArray* pKeep = pCreateDb->keep;
H
hjxilinx 已提交
5379
  if (pKeep != NULL) {
H
Haojun Liao 已提交
5380 5381 5382 5383
    size_t s = taosArrayGetSize(pKeep);
    tVariantListItem* p0 = taosArrayGet(pKeep, 0);
    switch (s) {
      case 1: {
5384
        pMsg->daysToKeep = htonl((int32_t)p0->pVar.i64);
H
Haojun Liao 已提交
5385
      }
5386 5387
        break;
      case 2: {
H
Haojun Liao 已提交
5388
        tVariantListItem* p1 = taosArrayGet(pKeep, 1);
5389 5390
        pMsg->daysToKeep = htonl((int32_t)p0->pVar.i64);
        pMsg->daysToKeep1 = htonl((int32_t)p1->pVar.i64);
5391 5392 5393
        break;
      }
      case 3: {
H
Haojun Liao 已提交
5394 5395 5396
        tVariantListItem* p1 = taosArrayGet(pKeep, 1);
        tVariantListItem* p2 = taosArrayGet(pKeep, 2);

5397 5398 5399
        pMsg->daysToKeep = htonl((int32_t)p0->pVar.i64);
        pMsg->daysToKeep1 = htonl((int32_t)p1->pVar.i64);
        pMsg->daysToKeep2 = htonl((int32_t)p2->pVar.i64);
5400 5401
        break;
      }
5402
      default: { return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg); }
5403 5404
    }
  }
H
hjxilinx 已提交
5405

H
hjxilinx 已提交
5406 5407
  return TSDB_CODE_SUCCESS;
}
5408

S
TD-1732  
Shengliang Guan 已提交
5409
static int32_t setTimePrecision(SSqlCmd* pCmd, SCreateDbMsg* pMsg, SCreateDBInfo* pCreateDbInfo) {
H
hjxilinx 已提交
5410
  const char* msg = "invalid time precision";
H
hjxilinx 已提交
5411

H
hjxilinx 已提交
5412
  pMsg->precision = TSDB_TIME_PRECISION_MILLI;  // millisecond by default
H
hjxilinx 已提交
5413

H
Haojun Liao 已提交
5414
  SStrToken* pToken = &pCreateDbInfo->precision;
5415 5416
  if (pToken->n > 0) {
    pToken->n = strdequote(pToken->z);
H
hjxilinx 已提交
5417

5418 5419 5420 5421 5422
    if (strncmp(pToken->z, TSDB_TIME_PRECISION_MILLI_STR, pToken->n) == 0 &&
        strlen(TSDB_TIME_PRECISION_MILLI_STR) == pToken->n) {
      // time precision for this db: million second
      pMsg->precision = TSDB_TIME_PRECISION_MILLI;
    } else if (strncmp(pToken->z, TSDB_TIME_PRECISION_MICRO_STR, pToken->n) == 0 &&
H
hjxilinx 已提交
5423
               strlen(TSDB_TIME_PRECISION_MICRO_STR) == pToken->n) {
5424 5425
      pMsg->precision = TSDB_TIME_PRECISION_MICRO;
    } else {
5426
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
5427 5428
    }
  }
H
hjxilinx 已提交
5429

H
hjxilinx 已提交
5430 5431
  return TSDB_CODE_SUCCESS;
}
5432

S
TD-1732  
Shengliang Guan 已提交
5433
static void setCreateDBOption(SCreateDbMsg* pMsg, SCreateDBInfo* pCreateDb) {
H
Haojun Liao 已提交
5434
  pMsg->maxTables = htonl(-1);  // max tables can not be set anymore
H
hjxilinx 已提交
5435
  pMsg->cacheBlockSize = htonl(pCreateDb->cacheBlockSize);
5436
  pMsg->totalBlocks = htonl(pCreateDb->numOfBlocks);
H
hjxilinx 已提交
5437
  pMsg->daysPerFile = htonl(pCreateDb->daysPerFile);
S
TD-1057  
Shengliang Guan 已提交
5438
  pMsg->commitTime = htonl((int32_t)pCreateDb->commitTime);
H
hjxilinx 已提交
5439 5440
  pMsg->minRowsPerFileBlock = htonl(pCreateDb->minRowsPerBlock);
  pMsg->maxRowsPerFileBlock = htonl(pCreateDb->maxRowsPerBlock);
陶建辉(Jeff)'s avatar
陶建辉(Jeff) 已提交
5441
  pMsg->fsyncPeriod = htonl(pCreateDb->fsyncPeriod);
S
slguan 已提交
5442
  pMsg->compression = pCreateDb->compressionLevel;
H
hjxilinx 已提交
5443
  pMsg->walLevel = (char)pCreateDb->walLevel;
H
hjxilinx 已提交
5444
  pMsg->replications = pCreateDb->replica;
5445
  pMsg->quorum = pCreateDb->quorum;
5446
  pMsg->ignoreExist = pCreateDb->ignoreExists;
Y
yihaoDeng 已提交
5447
  pMsg->update = pCreateDb->update;
D
dapan1121 已提交
5448
  pMsg->cacheLastRow = pCreateDb->cachelast;
H
hjxilinx 已提交
5449 5450 5451
}

int32_t parseCreateDBOptions(SSqlCmd* pCmd, SCreateDBInfo* pCreateDbSql) {
S
TD-1732  
Shengliang Guan 已提交
5452
  SCreateDbMsg* pMsg = (SCreateDbMsg *)(pCmd->payload);
H
hjxilinx 已提交
5453
  setCreateDBOption(pMsg, pCreateDbSql);
H
hjxilinx 已提交
5454

H
hjxilinx 已提交
5455
  if (setKeepOption(pCmd, pMsg, pCreateDbSql) != TSDB_CODE_SUCCESS) {
5456
    return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
5457
  }
H
hjxilinx 已提交
5458

H
hjxilinx 已提交
5459
  if (setTimePrecision(pCmd, pMsg, pCreateDbSql) != TSDB_CODE_SUCCESS) {
5460
    return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
5461
  }
H
hjxilinx 已提交
5462

H
hjxilinx 已提交
5463
  if (tscCheckCreateDbParams(pCmd, pMsg) != TSDB_CODE_SUCCESS) {
5464
    return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
5465
  }
H
hjxilinx 已提交
5466

5467
  return TSDB_CODE_SUCCESS;
H
huili 已提交
5468
}
S
slguan 已提交
5469

5470 5471
void addGroupInfoForSubquery(SSqlObj* pParentObj, SSqlObj* pSql, int32_t subClauseIndex, int32_t tableIndex) {
  SQueryInfo* pParentQueryInfo = tscGetQueryInfoDetail(&pParentObj->cmd, subClauseIndex);
5472

5473 5474
  if (pParentQueryInfo->groupbyExpr.numOfGroupCols > 0) {
    SQueryInfo* pQueryInfo = tscGetQueryInfoDetail(&pSql->cmd, subClauseIndex);
H
Haojun Liao 已提交
5475 5476
    SSqlExpr* pExpr = NULL;

H
hjxilinx 已提交
5477
    size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
Haojun Liao 已提交
5478 5479 5480
    if (size > 0) {
      pExpr = tscSqlExprGet(pQueryInfo, (int32_t)size - 1);
    }
5481

H
Haojun Liao 已提交
5482
    if (pExpr == NULL || pExpr->functionId != TSDB_FUNC_TAG) {
H
Haojun Liao 已提交
5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494
      STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pParentQueryInfo, tableIndex);

      int16_t colId = tscGetJoinTagColIdByUid(&pQueryInfo->tagCond, pTableMetaInfo->pTableMeta->id.uid);

      SSchema* pTagSchema = tscGetColumnSchemaById(pTableMetaInfo->pTableMeta, colId);
      int16_t colIndex = tscGetTagColIndexById(pTableMetaInfo->pTableMeta, colId);
      SColumnIndex    index = {.tableIndex = 0, .columnIndex = colIndex};

      char*   name = pTagSchema->name;
      int16_t type = pTagSchema->type;
      int16_t bytes = pTagSchema->bytes;

H
Haojun Liao 已提交
5495
      pExpr = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_TAG, &index, type, bytes, getNewResColId(pQueryInfo), bytes, true);
S
slguan 已提交
5496 5497 5498 5499
      pExpr->colInfo.flag = TSDB_COL_TAG;

      // NOTE: tag column does not add to source column list
      SColumnList ids = {0};
S
TD-1057  
Shengliang Guan 已提交
5500
      insertResultField(pQueryInfo, (int32_t)size, &ids, bytes, (int8_t)type, name, pExpr);
S
slguan 已提交
5501 5502 5503

      int32_t relIndex = index.columnIndex;

5504
      pExpr->colInfo.colIndex = relIndex;
5505 5506
      SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, 0);
      pColIndex->colIndex = relIndex;
S
slguan 已提交
5507

5508
      index = (SColumnIndex) {.tableIndex = tableIndex, .columnIndex = relIndex};
H
hjxilinx 已提交
5509
      tscColumnListInsert(pTableMetaInfo->tagColList, &index);
S
slguan 已提交
5510 5511 5512 5513
    }
  }
}

H
hjxilinx 已提交
5514 5515 5516
// limit the output to be 1 for each state value
static void doLimitOutputNormalColOfGroupby(SSqlExpr* pExpr) {
  int32_t outputRow = 1;
H
hjxilinx 已提交
5517
  tVariantCreateFromBinary(&pExpr->param[0], (char*)&outputRow, sizeof(int32_t), TSDB_DATA_TYPE_INT);
H
hjxilinx 已提交
5518 5519 5520
  pExpr->numOfParams = 1;
}

5521
void doAddGroupColumnForSubquery(SQueryInfo* pQueryInfo, int32_t tagIndex) {
5522
  SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, tagIndex);
H
hjxilinx 已提交
5523
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
S
slguan 已提交
5524

H
Haojun Liao 已提交
5525 5526 5527 5528
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);

  SSchema*     pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, pColIndex->colIndex);
  SColumnIndex colIndex = {.tableIndex = 0, .columnIndex = pColIndex->colIndex};
H
hjxilinx 已提交
5529

S
TD-1057  
Shengliang Guan 已提交
5530
  tscAddSpecialColumnForSelect(pQueryInfo, (int32_t)size, TSDB_FUNC_PRJ, &colIndex, pSchema, TSDB_COL_NORMAL);
S
slguan 已提交
5531

H
Haojun Liao 已提交
5532 5533 5534
  int32_t numOfFields = tscNumOfFields(pQueryInfo);
  SInternalField* pInfo = tscFieldInfoGetInternalField(&pQueryInfo->fieldsInfo, numOfFields - 1);

H
Haojun Liao 已提交
5535
  doLimitOutputNormalColOfGroupby(pInfo->pSqlExpr);
H
hjxilinx 已提交
5536
  pInfo->visible = false;
S
slguan 已提交
5537 5538
}

5539
static void doUpdateSqlFunctionForTagPrj(SQueryInfo* pQueryInfo) {
S
slguan 已提交
5540
  int32_t tagLength = 0;
H
hjxilinx 已提交
5541
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
5542 5543 5544 5545 5546

//todo is 0??
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
  bool isSTable = UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo);

H
hjxilinx 已提交
5547
  for (int32_t i = 0; i < size; ++i) {
5548
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
5549 5550 5551 5552 5553 5554 5555 5556 5557
    if (pExpr->functionId == TSDB_FUNC_TAGPRJ || pExpr->functionId == TSDB_FUNC_TAG) {
      pExpr->functionId = TSDB_FUNC_TAG_DUMMY;
      tagLength += pExpr->resBytes;
    } else if (pExpr->functionId == TSDB_FUNC_PRJ && pExpr->colInfo.colId == PRIMARYKEY_TIMESTAMP_COL_INDEX) {
      pExpr->functionId = TSDB_FUNC_TS_DUMMY;
      tagLength += pExpr->resBytes;
    }
  }

5558
  SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
5559

H
hjxilinx 已提交
5560
  for (int32_t i = 0; i < size; ++i) {
5561
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
H
Haojun Liao 已提交
5562 5563
    if ((pExpr->functionId != TSDB_FUNC_TAG_DUMMY && pExpr->functionId != TSDB_FUNC_TS_DUMMY) &&
       !(pExpr->functionId == TSDB_FUNC_PRJ && TSDB_COL_IS_UD_COL(pExpr->colInfo.flag))) {
5564
      SSchema* pColSchema = &pSchema[pExpr->colInfo.colIndex];
5565
      getResultDataInfo(pColSchema->type, pColSchema->bytes, pExpr->functionId, (int32_t)pExpr->param[0].i64, &pExpr->resType,
5566
                        &pExpr->resBytes, &pExpr->interBytes, tagLength, isSTable);
S
slguan 已提交
5567 5568 5569 5570
    }
  }
}

H
Haojun Liao 已提交
5571
static int32_t doUpdateSqlFunctionForColPrj(SQueryInfo* pQueryInfo) {
H
hjxilinx 已提交
5572
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5573 5574
  
  for (int32_t i = 0; i < size; ++i) {
5575
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
H
Haojun Liao 已提交
5576

5577
    if (pExpr->functionId == TSDB_FUNC_PRJ && (!TSDB_COL_IS_UD_COL(pExpr->colInfo.flag) && (pExpr->colInfo.colId != PRIMARYKEY_TIMESTAMP_COL_INDEX))) {
H
hjxilinx 已提交
5578
      bool qualifiedCol = false;
5579
      for (int32_t j = 0; j < pQueryInfo->groupbyExpr.numOfGroupCols; ++j) {
5580 5581 5582
        SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, j);
  
        if (pExpr->colInfo.colId == pColIndex->colId) {
H
hjxilinx 已提交
5583
          qualifiedCol = true;
H
hjxilinx 已提交
5584
          doLimitOutputNormalColOfGroupby(pExpr);
H
hjxilinx 已提交
5585 5586 5587 5588
          pExpr->numOfParams = 1;
          break;
        }
      }
H
hjxilinx 已提交
5589

H
Haojun Liao 已提交
5590 5591 5592 5593
      // it is not a tag column/tbname column/user-defined column, return error
      if (!qualifiedCol) {
        return TSDB_CODE_TSC_INVALID_SQL;
      }
H
hjxilinx 已提交
5594 5595
    }
  }
H
Haojun Liao 已提交
5596 5597

  return TSDB_CODE_SUCCESS;
H
hjxilinx 已提交
5598 5599
}

S
slguan 已提交
5600 5601
static bool tagColumnInGroupby(SSqlGroupbyExpr* pGroupbyExpr, int16_t columnId) {
  for (int32_t j = 0; j < pGroupbyExpr->numOfGroupCols; ++j) {
5602 5603
    SColIndex* pColIndex = taosArrayGet(pGroupbyExpr->columnInfo, j);
  
Y
TD-1230  
yihaoDeng 已提交
5604
    if (columnId == pColIndex->colId && TSDB_COL_IS_TAG(pColIndex->flag )) {
S
slguan 已提交
5605 5606 5607 5608 5609 5610 5611
      return true;
    }
  }

  return false;
}

5612
static bool onlyTagPrjFunction(SQueryInfo* pQueryInfo) {
S
slguan 已提交
5613 5614
  bool hasTagPrj = false;
  bool hasColumnPrj = false;
H
hjxilinx 已提交
5615
  
H
hjxilinx 已提交
5616
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5617
  for (int32_t i = 0; i < size; ++i) {
5618
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629
    if (pExpr->functionId == TSDB_FUNC_PRJ) {
      hasColumnPrj = true;
    } else if (pExpr->functionId == TSDB_FUNC_TAGPRJ) {
      hasTagPrj = true;
    }
  }

  return (hasTagPrj) && (hasColumnPrj == false);
}

// check if all the tags prj columns belongs to the group by columns
5630
static bool allTagPrjInGroupby(SQueryInfo* pQueryInfo) {
S
slguan 已提交
5631 5632
  bool allInGroupby = true;

H
hjxilinx 已提交
5633 5634
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t i = 0; i < size; ++i) {
5635
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
5636 5637 5638 5639
    if (pExpr->functionId != TSDB_FUNC_TAGPRJ) {
      continue;
    }

5640
    if (!tagColumnInGroupby(&pQueryInfo->groupbyExpr, pExpr->colInfo.colId)) {
S
slguan 已提交
5641 5642 5643 5644 5645 5646 5647 5648 5649
      allInGroupby = false;
      break;
    }
  }

  // all selected tag columns belong to the group by columns set, always correct
  return allInGroupby;
}

5650
static void updateTagPrjFunction(SQueryInfo* pQueryInfo) {
H
hjxilinx 已提交
5651
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5652 5653
  
  for (int32_t i = 0; i < size; ++i) {
5654
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666
    if (pExpr->functionId == TSDB_FUNC_TAGPRJ) {
      pExpr->functionId = TSDB_FUNC_TAG;
    }
  }
}

/*
 * check for selectivity function + tags column function both exist.
 * 1. tagprj functions are not compatible with aggregated function when missing "group by" clause
 * 2. if selectivity function and tagprj function both exist, there should be only
 *    one selectivity function exists.
 */
5667
static int32_t checkUpdateTagPrjFunctions(SQueryInfo* pQueryInfo, SSqlCmd* pCmd) {
S
slguan 已提交
5668
  const char* msg1 = "only one selectivity function allowed in presence of tags function";
H
hjxilinx 已提交
5669
  const char* msg3 = "aggregation function should not be mixed up with projection";
H
hjxilinx 已提交
5670

H
Haojun Liao 已提交
5671
  bool    tagTsColExists = false;
S
slguan 已提交
5672 5673 5674
  int16_t numOfSelectivity = 0;
  int16_t numOfAggregation = 0;

H
hjxilinx 已提交
5675
  size_t numOfExprs = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5676
  for (int32_t i = 0; i < numOfExprs; ++i) {
H
hjxilinx 已提交
5677
    SSqlExpr* pExpr = taosArrayGetP(pQueryInfo->exprList, i);
S
slguan 已提交
5678 5679
    if (pExpr->functionId == TSDB_FUNC_TAGPRJ ||
        (pExpr->functionId == TSDB_FUNC_PRJ && pExpr->colInfo.colId == PRIMARYKEY_TIMESTAMP_COL_INDEX)) {
H
Haojun Liao 已提交
5680
      tagTsColExists = true;  // selectivity + ts/tag column
S
slguan 已提交
5681 5682 5683
      break;
    }
  }
H
hjxilinx 已提交
5684

H
hjxilinx 已提交
5685
  for (int32_t i = 0; i < numOfExprs; ++i) {
H
hjxilinx 已提交
5686
    SSqlExpr* pExpr = taosArrayGetP(pQueryInfo->exprList, i);
H
hjxilinx 已提交
5687 5688
  
    int16_t functionId = pExpr->functionId;
5689
    if (functionId == TSDB_FUNC_TAGPRJ || functionId == TSDB_FUNC_PRJ || functionId == TSDB_FUNC_TS ||
H
hjxilinx 已提交
5690
        functionId == TSDB_FUNC_ARITHM) {
H
hjxilinx 已提交
5691
      continue;
S
slguan 已提交
5692
    }
H
hjxilinx 已提交
5693

H
hjxilinx 已提交
5694 5695 5696 5697 5698 5699
    if ((aAggs[functionId].nStatus & TSDB_FUNCSTATE_SELECTIVITY) != 0) {
      numOfSelectivity++;
    } else {
      numOfAggregation++;
    }
  }
H
hjxilinx 已提交
5700

H
Haojun Liao 已提交
5701
  if (tagTsColExists) {  // check if the selectivity function exists
S
slguan 已提交
5702 5703
    // When the tag projection function on tag column that is not in the group by clause, aggregation function and
    // selectivity function exist in select clause is not allowed.
5704
    if (numOfAggregation > 0) {
5705
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
5706 5707 5708 5709 5710 5711
    }

    /*
     *  if numOfSelectivity equals to 0, it is a super table projection query
     */
    if (numOfSelectivity == 1) {
5712
      doUpdateSqlFunctionForTagPrj(pQueryInfo);
H
Haojun Liao 已提交
5713 5714 5715 5716 5717
      int32_t code = doUpdateSqlFunctionForColPrj(pQueryInfo);
      if (code != TSDB_CODE_SUCCESS) {
        return code;
      }

S
slguan 已提交
5718 5719 5720 5721 5722
    } else if (numOfSelectivity > 1) {
      /*
       * If more than one selectivity functions exist, all the selectivity functions must be last_row.
       * Otherwise, return with error code.
       */
H
hjxilinx 已提交
5723
      for (int32_t i = 0; i < numOfExprs; ++i) {
H
Haojun Liao 已提交
5724 5725 5726
        SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
        int16_t functionId = pExpr->functionId;
        if (functionId == TSDB_FUNC_TAGPRJ || (aAggs[functionId].nStatus & TSDB_FUNCSTATE_SELECTIVITY) == 0) {
S
slguan 已提交
5727 5728 5729
          continue;
        }

H
Haojun Liao 已提交
5730 5731 5732 5733
        if ((functionId == TSDB_FUNC_LAST_ROW) ||
             (functionId == TSDB_FUNC_LAST_DST && (pExpr->colInfo.flag & TSDB_COL_NULL) != 0)) {
          // do nothing
        } else {
5734
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
5735 5736 5737
        }
      }

5738
      doUpdateSqlFunctionForTagPrj(pQueryInfo);
H
Haojun Liao 已提交
5739 5740 5741 5742
      int32_t code = doUpdateSqlFunctionForColPrj(pQueryInfo);
      if (code != TSDB_CODE_SUCCESS) {
        return code;
      }
H
hjxilinx 已提交
5743 5744
    }
  } else {
5745
    if ((pQueryInfo->type & TSDB_QUERY_TYPE_PROJECTION_QUERY) != 0) {
5746
      if (numOfAggregation > 0 && pQueryInfo->groupbyExpr.numOfGroupCols == 0) {
5747
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hjxilinx 已提交
5748
      }
H
hjxilinx 已提交
5749

H
hjxilinx 已提交
5750 5751
      if (numOfAggregation > 0 || numOfSelectivity > 0) {
        // clear the projection type flag
5752
        pQueryInfo->type &= (~TSDB_QUERY_TYPE_PROJECTION_QUERY);
H
Haojun Liao 已提交
5753 5754 5755 5756
        int32_t code = doUpdateSqlFunctionForColPrj(pQueryInfo);
        if (code != TSDB_CODE_SUCCESS) {
          return code;
        }
H
hjxilinx 已提交
5757
      }
S
slguan 已提交
5758 5759 5760 5761 5762 5763
    }
  }

  return TSDB_CODE_SUCCESS;
}

5764
static int32_t doAddGroupbyColumnsOnDemand(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
S
slguan 已提交
5765 5766
  const char* msg2 = "interval not allowed in group by normal column";

H
hjxilinx 已提交
5767
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
S
slguan 已提交
5768

H
Haojun Liao 已提交
5769
  SSchema s = tGetTableNameColumnSchema();
H
hjxilinx 已提交
5770
  SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
5771 5772 5773 5774
  int16_t  bytes = 0;
  int16_t  type = 0;
  char*    name = NULL;

5775
  for (int32_t i = 0; i < pQueryInfo->groupbyExpr.numOfGroupCols; ++i) {
5776
    SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, i);
5777
    int16_t colIndex = pColIndex->colIndex;
5778
    if (colIndex == TSDB_TBNAME_COLUMN_INDEX) {
H
Haojun Liao 已提交
5779
      type  = s.type;
H
Haojun Liao 已提交
5780
      bytes = s.bytes;
H
Haojun Liao 已提交
5781
      name  = s.name;
S
slguan 已提交
5782
    } else {
5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793
      if (TSDB_COL_IS_TAG(pColIndex->flag)) {
        SSchema* tagSchema = tscGetTableTagSchema(pTableMetaInfo->pTableMeta);
        
        type  = tagSchema[colIndex].type;
        bytes = tagSchema[colIndex].bytes;
        name  = tagSchema[colIndex].name;
      } else {
        type  = pSchema[colIndex].type;
        bytes = pSchema[colIndex].bytes;
        name  = pSchema[colIndex].name;
      }
S
slguan 已提交
5794
    }
H
hjxilinx 已提交
5795 5796 5797
  
    size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  
S
slguan 已提交
5798
    if (TSDB_COL_IS_TAG(pColIndex->flag)) {
5799
      SColumnIndex index = {.tableIndex = pQueryInfo->groupbyExpr.tableIndex, .columnIndex = colIndex};
H
Haojun Liao 已提交
5800
      SSqlExpr* pExpr = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_TAG, &index, type, bytes, getNewResColId(pQueryInfo), bytes, true);
5801
      
B
Bomin Zhang 已提交
5802 5803
      memset(pExpr->aliasName, 0, sizeof(pExpr->aliasName));
      tstrncpy(pExpr->aliasName, name, sizeof(pExpr->aliasName));
5804
      
S
slguan 已提交
5805 5806 5807
      pExpr->colInfo.flag = TSDB_COL_TAG;

      // NOTE: tag column does not add to source column list
5808
      SColumnList ids = getColumnList(1, 0, pColIndex->colIndex);
S
TD-1057  
Shengliang Guan 已提交
5809
      insertResultField(pQueryInfo, (int32_t)size, &ids, bytes, (int8_t)type, name, pExpr);
S
slguan 已提交
5810 5811
    } else {
      // if this query is "group by" normal column, interval is not allowed
5812
      if (pQueryInfo->interval.interval > 0) {
5813
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
5814 5815 5816
      }

      bool hasGroupColumn = false;
H
hjxilinx 已提交
5817
      for (int32_t j = 0; j < size; ++j) {
5818
        SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, j);
S
slguan 已提交
5819 5820 5821 5822 5823 5824 5825 5826 5827 5828
        if (pExpr->colInfo.colId == pColIndex->colId) {
          break;
        }
      }

      /*
       * if the group by column does not required by user, add this column into the final result set
       * but invisible to user
       */
      if (!hasGroupColumn) {
5829
        doAddGroupColumnForSubquery(pQueryInfo, i);
S
slguan 已提交
5830 5831 5832 5833 5834 5835 5836
      }
    }
  }

  return TSDB_CODE_SUCCESS;
}

5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860
static int32_t doTagFunctionCheck(SQueryInfo* pQueryInfo) {
  bool tagProjection = false;
  bool tableCounting = false;

  int32_t numOfCols = (int32_t) tscSqlExprNumOfExprs(pQueryInfo);

  for (int32_t i = 0; i < numOfCols; ++i) {
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
    int32_t functionId = pExpr->functionId;

    if (functionId == TSDB_FUNC_TAGPRJ) {
      tagProjection = true;
      continue;
    }

    if (functionId == TSDB_FUNC_COUNT) {
      assert(pExpr->colInfo.colId == TSDB_TBNAME_COLUMN_INDEX);
      tableCounting = true;
    }
  }

  return (tableCounting && tagProjection)? -1:0;
}

5861
int32_t doFunctionsCompatibleCheck(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
S
slguan 已提交
5862
  const char* msg1 = "functions/columns not allowed in group by query";
H
hjxilinx 已提交
5863
  const char* msg2 = "projection query on columns not allowed";
S
slguan 已提交
5864
  const char* msg3 = "group by not allowed on projection query";
H
hjxilinx 已提交
5865
  const char* msg4 = "retrieve tags not compatible with group by or interval query";
5866
  const char* msg5 = "functions can not be mixed up";
S
slguan 已提交
5867 5868

  // only retrieve tags, group by is not supportted
H
hjxilinx 已提交
5869
  if (tscQueryTags(pQueryInfo)) {
5870 5871 5872 5873
    if (doTagFunctionCheck(pQueryInfo) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
    }

5874
    if (pQueryInfo->groupbyExpr.numOfGroupCols > 0 || pQueryInfo->interval.interval > 0) {
5875
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
5876 5877 5878 5879 5880
    } else {
      return TSDB_CODE_SUCCESS;
    }
  }

5881
  if (pQueryInfo->groupbyExpr.numOfGroupCols > 0) {
S
slguan 已提交
5882
    // check if all the tags prj columns belongs to the group by columns
5883 5884
    if (onlyTagPrjFunction(pQueryInfo) && allTagPrjInGroupby(pQueryInfo)) {
      updateTagPrjFunction(pQueryInfo);
5885
      return doAddGroupbyColumnsOnDemand(pCmd, pQueryInfo);
S
slguan 已提交
5886 5887 5888
    }

    // check all query functions in selection clause, multi-output functions are not allowed
H
hjxilinx 已提交
5889 5890
    size_t size = tscSqlExprNumOfExprs(pQueryInfo);
    for (int32_t i = 0; i < size; ++i) {
5891
      SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
5892 5893 5894 5895 5896 5897
      int32_t   functId = pExpr->functionId;

      /*
       * group by normal columns.
       * Check if the column projection is identical to the group by column or not
       */
5898
      if (functId == TSDB_FUNC_PRJ && pExpr->colInfo.colId != PRIMARYKEY_TIMESTAMP_COL_INDEX) {
S
slguan 已提交
5899
        bool qualified = false;
5900
        for (int32_t j = 0; j < pQueryInfo->groupbyExpr.numOfGroupCols; ++j) {
5901
          SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, j);
S
slguan 已提交
5902 5903 5904 5905 5906 5907 5908
          if (pColIndex->colId == pExpr->colInfo.colId) {
            qualified = true;
            break;
          }
        }

        if (!qualified) {
5909
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
5910 5911 5912 5913
        }
      }

      if (IS_MULTIOUTPUT(aAggs[functId].nStatus) && functId != TSDB_FUNC_TOP && functId != TSDB_FUNC_BOTTOM &&
H
hjxilinx 已提交
5914
          functId != TSDB_FUNC_TAGPRJ && functId != TSDB_FUNC_PRJ) {
5915
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
5916 5917
      }

5918
      if (functId == TSDB_FUNC_COUNT && pExpr->colInfo.colIndex == TSDB_TBNAME_COLUMN_INDEX) {
5919
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
5920 5921 5922
      }
    }

5923
    if (checkUpdateTagPrjFunctions(pQueryInfo, pCmd) != TSDB_CODE_SUCCESS) {
5924
      return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
5925 5926 5927 5928 5929 5930
    }

    /*
     * group by tag function must be not changed the function name, otherwise, the group operation may fail to
     * divide the subset of final result.
     */
5931
    if (doAddGroupbyColumnsOnDemand(pCmd, pQueryInfo) != TSDB_CODE_SUCCESS) {
5932
      return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
5933 5934
    }

H
hjxilinx 已提交
5935
    // projection query on super table does not compatible with "group by" syntax
5936
    if (tscNonOrderedProjectionQueryOnSTable(pQueryInfo, 0)) {
5937
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
5938
    }
H
hjxilinx 已提交
5939

H
hjxilinx 已提交
5940
    return TSDB_CODE_SUCCESS;
S
slguan 已提交
5941
  } else {
5942
    return checkUpdateTagPrjFunctions(pQueryInfo, pCmd);
S
slguan 已提交
5943 5944
  }
}
5945
int32_t doLocalQueryProcess(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql) {
H
hjxilinx 已提交
5946 5947 5948
  const char* msg1 = "only one expression allowed";
  const char* msg2 = "invalid expression in select clause";
  const char* msg3 = "invalid function";
H
hjxilinx 已提交
5949

H
hjxilinx 已提交
5950 5951
  tSQLExprList* pExprList = pQuerySql->pSelection;
  if (pExprList->nExpr != 1) {
5952
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hjxilinx 已提交
5953
  }
Y
yihaoDeng 已提交
5954
  bool server_status = false;
H
hjxilinx 已提交
5955 5956
  tSQLExpr* pExpr = pExprList->a[0].pNode;
  if (pExpr->operand.z == NULL) {
Y
yihaoDeng 已提交
5957 5958 5959 5960 5961 5962 5963
    //handle 'select 1'
    if (pExpr->token.n == 1 && 0 == strncasecmp(pExpr->token.z, "1", 1)) {
      server_status = true; 
    } else {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    } 
  } 
H
hjxilinx 已提交
5964
  // TODO redefine the function
Y
yihaoDeng 已提交
5965 5966 5967 5968 5969
   SDNodeDynConfOption functionsInfo[5] = {{"database()", 10},
                                            {"server_version()", 16},
                                            {"server_status()", 15},
                                            {"client_version()", 16},
                                            {"current_user()", 14}};
H
hjxilinx 已提交
5970

H
hjxilinx 已提交
5971
  int32_t index = -1;
Y
yihaoDeng 已提交
5972 5973 5974 5975 5976 5977 5978 5979 5980
  if (server_status == true) {
    index = 2;
  } else {
    for (int32_t i = 0; i < tListLen(functionsInfo); ++i) {
      if (strncasecmp(functionsInfo[i].name, pExpr->operand.z, functionsInfo[i].len) == 0 &&
          functionsInfo[i].len == pExpr->operand.n) {
        index = i;
        break;
      }
H
hjxilinx 已提交
5981 5982
    }
  }
H
hjxilinx 已提交
5983 5984 5985

  switch (index) {
    case 0:
H
Haojun Liao 已提交
5986
      pQueryInfo->command = TSDB_SQL_CURRENT_DB;break;
H
hjxilinx 已提交
5987
    case 1:
H
Haojun Liao 已提交
5988 5989 5990
      pQueryInfo->command = TSDB_SQL_SERV_VERSION;break;
      case 2:
      pQueryInfo->command = TSDB_SQL_SERV_STATUS;break;
H
hjxilinx 已提交
5991
    case 3:
H
Haojun Liao 已提交
5992
      pQueryInfo->command = TSDB_SQL_CLI_VERSION;break;
H
hjxilinx 已提交
5993
    case 4:
H
Haojun Liao 已提交
5994
      pQueryInfo->command = TSDB_SQL_CURRENT_USER;break;
5995
    default: { return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3); }
H
hjxilinx 已提交
5996
  }
5997 5998 5999
  
  SColumnIndex ind = {0};
  SSqlExpr* pExpr1 = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_TAG_DUMMY, &ind, TSDB_DATA_TYPE_INT,
H
Haojun Liao 已提交
6000
                                      tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize, getNewResColId(pQueryInfo), tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize, false);
6001 6002
  
  const char* name = (pExprList->a[0].aliasName != NULL)? pExprList->a[0].aliasName:functionsInfo[index].name;
B
Bomin Zhang 已提交
6003
  tstrncpy(pExpr1->aliasName, name, tListLen(pExpr1->aliasName));
H
Haojun Liao 已提交
6004 6005
  
  return TSDB_CODE_SUCCESS;
H
hjxilinx 已提交
6006
}
H
hjxilinx 已提交
6007 6008

// can only perform the parameters based on the macro definitation
S
TD-1732  
Shengliang Guan 已提交
6009
int32_t tscCheckCreateDbParams(SSqlCmd* pCmd, SCreateDbMsg* pCreate) {
H
hjxilinx 已提交
6010
  char msg[512] = {0};
H
hjxilinx 已提交
6011

H
hjxilinx 已提交
6012
  if (pCreate->walLevel != -1 && (pCreate->walLevel < TSDB_MIN_WAL_LEVEL || pCreate->walLevel > TSDB_MAX_WAL_LEVEL)) {
S
TD-1388  
Shengliang Guan 已提交
6013
    snprintf(msg, tListLen(msg), "invalid db option walLevel: %d, only 1-2 allowed", pCreate->walLevel);
6014
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6015
  }
H
hjxilinx 已提交
6016

H
hjxilinx 已提交
6017
  if (pCreate->replications != -1 &&
6018
      (pCreate->replications < TSDB_MIN_DB_REPLICA_OPTION || pCreate->replications > TSDB_MAX_DB_REPLICA_OPTION)) {
H
hjxilinx 已提交
6019
    snprintf(msg, tListLen(msg), "invalid db option replications: %d valid range: [%d, %d]", pCreate->replications,
6020
             TSDB_MIN_DB_REPLICA_OPTION, TSDB_MAX_DB_REPLICA_OPTION);
6021
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6022
  }
H
hjxilinx 已提交
6023

6024
  if (pCreate->quorum != -1 &&
S
TD-2677  
Shengliang Guan 已提交
6025
      (pCreate->quorum < TSDB_MIN_DB_QUORUM_OPTION || pCreate->quorum > TSDB_MAX_DB_QUORUM_OPTION)) {
6026
    snprintf(msg, tListLen(msg), "invalid db option quorum: %d valid range: [%d, %d]", pCreate->quorum,
S
TD-2677  
Shengliang Guan 已提交
6027
             TSDB_MIN_DB_QUORUM_OPTION, TSDB_MAX_DB_QUORUM_OPTION);
6028 6029 6030
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
  }

H
hjxilinx 已提交
6031
  int32_t val = htonl(pCreate->daysPerFile);
S
slguan 已提交
6032
  if (val != -1 && (val < TSDB_MIN_DAYS_PER_FILE || val > TSDB_MAX_DAYS_PER_FILE)) {
H
hjxilinx 已提交
6033
    snprintf(msg, tListLen(msg), "invalid db option daysPerFile: %d valid range: [%d, %d]", val,
S
slguan 已提交
6034
             TSDB_MIN_DAYS_PER_FILE, TSDB_MAX_DAYS_PER_FILE);
6035
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6036
  }
H
hjxilinx 已提交
6037

H
hjxilinx 已提交
6038 6039 6040 6041
  val = htonl(pCreate->cacheBlockSize);
  if (val != -1 && (val < TSDB_MIN_CACHE_BLOCK_SIZE || val > TSDB_MAX_CACHE_BLOCK_SIZE)) {
    snprintf(msg, tListLen(msg), "invalid db option cacheBlockSize: %d valid range: [%d, %d]", val,
             TSDB_MIN_CACHE_BLOCK_SIZE, TSDB_MAX_CACHE_BLOCK_SIZE);
6042
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6043
  }
H
hjxilinx 已提交
6044

H
hjxilinx 已提交
6045
  val = htonl(pCreate->maxTables);
S
slguan 已提交
6046
  if (val != -1 && (val < TSDB_MIN_TABLES || val > TSDB_MAX_TABLES)) {
H
hjxilinx 已提交
6047
    snprintf(msg, tListLen(msg), "invalid db option maxSessions: %d valid range: [%d, %d]", val,
S
slguan 已提交
6048
             TSDB_MIN_TABLES, TSDB_MAX_TABLES);
6049
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6050
  }
H
hjxilinx 已提交
6051 6052 6053 6054

  if (pCreate->precision != TSDB_TIME_PRECISION_MILLI && pCreate->precision != TSDB_TIME_PRECISION_MICRO) {
    snprintf(msg, tListLen(msg), "invalid db option timePrecision: %d valid value: [%d, %d]", pCreate->precision,
             TSDB_TIME_PRECISION_MILLI, TSDB_TIME_PRECISION_MICRO);
6055
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6056
  }
H
hjxilinx 已提交
6057

H
hjxilinx 已提交
6058
  val = htonl(pCreate->commitTime);
S
slguan 已提交
6059
  if (val != -1 && (val < TSDB_MIN_COMMIT_TIME || val > TSDB_MAX_COMMIT_TIME)) {
H
hjxilinx 已提交
6060
    snprintf(msg, tListLen(msg), "invalid db option commitTime: %d valid range: [%d, %d]", val,
S
slguan 已提交
6061
             TSDB_MIN_COMMIT_TIME, TSDB_MAX_COMMIT_TIME);
6062
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6063
  }
H
hjxilinx 已提交
6064

陶建辉(Jeff)'s avatar
陶建辉(Jeff) 已提交
6065 6066 6067 6068 6069 6070 6071
  val = htonl(pCreate->fsyncPeriod);
  if (val != -1 && (val < TSDB_MIN_FSYNC_PERIOD || val > TSDB_MAX_FSYNC_PERIOD)) {
    snprintf(msg, tListLen(msg), "invalid db option fsyncPeriod: %d valid range: [%d, %d]", val,
             TSDB_MIN_FSYNC_PERIOD, TSDB_MAX_FSYNC_PERIOD);
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
  }

H
hjxilinx 已提交
6072
  if (pCreate->compression != -1 &&
S
slguan 已提交
6073
      (pCreate->compression < TSDB_MIN_COMP_LEVEL || pCreate->compression > TSDB_MAX_COMP_LEVEL)) {
H
hjxilinx 已提交
6074
    snprintf(msg, tListLen(msg), "invalid db option compression: %d valid range: [%d, %d]", pCreate->compression,
S
slguan 已提交
6075
             TSDB_MIN_COMP_LEVEL, TSDB_MAX_COMP_LEVEL);
6076
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6077
  }
H
hjxilinx 已提交
6078

H
hjxilinx 已提交
6079 6080
  return TSDB_CODE_SUCCESS;
}
H
hjxilinx 已提交
6081 6082

// for debug purpose
H
hjxilinx 已提交
6083 6084
void tscPrintSelectClause(SSqlObj* pSql, int32_t subClauseIndex) {
  SQueryInfo* pQueryInfo = tscGetQueryInfoDetail(&pSql->cmd, subClauseIndex);
6085

S
TD-1057  
Shengliang Guan 已提交
6086
  int32_t size = (int32_t)tscSqlExprNumOfExprs(pQueryInfo);
H
hjxilinx 已提交
6087
  if (size == 0) {
H
hjxilinx 已提交
6088 6089
    return;
  }
H
hjxilinx 已提交
6090

H
hjxilinx 已提交
6091
  int32_t totalBufSize = 1024;
H
hjxilinx 已提交
6092 6093

  char    str[1024] = {0};
H
hjxilinx 已提交
6094
  int32_t offset = 0;
H
hjxilinx 已提交
6095

H
hjxilinx 已提交
6096 6097
  offset += sprintf(str, "num:%d [", size);
  for (int32_t i = 0; i < size; ++i) {
6098
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
H
hjxilinx 已提交
6099

L
lihui 已提交
6100
    char    tmpBuf[1024] = {0};
H
hjxilinx 已提交
6101 6102 6103
    int32_t tmpLen = 0;
    tmpLen =
        sprintf(tmpBuf, "%s(uid:%" PRId64 ", %d)", aAggs[pExpr->functionId].aName, pExpr->uid, pExpr->colInfo.colId);
L
lihui 已提交
6104 6105 6106
    if (tmpLen + offset > totalBufSize) break;

    offset += sprintf(str + offset, "%s", tmpBuf);
H
hjxilinx 已提交
6107

H
hjxilinx 已提交
6108
    if (i < size - 1) {
H
hjxilinx 已提交
6109 6110 6111
      str[offset++] = ',';
    }
  }
H
hjxilinx 已提交
6112

H
hjxilinx 已提交
6113
  str[offset] = ']';
6114
  tscDebug("%p select clause:%s", pSql, str);
H
hjxilinx 已提交
6115
}
6116

6117
int32_t doCheckForCreateTable(SSqlObj* pSql, int32_t subClauseIndex, SSqlInfo* pInfo) {
6118 6119
  const char* msg1 = "invalid table name";

6120 6121
  SSqlCmd*        pCmd = &pSql->cmd;
  SQueryInfo*     pQueryInfo = tscGetQueryInfoDetail(pCmd, subClauseIndex);
H
hjxilinx 已提交
6122
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
6123 6124 6125

  SCreateTableSQL* pCreateTable = pInfo->pCreateTableInfo;

H
Haojun Liao 已提交
6126 6127
  SArray* pFieldList = pCreateTable->colInfo.pColumns;
  SArray* pTagList = pCreateTable->colInfo.pTagColumns;
6128 6129 6130 6131

  assert(pFieldList != NULL);

  // if sql specifies db, use it, otherwise use default db
H
Haojun Liao 已提交
6132
  SStrToken* pzTableName = &(pCreateTable->name);
6133 6134

  if (tscValidateName(pzTableName) != TSDB_CODE_SUCCESS) {
6135
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
6136 6137
  }

H
Haojun Liao 已提交
6138 6139 6140
  int32_t code = tscSetTableFullName(pTableMetaInfo, pzTableName, pSql);
  if(code != TSDB_CODE_SUCCESS) {
    return code;
6141 6142 6143 6144
  }

  if (!validateTableColumnInfo(pFieldList, pCmd) ||
      (pTagList != NULL && !validateTagParams(pTagList, pFieldList, pCmd))) {
6145
    return TSDB_CODE_TSC_INVALID_SQL;
6146 6147 6148
  }

  int32_t col = 0;
H
Haojun Liao 已提交
6149 6150 6151
  size_t numOfFields = taosArrayGetSize(pFieldList);

  for (; col < numOfFields; ++col) {
H
Haojun Liao 已提交
6152
    TAOS_FIELD* p = taosArrayGet(pFieldList, col);
H
Haojun Liao 已提交
6153
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, p);
6154 6155
  }

H
Haojun Liao 已提交
6156
  pCmd->numOfCols = (int16_t)numOfFields;
6157

H
hjxilinx 已提交
6158
  if (pTagList != NULL) {  // create super table[optional]
H
Haojun Liao 已提交
6159 6160
    size_t numOfTags = taosArrayGetSize(pTagList);
    for (int32_t i = 0; i < numOfTags; ++i) {
H
Haojun Liao 已提交
6161 6162
      TAOS_FIELD* p = taosArrayGet(pTagList, i);
      tscFieldInfoAppend(&pQueryInfo->fieldsInfo, p);
6163 6164
    }

S
Shengliang Guan 已提交
6165
    pCmd->count =(int32_t) numOfTags;
6166 6167 6168 6169 6170 6171 6172 6173 6174 6175 6176 6177 6178 6179
  }

  return TSDB_CODE_SUCCESS;
}

int32_t doCheckForCreateFromStable(SSqlObj* pSql, SSqlInfo* pInfo) {
  const char* msg1 = "invalid table name";
  const char* msg3 = "tag value too long";
  const char* msg4 = "illegal value or data overflow";
  const char* msg5 = "tags number not matched";

  SSqlCmd* pCmd = &pSql->cmd;

  SCreateTableSQL* pCreateTable = pInfo->pCreateTableInfo;
6180 6181 6182
  SQueryInfo*      pQueryInfo = tscGetQueryInfoDetail(pCmd, 0);

  // two table: the first one is for current table, and the secondary is for the super table.
6183 6184 6185
  if (pQueryInfo->numOfTables < 2) {
    tscAddEmptyMetaInfo(pQueryInfo);
  }
6186 6187 6188 6189

  const int32_t TABLE_INDEX = 0;
  const int32_t STABLE_INDEX = 1;

6190
  STableMetaInfo* pStableMetaInfo = tscGetMetaInfo(pQueryInfo, STABLE_INDEX);
6191 6192

  // super table name, create table by using dst
H
Haojun Liao 已提交
6193
  int32_t numOfTables = (int32_t) taosArrayGetSize(pCreateTable->childTableInfo);
6194 6195
  for(int32_t j = 0; j < numOfTables; ++j) {
    SCreatedTableInfo* pCreateTableInfo = taosArrayGet(pCreateTable->childTableInfo, j);
6196

6197 6198 6199 6200
    SStrToken* pToken = &pCreateTableInfo->stableName;
    if (tscValidateName(pToken) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
    }
6201

6202 6203 6204 6205
    int32_t code = tscSetTableFullName(pStableMetaInfo, pToken, pSql);
    if (code != TSDB_CODE_SUCCESS) {
      return code;
    }
6206

6207 6208 6209
    // get table meta from mnode
    tstrncpy(pCreateTableInfo->tagdata.name, pStableMetaInfo->name, tListLen(pCreateTableInfo->tagdata.name));
    SArray* pList = pCreateTableInfo->pTagVals;
6210

6211 6212 6213 6214
    code = tscGetTableMeta(pSql, pStableMetaInfo);
    if (code != TSDB_CODE_SUCCESS) {
      return code;
    }
6215

6216 6217 6218 6219
    size_t size = taosArrayGetSize(pList);
    if (tscGetNumOfTags(pStableMetaInfo->pTableMeta) != size) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
    }
6220

6221 6222 6223
    // too long tag values will return invalid sql, not be truncated automatically
    SSchema  *pTagSchema = tscGetTableTagSchema(pStableMetaInfo->pTableMeta);
    STagData *pTag = &pCreateTableInfo->tagdata;
6224

6225 6226 6227 6228
    SKVRowBuilder kvRowBuilder = {0};
    if (tdInitKVRowBuilder(&kvRowBuilder) < 0) {
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
    }
B
Bomin Zhang 已提交
6229

6230 6231 6232 6233
    int32_t ret = TSDB_CODE_SUCCESS;
    for (int32_t i = 0; i < size; ++i) {
      SSchema*          pSchema = &pTagSchema[i];
      tVariantListItem* pItem = taosArrayGet(pList, i);
H
Haojun Liao 已提交
6234

6235 6236 6237 6238 6239 6240
      char tagVal[TSDB_MAX_TAGS_LEN];
      if (pSchema->type == TSDB_DATA_TYPE_BINARY || pSchema->type == TSDB_DATA_TYPE_NCHAR) {
        if (pItem->pVar.nLen > pSchema->bytes) {
          tdDestroyKVRowBuilder(&kvRowBuilder);
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
        }
H
hjxilinx 已提交
6241
      }
H
Haojun Liao 已提交
6242

6243
      ret = tVariantDump(&(pItem->pVar), tagVal, pSchema->type, true);
H
Haojun Liao 已提交
6244

6245 6246 6247 6248 6249 6250 6251 6252 6253 6254
      // check again after the convert since it may be converted from binary to nchar.
      if (pSchema->type == TSDB_DATA_TYPE_BINARY || pSchema->type == TSDB_DATA_TYPE_NCHAR) {
        int16_t len = varDataTLen(tagVal);
        if (len > pSchema->bytes) {
          tdDestroyKVRowBuilder(&kvRowBuilder);
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
        }
      }

      if (ret != TSDB_CODE_SUCCESS) {
H
Haojun Liao 已提交
6255
        tdDestroyKVRowBuilder(&kvRowBuilder);
6256
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
H
Haojun Liao 已提交
6257 6258
      }

6259
      tdAddColToKVRow(&kvRowBuilder, pSchema->colId, pSchema->type, tagVal);
6260 6261
    }

6262 6263 6264 6265 6266 6267 6268
    SKVRow row = tdGetKVRowFromBuilder(&kvRowBuilder);
    tdDestroyKVRowBuilder(&kvRowBuilder);
    if (row == NULL) {
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
    }
    tdSortKVRowByColIdx(row);
    pTag->dataLen = kvRowLen(row);
H
Haojun Liao 已提交
6269

6270 6271 6272
    if (pTag->data == NULL) {
      pTag->data = malloc(pTag->dataLen);
    }
H
Haojun Liao 已提交
6273

6274 6275
    kvRowCpy(pTag->data, row);
    free(row);
6276

6277 6278 6279 6280
    // table name
    if (tscValidateName(&(pCreateTableInfo->name)) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
    }
B
Bomin Zhang 已提交
6281

6282 6283 6284 6285 6286
    STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, TABLE_INDEX);
    ret = tscSetTableFullName(pTableMetaInfo, &pCreateTableInfo->name, pSql);
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
6287

6288
    pCreateTableInfo->fullname = strndup(pTableMetaInfo->name, TSDB_TABLE_FNAME_LEN);
6289 6290 6291 6292 6293 6294 6295
  }

  return TSDB_CODE_SUCCESS;
}

int32_t doCheckForStream(SSqlObj* pSql, SSqlInfo* pInfo) {
  const char* msg1 = "invalid table name";
6296
  const char* msg2 = "functions not allowed in CQ";
6297 6298 6299
  const char* msg3 = "fill only available for interval query";
  const char* msg4 = "fill option not supported in stream computing";
  const char* msg5 = "sql too long";  // todo ADD support
H
Haojun Liao 已提交
6300
  const char* msg6 = "from missing in subclause";
6301
  const char* msg7 = "time interval is required";
H
Haojun Liao 已提交
6302
  
6303
  SSqlCmd*    pCmd = &pSql->cmd;
6304
  SQueryInfo* pQueryInfo = tscGetQueryInfoDetail(pCmd, 0);
6305 6306
  assert(pQueryInfo->numOfTables == 1);

6307
  SCreateTableSQL* pCreateTable = pInfo->pCreateTableInfo;
H
hjxilinx 已提交
6308
  STableMetaInfo*  pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
6309 6310

  // if sql specifies db, use it, otherwise use default db
6311
  SStrToken* pName = &(pCreateTable->name);
6312 6313
  SQuerySQL* pQuerySql = pCreateTable->pSelect;

6314
  if (tscValidateName(pName) != TSDB_CODE_SUCCESS) {
6315
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
6316
  }
H
Haojun Liao 已提交
6317
  
H
Haojun Liao 已提交
6318 6319
  SArray* pSrcMeterName = pInfo->pCreateTableInfo->pSelect->from;
  if (pSrcMeterName == NULL || taosArrayGetSize(pSrcMeterName) == 0) {
H
Haojun Liao 已提交
6320 6321 6322
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
  }
  
H
Haojun Liao 已提交
6323 6324
  tVariantListItem* p1 = taosArrayGet(pSrcMeterName, 0);
  SStrToken srcToken = {.z = p1->pVar.pz, .n = p1->pVar.nLen, .type = TK_STRING};
6325
  if (tscValidateName(&srcToken) != TSDB_CODE_SUCCESS) {
6326
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
6327 6328
  }

H
Haojun Liao 已提交
6329 6330 6331
  int32_t code = tscSetTableFullName(pTableMetaInfo, &srcToken, pSql);
  if (code != TSDB_CODE_SUCCESS) {
    return code;
6332 6333
  }

H
Haojun Liao 已提交
6334
  code = tscGetTableMeta(pSql, pTableMetaInfo);
6335 6336 6337 6338
  if (code != TSDB_CODE_SUCCESS) {
    return code;
  }

weixin_48148422's avatar
weixin_48148422 已提交
6339
  bool isSTable = UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo);
D
fix bug  
dapan1121 已提交
6340
  if (parseSelectClause(&pSql->cmd, 0, pQuerySql->pSelection, isSTable, false, false) != TSDB_CODE_SUCCESS) {
6341
    return TSDB_CODE_TSC_INVALID_SQL;
6342 6343 6344
  }

  if (pQuerySql->pWhere != NULL) {  // query condition in stream computing
6345
    if (parseWhereClause(pQueryInfo, &pQuerySql->pWhere, pSql) != TSDB_CODE_SUCCESS) {
6346
      return TSDB_CODE_TSC_INVALID_SQL;
6347 6348 6349 6350
    }
  }

  // set interval value
6351
  if (parseIntervalClause(pSql, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
6352
    return TSDB_CODE_TSC_INVALID_SQL;
6353 6354 6355 6356 6357 6358 6359 6360 6361
  }

  if ((pQueryInfo->interval.interval > 0) &&
      (validateFunctionsInIntervalOrGroupbyQuery(pCmd, pQueryInfo) != TSDB_CODE_SUCCESS)) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
  }

  if (!tscIsProjectionQuery(pQueryInfo) && pQueryInfo->interval.interval == 0) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
6362 6363 6364
  }

  // set the created table[stream] name
6365
  code = tscSetTableFullName(pTableMetaInfo, pName, pSql);
H
Haojun Liao 已提交
6366 6367
  if (code != TSDB_CODE_SUCCESS) {
    return code;
6368 6369 6370
  }

  if (pQuerySql->selectToken.n > TSDB_MAX_SAVED_SQL_LEN) {
6371
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
6372 6373
  }

6374
  if (tsRewriteFieldNameIfNecessary(pCmd, pQueryInfo) != TSDB_CODE_SUCCESS) {
6375
    return TSDB_CODE_TSC_INVALID_SQL;
6376 6377
  }

H
hjxilinx 已提交
6378
  pCmd->numOfCols = pQueryInfo->fieldsInfo.numOfOutput;
6379

6380
  if (validateSqlFunctionInStreamSql(pCmd, pQueryInfo) != TSDB_CODE_SUCCESS) {
6381
    return TSDB_CODE_TSC_INVALID_SQL;
6382 6383 6384 6385 6386 6387 6388
  }

  /*
   * check if fill operation is available, the fill operation is parsed and executed during query execution,
   * not here.
   */
  if (pQuerySql->fillType != NULL) {
6389
    if (pQueryInfo->interval.interval == 0) {
6390
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
6391 6392
    }

H
Haojun Liao 已提交
6393
    tVariantListItem* pItem = taosArrayGet(pQuerySql->fillType, 0);
6394 6395 6396
    if (pItem->pVar.nType == TSDB_DATA_TYPE_BINARY) {
      if (!((strncmp(pItem->pVar.pz, "none", 4) == 0 && pItem->pVar.nLen == 4) ||
            (strncmp(pItem->pVar.pz, "null", 4) == 0 && pItem->pVar.nLen == 4))) {
6397
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
6398 6399 6400 6401 6402
      }
    }
  }

  // set the number of stream table columns
H
hjxilinx 已提交
6403
  pCmd->numOfCols = pQueryInfo->fieldsInfo.numOfOutput;
6404 6405 6406
  return TSDB_CODE_SUCCESS;
}

6407 6408 6409 6410 6411 6412 6413 6414 6415 6416 6417 6418 6419 6420 6421 6422 6423 6424 6425 6426 6427 6428 6429 6430 6431 6432 6433 6434 6435 6436 6437 6438 6439 6440 6441
static int32_t checkQueryRangeForFill(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
  const char* msg3 = "start(end) time of query range required or time range too large";

  if (pQueryInfo->interval.interval == 0) {
    return TSDB_CODE_SUCCESS;
  }

    bool initialWindows = TSWINDOW_IS_EQUAL(pQueryInfo->window, TSWINDOW_INITIALIZER);
    if (initialWindows) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }

    int64_t timeRange = ABS(pQueryInfo->window.skey - pQueryInfo->window.ekey);

    int64_t intervalRange = 0;
    if (pQueryInfo->interval.intervalUnit == 'n' || pQueryInfo->interval.intervalUnit == 'y') {
      int64_t f = 1;
      if (pQueryInfo->interval.intervalUnit == 'n') {
        f = 30L * MILLISECOND_PER_DAY;
      } else if (pQueryInfo->interval.intervalUnit == 'y') {
        f = 365L * MILLISECOND_PER_DAY;
      }

      intervalRange = pQueryInfo->interval.interval * f;
    } else {
      intervalRange = pQueryInfo->interval.interval;
    }
    // number of result is not greater than 10,000,000
    if ((timeRange == 0) || (timeRange / intervalRange) >= MAX_INTERVAL_TIME_WINDOW) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }

    return TSDB_CODE_SUCCESS;
}

6442
int32_t doCheckForQuery(SSqlObj* pSql, SQuerySQL* pQuerySql, int32_t index) {
H
Haojun Liao 已提交
6443
  assert(pQuerySql != NULL && (pQuerySql->from == NULL || taosArrayGetSize(pQuerySql->from) > 0));
6444

H
Haojun Liao 已提交
6445
  const char* msg0  = "invalid table name";
6446 6447 6448 6449 6450 6451 6452
  const char* msg1 = "point interpolation query needs timestamp";
  const char* msg2 = "fill only available for interval query";
  const char* msg3 = "start(end) time of query range required or time range too large";
  const char* msg4 = "illegal number of tables in from clause";
  const char* msg5 = "too many columns in selection clause";
  const char* msg6 = "too many tables in from clause";
  const char* msg7 = "invalid table alias name";
6453 6454

  int32_t code = TSDB_CODE_SUCCESS;
6455

6456
  SSqlCmd* pCmd = &pSql->cmd;
6457

6458
  SQueryInfo*     pQueryInfo = tscGetQueryInfoDetail(pCmd, index);
H
hjxilinx 已提交
6459
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hjxilinx 已提交
6460
  if (pTableMetaInfo == NULL) {
H
hjxilinx 已提交
6461
    pTableMetaInfo = tscAddEmptyMetaInfo(pQueryInfo);
6462
  }
H
hjxilinx 已提交
6463

H
Haojun Liao 已提交
6464 6465
  assert(pCmd->clauseIndex == index);

6466 6467
  // too many result columns not support order by in query
  if (pQuerySql->pSelection->nExpr > TSDB_MAX_COLUMNS) {
6468
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
6469 6470 6471 6472 6473 6474 6475 6476 6477 6478 6479 6480
  }

  /*
   * handle the sql expression without from subclause
   * select current_database();
   * select server_version();
   * select client_version();
   * select server_state();
   */
  if (pQuerySql->from == NULL) {
    assert(pQuerySql->fillType == NULL && pQuerySql->pGroupby == NULL && pQuerySql->pWhere == NULL &&
           pQuerySql->pSortOrder == NULL);
6481
    return doLocalQueryProcess(pCmd, pQueryInfo, pQuerySql);
6482 6483
  }

H
Haojun Liao 已提交
6484 6485
  size_t fromSize = taosArrayGetSize(pQuerySql->from);
  if (fromSize > TSDB_MAX_JOIN_TABLE_NUM * 2) {
6486
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
6487 6488
  }

6489
  pQueryInfo->command = TSDB_SQL_SELECT;
H
hjxilinx 已提交
6490

H
Haojun Liao 已提交
6491
  if (fromSize > 4) {
6492
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
Haojun Liao 已提交
6493 6494
  }

6495
  // set all query tables, which are maybe more than one.
H
Haojun Liao 已提交
6496 6497 6498
  for (int32_t i = 0; i < fromSize; ) {
    tVariantListItem* item = taosArrayGet(pQuerySql->from, i);
    tVariant* pTableItem = &item->pVar;
6499 6500

    if (pTableItem->nType != TSDB_DATA_TYPE_BINARY) {
6501
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
6502 6503 6504 6505
    }

    pTableItem->nLen = strdequote(pTableItem->pz);

H
Haojun Liao 已提交
6506
    SStrToken tableName = {.z = pTableItem->pz, .n = pTableItem->nLen, .type = TK_STRING};
6507
    if (tscValidateName(&tableName) != TSDB_CODE_SUCCESS) {
6508
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
6509 6510
    }

H
Haojun Liao 已提交
6511
    if (pQueryInfo->numOfTables <= i/2) {  // more than one table
H
hjxilinx 已提交
6512
      tscAddEmptyMetaInfo(pQueryInfo);
6513 6514
    }

H
Haojun Liao 已提交
6515
    STableMetaInfo* pTableMetaInfo1 = tscGetMetaInfo(pQueryInfo, i/2);
6516

H
Haojun Liao 已提交
6517
    SStrToken t = {.type = TSDB_DATA_TYPE_BINARY, .n = pTableItem->nLen, .z = pTableItem->pz};
H
Haojun Liao 已提交
6518 6519 6520
    code = tscSetTableFullName(pTableMetaInfo1, &t, pSql);
    if (code != TSDB_CODE_SUCCESS) {
      return code;
6521 6522
    }

6523
    tVariantListItem* p1 = taosArrayGet(pQuerySql->from, i + 1);
H
Haojun Liao 已提交
6524
    if (p1->pVar.nType != TSDB_DATA_TYPE_BINARY) {
6525
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
H
Haojun Liao 已提交
6526 6527
    }

H
Haojun Liao 已提交
6528
    SStrToken aliasName = {.z = p1->pVar.pz, .n = p1->pVar.nLen, .type = TK_STRING};
H
Haojun Liao 已提交
6529
    if (tscValidateName(&aliasName) != TSDB_CODE_SUCCESS) {
6530
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
H
Haojun Liao 已提交
6531 6532
    }

6533
    // has no table alias name
H
Haojun Liao 已提交
6534
    if (memcmp(pTableItem->pz, p1->pVar.pz, p1->pVar.nLen) == 0) {
6535 6536
      extractTableName(pTableMetaInfo1->name, pTableMetaInfo1->aliasName);
    } else {
H
Haojun Liao 已提交
6537
      tstrncpy(pTableMetaInfo1->aliasName, p1->pVar.pz, sizeof(pTableMetaInfo1->aliasName));
6538
    }
H
Haojun Liao 已提交
6539 6540

    code = tscGetTableMeta(pSql, pTableMetaInfo1);
6541 6542 6543
    if (code != TSDB_CODE_SUCCESS) {
      return code;
    }
H
Haojun Liao 已提交
6544 6545

    i += 2;
6546 6547
  }

H
Haojun Liao 已提交
6548
  assert(pQueryInfo->numOfTables == taosArrayGetSize(pQuerySql->from) / 2);
H
hjxilinx 已提交
6549
  bool isSTable = false;
H
hjxilinx 已提交
6550
  
weixin_48148422's avatar
weixin_48148422 已提交
6551
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
hjxilinx 已提交
6552 6553 6554 6555 6556 6557 6558
    isSTable = true;
    code = tscGetSTableVgroupInfo(pSql, index);
    if (code != TSDB_CODE_SUCCESS) {
      return code;
    }
    
    TSDB_QUERY_SET_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_STABLE_QUERY);
6559 6560
  } else {
    TSDB_QUERY_SET_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_TABLE_QUERY);
H
hjxilinx 已提交
6561
  }
6562

6563
  // parse the group by clause in the first place
6564
  if (parseGroupbyClause(pQueryInfo, pQuerySql->pGroupby, pCmd) != TSDB_CODE_SUCCESS) {
6565
    return TSDB_CODE_TSC_INVALID_SQL;
6566 6567
  }

6568 6569
  // set where info
  STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);
Y
TD-1230  
yihaoDeng 已提交
6570

6571 6572 6573 6574 6575 6576 6577 6578 6579 6580 6581
  if (pQuerySql->pWhere != NULL) {
    if (parseWhereClause(pQueryInfo, &pQuerySql->pWhere, pSql) != TSDB_CODE_SUCCESS) {
      return TSDB_CODE_TSC_INVALID_SQL;
    }

    pQuerySql->pWhere = NULL;
    if (tinfo.precision == TSDB_TIME_PRECISION_MILLI) {
      pQueryInfo->window.skey = pQueryInfo->window.skey / 1000;
      pQueryInfo->window.ekey = pQueryInfo->window.ekey / 1000;
    }
  } else {  // set the time rang
H
Haojun Liao 已提交
6582
    if (taosArrayGetSize(pQuerySql->from) > 2) { // it is a join query, no wher clause is not allowed.
6583 6584
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "condition missing for join query ");
    }
Y
TD-1230  
yihaoDeng 已提交
6585
  }
6586

H
Haojun Liao 已提交
6587
  int32_t joinQuery = (pQuerySql->from != NULL && taosArrayGetSize(pQuerySql->from) > 2);
6588

D
fix bug  
dapan1121 已提交
6589 6590 6591
  int32_t intervalQuery = !(pQuerySql->interval.type == 0 || pQuerySql->interval.n == 0);

  if (parseSelectClause(pCmd, index, pQuerySql->pSelection, isSTable, joinQuery, intervalQuery) != TSDB_CODE_SUCCESS) {
6592
    return TSDB_CODE_TSC_INVALID_SQL;
6593 6594
  }

H
Haojun Liao 已提交
6595 6596 6597 6598 6599
  // set order by info
  if (parseOrderbyClause(pCmd, pQueryInfo, pQuerySql, tscGetTableSchema(pTableMetaInfo->pTableMeta)) != TSDB_CODE_SUCCESS) {
    return TSDB_CODE_TSC_INVALID_SQL;
  }

6600
  // set interval value
6601
  if (parseIntervalClause(pSql, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
6602
    return TSDB_CODE_TSC_INVALID_SQL;
6603
  } else {
6604
    if ((pQueryInfo->interval.interval > 0) &&
6605
        (validateFunctionsInIntervalOrGroupbyQuery(pCmd, pQueryInfo) != TSDB_CODE_SUCCESS)) {
6606
      return TSDB_CODE_TSC_INVALID_SQL;
6607 6608 6609 6610
    }
  }

  // no result due to invalid query time range
H
hjxilinx 已提交
6611
  if (pQueryInfo->window.skey > pQueryInfo->window.ekey) {
6612
    pQueryInfo->command = TSDB_SQL_RETRIEVE_EMPTY_RESULT;
6613 6614 6615
    return TSDB_CODE_SUCCESS;
  }

6616
  if (!hasTimestampForPointInterpQuery(pQueryInfo)) {
6617
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
6618 6619 6620
  }

  // in case of join query, time range is required.
6621
  if (QUERY_IS_JOIN_QUERY(pQueryInfo->type)) {
S
TD-1057  
Shengliang Guan 已提交
6622
    int64_t timeRange = ABS(pQueryInfo->window.skey - pQueryInfo->window.ekey);
6623

H
hjxilinx 已提交
6624
    if (timeRange == 0 && pQueryInfo->window.skey == 0) {
6625
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
6626 6627 6628
    }
  }

6629
  if ((code = parseLimitClause(pCmd, pQueryInfo, index, pQuerySql, pSql)) != TSDB_CODE_SUCCESS) {
6630 6631 6632
    return code;
  }

6633
  if ((code = doFunctionsCompatibleCheck(pCmd, pQueryInfo)) != TSDB_CODE_SUCCESS) {
6634 6635 6636
    return code;
  }

H
Haojun Liao 已提交
6637
  tscFieldInfoUpdateOffset(pQueryInfo);
6638

6639
  if (pQuerySql->fillType != NULL) {
6640
    if (pQueryInfo->interval.interval == 0 && (!tscIsPointInterpQuery(pQueryInfo))) {
6641
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
6642
    }
H
hjxilinx 已提交
6643

6644 6645 6646 6647 6648 6649 6650 6651
    /*
     * fill options are set at the end position, when all columns are set properly
     * the columns may be increased due to group by operation
     */
    if ((code = checkQueryRangeForFill(pCmd, pQueryInfo)) != TSDB_CODE_SUCCESS) {
      return code;
    }

6652 6653
    if ((code = parseFillClause(pCmd, pQueryInfo, pQuerySql)) != TSDB_CODE_SUCCESS) {
      return code;
6654 6655
    }
  }
6656 6657 6658

  return TSDB_CODE_SUCCESS;  // Does not build query message here
}
H
hjxilinx 已提交
6659

H
Haojun Liao 已提交
6660
int32_t exprTreeFromSqlExpr(SSqlCmd* pCmd, tExprNode **pExpr, const tSQLExpr* pSqlExpr, SQueryInfo* pQueryInfo, SArray* pCols, int64_t *uid) {
H
hjxilinx 已提交
6661 6662
  tExprNode* pLeft = NULL;
  tExprNode* pRight= NULL;
H
hjxilinx 已提交
6663
  
6664
  if (pSqlExpr->pLeft != NULL) {
H
Haojun Liao 已提交
6665
    int32_t ret = exprTreeFromSqlExpr(pCmd, &pLeft, pSqlExpr->pLeft, pQueryInfo, pCols, uid);
H
hjxilinx 已提交
6666 6667 6668 6669 6670
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
  }
  
6671
  if (pSqlExpr->pRight != NULL) {
H
Haojun Liao 已提交
6672
    int32_t ret = exprTreeFromSqlExpr(pCmd, &pRight, pSqlExpr->pRight, pQueryInfo, pCols, uid);
H
hjxilinx 已提交
6673 6674 6675 6676
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
  }
H
Haojun Liao 已提交
6677 6678 6679 6680 6681

  if (pSqlExpr->pLeft == NULL && pSqlExpr->pRight == NULL && pSqlExpr->nSQLOptr == 0) {
    *pExpr = calloc(1, sizeof(tExprNode));
    return TSDB_CODE_SUCCESS;
  }
H
hjxilinx 已提交
6682
  
6683
  if (pSqlExpr->pLeft == NULL) {
H
hjxilinx 已提交
6684
    if (pSqlExpr->nSQLOptr >= TK_BOOL && pSqlExpr->nSQLOptr <= TK_STRING) {
6685
      *pExpr = calloc(1, sizeof(tExprNode));
H
hjxilinx 已提交
6686
      (*pExpr)->nodeType = TSQL_NODE_VALUE;
6687 6688 6689
      (*pExpr)->pVal = calloc(1, sizeof(tVariant));
      
      tVariantAssign((*pExpr)->pVal, &pSqlExpr->val);
6690
      return TSDB_CODE_SUCCESS;
6691
    } else if (pSqlExpr->nSQLOptr >= TK_COUNT && pSqlExpr->nSQLOptr <= TK_AVG_IRATE) {
6692
      // arithmetic expression on the results of aggregation functions
6693
      *pExpr = calloc(1, sizeof(tExprNode));
H
hjxilinx 已提交
6694
      (*pExpr)->nodeType = TSQL_NODE_COL;
6695 6696 6697
      (*pExpr)->pSchema = calloc(1, sizeof(SSchema));
      strncpy((*pExpr)->pSchema->name, pSqlExpr->operand.z, pSqlExpr->operand.n);
      
H
hjxilinx 已提交
6698
      // set the input column data byte and type.
H
Haojun Liao 已提交
6699
      size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
6700 6701
      
      for (int32_t i = 0; i < size; ++i) {
H
Haojun Liao 已提交
6702
        SSqlExpr* p1 = taosArrayGetP(pQueryInfo->exprList, i);
H
hjxilinx 已提交
6703 6704
        
        if (strcmp((*pExpr)->pSchema->name, p1->aliasName) == 0) {
H
Haojun Liao 已提交
6705
          (*pExpr)->pSchema->type  = (uint8_t)p1->resType;
H
hjxilinx 已提交
6706
          (*pExpr)->pSchema->bytes = p1->resBytes;
H
Haojun Liao 已提交
6707
          (*pExpr)->pSchema->colId = p1->resColId;
H
Haojun Liao 已提交
6708 6709 6710 6711 6712

          if (uid != NULL) {
            *uid = p1->uid;
          }

H
hjxilinx 已提交
6713 6714 6715
          break;
        }
      }
6716
    } else if (pSqlExpr->nSQLOptr == TK_ID) { // column name, normal column arithmetic expression
H
Haojun Liao 已提交
6717
      SColumnIndex index = COLUMN_INDEX_INITIALIZER;
6718
      int32_t ret = getColumnIndexByName(pCmd, &pSqlExpr->colInfo, pQueryInfo, &index);
6719 6720 6721
      if (ret != TSDB_CODE_SUCCESS) {
        return ret;
      }
H
Haojun Liao 已提交
6722 6723 6724 6725

      STableMeta* pTableMeta = tscGetMetaInfo(pQueryInfo, 0)->pTableMeta;
      int32_t numOfColumns = tscGetNumOfColumns(pTableMeta);

6726 6727 6728
      *pExpr = calloc(1, sizeof(tExprNode));
      (*pExpr)->nodeType = TSQL_NODE_COL;
      (*pExpr)->pSchema = calloc(1, sizeof(SSchema));
H
Haojun Liao 已提交
6729

6730 6731
      SSchema* pSchema = tscGetTableColumnSchema(pTableMeta, index.columnIndex);
      *(*pExpr)->pSchema = *pSchema;
6732 6733 6734
  
      if (pCols != NULL) {  // record the involved columns
        SColIndex colIndex = {0};
B
Bomin Zhang 已提交
6735
        tstrncpy(colIndex.name, pSchema->name, sizeof(colIndex.name));
6736 6737
        colIndex.colId = pSchema->colId;
        colIndex.colIndex = index.columnIndex;
H
Haojun Liao 已提交
6738 6739
        colIndex.flag = (index.columnIndex >= numOfColumns)? 1:0;

6740 6741
        taosArrayPush(pCols, &colIndex);
      }
6742
      
H
hjxilinx 已提交
6743
      return TSDB_CODE_SUCCESS;
6744
    } else {
H
Haojun Liao 已提交
6745
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "not support filter expression");
H
hjxilinx 已提交
6746 6747 6748
    }
    
  } else {
H
hjxilinx 已提交
6749
    *pExpr = (tExprNode *)calloc(1, sizeof(tExprNode));
6750 6751
    (*pExpr)->nodeType = TSQL_NODE_EXPR;
    
H
[td-32]  
hjxilinx 已提交
6752 6753 6754
    (*pExpr)->_node.hasPK = false;
    (*pExpr)->_node.pLeft = pLeft;
    (*pExpr)->_node.pRight = pRight;
6755
    
H
Haojun Liao 已提交
6756
    SStrToken t = {.type = pSqlExpr->nSQLOptr};
H
Haojun Liao 已提交
6757
    (*pExpr)->_node.optr = convertOptr(&t);
6758
    
H
[td-32]  
hjxilinx 已提交
6759
    assert((*pExpr)->_node.optr != 0);
6760 6761

    // check for dividing by 0
H
[td-32]  
hjxilinx 已提交
6762
    if ((*pExpr)->_node.optr == TSDB_BINARY_OP_DIVIDE) {
H
hjxilinx 已提交
6763
      if (pRight->nodeType == TSQL_NODE_VALUE) {
6764
        if (pRight->pVal->nType == TSDB_DATA_TYPE_INT && pRight->pVal->i64 == 0) {
6765
          return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
6766
        } else if (pRight->pVal->nType == TSDB_DATA_TYPE_FLOAT && pRight->pVal->dKey == 0) {
6767
          return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
6768 6769 6770
        }
      }
    }
H
Hui Li 已提交
6771

6772
    // NOTE: binary|nchar data allows the >|< type filter
H
Hui Li 已提交
6773
    if ((*pExpr)->_node.optr != TSDB_RELATION_EQUAL && (*pExpr)->_node.optr != TSDB_RELATION_NOT_EQUAL) {
6774
      if (pRight != NULL && pRight->nodeType == TSQL_NODE_VALUE) {
B
Bomin Zhang 已提交
6775 6776 6777
        if (pRight->pVal->nType == TSDB_DATA_TYPE_BOOL) {
          return TSDB_CODE_TSC_INVALID_SQL;
        }
H
Hui Li 已提交
6778 6779
      }
    }
H
hjxilinx 已提交
6780 6781 6782
  }
  
  return TSDB_CODE_SUCCESS;
L
[#1197]  
lihui 已提交
6783
}
6784 6785 6786 6787 6788 6789 6790 6791 6792 6793 6794

bool hasNormalColumnFilter(SQueryInfo* pQueryInfo) {
  size_t numOfCols = taosArrayGetSize(pQueryInfo->colList);
  for (int32_t i = 0; i < numOfCols; ++i) {
    SColumn* pCol = taosArrayGetP(pQueryInfo->colList, i);
    if (pCol->numOfFilters > 0) {
      return true;
    }
  }

  return false;
6795
}