tscSQLParser.c 233.4 KB
Newer Older
H
hzcheng 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

16 17
#define _BSD_SOURCE
#define _XOPEN_SOURCE 500
S
slguan 已提交
18
#define _DEFAULT_SOURCE
19
#define _GNU_SOURCE
H
hzcheng 已提交
20

S
slguan 已提交
21
#include "os.h"
H
Haojun Liao 已提交
22
#include "qAst.h"
H
hzcheng 已提交
23
#include "taos.h"
S
slguan 已提交
24
#include "taosmsg.h"
H
Haojun Liao 已提交
25 26
#include "tcompare.h"
#include "tname.h"
S
slguan 已提交
27
#include "tscLog.h"
H
hzcheng 已提交
28 29 30
#include "tscUtil.h"
#include "tschemautil.h"
#include "tsclient.h"
H
Haojun Liao 已提交
31 32
#include "tstoken.h"
#include "tstrbuild.h"
33
#include "ttokendef.h"
H
hjxilinx 已提交
34

S
slguan 已提交
35 36
#define DEFAULT_PRIMARY_TIMESTAMP_COL_NAME "_c0"

Y
TD-1230  
yihaoDeng 已提交
37 38
#define TSWINDOW_IS_EQUAL(t1, t2) (((t1).skey == (t2).skey) && ((t1).ekey == (t2).ekey))

H
Haojun Liao 已提交
39 40
// -1 is tbname column index, so here use the -3 as the initial value
#define COLUMN_INDEX_INITIAL_VAL (-3)
S
slguan 已提交
41 42 43 44
#define COLUMN_INDEX_INITIALIZER \
  { COLUMN_INDEX_INITIAL_VAL, COLUMN_INDEX_INITIAL_VAL }
#define COLUMN_INDEX_VALIDE(index) (((index).tableIndex >= 0) && ((index).columnIndex >= TSDB_TBNAME_COLUMN_INDEX))
#define TBNAME_LIST_SEP ","
H
hzcheng 已提交
45

H
Haojun Liao 已提交
46
typedef struct SColumnList {  // todo refactor
S
slguan 已提交
47 48
  int32_t      num;
  SColumnIndex ids[TSDB_MAX_COLUMNS];
H
hzcheng 已提交
49 50
} SColumnList;

Y
TD-1230  
yihaoDeng 已提交
51 52 53 54
typedef struct SConvertFunc {
  int32_t originFuncId;
  int32_t execFuncId;
} SConvertFunc;
H
Haojun Liao 已提交
55 56

static SSqlExpr* doAddProjectCol(SQueryInfo* pQueryInfo, int32_t colIndex, int32_t tableIndex);
H
hzcheng 已提交
57 58

static int32_t setShowInfo(SSqlObj* pSql, SSqlInfo* pInfo);
H
hjxilinx 已提交
59
static char*   getAccountId(SSqlObj* pSql);
H
hzcheng 已提交
60

H
Haojun Liao 已提交
61
static bool has(SArray* pFieldList, int32_t startIdx, const char* name);
H
Haojun Liao 已提交
62 63
static void getCurrentDBName(SSqlObj* pSql, SStrToken* pDBToken);
static bool hasSpecifyDB(SStrToken* pTableName);
H
Haojun Liao 已提交
64 65
static bool validateTableColumnInfo(SArray* pFieldList, SSqlCmd* pCmd);
static bool validateTagParams(SArray* pTagsList, SArray* pFieldList, SSqlCmd* pCmd);
H
hzcheng 已提交
66

H
Haojun Liao 已提交
67
static int32_t setObjFullName(char* fullName, const char* account, SStrToken* pDB, SStrToken* tableName, int32_t* len);
H
hzcheng 已提交
68

H
Haojun Liao 已提交
69
static void getColumnName(tSqlExprItem* pItem, char* resultFieldName, int32_t nameLength);
H
hzcheng 已提交
70

H
Haojun Liao 已提交
71
static int32_t addExprAndResultField(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, int32_t colIndex, tSqlExprItem* pItem, bool finalResult);
72
static int32_t insertResultField(SQueryInfo* pQueryInfo, int32_t outputIndex, SColumnList* pIdList, int16_t bytes,
H
hjxilinx 已提交
73
                                 int8_t type, char* fieldName, SSqlExpr* pSqlExpr);
H
Haojun Liao 已提交
74 75 76 77

static int32_t convertFunctionId(int32_t optr, int16_t* functionId);
static uint8_t convertOptr(SStrToken *pToken);

H
Haojun Liao 已提交
78
static int32_t parseSelectClause(SSqlCmd* pCmd, int32_t clauseIndex, tSQLExprList* pSelection, bool isSTable, bool joinQuery);
H
hzcheng 已提交
79

80
static bool validateIpAddress(const char* ip, size_t size);
81
static bool hasUnsupportFunctionsForSTableQuery(SSqlCmd* pCmd, SQueryInfo* pQueryInfo);
H
Haojun Liao 已提交
82
static bool functionCompatibleCheck(SQueryInfo* pQueryInfo, bool joinQuery);
H
hzcheng 已提交
83

H
Haojun Liao 已提交
84
static int32_t parseGroupbyClause(SQueryInfo* pQueryInfo, SArray* pList, SSqlCmd* pCmd);
H
hzcheng 已提交
85

86
static int32_t parseIntervalClause(SSqlObj* pSql, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql);
87
static int32_t parseOffsetClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql);
88
static int32_t parseSlidingClause(SSqlObj* pSql, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql);
H
hzcheng 已提交
89

H
Haojun Liao 已提交
90
static int32_t addProjectionExprAndResultField(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSqlExprItem* pItem);
H
hzcheng 已提交
91

92
static int32_t parseWhereClause(SQueryInfo* pQueryInfo, tSQLExpr** pExpr, SSqlObj* pSql);
93 94
static int32_t parseFillClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySQL);
static int32_t parseOrderbyClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql, SSchema* pSchema);
H
hzcheng 已提交
95

96
static int32_t tsRewriteFieldNameIfNecessary(SSqlCmd* pCmd, SQueryInfo* pQueryInfo);
H
hzcheng 已提交
97
static int32_t setAlterTableInfo(SSqlObj* pSql, struct SSqlInfo* pInfo);
98 99 100
static int32_t validateSqlFunctionInStreamSql(SSqlCmd* pCmd, SQueryInfo* pQueryInfo);
static int32_t validateFunctionsInIntervalOrGroupbyQuery(SSqlCmd* pCmd, SQueryInfo* pQueryInfo);
static int32_t validateArithmeticSQLExpr(SSqlCmd* pCmd, tSQLExpr* pExpr, SQueryInfo* pQueryInfo, SColumnList* pList, int32_t* type);
H
Hui Li 已提交
101
static int32_t validateEp(char* ep);
H
hzcheng 已提交
102
static int32_t validateDNodeConfig(tDCLSQL* pOptions);
S
slguan 已提交
103
static int32_t validateLocalConfig(tDCLSQL* pOptions);
H
hzcheng 已提交
104
static int32_t validateColumnName(char* name);
105
static int32_t setKillInfo(SSqlObj* pSql, struct SSqlInfo* pInfo, int32_t killType);
S
slguan 已提交
106

H
hjxilinx 已提交
107
static bool validateOneTags(SSqlCmd* pCmd, TAOS_FIELD* pTagField);
108
static bool hasTimestampForPointInterpQuery(SQueryInfo* pQueryInfo);
109
static bool hasNormalColumnFilter(SQueryInfo* pQueryInfo);
H
hjxilinx 已提交
110

111
static int32_t parseLimitClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, int32_t index, SQuerySQL* pQuerySql, SSqlObj* pSql);
H
hjxilinx 已提交
112
static int32_t parseCreateDBOptions(SSqlCmd* pCmd, SCreateDBInfo* pCreateDbSql);
H
Haojun Liao 已提交
113 114
static int32_t getColumnIndexByName(SSqlCmd* pCmd, const SStrToken* pToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex);
static int32_t getTableIndexByName(SStrToken* pToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex);
S
slguan 已提交
115 116
static int32_t optrToString(tSQLExpr* pExpr, char** exprString);

H
Haojun Liao 已提交
117
static int32_t getTableIndexImpl(SStrToken* pTableToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex);
118
static int32_t doFunctionsCompatibleCheck(SSqlCmd* pCmd, SQueryInfo* pQueryInfo);
119
static int32_t doLocalQueryProcess(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql);
S
TD-1732  
Shengliang Guan 已提交
120
static int32_t tscCheckCreateDbParams(SSqlCmd* pCmd, SCreateDbMsg* pCreate);
H
hjxilinx 已提交
121

S
slguan 已提交
122
static SColumnList getColumnList(int32_t num, int16_t tableIndex, int32_t columnIndex);
H
hjxilinx 已提交
123

124
static int32_t doCheckForCreateTable(SSqlObj* pSql, int32_t subClauseIndex, SSqlInfo* pInfo);
125 126 127
static int32_t doCheckForCreateFromStable(SSqlObj* pSql, SSqlInfo* pInfo);
static int32_t doCheckForStream(SSqlObj* pSql, SSqlInfo* pInfo);
static int32_t doCheckForQuery(SSqlObj* pSql, SQuerySQL* pQuerySql, int32_t index);
H
Haojun Liao 已提交
128
static int32_t exprTreeFromSqlExpr(SSqlCmd* pCmd, tExprNode **pExpr, const tSQLExpr* pSqlExpr, SQueryInfo* pQueryInfo, SArray* pCols, int64_t *uid);
H
hjxilinx 已提交
129

H
Haojun Liao 已提交
130 131 132 133
int16_t getNewResColId(SQueryInfo* pQueryInfo) {
  return pQueryInfo->resColumnId--;
}

H
Haojun Liao 已提交
134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172
static uint8_t convertOptr(SStrToken *pToken) {
  switch (pToken->type) {
    case TK_LT:
      return TSDB_RELATION_LESS;
    case TK_LE:
      return TSDB_RELATION_LESS_EQUAL;
    case TK_GT:
      return TSDB_RELATION_GREATER;
    case TK_GE:
      return TSDB_RELATION_GREATER_EQUAL;
    case TK_NE:
      return TSDB_RELATION_NOT_EQUAL;
    case TK_AND:
      return TSDB_RELATION_AND;
    case TK_OR:
      return TSDB_RELATION_OR;
    case TK_EQ:
      return TSDB_RELATION_EQUAL;
    case TK_PLUS:
      return TSDB_BINARY_OP_ADD;
    case TK_MINUS:
      return TSDB_BINARY_OP_SUBTRACT;
    case TK_STAR:
      return TSDB_BINARY_OP_MULTIPLY;
    case TK_SLASH:
    case TK_DIVIDE:
      return TSDB_BINARY_OP_DIVIDE;
    case TK_REM:
      return TSDB_BINARY_OP_REMAINDER;
    case TK_LIKE:
      return TSDB_RELATION_LIKE;
    case TK_ISNULL:
      return TSDB_RELATION_ISNULL;
    case TK_NOTNULL:
      return TSDB_RELATION_NOTNULL;
    default: { return 0; }
  }
}

H
hjxilinx 已提交
173 174 175 176
/*
 * Used during parsing query sql. Since the query sql usually small in length, error position
 * is not needed in the final error message.
 */
177 178
static int32_t invalidSqlErrMsg(char* dstBuffer, const char* errMsg) {
  return tscInvalidSQLErrMsg(dstBuffer, errMsg, NULL);
H
hjxilinx 已提交
179 180
}

181
static int setColumnFilterInfoForTimestamp(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tVariant* pVar) {
S
slguan 已提交
182 183 184 185 186
  int64_t     time = 0;
  const char* msg = "invalid timestamp";

  strdequote(pVar->pz);
  char*           seg = strnchr(pVar->pz, '-', pVar->nLen, false);
H
hjxilinx 已提交
187
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
S
slguan 已提交
188

H
hjxilinx 已提交
189
  STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);
H
hjxilinx 已提交
190
  
S
slguan 已提交
191
  if (seg != NULL) {
dengyihao's avatar
dengyihao 已提交
192
    if (taosParseTime(pVar->pz, &time, pVar->nLen, tinfo.precision, tsDaylight) != TSDB_CODE_SUCCESS) {
193
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
S
slguan 已提交
194 195
    }
  } else {
196
    if (tVariantDump(pVar, (char*)&time, TSDB_DATA_TYPE_BIGINT, true)) {
197
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
S
slguan 已提交
198 199 200 201 202 203 204 205 206
    }
  }

  tVariantDestroy(pVar);
  tVariantCreateFromBinary(pVar, (char*)&time, 0, TSDB_DATA_TYPE_BIGINT);

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
207
static int32_t handlePassword(SSqlCmd* pCmd, SStrToken* pPwd) {
208 209 210 211 212
  const char* msg1 = "password can not be empty";
  const char* msg2 = "name or password too long";
  const char* msg3 = "password needs single quote marks enclosed";

  if (pPwd->type != TK_STRING) {
213
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
214 215 216
  }

  strdequote(pPwd->z);
S
TD-1057  
Shengliang Guan 已提交
217
  pPwd->n = (uint32_t)strtrim(pPwd->z);  // trim space before and after passwords
218 219

  if (pPwd->n <= 0) {
220
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
221 222
  }

B
Bomin Zhang 已提交
223
  if (pPwd->n >= TSDB_PASSWORD_LEN) {
224
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
225 226 227 228 229
  }

  return TSDB_CODE_SUCCESS;
}

H
hzcheng 已提交
230 231
int32_t tscToSQLCmd(SSqlObj* pSql, struct SSqlInfo* pInfo) {
  if (pInfo == NULL || pSql == NULL || pSql->signature != pSql) {
232
    return TSDB_CODE_TSC_APP_ERROR;
H
hzcheng 已提交
233 234
  }

235 236
  SSqlCmd* pCmd = &pSql->cmd;
  SSqlRes* pRes = &pSql->res;
H
hzcheng 已提交
237

238
  int32_t code = TSDB_CODE_SUCCESS;
H
Haojun Liao 已提交
239 240
  if (!pInfo->valid || terrno == TSDB_CODE_TSC_SQL_SYNTAX_ERROR) {
    terrno = TSDB_CODE_SUCCESS;  // clear the error number
Y
TD-934  
yihaoDeng 已提交
241
    return tscSQLSyntaxErrMsg(tscGetErrorMsgPayload(pCmd), NULL, pInfo->pzErrMsg);
H
hzcheng 已提交
242 243
  }

244 245 246 247 248
  SQueryInfo* pQueryInfo = tscGetQueryInfoDetailSafely(pCmd, pCmd->clauseIndex);
  if (pQueryInfo == NULL) {
    pRes->code = terrno;
    return pRes->code;
  }
H
hjxilinx 已提交
249

250 251 252 253
  STableMetaInfo* pTableMetaInfo = (pQueryInfo->numOfTables == 0)? tscAddEmptyMetaInfo(pQueryInfo) : pQueryInfo->pTableMetaInfo[0];
  if (pTableMetaInfo == NULL) {
    pRes->code = TSDB_CODE_TSC_OUT_OF_MEMORY;
    return pRes->code;
H
hjxilinx 已提交
254
  }
255

256 257 258 259 260 261 262 263
  pCmd->command = pInfo->type;

  switch (pInfo->type) {
    case TSDB_SQL_DROP_TABLE:
    case TSDB_SQL_DROP_USER:
    case TSDB_SQL_DROP_ACCT:
    case TSDB_SQL_DROP_DNODE:
    case TSDB_SQL_DROP_DB: {
264
      const char* msg2 = "invalid name";
265
      const char* msg3 = "param name too long";
H
hzcheng 已提交
266

H
Haojun Liao 已提交
267
      SStrToken* pzName = &pInfo->pDCLInfo->a[0];
268
      if ((pInfo->type != TSDB_SQL_DROP_DNODE) && (tscValidateName(pzName) != TSDB_CODE_SUCCESS)) {
269
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
270 271
      }

272 273
      if (pInfo->type == TSDB_SQL_DROP_DB) {
        assert(pInfo->pDCLInfo->nTokens == 1);
H
hzcheng 已提交
274

H
hjxilinx 已提交
275
        code = setObjFullName(pTableMetaInfo->name, getAccountId(pSql), pzName, NULL, NULL);
H
hzcheng 已提交
276
        if (code != TSDB_CODE_SUCCESS) {
277
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
278 279
        }

280 281
      } else if (pInfo->type == TSDB_SQL_DROP_TABLE) {
        assert(pInfo->pDCLInfo->nTokens == 1);
H
hzcheng 已提交
282

Y
TD-1039  
yihaoDeng 已提交
283 284 285
        code = tscSetTableFullName(pTableMetaInfo, pzName, pSql);
        if(code != TSDB_CODE_SUCCESS) {
          return code; 
H
hzcheng 已提交
286
        }
287
      } else if (pInfo->type == TSDB_SQL_DROP_DNODE) {
S
slguan 已提交
288
        pzName->n = strdequote(pzName->z);
H
hjxilinx 已提交
289
        strncpy(pTableMetaInfo->name, pzName->z, pzName->n);
290
      } else {  // drop user
B
Bomin Zhang 已提交
291
        if (pzName->n >= TSDB_USER_LEN) {
292
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
293 294
        }

H
hjxilinx 已提交
295
        strncpy(pTableMetaInfo->name, pzName->z, pzName->n);
H
hzcheng 已提交
296 297
      }

298 299
      break;
    }
H
hzcheng 已提交
300

301 302
    case TSDB_SQL_USE_DB: {
      const char* msg = "invalid db name";
H
Haojun Liao 已提交
303
      SStrToken*  pToken = &pInfo->pDCLInfo->a[0];
S
slguan 已提交
304 305

      if (tscValidateName(pToken) != TSDB_CODE_SUCCESS) {
306
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
307 308
      }

H
hjxilinx 已提交
309
      int32_t ret = setObjFullName(pTableMetaInfo->name, getAccountId(pSql), pToken, NULL, NULL);
H
hzcheng 已提交
310
      if (ret != TSDB_CODE_SUCCESS) {
311
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
312 313 314 315 316
      }

      break;
    }

317 318
    case TSDB_SQL_RESET_CACHE: {
      return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
319 320
    }

321 322
    case TSDB_SQL_SHOW: {
      if (setShowInfo(pSql, pInfo) != TSDB_CODE_SUCCESS) {
323
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
324 325
      }

326 327 328 329 330 331 332 333
      break;
    }

    case TSDB_SQL_ALTER_DB:
    case TSDB_SQL_CREATE_DB: {
      const char* msg1 = "invalid db name";
      const char* msg2 = "name too long";

334
      SCreateDBInfo* pCreateDB = &(pInfo->pDCLInfo->dbOpt);
H
hzcheng 已提交
335
      if (tscValidateName(&pCreateDB->dbname) != TSDB_CODE_SUCCESS) {
336
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
337 338
      }

H
hjxilinx 已提交
339
      int32_t ret = setObjFullName(pTableMetaInfo->name, getAccountId(pSql), &(pCreateDB->dbname), NULL, NULL);
H
hzcheng 已提交
340
      if (ret != TSDB_CODE_SUCCESS) {
341
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
342 343
      }

H
hjxilinx 已提交
344
      if (parseCreateDBOptions(pCmd, pCreateDB) != TSDB_CODE_SUCCESS) {
345
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
346 347 348 349 350
      }

      break;
    }

351 352
    case TSDB_SQL_CREATE_DNODE: {  // todo hostname
      const char* msg = "invalid host name (ip address)";
S
slguan 已提交
353

354
      if (pInfo->pDCLInfo->nTokens > 1) {
355
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
S
slguan 已提交
356 357
      }

H
Haojun Liao 已提交
358
      SStrToken* pIpAddr = &pInfo->pDCLInfo->a[0];
S
slguan 已提交
359
      pIpAddr->n = strdequote(pIpAddr->z);
S
slguan 已提交
360 361 362
      break;
    }

363 364 365 366 367
    case TSDB_SQL_CREATE_ACCT:
    case TSDB_SQL_ALTER_ACCT: {
      const char* msg1 = "invalid state option, available options[no, r, w, all]";
      const char* msg2 = "invalid user/account name";
      const char* msg3 = "name too long";
H
hzcheng 已提交
368

H
Haojun Liao 已提交
369 370
      SStrToken* pName = &pInfo->pDCLInfo->user.user;
      SStrToken* pPwd = &pInfo->pDCLInfo->user.passwd;
H
hzcheng 已提交
371

372
      if (handlePassword(pCmd, pPwd) != TSDB_CODE_SUCCESS) {
373
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
374 375
      }

B
Bomin Zhang 已提交
376
      if (pName->n >= TSDB_USER_LEN) {
377
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
378 379
      }

380
      if (tscValidateName(pName) != TSDB_CODE_SUCCESS) {
381
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
382 383 384
      }

      SCreateAcctSQL* pAcctOpt = &pInfo->pDCLInfo->acctOpt;
385
      if (pAcctOpt->stat.n > 0) {
H
hzcheng 已提交
386 387 388 389 390
        if (pAcctOpt->stat.z[0] == 'r' && pAcctOpt->stat.n == 1) {
        } else if (pAcctOpt->stat.z[0] == 'w' && pAcctOpt->stat.n == 1) {
        } else if (strncmp(pAcctOpt->stat.z, "all", 3) == 0 && pAcctOpt->stat.n == 3) {
        } else if (strncmp(pAcctOpt->stat.z, "no", 2) == 0 && pAcctOpt->stat.n == 2) {
        } else {
391
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
392 393
        }
      }
394

H
hzcheng 已提交
395 396 397
      break;
    }

398
    case TSDB_SQL_DESCRIBE_TABLE: {
H
Haojun Liao 已提交
399
      SStrToken*  pToken = &pInfo->pDCLInfo->a[0];
H
hjxilinx 已提交
400
      const char* msg1 = "invalid table name";
H
Haojun Liao 已提交
401
      const char* msg2 = "table name too long";
H
hzcheng 已提交
402

S
slguan 已提交
403
      if (tscValidateName(pToken) != TSDB_CODE_SUCCESS) {
404
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
405
      }
S
slguan 已提交
406

H
Haojun Liao 已提交
407
      if (!tscValidateTableNameLength(pToken->n)) {
408
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
409 410
      }

H
Haojun Liao 已提交
411
      // additional msg has been attached already
H
Haojun Liao 已提交
412 413 414
      code = tscSetTableFullName(pTableMetaInfo, pToken, pSql);
      if (code != TSDB_CODE_SUCCESS) {
        return code;
H
hzcheng 已提交
415 416
      }

H
hjxilinx 已提交
417
      return tscGetTableMeta(pSql, pTableMetaInfo);
H
hzcheng 已提交
418
    }
419 420 421 422
    case TSDB_SQL_SHOW_CREATE_TABLE: {
      SStrToken*  pToken = &pInfo->pDCLInfo->a[0];
      const char* msg1 = "invalid table name";
      const char* msg2 = "table name is too long";
H
hzcheng 已提交
423

424 425 426
      if (tscValidateName(pToken) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
      }
H
hzcheng 已提交
427

428 429 430 431
      if (!tscValidateTableNameLength(pToken->n)) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
      }

H
Haojun Liao 已提交
432 433 434
      code = tscSetTableFullName(pTableMetaInfo, pToken, pSql);
      if (code != TSDB_CODE_SUCCESS) {
        return code;
435
      }
H
Haojun Liao 已提交
436

437 438 439 440 441 442 443 444 445 446 447 448
      return tscGetTableMeta(pSql, pTableMetaInfo);
    }
    case TSDB_SQL_SHOW_CREATE_DATABASE: {
      const char* msg1 = "invalid database name";
      SStrToken*  pToken = &pInfo->pDCLInfo->a[0];

      if (tscValidateName(pToken) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
      }
      if (pToken->n > TSDB_DB_NAME_LEN) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
      }
H
Haojun Liao 已提交
449 450 451

      return tscSetTableFullName(pTableMetaInfo, pToken, pSql);
    }
452
    case TSDB_SQL_CFG_DNODE: {
S
Shengliang Guan 已提交
453
      const char* msg2 = "invalid configure options or values, such as resetlog / debugFlag 135 / balance 'vnode:2-dnode:2' / monitor 1 ";
H
Hui Li 已提交
454
      const char* msg3 = "invalid dnode ep";
H
hzcheng 已提交
455

456 457
      /* validate the ip address */
      tDCLSQL* pDCL = pInfo->pDCLInfo;
H
hzcheng 已提交
458

459 460
      /* validate the parameter names and options */
      if (validateDNodeConfig(pDCL) != TSDB_CODE_SUCCESS) {
461
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
462 463
      }

guanshengliang's avatar
guanshengliang 已提交
464
      char* pMsg = pCmd->payload;
H
hzcheng 已提交
465

S
TD-1732  
Shengliang Guan 已提交
466
      SCfgDnodeMsg* pCfg = (SCfgDnodeMsg*)pMsg;
guanshengliang's avatar
guanshengliang 已提交
467 468
      pDCL->a[0].n = strdequote(pDCL->a[0].z);
      
J
jtao1735 已提交
469
      strncpy(pCfg->ep, pDCL->a[0].z, pDCL->a[0].n);
H
hzcheng 已提交
470

H
Hui Li 已提交
471 472 473 474
      if (validateEp(pCfg->ep) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
      }

475
      strncpy(pCfg->config, pDCL->a[1].z, pDCL->a[1].n);
H
hzcheng 已提交
476

477 478 479 480
      if (pDCL->nTokens == 3) {
        pCfg->config[pDCL->a[1].n] = ' ';  // add sep
        strncpy(&pCfg->config[pDCL->a[1].n + 1], pDCL->a[2].z, pDCL->a[2].n);
      }
H
hzcheng 已提交
481

482 483
      break;
    }
H
hzcheng 已提交
484

485 486 487 488 489 490
    case TSDB_SQL_CREATE_USER:
    case TSDB_SQL_ALTER_USER: {
      const char* msg5 = "invalid user rights";
      const char* msg7 = "not support options";
      const char* msg2 = "invalid user/account name";
      const char* msg3 = "name too long";
H
hzcheng 已提交
491

492
      pCmd->command = pInfo->type;
H
hzcheng 已提交
493

494
      SUserInfo* pUser = &pInfo->pDCLInfo->user;
H
Haojun Liao 已提交
495 496
      SStrToken* pName = &pUser->user;
      SStrToken* pPwd = &pUser->passwd;
H
hzcheng 已提交
497

B
Bomin Zhang 已提交
498
      if (pName->n >= TSDB_USER_LEN) {
499
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
500
      }
H
hzcheng 已提交
501

502
      if (tscValidateName(pName) != TSDB_CODE_SUCCESS) {
503
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
504
      }
H
hzcheng 已提交
505

506 507
      if (pCmd->command == TSDB_SQL_CREATE_USER) {
        if (handlePassword(pCmd, pPwd) != TSDB_CODE_SUCCESS) {
508
          return TSDB_CODE_TSC_INVALID_SQL;
509 510 511 512
        }
      } else {
        if (pUser->type == TSDB_ALTER_USER_PASSWD) {
          if (handlePassword(pCmd, pPwd) != TSDB_CODE_SUCCESS) {
513
            return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
514
          }
515
        } else if (pUser->type == TSDB_ALTER_USER_PRIVILEGES) {
L
lihui 已提交
516 517
          assert(pPwd->type == TSDB_DATA_TYPE_NULL);

H
Haojun Liao 已提交
518
          SStrToken* pPrivilege = &pUser->privilege;
H
hzcheng 已提交
519

L
lihui 已提交
520
          if (strncasecmp(pPrivilege->z, "super", 5) == 0 && pPrivilege->n == 5) {
H
hzcheng 已提交
521
            pCmd->count = 1;
L
lihui 已提交
522
          } else if (strncasecmp(pPrivilege->z, "read", 4) == 0 && pPrivilege->n == 4) {
H
hzcheng 已提交
523
            pCmd->count = 2;
L
lihui 已提交
524
          } else if (strncasecmp(pPrivilege->z, "write", 5) == 0 && pPrivilege->n == 5) {
H
hzcheng 已提交
525 526
            pCmd->count = 3;
          } else {
527
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
528 529
          }
        } else {
530
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
H
hzcheng 已提交
531 532
        }
      }
533

H
hzcheng 已提交
534 535
      break;
    }
536 537

    case TSDB_SQL_CFG_LOCAL: {
S
slguan 已提交
538 539 540 541 542
      tDCLSQL*    pDCL = pInfo->pDCLInfo;
      const char* msg = "invalid configure options or values";

      // validate the parameter names and options
      if (validateLocalConfig(pDCL) != TSDB_CODE_SUCCESS) {
543
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
S
slguan 已提交
544 545 546 547 548 549 550
      }

      strncpy(pCmd->payload, pDCL->a[0].z, pDCL->a[0].n);
      if (pDCL->nTokens == 2) {
        pCmd->payload[pDCL->a[0].n] = ' ';  // add sep
        strncpy(&pCmd->payload[pDCL->a[0].n + 1], pDCL->a[1].z, pDCL->a[1].n);
      }
H
hzcheng 已提交
551 552 553 554

      break;
    }

555 556
    case TSDB_SQL_CREATE_TABLE: {
      SCreateTableSQL* pCreateTable = pInfo->pCreateTableInfo;
H
hzcheng 已提交
557

558
      if (pCreateTable->type == TSQL_CREATE_TABLE || pCreateTable->type == TSQL_CREATE_STABLE) {
559
        if ((code = doCheckForCreateTable(pSql, 0, pInfo)) != TSDB_CODE_SUCCESS) {
560
          return code;
H
hzcheng 已提交
561 562
        }

563
      } else if (pCreateTable->type == TSQL_CREATE_TABLE_FROM_STABLE) {
564
        assert(pCmd->numOfCols == 0);
565 566
        if ((code = doCheckForCreateFromStable(pSql, pInfo)) != TSDB_CODE_SUCCESS) {
          return code;
H
hzcheng 已提交
567 568
        }

569 570 571
      } else if (pCreateTable->type == TSQL_CREATE_STREAM) {
        if ((code = doCheckForStream(pSql, pInfo)) != TSDB_CODE_SUCCESS) {
          return code;
S
slguan 已提交
572
        }
H
hzcheng 已提交
573 574 575 576 577
      }

      break;
    }

578
    case TSDB_SQL_SELECT: {
H
hjxilinx 已提交
579
      const char* msg1 = "columns in select clause not identical";
H
hjxilinx 已提交
580

581
      for (int32_t i = pCmd->numOfClause; i < pInfo->subclauseInfo.numOfClause; ++i) {
582 583 584 585
        SQueryInfo* pqi = tscGetQueryInfoDetailSafely(pCmd, i);
        if (pqi == NULL) {
          pRes->code = terrno;
          return pRes->code;
586
        }
587 588 589
      }

      assert(pCmd->numOfClause == pInfo->subclauseInfo.numOfClause);
H
Haojun Liao 已提交
590
      for (int32_t i = pCmd->clauseIndex; i < pInfo->subclauseInfo.numOfClause; ++i) {
591
        SQuerySQL* pQuerySql = pInfo->subclauseInfo.pClause[i];
H
Haojun Liao 已提交
592
        tscTrace("%p start to parse %dth subclause, total:%d", pSql, i, pInfo->subclauseInfo.numOfClause);
593 594
        if ((code = doCheckForQuery(pSql, pQuerySql, i)) != TSDB_CODE_SUCCESS) {
          return code;
H
hzcheng 已提交
595
        }
H
hjxilinx 已提交
596

H
hjxilinx 已提交
597
        tscPrintSelectClause(pSql, i);
H
Haojun Liao 已提交
598
        pCmd->clauseIndex += 1;
H
hzcheng 已提交
599
      }
H
hjxilinx 已提交
600

H
Haojun Liao 已提交
601 602
      // restore the clause index
      pCmd->clauseIndex = 0;
H
hjxilinx 已提交
603
      // set the command/global limit parameters from the first subclause to the sqlcmd object
604 605
      SQueryInfo* pQueryInfo1 = tscGetQueryInfoDetail(pCmd, 0);
      pCmd->command = pQueryInfo1->command;
H
hjxilinx 已提交
606

607
      // if there is only one element, the limit of clause is the limit of global result.
H
hjxilinx 已提交
608
      for (int32_t i = 1; i < pCmd->numOfClause; ++i) {
609
        SQueryInfo* pQueryInfo2 = tscGetQueryInfoDetail(pCmd, i);
H
hjxilinx 已提交
610

611 612 613
        int32_t ret = tscFieldInfoCompare(&pQueryInfo1->fieldsInfo, &pQueryInfo2->fieldsInfo);
        if (ret != 0) {
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
614
        }
615
      }
616

617
      pCmd->parseFinished = 1;
618
      return TSDB_CODE_SUCCESS;  // do not build query message here
619
    }
H
hzcheng 已提交
620

621 622 623
    case TSDB_SQL_ALTER_TABLE: {
      if ((code = setAlterTableInfo(pSql, pInfo)) != TSDB_CODE_SUCCESS) {
        return code;
H
hzcheng 已提交
624 625 626 627 628
      }

      break;
    }

629 630 631
    case TSDB_SQL_KILL_QUERY:
    case TSDB_SQL_KILL_STREAM:
    case TSDB_SQL_KILL_CONNECTION: {
632
      if ((code = setKillInfo(pSql, pInfo, pInfo->type)) != TSDB_CODE_SUCCESS) {
H
hzcheng 已提交
633 634 635 636 637 638 639
        return code;
      }

      break;
    }

    default:
640
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "not support sql expression");
H
hzcheng 已提交
641 642
  }

dengyihao's avatar
dengyihao 已提交
643
  pSql->cmd.parseFinished = 1;
644
  return tscBuildMsg[pCmd->command](pSql, pInfo);
H
hzcheng 已提交
645 646
}

S
slguan 已提交
647 648 649 650
/*
 * if the top/bottom exists, only tags columns, tbname column, and primary timestamp column
 * are available.
 */
651
static bool isTopBottomQuery(SQueryInfo* pQueryInfo) {
H
hjxilinx 已提交
652 653 654
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  
  for (int32_t i = 0; i < size; ++i) {
655
    int32_t functionId = tscSqlExprGet(pQueryInfo, i)->functionId;
S
slguan 已提交
656 657 658 659

    if (functionId == TSDB_FUNC_TOP || functionId == TSDB_FUNC_BOTTOM) {
      return true;
    }
H
hzcheng 已提交
660 661
  }

S
slguan 已提交
662
  return false;
H
hzcheng 已提交
663 664
}

665
int32_t parseIntervalClause(SSqlObj* pSql, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql) {
S
slguan 已提交
666 667
  const char* msg1 = "invalid query expression";
  const char* msg2 = "interval cannot be less than 10 ms";
668
  const char* msg3 = "sliding cannot be used without interval";
669
  const char* msg4 = "top/bottom query does not support order by value in interval query";
670

671 672
  SSqlCmd* pCmd = &pSql->cmd;

H
hjxilinx 已提交
673
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hjxilinx 已提交
674
  STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);
H
hjxilinx 已提交
675
  
H
hjxilinx 已提交
676
  if (pQuerySql->interval.type == 0 || pQuerySql->interval.n == 0) {
677 678 679
    if (pQuerySql->sliding.n > 0) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }
H
hzcheng 已提交
680 681 682
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
683 684 685 686 687
  // orderby column not set yet, set it to be the primary timestamp column
  if (pQueryInfo->order.orderColId == INT32_MIN) {
    pQueryInfo->order.orderColId = PRIMARYKEY_TIMESTAMP_COL_INDEX;
  }

H
hzcheng 已提交
688
  // interval is not null
689
  SStrToken* t = &pQuerySql->interval;
690
  if (parseNatualDuration(t->z, t->n, &pQueryInfo->interval.interval, &pQueryInfo->interval.intervalUnit) != TSDB_CODE_SUCCESS) {
691
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
692 693
  }

694
  if (pQueryInfo->interval.intervalUnit != 'n' && pQueryInfo->interval.intervalUnit != 'y') {
B
Bomin Zhang 已提交
695 696
    // if the unit of time window value is millisecond, change the value from microsecond
    if (tinfo.precision == TSDB_TIME_PRECISION_MILLI) {
697
      pQueryInfo->interval.interval = pQueryInfo->interval.interval / 1000;
B
Bomin Zhang 已提交
698
    }
H
hzcheng 已提交
699

B
Bomin Zhang 已提交
700
    // interval cannot be less than 10 milliseconds
701
    if (pQueryInfo->interval.interval < tsMinIntervalTime) {
B
Bomin Zhang 已提交
702 703
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    }
H
hzcheng 已提交
704 705 706
  }

  // for top/bottom + interval query, we do not add additional timestamp column in the front
707
  if (isTopBottomQuery(pQueryInfo)) {
708 709 710 711
    if (parseOffsetClause(pCmd, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
      return TSDB_CODE_TSC_INVALID_SQL;
    }

712
    if (parseSlidingClause(pSql, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
713
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
714
    }
H
hjxilinx 已提交
715

716 717 718 719 720
    int32_t colId = pQueryInfo->order.orderColId;
    if (pQueryInfo->interval.interval > 0 && colId != PRIMARYKEY_TIMESTAMP_COL_INDEX) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
    }

H
hzcheng 已提交
721 722 723
    return TSDB_CODE_SUCCESS;
  }

H
hjxilinx 已提交
724 725 726
  /*
   * check invalid SQL:
   * select count(tbname)/count(tag1)/count(tag2) from super_table_name interval(1d);
H
hjxilinx 已提交
727
   */
H
hjxilinx 已提交
728 729
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t i = 0; i < size; ++i) {
730
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
731
    if (pExpr->functionId == TSDB_FUNC_COUNT && TSDB_COL_IS_TAG(pExpr->colInfo.flag)) {
732
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
733 734
    }
  }
H
hjxilinx 已提交
735

H
hjxilinx 已提交
736 737 738
  /*
   * check invalid SQL:
   * select tbname, tags_fields from super_table_name interval(1s)
H
hjxilinx 已提交
739
   */
740
  if (tscQueryTags(pQueryInfo) && pQueryInfo->interval.interval > 0) {
741
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hjxilinx 已提交
742
  }
S
slguan 已提交
743 744

  // need to add timestamp column in result set, if interval is existed
745
  uint64_t uid = tscSqlExprGet(pQueryInfo, 0)->uid;
S
slguan 已提交
746 747

  int32_t tableIndex = COLUMN_INDEX_INITIAL_VAL;
748
  for (int32_t i = 0; i < pQueryInfo->numOfTables; ++i) {
H
hjxilinx 已提交
749
    pTableMetaInfo = tscGetMetaInfo(pQueryInfo, i);
750
    if (pTableMetaInfo->pTableMeta->id.uid == uid) {
S
slguan 已提交
751 752 753 754 755 756
      tableIndex = i;
      break;
    }
  }

  if (tableIndex == COLUMN_INDEX_INITIAL_VAL) {
757
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
758 759
  }

H
Haojun Liao 已提交
760 761
  SSchema s = {.bytes = TSDB_KEYSIZE, .type = TSDB_DATA_TYPE_TIMESTAMP, .colId = PRIMARYKEY_TIMESTAMP_COL_INDEX};
  tstrncpy(s.name, aAggs[TSDB_FUNC_TS].aName, sizeof(s.name));
762

H
Haojun Liao 已提交
763 764
  SColumnIndex index = {tableIndex, PRIMARYKEY_TIMESTAMP_COL_INDEX};
  tscAddSpecialColumnForSelect(pQueryInfo, 0, TSDB_FUNC_TS, &index, &s, TSDB_COL_NORMAL);
H
hjxilinx 已提交
765

766 767 768 769
  if (parseOffsetClause(pCmd, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
    return TSDB_CODE_TSC_INVALID_SQL;
  }

770
  if (parseSlidingClause(pSql, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
771
    return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
772
  }
H
hjxilinx 已提交
773

H
hjxilinx 已提交
774
  return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
775 776
}

777
int32_t parseOffsetClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql) {
778 779 780 781
  const char* msg1 = "interval offset cannot be negative";
  const char* msg2 = "interval offset should be shorter than interval";
  const char* msg3 = "cannot use 'year' as offset when interval is 'month'";

782 783 784
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
  STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);

785 786 787 788
  SStrToken* t = &pQuerySql->offset;
  if (t->n == 0) {
    pQueryInfo->interval.offsetUnit = pQueryInfo->interval.intervalUnit;
    pQueryInfo->interval.offset = 0;
789 790 791
    return TSDB_CODE_SUCCESS;
  }

792
  if (parseNatualDuration(t->z, t->n, &pQueryInfo->interval.offset, &pQueryInfo->interval.offsetUnit) != TSDB_CODE_SUCCESS) {
793
    return TSDB_CODE_TSC_INVALID_SQL;
794 795
  }

796
  if (pQueryInfo->interval.offset < 0) {
797 798 799
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
  }

800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822
  if (pQueryInfo->interval.offsetUnit != 'n' && pQueryInfo->interval.offsetUnit != 'y') {
    // if the unit of time window value is millisecond, change the value from microsecond
    if (tinfo.precision == TSDB_TIME_PRECISION_MILLI) {
      pQueryInfo->interval.offset = pQueryInfo->interval.offset / 1000;
    }
    if (pQueryInfo->interval.intervalUnit != 'n' && pQueryInfo->interval.intervalUnit != 'y') {
      if (pQueryInfo->interval.offset >= pQueryInfo->interval.interval) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
      }
    }
  } else if (pQueryInfo->interval.offsetUnit == pQueryInfo->interval.intervalUnit) {
    if (pQueryInfo->interval.offset >= pQueryInfo->interval.interval) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    }
  } else if (pQueryInfo->interval.intervalUnit == 'n' && pQueryInfo->interval.offsetUnit == 'y') {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
  } else if (pQueryInfo->interval.intervalUnit == 'y' && pQueryInfo->interval.offsetUnit == 'n') {
    if (pQueryInfo->interval.interval * 12 <= pQueryInfo->interval.offset) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    }
  } else {
    // TODO: offset should be shorter than interval, but how to check
    // conflicts like 30days offset and 1 month interval
823 824 825 826 827
  }

  return TSDB_CODE_SUCCESS;
}

828
int32_t parseSlidingClause(SSqlObj* pSql, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql) {
829 830
  const char* msg0 = "sliding value too small";
  const char* msg1 = "sliding value no larger than the interval value";
H
Haojun Liao 已提交
831
  const char* msg2 = "sliding value can not less than 1% of interval value";
832
  const char* msg3 = "does not support sliding when interval is natural month/year";
H
Haojun Liao 已提交
833
//  const char* msg4 = "sliding not support yet in ordinary query";
H
Haojun Liao 已提交
834 835

  const static int32_t INTERVAL_SLIDING_FACTOR = 100;
836
  SSqlCmd* pCmd = &pSql->cmd;
H
hzcheng 已提交
837

H
hjxilinx 已提交
838
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hjxilinx 已提交
839
  STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);
H
hzcheng 已提交
840

841
  SStrToken* pSliding = &pQuerySql->sliding;
B
Bomin Zhang 已提交
842
  if (pSliding->n == 0) {
843 844
    pQueryInfo->interval.slidingUnit = pQueryInfo->interval.intervalUnit;
    pQueryInfo->interval.sliding = pQueryInfo->interval.interval;
B
Bomin Zhang 已提交
845 846
    return TSDB_CODE_SUCCESS;
  }
H
hzcheng 已提交
847

848
  if (pQueryInfo->interval.intervalUnit == 'n' || pQueryInfo->interval.intervalUnit == 'y') {
B
Bomin Zhang 已提交
849 850
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
  }
H
hzcheng 已提交
851

852
  parseAbsoluteDuration(pSliding->z, pSliding->n, &pQueryInfo->interval.sliding);
B
Bomin Zhang 已提交
853
  if (tinfo.precision == TSDB_TIME_PRECISION_MILLI) {
854
    pQueryInfo->interval.sliding /= 1000;
B
Bomin Zhang 已提交
855 856
  }

857
  if (pQueryInfo->interval.sliding < tsMinSlidingTime) {
B
Bomin Zhang 已提交
858 859 860
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
  }

861
  if (pQueryInfo->interval.sliding > pQueryInfo->interval.interval) {
B
Bomin Zhang 已提交
862
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
863 864
  }

865
  if ((pQueryInfo->interval.interval != 0) && (pQueryInfo->interval.interval/pQueryInfo->interval.sliding > INTERVAL_SLIDING_FACTOR)) {
H
Haojun Liao 已提交
866 867 868
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
  }

H
Haojun Liao 已提交
869 870 871
//  if (pQueryInfo->interval.sliding != pQueryInfo->interval.interval && pSql->pStream == NULL) {
//    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
//  }
872

H
hzcheng 已提交
873 874 875
  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
876
int32_t tscSetTableFullName(STableMetaInfo* pTableMetaInfo, SStrToken* pzTableName, SSqlObj* pSql) {
Y
TD-1039  
yihaoDeng 已提交
877
  const char* msg1 = "name too long";
H
hzcheng 已提交
878

879 880
  SSqlCmd* pCmd = &pSql->cmd;
  int32_t  code = TSDB_CODE_SUCCESS;
S
slguan 已提交
881

H
hjxilinx 已提交
882
  // backup the old name in pTableMetaInfo
H
Haojun Liao 已提交
883 884
  char oldName[TSDB_TABLE_FNAME_LEN] = {0};
  tstrncpy(oldName, pTableMetaInfo->name, tListLen(oldName));
H
hjxilinx 已提交
885

H
Haojun Liao 已提交
886
  if (hasSpecifyDB(pzTableName)) { // db has been specified in sql string so we ignore current db path
H
hjxilinx 已提交
887
    code = setObjFullName(pTableMetaInfo->name, getAccountId(pSql), NULL, pzTableName, NULL);
H
Haojun Liao 已提交
888 889 890
    if (code != 0) {
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
    }
H
Haojun Liao 已提交
891
  } else {  // get current DB name first, and then set it into path
H
Haojun Liao 已提交
892
    SStrToken t = {0};
H
hzcheng 已提交
893
    getCurrentDBName(pSql, &t);
H
Haojun Liao 已提交
894
    if (t.n == 0) {  // current database not available or not specified
895
      code = TSDB_CODE_TSC_DB_NOT_SELECTED;
H
Haojun Liao 已提交
896 897 898 899 900
    } else {
      code = setObjFullName(pTableMetaInfo->name, NULL, &t, pzTableName, NULL);
      if (code != 0) {
        invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
      }
H
Haojun Liao 已提交
901
    }
H
hzcheng 已提交
902
  }
H
Haojun Liao 已提交
903

S
slguan 已提交
904
  if (code != TSDB_CODE_SUCCESS) {
905 906
    return code;
  }
H
hjxilinx 已提交
907

908
  /*
H
Haojun Liao 已提交
909
   * the old name exists and is not equalled to the new name. Release the table meta
910 911
   * that are corresponding to the old name for the new table name.
   */
H
Haojun Liao 已提交
912
  if (strlen(oldName) > 0 && strncasecmp(oldName, pTableMetaInfo->name, tListLen(pTableMetaInfo->name)) != 0) {
913
    tscClearTableMetaInfo(pTableMetaInfo);
914
  }
H
hjxilinx 已提交
915

916
  return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
917 918
}

H
Haojun Liao 已提交
919
static bool validateTableColumnInfo(SArray* pFieldList, SSqlCmd* pCmd) {
H
hzcheng 已提交
920 921
  assert(pFieldList != NULL);

922 923 924 925 926 927 928
  const char* msg = "illegal number of columns";
  const char* msg1 = "first column must be timestamp";
  const char* msg2 = "row length exceeds max length";
  const char* msg3 = "duplicated column names";
  const char* msg4 = "invalid data types";
  const char* msg5 = "invalid binary/nchar column length";
  const char* msg6 = "invalid column name";
H
hzcheng 已提交
929 930

  // number of fields no less than 2
H
Haojun Liao 已提交
931 932
  size_t numOfCols = taosArrayGetSize(pFieldList);
  if (numOfCols <= 1 || numOfCols > TSDB_MAX_COLUMNS) {
933
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
934 935 936 937
    return false;
  }

  // first column must be timestamp
H
Haojun Liao 已提交
938 939
  TAOS_FIELD* pField = taosArrayGet(pFieldList, 0);
  if (pField->type != TSDB_DATA_TYPE_TIMESTAMP) {
940
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
941 942 943 944
    return false;
  }

  int32_t nLen = 0;
H
Haojun Liao 已提交
945 946
  for (int32_t i = 0; i < numOfCols; ++i) {
    pField = taosArrayGet(pFieldList, i);
B
Bomin Zhang 已提交
947 948

    if (pField->bytes == 0) {
dengyihao's avatar
dengyihao 已提交
949 950 951
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
      return false;
    }
H
hzcheng 已提交
952 953

    if (pField->type < TSDB_DATA_TYPE_BOOL || pField->type > TSDB_DATA_TYPE_NCHAR) {
954
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
H
hzcheng 已提交
955 956 957 958 959
      return false;
    }

    if ((pField->type == TSDB_DATA_TYPE_BINARY && (pField->bytes <= 0 || pField->bytes > TSDB_MAX_BINARY_LEN)) ||
        (pField->type == TSDB_DATA_TYPE_NCHAR && (pField->bytes <= 0 || pField->bytes > TSDB_MAX_NCHAR_LEN))) {
960
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
961 962 963 964
      return false;
    }

    if (validateColumnName(pField->name) != TSDB_CODE_SUCCESS) {
965
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
966 967 968
      return false;
    }

B
Bomin Zhang 已提交
969
    // field name must be unique
H
Haojun Liao 已提交
970
    if (has(pFieldList, i + 1, pField->name) == true) {
971
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
972 973
      return false;
    }
B
Bomin Zhang 已提交
974 975 976 977 978 979 980 981

    nLen += pField->bytes;
  }

  // max row length must be less than TSDB_MAX_BYTES_PER_ROW
  if (nLen > TSDB_MAX_BYTES_PER_ROW) {
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    return false;
H
hzcheng 已提交
982 983 984 985 986
  }

  return true;
}

H
Haojun Liao 已提交
987
static bool validateTagParams(SArray* pTagsList, SArray* pFieldList, SSqlCmd* pCmd) {
H
hzcheng 已提交
988 989
  assert(pTagsList != NULL);

990 991 992 993 994 995 996
  const char* msg1 = "invalid number of tag columns";
  const char* msg2 = "tag length too long";
  const char* msg3 = "duplicated column names";
  const char* msg4 = "timestamp not allowed in tags";
  const char* msg5 = "invalid data type in tags";
  const char* msg6 = "invalid tag name";
  const char* msg7 = "invalid binary/nchar tag length";
H
hzcheng 已提交
997 998

  // number of fields at least 1
H
Haojun Liao 已提交
999 1000
  size_t numOfTags = taosArrayGetSize(pTagsList);
  if (numOfTags < 1 || numOfTags > TSDB_MAX_TAGS) {
1001
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1002 1003 1004 1005
    return false;
  }

  /* timestamp in tag is not allowed */
H
Haojun Liao 已提交
1006 1007 1008 1009
  for (int32_t i = 0; i < numOfTags; ++i) {
    TAOS_FIELD* p = taosArrayGet(pTagsList, i);

    if (p->type == TSDB_DATA_TYPE_TIMESTAMP) {
1010
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
H
hzcheng 已提交
1011 1012 1013
      return false;
    }

H
Haojun Liao 已提交
1014
    if (p->type < TSDB_DATA_TYPE_BOOL || p->type > TSDB_DATA_TYPE_NCHAR) {
1015
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
1016 1017 1018
      return false;
    }

H
Haojun Liao 已提交
1019 1020
    if ((p->type == TSDB_DATA_TYPE_BINARY && p->bytes <= 0) ||
        (p->type == TSDB_DATA_TYPE_NCHAR && p->bytes <= 0)) {
1021
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
H
hzcheng 已提交
1022 1023 1024
      return false;
    }

H
Haojun Liao 已提交
1025
    if (validateColumnName(p->name) != TSDB_CODE_SUCCESS) {
1026
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
1027 1028 1029
      return false;
    }

H
Haojun Liao 已提交
1030
    if (has(pTagsList, i + 1, p->name) == true) {
1031
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
1032 1033 1034 1035
      return false;
    }
  }

D
fix bug  
dapan1121 已提交
1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062
  int32_t nLen = 0;
  for (int32_t i = 0; i < numOfTags; ++i) {
    TAOS_FIELD* p = taosArrayGet(pTagsList, i);
    if (p->bytes == 0) {
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
      return false;
    }

    nLen += p->bytes;
  }

  // max tag row length must be less than TSDB_MAX_TAGS_LEN
  if (nLen > TSDB_MAX_TAGS_LEN) {
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    return false;
  }

  // field name must be unique
  for (int32_t i = 0; i < numOfTags; ++i) {
    TAOS_FIELD* p = taosArrayGet(pTagsList, i);

    if (has(pFieldList, 0, p->name) == true) {
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
      return false;
    }
  }

H
hzcheng 已提交
1063 1064 1065 1066 1067 1068 1069
  return true;
}

/*
 * tags name /column name is truncated in sql.y
 */
bool validateOneTags(SSqlCmd* pCmd, TAOS_FIELD* pTagField) {
1070 1071 1072 1073 1074 1075
  const char* msg1 = "timestamp not allowed in tags";
  const char* msg2 = "duplicated column names";
  const char* msg3 = "tag length too long";
  const char* msg4 = "invalid tag name";
  const char* msg5 = "invalid binary/nchar tag length";
  const char* msg6 = "invalid data type in tags";
H
hzcheng 已提交
1076

1077
  assert(pCmd->numOfClause == 1);
H
hjxilinx 已提交
1078

1079
  STableMetaInfo* pTableMetaInfo = tscGetTableMetaInfoFromCmd(pCmd, pCmd->clauseIndex, 0);
H
hjxilinx 已提交
1080
  STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;
H
hzcheng 已提交
1081

H
hjxilinx 已提交
1082 1083 1084
  int32_t numOfTags = tscGetNumOfTags(pTableMeta);
  int32_t numOfCols = tscGetNumOfColumns(pTableMeta);
  
H
hzcheng 已提交
1085
  // no more than 6 tags
H
hjxilinx 已提交
1086
  if (numOfTags == TSDB_MAX_TAGS) {
H
hzcheng 已提交
1087 1088 1089
    char msg[128] = {0};
    sprintf(msg, "tags no more than %d", TSDB_MAX_TAGS);

1090
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
1091 1092 1093 1094 1095
    return false;
  }

  // no timestamp allowable
  if (pTagField->type == TSDB_DATA_TYPE_TIMESTAMP) {
1096
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1097 1098 1099
    return false;
  }

L
[#1236]  
lihui 已提交
1100
  if ((pTagField->type < TSDB_DATA_TYPE_BOOL) || (pTagField->type > TSDB_DATA_TYPE_NCHAR)) {
1101
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
1102 1103 1104
    return false;
  }

H
hjxilinx 已提交
1105
  SSchema* pTagSchema = tscGetTableTagSchema(pTableMetaInfo->pTableMeta);
H
hzcheng 已提交
1106 1107
  int32_t  nLen = 0;

H
hjxilinx 已提交
1108
  for (int32_t i = 0; i < numOfTags; ++i) {
H
hzcheng 已提交
1109 1110 1111 1112 1113
    nLen += pTagSchema[i].bytes;
  }

  // length less than TSDB_MAX_TASG_LEN
  if (nLen + pTagField->bytes > TSDB_MAX_TAGS_LEN) {
1114
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
1115 1116 1117 1118 1119
    return false;
  }

  // tags name can not be a keyword
  if (validateColumnName(pTagField->name) != TSDB_CODE_SUCCESS) {
1120
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
H
hzcheng 已提交
1121 1122 1123 1124 1125
    return false;
  }

  // binary(val), val can not be equalled to or less than 0
  if ((pTagField->type == TSDB_DATA_TYPE_BINARY || pTagField->type == TSDB_DATA_TYPE_NCHAR) && pTagField->bytes <= 0) {
1126
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
1127 1128 1129 1130
    return false;
  }

  // field name must be unique
H
hjxilinx 已提交
1131
  SSchema* pSchema = tscGetTableSchema(pTableMeta);
H
hzcheng 已提交
1132

H
hjxilinx 已提交
1133
  for (int32_t i = 0; i < numOfTags + numOfCols; ++i) {
B
Bomin Zhang 已提交
1134
    if (strncasecmp(pTagField->name, pSchema[i].name, sizeof(pTagField->name) - 1) == 0) {
1135
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1136 1137 1138 1139 1140 1141 1142 1143
      return false;
    }
  }

  return true;
}

bool validateOneColumn(SSqlCmd* pCmd, TAOS_FIELD* pColField) {
1144 1145 1146 1147 1148 1149
  const char* msg1 = "too many columns";
  const char* msg2 = "duplicated column names";
  const char* msg3 = "column length too long";
  const char* msg4 = "invalid data types";
  const char* msg5 = "invalid column name";
  const char* msg6 = "invalid column length";
H
hzcheng 已提交
1150

1151
  assert(pCmd->numOfClause == 1);
1152
  STableMetaInfo* pTableMetaInfo = tscGetTableMetaInfoFromCmd(pCmd, pCmd->clauseIndex, 0);
H
hjxilinx 已提交
1153 1154 1155 1156 1157
  STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;
  
  int32_t numOfTags = tscGetNumOfTags(pTableMeta);
  int32_t numOfCols = tscGetNumOfColumns(pTableMeta);
  
H
hzcheng 已提交
1158
  // no more max columns
H
hjxilinx 已提交
1159
  if (numOfCols >= TSDB_MAX_COLUMNS || numOfTags + numOfCols >= TSDB_MAX_COLUMNS) {
1160
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1161 1162 1163 1164
    return false;
  }

  if (pColField->type < TSDB_DATA_TYPE_BOOL || pColField->type > TSDB_DATA_TYPE_NCHAR) {
1165
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
H
hzcheng 已提交
1166 1167 1168 1169
    return false;
  }

  if (validateColumnName(pColField->name) != TSDB_CODE_SUCCESS) {
1170
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
1171 1172 1173
    return false;
  }

H
hjxilinx 已提交
1174
  SSchema* pSchema = tscGetTableSchema(pTableMeta);
H
hzcheng 已提交
1175 1176
  int32_t  nLen = 0;

H
hjxilinx 已提交
1177
  for (int32_t i = 0; i < numOfCols; ++i) {
H
hzcheng 已提交
1178 1179 1180 1181
    nLen += pSchema[i].bytes;
  }

  if (pColField->bytes <= 0) {
1182
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
1183 1184 1185 1186 1187
    return false;
  }

  // length less than TSDB_MAX_BYTES_PER_ROW
  if (nLen + pColField->bytes > TSDB_MAX_BYTES_PER_ROW) {
1188
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
1189 1190 1191 1192
    return false;
  }

  // field name must be unique
H
hjxilinx 已提交
1193
  for (int32_t i = 0; i < numOfTags + numOfCols; ++i) {
B
Bomin Zhang 已提交
1194
    if (strncasecmp(pColField->name, pSchema[i].name, sizeof(pColField->name) - 1) == 0) {
1195
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1196 1197 1198 1199 1200 1201 1202 1203
      return false;
    }
  }

  return true;
}

/* is contained in pFieldList or not */
H
Haojun Liao 已提交
1204 1205 1206 1207
static bool has(SArray* pFieldList, int32_t startIdx, const char* name) {
  size_t numOfCols = taosArrayGetSize(pFieldList);
  for (int32_t j = startIdx; j < numOfCols; ++j) {
    TAOS_FIELD* field = taosArrayGet(pFieldList, j);
B
Bomin Zhang 已提交
1208
    if (strncasecmp(name, field->name, sizeof(field->name) - 1) == 0) return true;
H
hzcheng 已提交
1209 1210 1211 1212 1213 1214 1215
  }

  return false;
}

static char* getAccountId(SSqlObj* pSql) { return pSql->pTscObj->acctId; }

H
Haojun Liao 已提交
1216
static void getCurrentDBName(SSqlObj* pSql, SStrToken* pDBToken) {
H
hzcheng 已提交
1217
  pDBToken->z = pSql->pTscObj->db;
S
TD-1057  
Shengliang Guan 已提交
1218
  pDBToken->n = (uint32_t)strlen(pSql->pTscObj->db);
H
hzcheng 已提交
1219 1220 1221
}

/* length limitation, strstr cannot be applied */
H
Haojun Liao 已提交
1222
static bool hasSpecifyDB(SStrToken* pTableName) {
S
TD-1057  
Shengliang Guan 已提交
1223
  for (uint32_t i = 0; i < pTableName->n; ++i) {
H
hzcheng 已提交
1224 1225 1226 1227 1228 1229 1230 1231
    if (pTableName->z[i] == TS_PATH_DELIMITER[0]) {
      return true;
    }
  }

  return false;
}

H
Haojun Liao 已提交
1232
int32_t setObjFullName(char* fullName, const char* account, SStrToken* pDB, SStrToken* tableName, int32_t* xlen) {
H
hzcheng 已提交
1233 1234 1235
  int32_t totalLen = 0;

  if (account != NULL) {
S
TD-1057  
Shengliang Guan 已提交
1236
    int32_t len = (int32_t)strlen(account);
H
hzcheng 已提交
1237 1238 1239 1240 1241 1242 1243
    strcpy(fullName, account);
    fullName[len] = TS_PATH_DELIMITER[0];
    totalLen += (len + 1);
  }

  /* db name is not specified, the tableName dose not include db name */
  if (pDB != NULL) {
Y
TD-1039  
yihaoDeng 已提交
1244
    if (pDB->n >= TSDB_ACCT_LEN + TSDB_DB_NAME_LEN || pDB->n == 0) {
1245
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257
    }

    memcpy(&fullName[totalLen], pDB->z, pDB->n);
    totalLen += pDB->n;
  }

  if (tableName != NULL) {
    if (pDB != NULL) {
      fullName[totalLen] = TS_PATH_DELIMITER[0];
      totalLen += 1;

      /* here we only check the table name length limitation */
H
Haojun Liao 已提交
1258
      if (!tscValidateTableNameLength(tableName->n)) {
1259
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1260 1261 1262
      }
    } else {  // pDB == NULL, the db prefix name is specified in tableName
      /* the length limitation includes tablename + dbname + sep */
B
Bomin Zhang 已提交
1263
      if (tableName->n >= TSDB_TABLE_NAME_LEN + TSDB_DB_NAME_LEN) {
1264
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1265 1266 1267 1268 1269 1270 1271 1272 1273 1274
      }
    }

    memcpy(&fullName[totalLen], tableName->z, tableName->n);
    totalLen += tableName->n;
  }

  if (xlen != NULL) {
    *xlen = totalLen;
  }
S
slguan 已提交
1275

H
Haojun Liao 已提交
1276
  if (totalLen < TSDB_TABLE_FNAME_LEN) {
S
slguan 已提交
1277 1278 1279
    fullName[totalLen] = 0;
  }

H
Haojun Liao 已提交
1280
  return (totalLen < TSDB_TABLE_FNAME_LEN) ? TSDB_CODE_SUCCESS : TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1281 1282
}

Y
TD-1688  
yihaoDeng 已提交
1283 1284 1285 1286
static void tscInsertPrimaryTSSourceColumn(SQueryInfo* pQueryInfo, SColumnIndex* pIndex) {
  SColumnIndex tsCol = {.tableIndex = pIndex->tableIndex, .columnIndex = PRIMARYKEY_TIMESTAMP_COL_INDEX};
  tscColumnListInsert(pQueryInfo->colList, &tsCol);
}
H
Haojun Liao 已提交
1287

H
Haojun Liao 已提交
1288
static int32_t handleArithmeticExpr(SSqlCmd* pCmd, int32_t clauseIndex, int32_t exprIndex, tSqlExprItem* pItem) {
1289
  const char* msg1 = "invalid column name, illegal column type, or columns in arithmetic expression from two tables";
1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318
  const char* msg2 = "invalid arithmetic expression in select clause";
  const char* msg3 = "tag columns can not be used in arithmetic expression";
  const char* msg4 = "columns from different table mixed up in arithmetic expression";

  // arithmetic function in select clause
  SQueryInfo* pQueryInfo = tscGetQueryInfoDetail(pCmd, clauseIndex);

  SColumnList columnList = {0};
  int32_t     arithmeticType = NON_ARITHMEIC_EXPR;

  if (validateArithmeticSQLExpr(pCmd, pItem->pNode, pQueryInfo, &columnList, &arithmeticType) != TSDB_CODE_SUCCESS) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
  }

  int32_t tableIndex = columnList.ids[0].tableIndex;
  if (arithmeticType == NORMAL_ARITHMETIC) {
    pQueryInfo->type |= TSDB_QUERY_TYPE_PROJECTION_QUERY;

    // all columns in arithmetic expression must belong to the same table
    for (int32_t f = 1; f < columnList.num; ++f) {
      if (columnList.ids[f].tableIndex != tableIndex) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
      }
    }

    // expr string is set as the parameter of function
    SColumnIndex index = {.tableIndex = tableIndex};

    SSqlExpr* pExpr = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_ARITHM, &index, TSDB_DATA_TYPE_DOUBLE, sizeof(double),
H
Haojun Liao 已提交
1319
                                       getNewResColId(pQueryInfo), sizeof(double), false);
1320

H
Haojun Liao 已提交
1321 1322 1323
    char* name = (pItem->aliasName != NULL)? pItem->aliasName:pItem->pNode->token.z;
    size_t len = MIN(sizeof(pExpr->aliasName), pItem->pNode->token.n + 1);
    tstrncpy(pExpr->aliasName, name, len);
1324 1325 1326 1327

    tExprNode* pNode = NULL;
    SArray* colList = taosArrayInit(10, sizeof(SColIndex));

H
Haojun Liao 已提交
1328
    int32_t ret = exprTreeFromSqlExpr(pCmd, &pNode, pItem->pNode, pQueryInfo, colList, NULL);
1329
    if (ret != TSDB_CODE_SUCCESS) {
1330 1331
      taosArrayDestroy(colList);
      tExprTreeDestroy(&pNode, NULL);
1332 1333 1334
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    }

H
Haojun Liao 已提交
1335
    // check for if there is a tag in the arithmetic express
1336 1337 1338
    size_t numOfNode = taosArrayGetSize(colList);
    for(int32_t k = 0; k < numOfNode; ++k) {
      SColIndex* pIndex = taosArrayGet(colList, k);
1339 1340
      if (TSDB_COL_IS_TAG(pIndex->flag)) {
        tExprTreeDestroy(&pNode, NULL);
1341 1342
        taosArrayDestroy(colList);
        tExprTreeDestroy(&pNode, NULL);
1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
      }
    }

    SBufferWriter bw = tbufInitWriter(NULL, false);

    TRY(0) {
        exprTreeToBinary(&bw, pNode);
      } CATCH(code) {
        tbufCloseWriter(&bw);
        UNUSED(code);
        // TODO: other error handling
      } END_TRY

H
Haojun Liao 已提交
1357
    len = tbufTell(&bw);
H
Haojun Liao 已提交
1358
    char* c = tbufGetData(&bw, false);
1359 1360

    // set the serialized binary string as the parameter of arithmetic expression
H
Haojun Liao 已提交
1361
    addExprParams(pExpr, c, TSDB_DATA_TYPE_BINARY, (int32_t)len);
1362
    insertResultField(pQueryInfo, exprIndex, &columnList, sizeof(double), TSDB_DATA_TYPE_DOUBLE, pExpr->aliasName, pExpr);
H
Haojun Liao 已提交
1363

Y
TD-1688  
yihaoDeng 已提交
1364 1365
    // add ts column
    tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
1366

H
Haojun Liao 已提交
1367
    tbufCloseWriter(&bw);
1368 1369 1370 1371 1372 1373
    taosArrayDestroy(colList);
    tExprTreeDestroy(&pNode, NULL);
  } else {
    columnList.num = 0;
    columnList.ids[0] = (SColumnIndex) {0, 0};

H
Haojun Liao 已提交
1374 1375 1376 1377 1378 1379 1380
    char aliasName[TSDB_COL_NAME_LEN] = {0};
    if (pItem->aliasName != NULL) {
      tstrncpy(aliasName, pItem->aliasName, TSDB_COL_NAME_LEN);
    } else {
      int32_t nameLen = MIN(TSDB_COL_NAME_LEN, pItem->pNode->token.n + 1);
      tstrncpy(aliasName, pItem->pNode->token.z, nameLen);
    }
H
Haojun Liao 已提交
1381

H
Haojun Liao 已提交
1382
    insertResultField(pQueryInfo, exprIndex, &columnList, sizeof(double), TSDB_DATA_TYPE_DOUBLE, aliasName, NULL);
1383 1384

    int32_t slot = tscNumOfFields(pQueryInfo) - 1;
H
Haojun Liao 已提交
1385
    SInternalField* pInfo = tscFieldInfoGetInternalField(&pQueryInfo->fieldsInfo, slot);
1386 1387 1388 1389 1390

    if (pInfo->pSqlExpr == NULL) {
      SExprInfo* pArithExprInfo = calloc(1, sizeof(SExprInfo));

      // arithmetic expression always return result in the format of double float
H
Haojun Liao 已提交
1391
      pArithExprInfo->bytes      = sizeof(double);
1392
      pArithExprInfo->interBytes = sizeof(double);
H
Haojun Liao 已提交
1393
      pArithExprInfo->type       = TSDB_DATA_TYPE_DOUBLE;
1394

H
Haojun Liao 已提交
1395 1396 1397 1398
      pArithExprInfo->base.functionId = TSDB_FUNC_ARITHM;
      pArithExprInfo->base.numOfParams = 1;
      pArithExprInfo->base.resColId = getNewResColId(pQueryInfo);

H
Haojun Liao 已提交
1399
      int32_t ret = exprTreeFromSqlExpr(pCmd, &pArithExprInfo->pExpr, pItem->pNode, pQueryInfo, NULL, &pArithExprInfo->uid);
1400 1401 1402 1403 1404 1405 1406
      if (ret != TSDB_CODE_SUCCESS) {
        tExprTreeDestroy(&pArithExprInfo->pExpr, NULL);
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "invalid expression in select clause");
      }

      pInfo->pArithExprInfo = pArithExprInfo;
    }
H
Haojun Liao 已提交
1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417

    SBufferWriter bw = tbufInitWriter(NULL, false);

    TRY(0) {
      exprTreeToBinary(&bw, pInfo->pArithExprInfo->pExpr);
    } CATCH(code) {
      tbufCloseWriter(&bw);
      UNUSED(code);
      // TODO: other error handling
    } END_TRY

H
Haojun Liao 已提交
1418 1419 1420 1421 1422 1423
    SSqlFuncMsg* pFuncMsg = &pInfo->pArithExprInfo->base;
    pFuncMsg->arg[0].argBytes = (int16_t) tbufTell(&bw);
    pFuncMsg->arg[0].argValue.pz = tbufGetData(&bw, true);
    pFuncMsg->arg[0].argType = TSDB_DATA_TYPE_BINARY;

//    tbufCloseWriter(&bw); // TODO there is a memory leak
1424 1425 1426 1427 1428
  }

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
1429
static void addProjectQueryCol(SQueryInfo* pQueryInfo, int32_t startPos, SColumnIndex* pIndex, tSqlExprItem* pItem) {
H
Haojun Liao 已提交
1430
  SSqlExpr* pExpr = doAddProjectCol(pQueryInfo, pIndex->columnIndex, pIndex->tableIndex);
H
Haojun Liao 已提交
1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451

  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, pIndex->tableIndex);
  STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;

  SSchema* pSchema = tscGetTableColumnSchema(pTableMeta, pIndex->columnIndex);

  char* colName = (pItem->aliasName == NULL) ? pSchema->name : pItem->aliasName;
  tstrncpy(pExpr->aliasName, colName, sizeof(pExpr->aliasName));

  SColumnList ids = {0};
  ids.num = 1;
  ids.ids[0] = *pIndex;

  if (pIndex->columnIndex == TSDB_TBNAME_COLUMN_INDEX || pIndex->columnIndex == TSDB_UD_COLUMN_INDEX ||
      pIndex->columnIndex >= tscGetNumOfColumns(pTableMeta)) {
    ids.num = 0;
  }

  insertResultField(pQueryInfo, startPos, &ids, pExpr->resBytes, (int8_t)pExpr->resType, pExpr->aliasName, pExpr);
}

H
Haojun Liao 已提交
1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467
static void addPrimaryTsColIntoResult(SQueryInfo* pQueryInfo) {
  // primary timestamp column has been added already
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t i = 0; i < size; ++i) {
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
    if (pExpr->functionId == TSDB_FUNC_PRJ && pExpr->colInfo.colId == PRIMARYKEY_TIMESTAMP_COL_INDEX) {
      return;
    }
  }


  // set the constant column value always attached to first table.
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
  SSchema* pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, PRIMARYKEY_TIMESTAMP_COL_INDEX);

  // add the timestamp column into the output columns
H
Haojun Liao 已提交
1468
  SColumnIndex index = {0};  // primary timestamp column info
H
Haojun Liao 已提交
1469 1470 1471
  int32_t numOfCols = (int32_t)tscSqlExprNumOfExprs(pQueryInfo);
  tscAddSpecialColumnForSelect(pQueryInfo, numOfCols, TSDB_FUNC_PRJ, &index, pSchema, TSDB_COL_NORMAL);

H
Haojun Liao 已提交
1472
  SInternalField* pSupInfo = tscFieldInfoGetInternalField(&pQueryInfo->fieldsInfo, numOfCols);
H
Haojun Liao 已提交
1473 1474 1475 1476 1477
  pSupInfo->visible = false;

  pQueryInfo->type |= TSDB_QUERY_TYPE_PROJECTION_QUERY;
}

H
Haojun Liao 已提交
1478
int32_t parseSelectClause(SSqlCmd* pCmd, int32_t clauseIndex, tSQLExprList* pSelection, bool isSTable, bool joinQuery) {
H
hzcheng 已提交
1479 1480
  assert(pSelection != NULL && pCmd != NULL);

1481 1482
  const char* msg2 = "functions can not be mixed up";
  const char* msg3 = "not support query expression";
H
hjxilinx 已提交
1483
  const char* msg5 = "invalid function name";
H
hjxilinx 已提交
1484

1485
  SQueryInfo* pQueryInfo = tscGetQueryInfoDetail(pCmd, clauseIndex);
H
Haojun Liao 已提交
1486

1487 1488 1489
  if (pQueryInfo->colList == NULL) {
    pQueryInfo->colList = taosArrayInit(4, POINTER_BYTES);
  }
H
Haojun Liao 已提交
1490

H
hzcheng 已提交
1491
  for (int32_t i = 0; i < pSelection->nExpr; ++i) {
S
Shengliang Guan 已提交
1492
    int32_t outputIndex = (int32_t)tscSqlExprNumOfExprs(pQueryInfo);
H
Haojun Liao 已提交
1493
    tSqlExprItem* pItem = &pSelection->a[i];
H
hzcheng 已提交
1494

S
slguan 已提交
1495
    // project on all fields
H
Haojun Liao 已提交
1496 1497
    int32_t optr = pItem->pNode->nSQLOptr;

1498
    if (optr == TK_ALL || optr == TK_ID || optr == TK_STRING || optr == TK_INTEGER || optr == TK_FLOAT) {
S
slguan 已提交
1499
      // it is actually a function, but the function name is invalid
H
hzcheng 已提交
1500
      if (pItem->pNode->nSQLOptr == TK_ID && (pItem->pNode->colInfo.z == NULL && pItem->pNode->colInfo.n == 0)) {
H
hjxilinx 已提交
1501
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
1502 1503
      }

S
slguan 已提交
1504
      // select table_name1.field_name1, table_name2.field_name2  from table_name1, table_name2
1505
      if (addProjectionExprAndResultField(pCmd, pQueryInfo, pItem) != TSDB_CODE_SUCCESS) {
1506
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1507
      }
1508
    } else if (pItem->pNode->nSQLOptr >= TK_COUNT && pItem->pNode->nSQLOptr <= TK_TBID) {
S
slguan 已提交
1509
      // sql function in selection clause, append sql function info in pSqlCmd structure sequentially
1510
      if (addExprAndResultField(pCmd, pQueryInfo, outputIndex, pItem, true) != TSDB_CODE_SUCCESS) {
1511
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1512 1513 1514
      }

    } else if (pItem->pNode->nSQLOptr >= TK_PLUS && pItem->pNode->nSQLOptr <= TK_REM) {
1515 1516 1517
      int32_t code = handleArithmeticExpr(pCmd, clauseIndex, i, pItem);
      if (code != TSDB_CODE_SUCCESS) {
        return code;
H
hzcheng 已提交
1518 1519
      }
    } else {
1520
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
1521 1522
    }

H
hjxilinx 已提交
1523
    if (pQueryInfo->fieldsInfo.numOfOutput > TSDB_MAX_COLUMNS) {
1524
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1525 1526 1527
    }
  }

1528 1529 1530
  // there is only one user-defined column in the final result field, add the timestamp column.
  size_t numOfSrcCols = taosArrayGetSize(pQueryInfo->colList);
  if (numOfSrcCols <= 0 && !tscQueryTags(pQueryInfo)) {
H
Haojun Liao 已提交
1531
    addPrimaryTsColIntoResult(pQueryInfo);
1532 1533
  }

H
Haojun Liao 已提交
1534
  if (!functionCompatibleCheck(pQueryInfo, joinQuery)) {
1535
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1536 1537
  }

H
Haojun Liao 已提交
1538 1539
  /*
   * transfer sql functions that need secondary merge into another format
1540
   * in dealing with super table queries such as: count/first/last
H
Haojun Liao 已提交
1541
   */
1542
  if (isSTable) {
H
hjxilinx 已提交
1543
    tscTansformSQLFuncForSTableQuery(pQueryInfo);
H
hzcheng 已提交
1544

1545
    if (hasUnsupportFunctionsForSTableQuery(pCmd, pQueryInfo)) {
1546
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1547 1548 1549 1550 1551 1552
    }
  }

  return TSDB_CODE_SUCCESS;
}

H
hjxilinx 已提交
1553 1554
int32_t insertResultField(SQueryInfo* pQueryInfo, int32_t outputIndex, SColumnList* pIdList, int16_t bytes,
    int8_t type, char* fieldName, SSqlExpr* pSqlExpr) {
1555
  
S
slguan 已提交
1556
  for (int32_t i = 0; i < pIdList->num; ++i) {
1557 1558 1559 1560 1561 1562 1563 1564
    int32_t tableId = pIdList->ids[i].tableIndex;
    STableMetaInfo* pTableMetaInfo = pQueryInfo->pTableMetaInfo[tableId];
    
    int32_t numOfCols = tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
    if (pIdList->ids[i].columnIndex >= numOfCols) {
      continue;
    }
    
1565
    tscColumnListInsert(pQueryInfo->colList, &(pIdList->ids[i]));
H
hzcheng 已提交
1566
  }
H
hjxilinx 已提交
1567 1568
  
  TAOS_FIELD f = tscCreateField(type, fieldName, bytes);
H
Haojun Liao 已提交
1569
  SInternalField* pInfo = tscFieldInfoInsert(&pQueryInfo->fieldsInfo, outputIndex, &f);
H
hjxilinx 已提交
1570
  pInfo->pSqlExpr = pSqlExpr;
H
hjxilinx 已提交
1571
  
H
hzcheng 已提交
1572 1573 1574
  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
1575
SSqlExpr* doAddProjectCol(SQueryInfo* pQueryInfo, int32_t colIndex, int32_t tableIndex) {
H
hjxilinx 已提交
1576
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, tableIndex);
H
hjxilinx 已提交
1577 1578 1579
  STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;
  int32_t numOfCols = tscGetNumOfColumns(pTableMeta);
  
1580
  SSchema* pSchema = tscGetTableColumnSchema(pTableMeta, colIndex);
H
hzcheng 已提交
1581

1582
  int16_t functionId = (int16_t)((colIndex >= numOfCols) ? TSDB_FUNC_TAGPRJ : TSDB_FUNC_PRJ);
1583 1584 1585 1586
  SColumnIndex index = {.tableIndex = tableIndex,};
  
  if (functionId == TSDB_FUNC_TAGPRJ) {
    index.columnIndex = colIndex - tscGetNumOfColumns(pTableMeta);
H
hjxilinx 已提交
1587
    tscColumnListInsert(pTableMetaInfo->tagColList, &index);
1588 1589 1590
  } else {
    index.columnIndex = colIndex;
  }
H
Haojun Liao 已提交
1591 1592 1593 1594

  int16_t colId = getNewResColId(pQueryInfo);
  return tscSqlExprAppend(pQueryInfo, functionId, &index, pSchema->type, pSchema->bytes, colId, pSchema->bytes,
                          (functionId == TSDB_FUNC_TAGPRJ));
H
hzcheng 已提交
1595 1596
}

H
Haojun Liao 已提交
1597
SSqlExpr* tscAddSpecialColumnForSelect(SQueryInfo* pQueryInfo, int32_t outputColIndex, int16_t functionId,
S
slguan 已提交
1598
                                  SColumnIndex* pIndex, SSchema* pColSchema, int16_t flag) {
H
Haojun Liao 已提交
1599 1600
  int16_t colId = getNewResColId(pQueryInfo);

H
Haojun Liao 已提交
1601
  SSqlExpr* pExpr = tscSqlExprInsert(pQueryInfo, outputColIndex, functionId, pIndex, pColSchema->type,
H
Haojun Liao 已提交
1602
                                     pColSchema->bytes, colId, pColSchema->bytes, TSDB_COL_IS_TAG(flag));
H
Haojun Liao 已提交
1603
  tstrncpy(pExpr->aliasName, pColSchema->name, sizeof(pExpr->aliasName));
H
hzcheng 已提交
1604

S
slguan 已提交
1605 1606 1607 1608
  SColumnList ids = getColumnList(1, pIndex->tableIndex, pIndex->columnIndex);
  if (TSDB_COL_IS_TAG(flag)) {
    ids.num = 0;
  }
H
hzcheng 已提交
1609

H
hjxilinx 已提交
1610
  insertResultField(pQueryInfo, outputColIndex, &ids, pColSchema->bytes, pColSchema->type, pColSchema->name, pExpr);
S
slguan 已提交
1611 1612

  pExpr->colInfo.flag = flag;
1613 1614
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, pIndex->tableIndex);
  
S
slguan 已提交
1615
  if (TSDB_COL_IS_TAG(flag)) {
H
hjxilinx 已提交
1616
    tscColumnListInsert(pTableMetaInfo->tagColList, pIndex);
S
slguan 已提交
1617
  }
H
Haojun Liao 已提交
1618 1619

  return pExpr;
S
slguan 已提交
1620 1621
}

1622
static int32_t doAddProjectionExprAndResultFields(SQueryInfo* pQueryInfo, SColumnIndex* pIndex, int32_t startPos) {
H
hjxilinx 已提交
1623
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, pIndex->tableIndex);
S
slguan 已提交
1624 1625

  int32_t     numOfTotalColumns = 0;
H
hjxilinx 已提交
1626 1627
  STableMeta* pTableMeta = pTableMetaInfo->pTableMeta;
  SSchema*    pSchema = tscGetTableSchema(pTableMeta);
S
slguan 已提交
1628

H
hjxilinx 已提交
1629
  STableComInfo tinfo = tscGetTableInfo(pTableMeta);
H
hjxilinx 已提交
1630
  
weixin_48148422's avatar
weixin_48148422 已提交
1631
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
hjxilinx 已提交
1632
    numOfTotalColumns = tinfo.numOfColumns + tinfo.numOfTags;
S
slguan 已提交
1633
  } else {
H
hjxilinx 已提交
1634
    numOfTotalColumns = tinfo.numOfColumns;
S
slguan 已提交
1635 1636 1637
  }

  for (int32_t j = 0; j < numOfTotalColumns; ++j) {
H
Haojun Liao 已提交
1638
    SSqlExpr* pExpr = doAddProjectCol(pQueryInfo, j, pIndex->tableIndex);
B
Bomin Zhang 已提交
1639
    tstrncpy(pExpr->aliasName, pSchema[j].name, sizeof(pExpr->aliasName));
S
slguan 已提交
1640 1641 1642 1643

    pIndex->columnIndex = j;
    SColumnList ids = {0};
    ids.ids[0] = *pIndex;
H
hjxilinx 已提交
1644
    ids.num = 1;
S
slguan 已提交
1645

H
hjxilinx 已提交
1646
    insertResultField(pQueryInfo, startPos + j, &ids, pSchema[j].bytes, pSchema[j].type, pSchema[j].name, pExpr);
S
slguan 已提交
1647 1648 1649 1650 1651
  }

  return numOfTotalColumns;
}

H
Haojun Liao 已提交
1652
int32_t addProjectionExprAndResultField(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSqlExprItem* pItem) {
S
slguan 已提交
1653
  const char* msg0 = "invalid column name";
H
hjxilinx 已提交
1654
  const char* msg1 = "tag for normal table query is not allowed";
S
slguan 已提交
1655

1656
  int32_t startPos = (int32_t)tscSqlExprNumOfExprs(pQueryInfo);
H
Haojun Liao 已提交
1657 1658 1659 1660 1661
  int32_t optr = pItem->pNode->nSQLOptr;

  if (optr == TK_ALL) {  // project on all fields
    TSDB_QUERY_SET_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_PROJECTION_QUERY);

S
slguan 已提交
1662
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
1663
    if (getTableIndexByName(&pItem->pNode->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
1664
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
S
slguan 已提交
1665 1666 1667 1668
    }

    // all meters columns are required
    if (index.tableIndex == COLUMN_INDEX_INITIAL_VAL) {  // all table columns are required.
1669
      for (int32_t i = 0; i < pQueryInfo->numOfTables; ++i) {
S
slguan 已提交
1670
        index.tableIndex = i;
1671
        int32_t inc = doAddProjectionExprAndResultFields(pQueryInfo, &index, startPos);
S
slguan 已提交
1672
        startPos += inc;
H
hzcheng 已提交
1673 1674
      }
    } else {
1675
      doAddProjectionExprAndResultFields(pQueryInfo, &index, startPos);
S
slguan 已提交
1676
    }
H
Haojun Liao 已提交
1677 1678 1679

    // add the primary timestamp column even though it is not required by user
    tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
1680
  } else if (optr == TK_STRING || optr == TK_INTEGER || optr == TK_FLOAT) {  // simple column projection query
S
slguan 已提交
1681 1682
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;

H
Haojun Liao 已提交
1683
    // user-specified constant value as a new result column
1684 1685
    index.columnIndex = (pQueryInfo->udColumnId--);
    index.tableIndex = 0;
H
hzcheng 已提交
1686

H
Haojun Liao 已提交
1687
    SSchema colSchema = tGetUserSpecifiedColumnSchema(&pItem->pNode->val, &pItem->pNode->token, pItem->aliasName);
1688 1689
    SSqlExpr* pExpr =
        tscAddSpecialColumnForSelect(pQueryInfo, startPos, TSDB_FUNC_PRJ, &index, &colSchema, TSDB_COL_UDC);
H
hzcheng 已提交
1690

1691 1692 1693 1694 1695
    // NOTE: the first parameter is reserved for the tag column id during join query process.
    pExpr->numOfParams = 2;
    tVariantAssign(&pExpr->param[1], &pItem->pNode->val);
  } else if (optr == TK_ID) {
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
H
Haojun Liao 已提交
1696

1697 1698 1699
    if (getColumnIndexByName(pCmd, &pItem->pNode->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
    }
H
Haojun Liao 已提交
1700

1701 1702 1703 1704 1705 1706
    if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
      SSchema colSchema = tGetTableNameColumnSchema();
      tscAddSpecialColumnForSelect(pQueryInfo, startPos, TSDB_FUNC_TAGPRJ, &index, &colSchema, TSDB_COL_TAG);
    } else {
      STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
      STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;
H
Haojun Liao 已提交
1707

1708 1709
      if (index.columnIndex >= tscGetNumOfColumns(pTableMeta) && UTIL_TABLE_IS_NORMAL_TABLE(pTableMetaInfo)) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1710 1711
      }

1712
      addProjectQueryCol(pQueryInfo, startPos, &index, pItem);
H
Haojun Liao 已提交
1713
      pQueryInfo->type |= TSDB_QUERY_TYPE_PROJECTION_QUERY;
H
hzcheng 已提交
1714
    }
H
Haojun Liao 已提交
1715

1716 1717
    // add the primary timestamp column even though it is not required by user
    tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
H
hzcheng 已提交
1718
  } else {
1719
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1720 1721 1722 1723 1724
  }

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
1725
static int32_t setExprInfoForFunctions(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SSchema* pSchema, SConvertFunc cvtFunc,
1726
                                       const char* name, int32_t resColIdx, SColumnIndex* pColIndex, bool finalResult) {
1727 1728
  const char* msg1 = "not support column types";

H
hzcheng 已提交
1729 1730
  int16_t type = 0;
  int16_t bytes = 0;
Y
TD-1230  
yihaoDeng 已提交
1731
  int32_t functionID = cvtFunc.execFuncId;
H
hzcheng 已提交
1732 1733

  if (functionID == TSDB_FUNC_SPREAD) {
1734
    int32_t t1 = pSchema->type;
1735
    if (t1 == TSDB_DATA_TYPE_BINARY || t1 == TSDB_DATA_TYPE_NCHAR || t1 == TSDB_DATA_TYPE_BOOL) {
1736
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1737 1738 1739 1740 1741 1742
      return -1;
    } else {
      type = TSDB_DATA_TYPE_DOUBLE;
      bytes = tDataTypeDesc[type].nSize;
    }
  } else {
1743 1744
    type = pSchema->type;
    bytes = pSchema->bytes;
H
hzcheng 已提交
1745
  }
Y
TD-1230  
yihaoDeng 已提交
1746
  
H
Haojun Liao 已提交
1747
  SSqlExpr* pExpr = tscSqlExprAppend(pQueryInfo, functionID, pColIndex, type, bytes, getNewResColId(pQueryInfo), bytes, false);
1748
  tstrncpy(pExpr->aliasName, name, tListLen(pExpr->aliasName));
1749

Y
TD-1230  
yihaoDeng 已提交
1750 1751 1752 1753
  if (cvtFunc.originFuncId == TSDB_FUNC_LAST_ROW && cvtFunc.originFuncId != functionID) {
    pExpr->colInfo.flag |= TSDB_COL_NULL;
  }

1754 1755 1756 1757 1758 1759
  // set reverse order scan data blocks for last query
  if (functionID == TSDB_FUNC_LAST) {
    pExpr->numOfParams = 1;
    pExpr->param[0].i64Key = TSDB_ORDER_DESC;
    pExpr->param[0].nType = TSDB_DATA_TYPE_INT;
  }
H
hjxilinx 已提交
1760
  
H
hjxilinx 已提交
1761
  // for all queries, the timestamp column needs to be loaded
S
slguan 已提交
1762
  SColumnIndex index = {.tableIndex = pColIndex->tableIndex, .columnIndex = PRIMARYKEY_TIMESTAMP_COL_INDEX};
1763
  tscColumnListInsert(pQueryInfo->colList, &index);
H
hzcheng 已提交
1764

H
Haojun Liao 已提交
1765
  // if it is not in the final result, do not add it
S
slguan 已提交
1766
  SColumnList ids = getColumnList(1, pColIndex->tableIndex, pColIndex->columnIndex);
H
Haojun Liao 已提交
1767
  if (finalResult) {
1768
    insertResultField(pQueryInfo, resColIdx, &ids, bytes, (int8_t)type, pExpr->aliasName, pExpr);
H
Haojun Liao 已提交
1769 1770 1771
  } else {
    tscColumnListInsert(pQueryInfo->colList, &(ids.ids[0]));
  }
H
hzcheng 已提交
1772 1773 1774 1775

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
1776
void setResultColName(char* name, tSqlExprItem* pItem, int32_t functionId, SStrToken* pToken, bool multiCols) {
1777 1778
  if (pItem->aliasName != NULL) {
    tstrncpy(name, pItem->aliasName, TSDB_COL_NAME_LEN);
H
Haojun Liao 已提交
1779
  } else if (multiCols) {
1780 1781 1782 1783
    char uname[TSDB_COL_NAME_LEN] = {0};
    int32_t len = MIN(pToken->n + 1, TSDB_COL_NAME_LEN);
    tstrncpy(uname, pToken->z, len);

1784 1785 1786 1787 1788 1789
    if (tsKeepOriginalColumnName) { // keep the original column name
      tstrncpy(name, uname, TSDB_COL_NAME_LEN);
    } else {
      int32_t size = TSDB_COL_NAME_LEN + tListLen(aAggs[functionId].aName) + 2 + 1;
      char tmp[TSDB_COL_NAME_LEN + tListLen(aAggs[functionId].aName) + 2 + 1] = {0};
      snprintf(tmp, size, "%s(%s)", aAggs[functionId].aName, uname);
H
Haojun Liao 已提交
1790

1791 1792
      tstrncpy(name, tmp, TSDB_COL_NAME_LEN);
    }
H
Haojun Liao 已提交
1793 1794 1795
  } else  { // use the user-input result column name
    int32_t len = MIN(pItem->pNode->token.n + 1, TSDB_COL_NAME_LEN);
    tstrncpy(name, pItem->pNode->token.z, len);
1796 1797 1798
  }
}

H
Haojun Liao 已提交
1799
int32_t addExprAndResultField(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, int32_t colIndex, tSqlExprItem* pItem, bool finalResult) {
H
hjxilinx 已提交
1800
  STableMetaInfo* pTableMetaInfo = NULL;
1801
  int32_t optr = pItem->pNode->nSQLOptr;
S
slguan 已提交
1802

1803
  const char* msg1 = "not support column types";
S
slguan 已提交
1804
  const char* msg2 = "invalid parameters";
1805
  const char* msg3 = "illegal column name";
S
slguan 已提交
1806
  const char* msg4 = "invalid table name";
1807
  const char* msg5 = "parameter is out of range [0, 100]";
S
slguan 已提交
1808
  const char* msg6 = "function applied to tags not allowed";
1809
  const char* msg7 = "normal table can not apply this function";
H
Haojun Liao 已提交
1810
  const char* msg8 = "multi-columns selection does not support alias column name";
B
Bomin Zhang 已提交
1811
  const char* msg9 = "invalid function";
H
Haojun Liao 已提交
1812

H
hzcheng 已提交
1813 1814 1815
  switch (optr) {
    case TK_COUNT: {
        /* more than one parameter for count() function */
H
Haojun Liao 已提交
1816
      if (pItem->pNode->pParam != NULL && pItem->pNode->pParam->nExpr != 1) {
1817
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1818 1819 1820
      }

      int16_t functionID = 0;
H
Haojun Liao 已提交
1821
      if (convertFunctionId(optr, &functionID) != TSDB_CODE_SUCCESS) {
1822
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1823 1824
      }

H
hjxilinx 已提交
1825
      SSqlExpr* pExpr = NULL;
S
slguan 已提交
1826
      SColumnIndex index = COLUMN_INDEX_INITIALIZER;
H
hzcheng 已提交
1827 1828

      if (pItem->pNode->pParam != NULL) {
H
Haojun Liao 已提交
1829
        tSqlExprItem* pParamElem = &pItem->pNode->pParam->a[0];
Y
TD-1370  
yihaoDeng 已提交
1830
        SStrToken* pToken = &pParamElem->pNode->colInfo;
S
TD-1530  
Shengliang Guan 已提交
1831
        int16_t sqlOptr = pParamElem->pNode->nSQLOptr;
Y
TD-1370  
yihaoDeng 已提交
1832 1833 1834 1835 1836
        if ((pToken->z == NULL || pToken->n == 0) 
            && (TK_INTEGER != sqlOptr)) /*select count(1) from table*/ {
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
        } 
        if (sqlOptr == TK_ALL) {
S
slguan 已提交
1837 1838
          // select table.*
          // check if the table name is valid or not
H
Haojun Liao 已提交
1839
          SStrToken tmpToken = pParamElem->pNode->colInfo;
S
slguan 已提交
1840

1841
          if (getTableIndexByName(&tmpToken, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
1842
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
1843 1844 1845 1846
          }

          index = (SColumnIndex){0, PRIMARYKEY_TIMESTAMP_COL_INDEX};
          int32_t size = tDataTypeDesc[TSDB_DATA_TYPE_BIGINT].nSize;
H
Haojun Liao 已提交
1847
          pExpr = tscSqlExprAppend(pQueryInfo, functionID, &index, TSDB_DATA_TYPE_BIGINT, size, getNewResColId(pQueryInfo), size, false);
Y
TD-1370  
yihaoDeng 已提交
1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858
        } else if (sqlOptr == TK_INTEGER) { // select count(1) from table1
          char buf[8] = {0};  
          int64_t val = -1;
          tVariant* pVariant = &pParamElem->pNode->val;
          if (pVariant->nType == TSDB_DATA_TYPE_BIGINT) {
            tVariantDump(pVariant, buf, TSDB_DATA_TYPE_BIGINT, true);
            val = GET_INT64_VAL(buf); 
          }
          if (val == 1) {
            index = (SColumnIndex){0, PRIMARYKEY_TIMESTAMP_COL_INDEX};
            int32_t size = tDataTypeDesc[TSDB_DATA_TYPE_BIGINT].nSize;
H
Haojun Liao 已提交
1859
            pExpr = tscSqlExprAppend(pQueryInfo, functionID, &index, TSDB_DATA_TYPE_BIGINT, size, getNewResColId(pQueryInfo), size, false);
Y
TD-1370  
yihaoDeng 已提交
1860 1861 1862
          } else {
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
          }
H
hzcheng 已提交
1863
        } else {
H
hjxilinx 已提交
1864
          // count the number of meters created according to the super table
1865 1866
          if (getColumnIndexByName(pCmd, pToken, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
1867 1868
          }

H
hjxilinx 已提交
1869
          pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
S
slguan 已提交
1870 1871

          // count tag is equalled to count(tbname)
H
Haojun Liao 已提交
1872 1873
          bool isTag = false;
          if (index.columnIndex >= tscGetNumOfColumns(pTableMetaInfo->pTableMeta) || index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
S
slguan 已提交
1874
            index.columnIndex = TSDB_TBNAME_COLUMN_INDEX;
H
Haojun Liao 已提交
1875
            isTag = true;
H
hzcheng 已提交
1876 1877
          }

S
slguan 已提交
1878
          int32_t size = tDataTypeDesc[TSDB_DATA_TYPE_BIGINT].nSize;
H
Haojun Liao 已提交
1879
          pExpr = tscSqlExprAppend(pQueryInfo, functionID, &index, TSDB_DATA_TYPE_BIGINT, size, getNewResColId(pQueryInfo), size, isTag);
H
hzcheng 已提交
1880
        }
S
slguan 已提交
1881 1882 1883
      } else {  // count(*) is equalled to count(primary_timestamp_key)
        index = (SColumnIndex){0, PRIMARYKEY_TIMESTAMP_COL_INDEX};
        int32_t size = tDataTypeDesc[TSDB_DATA_TYPE_BIGINT].nSize;
H
Haojun Liao 已提交
1884
        pExpr = tscSqlExprAppend(pQueryInfo, functionID, &index, TSDB_DATA_TYPE_BIGINT, size, getNewResColId(pQueryInfo), size, false);
H
hzcheng 已提交
1885
      }
H
Haojun Liao 已提交
1886 1887 1888

      pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);

H
hjxilinx 已提交
1889
      memset(pExpr->aliasName, 0, tListLen(pExpr->aliasName));
B
Bomin Zhang 已提交
1890
      getColumnName(pItem, pExpr->aliasName, sizeof(pExpr->aliasName) - 1);
H
hjxilinx 已提交
1891
      
S
slguan 已提交
1892
      SColumnList ids = getColumnList(1, index.tableIndex, index.columnIndex);
H
hjxilinx 已提交
1893 1894 1895 1896 1897
      if (finalResult) {
        int32_t numOfOutput = tscNumOfFields(pQueryInfo);
        insertResultField(pQueryInfo, numOfOutput, &ids, sizeof(int64_t), TSDB_DATA_TYPE_BIGINT, pExpr->aliasName, pExpr);
      } else {
        for (int32_t i = 0; i < ids.num; ++i) {
1898
          tscColumnListInsert(pQueryInfo->colList, &(ids.ids[i]));
H
hjxilinx 已提交
1899 1900
        }
      }
H
Haojun Liao 已提交
1901 1902

      // the time stamp may be always needed
H
Haojun Liao 已提交
1903 1904
      if (index.tableIndex < tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) {
        tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
H
Haojun Liao 已提交
1905 1906
      }

S
slguan 已提交
1907
      return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
1908 1909 1910
    }
    case TK_SUM:
    case TK_AVG:
L
lihui 已提交
1911 1912 1913 1914 1915 1916
    case TK_RATE:
    case TK_IRATE:
    case TK_SUM_RATE:
    case TK_SUM_IRATE:
    case TK_AVG_RATE:
    case TK_AVG_IRATE:
S
slguan 已提交
1917
    case TK_TWA:
H
hzcheng 已提交
1918 1919 1920 1921 1922 1923 1924 1925 1926
    case TK_MIN:
    case TK_MAX:
    case TK_DIFF:
    case TK_STDDEV:
    case TK_LEASTSQUARES: {
      // 1. valid the number of parameters
      if (pItem->pNode->pParam == NULL || (optr != TK_LEASTSQUARES && pItem->pNode->pParam->nExpr != 1) ||
          (optr == TK_LEASTSQUARES && pItem->pNode->pParam->nExpr != 3)) {
        /* no parameters or more than one parameter for function */
1927
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1928 1929
      }

H
Haojun Liao 已提交
1930
      tSqlExprItem* pParamElem = &(pItem->pNode->pParam->a[0]);
H
hzcheng 已提交
1931
      if (pParamElem->pNode->nSQLOptr != TK_ALL && pParamElem->pNode->nSQLOptr != TK_ID) {
1932
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
1933 1934
      }

S
slguan 已提交
1935
      SColumnIndex index = COLUMN_INDEX_INITIALIZER;
Y
yihaoDeng 已提交
1936
      if ((getColumnIndexByName(pCmd, &pParamElem->pNode->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS)) {
1937
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
1938
      }
Y
yihaoDeng 已提交
1939 1940 1941
      if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
      }
H
hzcheng 已提交
1942 1943

      // 2. check if sql function can be applied on this column data type
H
hjxilinx 已提交
1944
      pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
1945
      SSchema* pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, index.columnIndex);
S
slguan 已提交
1946 1947
      int16_t  colType = pSchema->type;

H
hjxilinx 已提交
1948
      if (colType <= TSDB_DATA_TYPE_BOOL || colType >= TSDB_DATA_TYPE_BINARY) {
1949
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
1950 1951 1952 1953
      }

      int16_t resultType = 0;
      int16_t resultSize = 0;
1954
      int32_t intermediateResSize = 0;
H
hzcheng 已提交
1955 1956

      int16_t functionID = 0;
H
Haojun Liao 已提交
1957
      if (convertFunctionId(optr, &functionID) != TSDB_CODE_SUCCESS) {
1958
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1959 1960
      }

S
slguan 已提交
1961 1962
      if (getResultDataInfo(pSchema->type, pSchema->bytes, functionID, 0, &resultType, &resultSize,
                            &intermediateResSize, 0, false) != TSDB_CODE_SUCCESS) {
1963
        return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
1964
      }
H
hzcheng 已提交
1965

S
slguan 已提交
1966
      // set the first column ts for diff query
H
hzcheng 已提交
1967
      if (optr == TK_DIFF) {
1968
        colIndex += 1;
S
slguan 已提交
1969
        SColumnIndex indexTS = {.tableIndex = index.tableIndex, .columnIndex = 0};
H
hjxilinx 已提交
1970
        SSqlExpr* pExpr = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_TS_DUMMY, &indexTS, TSDB_DATA_TYPE_TIMESTAMP, TSDB_KEYSIZE,
H
Haojun Liao 已提交
1971
                                           getNewResColId(pQueryInfo), TSDB_KEYSIZE, false);
H
hzcheng 已提交
1972

S
slguan 已提交
1973
        SColumnList ids = getColumnList(1, 0, 0);
H
hjxilinx 已提交
1974
        insertResultField(pQueryInfo, 0, &ids, TSDB_KEYSIZE, TSDB_DATA_TYPE_TIMESTAMP, aAggs[TSDB_FUNC_TS_DUMMY].aName, pExpr);
H
hzcheng 已提交
1975 1976
      }

S
slguan 已提交
1977
      // functions can not be applied to tags
H
hjxilinx 已提交
1978
      if (index.columnIndex >= tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) {
1979
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
S
slguan 已提交
1980 1981
      }

H
Haojun Liao 已提交
1982
      SSqlExpr* pExpr = tscSqlExprAppend(pQueryInfo, functionID, &index, resultType, resultSize, getNewResColId(pQueryInfo), resultSize, false);
H
hzcheng 已提交
1983 1984 1985 1986

      if (optr == TK_LEASTSQUARES) {
        /* set the leastsquares parameters */
        char val[8] = {0};
1987
        if (tVariantDump(&pParamElem[1].pNode->val, val, TSDB_DATA_TYPE_DOUBLE, true) < 0) {
1988
          return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1989 1990
        }

H
Haojun Liao 已提交
1991
        addExprParams(pExpr, val, TSDB_DATA_TYPE_DOUBLE, DOUBLE_BYTES);
H
hzcheng 已提交
1992 1993

        memset(val, 0, tListLen(val));
1994
        if (tVariantDump(&pParamElem[2].pNode->val, val, TSDB_DATA_TYPE_DOUBLE, true) < 0) {
1995
          return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
1996 1997
        }

H
Haojun Liao 已提交
1998
        addExprParams(pExpr, val, TSDB_DATA_TYPE_DOUBLE, sizeof(double));
H
hzcheng 已提交
1999 2000
      }

S
slguan 已提交
2001 2002 2003
      SColumnList ids = {0};
      ids.num = 1;
      ids.ids[0] = index;
H
hjxilinx 已提交
2004 2005
  
      memset(pExpr->aliasName, 0, tListLen(pExpr->aliasName));
B
Bomin Zhang 已提交
2006
      getColumnName(pItem, pExpr->aliasName, sizeof(pExpr->aliasName) - 1);
H
hjxilinx 已提交
2007 2008 2009
  
      if (finalResult) {
        int32_t numOfOutput = tscNumOfFields(pQueryInfo);
S
TD-1057  
Shengliang Guan 已提交
2010
        insertResultField(pQueryInfo, numOfOutput, &ids, pExpr->resBytes, (int32_t)pExpr->resType, pExpr->aliasName, pExpr);
H
hjxilinx 已提交
2011 2012
      } else {
        for (int32_t i = 0; i < ids.num; ++i) {
2013
          tscColumnListInsert(pQueryInfo->colList, &(ids.ids[i]));
H
hjxilinx 已提交
2014 2015
        }
      }
H
Haojun Liao 已提交
2016 2017

      tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
S
slguan 已提交
2018
      return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
2019 2020 2021 2022 2023 2024 2025 2026 2027
    }
    case TK_FIRST:
    case TK_LAST:
    case TK_SPREAD:
    case TK_LAST_ROW:
    case TK_INTERP: {
      bool requireAllFields = (pItem->pNode->pParam == NULL);

      int16_t functionID = 0;
H
Haojun Liao 已提交
2028
      if (convertFunctionId(optr, &functionID) != TSDB_CODE_SUCCESS) {
2029
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg9);
B
Bomin Zhang 已提交
2030
      }
2031 2032

      // NOTE: has time range condition or normal column filter condition, the last_row query will be transferred to last query
Y
TD-1230  
yihaoDeng 已提交
2033
      SConvertFunc cvtFunc = {.originFuncId = functionID, .execFuncId = functionID};
2034
      if (functionID == TSDB_FUNC_LAST_ROW && ((!TSWINDOW_IS_EQUAL(pQueryInfo->window, TSWINDOW_INITIALIZER)) || (hasNormalColumnFilter(pQueryInfo)))) {
Y
TD-1230  
yihaoDeng 已提交
2035 2036
        cvtFunc.execFuncId = TSDB_FUNC_LAST;
      }
2037

H
hzcheng 已提交
2038 2039
      if (!requireAllFields) {
        if (pItem->pNode->pParam->nExpr < 1) {
2040
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
2041 2042
        }

H
Haojun Liao 已提交
2043
        if (pItem->pNode->pParam->nExpr > 1 && (pItem->aliasName != NULL && strlen(pItem->aliasName) > 0)) {
2044
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg8);
H
Haojun Liao 已提交
2045 2046
        }

H
hzcheng 已提交
2047 2048
        /* in first/last function, multiple columns can be add to resultset */
        for (int32_t i = 0; i < pItem->pNode->pParam->nExpr; ++i) {
H
Haojun Liao 已提交
2049
          tSqlExprItem* pParamElem = &(pItem->pNode->pParam->a[i]);
H
hzcheng 已提交
2050
          if (pParamElem->pNode->nSQLOptr != TK_ALL && pParamElem->pNode->nSQLOptr != TK_ID) {
2051
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
2052 2053
          }

S
slguan 已提交
2054 2055
          SColumnIndex index = COLUMN_INDEX_INITIALIZER;

2056
          if (pParamElem->pNode->nSQLOptr == TK_ALL) { // select table.*
H
Haojun Liao 已提交
2057
            SStrToken tmpToken = pParamElem->pNode->colInfo;
S
slguan 已提交
2058

2059
            if (getTableIndexByName(&tmpToken, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
2060
              return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
2061 2062
            }

H
hjxilinx 已提交
2063
            pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
2064
            SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
2065

2066
            char name[TSDB_COL_NAME_LEN] = {0};
H
hjxilinx 已提交
2067
            for (int32_t j = 0; j < tscGetNumOfColumns(pTableMetaInfo->pTableMeta); ++j) {
S
slguan 已提交
2068
              index.columnIndex = j;
S
Shengliang Guan 已提交
2069
              SStrToken t = {.z = pSchema[j].name, .n = (uint32_t)strnlen(pSchema[j].name, TSDB_COL_NAME_LEN)};
H
Haojun Liao 已提交
2070
              setResultColName(name, pItem, cvtFunc.originFuncId, &t, true);
2071 2072

              if (setExprInfoForFunctions(pCmd, pQueryInfo, &pSchema[j], cvtFunc, name, colIndex++, &index, finalResult) != 0) {
2073
                return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2074 2075
              }
            }
H
hzcheng 已提交
2076

S
slguan 已提交
2077
          } else {
2078 2079
            if (getColumnIndexByName(pCmd, &pParamElem->pNode->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
              return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
2080 2081
            }

H
hjxilinx 已提交
2082
            pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
S
slguan 已提交
2083 2084

            // functions can not be applied to tags
H
hjxilinx 已提交
2085
            if ((index.columnIndex >= tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) || (index.columnIndex < 0)) {
2086
              return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
S
slguan 已提交
2087
            }
H
Haojun Liao 已提交
2088

2089 2090 2091
            char name[TSDB_COL_NAME_LEN] = {0};

            SSchema* pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, index.columnIndex);
H
Haojun Liao 已提交
2092 2093 2094

            bool multiColOutput = pItem->pNode->pParam->nExpr > 1;
            setResultColName(name, pItem, cvtFunc.originFuncId, &pParamElem->pNode->colInfo, multiColOutput);
2095 2096

            if (setExprInfoForFunctions(pCmd, pQueryInfo, pSchema, cvtFunc, name, colIndex + i, &index, finalResult) != 0) {
2097
              return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2098
            }
2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114

            if (optr == TK_LAST) {  // todo refactor
              SSqlGroupbyExpr* pGroupBy = &pQueryInfo->groupbyExpr;
              if (pGroupBy->numOfGroupCols > 0) {
                for(int32_t k = 0; k < pGroupBy->numOfGroupCols; ++k) {
                  SColIndex* pIndex = taosArrayGet(pGroupBy->columnInfo, k);
                  if (!TSDB_COL_IS_TAG(pIndex->flag) && pIndex->colIndex < tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) { // group by normal columns
                    SSqlExpr* pExpr = taosArrayGetP(pQueryInfo->exprList, colIndex + i);
                    pExpr->numOfParams = 1;
                    pExpr->param->i64Key = TSDB_ORDER_ASC;

                    break;
                  }
                }
              }
            }
H
hzcheng 已提交
2115 2116
          }
        }
2117
        
S
slguan 已提交
2118 2119 2120 2121
        return TSDB_CODE_SUCCESS;
      } else {  // select * from xxx
        int32_t numOfFields = 0;

H
Haojun Liao 已提交
2122
        // multicolumn selection does not support alias name
H
Haojun Liao 已提交
2123
        if (pItem->aliasName != NULL && strlen(pItem->aliasName) > 0) {
2124
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg8);
H
Haojun Liao 已提交
2125 2126
        }

2127
        for (int32_t j = 0; j < pQueryInfo->numOfTables; ++j) {
H
hjxilinx 已提交
2128
          pTableMetaInfo = tscGetMetaInfo(pQueryInfo, j);
H
hjxilinx 已提交
2129
          SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
2130

H
hjxilinx 已提交
2131
          for (int32_t i = 0; i < tscGetNumOfColumns(pTableMetaInfo->pTableMeta); ++i) {
S
slguan 已提交
2132
            SColumnIndex index = {.tableIndex = j, .columnIndex = i};
2133 2134

            char name[TSDB_COL_NAME_LEN] = {0};
2135
            SStrToken t = {.z = pSchema[i].name, .n = (uint32_t)strnlen(pSchema[i].name, TSDB_COL_NAME_LEN)};
H
Haojun Liao 已提交
2136
            setResultColName(name, pItem, cvtFunc.originFuncId, &t, true);
2137 2138

            if (setExprInfoForFunctions(pCmd, pQueryInfo, &pSchema[index.columnIndex], cvtFunc, name, colIndex, &index, finalResult) != 0) {
2139
              return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2140
            }
H
Haojun Liao 已提交
2141 2142

            colIndex++;
H
hzcheng 已提交
2143
          }
S
slguan 已提交
2144

H
hjxilinx 已提交
2145
          numOfFields += tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
H
hzcheng 已提交
2146 2147
        }

2148
        
S
slguan 已提交
2149
        return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
2150 2151 2152 2153 2154 2155 2156 2157 2158
      }
    }
    case TK_TOP:
    case TK_BOTTOM:
    case TK_PERCENTILE:
    case TK_APERCENTILE: {
      // 1. valid the number of parameters
      if (pItem->pNode->pParam == NULL || pItem->pNode->pParam->nExpr != 2) {
        /* no parameters or more than one parameter for function */
2159
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
2160 2161
      }

H
Haojun Liao 已提交
2162
      tSqlExprItem* pParamElem = &(pItem->pNode->pParam->a[0]);
H
hzcheng 已提交
2163
      if (pParamElem->pNode->nSQLOptr != TK_ID) {
2164
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
2165
      }
H
hjxilinx 已提交
2166
      
S
slguan 已提交
2167
      SColumnIndex index = COLUMN_INDEX_INITIALIZER;
2168 2169
      if (getColumnIndexByName(pCmd, &pParamElem->pNode->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
2170
      }
Y
yihaoDeng 已提交
2171 2172 2173 2174
      if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
      }
      
H
hjxilinx 已提交
2175
      pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
2176
      SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
2177 2178

      // functions can not be applied to tags
H
hjxilinx 已提交
2179
      if (index.columnIndex >= tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) {
2180
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
2181 2182 2183
      }

      // 2. valid the column type
S
slguan 已提交
2184
      int16_t colType = pSchema[index.columnIndex].type;
H
hzcheng 已提交
2185
      if (colType == TSDB_DATA_TYPE_BOOL || colType >= TSDB_DATA_TYPE_BINARY) {
2186
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
2187 2188 2189 2190
      }

      // 3. valid the parameters
      if (pParamElem[1].pNode->nSQLOptr == TK_ID) {
2191
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
2192 2193 2194 2195
      }

      tVariant* pVariant = &pParamElem[1].pNode->val;

S
slguan 已提交
2196 2197
      int8_t  resultType = pSchema[index.columnIndex].type;
      int16_t resultSize = pSchema[index.columnIndex].bytes;
H
hzcheng 已提交
2198

H
hjxilinx 已提交
2199
      char    val[8] = {0};
H
hjxilinx 已提交
2200 2201
      SSqlExpr* pExpr = NULL;
      
H
hzcheng 已提交
2202
      if (optr == TK_PERCENTILE || optr == TK_APERCENTILE) {
2203
        tVariantDump(pVariant, val, TSDB_DATA_TYPE_DOUBLE, true);
H
hzcheng 已提交
2204

L
lihui 已提交
2205
        double dp = GET_DOUBLE_VAL(val);
S
slguan 已提交
2206
        if (dp < 0 || dp > TOP_BOTTOM_QUERY_LIMIT) {
2207
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218
        }

        resultSize = sizeof(double);
        resultType = TSDB_DATA_TYPE_DOUBLE;

        /*
         * sql function transformation
         * for dp = 0, it is actually min,
         * for dp = 100, it is max,
         */
        int16_t functionId = 0;
H
Haojun Liao 已提交
2219
        if (convertFunctionId(optr, &functionId) != TSDB_CODE_SUCCESS) {
2220
          return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2221
        }
dengyihao's avatar
dengyihao 已提交
2222 2223
        tscInsertPrimaryTSSourceColumn(pQueryInfo, &index);
        colIndex += 1;  // the first column is ts
H
hzcheng 已提交
2224

H
Haojun Liao 已提交
2225 2226
        pExpr = tscSqlExprAppend(pQueryInfo, functionId, &index, resultType, resultSize, getNewResColId(pQueryInfo), resultSize, false);
        addExprParams(pExpr, val, TSDB_DATA_TYPE_DOUBLE, sizeof(double));
H
hzcheng 已提交
2227
      } else {
2228
        tVariantDump(pVariant, val, TSDB_DATA_TYPE_BIGINT, true);
H
hzcheng 已提交
2229

H
Haojun Liao 已提交
2230
        int64_t nTop = GET_INT32_VAL(val);
H
hzcheng 已提交
2231
        if (nTop <= 0 || nTop > 100) {  // todo use macro
2232
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
2233 2234 2235
        }

        int16_t functionId = 0;
H
Haojun Liao 已提交
2236
        if (convertFunctionId(optr, &functionId) != TSDB_CODE_SUCCESS) {
2237
          return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2238
        }
S
slguan 已提交
2239

H
Haojun Liao 已提交
2240
        // todo REFACTOR
H
hzcheng 已提交
2241
        // set the first column ts for top/bottom query
S
slguan 已提交
2242
        SColumnIndex index1 = {0, PRIMARYKEY_TIMESTAMP_COL_INDEX};
H
Haojun Liao 已提交
2243 2244
        pExpr = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_TS, &index1, TSDB_DATA_TYPE_TIMESTAMP, TSDB_KEYSIZE, getNewResColId(pQueryInfo),
                                 TSDB_KEYSIZE, false);
H
Haojun Liao 已提交
2245
        tstrncpy(pExpr->aliasName, aAggs[TSDB_FUNC_TS].aName, sizeof(pExpr->aliasName));
S
slguan 已提交
2246

H
Haojun Liao 已提交
2247
        const int32_t TS_COLUMN_INDEX = PRIMARYKEY_TIMESTAMP_COL_INDEX;
S
slguan 已提交
2248
        SColumnList   ids = getColumnList(1, 0, TS_COLUMN_INDEX);
2249
        insertResultField(pQueryInfo, TS_COLUMN_INDEX, &ids, TSDB_KEYSIZE, TSDB_DATA_TYPE_TIMESTAMP,
H
hjxilinx 已提交
2250
                          aAggs[TSDB_FUNC_TS].aName, pExpr);
H
hzcheng 已提交
2251

2252
        colIndex += 1;  // the first column is ts
H
hzcheng 已提交
2253

H
Haojun Liao 已提交
2254 2255
        pExpr = tscSqlExprAppend(pQueryInfo, functionId, &index, resultType, resultSize, getNewResColId(pQueryInfo), resultSize, false);
        addExprParams(pExpr, val, TSDB_DATA_TYPE_BIGINT, sizeof(int64_t));
H
hzcheng 已提交
2256
      }
H
hjxilinx 已提交
2257 2258
  
      memset(pExpr->aliasName, 0, tListLen(pExpr->aliasName));
B
Bomin Zhang 已提交
2259
      getColumnName(pItem, pExpr->aliasName, sizeof(pExpr->aliasName) - 1);
H
hjxilinx 已提交
2260
  
S
slguan 已提交
2261
      SColumnList ids = getColumnList(1, 0, index.columnIndex);
H
hjxilinx 已提交
2262
      if (finalResult) {
2263
        insertResultField(pQueryInfo, colIndex, &ids, resultSize, resultType, pExpr->aliasName, pExpr);
H
hjxilinx 已提交
2264 2265
      } else {
        for (int32_t i = 0; i < ids.num; ++i) {
2266
          tscColumnListInsert(pQueryInfo->colList, &(ids.ids[i]));
H
hjxilinx 已提交
2267 2268
        }
      }
S
slguan 已提交
2269

2270 2271 2272 2273 2274
      return TSDB_CODE_SUCCESS;
    };
    
    case TK_TBID: {
      pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
weixin_48148422's avatar
weixin_48148422 已提交
2275
      if (UTIL_TABLE_IS_NORMAL_TABLE(pTableMetaInfo)) {
2276
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
2277 2278 2279 2280
      }
    
      // no parameters or more than one parameter for function
      if (pItem->pNode->pParam == NULL || pItem->pNode->pParam->nExpr != 1) {
2281
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
2282 2283 2284 2285 2286
      }
      
      tSQLExpr* pParam = pItem->pNode->pParam->a[0].pNode;
    
      SColumnIndex index = COLUMN_INDEX_INITIALIZER;
2287 2288
      if (getColumnIndexByName(pCmd, &pParam->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
2289 2290 2291 2292 2293 2294 2295
      }
    
      pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
      SSchema* pSchema = tscGetTableTagSchema(pTableMetaInfo->pTableMeta);
  
      // functions can not be applied to normal columns
      int32_t numOfCols = tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
2296
      if (index.columnIndex < numOfCols && index.columnIndex != TSDB_TBNAME_COLUMN_INDEX) {
2297
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
2298 2299
      }
    
2300 2301 2302
      if (index.columnIndex > 0) {
        index.columnIndex -= numOfCols;
      }
2303 2304
      
      // 2. valid the column type
2305 2306 2307 2308 2309 2310 2311 2312
      int16_t colType = 0;
      if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
        colType = TSDB_DATA_TYPE_BINARY;
      } else {
        colType = pSchema[index.columnIndex].type;
      }
      
      if (colType == TSDB_DATA_TYPE_BOOL) {
2313
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
2314 2315 2316 2317
      }

      tscColumnListInsert(pTableMetaInfo->tagColList, &index);
      SSchema* pTagSchema = tscGetTableTagSchema(pTableMetaInfo->pTableMeta);
2318 2319 2320
      
      SSchema s = {0};
      if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
H
Haojun Liao 已提交
2321
        s = tGetTableNameColumnSchema();
2322 2323 2324 2325
      } else {
        s = pTagSchema[index.columnIndex];
      }
      
2326 2327
      int16_t bytes = 0;
      int16_t type  = 0;
2328
      int32_t inter = 0;
2329 2330 2331 2332

      int32_t ret = getResultDataInfo(s.type, s.bytes, TSDB_FUNC_TID_TAG, 0, &type, &bytes, &inter, 0, 0);
      assert(ret == TSDB_CODE_SUCCESS);
      
S
TD-1057  
Shengliang Guan 已提交
2333
      s.type = (uint8_t)type;
2334 2335 2336 2337 2338
      s.bytes = bytes;

      TSDB_QUERY_SET_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_TAG_FILTER_QUERY);
      tscAddSpecialColumnForSelect(pQueryInfo, 0, TSDB_FUNC_TID_TAG, &index, &s, TSDB_COL_TAG);
      
S
slguan 已提交
2339
      return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
2340
    }
2341
    
H
hzcheng 已提交
2342
    default:
2343
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2344
  }
2345
  
H
hzcheng 已提交
2346 2347
}

S
slguan 已提交
2348 2349
// todo refactor
static SColumnList getColumnList(int32_t num, int16_t tableIndex, int32_t columnIndex) {
2350
  assert(num == 1 && tableIndex >= 0);
S
slguan 已提交
2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361

  SColumnList columnList = {0};
  columnList.num = num;

  int32_t index = num - 1;
  columnList.ids[index].tableIndex = tableIndex;
  columnList.ids[index].columnIndex = columnIndex;

  return columnList;
}

H
Haojun Liao 已提交
2362
void getColumnName(tSqlExprItem* pItem, char* resultFieldName, int32_t nameLength) {
H
hzcheng 已提交
2363 2364 2365
  if (pItem->aliasName != NULL) {
    strncpy(resultFieldName, pItem->aliasName, nameLength);
  } else {
S
TD-1057  
Shengliang Guan 已提交
2366
    int32_t len = ((int32_t)pItem->pNode->operand.n < nameLength) ? (int32_t)pItem->pNode->operand.n : nameLength;
H
hzcheng 已提交
2367 2368 2369 2370
    strncpy(resultFieldName, pItem->pNode->operand.z, len);
  }
}

H
Haojun Liao 已提交
2371 2372 2373
static bool isTablenameToken(SStrToken* token) {
  SStrToken tmpToken = *token;
  SStrToken tableToken = {0};
S
slguan 已提交
2374 2375 2376 2377 2378 2379

  extractTableNameFromToken(&tmpToken, &tableToken);

  return (strncasecmp(TSQL_TBNAME_L, tmpToken.z, tmpToken.n) == 0 && tmpToken.n == strlen(TSQL_TBNAME_L));
}

H
Haojun Liao 已提交
2380
static int16_t doGetColumnIndex(SQueryInfo* pQueryInfo, int32_t index, SStrToken* pToken) {
H
hjxilinx 已提交
2381
  STableMeta* pTableMeta = tscGetMetaInfo(pQueryInfo, index)->pTableMeta;
S
slguan 已提交
2382

H
hjxilinx 已提交
2383 2384
  int32_t  numOfCols = tscGetNumOfColumns(pTableMeta) + tscGetNumOfTags(pTableMeta);
  SSchema* pSchema = tscGetTableSchema(pTableMeta);
S
slguan 已提交
2385 2386 2387 2388 2389 2390 2391 2392 2393 2394

  int16_t columnIndex = COLUMN_INDEX_INITIAL_VAL;

  for (int16_t i = 0; i < numOfCols; ++i) {
    if (pToken->n != strlen(pSchema[i].name)) {
      continue;
    }

    if (strncasecmp(pSchema[i].name, pToken->z, pToken->n) == 0) {
      columnIndex = i;
H
Hui Li 已提交
2395
      break;
S
slguan 已提交
2396 2397 2398 2399 2400 2401
    }
  }

  return columnIndex;
}

H
Haojun Liao 已提交
2402
int32_t doGetColumnIndexByName(SSqlCmd* pCmd, SStrToken* pToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex) {
S
slguan 已提交
2403 2404 2405 2406 2407 2408 2409 2410 2411 2412
  const char* msg0 = "ambiguous column name";
  const char* msg1 = "invalid column name";

  if (isTablenameToken(pToken)) {
    pIndex->columnIndex = TSDB_TBNAME_COLUMN_INDEX;
  } else if (strncasecmp(pToken->z, DEFAULT_PRIMARY_TIMESTAMP_COL_NAME, pToken->n) == 0) {
    pIndex->columnIndex = PRIMARYKEY_TIMESTAMP_COL_INDEX;
  } else {
    // not specify the table name, try to locate the table index by column name
    if (pIndex->tableIndex == COLUMN_INDEX_INITIAL_VAL) {
2413 2414
      for (int16_t i = 0; i < pQueryInfo->numOfTables; ++i) {
        int16_t colIndex = doGetColumnIndex(pQueryInfo, i, pToken);
S
slguan 已提交
2415 2416 2417

        if (colIndex != COLUMN_INDEX_INITIAL_VAL) {
          if (pIndex->columnIndex != COLUMN_INDEX_INITIAL_VAL) {
2418
            return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
S
slguan 已提交
2419 2420 2421 2422 2423 2424 2425
          } else {
            pIndex->tableIndex = i;
            pIndex->columnIndex = colIndex;
          }
        }
      }
    } else {  // table index is valid, get the column index
2426
      int16_t colIndex = doGetColumnIndex(pQueryInfo, pIndex->tableIndex, pToken);
S
slguan 已提交
2427 2428 2429 2430 2431 2432
      if (colIndex != COLUMN_INDEX_INITIAL_VAL) {
        pIndex->columnIndex = colIndex;
      }
    }

    if (pIndex->columnIndex == COLUMN_INDEX_INITIAL_VAL) {
2433
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
2434 2435 2436 2437 2438 2439
    }
  }

  if (COLUMN_INDEX_VALIDE(*pIndex)) {
    return TSDB_CODE_SUCCESS;
  } else {
2440
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2441 2442 2443
  }
}

H
Haojun Liao 已提交
2444
int32_t getTableIndexImpl(SStrToken* pTableToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex) {
S
slguan 已提交
2445
  if (pTableToken->n == 0) {  // only one table and no table name prefix in column name
2446
    if (pQueryInfo->numOfTables == 1) {
S
slguan 已提交
2447
      pIndex->tableIndex = 0;
2448 2449
    } else {
      pIndex->tableIndex = COLUMN_INDEX_INITIAL_VAL;
S
slguan 已提交
2450 2451 2452 2453 2454 2455
    }

    return TSDB_CODE_SUCCESS;
  }

  pIndex->tableIndex = COLUMN_INDEX_INITIAL_VAL;
2456
  for (int32_t i = 0; i < pQueryInfo->numOfTables; ++i) {
H
hjxilinx 已提交
2457
    STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, i);
H
Haojun Liao 已提交
2458 2459
    char* name = pTableMetaInfo->aliasName;
    if (strncasecmp(name, pTableToken->z, pTableToken->n) == 0 && strlen(name) == pTableToken->n) {
S
slguan 已提交
2460 2461 2462 2463 2464 2465
      pIndex->tableIndex = i;
      break;
    }
  }

  if (pIndex->tableIndex < 0) {
2466
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2467 2468 2469 2470 2471
  }

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
2472 2473
int32_t getTableIndexByName(SStrToken* pToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex) {
  SStrToken tableToken = {0};
S
slguan 已提交
2474 2475
  extractTableNameFromToken(pToken, &tableToken);

H
hjxilinx 已提交
2476
  if (getTableIndexImpl(&tableToken, pQueryInfo, pIndex) != TSDB_CODE_SUCCESS) {
2477
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2478 2479
  }

S
slguan 已提交
2480 2481
  return TSDB_CODE_SUCCESS;
}
H
hzcheng 已提交
2482

H
Haojun Liao 已提交
2483
int32_t getColumnIndexByName(SSqlCmd* pCmd, const SStrToken* pToken, SQueryInfo* pQueryInfo, SColumnIndex* pIndex) {
H
hjxilinx 已提交
2484
  if (pQueryInfo->pTableMetaInfo == NULL || pQueryInfo->numOfTables == 0) {
2485
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2486 2487
  }

H
Haojun Liao 已提交
2488
  SStrToken tmpToken = *pToken;
S
slguan 已提交
2489

2490
  if (getTableIndexByName(&tmpToken, pQueryInfo, pIndex) != TSDB_CODE_SUCCESS) {
2491
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2492 2493
  }

2494
  return doGetColumnIndexByName(pCmd, &tmpToken, pQueryInfo, pIndex);
H
hzcheng 已提交
2495 2496
}

H
Haojun Liao 已提交
2497
int32_t convertFunctionId(int32_t optr, int16_t* functionId) {
H
hzcheng 已提交
2498 2499 2500 2501 2502 2503 2504 2505 2506 2507
  switch (optr) {
    case TK_COUNT:
      *functionId = TSDB_FUNC_COUNT;
      break;
    case TK_SUM:
      *functionId = TSDB_FUNC_SUM;
      break;
    case TK_AVG:
      *functionId = TSDB_FUNC_AVG;
      break;
L
lihui 已提交
2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525
    case TK_RATE:
      *functionId = TSDB_FUNC_RATE;
      break;
    case TK_IRATE:
      *functionId = TSDB_FUNC_IRATE;
      break;
    case TK_SUM_RATE:
      *functionId = TSDB_FUNC_SUM_RATE;
      break;
    case TK_SUM_IRATE:
      *functionId = TSDB_FUNC_SUM_IRATE;
      break;
    case TK_AVG_RATE:
      *functionId = TSDB_FUNC_AVG_RATE;
      break;
    case TK_AVG_IRATE:
      *functionId = TSDB_FUNC_AVG_IRATE;
      break;
H
hzcheng 已提交
2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561
    case TK_MIN:
      *functionId = TSDB_FUNC_MIN;
      break;
    case TK_MAX:
      *functionId = TSDB_FUNC_MAX;
      break;
    case TK_STDDEV:
      *functionId = TSDB_FUNC_STDDEV;
      break;
    case TK_PERCENTILE:
      *functionId = TSDB_FUNC_PERCT;
      break;
    case TK_APERCENTILE:
      *functionId = TSDB_FUNC_APERCT;
      break;
    case TK_FIRST:
      *functionId = TSDB_FUNC_FIRST;
      break;
    case TK_LAST:
      *functionId = TSDB_FUNC_LAST;
      break;
    case TK_LEASTSQUARES:
      *functionId = TSDB_FUNC_LEASTSQR;
      break;
    case TK_TOP:
      *functionId = TSDB_FUNC_TOP;
      break;
    case TK_BOTTOM:
      *functionId = TSDB_FUNC_BOTTOM;
      break;
    case TK_DIFF:
      *functionId = TSDB_FUNC_DIFF;
      break;
    case TK_SPREAD:
      *functionId = TSDB_FUNC_SPREAD;
      break;
S
slguan 已提交
2562 2563
    case TK_TWA:
      *functionId = TSDB_FUNC_TWA;
H
hzcheng 已提交
2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578
      break;
    case TK_INTERP:
      *functionId = TSDB_FUNC_INTERP;
      break;
    case TK_LAST_ROW:
      *functionId = TSDB_FUNC_LAST_ROW;
      break;
    default:
      return -1;
  }

  return TSDB_CODE_SUCCESS;
}

int32_t setShowInfo(SSqlObj* pSql, struct SSqlInfo* pInfo) {
S
slguan 已提交
2579
  SSqlCmd*        pCmd = &pSql->cmd;
2580
  STableMetaInfo* pTableMetaInfo = tscGetTableMetaInfoFromCmd(pCmd, pCmd->clauseIndex, 0);
2581
  assert(pCmd->numOfClause == 1);
H
hjxilinx 已提交
2582

H
hzcheng 已提交
2583 2584
  pCmd->command = TSDB_SQL_SHOW;

2585
  const char* msg1 = "invalid name";
2586
  const char* msg2 = "pattern filter string too long";
2587 2588 2589 2590
  const char* msg3 = "database name too long";
  const char* msg4 = "invalid ip address";
  const char* msg5 = "database name is empty";
  const char* msg6 = "pattern string is empty";
H
hzcheng 已提交
2591 2592 2593 2594 2595

  /*
   * database prefix in pInfo->pDCLInfo->a[0]
   * wildcard in like clause in pInfo->pDCLInfo->a[1]
   */
2596 2597 2598
  SShowInfo* pShowInfo = &pInfo->pDCLInfo->showOpt;
  int16_t    showType = pShowInfo->showType;
  if (showType == TSDB_MGMT_TABLE_TABLE || showType == TSDB_MGMT_TABLE_METRIC || showType == TSDB_MGMT_TABLE_VGROUP) {
H
hzcheng 已提交
2599
    // db prefix in tagCond, show table conds in payload
H
Haojun Liao 已提交
2600
    SStrToken* pDbPrefixToken = &pShowInfo->prefix;
2601
    if (pDbPrefixToken->type != 0) {
H
hzcheng 已提交
2602

B
Bomin Zhang 已提交
2603
      if (pDbPrefixToken->n >= TSDB_DB_NAME_LEN) {  // db name is too long
2604
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
2605 2606
      }

2607
      if (pDbPrefixToken->n <= 0) {
2608
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
2609 2610
      }

2611
      if (tscValidateName(pDbPrefixToken) != TSDB_CODE_SUCCESS) {
2612
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
2613 2614
      }

H
hjxilinx 已提交
2615
      int32_t ret = setObjFullName(pTableMetaInfo->name, getAccountId(pSql), pDbPrefixToken, NULL, NULL);
H
hzcheng 已提交
2616
      if (ret != TSDB_CODE_SUCCESS) {
2617
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
2618
      }
2619
    }
H
hzcheng 已提交
2620

2621
    // show table/stable like 'xxxx', set the like pattern for show tables
H
Haojun Liao 已提交
2622
    SStrToken* pPattern = &pShowInfo->pattern;
2623 2624
    if (pPattern->type != 0) {
      pPattern->n = strdequote(pPattern->z);
S
slguan 已提交
2625

2626
      if (pPattern->n <= 0) {
2627
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
2628
      }
H
hzcheng 已提交
2629

H
Haojun Liao 已提交
2630
      if (!tscValidateTableNameLength(pCmd->payloadLen)) {
2631
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
2632 2633
      }
    }
2634 2635
  } else if (showType == TSDB_MGMT_TABLE_VNODES) {
    if (pShowInfo->prefix.type == 0) {
2636
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "No specified ip of dnode");
L
lihui 已提交
2637 2638
    }

L
lihui 已提交
2639
    // show vnodes may be ip addr of dnode in payload
H
Haojun Liao 已提交
2640
    SStrToken* pDnodeIp = &pShowInfo->prefix;
B
Bomin Zhang 已提交
2641
    if (pDnodeIp->n >= TSDB_IPv4ADDR_LEN) {  // ip addr is too long
2642
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
2643
    }
L
lihui 已提交
2644

2645
    if (!validateIpAddress(pDnodeIp->z, pDnodeIp->n)) {
2646
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
L
lihui 已提交
2647
    }
H
hzcheng 已提交
2648 2649 2650 2651 2652
  }

  return TSDB_CODE_SUCCESS;
}

2653 2654 2655 2656
int32_t setKillInfo(SSqlObj* pSql, struct SSqlInfo* pInfo, int32_t killType) {
  const char* msg1 = "invalid connection ID";
  const char* msg2 = "invalid query ID";
  const char* msg3 = "invalid stream ID";
H
hzcheng 已提交
2657

2658 2659
  SSqlCmd* pCmd = &pSql->cmd;
  pCmd->command = pInfo->type;
2660
  
H
Haojun Liao 已提交
2661
  SStrToken* idStr = &(pInfo->pDCLInfo->ip);
2662
  if (idStr->n > TSDB_KILL_MSG_LEN) {
2663
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2664 2665
  }

2666
  strncpy(pCmd->payload, idStr->z, idStr->n);
2667

H
hzcheng 已提交
2668
  const char delim = ':';
2669 2670
  char* connIdStr = strtok(idStr->z, &delim);
  char* queryIdStr = strtok(NULL, &delim);
H
hzcheng 已提交
2671

2672 2673 2674 2675 2676
  int32_t connId = (int32_t)strtol(connIdStr, NULL, 10);
  if (connId <= 0) {
    memset(pCmd->payload, 0, strlen(pCmd->payload));
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
  }
2677

2678 2679 2680 2681 2682 2683
  if (killType == TSDB_SQL_KILL_CONNECTION) {
    return TSDB_CODE_SUCCESS;
  }

  int32_t queryId = (int32_t)strtol(queryIdStr, NULL, 10);
  if (queryId <= 0) {
sangshuduo's avatar
sangshuduo 已提交
2684
    memset(pCmd->payload, 0, strlen(pCmd->payload));
2685 2686 2687 2688 2689
    if (killType == TSDB_SQL_KILL_QUERY) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    } else {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }
H
hzcheng 已提交
2690
  }
2691
  
H
hzcheng 已提交
2692 2693 2694
  return TSDB_CODE_SUCCESS;
}

2695 2696 2697 2698 2699 2700
bool validateIpAddress(const char* ip, size_t size) {
  char tmp[128] = {0};  // buffer to build null-terminated string
  assert(size < 128);

  strncpy(tmp, ip, size);

2701
  in_addr_t epAddr = taosInetAddr(tmp);
2702

2703
  return epAddr != INADDR_NONE;
H
hzcheng 已提交
2704 2705
}

H
hjxilinx 已提交
2706
int32_t tscTansformSQLFuncForSTableQuery(SQueryInfo* pQueryInfo) {
H
hjxilinx 已提交
2707
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
S
slguan 已提交
2708

weixin_48148422's avatar
weixin_48148422 已提交
2709
  if (pTableMetaInfo->pTableMeta == NULL || !UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
2710
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
2711 2712
  }

H
hjxilinx 已提交
2713
  assert(tscGetNumOfTags(pTableMetaInfo->pTableMeta) >= 0);
H
hzcheng 已提交
2714 2715 2716

  int16_t bytes = 0;
  int16_t type = 0;
2717
  int32_t interBytes = 0;
H
hjxilinx 已提交
2718 2719 2720
  
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t k = 0; k < size; ++k) {
2721
    SSqlExpr*   pExpr = tscSqlExprGet(pQueryInfo, k);
S
slguan 已提交
2722 2723
    int16_t functionId = aAggs[pExpr->functionId].stableFuncId;

2724
    int32_t colIndex = pExpr->colInfo.colIndex;
H
hjxilinx 已提交
2725
    SSchema* pSrcSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, colIndex);
H
hjxilinx 已提交
2726
    
S
slguan 已提交
2727
    if ((functionId >= TSDB_FUNC_SUM && functionId <= TSDB_FUNC_TWA) ||
L
lihui 已提交
2728 2729
        (functionId >= TSDB_FUNC_FIRST_DST && functionId <= TSDB_FUNC_LAST_DST) ||
        (functionId >= TSDB_FUNC_RATE && functionId <= TSDB_FUNC_AVG_IRATE)) {
S
TD-1057  
Shengliang Guan 已提交
2730
      if (getResultDataInfo(pSrcSchema->type, pSrcSchema->bytes, functionId, (int32_t)pExpr->param[0].i64Key, &type, &bytes,
2731
                            &interBytes, 0, true) != TSDB_CODE_SUCCESS) {
2732
        return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
2733
      }
H
hzcheng 已提交
2734

2735
      tscSqlExprUpdate(pQueryInfo, k, functionId, pExpr->colInfo.colIndex, TSDB_DATA_TYPE_BINARY, bytes);
S
slguan 已提交
2736
      // todo refactor
2737
      pExpr->interBytes = interBytes;
H
hzcheng 已提交
2738 2739 2740
    }
  }

H
Haojun Liao 已提交
2741
  tscFieldInfoUpdateOffset(pQueryInfo);
S
slguan 已提交
2742
  return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
2743 2744 2745
}

/* transfer the field-info back to original input format */
H
hjxilinx 已提交
2746
void tscRestoreSQLFuncForSTableQuery(SQueryInfo* pQueryInfo) {
H
hjxilinx 已提交
2747
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
weixin_48148422's avatar
weixin_48148422 已提交
2748
  if (!UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
hzcheng 已提交
2749 2750
    return;
  }
H
hjxilinx 已提交
2751 2752 2753
  
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t i = 0; i < size; ++i) {
2754
    SSqlExpr*   pExpr = tscSqlExprGet(pQueryInfo, i);
2755
    SSchema* pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, pExpr->colInfo.colIndex);
H
hjxilinx 已提交
2756
    
2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773
    // the final result size and type in the same as query on single table.
    // so here, set the flag to be false;
    int32_t inter = 0;
    
    int32_t functionId = pExpr->functionId;
    if (functionId >= TSDB_FUNC_TS && functionId <= TSDB_FUNC_DIFF) {
      continue;
    }
    
    if (functionId == TSDB_FUNC_FIRST_DST) {
      functionId = TSDB_FUNC_FIRST;
    } else if (functionId == TSDB_FUNC_LAST_DST) {
      functionId = TSDB_FUNC_LAST;
    }
    
    getResultDataInfo(pSchema->type, pSchema->bytes, functionId, 0, &pExpr->resType, &pExpr->resBytes,
                      &inter, 0, false);
H
hzcheng 已提交
2774 2775 2776
  }
}

2777
bool hasUnsupportFunctionsForSTableQuery(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
S
slguan 已提交
2778
  const char* msg1 = "TWA not allowed to apply to super table directly";
H
hjxilinx 已提交
2779
  const char* msg2 = "TWA only support group by tbname for super table query";
2780
  const char* msg3 = "function not support for super table query";
H
hjxilinx 已提交
2781

S
slguan 已提交
2782
  // filter sql function not supported by metric query yet.
H
hjxilinx 已提交
2783 2784
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t i = 0; i < size; ++i) {
2785
    int32_t functionId = tscSqlExprGet(pQueryInfo, i)->functionId;
2786
    if ((aAggs[functionId].nStatus & TSDB_FUNCSTATE_STABLE) == 0) {
2787
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
2788
      return true;
H
hzcheng 已提交
2789 2790 2791
    }
  }

2792 2793
  if (tscIsTWAQuery(pQueryInfo)) {
    if (pQueryInfo->groupbyExpr.numOfGroupCols == 0) {
2794
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
2795 2796
      return true;
    }
H
hzcheng 已提交
2797

2798
    if (pQueryInfo->groupbyExpr.numOfGroupCols != 1) {
2799
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
2800
      return true;
2801 2802 2803
    } else {
      SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, 0);
      if (pColIndex->colIndex != TSDB_TBNAME_COLUMN_INDEX) {
2804
        invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
2805 2806
        return true;
      }
H
hzcheng 已提交
2807 2808
    }
  }
S
slguan 已提交
2809

H
hzcheng 已提交
2810 2811 2812
  return false;
}

H
Haojun Liao 已提交
2813
static bool functionCompatibleCheck(SQueryInfo* pQueryInfo, bool joinQuery) {
H
hzcheng 已提交
2814
  int32_t startIdx = 0;
2815 2816 2817 2818

  size_t numOfExpr = tscSqlExprNumOfExprs(pQueryInfo);
  assert(numOfExpr > 0);

H
hjxilinx 已提交
2819 2820
  SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, startIdx);
  int32_t functionID = pExpr->functionId;
S
slguan 已提交
2821 2822

  // ts function can be simultaneously used with any other functions.
H
hzcheng 已提交
2823
  if (functionID == TSDB_FUNC_TS || functionID == TSDB_FUNC_TS_DUMMY) {
S
slguan 已提交
2824
    startIdx++;
H
hzcheng 已提交
2825 2826
  }

H
Haojun Liao 已提交
2827
  int32_t factor = functionCompatList[tscSqlExprGet(pQueryInfo, startIdx)->functionId];
H
hzcheng 已提交
2828 2829 2830

  // diff function cannot be executed with other function
  // arithmetic function can be executed with other arithmetic functions
H
hjxilinx 已提交
2831 2832 2833
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  
  for (int32_t i = startIdx + 1; i < size; ++i) {
H
hjxilinx 已提交
2834
    SSqlExpr* pExpr1 = tscSqlExprGet(pQueryInfo, i);
2835

H
hjxilinx 已提交
2836
    int16_t functionId = pExpr1->functionId;
2837 2838 2839 2840
    if (functionId == TSDB_FUNC_TAGPRJ || functionId == TSDB_FUNC_TAG || functionId == TSDB_FUNC_TS) {
      continue;
    }

H
Haojun Liao 已提交
2841
    if (functionId == TSDB_FUNC_PRJ && (pExpr1->colInfo.colId == PRIMARYKEY_TIMESTAMP_COL_INDEX || TSDB_COL_IS_UD_COL(pExpr1->colInfo.flag))) {
S
slguan 已提交
2842 2843 2844
      continue;
    }

H
Haojun Liao 已提交
2845
    if (functionCompatList[functionId] != factor) {
H
hzcheng 已提交
2846
      return false;
2847 2848 2849 2850
    } else {
      if (factor == -1) { // two functions with the same -1 flag
        return false;
      }
H
hzcheng 已提交
2851
    }
H
Haojun Liao 已提交
2852 2853 2854 2855

    if (functionId == TSDB_FUNC_LAST_ROW && joinQuery) {
      return false;
    }
H
hzcheng 已提交
2856 2857 2858 2859 2860
  }

  return true;
}

H
Haojun Liao 已提交
2861
int32_t parseGroupbyClause(SQueryInfo* pQueryInfo, SArray* pList, SSqlCmd* pCmd) {
2862 2863
  const char* msg1 = "too many columns in group by clause";
  const char* msg2 = "invalid column name in group by clause";
2864
  const char* msg3 = "columns from one table allowed as group by columns";
2865
  const char* msg4 = "join query does not support group by";
S
slguan 已提交
2866 2867 2868
  const char* msg7 = "not support group by expression";
  const char* msg8 = "not allowed column type for group by";
  const char* msg9 = "tags not allowed for table query";
H
hzcheng 已提交
2869

2870
  // todo : handle two tables situation
H
hjxilinx 已提交
2871
  STableMetaInfo* pTableMetaInfo = NULL;
H
hzcheng 已提交
2872 2873 2874 2875 2876

  if (pList == NULL) {
    return TSDB_CODE_SUCCESS;
  }

2877 2878 2879 2880
  if (pQueryInfo->colList == NULL) {
    pQueryInfo->colList = taosArrayInit(4, POINTER_BYTES);
  }
  
S
Shengliang Guan 已提交
2881
  pQueryInfo->groupbyExpr.numOfGroupCols = (int16_t)taosArrayGetSize(pList);
H
Haojun Liao 已提交
2882
  if (pQueryInfo->groupbyExpr.numOfGroupCols > TSDB_MAX_TAGS) {
2883
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
2884 2885
  }

2886 2887 2888 2889
  if (pQueryInfo->numOfTables > 1) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
  }

H
hjxilinx 已提交
2890
  STableMeta* pTableMeta = NULL;
S
slguan 已提交
2891
  SSchema*    pSchema = NULL;
H
hjxilinx 已提交
2892
  SSchema     s = tscGetTbnameColumnSchema();
H
hzcheng 已提交
2893

S
slguan 已提交
2894
  int32_t tableIndex = COLUMN_INDEX_INITIAL_VAL;
H
Haojun Liao 已提交
2895 2896 2897 2898 2899 2900

  size_t num = taosArrayGetSize(pList);
  for (int32_t i = 0; i < num; ++i) {
    tVariantListItem * pItem = taosArrayGet(pList, i);
    tVariant* pVar = &pItem->pVar;

H
Haojun Liao 已提交
2901
    SStrToken token = {pVar->nLen, pVar->nType, pVar->pz};
H
hzcheng 已提交
2902

S
slguan 已提交
2903
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
2904 2905
    if (getColumnIndexByName(pCmd, &token, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
2906
    }
H
hzcheng 已提交
2907

2908 2909 2910 2911 2912
    if (tableIndex == COLUMN_INDEX_INITIAL_VAL) {
      tableIndex = index.tableIndex;
    } else if (tableIndex != index.tableIndex) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }
H
hzcheng 已提交
2913

H
hjxilinx 已提交
2914
    pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
2915
    pTableMeta = pTableMetaInfo->pTableMeta;
2916 2917
  
    int32_t numOfCols = tscGetNumOfColumns(pTableMeta);
S
slguan 已提交
2918 2919 2920
    if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
      pSchema = &s;
    } else {
H
hjxilinx 已提交
2921
      pSchema = tscGetTableColumnSchema(pTableMeta, index.columnIndex);
S
slguan 已提交
2922
    }
H
hzcheng 已提交
2923

S
slguan 已提交
2924
    bool groupTag = false;
2925
    if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX || index.columnIndex >= numOfCols) {
S
slguan 已提交
2926
      groupTag = true;
H
hzcheng 已提交
2927
    }
2928 2929 2930 2931 2932 2933
  
    SSqlGroupbyExpr* pGroupExpr = &pQueryInfo->groupbyExpr;
    if (pGroupExpr->columnInfo == NULL) {
      pGroupExpr->columnInfo = taosArrayInit(4, sizeof(SColIndex));
    }
    
S
slguan 已提交
2934
    if (groupTag) {
weixin_48148422's avatar
weixin_48148422 已提交
2935
      if (!UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
2936
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg9);
S
slguan 已提交
2937 2938
      }

2939 2940 2941 2942
      int32_t relIndex = index.columnIndex;
      if (index.columnIndex != TSDB_TBNAME_COLUMN_INDEX) {
        relIndex -= numOfCols;
      }
S
slguan 已提交
2943

H
hjxilinx 已提交
2944
      SColIndex colIndex = { .colIndex = relIndex, .flag = TSDB_COL_TAG, .colId = pSchema->colId, };
2945
      taosArrayPush(pGroupExpr->columnInfo, &colIndex);
H
hjxilinx 已提交
2946 2947 2948
      
      index.columnIndex = relIndex;
      tscColumnListInsert(pTableMetaInfo->tagColList, &index);
S
slguan 已提交
2949 2950
    } else {
      // check if the column type is valid, here only support the bool/tinyint/smallint/bigint group by
H
Haojun Liao 已提交
2951
      if (pSchema->type == TSDB_DATA_TYPE_TIMESTAMP || pSchema->type == TSDB_DATA_TYPE_FLOAT || pSchema->type == TSDB_DATA_TYPE_DOUBLE) {
2952
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg8);
S
slguan 已提交
2953 2954
      }

2955
      tscColumnListInsert(pQueryInfo->colList, &index);
2956
      
2957
      SColIndex colIndex = { .colIndex = index.columnIndex, .flag = TSDB_COL_NORMAL, .colId = pSchema->colId };
2958
      taosArrayPush(pGroupExpr->columnInfo, &colIndex);
2959
      pQueryInfo->groupbyExpr.orderType = TSDB_ORDER_ASC;
S
slguan 已提交
2960

H
Haojun Liao 已提交
2961
      if (i == 0 && num > 1) {
2962
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
S
slguan 已提交
2963
      }
H
hzcheng 已提交
2964 2965 2966
    }
  }

2967
  pQueryInfo->groupbyExpr.tableIndex = tableIndex;
H
hzcheng 已提交
2968 2969 2970
  return TSDB_CODE_SUCCESS;
}

2971
static SColumnFilterInfo* addColumnFilterInfo(SColumn* pColumn) {
S
slguan 已提交
2972 2973 2974
  if (pColumn == NULL) {
    return NULL;
  }
2975

S
slguan 已提交
2976
  int32_t size = pColumn->numOfFilters + 1;
2977 2978

  char* tmp = (char*) realloc((void*)(pColumn->filterInfo), sizeof(SColumnFilterInfo) * (size));
S
slguan 已提交
2979 2980
  if (tmp != NULL) {
    pColumn->filterInfo = (SColumnFilterInfo*)tmp;
2981 2982
  } else {
    return NULL;
2983 2984
  }

S
slguan 已提交
2985
  pColumn->numOfFilters++;
2986

S
slguan 已提交
2987 2988 2989 2990
  SColumnFilterInfo* pColFilterInfo = &pColumn->filterInfo[pColumn->numOfFilters - 1];
  memset(pColFilterInfo, 0, sizeof(SColumnFilterInfo));

  return pColFilterInfo;
2991 2992
}

2993
static int32_t doExtractColumnFilterInfo(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SColumnFilterInfo* pColumnFilter,
2994
                                         SColumnIndex* columnIndex, tSQLExpr* pExpr) {
S
slguan 已提交
2995
  const char* msg = "not supported filter condition";
H
hzcheng 已提交
2996

S
slguan 已提交
2997
  tSQLExpr*       pRight = pExpr->pRight;
H
hjxilinx 已提交
2998
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, columnIndex->tableIndex);
H
hzcheng 已提交
2999

H
hjxilinx 已提交
3000
  SSchema* pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, columnIndex->columnIndex);
H
hzcheng 已提交
3001

S
slguan 已提交
3002
  int16_t colType = pSchema->type;
3003
  if (colType >= TSDB_DATA_TYPE_TINYINT && colType <= TSDB_DATA_TYPE_BIGINT) {
H
hzcheng 已提交
3004 3005 3006
    colType = TSDB_DATA_TYPE_BIGINT;
  } else if (colType == TSDB_DATA_TYPE_FLOAT || colType == TSDB_DATA_TYPE_DOUBLE) {
    colType = TSDB_DATA_TYPE_DOUBLE;
3007
  } else if ((colType == TSDB_DATA_TYPE_TIMESTAMP) && (TSDB_DATA_TYPE_BINARY == pRight->val.nType)) {
3008
    int retVal = setColumnFilterInfoForTimestamp(pCmd, pQueryInfo, &pRight->val);
3009 3010 3011
    if (TSDB_CODE_SUCCESS != retVal) {
      return retVal;
    }
H
hzcheng 已提交
3012 3013
  }

B
Bomin Zhang 已提交
3014
  int32_t retVal = TSDB_CODE_SUCCESS;
H
hzcheng 已提交
3015
  if (pExpr->nSQLOptr == TK_LE || pExpr->nSQLOptr == TK_LT) {
B
Bomin Zhang 已提交
3016
    retVal = tVariantDump(&pRight->val, (char*)&pColumnFilter->upperBndd, colType, false);
H
hzcheng 已提交
3017

B
Bomin Zhang 已提交
3018 3019 3020 3021 3022
  // TK_GT,TK_GE,TK_EQ,TK_NE are based on the pColumn->lowerBndd
  } else if (colType == TSDB_DATA_TYPE_BINARY) {
    pColumnFilter->pz = (int64_t)calloc(1, pRight->val.nLen + TSDB_NCHAR_SIZE);
    pColumnFilter->len = pRight->val.nLen;
    retVal = tVariantDump(&pRight->val, (char*)pColumnFilter->pz, colType, false);
S
slguan 已提交
3023

B
Bomin Zhang 已提交
3024 3025 3026 3027 3028 3029
  } else if (colType == TSDB_DATA_TYPE_NCHAR) {
    // pRight->val.nLen + 1 is larger than the actual nchar string length
    pColumnFilter->pz = (int64_t)calloc(1, (pRight->val.nLen + 1) * TSDB_NCHAR_SIZE);
    retVal = tVariantDump(&pRight->val, (char*)pColumnFilter->pz, colType, false);
    size_t len = twcslen((wchar_t*)pColumnFilter->pz);
    pColumnFilter->len = len * TSDB_NCHAR_SIZE;
S
slguan 已提交
3030

B
Bomin Zhang 已提交
3031 3032
  } else {
    retVal = tVariantDump(&pRight->val, (char*)&pColumnFilter->lowerBndd, colType, false);
H
hzcheng 已提交
3033 3034
  }

B
Bomin Zhang 已提交
3035 3036 3037 3038
  if (retVal != TSDB_CODE_SUCCESS) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
  } 

H
hzcheng 已提交
3039 3040
  switch (pExpr->nSQLOptr) {
    case TK_LE:
S
slguan 已提交
3041
      pColumnFilter->upperRelOptr = TSDB_RELATION_LESS_EQUAL;
H
hzcheng 已提交
3042 3043
      break;
    case TK_LT:
S
slguan 已提交
3044
      pColumnFilter->upperRelOptr = TSDB_RELATION_LESS;
H
hzcheng 已提交
3045 3046
      break;
    case TK_GT:
3047
      pColumnFilter->lowerRelOptr = TSDB_RELATION_GREATER;
H
hzcheng 已提交
3048 3049
      break;
    case TK_GE:
3050
      pColumnFilter->lowerRelOptr = TSDB_RELATION_GREATER_EQUAL;
H
hzcheng 已提交
3051 3052
      break;
    case TK_EQ:
S
slguan 已提交
3053
      pColumnFilter->lowerRelOptr = TSDB_RELATION_EQUAL;
H
hzcheng 已提交
3054 3055
      break;
    case TK_NE:
S
slguan 已提交
3056
      pColumnFilter->lowerRelOptr = TSDB_RELATION_NOT_EQUAL;
H
hzcheng 已提交
3057 3058
      break;
    case TK_LIKE:
S
slguan 已提交
3059
      pColumnFilter->lowerRelOptr = TSDB_RELATION_LIKE;
H
hzcheng 已提交
3060
      break;
H
Haojun Liao 已提交
3061 3062 3063 3064 3065 3066
    case TK_ISNULL:
      pColumnFilter->lowerRelOptr = TSDB_RELATION_ISNULL;
      break;
    case TK_NOTNULL:
      pColumnFilter->lowerRelOptr = TSDB_RELATION_NOTNULL;
      break;
S
slguan 已提交
3067
    default:
3068
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
3069
  }
S
slguan 已提交
3070

3071
  return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
3072 3073
}

S
slguan 已提交
3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087
typedef struct SCondExpr {
  tSQLExpr* pTagCond;
  tSQLExpr* pTimewindow;

  tSQLExpr* pColumnCond;

  tSQLExpr* pTableCond;
  int16_t   relType;  // relation between table name in expression and other tag
                      // filter condition expression, TK_AND or TK_OR
  int16_t tableCondIndex;

  tSQLExpr* pJoinExpr;  // join condition
  bool      tsJoin;
} SCondExpr;
H
hzcheng 已提交
3088

H
hjxilinx 已提交
3089
static int32_t getTimeRange(STimeWindow* win, tSQLExpr* pRight, int32_t optr, int16_t timePrecision);
S
slguan 已提交
3090 3091

static int32_t tSQLExprNodeToString(tSQLExpr* pExpr, char** str) {
H
hzcheng 已提交
3092
  if (pExpr->nSQLOptr == TK_ID) {  // column name
S
slguan 已提交
3093 3094
    strncpy(*str, pExpr->colInfo.z, pExpr->colInfo.n);
    *str += pExpr->colInfo.n;
H
hzcheng 已提交
3095 3096

  } else if (pExpr->nSQLOptr >= TK_BOOL && pExpr->nSQLOptr <= TK_STRING) {  // value
S
slguan 已提交
3097 3098
    *str += tVariantToString(&pExpr->val, *str);

H
hjxilinx 已提交
3099 3100 3101 3102 3103 3104 3105
  } else if (pExpr->nSQLOptr >= TK_COUNT && pExpr->nSQLOptr <= TK_AVG_IRATE) {
    /*
     * arithmetic expression of aggregation, such as count(ts) + count(ts) *2
     */
    strncpy(*str, pExpr->operand.z, pExpr->operand.n);
    *str += pExpr->operand.n;
  } else {  // not supported operation
S
slguan 已提交
3106 3107 3108 3109 3110 3111
    assert(false);
  }

  return TSDB_CODE_SUCCESS;
}

H
Haojun Liao 已提交
3112
// pExpr->nSQLOptr == 0 while handling "is null" query
S
slguan 已提交
3113 3114
static bool isExprLeafNode(tSQLExpr* pExpr) {
  return (pExpr->pRight == NULL && pExpr->pLeft == NULL) &&
H
Haojun Liao 已提交
3115
         (pExpr->nSQLOptr == 0 || pExpr->nSQLOptr == TK_ID || (pExpr->nSQLOptr >= TK_BOOL && pExpr->nSQLOptr <= TK_NCHAR) || pExpr->nSQLOptr == TK_SET);
S
slguan 已提交
3116 3117
}

H
Haojun Liao 已提交
3118
static bool isExprDirectParentOfLeafNode(tSQLExpr* pExpr) {
S
slguan 已提交
3119 3120 3121 3122 3123
  return (pExpr->pLeft != NULL && pExpr->pRight != NULL) &&
         (isExprLeafNode(pExpr->pLeft) && isExprLeafNode(pExpr->pRight));
}

static int32_t tSQLExprLeafToString(tSQLExpr* pExpr, bool addParentheses, char** output) {
H
Haojun Liao 已提交
3124
  if (!isExprDirectParentOfLeafNode(pExpr)) {
3125
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3126 3127
  }

S
slguan 已提交
3128 3129 3130 3131 3132 3133 3134 3135 3136 3137
  tSQLExpr* pLeft = pExpr->pLeft;
  tSQLExpr* pRight = pExpr->pRight;

  if (addParentheses) {
    *(*output) = '(';
    *output += 1;
  }

  tSQLExprNodeToString(pLeft, output);
  if (optrToString(pExpr, output) != TSDB_CODE_SUCCESS) {
3138
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
3139 3140 3141 3142 3143 3144 3145 3146 3147
  }

  tSQLExprNodeToString(pRight, output);

  if (addParentheses) {
    *(*output) = ')';
    *output += 1;
  }

H
hzcheng 已提交
3148 3149 3150 3151
  return TSDB_CODE_SUCCESS;
}

static int32_t optrToString(tSQLExpr* pExpr, char** exprString) {
S
slguan 已提交
3152 3153 3154 3155
  const char* le = "<=";
  const char* ge = ">=";
  const char* ne = "<>";
  const char* likeOptr = "LIKE";
H
hzcheng 已提交
3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203

  switch (pExpr->nSQLOptr) {
    case TK_LE: {
      *(int16_t*)(*exprString) = *(int16_t*)le;
      *exprString += 1;
      break;
    }
    case TK_GE: {
      *(int16_t*)(*exprString) = *(int16_t*)ge;
      *exprString += 1;
      break;
    }
    case TK_NE: {
      *(int16_t*)(*exprString) = *(int16_t*)ne;
      *exprString += 1;
      break;
    }

    case TK_LT:
      *(*exprString) = '<';
      break;
    case TK_GT:
      *(*exprString) = '>';
      break;
    case TK_EQ:
      *(*exprString) = '=';
      break;
    case TK_PLUS:
      *(*exprString) = '+';
      break;
    case TK_MINUS:
      *(*exprString) = '-';
      break;
    case TK_STAR:
      *(*exprString) = '*';
      break;
    case TK_DIVIDE:
      *(*exprString) = '/';
      break;
    case TK_REM:
      *(*exprString) = '%';
      break;
    case TK_LIKE: {
      int32_t len = sprintf(*exprString, " %s ", likeOptr);
      *exprString += (len - 1);
      break;
    }
    default:
3204
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3205 3206 3207 3208 3209 3210 3211
  }

  *exprString += 1;

  return TSDB_CODE_SUCCESS;
}

H
hjxilinx 已提交
3212
static int32_t tablenameListToString(tSQLExpr* pExpr, SStringBuilder* sb) {
H
hzcheng 已提交
3213 3214
  tSQLExprList* pList = pExpr->pParam;
  if (pList->nExpr <= 0) {
3215
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3216 3217
  }

S
slguan 已提交
3218
  if (pList->nExpr > 0) {
H
hjxilinx 已提交
3219
    taosStringBuilderAppendStringLen(sb, QUERY_COND_REL_PREFIX_IN, QUERY_COND_REL_PREFIX_IN_LEN);
S
slguan 已提交
3220 3221
  }

H
hzcheng 已提交
3222 3223
  for (int32_t i = 0; i < pList->nExpr; ++i) {
    tSQLExpr* pSub = pList->a[i].pNode;
H
hjxilinx 已提交
3224
    taosStringBuilderAppendStringLen(sb, pSub->val.pz, pSub->val.nLen);
S
slguan 已提交
3225 3226

    if (i < pList->nExpr - 1) {
H
hjxilinx 已提交
3227
      taosStringBuilderAppendString(sb, TBNAME_LIST_SEP);
S
slguan 已提交
3228
    }
H
hzcheng 已提交
3229

H
Haojun Liao 已提交
3230
    if (pSub->val.nLen <= 0 || !tscValidateTableNameLength(pSub->val.nLen)) {
3231
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3232 3233 3234 3235 3236 3237
    }
  }

  return TSDB_CODE_SUCCESS;
}

H
hjxilinx 已提交
3238
static int32_t tablenameCondToString(tSQLExpr* pExpr, SStringBuilder* sb) {
H
hjxilinx 已提交
3239 3240
  taosStringBuilderAppendStringLen(sb, QUERY_COND_REL_PREFIX_LIKE, QUERY_COND_REL_PREFIX_LIKE_LEN);
  taosStringBuilderAppendString(sb, pExpr->val.pz);
S
slguan 已提交
3241 3242

  return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
3243 3244
}

S
slguan 已提交
3245 3246 3247 3248 3249 3250
enum {
  TSQL_EXPR_TS = 0,
  TSQL_EXPR_TAG = 1,
  TSQL_EXPR_COLUMN = 2,
  TSQL_EXPR_TBNAME = 3,
};
H
hzcheng 已提交
3251

3252
static int32_t extractColumnFilterInfo(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SColumnIndex* pIndex, tSQLExpr* pExpr, int32_t sqlOptr) {
H
hjxilinx 已提交
3253
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, pIndex->tableIndex);
S
slguan 已提交
3254

H
hjxilinx 已提交
3255 3256
  STableMeta* pTableMeta = pTableMetaInfo->pTableMeta;
  SSchema*    pSchema = tscGetTableColumnSchema(pTableMeta, pIndex->columnIndex);
H
hzcheng 已提交
3257

S
slguan 已提交
3258
  const char* msg1 = "non binary column not support like operator";
H
Hui Li 已提交
3259 3260
  const char* msg2 = "binary column not support this operator";  
  const char* msg3 = "bool column not support this operator";
S
slguan 已提交
3261

H
hjxilinx 已提交
3262
  SColumn* pColumn = tscColumnListInsert(pQueryInfo->colList, pIndex);
S
slguan 已提交
3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275
  SColumnFilterInfo* pColFilter = NULL;

  /*
   * in case of TK_AND filter condition, we first find the corresponding column and build the query condition together
   * the already existed condition.
   */
  if (sqlOptr == TK_AND) {
    // this is a new filter condition on this column
    if (pColumn->numOfFilters == 0) {
      pColFilter = addColumnFilterInfo(pColumn);
    } else {  // update the existed column filter information, find the filter info here
      pColFilter = &pColumn->filterInfo[0];
    }
3276 3277 3278 3279

    if (pColFilter == NULL) {
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
    }
S
slguan 已提交
3280 3281 3282
  } else if (sqlOptr == TK_OR) {
    // TODO fixme: failed to invalid the filter expression: "col1 = 1 OR col2 = 2"
    pColFilter = addColumnFilterInfo(pColumn);
3283 3284 3285
    if (pColFilter == NULL) {
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
    }
S
slguan 已提交
3286
  } else {  // error;
3287
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
3288 3289
  }

3290
  pColFilter->filterstr =
S
slguan 已提交
3291 3292
      ((pSchema->type == TSDB_DATA_TYPE_BINARY || pSchema->type == TSDB_DATA_TYPE_NCHAR) ? 1 : 0);

3293
  if (pColFilter->filterstr) {
3294 3295 3296 3297 3298 3299
    if (pExpr->nSQLOptr != TK_EQ
      && pExpr->nSQLOptr != TK_NE
      && pExpr->nSQLOptr != TK_ISNULL
      && pExpr->nSQLOptr != TK_NOTNULL
      && pExpr->nSQLOptr != TK_LIKE
      ) {
3300
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
3301
    }
S
slguan 已提交
3302 3303
  } else {
    if (pExpr->nSQLOptr == TK_LIKE) {
3304
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
3305
    }
H
Hui Li 已提交
3306 3307 3308
    
    if (pSchema->type == TSDB_DATA_TYPE_BOOL) {
      if (pExpr->nSQLOptr != TK_EQ && pExpr->nSQLOptr != TK_NE) {
3309
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
Hui Li 已提交
3310 3311
      }
    }
S
slguan 已提交
3312 3313 3314
  }

  pColumn->colIndex = *pIndex;
3315
  return doExtractColumnFilterInfo(pCmd, pQueryInfo, pColFilter, pIndex, pExpr);
S
slguan 已提交
3316 3317
}

3318
static void relToString(tSQLExpr* pExpr, char** str) {
S
slguan 已提交
3319 3320 3321 3322 3323
  assert(pExpr->nSQLOptr == TK_AND || pExpr->nSQLOptr == TK_OR);

  const char* or = "OR";
  const char*and = "AND";

3324
  //    if (pQueryInfo->tagCond.relType == TSQL_STABLE_QTYPE_COND) {
S
slguan 已提交
3325 3326 3327 3328 3329 3330 3331 3332 3333
  if (pExpr->nSQLOptr == TK_AND) {
    strcpy(*str, and);
    *str += strlen(and);
  } else {
    strcpy(*str, or);
    *str += strlen(or);
  }
}

3334
UNUSED_FUNC
3335
static int32_t getTagCondString(tSQLExpr* pExpr, char** str) {
S
slguan 已提交
3336 3337 3338 3339
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
3340
  if (!isExprDirectParentOfLeafNode(pExpr)) {
S
slguan 已提交
3341 3342
    *(*str) = '(';
    *str += 1;
H
hzcheng 已提交
3343

3344
    int32_t ret = getTagCondString(pExpr->pLeft, str);
H
hzcheng 已提交
3345
    if (ret != TSDB_CODE_SUCCESS) {
S
slguan 已提交
3346
      return ret;
H
hzcheng 已提交
3347
    }
S
slguan 已提交
3348

3349
    relToString(pExpr, str);
S
slguan 已提交
3350

3351
    ret = getTagCondString(pExpr->pRight, str);
S
slguan 已提交
3352 3353 3354 3355

    *(*str) = ')';
    *str += 1;

H
hzcheng 已提交
3356 3357 3358
    return ret;
  }

S
slguan 已提交
3359 3360 3361
  return tSQLExprLeafToString(pExpr, true, str);
}

3362
static int32_t getTablenameCond(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr* pTableCond, SStringBuilder* sb) {
S
slguan 已提交
3363 3364 3365 3366
  const char* msg0 = "invalid table name list";

  if (pTableCond == NULL) {
    return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
3367 3368
  }

S
slguan 已提交
3369 3370
  tSQLExpr* pLeft = pTableCond->pLeft;
  tSQLExpr* pRight = pTableCond->pRight;
H
hzcheng 已提交
3371

S
slguan 已提交
3372
  if (!isTablenameToken(&pLeft->colInfo)) {
3373
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3374 3375
  }

S
slguan 已提交
3376
  int32_t ret = TSDB_CODE_SUCCESS;
H
hzcheng 已提交
3377

S
slguan 已提交
3378
  if (pTableCond->nSQLOptr == TK_IN) {
H
hjxilinx 已提交
3379
    ret = tablenameListToString(pRight, sb);
S
slguan 已提交
3380
  } else if (pTableCond->nSQLOptr == TK_LIKE) {
H
hjxilinx 已提交
3381
    ret = tablenameCondToString(pRight, sb);
S
slguan 已提交
3382
  }
H
hzcheng 已提交
3383

S
slguan 已提交
3384
  if (ret != TSDB_CODE_SUCCESS) {
3385
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
S
slguan 已提交
3386
  }
H
hzcheng 已提交
3387

S
slguan 已提交
3388 3389 3390
  return ret;
}

3391
static int32_t getColumnQueryCondInfo(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr* pExpr, int32_t relOptr) {
S
slguan 已提交
3392 3393 3394 3395
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
3396
  if (!isExprDirectParentOfLeafNode(pExpr)) {  // internal node
3397
    int32_t ret = getColumnQueryCondInfo(pCmd, pQueryInfo, pExpr->pLeft, pExpr->nSQLOptr);
S
slguan 已提交
3398 3399 3400 3401
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }

3402
    return getColumnQueryCondInfo(pCmd, pQueryInfo, pExpr->pRight, pExpr->nSQLOptr);
S
slguan 已提交
3403 3404
  } else {  // handle leaf node
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
3405
    if (getColumnIndexByName(pCmd, &pExpr->pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
3406
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3407
    }
S
slguan 已提交
3408

3409
    return extractColumnFilterInfo(pCmd, pQueryInfo, &index, pExpr, relOptr);
H
hzcheng 已提交
3410
  }
S
slguan 已提交
3411
}
H
hzcheng 已提交
3412

3413
static int32_t getJoinCondInfo(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr* pExpr) {
H
Haojun Liao 已提交
3414 3415 3416
  const char* msg1 = "invalid join query condition";
  const char* msg3 = "type of join columns must be identical";
  const char* msg4 = "invalid column name in join condition";
H
hzcheng 已提交
3417

S
slguan 已提交
3418 3419 3420
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }
H
hzcheng 已提交
3421

H
Haojun Liao 已提交
3422
  if (!isExprDirectParentOfLeafNode(pExpr)) {
3423
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
3424 3425
  }

3426
  STagCond*  pTagCond = &pQueryInfo->tagCond;
S
slguan 已提交
3427 3428 3429 3430
  SJoinNode* pLeft = &pTagCond->joinInfo.left;
  SJoinNode* pRight = &pTagCond->joinInfo.right;

  SColumnIndex index = COLUMN_INDEX_INITIALIZER;
3431 3432
  if (getColumnIndexByName(pCmd, &pExpr->pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
3433 3434
  }

H
hjxilinx 已提交
3435
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
Haojun Liao 已提交
3436
  SSchema* pTagSchema1 = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, index.columnIndex);
S
slguan 已提交
3437

3438
  pLeft->uid = pTableMetaInfo->pTableMeta->id.uid;
H
Haojun Liao 已提交
3439
  pLeft->tagColId = pTagSchema1->colId;
H
hjxilinx 已提交
3440
  strcpy(pLeft->tableId, pTableMetaInfo->name);
S
slguan 已提交
3441 3442

  index = (SColumnIndex)COLUMN_INDEX_INITIALIZER;
3443 3444
  if (getColumnIndexByName(pCmd, &pExpr->pRight->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
3445 3446
  }

H
hjxilinx 已提交
3447
  pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
Haojun Liao 已提交
3448
  SSchema* pTagSchema2 = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, index.columnIndex);
S
slguan 已提交
3449

3450
  pRight->uid = pTableMetaInfo->pTableMeta->id.uid;
H
Haojun Liao 已提交
3451
  pRight->tagColId = pTagSchema2->colId;
H
hjxilinx 已提交
3452
  strcpy(pRight->tableId, pTableMetaInfo->name);
S
slguan 已提交
3453

H
Haojun Liao 已提交
3454
  if (pTagSchema1->type != pTagSchema2->type) {
3455
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
Haojun Liao 已提交
3456 3457
  }

S
slguan 已提交
3458
  pTagCond->joinInfo.hasJoin = true;
H
hzcheng 已提交
3459 3460 3461 3462
  return TSDB_CODE_SUCCESS;
}

// todo error handle / such as and /or mixed with +/-/*/
3463
int32_t doArithmeticExprToString(tSQLExpr* pExpr, char** exprString) {
H
hzcheng 已提交
3464 3465 3466
  tSQLExpr* pLeft = pExpr->pLeft;
  tSQLExpr* pRight = pExpr->pRight;

H
hjxilinx 已提交
3467
  *(*exprString)++ = '(';
H
hzcheng 已提交
3468 3469

  if (pLeft->nSQLOptr >= TK_PLUS && pLeft->nSQLOptr <= TK_REM) {
3470
    doArithmeticExprToString(pLeft, exprString);
H
hzcheng 已提交
3471
  } else {
S
slguan 已提交
3472
    int32_t ret = tSQLExprNodeToString(pLeft, exprString);
H
hzcheng 已提交
3473
    if (ret != TSDB_CODE_SUCCESS) {
3474
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3475 3476 3477 3478 3479 3480
    }
  }

  optrToString(pExpr, exprString);

  if (pRight->nSQLOptr >= TK_PLUS && pRight->nSQLOptr <= TK_REM) {
3481
    doArithmeticExprToString(pRight, exprString);
H
hzcheng 已提交
3482
  } else {
S
slguan 已提交
3483
    int32_t ret = tSQLExprNodeToString(pRight, exprString);
H
hzcheng 已提交
3484
    if (ret != TSDB_CODE_SUCCESS) {
3485
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3486 3487 3488
    }
  }

H
hjxilinx 已提交
3489
  *(*exprString)++ = ')';
H
hzcheng 已提交
3490 3491 3492 3493

  return TSDB_CODE_SUCCESS;
}

3494 3495
static int32_t validateSQLExpr(SSqlCmd* pCmd, tSQLExpr* pExpr, SQueryInfo* pQueryInfo, SColumnList* pList,
    int32_t* type, uint64_t* uid) {
H
hzcheng 已提交
3496
  if (pExpr->nSQLOptr == TK_ID) {
H
hjxilinx 已提交
3497 3498 3499
    if (*type == NON_ARITHMEIC_EXPR) {
      *type = NORMAL_ARITHMETIC;
    } else if (*type == AGG_ARIGHTMEIC) {
3500
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3501
    }
L
lihui 已提交
3502

H
hjxilinx 已提交
3503
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
3504
    if (getColumnIndexByName(pCmd, &pExpr->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
3505
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3506 3507 3508
    }

    // if column is timestamp, bool, binary, nchar, not support arithmetic, so return invalid sql
H
hjxilinx 已提交
3509
    STableMeta* pTableMeta = tscGetMetaInfo(pQueryInfo, index.tableIndex)->pTableMeta;
H
hjxilinx 已提交
3510 3511
    SSchema*    pSchema = tscGetTableSchema(pTableMeta) + index.columnIndex;
    
H
hjxilinx 已提交
3512 3513
    if ((pSchema->type == TSDB_DATA_TYPE_TIMESTAMP) || (pSchema->type == TSDB_DATA_TYPE_BOOL) ||
        (pSchema->type == TSDB_DATA_TYPE_BINARY) || (pSchema->type == TSDB_DATA_TYPE_NCHAR)) {
3514
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3515 3516 3517
    }

    pList->ids[pList->num++] = index;
H
hzcheng 已提交
3518
  } else if (pExpr->nSQLOptr == TK_FLOAT && (isnan(pExpr->val.dKey) || isinf(pExpr->val.dKey))) {
3519
    return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3520 3521 3522 3523
  } else if (pExpr->nSQLOptr >= TK_COUNT && pExpr->nSQLOptr <= TK_AVG_IRATE) {
    if (*type == NON_ARITHMEIC_EXPR) {
      *type = AGG_ARIGHTMEIC;
    } else if (*type == NORMAL_ARITHMETIC) {
3524
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3525 3526
    }

S
TD-1057  
Shengliang Guan 已提交
3527
    int32_t outputIndex = (int32_t)tscSqlExprNumOfExprs(pQueryInfo);
H
hjxilinx 已提交
3528
  
H
Haojun Liao 已提交
3529
    tSqlExprItem item = {.pNode = pExpr, .aliasName = NULL};
H
hjxilinx 已提交
3530
  
H
Haojun Liao 已提交
3531 3532
    // sql function list in selection clause.
    // Append the sqlExpr into exprList of pQueryInfo structure sequentially
3533
    if (addExprAndResultField(pCmd, pQueryInfo, outputIndex, &item, false) != TSDB_CODE_SUCCESS) {
3534
      return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
3535
    }
H
Haojun Liao 已提交
3536 3537 3538 3539 3540 3541 3542 3543

    // It is invalid in case of more than one sqlExpr, such as first(ts, k) - last(ts, k)
    int32_t inc = (int32_t) tscSqlExprNumOfExprs(pQueryInfo) - outputIndex;
    if (inc > 1) {
      return TSDB_CODE_TSC_INVALID_SQL;
    }

    // Not supported data type in arithmetic expression
3544
    uint64_t id = -1;
H
Haojun Liao 已提交
3545 3546 3547 3548 3549 3550
    for(int32_t i = 0; i < inc; ++i) {
      SSqlExpr* p1 = tscSqlExprGet(pQueryInfo, i + outputIndex);
      int16_t t = p1->resType;
      if (t == TSDB_DATA_TYPE_BINARY || t == TSDB_DATA_TYPE_NCHAR || t == TSDB_DATA_TYPE_BOOL || t == TSDB_DATA_TYPE_TIMESTAMP) {
        return TSDB_CODE_TSC_INVALID_SQL;
      }
3551 3552 3553

      if (i == 0) {
        id = p1->uid;
H
Haojun Liao 已提交
3554
      } else if (id != p1->uid) {
3555 3556
        return TSDB_CODE_TSC_INVALID_SQL;
      }
H
Haojun Liao 已提交
3557
    }
3558 3559

    *uid = id;
H
hzcheng 已提交
3560 3561 3562 3563 3564
  }

  return TSDB_CODE_SUCCESS;
}

3565
static int32_t validateArithmeticSQLExpr(SSqlCmd* pCmd, tSQLExpr* pExpr, SQueryInfo* pQueryInfo, SColumnList* pList, int32_t* type) {
H
hzcheng 已提交
3566 3567 3568 3569 3570
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

  tSQLExpr* pLeft = pExpr->pLeft;
3571 3572 3573
  uint64_t uidLeft = 0;
  uint64_t uidRight = 0;

H
hzcheng 已提交
3574
  if (pLeft->nSQLOptr >= TK_PLUS && pLeft->nSQLOptr <= TK_REM) {
3575
    int32_t ret = validateArithmeticSQLExpr(pCmd, pLeft, pQueryInfo, pList, type);
H
hzcheng 已提交
3576 3577 3578 3579
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
  } else {
3580
    int32_t ret = validateSQLExpr(pCmd, pLeft, pQueryInfo, pList, type, &uidLeft);
H
hzcheng 已提交
3581 3582 3583 3584 3585 3586 3587
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
  }

  tSQLExpr* pRight = pExpr->pRight;
  if (pRight->nSQLOptr >= TK_PLUS && pRight->nSQLOptr <= TK_REM) {
3588
    int32_t ret = validateArithmeticSQLExpr(pCmd, pRight, pQueryInfo, pList, type);
H
hzcheng 已提交
3589 3590 3591 3592
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
  } else {
3593
    int32_t ret = validateSQLExpr(pCmd, pRight, pQueryInfo, pList, type, &uidRight);
H
hzcheng 已提交
3594 3595 3596
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
3597 3598

    // the expression not from the same table, return error
3599
    if (uidLeft != uidRight && uidLeft != 0 && uidRight != 0) {
3600 3601
      return TSDB_CODE_TSC_INVALID_SQL;
    }
H
hzcheng 已提交
3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613
  }

  return TSDB_CODE_SUCCESS;
}

static bool isValidExpr(tSQLExpr* pLeft, tSQLExpr* pRight, int32_t optr) {
  if (pLeft == NULL || (pRight == NULL && optr != TK_IN)) {
    return false;
  }

  /*
   * filter illegal expression in where clause:
S
slguan 已提交
3614 3615 3616
   * 1. count(*) > 12
   * 2. sum(columnA) > sum(columnB)
   * 3. 4 < 5,  'ABC'>'abc'
H
hzcheng 已提交
3617 3618 3619
   *
   * However, columnA < 4+12 is valid
   */
B
Bomin Zhang 已提交
3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635
  if (pLeft->nSQLOptr >= TK_COUNT && pLeft->nSQLOptr <= TK_AVG_IRATE) {
    return false;
  }

  if (pRight == NULL) {
    return true;
  }

  if (pRight->nSQLOptr >= TK_COUNT && pRight->nSQLOptr <= TK_AVG_IRATE) {
    return false;
  }
  
  if (pLeft->nSQLOptr >= TK_BOOL
    && pLeft->nSQLOptr <= TK_BINARY
    && pRight->nSQLOptr >= TK_BOOL
    && pRight->nSQLOptr <= TK_BINARY) {
H
hzcheng 已提交
3636 3637 3638 3639 3640 3641
    return false;
  }

  return true;
}

S
slguan 已提交
3642 3643 3644
static void exchangeExpr(tSQLExpr* pExpr) {
  tSQLExpr* pLeft = pExpr->pLeft;
  tSQLExpr* pRight = pExpr->pRight;
H
hzcheng 已提交
3645

S
slguan 已提交
3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670
  if (pRight->nSQLOptr == TK_ID && (pLeft->nSQLOptr == TK_INTEGER || pLeft->nSQLOptr == TK_FLOAT ||
                                    pLeft->nSQLOptr == TK_STRING || pLeft->nSQLOptr == TK_BOOL)) {
    /*
     * exchange value of the left handside and the value of the right-handside
     * to make sure that the value of filter expression always locates in
     * right-handside and
     * the column-id is at the left handside.
     */
    uint32_t optr = 0;
    switch (pExpr->nSQLOptr) {
      case TK_LE:
        optr = TK_GE;
        break;
      case TK_LT:
        optr = TK_GT;
        break;
      case TK_GT:
        optr = TK_LT;
        break;
      case TK_GE:
        optr = TK_LE;
        break;
      default:
        optr = pExpr->nSQLOptr;
    }
H
hzcheng 已提交
3671

S
slguan 已提交
3672 3673 3674 3675 3676
    pExpr->nSQLOptr = optr;
    SWAP(pExpr->pLeft, pExpr->pRight, void*);
  }
}

3677
static bool validateJoinExprNode(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr* pExpr, SColumnIndex* pLeftIndex) {
S
slguan 已提交
3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690
  const char* msg1 = "illegal column name";
  const char* msg2 = "= is expected in join expression";
  const char* msg3 = "join column must have same type";
  const char* msg4 = "self join is not allowed";
  const char* msg5 = "join table must be the same type(table to table, super table to super table)";

  tSQLExpr* pRight = pExpr->pRight;

  if (pRight->nSQLOptr != TK_ID) {
    return true;
  }

  if (pExpr->nSQLOptr != TK_EQ) {
3691
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
3692 3693 3694 3695 3696
    return false;
  }

  SColumnIndex rightIndex = COLUMN_INDEX_INITIALIZER;

3697 3698
  if (getColumnIndexByName(pCmd, &pRight->colInfo, pQueryInfo, &rightIndex) != TSDB_CODE_SUCCESS) {
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
3699
    return false;
H
hzcheng 已提交
3700 3701
  }

S
slguan 已提交
3702
  // todo extract function
H
hjxilinx 已提交
3703
  STableMetaInfo* pLeftMeterMeta = tscGetMetaInfo(pQueryInfo, pLeftIndex->tableIndex);
H
hjxilinx 已提交
3704
  SSchema*        pLeftSchema = tscGetTableSchema(pLeftMeterMeta->pTableMeta);
S
slguan 已提交
3705 3706
  int16_t         leftType = pLeftSchema[pLeftIndex->columnIndex].type;

H
hjxilinx 已提交
3707
  STableMetaInfo* pRightMeterMeta = tscGetMetaInfo(pQueryInfo, rightIndex.tableIndex);
H
hjxilinx 已提交
3708
  SSchema*        pRightSchema = tscGetTableSchema(pRightMeterMeta->pTableMeta);
S
slguan 已提交
3709 3710 3711
  int16_t         rightType = pRightSchema[rightIndex.columnIndex].type;

  if (leftType != rightType) {
3712
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
3713 3714
    return false;
  } else if (pLeftIndex->tableIndex == rightIndex.tableIndex) {
3715
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
3716
    return false;
H
hzcheng 已提交
3717 3718
  }

S
slguan 已提交
3719
  // table to table/ super table to super table are allowed
weixin_48148422's avatar
weixin_48148422 已提交
3720
  if (UTIL_TABLE_IS_SUPER_TABLE(pLeftMeterMeta) != UTIL_TABLE_IS_SUPER_TABLE(pRightMeterMeta)) {
3721
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
S
slguan 已提交
3722 3723
    return false;
  }
H
hzcheng 已提交
3724

S
slguan 已提交
3725 3726
  return true;
}
H
hzcheng 已提交
3727

S
slguan 已提交
3728 3729 3730 3731 3732 3733
static bool validTableNameOptr(tSQLExpr* pExpr) {
  const char nameFilterOptr[] = {TK_IN, TK_LIKE};

  for (int32_t i = 0; i < tListLen(nameFilterOptr); ++i) {
    if (pExpr->nSQLOptr == nameFilterOptr[i]) {
      return true;
H
hzcheng 已提交
3734 3735 3736
    }
  }

S
slguan 已提交
3737
  return false;
H
hzcheng 已提交
3738 3739
}

3740
static int32_t setExprToCond(tSQLExpr** parent, tSQLExpr* pExpr, const char* msg, int32_t parentOptr, char* msgBuf) {
S
slguan 已提交
3741 3742
  if (*parent != NULL) {
    if (parentOptr == TK_OR && msg != NULL) {
3743
      return invalidSqlErrMsg(msgBuf, msg);
S
slguan 已提交
3744
    }
H
hzcheng 已提交
3745

H
Haojun Liao 已提交
3746
    *parent = tSqlExprCreate((*parent), pExpr, parentOptr);
S
slguan 已提交
3747 3748 3749
  } else {
    *parent = pExpr;
  }
H
hzcheng 已提交
3750

S
slguan 已提交
3751 3752
  return TSDB_CODE_SUCCESS;
}
H
hzcheng 已提交
3753

3754 3755
static int32_t handleExprInQueryCond(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr** pExpr, SCondExpr* pCondExpr,
                                     int32_t* type, int32_t parentOptr) {
3756
  const char* msg1 = "table query cannot use tags filter";
S
slguan 已提交
3757 3758 3759
  const char* msg2 = "illegal column name";
  const char* msg3 = "only one query time range allowed";
  const char* msg4 = "only one join condition allowed";
H
hjxilinx 已提交
3760 3761 3762
  const char* msg5 = "not support ordinary column join";
  const char* msg6 = "only one query condition on tbname allowed";
  const char* msg7 = "only in/like allowed in filter table name";
3763 3764
  const char* msg8 = "wildcard string should be less than 20 characters";
  
S
slguan 已提交
3765 3766
  tSQLExpr* pLeft = (*pExpr)->pLeft;
  tSQLExpr* pRight = (*pExpr)->pRight;
H
hzcheng 已提交
3767

S
slguan 已提交
3768 3769 3770
  int32_t ret = TSDB_CODE_SUCCESS;

  SColumnIndex index = COLUMN_INDEX_INITIALIZER;
3771 3772
  if (getColumnIndexByName(pCmd, &pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
3773 3774
  }

H
Haojun Liao 已提交
3775
  assert(isExprDirectParentOfLeafNode(*pExpr));
S
slguan 已提交
3776

H
hjxilinx 已提交
3777
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
3778
  STableMeta*     pTableMeta = pTableMetaInfo->pTableMeta;
S
slguan 已提交
3779 3780

  if (index.columnIndex == PRIMARYKEY_TIMESTAMP_COL_INDEX) {  // query on time range
3781
    if (!validateJoinExprNode(pCmd, pQueryInfo, *pExpr, &index)) {
3782
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3783
    }
S
slguan 已提交
3784 3785 3786

    // set join query condition
    if (pRight->nSQLOptr == TK_ID) {  // no need to keep the timestamp join condition
H
hjxilinx 已提交
3787
      TSDB_QUERY_SET_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_JOIN_QUERY);
S
slguan 已提交
3788 3789 3790 3791 3792 3793
      pCondExpr->tsJoin = true;

      /*
       * to release expression, e.g., m1.ts = m2.ts,
       * since this expression is used to set the join query type
       */
H
Haojun Liao 已提交
3794
      tSqlExprDestroy(*pExpr);
S
slguan 已提交
3795
    } else {
3796
      ret = setExprToCond(&pCondExpr->pTimewindow, *pExpr, msg3, parentOptr, pQueryInfo->msg);
S
slguan 已提交
3797 3798 3799 3800
    }

    *pExpr = NULL;  // remove this expression
    *type = TSQL_EXPR_TS;
3801 3802
  } else if (index.columnIndex >= tscGetNumOfColumns(pTableMeta) || index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
    // query on tags, check for tag query condition
weixin_48148422's avatar
weixin_48148422 已提交
3803
    if (UTIL_TABLE_IS_NORMAL_TABLE(pTableMetaInfo)) {
3804
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
3805 3806 3807 3808 3809
    }

    // check for like expression
    if ((*pExpr)->nSQLOptr == TK_LIKE) {
      if (pRight->val.nLen > TSDB_PATTERN_STRING_MAX_LEN) {
3810
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg8);
S
slguan 已提交
3811 3812
      }

H
hjxilinx 已提交
3813
      SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
3814 3815 3816

      if ((!isTablenameToken(&pLeft->colInfo)) && pSchema[index.columnIndex].type != TSDB_DATA_TYPE_BINARY &&
          pSchema[index.columnIndex].type != TSDB_DATA_TYPE_NCHAR) {
3817
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
3818 3819 3820
      }
    }

H
Haojun Liao 已提交
3821
    // in case of in operator, keep it in a seprate attribute
S
slguan 已提交
3822 3823
    if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
      if (!validTableNameOptr(*pExpr)) {
3824
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
S
slguan 已提交
3825
      }
3826 3827
  
      if (!UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
3828
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
3829
      }
S
slguan 已提交
3830 3831 3832 3833 3834 3835

      if (pCondExpr->pTableCond == NULL) {
        pCondExpr->pTableCond = *pExpr;
        pCondExpr->relType = parentOptr;
        pCondExpr->tableCondIndex = index.tableIndex;
      } else {
3836
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
S
slguan 已提交
3837 3838 3839 3840 3841
      }

      *type = TSQL_EXPR_TBNAME;
      *pExpr = NULL;
    } else {
H
Haojun Liao 已提交
3842
      if (pRight != NULL && pRight->nSQLOptr == TK_ID) {  // join on tag columns for stable query
3843
        if (!validateJoinExprNode(pCmd, pQueryInfo, *pExpr, &index)) {
3844
          return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
3845 3846 3847
        }

        if (pCondExpr->pJoinExpr != NULL) {
3848
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
3849 3850
        }

3851 3852
        pQueryInfo->type |= TSDB_QUERY_TYPE_JOIN_QUERY;
        ret = setExprToCond(&pCondExpr->pJoinExpr, *pExpr, NULL, parentOptr, pQueryInfo->msg);
S
slguan 已提交
3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866
        *pExpr = NULL;
      } else {
        // do nothing
        //                ret = setExprToCond(pCmd, &pCondExpr->pTagCond,
        //                *pExpr, NULL, parentOptr);
      }

      *type = TSQL_EXPR_TAG;
    }

  } else {  // query on other columns
    *type = TSQL_EXPR_COLUMN;

    if (pRight->nSQLOptr == TK_ID) {  // other column cannot be served as the join column
3867
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
3868 3869
    }

3870
    ret = setExprToCond(&pCondExpr->pColumnCond, *pExpr, NULL, parentOptr, pQueryInfo->msg);
S
slguan 已提交
3871 3872
    *pExpr = NULL;  // remove it from expr tree
  }
H
hzcheng 已提交
3873

S
slguan 已提交
3874
  return ret;
H
hzcheng 已提交
3875 3876
}

3877 3878
int32_t getQueryCondExpr(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr** pExpr, SCondExpr* pCondExpr,
                        int32_t* type, int32_t parentOptr) {
H
hzcheng 已提交
3879 3880 3881 3882
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

S
slguan 已提交
3883
  const char* msg1 = "query condition between different columns must use 'AND'";
H
hzcheng 已提交
3884

S
slguan 已提交
3885 3886 3887 3888
  tSQLExpr* pLeft = (*pExpr)->pLeft;
  tSQLExpr* pRight = (*pExpr)->pRight;

  if (!isValidExpr(pLeft, pRight, (*pExpr)->nSQLOptr)) {
3889
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
3890 3891
  }

S
slguan 已提交
3892 3893
  int32_t leftType = -1;
  int32_t rightType = -1;
H
hzcheng 已提交
3894

H
Haojun Liao 已提交
3895
  if (!isExprDirectParentOfLeafNode(*pExpr)) {
3896
    int32_t ret = getQueryCondExpr(pCmd, pQueryInfo, &(*pExpr)->pLeft, pCondExpr, &leftType, (*pExpr)->nSQLOptr);
H
hzcheng 已提交
3897 3898 3899 3900
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }

3901
    ret = getQueryCondExpr(pCmd, pQueryInfo, &(*pExpr)->pRight, pCondExpr, &rightType, (*pExpr)->nSQLOptr);
S
slguan 已提交
3902 3903 3904
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
H
hzcheng 已提交
3905

S
slguan 已提交
3906 3907 3908 3909 3910 3911
    /*
     *  if left child and right child do not belong to the same group, the sub
     *  expression is not valid for parent node, it must be TK_AND operator.
     */
    if (leftType != rightType) {
      if ((*pExpr)->nSQLOptr == TK_OR && (leftType + rightType != TSQL_EXPR_TBNAME + TSQL_EXPR_TAG)) {
3912
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
3913
      }
H
hzcheng 已提交
3914 3915
    }

S
slguan 已提交
3916 3917 3918
    *type = rightType;
    return TSDB_CODE_SUCCESS;
  }
H
hzcheng 已提交
3919

S
slguan 已提交
3920
  exchangeExpr(*pExpr);
H
hzcheng 已提交
3921

3922
  return handleExprInQueryCond(pCmd, pQueryInfo, pExpr, pCondExpr, type, parentOptr);
S
slguan 已提交
3923
}
H
hzcheng 已提交
3924

S
slguan 已提交
3925
static void doCompactQueryExpr(tSQLExpr** pExpr) {
3926
  if (*pExpr == NULL || isExprDirectParentOfLeafNode(*pExpr)) {
S
slguan 已提交
3927 3928
    return;
  }
H
hzcheng 已提交
3929

S
slguan 已提交
3930 3931 3932
  if ((*pExpr)->pLeft) {
    doCompactQueryExpr(&(*pExpr)->pLeft);
  }
H
hzcheng 已提交
3933

S
slguan 已提交
3934 3935 3936
  if ((*pExpr)->pRight) {
    doCompactQueryExpr(&(*pExpr)->pRight);
  }
H
hzcheng 已提交
3937

S
slguan 已提交
3938 3939
  if ((*pExpr)->pLeft == NULL && (*pExpr)->pRight == NULL &&
      ((*pExpr)->nSQLOptr == TK_OR || (*pExpr)->nSQLOptr == TK_AND)) {
H
Haojun Liao 已提交
3940
    tSqlExprNodeDestroy(*pExpr);
S
slguan 已提交
3941
    *pExpr = NULL;
H
hzcheng 已提交
3942

S
slguan 已提交
3943 3944
  } else if ((*pExpr)->pLeft == NULL && (*pExpr)->pRight != NULL) {
    tSQLExpr* tmpPtr = (*pExpr)->pRight;
H
Haojun Liao 已提交
3945
    tSqlExprNodeDestroy(*pExpr);
H
hzcheng 已提交
3946

S
slguan 已提交
3947 3948 3949
    (*pExpr) = tmpPtr;
  } else if ((*pExpr)->pRight == NULL && (*pExpr)->pLeft != NULL) {
    tSQLExpr* tmpPtr = (*pExpr)->pLeft;
H
Haojun Liao 已提交
3950
    tSqlExprNodeDestroy(*pExpr);
H
hzcheng 已提交
3951

S
slguan 已提交
3952
    (*pExpr) = tmpPtr;
H
hzcheng 已提交
3953
  }
S
slguan 已提交
3954
}
H
hzcheng 已提交
3955

3956
static void doExtractExprForSTable(SSqlCmd* pCmd, tSQLExpr** pExpr, SQueryInfo* pQueryInfo, tSQLExpr** pOut, int32_t tableIndex) {
H
Haojun Liao 已提交
3957
  if (isExprDirectParentOfLeafNode(*pExpr)) {
S
slguan 已提交
3958 3959 3960
    tSQLExpr* pLeft = (*pExpr)->pLeft;

    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
3961
    if (getColumnIndexByName(pCmd, &pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
3962
      return;
H
hzcheng 已提交
3963 3964
    }

S
slguan 已提交
3965 3966 3967 3968 3969 3970 3971 3972
    if (index.tableIndex != tableIndex) {
      return;
    }

    *pOut = *pExpr;
    (*pExpr) = NULL;

  } else {
H
Haojun Liao 已提交
3973
    *pOut = tSqlExprCreate(NULL, NULL, (*pExpr)->nSQLOptr);
S
slguan 已提交
3974

3975 3976
    doExtractExprForSTable(pCmd, &(*pExpr)->pLeft, pQueryInfo, &((*pOut)->pLeft), tableIndex);
    doExtractExprForSTable(pCmd, &(*pExpr)->pRight, pQueryInfo, &((*pOut)->pRight), tableIndex);
S
slguan 已提交
3977 3978 3979
  }
}

3980
static tSQLExpr* extractExprForSTable(SSqlCmd* pCmd, tSQLExpr** pExpr, SQueryInfo* pQueryInfo, int32_t tableIndex) {
S
slguan 已提交
3981
  tSQLExpr* pResExpr = NULL;
H
hzcheng 已提交
3982

S
slguan 已提交
3983
  if (*pExpr != NULL) {
3984
    doExtractExprForSTable(pCmd, pExpr, pQueryInfo, &pResExpr, tableIndex);
S
slguan 已提交
3985
    doCompactQueryExpr(&pResExpr);
H
hzcheng 已提交
3986 3987
  }

S
slguan 已提交
3988
  return pResExpr;
H
hzcheng 已提交
3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003
}

int tableNameCompar(const void* lhs, const void* rhs) {
  char* left = *(char**)lhs;
  char* right = *(char**)rhs;

  int32_t ret = strcmp(left, right);

  if (ret == 0) {
    return 0;
  }

  return ret > 0 ? 1 : -1;
}

4004 4005
static int32_t setTableCondForSTableQuery(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, const char* account,
                                          tSQLExpr* pExpr, int16_t tableCondIndex, SStringBuilder* sb) {
4006
  const char* msg = "table name too long";
H
hzcheng 已提交
4007

S
slguan 已提交
4008 4009 4010 4011
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

H
hjxilinx 已提交
4012
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, tableCondIndex);
S
slguan 已提交
4013

4014
  STagCond* pTagCond = &pQueryInfo->tagCond;
4015
  pTagCond->tbnameCond.uid = pTableMetaInfo->pTableMeta->id.uid;
S
slguan 已提交
4016 4017 4018 4019

  assert(pExpr->nSQLOptr == TK_LIKE || pExpr->nSQLOptr == TK_IN);

  if (pExpr->nSQLOptr == TK_LIKE) {
H
hjxilinx 已提交
4020
    char* str = taosStringBuilderGetResult(sb, NULL);
4021
    pQueryInfo->tagCond.tbnameCond.cond = strdup(str);
S
slguan 已提交
4022 4023 4024
    return TSDB_CODE_SUCCESS;
  }

S
Shuduo Sang 已提交
4025
  SStringBuilder sb1; memset(&sb1, 0, sizeof(sb1));
H
hjxilinx 已提交
4026
  taosStringBuilderAppendStringLen(&sb1, QUERY_COND_REL_PREFIX_IN, QUERY_COND_REL_PREFIX_IN_LEN);
H
hzcheng 已提交
4027

H
Haojun Liao 已提交
4028
  char db[TSDB_TABLE_FNAME_LEN] = {0};
H
hzcheng 已提交
4029

S
slguan 已提交
4030
  // remove the duplicated input table names
H
hzcheng 已提交
4031
  int32_t num = 0;
H
hjxilinx 已提交
4032 4033 4034
  char*   tableNameString = taosStringBuilderGetResult(sb, NULL);

  char** segments = strsplit(tableNameString + QUERY_COND_REL_PREFIX_IN_LEN, TBNAME_LIST_SEP, &num);
H
hjxilinx 已提交
4035
  qsort(segments, num, POINTER_BYTES, tableNameCompar);
H
hzcheng 已提交
4036 4037 4038 4039 4040 4041 4042 4043 4044

  int32_t j = 1;
  for (int32_t i = 1; i < num; ++i) {
    if (strcmp(segments[i], segments[i - 1]) != 0) {
      segments[j++] = segments[i];
    }
  }
  num = j;

H
hjxilinx 已提交
4045
  char* name = extractDBName(pTableMetaInfo->name, db);
H
Haojun Liao 已提交
4046
  SStrToken dbToken = { .type = TK_STRING, .z = name, .n = (uint32_t)strlen(name) };
H
hjxilinx 已提交
4047
  
H
hzcheng 已提交
4048 4049
  for (int32_t i = 0; i < num; ++i) {
    if (i >= 1) {
H
hjxilinx 已提交
4050
      taosStringBuilderAppendStringLen(&sb1, TBNAME_LIST_SEP, 1);
H
hzcheng 已提交
4051
    }
H
hjxilinx 已提交
4052

H
Haojun Liao 已提交
4053
    char      idBuf[TSDB_TABLE_FNAME_LEN] = {0};
S
TD-1057  
Shengliang Guan 已提交
4054
    int32_t   xlen = (int32_t)strlen(segments[i]);
H
Haojun Liao 已提交
4055
    SStrToken t = {.z = segments[i], .n = xlen, .type = TK_STRING};
H
hzcheng 已提交
4056

4057
    int32_t ret = setObjFullName(idBuf, account, &dbToken, &t, &xlen);
H
hzcheng 已提交
4058
    if (ret != TSDB_CODE_SUCCESS) {
H
hjxilinx 已提交
4059
      taosStringBuilderDestroy(&sb1);
S
TD-1848  
Shengliang Guan 已提交
4060
      tfree(segments);
H
hjxilinx 已提交
4061

4062
      invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
4063 4064
      return ret;
    }
H
hjxilinx 已提交
4065

H
hjxilinx 已提交
4066
    taosStringBuilderAppendString(&sb1, idBuf);
H
hzcheng 已提交
4067
  }
H
hjxilinx 已提交
4068

H
hjxilinx 已提交
4069
  char* str = taosStringBuilderGetResult(&sb1, NULL);
4070
  pQueryInfo->tagCond.tbnameCond.cond = strdup(str);
H
hjxilinx 已提交
4071

H
hjxilinx 已提交
4072
  taosStringBuilderDestroy(&sb1);
S
TD-1848  
Shengliang Guan 已提交
4073
  tfree(segments);
H
hzcheng 已提交
4074 4075 4076
  return TSDB_CODE_SUCCESS;
}

4077
static bool validateFilterExpr(SQueryInfo* pQueryInfo) {
4078 4079 4080 4081 4082 4083
  SArray* pColList = pQueryInfo->colList;
  
  size_t num = taosArrayGetSize(pColList);
  
  for (int32_t i = 0; i < num; ++i) {
    SColumn* pCol = taosArrayGetP(pColList, i);
4084

4085 4086
    for (int32_t j = 0; j < pCol->numOfFilters; ++j) {
      SColumnFilterInfo* pColFilter = &pCol->filterInfo[j];
S
slguan 已提交
4087 4088
      int32_t            lowerOptr = pColFilter->lowerRelOptr;
      int32_t            upperOptr = pColFilter->upperRelOptr;
4089

4090
      if ((lowerOptr == TSDB_RELATION_GREATER_EQUAL || lowerOptr == TSDB_RELATION_GREATER) &&
4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104
          (upperOptr == TSDB_RELATION_LESS_EQUAL || upperOptr == TSDB_RELATION_LESS)) {
        continue;
      }

      // there must be at least two range, not support yet.
      if (lowerOptr * upperOptr != TSDB_RELATION_INVALID) {
        return false;
      }
    }
  }

  return true;
}

4105
static int32_t getTimeRangeFromExpr(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, tSQLExpr* pExpr) {
S
slguan 已提交
4106 4107
  const char* msg0 = "invalid timestamp";
  const char* msg1 = "only one time stamp window allowed";
H
hzcheng 已提交
4108 4109 4110 4111 4112

  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
4113
  if (!isExprDirectParentOfLeafNode(pExpr)) {
S
slguan 已提交
4114
    if (pExpr->nSQLOptr == TK_OR) {
4115
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
4116
    }
H
hzcheng 已提交
4117

4118
    getTimeRangeFromExpr(pCmd, pQueryInfo, pExpr->pLeft);
S
slguan 已提交
4119

4120
    return getTimeRangeFromExpr(pCmd, pQueryInfo, pExpr->pRight);
S
slguan 已提交
4121 4122
  } else {
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
4123
    if (getColumnIndexByName(pCmd, &pExpr->pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
4124
      return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
4125 4126
    }

H
hjxilinx 已提交
4127
    STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
4128
    STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);
H
hjxilinx 已提交
4129
    
S
slguan 已提交
4130 4131
    tSQLExpr* pRight = pExpr->pRight;

H
hjxilinx 已提交
4132 4133
    STimeWindow win = {.skey = INT64_MIN, .ekey = INT64_MAX};
    if (getTimeRange(&win, pRight, pExpr->nSQLOptr, tinfo.precision) != TSDB_CODE_SUCCESS) {
4134
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
S
slguan 已提交
4135 4136 4137
    }

    // update the timestamp query range
H
hjxilinx 已提交
4138 4139
    if (pQueryInfo->window.skey < win.skey) {
      pQueryInfo->window.skey = win.skey;
S
slguan 已提交
4140 4141
    }

H
hjxilinx 已提交
4142 4143
    if (pQueryInfo->window.ekey > win.ekey) {
      pQueryInfo->window.ekey = win.ekey;
S
slguan 已提交
4144 4145 4146 4147 4148 4149
    }
  }

  return TSDB_CODE_SUCCESS;
}

4150
static int32_t validateJoinExpr(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SCondExpr* pCondExpr) {
S
slguan 已提交
4151 4152 4153 4154
  const char* msg1 = "super table join requires tags column";
  const char* msg2 = "timestamp join condition missing";
  const char* msg3 = "condition missing for join query";

4155 4156
  if (!QUERY_IS_JOIN_QUERY(pQueryInfo->type)) {
    if (pQueryInfo->numOfTables == 1) {
S
slguan 已提交
4157 4158
      return TSDB_CODE_SUCCESS;
    } else {
4159
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
4160 4161 4162
    }
  }

H
hjxilinx 已提交
4163
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
weixin_48148422's avatar
weixin_48148422 已提交
4164
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {  // for stable join, tag columns
4165
                                                   // must be present for join
S
slguan 已提交
4166
    if (pCondExpr->pJoinExpr == NULL) {
4167
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
4168 4169 4170 4171
    }
  }

  if (!pCondExpr->tsJoin) {
4172
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4173 4174
  }

S
slguan 已提交
4175 4176 4177 4178 4179
  return TSDB_CODE_SUCCESS;
}

static void cleanQueryExpr(SCondExpr* pCondExpr) {
  if (pCondExpr->pTableCond) {
H
Haojun Liao 已提交
4180
    tSqlExprDestroy(pCondExpr->pTableCond);
S
slguan 已提交
4181 4182 4183
  }

  if (pCondExpr->pTagCond) {
H
Haojun Liao 已提交
4184
    tSqlExprDestroy(pCondExpr->pTagCond);
S
slguan 已提交
4185 4186 4187
  }

  if (pCondExpr->pColumnCond) {
H
Haojun Liao 已提交
4188
    tSqlExprDestroy(pCondExpr->pColumnCond);
S
slguan 已提交
4189 4190 4191
  }

  if (pCondExpr->pTimewindow) {
H
Haojun Liao 已提交
4192
    tSqlExprDestroy(pCondExpr->pTimewindow);
S
slguan 已提交
4193 4194 4195
  }

  if (pCondExpr->pJoinExpr) {
H
Haojun Liao 已提交
4196
    tSqlExprDestroy(pCondExpr->pJoinExpr);
S
slguan 已提交
4197 4198 4199
  }
}

4200
static void doAddJoinTagsColumnsIntoTagList(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SCondExpr* pCondExpr) {
H
hjxilinx 已提交
4201
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
weixin_48148422's avatar
weixin_48148422 已提交
4202
  if (QUERY_IS_JOIN_QUERY(pQueryInfo->type) && UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
Haojun Liao 已提交
4203
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
H
hjxilinx 已提交
4204

4205
    if (getColumnIndexByName(pCmd, &pCondExpr->pJoinExpr->pLeft->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
B
Bomin Zhang 已提交
4206 4207
      tscError("%p: invalid column name (left)", pQueryInfo);
    }
H
hjxilinx 已提交
4208
    pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
4209 4210
  
    index.columnIndex = index.columnIndex - tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
H
hjxilinx 已提交
4211 4212
    tscColumnListInsert(pTableMetaInfo->tagColList, &index);
  
4213
    if (getColumnIndexByName(pCmd, &pCondExpr->pJoinExpr->pRight->colInfo, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
B
Bomin Zhang 已提交
4214 4215
      tscError("%p: invalid column name (right)", pQueryInfo);
    }
H
hjxilinx 已提交
4216
    pTableMetaInfo = tscGetMetaInfo(pQueryInfo, index.tableIndex);
H
hjxilinx 已提交
4217 4218
  
    index.columnIndex = index.columnIndex - tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
H
hjxilinx 已提交
4219
    tscColumnListInsert(pTableMetaInfo->tagColList, &index);
S
slguan 已提交
4220
  }
H
hjxilinx 已提交
4221
}
S
slguan 已提交
4222

4223
static int32_t getTagQueryCondExpr(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SCondExpr* pCondExpr, tSQLExpr** pExpr) {
H
hjxilinx 已提交
4224
  int32_t ret = TSDB_CODE_SUCCESS;
H
hjxilinx 已提交
4225

4226 4227 4228 4229 4230
  if (pCondExpr->pTagCond == NULL) {
    return ret;
  }
  
  for (int32_t i = 0; i < pQueryInfo->numOfTables; ++i) {
4231
    tSQLExpr* p1 = extractExprForSTable(pCmd, pExpr, pQueryInfo, i);
H
Haojun Liao 已提交
4232 4233 4234 4235
    if (p1 == NULL) {  // no query condition on this table
      continue;
    }

4236
    tExprNode* p = NULL;
4237 4238
  
    SArray* colList = taosArrayInit(10, sizeof(SColIndex));
H
Haojun Liao 已提交
4239
    ret = exprTreeFromSqlExpr(pCmd, &p, p1, pQueryInfo, colList, NULL);
4240 4241 4242 4243 4244 4245 4246 4247 4248
    SBufferWriter bw = tbufInitWriter(NULL, false);

    TRY(0) {
      exprTreeToBinary(&bw, p);
    } CATCH(code) {
      tbufCloseWriter(&bw);
      UNUSED(code);
      // TODO: more error handling
    } END_TRY
4249
    
4250 4251
    // add to source column list
    STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, i);
4252
    int64_t uid = pTableMetaInfo->pTableMeta->id.uid;
4253 4254 4255 4256 4257 4258
    int32_t numOfCols = tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
    
    size_t num = taosArrayGetSize(colList);
    for(int32_t j = 0; j < num; ++j) {
      SColIndex* pIndex = taosArrayGet(colList, j);
      SColumnIndex index = {.tableIndex = i, .columnIndex = pIndex->colIndex - numOfCols};
H
hjxilinx 已提交
4259
      tscColumnListInsert(pTableMetaInfo->tagColList, &index);
4260 4261
    }
    
4262
    tsSetSTableQueryCond(&pQueryInfo->tagCond, uid, &bw);
4263
    doCompactQueryExpr(pExpr);
H
Haojun Liao 已提交
4264 4265

    tSqlExprDestroy(p1);
4266
    tExprTreeDestroy(&p, NULL);
4267 4268
    
    taosArrayDestroy(colList);
H
Haojun Liao 已提交
4269
    if (pQueryInfo->tagCond.pCond != NULL && taosArrayGetSize(pQueryInfo->tagCond.pCond) > 0 && !UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
Haojun Liao 已提交
4270 4271
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "filter on tag not supported for normal table");
    }
H
hjxilinx 已提交
4272
  }
H
hjxilinx 已提交
4273

4274
  pCondExpr->pTagCond = NULL;
S
slguan 已提交
4275 4276
  return ret;
}
H
Haojun Liao 已提交
4277

4278
int32_t parseWhereClause(SQueryInfo* pQueryInfo, tSQLExpr** pExpr, SSqlObj* pSql) {
H
hjxilinx 已提交
4279 4280 4281
  if (pExpr == NULL) {
    return TSDB_CODE_SUCCESS;
  }
H
hjxilinx 已提交
4282

H
hjxilinx 已提交
4283
  const char* msg1 = "invalid expression";
H
hjxilinx 已提交
4284
  const char* msg2 = "invalid filter expression";
H
hjxilinx 已提交
4285

H
hjxilinx 已提交
4286
  int32_t ret = TSDB_CODE_SUCCESS;
S
slguan 已提交
4287

H
hjxilinx 已提交
4288
  // tags query condition may be larger than 512bytes, therefore, we need to prepare enough large space
S
Shuduo Sang 已提交
4289
  SStringBuilder sb; memset(&sb, 0, sizeof(sb));
H
hjxilinx 已提交
4290
  SCondExpr      condExpr = {0};
S
slguan 已提交
4291

H
hjxilinx 已提交
4292
  if ((*pExpr)->pLeft == NULL || (*pExpr)->pRight == NULL) {
4293
    return invalidSqlErrMsg(tscGetErrorMsgPayload(&pSql->cmd), msg1);
S
slguan 已提交
4294 4295
  }

H
hjxilinx 已提交
4296
  int32_t type = 0;
4297
  if ((ret = getQueryCondExpr(&pSql->cmd, pQueryInfo, pExpr, &condExpr, &type, (*pExpr)->nSQLOptr)) != TSDB_CODE_SUCCESS) {
H
hjxilinx 已提交
4298 4299
    return ret;
  }
H
hjxilinx 已提交
4300

S
slguan 已提交
4301
  doCompactQueryExpr(pExpr);
H
hjxilinx 已提交
4302

S
slguan 已提交
4303
  // after expression compact, the expression tree is only include tag query condition
H
hjxilinx 已提交
4304
  condExpr.pTagCond = (*pExpr);
H
hjxilinx 已提交
4305

S
slguan 已提交
4306
  // 1. check if it is a join query
4307
  if ((ret = validateJoinExpr(&pSql->cmd, pQueryInfo, &condExpr)) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
4308 4309
    return ret;
  }
H
hjxilinx 已提交
4310

S
slguan 已提交
4311
  // 2. get the query time range
4312
  if ((ret = getTimeRangeFromExpr(&pSql->cmd, pQueryInfo, condExpr.pTimewindow)) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
4313 4314
    return ret;
  }
H
hjxilinx 已提交
4315

S
slguan 已提交
4316
  // 3. get the tag query condition
4317
  if ((ret = getTagQueryCondExpr(&pSql->cmd, pQueryInfo, &condExpr, pExpr)) != TSDB_CODE_SUCCESS) {
H
hjxilinx 已提交
4318
    return ret;
S
slguan 已提交
4319
  }
H
hjxilinx 已提交
4320

S
slguan 已提交
4321
  // 4. get the table name query condition
4322
  if ((ret = getTablenameCond(&pSql->cmd, pQueryInfo, condExpr.pTableCond, &sb)) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
4323 4324
    return ret;
  }
H
hjxilinx 已提交
4325

S
slguan 已提交
4326
  // 5. other column query condition
4327
  if ((ret = getColumnQueryCondInfo(&pSql->cmd, pQueryInfo, condExpr.pColumnCond, TK_AND)) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
4328 4329
    return ret;
  }
H
hjxilinx 已提交
4330

S
slguan 已提交
4331
  // 6. join condition
4332
  if ((ret = getJoinCondInfo(&pSql->cmd, pQueryInfo, condExpr.pJoinExpr)) != TSDB_CODE_SUCCESS) {
S
slguan 已提交
4333
    return ret;
H
hzcheng 已提交
4334
  }
H
hjxilinx 已提交
4335

S
slguan 已提交
4336
  // 7. query condition for table name
4337
  pQueryInfo->tagCond.relType = (condExpr.relType == TK_AND) ? TSDB_RELATION_AND : TSDB_RELATION_OR;
H
hjxilinx 已提交
4338

4339
  ret = setTableCondForSTableQuery(&pSql->cmd, pQueryInfo, getAccountId(pSql), condExpr.pTableCond, condExpr.tableCondIndex, &sb);
H
hjxilinx 已提交
4340
  taosStringBuilderDestroy(&sb);
H
hjxilinx 已提交
4341

4342
  if (!validateFilterExpr(pQueryInfo)) {
4343
    return invalidSqlErrMsg(tscGetErrorMsgPayload(&pSql->cmd), msg2);
4344
  }
H
hjxilinx 已提交
4345

4346
  doAddJoinTagsColumnsIntoTagList(&pSql->cmd, pQueryInfo, &condExpr);
H
hjxilinx 已提交
4347

H
hjxilinx 已提交
4348
  cleanQueryExpr(&condExpr);
H
hzcheng 已提交
4349 4350 4351
  return ret;
}

H
hjxilinx 已提交
4352
int32_t getTimeRange(STimeWindow* win, tSQLExpr* pRight, int32_t optr, int16_t timePrecision) {
S
slguan 已提交
4353 4354 4355 4356 4357
  // this is join condition, do nothing
  if (pRight->nSQLOptr == TK_ID) {
    return TSDB_CODE_SUCCESS;
  }

S
slguan 已提交
4358 4359
  /*
   * filter primary ts filter expression like:
S
slguan 已提交
4360
   * where ts in ('2015-12-12 4:8:12')
S
slguan 已提交
4361 4362
   */
  if (pRight->nSQLOptr == TK_SET || optr == TK_IN) {
4363
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
4364
  }
H
hzcheng 已提交
4365 4366 4367 4368

  int64_t val = 0;
  bool    parsed = false;
  if (pRight->val.nType == TSDB_DATA_TYPE_BINARY) {
S
slguan 已提交
4369 4370
    pRight->val.nLen = strdequote(pRight->val.pz);

S
slguan 已提交
4371
    char* seg = strnchr(pRight->val.pz, '-', pRight->val.nLen, false);
H
hzcheng 已提交
4372
    if (seg != NULL) {
dengyihao's avatar
dengyihao 已提交
4373
      if (taosParseTime(pRight->val.pz, &val, pRight->val.nLen, TSDB_TIME_PRECISION_MICRO, tsDaylight) == TSDB_CODE_SUCCESS) {
H
hzcheng 已提交
4374 4375
        parsed = true;
      } else {
4376
        return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4377
      }
S
slguan 已提交
4378
    } else {
H
Haojun Liao 已提交
4379
      SStrToken token = {.z = pRight->val.pz, .n = pRight->val.nLen, .type = TK_ID};
S
slguan 已提交
4380 4381 4382
      int32_t   len = tSQLGetToken(pRight->val.pz, &token.type);

      if ((token.type != TK_INTEGER && token.type != TK_FLOAT) || len != pRight->val.nLen) {
4383
        return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
4384
      }
H
hzcheng 已提交
4385 4386 4387 4388
    }
  } else if (pRight->nSQLOptr == TK_INTEGER && timePrecision == TSDB_TIME_PRECISION_MILLI) {
    /*
     * if the pRight->nSQLOptr == TK_INTEGER/TK_FLOAT, the value is adaptive, we
S
slguan 已提交
4389
     * need the time precision in metermeta to transfer the value in MICROSECOND
H
hzcheng 已提交
4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404
     *
     * Additional check to avoid data overflow
     */
    if (pRight->val.i64Key <= INT64_MAX / 1000) {
      pRight->val.i64Key *= 1000;
    }
  } else if (pRight->nSQLOptr == TK_FLOAT && timePrecision == TSDB_TIME_PRECISION_MILLI) {
    pRight->val.dKey *= 1000;
  }

  if (!parsed) {
    /*
     * failed to parse timestamp in regular formation, try next
     * it may be a epoch time in string format
     */
4405
    tVariantDump(&pRight->val, (char*)&val, TSDB_DATA_TYPE_BIGINT, true);
H
hzcheng 已提交
4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426

    /*
     * transfer it into MICROSECOND format if it is a string, since for
     * TK_INTEGER/TK_FLOAT the value has been transferred
     *
     * additional check to avoid data overflow
     */
    if (pRight->nSQLOptr == TK_STRING && timePrecision == TSDB_TIME_PRECISION_MILLI) {
      if (val <= INT64_MAX / 1000) {
        val *= 1000;
      }
    }
  }

  int32_t delta = 1;
  /* for millisecond, delta is 1ms=1000us */
  if (timePrecision == TSDB_TIME_PRECISION_MILLI) {
    delta *= 1000;
  }

  if (optr == TK_LE) {
H
hjxilinx 已提交
4427
    win->ekey = val;
H
hzcheng 已提交
4428
  } else if (optr == TK_LT) {
H
hjxilinx 已提交
4429
    win->ekey = val - delta;
H
hzcheng 已提交
4430
  } else if (optr == TK_GT) {
H
hjxilinx 已提交
4431
    win->skey = val + delta;
H
hzcheng 已提交
4432
  } else if (optr == TK_GE) {
H
hjxilinx 已提交
4433
    win->skey = val;
H
hzcheng 已提交
4434
  } else if (optr == TK_EQ) {
H
hjxilinx 已提交
4435
    win->ekey = win->skey = val;
H
hzcheng 已提交
4436 4437 4438 4439
  }
  return TSDB_CODE_SUCCESS;
}

H
hjxilinx 已提交
4440
// todo error !!!!
4441
int32_t tsRewriteFieldNameIfNecessary(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
S
slguan 已提交
4442 4443
  const char rep[] = {'(', ')', '*', ',', '.', '/', '\\', '+', '-', '%', ' '};

H
hjxilinx 已提交
4444 4445
  for (int32_t i = 0; i < pQueryInfo->fieldsInfo.numOfOutput; ++i) {
    char* fieldName = tscFieldInfoGetField(&pQueryInfo->fieldsInfo, i)->name;
B
Bomin Zhang 已提交
4446
    for (int32_t j = 0; j < (TSDB_COL_NAME_LEN - 1) && fieldName[j] != 0; ++j) {
S
slguan 已提交
4447 4448 4449 4450 4451
      for (int32_t k = 0; k < tListLen(rep); ++k) {
        if (fieldName[j] == rep[k]) {
          fieldName[j] = '_';
          break;
        }
H
hzcheng 已提交
4452 4453
      }
    }
S
slguan 已提交
4454

H
hzcheng 已提交
4455 4456 4457 4458
    fieldName[TSDB_COL_NAME_LEN - 1] = 0;
  }

  // the column name may be identical, here check again
H
hjxilinx 已提交
4459 4460 4461
  for (int32_t i = 0; i < pQueryInfo->fieldsInfo.numOfOutput; ++i) {
    char* fieldName = tscFieldInfoGetField(&pQueryInfo->fieldsInfo, i)->name;
    for (int32_t j = i + 1; j < pQueryInfo->fieldsInfo.numOfOutput; ++j) {
B
Bomin Zhang 已提交
4462
      if (strncasecmp(fieldName, tscFieldInfoGetField(&pQueryInfo->fieldsInfo, j)->name, (TSDB_COL_NAME_LEN - 1)) == 0) {
4463
        const char* msg = "duplicated column name in new table";
4464
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
4465 4466 4467 4468 4469 4470 4471
      }
    }
  }

  return TSDB_CODE_SUCCESS;
}

4472
int32_t parseFillClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySQL) {
H
Haojun Liao 已提交
4473 4474
  SArray*     pFillToken = pQuerySQL->fillType;
  tVariantListItem* pItem = taosArrayGet(pFillToken, 0);
H
hzcheng 已提交
4475 4476

  const int32_t START_INTERPO_COL_IDX = 1;
4477 4478 4479 4480

  const char* msg = "illegal value or data overflow";
  const char* msg1 = "value is expected";
  const char* msg2 = "invalid fill option";
H
hzcheng 已提交
4481 4482

  if (pItem->pVar.nType != TSDB_DATA_TYPE_BINARY) {
4483
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4484
  }
H
hjxilinx 已提交
4485
  
H
Haojun Liao 已提交
4486
  size_t size = tscNumOfFields(pQueryInfo);
H
hjxilinx 已提交
4487
  
4488 4489 4490
  if (pQueryInfo->fillVal == NULL) {
    pQueryInfo->fillVal = calloc(size, sizeof(int64_t));
    if (pQueryInfo->fillVal == NULL) {
4491
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
4492 4493 4494
    }
  }

H
hzcheng 已提交
4495
  if (strncasecmp(pItem->pVar.pz, "none", 4) == 0 && pItem->pVar.nLen == 4) {
4496
    pQueryInfo->fillType = TSDB_FILL_NONE;
H
hzcheng 已提交
4497
  } else if (strncasecmp(pItem->pVar.pz, "null", 4) == 0 && pItem->pVar.nLen == 4) {
4498
    pQueryInfo->fillType = TSDB_FILL_NULL;
H
hjxilinx 已提交
4499
    for (int32_t i = START_INTERPO_COL_IDX; i < size; ++i) {
H
Haojun Liao 已提交
4500 4501
      TAOS_FIELD* pField = tscFieldInfoGetField(&pQueryInfo->fieldsInfo, i);
      setNull((char*)&pQueryInfo->fillVal[i], pField->type, pField->bytes);
H
hzcheng 已提交
4502 4503
    }
  } else if (strncasecmp(pItem->pVar.pz, "prev", 4) == 0 && pItem->pVar.nLen == 4) {
4504
    pQueryInfo->fillType = TSDB_FILL_PREV;
H
hzcheng 已提交
4505
  } else if (strncasecmp(pItem->pVar.pz, "linear", 6) == 0 && pItem->pVar.nLen == 6) {
4506
    pQueryInfo->fillType = TSDB_FILL_LINEAR;
H
hzcheng 已提交
4507
  } else if (strncasecmp(pItem->pVar.pz, "value", 5) == 0 && pItem->pVar.nLen == 5) {
4508
    pQueryInfo->fillType = TSDB_FILL_SET_VALUE;
H
hzcheng 已提交
4509

H
Haojun Liao 已提交
4510 4511
    size_t num = taosArrayGetSize(pFillToken);
    if (num == 1) {
4512
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
4513 4514 4515
    }

    int32_t startPos = 1;
S
Shengliang Guan 已提交
4516
    int32_t numOfFillVal = (int32_t)(num - 1);
H
hzcheng 已提交
4517 4518

    /* for point interpolation query, we do not have the timestamp column */
4519
    if (tscIsPointInterpQuery(pQueryInfo)) {
H
hzcheng 已提交
4520 4521
      startPos = 0;

H
hjxilinx 已提交
4522
      if (numOfFillVal > size) {
S
TD-1057  
Shengliang Guan 已提交
4523
        numOfFillVal = (int32_t)size;
H
hzcheng 已提交
4524 4525
      }
    } else {
S
Shengliang Guan 已提交
4526
      numOfFillVal = (int16_t)((num >  (int32_t)size) ? (int32_t)size : num);
H
hzcheng 已提交
4527 4528 4529 4530 4531
    }

    int32_t j = 1;

    for (int32_t i = startPos; i < numOfFillVal; ++i, ++j) {
H
Haojun Liao 已提交
4532
      TAOS_FIELD* pField = tscFieldInfoGetField(&pQueryInfo->fieldsInfo, i);
H
hjxilinx 已提交
4533

H
Haojun Liao 已提交
4534 4535
      if (pField->type == TSDB_DATA_TYPE_BINARY || pField->type == TSDB_DATA_TYPE_NCHAR) {
        setVardataNull((char*) &pQueryInfo->fillVal[i], pField->type);
4536 4537
        continue;
      }
H
hjxilinx 已提交
4538

H
Haojun Liao 已提交
4539
      tVariant* p = taosArrayGet(pFillToken, j);
H
Haojun Liao 已提交
4540
      int32_t ret = tVariantDump(p, (char*)&pQueryInfo->fillVal[i], pField->type, true);
H
hzcheng 已提交
4541
      if (ret != TSDB_CODE_SUCCESS) {
4542
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
4543 4544
      }
    }
H
hjxilinx 已提交
4545
    
H
Haojun Liao 已提交
4546 4547
    if ((num < size) || ((num - 1 < size) && (tscIsPointInterpQuery(pQueryInfo)))) {
      tVariantListItem* lastItem = taosArrayGetLast(pFillToken);
H
hzcheng 已提交
4548

H
hjxilinx 已提交
4549
      for (int32_t i = numOfFillVal; i < size; ++i) {
H
Haojun Liao 已提交
4550
        TAOS_FIELD* pField = tscFieldInfoGetField(&pQueryInfo->fieldsInfo, i);
H
hzcheng 已提交
4551

H
Haojun Liao 已提交
4552 4553
        if (pField->type == TSDB_DATA_TYPE_BINARY || pField->type == TSDB_DATA_TYPE_NCHAR) {
          setVardataNull((char*) &pQueryInfo->fillVal[i], pField->type);
H
hjxilinx 已提交
4554
        } else {
H
Haojun Liao 已提交
4555
          tVariantDump(&lastItem->pVar, (char*)&pQueryInfo->fillVal[i], pField->type, true);
H
hzcheng 已提交
4556 4557 4558 4559
        }
      }
    }
  } else {
4560
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4561 4562 4563 4564 4565
  }

  return TSDB_CODE_SUCCESS;
}

4566
static void setDefaultOrderInfo(SQueryInfo* pQueryInfo) {
H
hzcheng 已提交
4567
  /* set default timestamp order information for all queries */
H
hjxilinx 已提交
4568
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hzcheng 已提交
4569

H
Haojun Liao 已提交
4570
  pQueryInfo->order.order = TSDB_ORDER_ASC;
H
Haojun Liao 已提交
4571 4572 4573 4574 4575
  if (isTopBottomQuery(pQueryInfo)) {
    pQueryInfo->order.orderColId = PRIMARYKEY_TIMESTAMP_COL_INDEX;
  } else { // in case of select tbname from super_table, the defualt order column can not be the primary ts column
    pQueryInfo->order.orderColId = INT32_MIN;
  }
H
hzcheng 已提交
4576

H
hjxilinx 已提交
4577
  /* for super table query, set default ascending order for group output */
weixin_48148422's avatar
weixin_48148422 已提交
4578
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
4579
    pQueryInfo->groupbyExpr.orderType = TSDB_ORDER_ASC;
H
hzcheng 已提交
4580 4581 4582
  }
}

4583
int32_t parseOrderbyClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql, SSchema* pSchema) {
S
slguan 已提交
4584 4585
  const char* msg0 = "only support order by primary timestamp";
  const char* msg1 = "invalid column name";
4586 4587
  const char* msg2 = "only support order by primary timestamp or queried column";
  const char* msg3 = "only support order by primary timestamp or first tag in groupby clause";
H
hzcheng 已提交
4588

4589
  setDefaultOrderInfo(pQueryInfo);
H
hjxilinx 已提交
4590
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hzcheng 已提交
4591 4592 4593 4594 4595

  if (pQuerySql->pSortOrder == NULL) {
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
4596
  SArray* pSortorder = pQuerySql->pSortOrder;
S
slguan 已提交
4597 4598 4599 4600 4601 4602 4603

  /*
   * for table query, there is only one or none order option is allowed, which is the
   * ts or values(top/bottom) order is supported.
   *
   * for super table query, the order option must be less than 3.
   */
H
Haojun Liao 已提交
4604
  size_t size = taosArrayGetSize(pSortorder);
weixin_48148422's avatar
weixin_48148422 已提交
4605
  if (UTIL_TABLE_IS_NORMAL_TABLE(pTableMetaInfo)) {
H
Haojun Liao 已提交
4606
    if (size > 1) {
4607
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
H
hzcheng 已提交
4608 4609
    }
  } else {
H
Haojun Liao 已提交
4610
    if (size > 2) {
4611
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
4612 4613 4614 4615
    }
  }

  // handle the first part of order by
H
Haojun Liao 已提交
4616
  tVariant* pVar = taosArrayGet(pSortorder, 0);
H
hzcheng 已提交
4617 4618 4619 4620 4621 4622

  // e.g., order by 1 asc, return directly with out further check.
  if (pVar->nType >= TSDB_DATA_TYPE_TINYINT && pVar->nType <= TSDB_DATA_TYPE_BIGINT) {
    return TSDB_CODE_SUCCESS;
  }

H
Haojun Liao 已提交
4623
  SStrToken    columnName = {pVar->nLen, pVar->nType, pVar->pz};
4624
  SColumnIndex index = COLUMN_INDEX_INITIALIZER;
S
slguan 已提交
4625

weixin_48148422's avatar
weixin_48148422 已提交
4626
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {  // super table query
4627 4628
    if (getColumnIndexByName(pCmd, &columnName, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
4629 4630 4631 4632
    }

    bool orderByTags = false;
    bool orderByTS = false;
H
hzcheng 已提交
4633

H
hjxilinx 已提交
4634 4635
    if (index.columnIndex >= tscGetNumOfColumns(pTableMetaInfo->pTableMeta)) {
      int32_t relTagIndex = index.columnIndex - tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
4636
      
4637 4638
      // it is a tag column
      if (pQueryInfo->groupbyExpr.columnInfo == NULL) {
4639
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
4640
      }
4641 4642
      SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, 0);
      if (relTagIndex == pColIndex->colIndex) {
H
hzcheng 已提交
4643 4644
        orderByTags = true;
      }
S
slguan 已提交
4645 4646
    } else if (index.columnIndex == TSDB_TBNAME_COLUMN_INDEX) {
      orderByTags = true;
H
hzcheng 已提交
4647 4648
    }

S
slguan 已提交
4649
    if (PRIMARYKEY_TIMESTAMP_COL_INDEX == index.columnIndex) {
H
hzcheng 已提交
4650 4651 4652
      orderByTS = true;
    }

4653
    if (!(orderByTags || orderByTS) && !isTopBottomQuery(pQueryInfo)) {
4654
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
4655
    } else {  // order by top/bottom result value column is not supported in case of interval query.
H
hzcheng 已提交
4656 4657 4658
      assert(!(orderByTags && orderByTS));
    }

H
Haojun Liao 已提交
4659 4660
    size_t s = taosArrayGetSize(pSortorder);
    if (s == 1) {
H
hzcheng 已提交
4661
      if (orderByTags) {
H
hjxilinx 已提交
4662
        pQueryInfo->groupbyExpr.orderIndex = index.columnIndex - tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
H
Haojun Liao 已提交
4663 4664 4665

        tVariantListItem* p1 = taosArrayGet(pQuerySql->pSortOrder, 0);
        pQueryInfo->groupbyExpr.orderType = p1->sortOrder;
4666
      } else if (isTopBottomQuery(pQueryInfo)) {
S
slguan 已提交
4667
        /* order of top/bottom query in interval is not valid  */
4668
        SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, 0);
S
slguan 已提交
4669 4670
        assert(pExpr->functionId == TSDB_FUNC_TS);

4671
        pExpr = tscSqlExprGet(pQueryInfo, 1);
4672
        if (pExpr->colInfo.colIndex != index.columnIndex && index.columnIndex != PRIMARYKEY_TIMESTAMP_COL_INDEX) {
4673
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
4674
        }
4675

H
Haojun Liao 已提交
4676 4677
        tVariantListItem* p1 = taosArrayGet(pQuerySql->pSortOrder, 0);
        pQueryInfo->order.order = p1->sortOrder;
4678
        pQueryInfo->order.orderColId = pSchema[index.columnIndex].colId;
S
slguan 已提交
4679
        return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
4680
      } else {
H
Haojun Liao 已提交
4681 4682 4683
        tVariantListItem* p1 = taosArrayGet(pQuerySql->pSortOrder, 0);

        pQueryInfo->order.order = p1->sortOrder;
4684
        pQueryInfo->order.orderColId = PRIMARYKEY_TIMESTAMP_COL_INDEX;
H
Haojun Liao 已提交
4685 4686 4687 4688 4689

        // orderby ts query on super table
        if (tscOrderedProjectionQueryOnSTable(pQueryInfo, 0)) {
          addPrimaryTsColIntoResult(pQueryInfo);
        }
H
hzcheng 已提交
4690 4691 4692
      }
    }

H
Haojun Liao 已提交
4693 4694
    if (s == 2) {
      tVariantListItem *pItem = taosArrayGet(pQuerySql->pSortOrder, 0);
S
slguan 已提交
4695
      if (orderByTags) {
H
hjxilinx 已提交
4696
        pQueryInfo->groupbyExpr.orderIndex = index.columnIndex - tscGetNumOfColumns(pTableMetaInfo->pTableMeta);
H
Haojun Liao 已提交
4697
        pQueryInfo->groupbyExpr.orderType = pItem->sortOrder;
S
slguan 已提交
4698
      } else {
H
Haojun Liao 已提交
4699
        pQueryInfo->order.order = pItem->sortOrder;
4700
        pQueryInfo->order.orderColId = PRIMARYKEY_TIMESTAMP_COL_INDEX;
S
slguan 已提交
4701 4702
      }

H
Haojun Liao 已提交
4703 4704
      pItem = taosArrayGet(pQuerySql->pSortOrder, 1);
      tVariant* pVar2 = &pItem->pVar;
H
Haojun Liao 已提交
4705
      SStrToken cname = {pVar2->nLen, pVar2->nType, pVar2->pz};
4706 4707
      if (getColumnIndexByName(pCmd, &cname, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
4708 4709 4710
      }

      if (index.columnIndex != PRIMARYKEY_TIMESTAMP_COL_INDEX) {
4711
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4712
      } else {
H
Haojun Liao 已提交
4713 4714
        tVariantListItem* p1 = taosArrayGet(pSortorder, 1);
        pQueryInfo->order.order = p1->sortOrder;
4715
        pQueryInfo->order.orderColId = PRIMARYKEY_TIMESTAMP_COL_INDEX;
H
hzcheng 已提交
4716 4717 4718 4719
      }
    }

  } else {  // meter query
4720 4721
    if (getColumnIndexByName(pCmd, &columnName, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
4722 4723
    }

4724
    if (index.columnIndex != PRIMARYKEY_TIMESTAMP_COL_INDEX && !isTopBottomQuery(pQueryInfo)) {
4725
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4726 4727
    }

4728
    if (isTopBottomQuery(pQueryInfo)) {
H
hzcheng 已提交
4729
      /* order of top/bottom query in interval is not valid  */
4730
      SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, 0);
S
slguan 已提交
4731
      assert(pExpr->functionId == TSDB_FUNC_TS);
H
hzcheng 已提交
4732

4733
      pExpr = tscSqlExprGet(pQueryInfo, 1);
4734
      if (pExpr->colInfo.colIndex != index.columnIndex && index.columnIndex != PRIMARYKEY_TIMESTAMP_COL_INDEX) {
4735
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
H
hzcheng 已提交
4736
      }
4737

H
Haojun Liao 已提交
4738 4739
      tVariantListItem* pItem = taosArrayGet(pQuerySql->pSortOrder, 0);
      pQueryInfo->order.order = pItem->sortOrder;
4740
      pQueryInfo->order.orderColId = pSchema[index.columnIndex].colId;
H
hzcheng 已提交
4741 4742
      return TSDB_CODE_SUCCESS;
    }
4743

H
Haojun Liao 已提交
4744 4745
    tVariantListItem* pItem = taosArrayGet(pQuerySql->pSortOrder, 0);
    pQueryInfo->order.order = pItem->sortOrder;
H
hzcheng 已提交
4746 4747 4748 4749 4750 4751
  }

  return TSDB_CODE_SUCCESS;
}

int32_t setAlterTableInfo(SSqlObj* pSql, struct SSqlInfo* pInfo) {
S
slguan 已提交
4752
  const int32_t DEFAULT_TABLE_INDEX = 0;
4753

4754 4755 4756 4757 4758
  const char* msg1 = "invalid table name";
  const char* msg3 = "manipulation of tag available for super table";
  const char* msg4 = "set tag value only available for table";
  const char* msg5 = "only support add one tag";
  const char* msg6 = "column can only be modified by super table";
H
hjxilinx 已提交
4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773
  
  const char* msg7 = "no tags can be dropped";
  const char* msg8 = "only support one tag";
  const char* msg9 = "tag name too long";
  
  const char* msg10 = "invalid tag name";
  const char* msg11 = "primary tag cannot be dropped";
  const char* msg12 = "update normal column not supported";
  const char* msg13 = "invalid tag value";
  const char* msg14 = "tag value too long";
  
  const char* msg15 = "no columns can be dropped";
  const char* msg16 = "only support one column";
  const char* msg17 = "invalid column name";
  const char* msg18 = "primary timestamp column cannot be dropped";
H
Haojun Liao 已提交
4774 4775
  const char* msg19 = "invalid new tag name";

H
Haojun Liao 已提交
4776 4777
  int32_t code = TSDB_CODE_SUCCESS;

S
slguan 已提交
4778
  SSqlCmd*        pCmd = &pSql->cmd;
H
hzcheng 已提交
4779
  SAlterTableSQL* pAlterSQL = pInfo->pAlterInfo;
4780 4781
  SQueryInfo*     pQueryInfo = tscGetQueryInfoDetail(pCmd, 0);

H
hjxilinx 已提交
4782
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, DEFAULT_TABLE_INDEX);
H
hzcheng 已提交
4783

4784
  if (tscValidateName(&(pAlterSQL->name)) != TSDB_CODE_SUCCESS) {
4785
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
4786
  }
P
plum-lihui 已提交
4787

H
Haojun Liao 已提交
4788 4789 4790
  code = tscSetTableFullName(pTableMetaInfo, &(pAlterSQL->name), pSql);
  if (code != TSDB_CODE_SUCCESS) {
    return code;
H
hzcheng 已提交
4791 4792
  }

H
Haojun Liao 已提交
4793 4794 4795
  code = tscGetTableMeta(pSql, pTableMetaInfo);
  if (code != TSDB_CODE_SUCCESS) {
    return code;
H
hzcheng 已提交
4796 4797
  }

H
hjxilinx 已提交
4798
  STableMeta* pTableMeta = pTableMetaInfo->pTableMeta;
H
hzcheng 已提交
4799

4800 4801
  if (pAlterSQL->type == TSDB_ALTER_TABLE_ADD_TAG_COLUMN || pAlterSQL->type == TSDB_ALTER_TABLE_DROP_TAG_COLUMN ||
      pAlterSQL->type == TSDB_ALTER_TABLE_CHANGE_TAG_COLUMN) {
weixin_48148422's avatar
weixin_48148422 已提交
4802
    if (UTIL_TABLE_IS_NORMAL_TABLE(pTableMetaInfo)) {
4803
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hzcheng 已提交
4804
    }
weixin_48148422's avatar
weixin_48148422 已提交
4805
  } else if ((pAlterSQL->type == TSDB_ALTER_TABLE_UPDATE_TAG_VAL) && (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo))) {
4806
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
4807
  } else if ((pAlterSQL->type == TSDB_ALTER_TABLE_ADD_COLUMN || pAlterSQL->type == TSDB_ALTER_TABLE_DROP_COLUMN) &&
4808
             UTIL_TABLE_IS_CHILD_TABLE(pTableMetaInfo)) {
4809
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
hzcheng 已提交
4810 4811
  }

4812
  if (pAlterSQL->type == TSDB_ALTER_TABLE_ADD_TAG_COLUMN) {
H
Haojun Liao 已提交
4813 4814
    SArray* pFieldList = pAlterSQL->pAddColumns;
    if (taosArrayGetSize(pFieldList) > 1) {
4815
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
H
hzcheng 已提交
4816 4817
    }

H
Haojun Liao 已提交
4818 4819
    TAOS_FIELD* p = taosArrayGet(pFieldList, 0);
    if (!validateOneTags(pCmd, p)) {
4820
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4821
    }
H
hjxilinx 已提交
4822
  
H
Haojun Liao 已提交
4823
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, p);
4824
  } else if (pAlterSQL->type == TSDB_ALTER_TABLE_DROP_TAG_COLUMN) {
H
hjxilinx 已提交
4825
    if (tscGetNumOfTags(pTableMeta) == 1) {
4826
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
H
hzcheng 已提交
4827 4828 4829
    }

    // numOfTags == 1
H
Haojun Liao 已提交
4830
    if (taosArrayGetSize(pAlterSQL->varList) > 1) {
4831
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg8);
H
hzcheng 已提交
4832 4833
    }

H
Haojun Liao 已提交
4834
    tVariantListItem* pItem = taosArrayGet(pAlterSQL->varList, 0);
B
Bomin Zhang 已提交
4835
    if (pItem->pVar.nLen >= TSDB_COL_NAME_LEN) {
4836
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg9);
H
hzcheng 已提交
4837
    }
4838

4839
    SColumnIndex index = COLUMN_INDEX_INITIALIZER;
H
Haojun Liao 已提交
4840
    SStrToken    name = {.z = pItem->pVar.pz, .n = pItem->pVar.nLen, .type = TK_STRING};
4841

4842
    if (getColumnIndexByName(pCmd, &name, pQueryInfo, &index) != TSDB_CODE_SUCCESS) {
4843
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4844 4845
    }

H
Haojun Liao 已提交
4846 4847
    int32_t numOfCols = tscGetNumOfColumns(pTableMeta);
    if (index.columnIndex < numOfCols) {
4848
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg10);
H
Haojun Liao 已提交
4849
    } else if (index.columnIndex == numOfCols) {
4850
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg11);
H
hzcheng 已提交
4851 4852
    }

4853 4854
    char name1[128] = {0};
    strncpy(name1, pItem->pVar.pz, pItem->pVar.nLen);
H
hjxilinx 已提交
4855 4856 4857
  
    TAOS_FIELD f = tscCreateField(TSDB_DATA_TYPE_INT, name1, tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize);
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, &f);
4858
  } else if (pAlterSQL->type == TSDB_ALTER_TABLE_CHANGE_TAG_COLUMN) {
H
Haojun Liao 已提交
4859 4860
    SArray* pVarList = pAlterSQL->varList;
    if (taosArrayGetSize(pVarList) > 2) {
4861
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4862 4863
    }

H
Haojun Liao 已提交
4864 4865
    tVariantListItem* pSrcItem = taosArrayGet(pAlterSQL->varList, 0);
    tVariantListItem* pDstItem = taosArrayGet(pAlterSQL->varList, 1);
4866 4867

    if (pSrcItem->pVar.nLen >= TSDB_COL_NAME_LEN || pDstItem->pVar.nLen >= TSDB_COL_NAME_LEN) {
4868
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg9);
H
hzcheng 已提交
4869 4870
    }

4871
    if (pSrcItem->pVar.nType != TSDB_DATA_TYPE_BINARY || pDstItem->pVar.nType != TSDB_DATA_TYPE_BINARY) {
4872
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg10);
4873
    }
H
hzcheng 已提交
4874

S
slguan 已提交
4875 4876
    SColumnIndex srcIndex = COLUMN_INDEX_INITIALIZER;
    SColumnIndex destIndex = COLUMN_INDEX_INITIALIZER;
H
hzcheng 已提交
4877

H
Haojun Liao 已提交
4878
    SStrToken srcToken = {.z = pSrcItem->pVar.pz, .n = pSrcItem->pVar.nLen, .type = TK_STRING};
4879
    if (getColumnIndexByName(pCmd, &srcToken, pQueryInfo, &srcIndex) != TSDB_CODE_SUCCESS) {
H
Haojun Liao 已提交
4880
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg17);
H
hzcheng 已提交
4881 4882
    }

H
Haojun Liao 已提交
4883
    SStrToken destToken = {.z = pDstItem->pVar.pz, .n = pDstItem->pVar.nLen, .type = TK_STRING};
4884
    if (getColumnIndexByName(pCmd, &destToken, pQueryInfo, &destIndex) == TSDB_CODE_SUCCESS) {
H
Haojun Liao 已提交
4885
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg19);
H
hzcheng 已提交
4886 4887
    }

H
Haojun Liao 已提交
4888 4889
    tVariantListItem* pItem = taosArrayGet(pVarList, 0);

B
Bomin Zhang 已提交
4890
    char name[TSDB_COL_NAME_LEN] = {0};
H
Haojun Liao 已提交
4891
    strncpy(name, pItem->pVar.pz, pItem->pVar.nLen);
H
hjxilinx 已提交
4892 4893
    TAOS_FIELD f = tscCreateField(TSDB_DATA_TYPE_INT, name, tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize);
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, &f);
H
hzcheng 已提交
4894

H
Haojun Liao 已提交
4895
    pItem = taosArrayGet(pVarList, 1);
H
hzcheng 已提交
4896
    memset(name, 0, tListLen(name));
H
Haojun Liao 已提交
4897 4898

    strncpy(name, pItem->pVar.pz, pItem->pVar.nLen);
H
hjxilinx 已提交
4899 4900
    f = tscCreateField(TSDB_DATA_TYPE_INT, name, tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize);
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, &f);
4901 4902
  } else if (pAlterSQL->type == TSDB_ALTER_TABLE_UPDATE_TAG_VAL) {
    // Note: update can only be applied to table not super table.
4903 4904 4905
    // the following is used to handle tags value for table created according to super table
    pCmd->command = TSDB_SQL_UPDATE_TAGS_VAL;
    
H
Haojun Liao 已提交
4906 4907
    SArray* pVarList = pAlterSQL->varList;
    tVariantListItem* item = taosArrayGet(pVarList, 0);
4908
    int16_t       numOfTags = tscGetNumOfTags(pTableMeta);
H
hzcheng 已提交
4909

4910
    SColumnIndex columnIndex = COLUMN_INDEX_INITIALIZER;
H
Haojun Liao 已提交
4911
    SStrToken    name = {.type = TK_STRING, .z = item->pVar.pz, .n = item->pVar.nLen};
4912
    if (getColumnIndexByName(pCmd, &name, pQueryInfo, &columnIndex) != TSDB_CODE_SUCCESS) {
4913
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4914 4915
    }

H
hjxilinx 已提交
4916
    if (columnIndex.columnIndex < tscGetNumOfColumns(pTableMeta)) {
4917
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg12);
S
slguan 已提交
4918 4919
    }

H
Haojun Liao 已提交
4920
    tVariantListItem* pItem = taosArrayGet(pVarList, 1);
H
hjxilinx 已提交
4921
    SSchema* pTagsSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, columnIndex.columnIndex);
4922 4923
    pAlterSQL->tagData.data = calloc(1, pTagsSchema->bytes * TSDB_NCHAR_SIZE + VARSTR_HEADER_SIZE);

H
Haojun Liao 已提交
4924
    if (tVariantDump(&pItem->pVar, pAlterSQL->tagData.data, pTagsSchema->type, true) != TSDB_CODE_SUCCESS) {
4925
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg13);
H
hzcheng 已提交
4926
    }
4927
    
4928
    pAlterSQL->tagData.dataLen = pTagsSchema->bytes;
H
hzcheng 已提交
4929 4930

    // validate the length of binary
4931
    if ((pTagsSchema->type == TSDB_DATA_TYPE_BINARY || pTagsSchema->type == TSDB_DATA_TYPE_NCHAR) &&
H
Haojun Liao 已提交
4932
        varDataTLen(pAlterSQL->tagData.data) > pTagsSchema->bytes) {
4933
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg14);
H
hzcheng 已提交
4934
    }
4935 4936 4937 4938

    int32_t schemaLen = sizeof(STColumn) * numOfTags;
    int32_t size = sizeof(SUpdateTableTagValMsg) + pTagsSchema->bytes + schemaLen + TSDB_EXTRA_PAYLOAD_SIZE;

4939 4940
    if (TSDB_CODE_SUCCESS != tscAllocPayload(pCmd, size)) {
      tscError("%p failed to malloc for alter table msg", pSql);
4941
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
4942 4943
    }

4944
    SUpdateTableTagValMsg* pUpdateMsg = (SUpdateTableTagValMsg*) pCmd->payload;
4945
    pUpdateMsg->head.vgId = htonl(pTableMeta->vgId);
4946 4947
    pUpdateMsg->tid       = htonl(pTableMeta->id.tid);
    pUpdateMsg->uid       = htobe64(pTableMeta->id.uid);
H
Haojun Liao 已提交
4948
    pUpdateMsg->colId     = htons(pTagsSchema->colId);
H
Hongze Cheng 已提交
4949
    pUpdateMsg->type      = pTagsSchema->type;
H
Haojun Liao 已提交
4950 4951
    pUpdateMsg->bytes     = htons(pTagsSchema->bytes);
    pUpdateMsg->tversion  = htons(pTableMeta->tversion);
4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968
    pUpdateMsg->numOfTags = htons(numOfTags);
    pUpdateMsg->schemaLen = htonl(schemaLen);

    // the schema is located after the msg body, then followed by true tag value
    char* d = pUpdateMsg->data;
    SSchema* pTagCols = tscGetTableTagSchema(pTableMeta);
    for (int i = 0; i < numOfTags; ++i) {
      STColumn* pCol = (STColumn*) d;
      pCol->colId = htons(pTagCols[i].colId);
      pCol->bytes = htons(pTagCols[i].bytes);
      pCol->type  = pTagCols[i].type;
      pCol->offset = 0;

      d += sizeof(STColumn);
    }

    // copy the tag value to msg body
H
Haojun Liao 已提交
4969 4970
    pItem = taosArrayGet(pVarList, 1);
    tVariantDump(&pItem->pVar, pUpdateMsg->data + schemaLen, pTagsSchema->type, true);
4971 4972 4973 4974 4975
    
    int32_t len = 0;
    if (pTagsSchema->type != TSDB_DATA_TYPE_BINARY && pTagsSchema->type != TSDB_DATA_TYPE_NCHAR) {
      len = tDataTypeDesc[pTagsSchema->type].nSize;
    } else {
4976
      len = varDataTLen(pUpdateMsg->data + schemaLen);
4977 4978 4979 4980
    }
    
    pUpdateMsg->tagValLen = htonl(len);  // length may be changed after dump data
    
4981
    int32_t total = sizeof(SUpdateTableTagValMsg) + len + schemaLen;
4982
    pUpdateMsg->head.contLen = htonl(total);
H
hjxilinx 已提交
4983
    
4984
  } else if (pAlterSQL->type == TSDB_ALTER_TABLE_ADD_COLUMN) {
H
Haojun Liao 已提交
4985 4986
    SArray* pFieldList = pAlterSQL->pAddColumns;
    if (taosArrayGetSize(pFieldList) > 1) {
4987
      const char* msg = "only support add one column";
4988
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hzcheng 已提交
4989 4990
    }

H
Haojun Liao 已提交
4991 4992
    TAOS_FIELD* p = taosArrayGet(pFieldList, 0);
    if (!validateOneColumn(pCmd, p)) {
4993
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
4994
    }
H
hjxilinx 已提交
4995
  
H
Haojun Liao 已提交
4996
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, p);
4997
  } else if (pAlterSQL->type == TSDB_ALTER_TABLE_DROP_COLUMN) {
H
hjxilinx 已提交
4998
    if (tscGetNumOfColumns(pTableMeta) == TSDB_MIN_COLUMNS) {  //
H
hjxilinx 已提交
4999
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg15);
H
hzcheng 已提交
5000 5001
    }

H
Haojun Liao 已提交
5002 5003
    size_t size = taosArrayGetSize(pAlterSQL->varList);
    if (size > 1) {
H
hjxilinx 已提交
5004
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg16);
H
hzcheng 已提交
5005 5006
    }

H
Haojun Liao 已提交
5007
    tVariantListItem* pItem = taosArrayGet(pAlterSQL->varList, 0);
H
hzcheng 已提交
5008

5009
    SColumnIndex columnIndex = COLUMN_INDEX_INITIALIZER;
H
Haojun Liao 已提交
5010
    SStrToken    name = {.type = TK_STRING, .z = pItem->pVar.pz, .n = pItem->pVar.nLen};
5011 5012
    if (getColumnIndexByName(pCmd, &name, pQueryInfo, &columnIndex) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg17);
H
hzcheng 已提交
5013 5014
    }

5015
    if (columnIndex.columnIndex == PRIMARYKEY_TIMESTAMP_COL_INDEX) {
5016
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg18);
5017
    }
H
hzcheng 已提交
5018

B
Bomin Zhang 已提交
5019 5020
    char name1[TSDB_COL_NAME_LEN] = {0};
    tstrncpy(name1, pItem->pVar.pz, sizeof(name1));
H
hjxilinx 已提交
5021 5022
    TAOS_FIELD f = tscCreateField(TSDB_DATA_TYPE_INT, name1, tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize);
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, &f);
H
hzcheng 已提交
5023 5024 5025 5026 5027
  }

  return TSDB_CODE_SUCCESS;
}

5028
int32_t validateSqlFunctionInStreamSql(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
5029 5030
  const char* msg0 = "sample interval can not be less than 10ms.";
  const char* msg1 = "functions not allowed in select clause";
H
hzcheng 已提交
5031

5032 5033 5034
  if (pQueryInfo->interval.interval != 0 && pQueryInfo->interval.interval < 10 &&
     pQueryInfo->interval.intervalUnit != 'n' &&
     pQueryInfo->interval.intervalUnit != 'y') {
5035
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
H
hzcheng 已提交
5036
  }
H
hjxilinx 已提交
5037
  
H
hjxilinx 已提交
5038
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5039
  for (int32_t i = 0; i < size; ++i) {
5040
    int32_t functId = tscSqlExprGet(pQueryInfo, i)->functionId;
H
hzcheng 已提交
5041
    if (!IS_STREAM_QUERY_VALID(aAggs[functId].nStatus)) {
5042
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
5043 5044 5045 5046 5047 5048
    }
  }

  return TSDB_CODE_SUCCESS;
}

5049
int32_t validateFunctionsInIntervalOrGroupbyQuery(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
S
slguan 已提交
5050
  bool        isProjectionFunction = false;
5051
  const char* msg1 = "column projection is not compatible with interval";
H
hjxilinx 已提交
5052

H
hzcheng 已提交
5053
  // multi-output set/ todo refactor
H
hjxilinx 已提交
5054
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5055 5056
  
  for (int32_t k = 0; k < size; ++k) {
5057
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, k);
H
hjxilinx 已提交
5058

5059 5060 5061
    // projection query on primary timestamp, the selectivity function needs to be present.
    if (pExpr->functionId == TSDB_FUNC_PRJ && pExpr->colInfo.colId == PRIMARYKEY_TIMESTAMP_COL_INDEX) {
      bool hasSelectivity = false;
H
hjxilinx 已提交
5062
      for (int32_t j = 0; j < size; ++j) {
5063
        SSqlExpr* pEx = tscSqlExprGet(pQueryInfo, j);
5064 5065 5066 5067 5068
        if ((aAggs[pEx->functionId].nStatus & TSDB_FUNCSTATE_SELECTIVITY) == TSDB_FUNCSTATE_SELECTIVITY) {
          hasSelectivity = true;
          break;
        }
      }
H
hjxilinx 已提交
5069

5070 5071 5072 5073
      if (hasSelectivity) {
        continue;
      }
    }
H
hjxilinx 已提交
5074

5075
    if ((pExpr->functionId == TSDB_FUNC_PRJ && pExpr->numOfParams == 0) || pExpr->functionId == TSDB_FUNC_DIFF ||
H
hjxilinx 已提交
5076
        pExpr->functionId == TSDB_FUNC_ARITHM) {
H
hzcheng 已提交
5077 5078 5079
      isProjectionFunction = true;
    }
  }
S
slguan 已提交
5080 5081

  if (isProjectionFunction) {
5082
    invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
5083 5084
  }

5085
  return isProjectionFunction == true ? TSDB_CODE_TSC_INVALID_SQL : TSDB_CODE_SUCCESS;
H
hzcheng 已提交
5086 5087 5088
}

typedef struct SDNodeDynConfOption {
H
hjxilinx 已提交
5089 5090
  char*   name;  // command name
  int32_t len;   // name string length
H
hzcheng 已提交
5091 5092
} SDNodeDynConfOption;

H
Hui Li 已提交
5093

5094
int32_t validateEp(char* ep) {  
H
Hui Li 已提交
5095 5096 5097
  char buf[TSDB_EP_LEN + 1] = {0};
  tstrncpy(buf, ep, TSDB_EP_LEN);

5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108
  char* pos = strchr(buf, ':');
  if (NULL == pos) {
    int32_t val = strtol(ep, NULL, 10);
    if (val <= 0 || val > 65536) {
      return TSDB_CODE_TSC_INVALID_SQL;
    }
  } else {
    uint16_t port = atoi(pos + 1);
    if (0 == port) {
      return TSDB_CODE_TSC_INVALID_SQL;
    }
H
Hui Li 已提交
5109 5110
  }

5111
  return TSDB_CODE_SUCCESS;
H
Hui Li 已提交
5112 5113
}

H
hzcheng 已提交
5114 5115
int32_t validateDNodeConfig(tDCLSQL* pOptions) {
  if (pOptions->nTokens < 2 || pOptions->nTokens > 3) {
5116
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5117 5118
  }

5119 5120 5121 5122 5123 5124 5125
  const int tokenLogEnd = 2;
  const int tokenBalance = 2;
  const int tokenMonitor = 3;
  const int tokenDebugFlag = 4;
  const int tokenDebugFlagEnd = 20;
  const SDNodeDynConfOption cfgOptions[] = {
      {"resetLog", 8},    {"resetQueryCache", 15},  {"balance", 7},     {"monitor", 7},
S
Shengliang Guan 已提交
5126
      {"debugFlag", 9},   {"monDebugFlag", 12},     {"vDebugFlag", 10}, {"mDebugFlag", 10},
5127 5128 5129
      {"cDebugFlag", 10}, {"httpDebugFlag", 13},    {"qDebugflag", 10}, {"sdbDebugFlag", 12},
      {"uDebugFlag", 10}, {"tsdbDebugFlag", 13},    {"sDebugflag", 10}, {"rpcDebugFlag", 12},
      {"dDebugFlag", 10}, {"mqttDebugFlag", 13},    {"wDebugFlag", 10}, {"tmrDebugFlag", 12},
S
TD-1520  
Shengliang Guan 已提交
5130
      {"cqDebugFlag", 11},
5131
  };
H
hzcheng 已提交
5132

H
Haojun Liao 已提交
5133
  SStrToken* pOptionToken = &pOptions->a[1];
H
hzcheng 已提交
5134 5135 5136

  if (pOptions->nTokens == 2) {
    // reset log and reset query cache does not need value
5137 5138
    for (int32_t i = 0; i < tokenLogEnd; ++i) {
      const SDNodeDynConfOption* pOption = &cfgOptions[i];
H
hzcheng 已提交
5139 5140 5141 5142
      if ((strncasecmp(pOption->name, pOptionToken->z, pOptionToken->n) == 0) && (pOption->len == pOptionToken->n)) {
        return TSDB_CODE_SUCCESS;
      }
    }
5143 5144
  } else if ((strncasecmp(cfgOptions[tokenBalance].name, pOptionToken->z, pOptionToken->n) == 0) &&
             (cfgOptions[tokenBalance].len == pOptionToken->n)) {
H
Haojun Liao 已提交
5145
    SStrToken* pValToken = &pOptions->a[2];
S
Shengliang Guan 已提交
5146 5147
    int32_t vnodeId = 0;
    int32_t dnodeId = 0;
5148
    strdequote(pValToken->z);
S
Shengliang Guan 已提交
5149
    bool parseOk = taosCheckBalanceCfgOptions(pValToken->z, &vnodeId, &dnodeId);
5150 5151 5152 5153 5154 5155
    if (!parseOk) {
      return TSDB_CODE_TSC_INVALID_SQL;  // options value is invalid
    }
    return TSDB_CODE_SUCCESS;
  } else if ((strncasecmp(cfgOptions[tokenMonitor].name, pOptionToken->z, pOptionToken->n) == 0) &&
             (cfgOptions[tokenMonitor].len == pOptionToken->n)) {
H
Haojun Liao 已提交
5156
    SStrToken* pValToken = &pOptions->a[2];
S
slguan 已提交
5157 5158
    int32_t    val = strtol(pValToken->z, NULL, 10);
    if (val != 0 && val != 1) {
5159
      return TSDB_CODE_TSC_INVALID_SQL;  // options value is invalid
S
slguan 已提交
5160 5161
    }
    return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
5162
  } else {
H
Haojun Liao 已提交
5163
    SStrToken* pValToken = &pOptions->a[2];
H
hzcheng 已提交
5164 5165

    int32_t val = strtol(pValToken->z, NULL, 10);
5166
    if (val < 0 || val > 256) {
H
hzcheng 已提交
5167
      /* options value is out of valid range */
5168
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5169 5170
    }

5171 5172
    for (int32_t i = tokenDebugFlag; i < tokenDebugFlagEnd; ++i) {
      const SDNodeDynConfOption* pOption = &cfgOptions[i];
H
hzcheng 已提交
5173 5174 5175 5176 5177 5178 5179 5180

      if ((strncasecmp(pOption->name, pOptionToken->z, pOptionToken->n) == 0) && (pOption->len == pOptionToken->n)) {
        /* options is valid */
        return TSDB_CODE_SUCCESS;
      }
    }
  }

5181
  return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5182 5183
}

S
slguan 已提交
5184 5185
int32_t validateLocalConfig(tDCLSQL* pOptions) {
  if (pOptions->nTokens < 1 || pOptions->nTokens > 2) {
5186
    return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
5187 5188
  }

H
hjxilinx 已提交
5189 5190
  SDNodeDynConfOption LOCAL_DYNAMIC_CFG_OPTIONS[6] = {{"resetLog", 8},    {"rpcDebugFlag", 12}, {"tmrDebugFlag", 12},
                                                      {"cDebugFlag", 10}, {"uDebugFlag", 10},   {"debugFlag", 9}};
S
slguan 已提交
5191

H
Haojun Liao 已提交
5192
  SStrToken* pOptionToken = &pOptions->a[0];
S
slguan 已提交
5193 5194 5195 5196 5197 5198 5199 5200 5201 5202

  if (pOptions->nTokens == 1) {
    // reset log does not need value
    for (int32_t i = 0; i < 1; ++i) {
      SDNodeDynConfOption* pOption = &LOCAL_DYNAMIC_CFG_OPTIONS[i];
      if ((strncasecmp(pOption->name, pOptionToken->z, pOptionToken->n) == 0) && (pOption->len == pOptionToken->n)) {
        return TSDB_CODE_SUCCESS;
      }
    }
  } else {
H
Haojun Liao 已提交
5203
    SStrToken* pValToken = &pOptions->a[1];
S
slguan 已提交
5204 5205 5206 5207

    int32_t val = strtol(pValToken->z, NULL, 10);
    if (val < 131 || val > 199) {
      // options value is out of valid range
5208
      return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
5209 5210 5211 5212 5213 5214 5215 5216 5217 5218
    }

    for (int32_t i = 1; i < tListLen(LOCAL_DYNAMIC_CFG_OPTIONS); ++i) {
      SDNodeDynConfOption* pOption = &LOCAL_DYNAMIC_CFG_OPTIONS[i];
      if ((strncasecmp(pOption->name, pOptionToken->z, pOptionToken->n) == 0) && (pOption->len == pOptionToken->n)) {
        // options is valid
        return TSDB_CODE_SUCCESS;
      }
    }
  }
5219
  return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
5220 5221
}

H
hzcheng 已提交
5222
int32_t validateColumnName(char* name) {
S
TD-1057  
Shengliang Guan 已提交
5223
  bool ret = isKeyWord(name, (int32_t)strlen(name));
H
hzcheng 已提交
5224
  if (ret) {
5225
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5226 5227
  }

H
Haojun Liao 已提交
5228
  SStrToken token = {.z = name};
H
hzcheng 已提交
5229 5230 5231
  token.n = tSQLGetToken(name, &token.type);

  if (token.type != TK_STRING && token.type != TK_ID) {
5232
    return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5233 5234 5235 5236
  }

  if (token.type == TK_STRING) {
    strdequote(token.z);
S
TD-1057  
Shengliang Guan 已提交
5237
    token.n = (uint32_t)strtrim(token.z);
H
hzcheng 已提交
5238 5239 5240

    int32_t k = tSQLGetToken(token.z, &token.type);
    if (k != token.n) {
5241
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5242 5243 5244 5245 5246
    }

    return validateColumnName(token.z);
  } else {
    if (isNumber(&token)) {
5247
      return TSDB_CODE_TSC_INVALID_SQL;
H
hzcheng 已提交
5248 5249 5250 5251 5252 5253
    }
  }

  return TSDB_CODE_SUCCESS;
}

5254 5255
bool hasTimestampForPointInterpQuery(SQueryInfo* pQueryInfo) {
  if (!tscIsPointInterpQuery(pQueryInfo)) {
H
hzcheng 已提交
5256 5257 5258
    return true;
  }

H
hjxilinx 已提交
5259
  return (pQueryInfo->window.skey == pQueryInfo->window.ekey) && (pQueryInfo->window.skey != 0);
H
hzcheng 已提交
5260 5261
}

5262
int32_t parseLimitClause(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, int32_t clauseIndex, SQuerySQL* pQuerySql, SSqlObj* pSql) {
H
hjxilinx 已提交
5263
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hzcheng 已提交
5264

S
slguan 已提交
5265 5266
  const char* msg0 = "soffset/offset can not be less than 0";
  const char* msg1 = "slimit/soffset only available for STable query";
5267
  const char* msg2 = "functions mixed up in table query";
S
slguan 已提交
5268
  const char* msg3 = "slimit/soffset can not apply to projection query";
H
hjxilinx 已提交
5269

H
hzcheng 已提交
5270
  // handle the limit offset value, validate the limit
5271
  pQueryInfo->limit = pQuerySql->limit;
5272
  pQueryInfo->clauseLimit = pQueryInfo->limit.limit;
5273
  pQueryInfo->slimit = pQuerySql->slimit;
5274
  
5275
  tscDebug("%p limit:%" PRId64 ", offset:%" PRId64 " slimit:%" PRId64 ", soffset:%" PRId64, pSql, pQueryInfo->limit.limit,
5276 5277
      pQueryInfo->limit.offset, pQueryInfo->slimit.limit, pQueryInfo->slimit.offset);
  
5278
  if (pQueryInfo->slimit.offset < 0 || pQueryInfo->limit.offset < 0) {
5279
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
S
slguan 已提交
5280 5281
  }

5282
  if (pQueryInfo->limit.limit == 0) {
5283
    tscDebug("%p limit 0, no output result", pSql);
5284
    pQueryInfo->command = TSDB_SQL_RETRIEVE_EMPTY_RESULT;
H
hjxilinx 已提交
5285
    return TSDB_CODE_SUCCESS;
S
slguan 已提交
5286 5287
  }

H
hjxilinx 已提交
5288
  // todo refactor
weixin_48148422's avatar
weixin_48148422 已提交
5289
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
hjxilinx 已提交
5290
    if (!tscQueryTags(pQueryInfo)) {  // local handle the super table tag query
5291
      if (tscIsProjectionQueryOnSTable(pQueryInfo, 0)) {
H
hjxilinx 已提交
5292
        if (pQueryInfo->slimit.limit > 0 || pQueryInfo->slimit.offset > 0) {
5293
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hjxilinx 已提交
5294
        }
H
hjxilinx 已提交
5295

5296
        // for projection query on super table, all queries are subqueries
H
hjxilinx 已提交
5297 5298
        if (tscNonOrderedProjectionQueryOnSTable(pQueryInfo, 0) &&
            !TSDB_QUERY_HAS_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_JOIN_QUERY)) {
5299
          pQueryInfo->type |= TSDB_QUERY_TYPE_SUBQUERY;
5300
        }
S
slguan 已提交
5301
      }
H
hzcheng 已提交
5302 5303
    }

5304
    if (pQueryInfo->slimit.limit == 0) {
5305
      tscDebug("%p slimit 0, no output result", pSql);
5306
      pQueryInfo->command = TSDB_SQL_RETRIEVE_EMPTY_RESULT;
H
hzcheng 已提交
5307 5308 5309 5310
      return TSDB_CODE_SUCCESS;
    }

    /*
5311 5312 5313 5314
     * Get the distribution of all tables among all available virtual nodes that are qualified for the query condition
     * and created according to this super table from management node.
     * And then launching multiple async-queries against all qualified virtual nodes, during the first-stage
     * query operation.
H
hzcheng 已提交
5315
     */
H
hjxilinx 已提交
5316
    int32_t code = tscGetSTableVgroupInfo(pSql, clauseIndex);
H
hzcheng 已提交
5317 5318 5319 5320
    if (code != TSDB_CODE_SUCCESS) {
      return code;
    }

S
slguan 已提交
5321
    // No tables included. No results generated. Query results are empty.
5322
    if (pTableMetaInfo->vgroupList->numOfVgroups == 0) {
5323
      tscDebug("%p no table in super table, no output result", pSql);
5324
      pQueryInfo->command = TSDB_SQL_RETRIEVE_EMPTY_RESULT;
H
hjxilinx 已提交
5325
      return TSDB_CODE_SUCCESS;
H
hzcheng 已提交
5326 5327 5328
    }

    // keep original limitation value in globalLimit
5329
    pQueryInfo->clauseLimit = pQueryInfo->limit.limit;
H
Haojun Liao 已提交
5330
    pQueryInfo->prjOffset   = pQueryInfo->limit.offset;
H
Haojun Liao 已提交
5331
    pQueryInfo->vgroupLimit = -1;
H
hjxilinx 已提交
5332

5333 5334
    if (tscOrderedProjectionQueryOnSTable(pQueryInfo, 0)) {
      /*
5335 5336 5337 5338
       * the offset value should be removed during retrieve data from virtual node, since the
       * global order are done in client side, so the offset is applied at the client side
       * However, note that the maximum allowed number of result for each table should be less
       * than or equal to the value of limit.
5339 5340
       */
      if (pQueryInfo->limit.limit > 0) {
H
Haojun Liao 已提交
5341
        pQueryInfo->vgroupLimit = pQueryInfo->limit.limit + pQueryInfo->limit.offset;
5342 5343
        pQueryInfo->limit.limit = -1;
      }
H
hjxilinx 已提交
5344

5345 5346
      pQueryInfo->limit.offset = 0;
    }
H
hzcheng 已提交
5347
  } else {
5348
    if (pQueryInfo->slimit.limit != -1 || pQueryInfo->slimit.offset != 0) {
5349
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hzcheng 已提交
5350
    }
H
hjxilinx 已提交
5351
  
H
hjxilinx 已提交
5352
    size_t size = taosArrayGetSize(pQueryInfo->exprList);
5353 5354 5355
    
    bool hasTags = false;
    bool hasOtherFunc = false;
S
slguan 已提交
5356
    // filter the query functions operating on "tbname" column that are not supported by normal columns.
H
hjxilinx 已提交
5357
    for (int32_t i = 0; i < size; ++i) {
5358
      SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
5359 5360 5361 5362
      if (TSDB_COL_IS_TAG(pExpr->colInfo.flag)) {
        hasTags = true;
      } else {
        hasOtherFunc = true;
H
hzcheng 已提交
5363 5364
      }
    }
5365 5366
    
    if (hasTags && hasOtherFunc) {
5367
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
5368
    }
H
hzcheng 已提交
5369 5370 5371 5372
  }

  return TSDB_CODE_SUCCESS;
}
5373

S
TD-1732  
Shengliang Guan 已提交
5374
static int32_t setKeepOption(SSqlCmd* pCmd, SCreateDbMsg* pMsg, SCreateDBInfo* pCreateDb) {
H
hjxilinx 已提交
5375
  const char* msg = "invalid number of options";
H
hjxilinx 已提交
5376

5377 5378 5379
  pMsg->daysToKeep = htonl(-1);
  pMsg->daysToKeep1 = htonl(-1);
  pMsg->daysToKeep2 = htonl(-1);
H
hjxilinx 已提交
5380

H
Haojun Liao 已提交
5381
  SArray* pKeep = pCreateDb->keep;
H
hjxilinx 已提交
5382
  if (pKeep != NULL) {
H
Haojun Liao 已提交
5383 5384 5385 5386 5387 5388
    size_t s = taosArrayGetSize(pKeep);
    tVariantListItem* p0 = taosArrayGet(pKeep, 0);
    switch (s) {
      case 1: {
        pMsg->daysToKeep = htonl((int32_t)p0->pVar.i64Key);
      }
5389 5390
        break;
      case 2: {
H
Haojun Liao 已提交
5391 5392 5393
        tVariantListItem* p1 = taosArrayGet(pKeep, 1);
        pMsg->daysToKeep = htonl((int32_t)p0->pVar.i64Key);
        pMsg->daysToKeep1 = htonl((int32_t)p1->pVar.i64Key);
5394 5395 5396
        break;
      }
      case 3: {
H
Haojun Liao 已提交
5397 5398 5399 5400 5401 5402
        tVariantListItem* p1 = taosArrayGet(pKeep, 1);
        tVariantListItem* p2 = taosArrayGet(pKeep, 2);

        pMsg->daysToKeep = htonl((int32_t)p0->pVar.i64Key);
        pMsg->daysToKeep1 = htonl((int32_t)p1->pVar.i64Key);
        pMsg->daysToKeep2 = htonl((int32_t)p2->pVar.i64Key);
5403 5404
        break;
      }
5405
      default: { return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg); }
5406 5407
    }
  }
H
hjxilinx 已提交
5408

H
hjxilinx 已提交
5409 5410
  return TSDB_CODE_SUCCESS;
}
5411

S
TD-1732  
Shengliang Guan 已提交
5412
static int32_t setTimePrecision(SSqlCmd* pCmd, SCreateDbMsg* pMsg, SCreateDBInfo* pCreateDbInfo) {
H
hjxilinx 已提交
5413
  const char* msg = "invalid time precision";
H
hjxilinx 已提交
5414

H
hjxilinx 已提交
5415
  pMsg->precision = TSDB_TIME_PRECISION_MILLI;  // millisecond by default
H
hjxilinx 已提交
5416

H
Haojun Liao 已提交
5417
  SStrToken* pToken = &pCreateDbInfo->precision;
5418 5419
  if (pToken->n > 0) {
    pToken->n = strdequote(pToken->z);
H
hjxilinx 已提交
5420

5421 5422 5423 5424 5425
    if (strncmp(pToken->z, TSDB_TIME_PRECISION_MILLI_STR, pToken->n) == 0 &&
        strlen(TSDB_TIME_PRECISION_MILLI_STR) == pToken->n) {
      // time precision for this db: million second
      pMsg->precision = TSDB_TIME_PRECISION_MILLI;
    } else if (strncmp(pToken->z, TSDB_TIME_PRECISION_MICRO_STR, pToken->n) == 0 &&
H
hjxilinx 已提交
5426
               strlen(TSDB_TIME_PRECISION_MICRO_STR) == pToken->n) {
5427 5428
      pMsg->precision = TSDB_TIME_PRECISION_MICRO;
    } else {
5429
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
5430 5431
    }
  }
H
hjxilinx 已提交
5432

H
hjxilinx 已提交
5433 5434
  return TSDB_CODE_SUCCESS;
}
5435

S
TD-1732  
Shengliang Guan 已提交
5436
static void setCreateDBOption(SCreateDbMsg* pMsg, SCreateDBInfo* pCreateDb) {
H
Haojun Liao 已提交
5437
  pMsg->maxTables = htonl(-1);  // max tables can not be set anymore
H
hjxilinx 已提交
5438
  pMsg->cacheBlockSize = htonl(pCreateDb->cacheBlockSize);
5439
  pMsg->totalBlocks = htonl(pCreateDb->numOfBlocks);
H
hjxilinx 已提交
5440
  pMsg->daysPerFile = htonl(pCreateDb->daysPerFile);
S
TD-1057  
Shengliang Guan 已提交
5441
  pMsg->commitTime = htonl((int32_t)pCreateDb->commitTime);
H
hjxilinx 已提交
5442 5443
  pMsg->minRowsPerFileBlock = htonl(pCreateDb->minRowsPerBlock);
  pMsg->maxRowsPerFileBlock = htonl(pCreateDb->maxRowsPerBlock);
陶建辉(Jeff)'s avatar
陶建辉(Jeff) 已提交
5444
  pMsg->fsyncPeriod = htonl(pCreateDb->fsyncPeriod);
S
slguan 已提交
5445
  pMsg->compression = pCreateDb->compressionLevel;
H
hjxilinx 已提交
5446
  pMsg->walLevel = (char)pCreateDb->walLevel;
H
hjxilinx 已提交
5447
  pMsg->replications = pCreateDb->replica;
5448
  pMsg->quorum = pCreateDb->quorum;
5449
  pMsg->ignoreExist = pCreateDb->ignoreExists;
Y
yihaoDeng 已提交
5450
  pMsg->update = pCreateDb->update;
H
hjxilinx 已提交
5451 5452 5453
}

int32_t parseCreateDBOptions(SSqlCmd* pCmd, SCreateDBInfo* pCreateDbSql) {
S
TD-1732  
Shengliang Guan 已提交
5454
  SCreateDbMsg* pMsg = (SCreateDbMsg *)(pCmd->payload);
H
hjxilinx 已提交
5455
  setCreateDBOption(pMsg, pCreateDbSql);
H
hjxilinx 已提交
5456

H
hjxilinx 已提交
5457
  if (setKeepOption(pCmd, pMsg, pCreateDbSql) != TSDB_CODE_SUCCESS) {
5458
    return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
5459
  }
H
hjxilinx 已提交
5460

H
hjxilinx 已提交
5461
  if (setTimePrecision(pCmd, pMsg, pCreateDbSql) != TSDB_CODE_SUCCESS) {
5462
    return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
5463
  }
H
hjxilinx 已提交
5464

H
hjxilinx 已提交
5465
  if (tscCheckCreateDbParams(pCmd, pMsg) != TSDB_CODE_SUCCESS) {
5466
    return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
5467
  }
H
hjxilinx 已提交
5468

5469
  return TSDB_CODE_SUCCESS;
H
huili 已提交
5470
}
S
slguan 已提交
5471

5472 5473
void addGroupInfoForSubquery(SSqlObj* pParentObj, SSqlObj* pSql, int32_t subClauseIndex, int32_t tableIndex) {
  SQueryInfo* pParentQueryInfo = tscGetQueryInfoDetail(&pParentObj->cmd, subClauseIndex);
5474

5475 5476
  if (pParentQueryInfo->groupbyExpr.numOfGroupCols > 0) {
    SQueryInfo* pQueryInfo = tscGetQueryInfoDetail(&pSql->cmd, subClauseIndex);
H
Haojun Liao 已提交
5477 5478
    SSqlExpr* pExpr = NULL;

H
hjxilinx 已提交
5479
    size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
Haojun Liao 已提交
5480 5481 5482
    if (size > 0) {
      pExpr = tscSqlExprGet(pQueryInfo, (int32_t)size - 1);
    }
5483

H
Haojun Liao 已提交
5484
    if (pExpr == NULL || pExpr->functionId != TSDB_FUNC_TAG) {
H
Haojun Liao 已提交
5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496
      STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pParentQueryInfo, tableIndex);

      int16_t colId = tscGetJoinTagColIdByUid(&pQueryInfo->tagCond, pTableMetaInfo->pTableMeta->id.uid);

      SSchema* pTagSchema = tscGetColumnSchemaById(pTableMetaInfo->pTableMeta, colId);
      int16_t colIndex = tscGetTagColIndexById(pTableMetaInfo->pTableMeta, colId);
      SColumnIndex    index = {.tableIndex = 0, .columnIndex = colIndex};

      char*   name = pTagSchema->name;
      int16_t type = pTagSchema->type;
      int16_t bytes = pTagSchema->bytes;

H
Haojun Liao 已提交
5497
      pExpr = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_TAG, &index, type, bytes, getNewResColId(pQueryInfo), bytes, true);
S
slguan 已提交
5498 5499 5500 5501
      pExpr->colInfo.flag = TSDB_COL_TAG;

      // NOTE: tag column does not add to source column list
      SColumnList ids = {0};
S
TD-1057  
Shengliang Guan 已提交
5502
      insertResultField(pQueryInfo, (int32_t)size, &ids, bytes, (int8_t)type, name, pExpr);
S
slguan 已提交
5503 5504 5505

      int32_t relIndex = index.columnIndex;

5506
      pExpr->colInfo.colIndex = relIndex;
5507 5508
      SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, 0);
      pColIndex->colIndex = relIndex;
S
slguan 已提交
5509

5510
      index = (SColumnIndex) {.tableIndex = tableIndex, .columnIndex = relIndex};
H
hjxilinx 已提交
5511
      tscColumnListInsert(pTableMetaInfo->tagColList, &index);
S
slguan 已提交
5512 5513 5514 5515
    }
  }
}

H
hjxilinx 已提交
5516 5517 5518
// limit the output to be 1 for each state value
static void doLimitOutputNormalColOfGroupby(SSqlExpr* pExpr) {
  int32_t outputRow = 1;
H
hjxilinx 已提交
5519
  tVariantCreateFromBinary(&pExpr->param[0], (char*)&outputRow, sizeof(int32_t), TSDB_DATA_TYPE_INT);
H
hjxilinx 已提交
5520 5521 5522
  pExpr->numOfParams = 1;
}

5523
void doAddGroupColumnForSubquery(SQueryInfo* pQueryInfo, int32_t tagIndex) {
5524
  SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, tagIndex);
H
hjxilinx 已提交
5525
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
S
slguan 已提交
5526

H
Haojun Liao 已提交
5527 5528 5529 5530
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);

  SSchema*     pSchema = tscGetTableColumnSchema(pTableMetaInfo->pTableMeta, pColIndex->colIndex);
  SColumnIndex colIndex = {.tableIndex = 0, .columnIndex = pColIndex->colIndex};
H
hjxilinx 已提交
5531

S
TD-1057  
Shengliang Guan 已提交
5532
  tscAddSpecialColumnForSelect(pQueryInfo, (int32_t)size, TSDB_FUNC_PRJ, &colIndex, pSchema, TSDB_COL_NORMAL);
S
slguan 已提交
5533

H
Haojun Liao 已提交
5534 5535 5536
  int32_t numOfFields = tscNumOfFields(pQueryInfo);
  SInternalField* pInfo = tscFieldInfoGetInternalField(&pQueryInfo->fieldsInfo, numOfFields - 1);

H
Haojun Liao 已提交
5537
  doLimitOutputNormalColOfGroupby(pInfo->pSqlExpr);
H
hjxilinx 已提交
5538
  pInfo->visible = false;
S
slguan 已提交
5539 5540
}

5541
static void doUpdateSqlFunctionForTagPrj(SQueryInfo* pQueryInfo) {
S
slguan 已提交
5542
  int32_t tagLength = 0;
H
hjxilinx 已提交
5543
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
5544 5545 5546 5547 5548

//todo is 0??
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
  bool isSTable = UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo);

H
hjxilinx 已提交
5549
  for (int32_t i = 0; i < size; ++i) {
5550
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
5551 5552 5553 5554 5555 5556 5557 5558 5559
    if (pExpr->functionId == TSDB_FUNC_TAGPRJ || pExpr->functionId == TSDB_FUNC_TAG) {
      pExpr->functionId = TSDB_FUNC_TAG_DUMMY;
      tagLength += pExpr->resBytes;
    } else if (pExpr->functionId == TSDB_FUNC_PRJ && pExpr->colInfo.colId == PRIMARYKEY_TIMESTAMP_COL_INDEX) {
      pExpr->functionId = TSDB_FUNC_TS_DUMMY;
      tagLength += pExpr->resBytes;
    }
  }

5560
  SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
5561

H
hjxilinx 已提交
5562
  for (int32_t i = 0; i < size; ++i) {
5563
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
H
Haojun Liao 已提交
5564 5565
    if ((pExpr->functionId != TSDB_FUNC_TAG_DUMMY && pExpr->functionId != TSDB_FUNC_TS_DUMMY) &&
       !(pExpr->functionId == TSDB_FUNC_PRJ && TSDB_COL_IS_UD_COL(pExpr->colInfo.flag))) {
5566
      SSchema* pColSchema = &pSchema[pExpr->colInfo.colIndex];
S
TD-1057  
Shengliang Guan 已提交
5567
      getResultDataInfo(pColSchema->type, pColSchema->bytes, pExpr->functionId, (int32_t)pExpr->param[0].i64Key, &pExpr->resType,
5568
                        &pExpr->resBytes, &pExpr->interBytes, tagLength, isSTable);
S
slguan 已提交
5569 5570 5571 5572
    }
  }
}

H
Haojun Liao 已提交
5573
static int32_t doUpdateSqlFunctionForColPrj(SQueryInfo* pQueryInfo) {
H
hjxilinx 已提交
5574
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5575 5576
  
  for (int32_t i = 0; i < size; ++i) {
5577
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
H
Haojun Liao 已提交
5578

5579
    if (pExpr->functionId == TSDB_FUNC_PRJ && (!TSDB_COL_IS_UD_COL(pExpr->colInfo.flag) && (pExpr->colInfo.colId != PRIMARYKEY_TIMESTAMP_COL_INDEX))) {
H
hjxilinx 已提交
5580
      bool qualifiedCol = false;
5581
      for (int32_t j = 0; j < pQueryInfo->groupbyExpr.numOfGroupCols; ++j) {
5582 5583 5584
        SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, j);
  
        if (pExpr->colInfo.colId == pColIndex->colId) {
H
hjxilinx 已提交
5585
          qualifiedCol = true;
H
hjxilinx 已提交
5586
          doLimitOutputNormalColOfGroupby(pExpr);
H
hjxilinx 已提交
5587 5588 5589 5590
          pExpr->numOfParams = 1;
          break;
        }
      }
H
hjxilinx 已提交
5591

H
Haojun Liao 已提交
5592 5593 5594 5595
      // it is not a tag column/tbname column/user-defined column, return error
      if (!qualifiedCol) {
        return TSDB_CODE_TSC_INVALID_SQL;
      }
H
hjxilinx 已提交
5596 5597
    }
  }
H
Haojun Liao 已提交
5598 5599

  return TSDB_CODE_SUCCESS;
H
hjxilinx 已提交
5600 5601
}

S
slguan 已提交
5602 5603
static bool tagColumnInGroupby(SSqlGroupbyExpr* pGroupbyExpr, int16_t columnId) {
  for (int32_t j = 0; j < pGroupbyExpr->numOfGroupCols; ++j) {
5604 5605
    SColIndex* pColIndex = taosArrayGet(pGroupbyExpr->columnInfo, j);
  
Y
TD-1230  
yihaoDeng 已提交
5606
    if (columnId == pColIndex->colId && TSDB_COL_IS_TAG(pColIndex->flag )) {
S
slguan 已提交
5607 5608 5609 5610 5611 5612 5613
      return true;
    }
  }

  return false;
}

5614
static bool onlyTagPrjFunction(SQueryInfo* pQueryInfo) {
S
slguan 已提交
5615 5616
  bool hasTagPrj = false;
  bool hasColumnPrj = false;
H
hjxilinx 已提交
5617
  
H
hjxilinx 已提交
5618
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5619
  for (int32_t i = 0; i < size; ++i) {
5620
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631
    if (pExpr->functionId == TSDB_FUNC_PRJ) {
      hasColumnPrj = true;
    } else if (pExpr->functionId == TSDB_FUNC_TAGPRJ) {
      hasTagPrj = true;
    }
  }

  return (hasTagPrj) && (hasColumnPrj == false);
}

// check if all the tags prj columns belongs to the group by columns
5632
static bool allTagPrjInGroupby(SQueryInfo* pQueryInfo) {
S
slguan 已提交
5633 5634
  bool allInGroupby = true;

H
hjxilinx 已提交
5635 5636
  size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  for (int32_t i = 0; i < size; ++i) {
5637
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
5638 5639 5640 5641
    if (pExpr->functionId != TSDB_FUNC_TAGPRJ) {
      continue;
    }

5642
    if (!tagColumnInGroupby(&pQueryInfo->groupbyExpr, pExpr->colInfo.colId)) {
S
slguan 已提交
5643 5644 5645 5646 5647 5648 5649 5650 5651
      allInGroupby = false;
      break;
    }
  }

  // all selected tag columns belong to the group by columns set, always correct
  return allInGroupby;
}

5652
static void updateTagPrjFunction(SQueryInfo* pQueryInfo) {
H
hjxilinx 已提交
5653
  size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5654 5655
  
  for (int32_t i = 0; i < size; ++i) {
5656
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668
    if (pExpr->functionId == TSDB_FUNC_TAGPRJ) {
      pExpr->functionId = TSDB_FUNC_TAG;
    }
  }
}

/*
 * check for selectivity function + tags column function both exist.
 * 1. tagprj functions are not compatible with aggregated function when missing "group by" clause
 * 2. if selectivity function and tagprj function both exist, there should be only
 *    one selectivity function exists.
 */
5669
static int32_t checkUpdateTagPrjFunctions(SQueryInfo* pQueryInfo, SSqlCmd* pCmd) {
S
slguan 已提交
5670
  const char* msg1 = "only one selectivity function allowed in presence of tags function";
H
hjxilinx 已提交
5671
  const char* msg3 = "aggregation function should not be mixed up with projection";
H
hjxilinx 已提交
5672

H
Haojun Liao 已提交
5673
  bool    tagTsColExists = false;
S
slguan 已提交
5674 5675 5676
  int16_t numOfSelectivity = 0;
  int16_t numOfAggregation = 0;

H
hjxilinx 已提交
5677
  size_t numOfExprs = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
5678
  for (int32_t i = 0; i < numOfExprs; ++i) {
H
hjxilinx 已提交
5679
    SSqlExpr* pExpr = taosArrayGetP(pQueryInfo->exprList, i);
S
slguan 已提交
5680 5681
    if (pExpr->functionId == TSDB_FUNC_TAGPRJ ||
        (pExpr->functionId == TSDB_FUNC_PRJ && pExpr->colInfo.colId == PRIMARYKEY_TIMESTAMP_COL_INDEX)) {
H
Haojun Liao 已提交
5682
      tagTsColExists = true;  // selectivity + ts/tag column
S
slguan 已提交
5683 5684 5685
      break;
    }
  }
H
hjxilinx 已提交
5686

H
hjxilinx 已提交
5687
  for (int32_t i = 0; i < numOfExprs; ++i) {
H
hjxilinx 已提交
5688
    SSqlExpr* pExpr = taosArrayGetP(pQueryInfo->exprList, i);
H
hjxilinx 已提交
5689 5690
  
    int16_t functionId = pExpr->functionId;
5691
    if (functionId == TSDB_FUNC_TAGPRJ || functionId == TSDB_FUNC_PRJ || functionId == TSDB_FUNC_TS ||
H
hjxilinx 已提交
5692
        functionId == TSDB_FUNC_ARITHM) {
H
hjxilinx 已提交
5693
      continue;
S
slguan 已提交
5694
    }
H
hjxilinx 已提交
5695

H
hjxilinx 已提交
5696 5697 5698 5699 5700 5701
    if ((aAggs[functionId].nStatus & TSDB_FUNCSTATE_SELECTIVITY) != 0) {
      numOfSelectivity++;
    } else {
      numOfAggregation++;
    }
  }
H
hjxilinx 已提交
5702

H
Haojun Liao 已提交
5703
  if (tagTsColExists) {  // check if the selectivity function exists
S
slguan 已提交
5704 5705
    // When the tag projection function on tag column that is not in the group by clause, aggregation function and
    // selectivity function exist in select clause is not allowed.
5706
    if (numOfAggregation > 0) {
5707
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
5708 5709 5710 5711 5712 5713
    }

    /*
     *  if numOfSelectivity equals to 0, it is a super table projection query
     */
    if (numOfSelectivity == 1) {
5714
      doUpdateSqlFunctionForTagPrj(pQueryInfo);
H
Haojun Liao 已提交
5715 5716 5717 5718 5719
      int32_t code = doUpdateSqlFunctionForColPrj(pQueryInfo);
      if (code != TSDB_CODE_SUCCESS) {
        return code;
      }

S
slguan 已提交
5720 5721 5722 5723 5724
    } else if (numOfSelectivity > 1) {
      /*
       * If more than one selectivity functions exist, all the selectivity functions must be last_row.
       * Otherwise, return with error code.
       */
H
hjxilinx 已提交
5725
      for (int32_t i = 0; i < numOfExprs; ++i) {
H
Haojun Liao 已提交
5726 5727 5728
        SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
        int16_t functionId = pExpr->functionId;
        if (functionId == TSDB_FUNC_TAGPRJ || (aAggs[functionId].nStatus & TSDB_FUNCSTATE_SELECTIVITY) == 0) {
S
slguan 已提交
5729 5730 5731
          continue;
        }

H
Haojun Liao 已提交
5732 5733 5734 5735
        if ((functionId == TSDB_FUNC_LAST_ROW) ||
             (functionId == TSDB_FUNC_LAST_DST && (pExpr->colInfo.flag & TSDB_COL_NULL) != 0)) {
          // do nothing
        } else {
5736
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
5737 5738 5739
        }
      }

5740
      doUpdateSqlFunctionForTagPrj(pQueryInfo);
H
Haojun Liao 已提交
5741 5742 5743 5744
      int32_t code = doUpdateSqlFunctionForColPrj(pQueryInfo);
      if (code != TSDB_CODE_SUCCESS) {
        return code;
      }
H
hjxilinx 已提交
5745 5746
    }
  } else {
5747
    if ((pQueryInfo->type & TSDB_QUERY_TYPE_PROJECTION_QUERY) != 0) {
5748
      if (numOfAggregation > 0 && pQueryInfo->groupbyExpr.numOfGroupCols == 0) {
5749
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
H
hjxilinx 已提交
5750
      }
H
hjxilinx 已提交
5751

H
hjxilinx 已提交
5752 5753
      if (numOfAggregation > 0 || numOfSelectivity > 0) {
        // clear the projection type flag
5754
        pQueryInfo->type &= (~TSDB_QUERY_TYPE_PROJECTION_QUERY);
H
Haojun Liao 已提交
5755 5756 5757 5758
        int32_t code = doUpdateSqlFunctionForColPrj(pQueryInfo);
        if (code != TSDB_CODE_SUCCESS) {
          return code;
        }
H
hjxilinx 已提交
5759
      }
S
slguan 已提交
5760 5761 5762 5763 5764 5765
    }
  }

  return TSDB_CODE_SUCCESS;
}

5766
static int32_t doAddGroupbyColumnsOnDemand(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
S
slguan 已提交
5767 5768
  const char* msg2 = "interval not allowed in group by normal column";

H
hjxilinx 已提交
5769
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
S
slguan 已提交
5770

H
Haojun Liao 已提交
5771
  SSchema s = tGetTableNameColumnSchema();
H
hjxilinx 已提交
5772
  SSchema* pSchema = tscGetTableSchema(pTableMetaInfo->pTableMeta);
S
slguan 已提交
5773 5774 5775 5776
  int16_t  bytes = 0;
  int16_t  type = 0;
  char*    name = NULL;

5777
  for (int32_t i = 0; i < pQueryInfo->groupbyExpr.numOfGroupCols; ++i) {
5778
    SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, i);
5779
    int16_t colIndex = pColIndex->colIndex;
5780
    if (colIndex == TSDB_TBNAME_COLUMN_INDEX) {
H
Haojun Liao 已提交
5781
      type  = s.type;
H
Haojun Liao 已提交
5782
      bytes = s.bytes;
H
Haojun Liao 已提交
5783
      name  = s.name;
S
slguan 已提交
5784
    } else {
5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795
      if (TSDB_COL_IS_TAG(pColIndex->flag)) {
        SSchema* tagSchema = tscGetTableTagSchema(pTableMetaInfo->pTableMeta);
        
        type  = tagSchema[colIndex].type;
        bytes = tagSchema[colIndex].bytes;
        name  = tagSchema[colIndex].name;
      } else {
        type  = pSchema[colIndex].type;
        bytes = pSchema[colIndex].bytes;
        name  = pSchema[colIndex].name;
      }
S
slguan 已提交
5796
    }
H
hjxilinx 已提交
5797 5798 5799
  
    size_t size = tscSqlExprNumOfExprs(pQueryInfo);
  
S
slguan 已提交
5800
    if (TSDB_COL_IS_TAG(pColIndex->flag)) {
5801
      SColumnIndex index = {.tableIndex = pQueryInfo->groupbyExpr.tableIndex, .columnIndex = colIndex};
H
Haojun Liao 已提交
5802
      SSqlExpr* pExpr = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_TAG, &index, type, bytes, getNewResColId(pQueryInfo), bytes, true);
5803
      
B
Bomin Zhang 已提交
5804 5805
      memset(pExpr->aliasName, 0, sizeof(pExpr->aliasName));
      tstrncpy(pExpr->aliasName, name, sizeof(pExpr->aliasName));
5806
      
S
slguan 已提交
5807 5808 5809
      pExpr->colInfo.flag = TSDB_COL_TAG;

      // NOTE: tag column does not add to source column list
5810
      SColumnList ids = getColumnList(1, 0, pColIndex->colIndex);
S
TD-1057  
Shengliang Guan 已提交
5811
      insertResultField(pQueryInfo, (int32_t)size, &ids, bytes, (int8_t)type, name, pExpr);
S
slguan 已提交
5812 5813
    } else {
      // if this query is "group by" normal column, interval is not allowed
5814
      if (pQueryInfo->interval.interval > 0) {
5815
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
5816 5817 5818
      }

      bool hasGroupColumn = false;
H
hjxilinx 已提交
5819
      for (int32_t j = 0; j < size; ++j) {
5820
        SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, j);
S
slguan 已提交
5821 5822 5823 5824 5825 5826 5827 5828 5829 5830
        if (pExpr->colInfo.colId == pColIndex->colId) {
          break;
        }
      }

      /*
       * if the group by column does not required by user, add this column into the final result set
       * but invisible to user
       */
      if (!hasGroupColumn) {
5831
        doAddGroupColumnForSubquery(pQueryInfo, i);
S
slguan 已提交
5832 5833 5834 5835 5836 5837 5838
      }
    }
  }

  return TSDB_CODE_SUCCESS;
}

5839
int32_t doFunctionsCompatibleCheck(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
S
slguan 已提交
5840
  const char* msg1 = "functions/columns not allowed in group by query";
H
hjxilinx 已提交
5841
  const char* msg2 = "projection query on columns not allowed";
S
slguan 已提交
5842
  const char* msg3 = "group by not allowed on projection query";
H
hjxilinx 已提交
5843
  const char* msg4 = "retrieve tags not compatible with group by or interval query";
S
slguan 已提交
5844 5845

  // only retrieve tags, group by is not supportted
H
hjxilinx 已提交
5846
  if (tscQueryTags(pQueryInfo)) {
5847
    if (pQueryInfo->groupbyExpr.numOfGroupCols > 0 || pQueryInfo->interval.interval > 0) {
5848
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
S
slguan 已提交
5849 5850 5851 5852 5853
    } else {
      return TSDB_CODE_SUCCESS;
    }
  }

5854
  if (pQueryInfo->groupbyExpr.numOfGroupCols > 0) {
S
slguan 已提交
5855
    // check if all the tags prj columns belongs to the group by columns
5856 5857
    if (onlyTagPrjFunction(pQueryInfo) && allTagPrjInGroupby(pQueryInfo)) {
      updateTagPrjFunction(pQueryInfo);
5858
      return doAddGroupbyColumnsOnDemand(pCmd, pQueryInfo);
S
slguan 已提交
5859 5860 5861
    }

    // check all query functions in selection clause, multi-output functions are not allowed
H
hjxilinx 已提交
5862 5863
    size_t size = tscSqlExprNumOfExprs(pQueryInfo);
    for (int32_t i = 0; i < size; ++i) {
5864
      SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
S
slguan 已提交
5865 5866 5867 5868 5869 5870
      int32_t   functId = pExpr->functionId;

      /*
       * group by normal columns.
       * Check if the column projection is identical to the group by column or not
       */
5871
      if (functId == TSDB_FUNC_PRJ && pExpr->colInfo.colId != PRIMARYKEY_TIMESTAMP_COL_INDEX) {
S
slguan 已提交
5872
        bool qualified = false;
5873
        for (int32_t j = 0; j < pQueryInfo->groupbyExpr.numOfGroupCols; ++j) {
5874
          SColIndex* pColIndex = taosArrayGet(pQueryInfo->groupbyExpr.columnInfo, j);
S
slguan 已提交
5875 5876 5877 5878 5879 5880 5881
          if (pColIndex->colId == pExpr->colInfo.colId) {
            qualified = true;
            break;
          }
        }

        if (!qualified) {
5882
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
S
slguan 已提交
5883 5884 5885 5886
        }
      }

      if (IS_MULTIOUTPUT(aAggs[functId].nStatus) && functId != TSDB_FUNC_TOP && functId != TSDB_FUNC_BOTTOM &&
H
hjxilinx 已提交
5887
          functId != TSDB_FUNC_TAGPRJ && functId != TSDB_FUNC_PRJ) {
5888
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
5889 5890
      }

5891
      if (functId == TSDB_FUNC_COUNT && pExpr->colInfo.colIndex == TSDB_TBNAME_COLUMN_INDEX) {
5892
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
S
slguan 已提交
5893 5894 5895
      }
    }

5896
    if (checkUpdateTagPrjFunctions(pQueryInfo, pCmd) != TSDB_CODE_SUCCESS) {
5897
      return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
5898 5899 5900 5901 5902 5903
    }

    /*
     * group by tag function must be not changed the function name, otherwise, the group operation may fail to
     * divide the subset of final result.
     */
5904
    if (doAddGroupbyColumnsOnDemand(pCmd, pQueryInfo) != TSDB_CODE_SUCCESS) {
5905
      return TSDB_CODE_TSC_INVALID_SQL;
S
slguan 已提交
5906 5907
    }

H
hjxilinx 已提交
5908
    // projection query on super table does not compatible with "group by" syntax
5909
    if (tscNonOrderedProjectionQueryOnSTable(pQueryInfo, 0)) {
5910
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
S
slguan 已提交
5911
    }
H
hjxilinx 已提交
5912

H
hjxilinx 已提交
5913
    return TSDB_CODE_SUCCESS;
S
slguan 已提交
5914
  } else {
5915
    return checkUpdateTagPrjFunctions(pQueryInfo, pCmd);
S
slguan 已提交
5916 5917
  }
}
5918
int32_t doLocalQueryProcess(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, SQuerySQL* pQuerySql) {
H
hjxilinx 已提交
5919 5920 5921
  const char* msg1 = "only one expression allowed";
  const char* msg2 = "invalid expression in select clause";
  const char* msg3 = "invalid function";
H
hjxilinx 已提交
5922

H
hjxilinx 已提交
5923 5924
  tSQLExprList* pExprList = pQuerySql->pSelection;
  if (pExprList->nExpr != 1) {
5925
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
H
hjxilinx 已提交
5926
  }
Y
yihaoDeng 已提交
5927
  bool server_status = false;
H
hjxilinx 已提交
5928 5929
  tSQLExpr* pExpr = pExprList->a[0].pNode;
  if (pExpr->operand.z == NULL) {
Y
yihaoDeng 已提交
5930 5931 5932 5933 5934 5935 5936
    //handle 'select 1'
    if (pExpr->token.n == 1 && 0 == strncasecmp(pExpr->token.z, "1", 1)) {
      server_status = true; 
    } else {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
    } 
  } 
H
hjxilinx 已提交
5937
  // TODO redefine the function
Y
yihaoDeng 已提交
5938 5939 5940 5941 5942
   SDNodeDynConfOption functionsInfo[5] = {{"database()", 10},
                                            {"server_version()", 16},
                                            {"server_status()", 15},
                                            {"client_version()", 16},
                                            {"current_user()", 14}};
H
hjxilinx 已提交
5943

H
hjxilinx 已提交
5944
  int32_t index = -1;
Y
yihaoDeng 已提交
5945 5946 5947 5948 5949 5950 5951 5952 5953
  if (server_status == true) {
    index = 2;
  } else {
    for (int32_t i = 0; i < tListLen(functionsInfo); ++i) {
      if (strncasecmp(functionsInfo[i].name, pExpr->operand.z, functionsInfo[i].len) == 0 &&
          functionsInfo[i].len == pExpr->operand.n) {
        index = i;
        break;
      }
H
hjxilinx 已提交
5954 5955
    }
  }
H
hjxilinx 已提交
5956 5957 5958

  switch (index) {
    case 0:
H
Haojun Liao 已提交
5959
      pQueryInfo->command = TSDB_SQL_CURRENT_DB;break;
H
hjxilinx 已提交
5960
    case 1:
H
Haojun Liao 已提交
5961 5962 5963
      pQueryInfo->command = TSDB_SQL_SERV_VERSION;break;
      case 2:
      pQueryInfo->command = TSDB_SQL_SERV_STATUS;break;
H
hjxilinx 已提交
5964
    case 3:
H
Haojun Liao 已提交
5965
      pQueryInfo->command = TSDB_SQL_CLI_VERSION;break;
H
hjxilinx 已提交
5966
    case 4:
H
Haojun Liao 已提交
5967
      pQueryInfo->command = TSDB_SQL_CURRENT_USER;break;
5968
    default: { return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3); }
H
hjxilinx 已提交
5969
  }
5970 5971 5972
  
  SColumnIndex ind = {0};
  SSqlExpr* pExpr1 = tscSqlExprAppend(pQueryInfo, TSDB_FUNC_TAG_DUMMY, &ind, TSDB_DATA_TYPE_INT,
H
Haojun Liao 已提交
5973
                                      tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize, getNewResColId(pQueryInfo), tDataTypeDesc[TSDB_DATA_TYPE_INT].nSize, false);
5974 5975
  
  const char* name = (pExprList->a[0].aliasName != NULL)? pExprList->a[0].aliasName:functionsInfo[index].name;
B
Bomin Zhang 已提交
5976
  tstrncpy(pExpr1->aliasName, name, tListLen(pExpr1->aliasName));
H
Haojun Liao 已提交
5977 5978
  
  return TSDB_CODE_SUCCESS;
H
hjxilinx 已提交
5979
}
H
hjxilinx 已提交
5980 5981

// can only perform the parameters based on the macro definitation
S
TD-1732  
Shengliang Guan 已提交
5982
int32_t tscCheckCreateDbParams(SSqlCmd* pCmd, SCreateDbMsg* pCreate) {
H
hjxilinx 已提交
5983
  char msg[512] = {0};
H
hjxilinx 已提交
5984

H
hjxilinx 已提交
5985
  if (pCreate->walLevel != -1 && (pCreate->walLevel < TSDB_MIN_WAL_LEVEL || pCreate->walLevel > TSDB_MAX_WAL_LEVEL)) {
S
TD-1388  
Shengliang Guan 已提交
5986
    snprintf(msg, tListLen(msg), "invalid db option walLevel: %d, only 1-2 allowed", pCreate->walLevel);
5987
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
5988
  }
H
hjxilinx 已提交
5989

H
hjxilinx 已提交
5990
  if (pCreate->replications != -1 &&
5991
      (pCreate->replications < TSDB_MIN_DB_REPLICA_OPTION || pCreate->replications > TSDB_MAX_DB_REPLICA_OPTION)) {
H
hjxilinx 已提交
5992
    snprintf(msg, tListLen(msg), "invalid db option replications: %d valid range: [%d, %d]", pCreate->replications,
5993
             TSDB_MIN_DB_REPLICA_OPTION, TSDB_MAX_DB_REPLICA_OPTION);
5994
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
5995
  }
H
hjxilinx 已提交
5996

5997 5998 5999 6000 6001 6002 6003
  if (pCreate->quorum != -1 &&
      (pCreate->quorum < TSDB_MIN_DB_REPLICA_OPTION || pCreate->quorum > TSDB_MAX_DB_REPLICA_OPTION)) {
    snprintf(msg, tListLen(msg), "invalid db option quorum: %d valid range: [%d, %d]", pCreate->quorum,
             TSDB_MIN_DB_REPLICA_OPTION, TSDB_MAX_DB_REPLICA_OPTION);
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
  }

H
hjxilinx 已提交
6004
  int32_t val = htonl(pCreate->daysPerFile);
S
slguan 已提交
6005
  if (val != -1 && (val < TSDB_MIN_DAYS_PER_FILE || val > TSDB_MAX_DAYS_PER_FILE)) {
H
hjxilinx 已提交
6006
    snprintf(msg, tListLen(msg), "invalid db option daysPerFile: %d valid range: [%d, %d]", val,
S
slguan 已提交
6007
             TSDB_MIN_DAYS_PER_FILE, TSDB_MAX_DAYS_PER_FILE);
6008
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6009
  }
H
hjxilinx 已提交
6010

H
hjxilinx 已提交
6011 6012 6013 6014
  val = htonl(pCreate->cacheBlockSize);
  if (val != -1 && (val < TSDB_MIN_CACHE_BLOCK_SIZE || val > TSDB_MAX_CACHE_BLOCK_SIZE)) {
    snprintf(msg, tListLen(msg), "invalid db option cacheBlockSize: %d valid range: [%d, %d]", val,
             TSDB_MIN_CACHE_BLOCK_SIZE, TSDB_MAX_CACHE_BLOCK_SIZE);
6015
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6016
  }
H
hjxilinx 已提交
6017

H
hjxilinx 已提交
6018
  val = htonl(pCreate->maxTables);
S
slguan 已提交
6019
  if (val != -1 && (val < TSDB_MIN_TABLES || val > TSDB_MAX_TABLES)) {
H
hjxilinx 已提交
6020
    snprintf(msg, tListLen(msg), "invalid db option maxSessions: %d valid range: [%d, %d]", val,
S
slguan 已提交
6021
             TSDB_MIN_TABLES, TSDB_MAX_TABLES);
6022
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6023
  }
H
hjxilinx 已提交
6024 6025 6026 6027

  if (pCreate->precision != TSDB_TIME_PRECISION_MILLI && pCreate->precision != TSDB_TIME_PRECISION_MICRO) {
    snprintf(msg, tListLen(msg), "invalid db option timePrecision: %d valid value: [%d, %d]", pCreate->precision,
             TSDB_TIME_PRECISION_MILLI, TSDB_TIME_PRECISION_MICRO);
6028
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6029
  }
H
hjxilinx 已提交
6030

H
hjxilinx 已提交
6031
  val = htonl(pCreate->commitTime);
S
slguan 已提交
6032
  if (val != -1 && (val < TSDB_MIN_COMMIT_TIME || val > TSDB_MAX_COMMIT_TIME)) {
H
hjxilinx 已提交
6033
    snprintf(msg, tListLen(msg), "invalid db option commitTime: %d valid range: [%d, %d]", val,
S
slguan 已提交
6034
             TSDB_MIN_COMMIT_TIME, TSDB_MAX_COMMIT_TIME);
6035
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6036
  }
H
hjxilinx 已提交
6037

陶建辉(Jeff)'s avatar
陶建辉(Jeff) 已提交
6038 6039 6040 6041 6042 6043 6044
  val = htonl(pCreate->fsyncPeriod);
  if (val != -1 && (val < TSDB_MIN_FSYNC_PERIOD || val > TSDB_MAX_FSYNC_PERIOD)) {
    snprintf(msg, tListLen(msg), "invalid db option fsyncPeriod: %d valid range: [%d, %d]", val,
             TSDB_MIN_FSYNC_PERIOD, TSDB_MAX_FSYNC_PERIOD);
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
  }

H
hjxilinx 已提交
6045
  if (pCreate->compression != -1 &&
S
slguan 已提交
6046
      (pCreate->compression < TSDB_MIN_COMP_LEVEL || pCreate->compression > TSDB_MAX_COMP_LEVEL)) {
H
hjxilinx 已提交
6047
    snprintf(msg, tListLen(msg), "invalid db option compression: %d valid range: [%d, %d]", pCreate->compression,
S
slguan 已提交
6048
             TSDB_MIN_COMP_LEVEL, TSDB_MAX_COMP_LEVEL);
6049
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg);
H
hjxilinx 已提交
6050
  }
H
hjxilinx 已提交
6051

H
hjxilinx 已提交
6052 6053
  return TSDB_CODE_SUCCESS;
}
H
hjxilinx 已提交
6054 6055

// for debug purpose
H
hjxilinx 已提交
6056 6057
void tscPrintSelectClause(SSqlObj* pSql, int32_t subClauseIndex) {
  SQueryInfo* pQueryInfo = tscGetQueryInfoDetail(&pSql->cmd, subClauseIndex);
6058

S
TD-1057  
Shengliang Guan 已提交
6059
  int32_t size = (int32_t)tscSqlExprNumOfExprs(pQueryInfo);
H
hjxilinx 已提交
6060
  if (size == 0) {
H
hjxilinx 已提交
6061 6062
    return;
  }
H
hjxilinx 已提交
6063

H
hjxilinx 已提交
6064
  int32_t totalBufSize = 1024;
H
hjxilinx 已提交
6065 6066

  char    str[1024] = {0};
H
hjxilinx 已提交
6067
  int32_t offset = 0;
H
hjxilinx 已提交
6068

H
hjxilinx 已提交
6069 6070
  offset += sprintf(str, "num:%d [", size);
  for (int32_t i = 0; i < size; ++i) {
6071
    SSqlExpr* pExpr = tscSqlExprGet(pQueryInfo, i);
H
hjxilinx 已提交
6072

L
lihui 已提交
6073
    char    tmpBuf[1024] = {0};
H
hjxilinx 已提交
6074 6075 6076
    int32_t tmpLen = 0;
    tmpLen =
        sprintf(tmpBuf, "%s(uid:%" PRId64 ", %d)", aAggs[pExpr->functionId].aName, pExpr->uid, pExpr->colInfo.colId);
L
lihui 已提交
6077 6078 6079
    if (tmpLen + offset > totalBufSize) break;

    offset += sprintf(str + offset, "%s", tmpBuf);
H
hjxilinx 已提交
6080

H
hjxilinx 已提交
6081
    if (i < size - 1) {
H
hjxilinx 已提交
6082 6083 6084
      str[offset++] = ',';
    }
  }
H
hjxilinx 已提交
6085

H
hjxilinx 已提交
6086
  str[offset] = ']';
6087
  tscDebug("%p select clause:%s", pSql, str);
H
hjxilinx 已提交
6088
}
6089

6090
int32_t doCheckForCreateTable(SSqlObj* pSql, int32_t subClauseIndex, SSqlInfo* pInfo) {
6091 6092
  const char* msg1 = "invalid table name";

6093 6094
  SSqlCmd*        pCmd = &pSql->cmd;
  SQueryInfo*     pQueryInfo = tscGetQueryInfoDetail(pCmd, subClauseIndex);
H
hjxilinx 已提交
6095
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
6096 6097 6098

  SCreateTableSQL* pCreateTable = pInfo->pCreateTableInfo;

H
Haojun Liao 已提交
6099 6100
  SArray* pFieldList = pCreateTable->colInfo.pColumns;
  SArray* pTagList = pCreateTable->colInfo.pTagColumns;
6101 6102 6103 6104

  assert(pFieldList != NULL);

  // if sql specifies db, use it, otherwise use default db
H
Haojun Liao 已提交
6105
  SStrToken* pzTableName = &(pCreateTable->name);
6106 6107

  if (tscValidateName(pzTableName) != TSDB_CODE_SUCCESS) {
6108
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
6109 6110
  }

H
Haojun Liao 已提交
6111 6112 6113
  int32_t code = tscSetTableFullName(pTableMetaInfo, pzTableName, pSql);
  if(code != TSDB_CODE_SUCCESS) {
    return code;
6114 6115 6116 6117
  }

  if (!validateTableColumnInfo(pFieldList, pCmd) ||
      (pTagList != NULL && !validateTagParams(pTagList, pFieldList, pCmd))) {
6118
    return TSDB_CODE_TSC_INVALID_SQL;
6119 6120 6121
  }

  int32_t col = 0;
H
Haojun Liao 已提交
6122 6123 6124
  size_t numOfFields = taosArrayGetSize(pFieldList);

  for (; col < numOfFields; ++col) {
H
Haojun Liao 已提交
6125
    TAOS_FIELD* p = taosArrayGet(pFieldList, col);
H
Haojun Liao 已提交
6126
    tscFieldInfoAppend(&pQueryInfo->fieldsInfo, p);
6127 6128
  }

H
Haojun Liao 已提交
6129
  pCmd->numOfCols = (int16_t)numOfFields;
6130

H
hjxilinx 已提交
6131
  if (pTagList != NULL) {  // create super table[optional]
H
Haojun Liao 已提交
6132 6133
    size_t numOfTags = taosArrayGetSize(pTagList);
    for (int32_t i = 0; i < numOfTags; ++i) {
H
Haojun Liao 已提交
6134 6135
      TAOS_FIELD* p = taosArrayGet(pTagList, i);
      tscFieldInfoAppend(&pQueryInfo->fieldsInfo, p);
6136 6137
    }

S
Shengliang Guan 已提交
6138
    pCmd->count =(int32_t) numOfTags;
6139 6140 6141 6142 6143 6144 6145 6146 6147 6148 6149 6150 6151 6152
  }

  return TSDB_CODE_SUCCESS;
}

int32_t doCheckForCreateFromStable(SSqlObj* pSql, SSqlInfo* pInfo) {
  const char* msg1 = "invalid table name";
  const char* msg3 = "tag value too long";
  const char* msg4 = "illegal value or data overflow";
  const char* msg5 = "tags number not matched";

  SSqlCmd* pCmd = &pSql->cmd;

  SCreateTableSQL* pCreateTable = pInfo->pCreateTableInfo;
6153 6154 6155
  SQueryInfo*      pQueryInfo = tscGetQueryInfoDetail(pCmd, 0);

  // two table: the first one is for current table, and the secondary is for the super table.
6156 6157 6158
  if (pQueryInfo->numOfTables < 2) {
    tscAddEmptyMetaInfo(pQueryInfo);
  }
6159 6160 6161 6162

  const int32_t TABLE_INDEX = 0;
  const int32_t STABLE_INDEX = 1;

6163
  STableMetaInfo* pStableMetaInfo = tscGetMetaInfo(pQueryInfo, STABLE_INDEX);
6164 6165

  // super table name, create table by using dst
H
Haojun Liao 已提交
6166
  int32_t numOfTables = (int32_t) taosArrayGetSize(pCreateTable->childTableInfo);
6167 6168
  for(int32_t j = 0; j < numOfTables; ++j) {
    SCreatedTableInfo* pCreateTableInfo = taosArrayGet(pCreateTable->childTableInfo, j);
6169

6170 6171 6172 6173
    SStrToken* pToken = &pCreateTableInfo->stableName;
    if (tscValidateName(pToken) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
    }
6174

6175 6176 6177 6178
    int32_t code = tscSetTableFullName(pStableMetaInfo, pToken, pSql);
    if (code != TSDB_CODE_SUCCESS) {
      return code;
    }
6179

6180 6181 6182
    // get table meta from mnode
    tstrncpy(pCreateTableInfo->tagdata.name, pStableMetaInfo->name, tListLen(pCreateTableInfo->tagdata.name));
    SArray* pList = pCreateTableInfo->pTagVals;
6183

6184 6185 6186 6187
    code = tscGetTableMeta(pSql, pStableMetaInfo);
    if (code != TSDB_CODE_SUCCESS) {
      return code;
    }
6188

6189 6190 6191 6192
    size_t size = taosArrayGetSize(pList);
    if (tscGetNumOfTags(pStableMetaInfo->pTableMeta) != size) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
    }
6193

6194 6195 6196
    // too long tag values will return invalid sql, not be truncated automatically
    SSchema  *pTagSchema = tscGetTableTagSchema(pStableMetaInfo->pTableMeta);
    STagData *pTag = &pCreateTableInfo->tagdata;
6197

6198 6199 6200 6201
    SKVRowBuilder kvRowBuilder = {0};
    if (tdInitKVRowBuilder(&kvRowBuilder) < 0) {
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
    }
B
Bomin Zhang 已提交
6202

6203 6204 6205 6206
    int32_t ret = TSDB_CODE_SUCCESS;
    for (int32_t i = 0; i < size; ++i) {
      SSchema*          pSchema = &pTagSchema[i];
      tVariantListItem* pItem = taosArrayGet(pList, i);
H
Haojun Liao 已提交
6207

6208 6209 6210 6211 6212 6213
      char tagVal[TSDB_MAX_TAGS_LEN];
      if (pSchema->type == TSDB_DATA_TYPE_BINARY || pSchema->type == TSDB_DATA_TYPE_NCHAR) {
        if (pItem->pVar.nLen > pSchema->bytes) {
          tdDestroyKVRowBuilder(&kvRowBuilder);
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
        }
H
hjxilinx 已提交
6214
      }
H
Haojun Liao 已提交
6215

6216
      ret = tVariantDump(&(pItem->pVar), tagVal, pSchema->type, true);
H
Haojun Liao 已提交
6217

6218 6219 6220 6221 6222 6223 6224 6225 6226 6227
      // check again after the convert since it may be converted from binary to nchar.
      if (pSchema->type == TSDB_DATA_TYPE_BINARY || pSchema->type == TSDB_DATA_TYPE_NCHAR) {
        int16_t len = varDataTLen(tagVal);
        if (len > pSchema->bytes) {
          tdDestroyKVRowBuilder(&kvRowBuilder);
          return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
        }
      }

      if (ret != TSDB_CODE_SUCCESS) {
H
Haojun Liao 已提交
6228
        tdDestroyKVRowBuilder(&kvRowBuilder);
6229
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
H
Haojun Liao 已提交
6230 6231
      }

6232
      tdAddColToKVRow(&kvRowBuilder, pSchema->colId, pSchema->type, tagVal);
6233 6234
    }

6235 6236 6237 6238 6239 6240 6241
    SKVRow row = tdGetKVRowFromBuilder(&kvRowBuilder);
    tdDestroyKVRowBuilder(&kvRowBuilder);
    if (row == NULL) {
      return TSDB_CODE_TSC_OUT_OF_MEMORY;
    }
    tdSortKVRowByColIdx(row);
    pTag->dataLen = kvRowLen(row);
H
Haojun Liao 已提交
6242

6243 6244 6245
    if (pTag->data == NULL) {
      pTag->data = malloc(pTag->dataLen);
    }
H
Haojun Liao 已提交
6246

6247 6248
    kvRowCpy(pTag->data, row);
    free(row);
6249

6250 6251 6252 6253
    // table name
    if (tscValidateName(&(pCreateTableInfo->name)) != TSDB_CODE_SUCCESS) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
    }
B
Bomin Zhang 已提交
6254

6255 6256 6257 6258 6259
    STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, TABLE_INDEX);
    ret = tscSetTableFullName(pTableMetaInfo, &pCreateTableInfo->name, pSql);
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
6260

6261
    pCreateTableInfo->fullname = strndup(pTableMetaInfo->name, TSDB_TABLE_FNAME_LEN);
6262 6263 6264 6265 6266 6267 6268 6269 6270 6271
  }

  return TSDB_CODE_SUCCESS;
}

int32_t doCheckForStream(SSqlObj* pSql, SSqlInfo* pInfo) {
  const char* msg1 = "invalid table name";
  const char* msg3 = "fill only available for interval query";
  const char* msg4 = "fill option not supported in stream computing";
  const char* msg5 = "sql too long";  // todo ADD support
H
Haojun Liao 已提交
6272 6273
  const char* msg6 = "from missing in subclause";
  
6274
  SSqlCmd*    pCmd = &pSql->cmd;
6275
  SQueryInfo* pQueryInfo = tscGetQueryInfoDetail(pCmd, 0);
6276 6277
  assert(pQueryInfo->numOfTables == 1);

6278
  SCreateTableSQL* pCreateTable = pInfo->pCreateTableInfo;
H
hjxilinx 已提交
6279
  STableMetaInfo*  pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
6280 6281

  // if sql specifies db, use it, otherwise use default db
H
Haojun Liao 已提交
6282
  SStrToken* pzTableName = &(pCreateTable->name);
6283 6284 6285
  SQuerySQL* pQuerySql = pCreateTable->pSelect;

  if (tscValidateName(pzTableName) != TSDB_CODE_SUCCESS) {
6286
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
6287
  }
H
Haojun Liao 已提交
6288
  
H
Haojun Liao 已提交
6289 6290
  SArray* pSrcMeterName = pInfo->pCreateTableInfo->pSelect->from;
  if (pSrcMeterName == NULL || taosArrayGetSize(pSrcMeterName) == 0) {
H
Haojun Liao 已提交
6291 6292 6293
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
  }
  
H
Haojun Liao 已提交
6294 6295
  tVariantListItem* p1 = taosArrayGet(pSrcMeterName, 0);
  SStrToken srcToken = {.z = p1->pVar.pz, .n = p1->pVar.nLen, .type = TK_STRING};
6296
  if (tscValidateName(&srcToken) != TSDB_CODE_SUCCESS) {
6297
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
6298 6299
  }

H
Haojun Liao 已提交
6300 6301 6302
  int32_t code = tscSetTableFullName(pTableMetaInfo, &srcToken, pSql);
  if (code != TSDB_CODE_SUCCESS) {
    return code;
6303 6304
  }

H
Haojun Liao 已提交
6305
  code = tscGetTableMeta(pSql, pTableMetaInfo);
6306 6307 6308 6309
  if (code != TSDB_CODE_SUCCESS) {
    return code;
  }

weixin_48148422's avatar
weixin_48148422 已提交
6310
  bool isSTable = UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo);
H
Haojun Liao 已提交
6311
  if (parseSelectClause(&pSql->cmd, 0, pQuerySql->pSelection, isSTable, false) != TSDB_CODE_SUCCESS) {
6312
    return TSDB_CODE_TSC_INVALID_SQL;
6313 6314 6315
  }

  if (pQuerySql->pWhere != NULL) {  // query condition in stream computing
6316
    if (parseWhereClause(pQueryInfo, &pQuerySql->pWhere, pSql) != TSDB_CODE_SUCCESS) {
6317
      return TSDB_CODE_TSC_INVALID_SQL;
6318 6319 6320 6321
    }
  }

  // set interval value
6322
  if (parseIntervalClause(pSql, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
6323
    return TSDB_CODE_TSC_INVALID_SQL;
6324
  } else {
6325
    if ((pQueryInfo->interval.interval > 0) &&
6326
        (validateFunctionsInIntervalOrGroupbyQuery(pCmd, pQueryInfo) != TSDB_CODE_SUCCESS)) {
6327
      return TSDB_CODE_TSC_INVALID_SQL;
6328 6329 6330 6331
    }
  }

  // set the created table[stream] name
H
Haojun Liao 已提交
6332 6333 6334
  code = tscSetTableFullName(pTableMetaInfo, pzTableName, pSql);
  if (code != TSDB_CODE_SUCCESS) {
    return code;
6335 6336 6337
  }

  if (pQuerySql->selectToken.n > TSDB_MAX_SAVED_SQL_LEN) {
6338
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
6339 6340
  }

6341
  if (tsRewriteFieldNameIfNecessary(pCmd, pQueryInfo) != TSDB_CODE_SUCCESS) {
6342
    return TSDB_CODE_TSC_INVALID_SQL;
6343 6344
  }

H
hjxilinx 已提交
6345
  pCmd->numOfCols = pQueryInfo->fieldsInfo.numOfOutput;
6346

6347
  if (validateSqlFunctionInStreamSql(pCmd, pQueryInfo) != TSDB_CODE_SUCCESS) {
6348
    return TSDB_CODE_TSC_INVALID_SQL;
6349 6350 6351 6352 6353 6354 6355
  }

  /*
   * check if fill operation is available, the fill operation is parsed and executed during query execution,
   * not here.
   */
  if (pQuerySql->fillType != NULL) {
6356
    if (pQueryInfo->interval.interval == 0) {
6357
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
6358 6359
    }

H
Haojun Liao 已提交
6360
    tVariantListItem* pItem = taosArrayGet(pQuerySql->fillType, 0);
6361 6362 6363
    if (pItem->pVar.nType == TSDB_DATA_TYPE_BINARY) {
      if (!((strncmp(pItem->pVar.pz, "none", 4) == 0 && pItem->pVar.nLen == 4) ||
            (strncmp(pItem->pVar.pz, "null", 4) == 0 && pItem->pVar.nLen == 4))) {
6364
        return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
6365 6366 6367 6368 6369
      }
    }
  }

  // set the number of stream table columns
H
hjxilinx 已提交
6370
  pCmd->numOfCols = pQueryInfo->fieldsInfo.numOfOutput;
6371 6372 6373
  return TSDB_CODE_SUCCESS;
}

6374 6375 6376 6377 6378 6379 6380 6381 6382 6383 6384 6385 6386 6387 6388 6389 6390 6391 6392 6393 6394 6395 6396 6397 6398 6399 6400 6401 6402 6403 6404 6405 6406 6407 6408
static int32_t checkQueryRangeForFill(SSqlCmd* pCmd, SQueryInfo* pQueryInfo) {
  const char* msg3 = "start(end) time of query range required or time range too large";

  if (pQueryInfo->interval.interval == 0) {
    return TSDB_CODE_SUCCESS;
  }

    bool initialWindows = TSWINDOW_IS_EQUAL(pQueryInfo->window, TSWINDOW_INITIALIZER);
    if (initialWindows) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }

    int64_t timeRange = ABS(pQueryInfo->window.skey - pQueryInfo->window.ekey);

    int64_t intervalRange = 0;
    if (pQueryInfo->interval.intervalUnit == 'n' || pQueryInfo->interval.intervalUnit == 'y') {
      int64_t f = 1;
      if (pQueryInfo->interval.intervalUnit == 'n') {
        f = 30L * MILLISECOND_PER_DAY;
      } else if (pQueryInfo->interval.intervalUnit == 'y') {
        f = 365L * MILLISECOND_PER_DAY;
      }

      intervalRange = pQueryInfo->interval.interval * f;
    } else {
      intervalRange = pQueryInfo->interval.interval;
    }
    // number of result is not greater than 10,000,000
    if ((timeRange == 0) || (timeRange / intervalRange) >= MAX_INTERVAL_TIME_WINDOW) {
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
    }

    return TSDB_CODE_SUCCESS;
}

6409
int32_t doCheckForQuery(SSqlObj* pSql, SQuerySQL* pQuerySql, int32_t index) {
H
Haojun Liao 已提交
6410
  assert(pQuerySql != NULL && (pQuerySql->from == NULL || taosArrayGetSize(pQuerySql->from) > 0));
6411

H
Haojun Liao 已提交
6412
  const char* msg0  = "invalid table name";
6413 6414 6415 6416 6417 6418 6419
  const char* msg1 = "point interpolation query needs timestamp";
  const char* msg2 = "fill only available for interval query";
  const char* msg3 = "start(end) time of query range required or time range too large";
  const char* msg4 = "illegal number of tables in from clause";
  const char* msg5 = "too many columns in selection clause";
  const char* msg6 = "too many tables in from clause";
  const char* msg7 = "invalid table alias name";
6420 6421

  int32_t code = TSDB_CODE_SUCCESS;
6422

6423
  SSqlCmd* pCmd = &pSql->cmd;
6424

6425
  SQueryInfo*     pQueryInfo = tscGetQueryInfoDetail(pCmd, index);
H
hjxilinx 已提交
6426
  STableMetaInfo* pTableMetaInfo = tscGetMetaInfo(pQueryInfo, 0);
H
hjxilinx 已提交
6427
  if (pTableMetaInfo == NULL) {
H
hjxilinx 已提交
6428
    pTableMetaInfo = tscAddEmptyMetaInfo(pQueryInfo);
6429
  }
H
hjxilinx 已提交
6430

H
Haojun Liao 已提交
6431 6432
  assert(pCmd->clauseIndex == index);

6433 6434
  // too many result columns not support order by in query
  if (pQuerySql->pSelection->nExpr > TSDB_MAX_COLUMNS) {
6435
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg5);
6436 6437 6438 6439 6440 6441 6442 6443 6444 6445 6446 6447
  }

  /*
   * handle the sql expression without from subclause
   * select current_database();
   * select server_version();
   * select client_version();
   * select server_state();
   */
  if (pQuerySql->from == NULL) {
    assert(pQuerySql->fillType == NULL && pQuerySql->pGroupby == NULL && pQuerySql->pWhere == NULL &&
           pQuerySql->pSortOrder == NULL);
6448
    return doLocalQueryProcess(pCmd, pQueryInfo, pQuerySql);
6449 6450
  }

H
Haojun Liao 已提交
6451 6452
  size_t fromSize = taosArrayGetSize(pQuerySql->from);
  if (fromSize > TSDB_MAX_JOIN_TABLE_NUM * 2) {
6453
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg4);
6454 6455
  }

6456
  pQueryInfo->command = TSDB_SQL_SELECT;
H
hjxilinx 已提交
6457

H
Haojun Liao 已提交
6458
  if (fromSize > 4) {
6459
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg6);
H
Haojun Liao 已提交
6460 6461
  }

6462
  // set all query tables, which are maybe more than one.
H
Haojun Liao 已提交
6463 6464 6465
  for (int32_t i = 0; i < fromSize; ) {
    tVariantListItem* item = taosArrayGet(pQuerySql->from, i);
    tVariant* pTableItem = &item->pVar;
6466 6467

    if (pTableItem->nType != TSDB_DATA_TYPE_BINARY) {
6468
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
6469 6470 6471 6472
    }

    pTableItem->nLen = strdequote(pTableItem->pz);

H
Haojun Liao 已提交
6473
    SStrToken tableName = {.z = pTableItem->pz, .n = pTableItem->nLen, .type = TK_STRING};
6474
    if (tscValidateName(&tableName) != TSDB_CODE_SUCCESS) {
6475
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg0);
6476 6477
    }

H
Haojun Liao 已提交
6478
    if (pQueryInfo->numOfTables <= i/2) {  // more than one table
H
hjxilinx 已提交
6479
      tscAddEmptyMetaInfo(pQueryInfo);
6480 6481
    }

H
Haojun Liao 已提交
6482
    STableMetaInfo* pTableMetaInfo1 = tscGetMetaInfo(pQueryInfo, i/2);
6483

H
Haojun Liao 已提交
6484
    SStrToken t = {.type = TSDB_DATA_TYPE_BINARY, .n = pTableItem->nLen, .z = pTableItem->pz};
H
Haojun Liao 已提交
6485 6486 6487
    code = tscSetTableFullName(pTableMetaInfo1, &t, pSql);
    if (code != TSDB_CODE_SUCCESS) {
      return code;
6488 6489
    }

6490
    tVariantListItem* p1 = taosArrayGet(pQuerySql->from, i + 1);
H
Haojun Liao 已提交
6491
    if (p1->pVar.nType != TSDB_DATA_TYPE_BINARY) {
6492
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
H
Haojun Liao 已提交
6493 6494
    }

H
Haojun Liao 已提交
6495
    SStrToken aliasName = {.z = p1->pVar.pz, .n = p1->pVar.nLen, .type = TK_STRING};
H
Haojun Liao 已提交
6496
    if (tscValidateName(&aliasName) != TSDB_CODE_SUCCESS) {
6497
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg7);
H
Haojun Liao 已提交
6498 6499
    }

6500
    // has no table alias name
H
Haojun Liao 已提交
6501
    if (memcmp(pTableItem->pz, p1->pVar.pz, p1->pVar.nLen) == 0) {
6502 6503
      extractTableName(pTableMetaInfo1->name, pTableMetaInfo1->aliasName);
    } else {
H
Haojun Liao 已提交
6504
      tstrncpy(pTableMetaInfo1->aliasName, p1->pVar.pz, sizeof(pTableMetaInfo1->aliasName));
6505
    }
H
Haojun Liao 已提交
6506 6507

    code = tscGetTableMeta(pSql, pTableMetaInfo1);
6508 6509 6510
    if (code != TSDB_CODE_SUCCESS) {
      return code;
    }
H
Haojun Liao 已提交
6511 6512

    i += 2;
6513 6514
  }

H
Haojun Liao 已提交
6515
  assert(pQueryInfo->numOfTables == taosArrayGetSize(pQuerySql->from) / 2);
H
hjxilinx 已提交
6516
  bool isSTable = false;
H
hjxilinx 已提交
6517
  
weixin_48148422's avatar
weixin_48148422 已提交
6518
  if (UTIL_TABLE_IS_SUPER_TABLE(pTableMetaInfo)) {
H
hjxilinx 已提交
6519 6520 6521 6522 6523 6524 6525
    isSTable = true;
    code = tscGetSTableVgroupInfo(pSql, index);
    if (code != TSDB_CODE_SUCCESS) {
      return code;
    }
    
    TSDB_QUERY_SET_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_STABLE_QUERY);
6526 6527
  } else {
    TSDB_QUERY_SET_TYPE(pQueryInfo->type, TSDB_QUERY_TYPE_TABLE_QUERY);
H
hjxilinx 已提交
6528
  }
6529

6530
  // parse the group by clause in the first place
6531
  if (parseGroupbyClause(pQueryInfo, pQuerySql->pGroupby, pCmd) != TSDB_CODE_SUCCESS) {
6532
    return TSDB_CODE_TSC_INVALID_SQL;
6533 6534
  }

6535 6536
  // set where info
  STableComInfo tinfo = tscGetTableInfo(pTableMetaInfo->pTableMeta);
Y
TD-1230  
yihaoDeng 已提交
6537

6538 6539 6540 6541 6542 6543 6544 6545 6546 6547 6548
  if (pQuerySql->pWhere != NULL) {
    if (parseWhereClause(pQueryInfo, &pQuerySql->pWhere, pSql) != TSDB_CODE_SUCCESS) {
      return TSDB_CODE_TSC_INVALID_SQL;
    }

    pQuerySql->pWhere = NULL;
    if (tinfo.precision == TSDB_TIME_PRECISION_MILLI) {
      pQueryInfo->window.skey = pQueryInfo->window.skey / 1000;
      pQueryInfo->window.ekey = pQueryInfo->window.ekey / 1000;
    }
  } else {  // set the time rang
H
Haojun Liao 已提交
6549
    if (taosArrayGetSize(pQuerySql->from) > 2) { // it is a join query, no wher clause is not allowed.
6550 6551
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "condition missing for join query ");
    }
Y
TD-1230  
yihaoDeng 已提交
6552
  }
6553

H
Haojun Liao 已提交
6554
  int32_t joinQuery = (pQuerySql->from != NULL && taosArrayGetSize(pQuerySql->from) > 2);
6555

H
Haojun Liao 已提交
6556
  if (parseSelectClause(pCmd, index, pQuerySql->pSelection, isSTable, joinQuery) != TSDB_CODE_SUCCESS) {
6557
    return TSDB_CODE_TSC_INVALID_SQL;
6558 6559
  }

H
Haojun Liao 已提交
6560 6561 6562 6563 6564
  // set order by info
  if (parseOrderbyClause(pCmd, pQueryInfo, pQuerySql, tscGetTableSchema(pTableMetaInfo->pTableMeta)) != TSDB_CODE_SUCCESS) {
    return TSDB_CODE_TSC_INVALID_SQL;
  }

6565
  // set interval value
6566
  if (parseIntervalClause(pSql, pQueryInfo, pQuerySql) != TSDB_CODE_SUCCESS) {
6567
    return TSDB_CODE_TSC_INVALID_SQL;
6568
  } else {
6569
    if ((pQueryInfo->interval.interval > 0) &&
6570
        (validateFunctionsInIntervalOrGroupbyQuery(pCmd, pQueryInfo) != TSDB_CODE_SUCCESS)) {
6571
      return TSDB_CODE_TSC_INVALID_SQL;
6572 6573 6574 6575
    }
  }

  // no result due to invalid query time range
H
hjxilinx 已提交
6576
  if (pQueryInfo->window.skey > pQueryInfo->window.ekey) {
6577
    pQueryInfo->command = TSDB_SQL_RETRIEVE_EMPTY_RESULT;
6578 6579 6580
    return TSDB_CODE_SUCCESS;
  }

6581
  if (!hasTimestampForPointInterpQuery(pQueryInfo)) {
6582
    return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg1);
6583 6584 6585
  }

  // in case of join query, time range is required.
6586
  if (QUERY_IS_JOIN_QUERY(pQueryInfo->type)) {
S
TD-1057  
Shengliang Guan 已提交
6587
    int64_t timeRange = ABS(pQueryInfo->window.skey - pQueryInfo->window.ekey);
6588

H
hjxilinx 已提交
6589
    if (timeRange == 0 && pQueryInfo->window.skey == 0) {
6590
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg3);
6591 6592 6593
    }
  }

6594
  if ((code = parseLimitClause(pCmd, pQueryInfo, index, pQuerySql, pSql)) != TSDB_CODE_SUCCESS) {
6595 6596 6597
    return code;
  }

6598
  if ((code = doFunctionsCompatibleCheck(pCmd, pQueryInfo)) != TSDB_CODE_SUCCESS) {
6599 6600 6601
    return code;
  }

H
Haojun Liao 已提交
6602
  tscFieldInfoUpdateOffset(pQueryInfo);
6603

6604 6605 6606 6607
  /*
   * fill options are set at the end position, when all columns are set properly
   * the columns may be increased due to group by operation
   */
6608 6609 6610 6611
  if ((code = checkQueryRangeForFill(pCmd, pQueryInfo)) != TSDB_CODE_SUCCESS) {
    return code;
  }

6612
  if (pQuerySql->fillType != NULL) {
6613
    if (pQueryInfo->interval.interval == 0 && (!tscIsPointInterpQuery(pQueryInfo))) {
6614
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), msg2);
6615
    }
H
hjxilinx 已提交
6616

6617 6618
    if ((code = parseFillClause(pCmd, pQueryInfo, pQuerySql)) != TSDB_CODE_SUCCESS) {
      return code;
6619 6620
    }
  }
6621 6622 6623

  return TSDB_CODE_SUCCESS;  // Does not build query message here
}
H
hjxilinx 已提交
6624

H
Haojun Liao 已提交
6625
int32_t exprTreeFromSqlExpr(SSqlCmd* pCmd, tExprNode **pExpr, const tSQLExpr* pSqlExpr, SQueryInfo* pQueryInfo, SArray* pCols, int64_t *uid) {
H
hjxilinx 已提交
6626 6627
  tExprNode* pLeft = NULL;
  tExprNode* pRight= NULL;
H
hjxilinx 已提交
6628
  
6629
  if (pSqlExpr->pLeft != NULL) {
H
Haojun Liao 已提交
6630
    int32_t ret = exprTreeFromSqlExpr(pCmd, &pLeft, pSqlExpr->pLeft, pQueryInfo, pCols, uid);
H
hjxilinx 已提交
6631 6632 6633 6634 6635
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
  }
  
6636
  if (pSqlExpr->pRight != NULL) {
H
Haojun Liao 已提交
6637
    int32_t ret = exprTreeFromSqlExpr(pCmd, &pRight, pSqlExpr->pRight, pQueryInfo, pCols, uid);
H
hjxilinx 已提交
6638 6639 6640 6641
    if (ret != TSDB_CODE_SUCCESS) {
      return ret;
    }
  }
H
Haojun Liao 已提交
6642 6643 6644 6645 6646

  if (pSqlExpr->pLeft == NULL && pSqlExpr->pRight == NULL && pSqlExpr->nSQLOptr == 0) {
    *pExpr = calloc(1, sizeof(tExprNode));
    return TSDB_CODE_SUCCESS;
  }
H
hjxilinx 已提交
6647
  
6648
  if (pSqlExpr->pLeft == NULL) {
H
hjxilinx 已提交
6649
    if (pSqlExpr->nSQLOptr >= TK_BOOL && pSqlExpr->nSQLOptr <= TK_STRING) {
6650
      *pExpr = calloc(1, sizeof(tExprNode));
H
hjxilinx 已提交
6651
      (*pExpr)->nodeType = TSQL_NODE_VALUE;
6652 6653 6654
      (*pExpr)->pVal = calloc(1, sizeof(tVariant));
      
      tVariantAssign((*pExpr)->pVal, &pSqlExpr->val);
6655
      return TSDB_CODE_SUCCESS;
6656
    } else if (pSqlExpr->nSQLOptr >= TK_COUNT && pSqlExpr->nSQLOptr <= TK_AVG_IRATE) {
6657
      // arithmetic expression on the results of aggregation functions
6658
      *pExpr = calloc(1, sizeof(tExprNode));
H
hjxilinx 已提交
6659
      (*pExpr)->nodeType = TSQL_NODE_COL;
6660 6661 6662
      (*pExpr)->pSchema = calloc(1, sizeof(SSchema));
      strncpy((*pExpr)->pSchema->name, pSqlExpr->operand.z, pSqlExpr->operand.n);
      
H
hjxilinx 已提交
6663
      // set the input column data byte and type.
H
Haojun Liao 已提交
6664
      size_t size = taosArrayGetSize(pQueryInfo->exprList);
H
hjxilinx 已提交
6665 6666
      
      for (int32_t i = 0; i < size; ++i) {
H
Haojun Liao 已提交
6667
        SSqlExpr* p1 = taosArrayGetP(pQueryInfo->exprList, i);
H
hjxilinx 已提交
6668 6669
        
        if (strcmp((*pExpr)->pSchema->name, p1->aliasName) == 0) {
H
Haojun Liao 已提交
6670
          (*pExpr)->pSchema->type  = (uint8_t)p1->resType;
H
hjxilinx 已提交
6671
          (*pExpr)->pSchema->bytes = p1->resBytes;
H
Haojun Liao 已提交
6672
          (*pExpr)->pSchema->colId = p1->resColId;
H
Haojun Liao 已提交
6673 6674 6675 6676 6677

          if (uid != NULL) {
            *uid = p1->uid;
          }

H
hjxilinx 已提交
6678 6679 6680
          break;
        }
      }
6681
    } else if (pSqlExpr->nSQLOptr == TK_ID) { // column name, normal column arithmetic expression
H
Haojun Liao 已提交
6682
      SColumnIndex index = COLUMN_INDEX_INITIALIZER;
6683
      int32_t ret = getColumnIndexByName(pCmd, &pSqlExpr->colInfo, pQueryInfo, &index);
6684 6685 6686
      if (ret != TSDB_CODE_SUCCESS) {
        return ret;
      }
H
Haojun Liao 已提交
6687 6688 6689 6690

      STableMeta* pTableMeta = tscGetMetaInfo(pQueryInfo, 0)->pTableMeta;
      int32_t numOfColumns = tscGetNumOfColumns(pTableMeta);

6691 6692 6693
      *pExpr = calloc(1, sizeof(tExprNode));
      (*pExpr)->nodeType = TSQL_NODE_COL;
      (*pExpr)->pSchema = calloc(1, sizeof(SSchema));
H
Haojun Liao 已提交
6694

6695 6696
      SSchema* pSchema = tscGetTableColumnSchema(pTableMeta, index.columnIndex);
      *(*pExpr)->pSchema = *pSchema;
6697 6698 6699
  
      if (pCols != NULL) {  // record the involved columns
        SColIndex colIndex = {0};
B
Bomin Zhang 已提交
6700
        tstrncpy(colIndex.name, pSchema->name, sizeof(colIndex.name));
6701 6702
        colIndex.colId = pSchema->colId;
        colIndex.colIndex = index.columnIndex;
H
Haojun Liao 已提交
6703 6704
        colIndex.flag = (index.columnIndex >= numOfColumns)? 1:0;

6705 6706
        taosArrayPush(pCols, &colIndex);
      }
6707
      
H
hjxilinx 已提交
6708
      return TSDB_CODE_SUCCESS;
6709
    } else {
H
Haojun Liao 已提交
6710
      return invalidSqlErrMsg(tscGetErrorMsgPayload(pCmd), "not support filter expression");
H
hjxilinx 已提交
6711 6712 6713
    }
    
  } else {
H
hjxilinx 已提交
6714
    *pExpr = (tExprNode *)calloc(1, sizeof(tExprNode));
6715 6716
    (*pExpr)->nodeType = TSQL_NODE_EXPR;
    
H
[td-32]  
hjxilinx 已提交
6717 6718 6719
    (*pExpr)->_node.hasPK = false;
    (*pExpr)->_node.pLeft = pLeft;
    (*pExpr)->_node.pRight = pRight;
6720
    
H
Haojun Liao 已提交
6721
    SStrToken t = {.type = pSqlExpr->nSQLOptr};
H
Haojun Liao 已提交
6722
    (*pExpr)->_node.optr = convertOptr(&t);
6723
    
H
[td-32]  
hjxilinx 已提交
6724
    assert((*pExpr)->_node.optr != 0);
6725 6726

    // check for dividing by 0
H
[td-32]  
hjxilinx 已提交
6727
    if ((*pExpr)->_node.optr == TSDB_BINARY_OP_DIVIDE) {
H
hjxilinx 已提交
6728 6729
      if (pRight->nodeType == TSQL_NODE_VALUE) {
        if (pRight->pVal->nType == TSDB_DATA_TYPE_INT && pRight->pVal->i64Key == 0) {
6730
          return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
6731
        } else if (pRight->pVal->nType == TSDB_DATA_TYPE_FLOAT && pRight->pVal->dKey == 0) {
6732
          return TSDB_CODE_TSC_INVALID_SQL;
H
hjxilinx 已提交
6733 6734 6735
        }
      }
    }
H
Hui Li 已提交
6736

6737
    // NOTE: binary|nchar data allows the >|< type filter
H
Hui Li 已提交
6738
    if ((*pExpr)->_node.optr != TSDB_RELATION_EQUAL && (*pExpr)->_node.optr != TSDB_RELATION_NOT_EQUAL) {
6739
      if (pRight != NULL && pRight->nodeType == TSQL_NODE_VALUE) {
B
Bomin Zhang 已提交
6740 6741 6742
        if (pRight->pVal->nType == TSDB_DATA_TYPE_BOOL) {
          return TSDB_CODE_TSC_INVALID_SQL;
        }
H
Hui Li 已提交
6743 6744
      }
    }
H
hjxilinx 已提交
6745 6746 6747
  }
  
  return TSDB_CODE_SUCCESS;
L
[#1197]  
lihui 已提交
6748
}
6749 6750 6751 6752 6753 6754 6755 6756 6757 6758 6759

bool hasNormalColumnFilter(SQueryInfo* pQueryInfo) {
  size_t numOfCols = taosArrayGetSize(pQueryInfo->colList);
  for (int32_t i = 0; i < numOfCols; ++i) {
    SColumn* pCol = taosArrayGetP(pQueryInfo->colList, i);
    if (pCol->numOfFilters > 0) {
      return true;
    }
  }

  return false;
6760
}