doc strings, dont we love em?
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

Signed-off-by: NMark Hymers <mhy@debian.org>

Signed-off-by: NMark Hymers <mhy@debian.org>

This is so that we have an idea of where we need what.

Lots of these should be changed to be opaque functions,
not exposing that they're internally regexes at all.
Signed-off-by: NMark Hymers <mhy@debian.org>

Signed-off-by: NMark Hymers <mhy@debian.org>

Rather than scatter regexes all over the place (for things
which should probably be functions hiding the implementation
detail anyways such as "is this a valid package version"),
move them into daklib.regexes.

I'm not convinced this is an immediate win, but I think it's
one step on a long road...

Oh, and it's untested
Signed-off-by: NMark Hymers <mhy@debian.org>

"0644" != 0644. damn you, string and int.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

who would have thought, os.fdopen really wants an fd, not a filename.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

remove a few trailing ;
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

add docstrings.
make two sql queries more readable
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

shut up more of pychecker.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

remove a few "FOO shadows builtin" warnings.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

use the new "style" for the temp_filename function, and if applicable
also use os.fdopen.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

stop using mktemp and use mkstemp. Also use the functions with all their
features, like setting prefix, instead of trying to do that ourself.
Yikes, one-liner now, could remove the function alltogether and instead
use mkstemp directly, but *maybe* we want to get more code into here,
so lets keep it for now.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

stop using mktemp and use mkstemp instead
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

eliminate pychecker warning "shadows builtin input|file|hash"
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

There was a ß in utils.py that I think was supposed to be a 0.  Either it needs
to be changed to a 0 or the character encoding needs to be declared at the top
of the source file.  I opted to change the character to a 0.
Signed-off-by: NMike O'Connor <stew@vireo.org>

Adjust the gpgv signature check. Add one more case of broken key to detect,
EXPKEYSIG. From gnupg docs:
    EXPKEYSIG   <long keyid>  <username>
    The signature with the keyid is good, but the signature was
    made by an expired key. The username is the primary one
    encoded in UTF-8 and %XX escaped.

Also, handle KEYEXPIRED right. The first argument given back is NOT the keyid,
it is the timestamp when the key expired. From gnupg docs:
    KEYEXPIRED <expire-timestamp>
    The key has expired.  expire-timestamp is the expiration time
    in seconds after the epoch.

    Note, that TIMESTAMP may either be a number with seconds since
    epoch or an ISO 8601 string which can be detected by the
    presence of the letter 'T' inside.
So lets go and see if we find a T, if not convert the epoch to something
more easily human readable in our reject message.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

        * daklib/utils.py: move the html escape stuff here.
        * dak/examine_package.py: Remove the html escape stuff.
        * dak/queue_report.py: lotsa html changes to get more info on the
        page and to get Tinchos css foo working.
        * web/style.css: Added new stuff from Tincho
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

2008-12-09  Philipp Kern  <pkern@debian.org>

        * daklib/queue.py (cross_suite_version_check): add an additional
        parameter to specify if an upload is sourceful or not; do not reject
        uploads that do not satisfy the "must be newer than" criteria and
        are binary-only
        * daklib/queue.py (check_source_against_db, check_binary_against_db):
        invoke cross_suite_version_check as above

OLD bug.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

2008-10-21  Philipp Kern  <pkern@debian.org>

        * daklib/queue.py: reintroduce James' check for EPERM after
          the chmod'ing of dak files and ignore it; just fubar if the file is
          world writable, which should really never happen
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

2008-09-13  Philipp Kern  <pkern@debian.org>

        * dak/queue.py (dump_vars): make .dak u,g=rw,o=r; James'
        assumption (as stated in 2002-05-18's ChangeLog entry)
        was that people will use the information therein albeit
        it is "just" a duplication of information present in
        other control files; people should still not use it
        as source of information but access to those files makes
        dak debugging easier and there is no leak of sensitive
        information involved
Signed-off-by: NPhilipp Kern <pkern@debian.org>

2008-09-08  Philipp Kern  <pkern@debian.org>

        * daklib/utils.py (build_file_list): do not die on very
        old dsc files without format header
Signed-off-by: NPhilipp Kern <pkern@debian.org>

Signed-off-by: NPhilipp Kern <pkern@debian.org>

The current check for additional entries in checksums-* which are not
covered by entries in files is flawed because files could be modified
by autobyhand or sometimes when the file's already in the pool.

We need to rework this to look into the original files dict instead.
Signed-off-by: NPhilipp Kern <pkern@debian.org>

For now dont warn if file is not found.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

2008-09-07  Philipp Kern  <pkern@debian.org>

        * daklib/utils.py (check_hash): try..except..finally only
        works on python >=2.5.
Signed-off-by: NPhilipp Kern <pkern@debian.org>

2008-09-07  Philipp Kern  <pkern@debian.org>

        * daklib/utils.py (check_hash): change the comment and warn
        if a file is not found when checking the hashes (i.e. when
        it is probably in the pool)

	* daklib/utils.py (check_size): do not bail out if the file
	is not found, because it may be in the pool

        * dak/process_accepted.py (install): bail out and skip the
        upload when ensure_hashes fails, print the rejection messages
        as warnings
Signed-off-by: NPhilipp Kern <pkern@debian.org>

This reverts commit aa83ebb1.

Conflicts:

	ChangeLog

This reverts commit 536cb00b.

2008-08-28  Philipp Kern  <pkern@debian.org>

	* daklib/utils.py (check_hashes): adapt to different API, check
	sizes separately

	* daklib/utils.py (parse_changes, parse_deb822): refactor
	the string-based logic of parse_changes into a new function
	parse_deb822; parse_changes itself remains file-based

	* daklib/utils.py (hash_key): gives the key of a hash in the
	files dict

	* daklib/utils.py (create_hash, check_size): made more readable

	* daklib/utils.py (check_hash): just check the hashes and complain
	about missing checksums

	* daklib/utils.py (check_hash_fields): function to reject unknown
	checksums fields

	* daklib/utils.py (_ensure_changes_hash, _ensure_dsc_hash): helper
	functions for ensure_hashes; check their corresponding manifests'
	hashes

	* daklib/utils.py (ensure_hashes): retrieve the checksums fields
	from the original filecontents blob so that they do not need to
	be present in the .dak; refactored the actual checks by calling
	the aforementioned helper functions

	* daklib/utils.py (parse_checksums): parse a given checksums field
	in a manifest and insert the values found into the files dict,
	checking the file sizes on the way

Signed-off-by: NMark Hymers <mhy@debian.org>

Signed-off-by: NMark Hymers <mhy@debian.org>

This reverts commit f50c6be1.

Signed-off-by: NMark Hymers <mhy@debian.org>

Signed-off-by: NMark Hymers <mhy@debian.org>