doc strings, dont we love em?
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

its re_no_epoch and re_no_revision
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

* commit 'mhy/regexes':
  remove unused regexes
  docstring update
  Only import regexes we're using
  whoops, put sensible comment in
  Move regexes into a module so we can keep track
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

Signed-off-by: NMark Hymers <mhy@debian.org>

Signed-off-by: NMark Hymers <mhy@debian.org>

Conflicts:

	dak/make_maintainers.py
	dak/new_security_install.py
	dak/process_accepted.py
Signed-off-by: NMark Hymers <mhy@debian.org>

This is so that we have an idea of where we need what.

Lots of these should be changed to be opaque functions,
not exposing that they're internally regexes at all.
Signed-off-by: NMark Hymers <mhy@debian.org>

Signed-off-by: NMark Hymers <mhy@debian.org>

Rather than scatter regexes all over the place (for things
which should probably be functions hiding the implementation
detail anyways such as "is this a valid package version"),
move them into daklib.regexes.

I'm not convinced this is an immediate win, but I think it's
one step on a long road...

Oh, and it's untested
Signed-off-by: NMark Hymers <mhy@debian.org>

"0644" != 0644. damn you, string and int.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

who would have thought, os.fdopen really wants an fd, not a filename.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

remove a few trailing ;
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

simple remove of two unneeded ;
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

Remove, not used.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

add docstrings.
make two sql queries more readable
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

a whole bunch more pychecker warnings. (Thanks to bicyclerepair, those are the easy ones)
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

its existing_uid, not existing_ui
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

shut up more of pychecker.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

remove a few "FOO shadows builtin" warnings.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

remove commented code. if we really need it - we do have a VCS...
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

replace os.popen2 by strftime usage (someone clearly didnt know that
and preferred to spawn date +%whatever. *sigh*).

also replace a os.popen call with subprocess.Popen.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

use the new "style" for the temp_filename function, and if applicable
also use os.fdopen.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

stop using mktemp and use mkstemp. Also use the functions with all their
features, like setting prefix, instead of trying to do that ourself.
Yikes, one-liner now, could remove the function alltogether and instead
use mkstemp directly, but *maybe* we want to get more code into here,
so lets keep it for now.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

stop using mktemp and use mkstemp instead
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

eliminate pychecker warning "shadows builtin input|file|hash"
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

(cosmetical) this is not a warning, merely an information about the correct
function of this tool.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

This reverts commit d72561f4.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

This reverts commit 1fb2a3d4.
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

* 'master' of ssh://ftp-master.debian.org/srv/ftp.debian.org/git/dak:
  generate_releases

depending on what kind of file we have we generate the checksums in
different ways. For the uncompressed sum we continue reading in all the
content and hand that as a variable to apt_pkg.*sum. Turns out this does
not work for the already compressed files, there we now go and just hand
the opened file_handle to apt_pkg.*sum.

we expect 3 values
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

* commit 'stew/popen2-must-die':
  fix generate_index_diffs' smartopen by replacing it with a smartread
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

smartread slurps the contents of the file into a string, we need to do this
becuase apt_pkg.sha1sum won't accept a 'gzip open file' but will accept a
string
Signed-off-by: NMike O'Connor <stew@vireo.org>

show a url to the bug log.
Closes #510887 (yes, without url. ha! )
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

* commit 'stew/popen2-must-die':
  get rid of popen2 calls in generate_index_diffs
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

Signed-off-by: NMike O'Connor <stew@vireo.org>

* commit 'stew/popen2-must-die':
  oops DEcompress, dummy
  getting rid of popen2 in generate_releases
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

Signed-off-by: NMike O'Connor <stew@vireo.org>

Signed-off-by: NMike O'Connor <stew@vireo.org>

little script to be used on ravel, whenever ravel is hosting
ftp.upload.d.o, so we don't need two queueds
Signed-off-by: NJoerg Jaspert <joerg@debian.org>