1. 15 3月, 2018 2 次提交
  2. 14 3月, 2018 1 次提交
  3. 13 3月, 2018 4 次提交
  4. 12 3月, 2018 2 次提交
  5. 11 3月, 2018 11 次提交
  6. 10 3月, 2018 14 次提交
  7. 08 3月, 2018 6 次提交
    • O
      Update to Parent POM 1.40 with configured FindBugs (#3308) · c84cbf32
      Oleg Nenashev 提交于
      * Update to Parent POM 1.40 with configured FindBugs
      
      * Used the released version of Parent POM, address comments from @dwnusbaum
      c84cbf32
    • D
      [JENKINS-49971] Fix a race condition in Util.loadFile() (#3225) · aaae71af
      Daniel Trebbien 提交于
      * Fix a race condition in Util.loadFile()
      
      If the file is deleted in between when its existence is checked and the
      file is opened for reading, then the method will fail to return an empty
      string.
      
      * Switch to using FileUtils.readFileToString()
      aaae71af
    • L
      [JENKINS-45387] Fix validation error displaying in setup wizard's "create first admin" form (#3116) · 12031d7d
      Literallie 提交于
      * [JENKINS-45387] Improve setup wizard account creation in security realm
      
      This commit adds an additional account creation method to the
      security realm, that allows to create a new user account (as the system)
      and is intended to be used by the setup wizard.
      
      The main difference to the existing method is that the new method does
      not force the Stapler to send a response, but instead throws an
      exception if invalid data is submitted. This allows to call this from
      the setup wizard, and send the response there. (This is necessary
      because the setup wizard method has a response return type and
      there is no way to access the response already send in the realm)
      
      Further, it splits the private createAccount() method for
      clarity as well as to allow code reuse from the new method.
      
      * [JENKINS-45387] Fix SetupWizard sending responses twice on create admin
      
      This commit fixes an issue where the SetupWizard class would send
      two responses (indirectly) when invalid form data was provided for
      creating the first admin account.
      
      * [Fix JENKINS-45387] Setup wizard not displaying first account errors
      
      This commit fixes the setup wizard not displaying HTML error
      responses upon first account creation.
      
      Previously, it just froze (buttons were not re-enabled) and didn't
      display responses. (Probably caused by XSS policies on the iframe)
      
      * [JENKINS-45387] Add some @Restricted annotations
      
      As per
      https://github.com/jenkinsci/jenkins/pull/3116#discussion_r172031063
      https://github.com/jenkinsci/jenkins/pull/3116#discussion_r172051979
      12031d7d
    • D
      Refactor TextFile.lines() (#3211) · 145c606e
      Daniel Trebbien 提交于
      * Refactor TextFile.lines()
      
      Introduces a LinesStream utility class that is responsible for closing
      the underlying file handle.
      
      Switches to calling Files.newBufferedReader() instead of wrapping the
      InputStream returned by Files.newInputStream() in a BufferedReader of
      an InputStreamReader.
      
      Creates the file reader at the time that lines() is invoked, instead of
      at the time that iterator() of the returned Iterable is invoked. This
      can help prevent confusion as to the cause of an exception, whether it's
      because of a problem opening the file or reading from it.
      
      * Delete a duplicate import and a now-unused import
      
      * Introduce load2()
      
      * Add a @Deprecated annotation
      145c606e
    • J
    • J
      Merge pull request #3332 from jglick/message-JENKINS-49795 · 93b95104
      Jesse Glick 提交于
      s/JENKINS-49573/JENKINS-49795/g in messages
      93b95104