Signed-off-by: NMatt Sicker <boards@gmail.com>

* [58571] Check if name is editable on item before doing rename.

* [JENKINS-58571]Form failure when rename item with not editable name.

* [JENKINS-58571] Change to IOException when isNameEditable is false.

* [JENKINS-58571] Validate test harness furure version.

* [JENKINS-58571] Validate test harness 2.55.

* Batch up dynamic plugin installations from setup wizard.

* Reworked to thread the list of batched-up plugins properly and introduced CompleteBatchJob to force the setup wizard to wait.

* UpdateCenterPluginInstallTest.test_installKnownPlugins failure.

* @amuniz notes that an existing message could now be considered misleading.

* Introduced UpdateCenter.DownloadJob.getDisplayName for better consistency in logging, as suggested by @Vlatombe.

* Reducing log levels of messages from dynamicLoad which are not of great interest, as suggested by @Vlatombe.

* Reducing log level of another message of little interest.

* Adding classic UI for CompleteBatchJob.

* CompleteBatchJob should be used only when dynamicLoad.

* Null defense on UpdateCenterJob.site.
Otherwise can get:
java.lang.NullPointerException
	at hudson.model.UpdateCenter.getConnectionCheckJob(UpdateCenter.java:850)
	at hudson.model.UpdateCenter.addConnectionCheckJob(UpdateCenter.java:817)
	at hudson.model.UpdateCenter.addJob(UpdateCenter.java:804)
	at hudson.model.UpdateSite$Plugin.deploy(UpdateSite.java:1367)
	at hudson.PluginManager.install(PluginManager.java:1537)
	at hudson.PluginManager.install(PluginManager.java:1496)
	at hudson.PluginManager.doInstall(PluginManager.java:1445)
	at …

JENKINS-36720: Fixed some spotbugs findings (SE_NO_SERIALVERSIONID, CO_COMPARETO_INCORRECT_FLOATING, VA_FORMAT_STRING_USES_NEWLINE)

[JENKINS-57528] - Load detached plugins which are implicit deps of other plugins at startup even w/o UC (#4000)

* Do not warn repeatedly of the same missing update site dependency.
This happens when locally testing split plugins (despite their presence in WEB-INF/detached-plugins/*.hpi).

(cherry picked from commit 918a0fd2211210a158279b2f19690c86801fe4a1)

* Detached plugins must be kept up to date with security advisories.

(cherry picked from commit e08d28a69897ff94811e02040255a9d266c44d0d)

* Load detached plugins which are implicit dependencies of other plugins at startup, even if the update center was not used.

(cherry picked from commit ad7a36001d30a6174b25e616fc3c215dd24919d1)

* Adjusted expected version after e08d28a69897ff94811e02040255a9d266c44d0d.

(cherry picked from commit 84f939cebd1a0d03633e7b7c01e71ac387fb6463)

* e08d28a69897ff94811e02040255a9d266c44d0d exposed tests which had been incorrectly storing plugins as *.hpi rather than *.jpi.

(cherry picked from commit a0abad7ec474b28d2d388f075bc54f961046b09a)

* Test failure after ad7a36001d30a6174b25e616fc3c215dd24919d1.

(cherry picked from commit 0084e8dbdddf93bb1353516c1fe20d807577631f)

* Another test failure after ad7a36001d30a6174b25e616fc3c215dd24919d1; fewer installDetachedPlugin calls are now required.

(cherry picked from commit b65bb54e9975a7c77103bf7cf4da82295498f308)
(cherry picked from commit 855ea2ee)

* Change getInstance() (deprecated) to get()

* Reverting modifications according review

* Changing for use the variable

Slave constructor wants implementations to use setters,
but AbstractCloudSlave has no corresponding constructor.

* make list view JCasC complianant

* setRecurse @DataBoundSetter

* Set and synchronized jobNames

* description databound setter for view

Co-Authored-By: NMatt Sicker <boards@gmail.com>

[JENKINS-57528] - Load detached plugins which are implicit deps of other plugins at startup even w/o UC (#4000)

* Do not warn repeatedly of the same missing update site dependency.
This happens when locally testing split plugins (despite their presence in WEB-INF/detached-plugins/*.hpi).

(cherry picked from commit 918a0fd2211210a158279b2f19690c86801fe4a1)

* Detached plugins must be kept up to date with security advisories.

(cherry picked from commit e08d28a69897ff94811e02040255a9d266c44d0d)

* Load detached plugins which are implicit dependencies of other plugins at startup, even if the update center was not used.

(cherry picked from commit ad7a36001d30a6174b25e616fc3c215dd24919d1)

* Adjusted expected version after e08d28a69897ff94811e02040255a9d266c44d0d.

(cherry picked from commit 84f939cebd1a0d03633e7b7c01e71ac387fb6463)

* e08d28a69897ff94811e02040255a9d266c44d0d exposed tests which had been incorrectly storing plugins as *.hpi rather than *.jpi.

(cherry picked from commit a0abad7ec474b28d2d388f075bc54f961046b09a)

* Test failure after ad7a36001d30a6174b25e616fc3c215dd24919d1.

(cherry picked from commit 0084e8dbdddf93bb1353516c1fe20d807577631f)

* Another test failure after ad7a36001d30a6174b25e616fc3c215dd24919d1; fewer installDetachedPlugin calls are now required.

(cherry picked from commit b65bb54e9975a7c77103bf7cf4da82295498f308)

Run.keepLog-related Javadoc failed to note that what is being kept is the build, not just the log as the name would suggest.

* [JENKINS-56477] New "isCompatible" method avoiding all plugins w/ warns

Previous version was only checking "isCompatibleWithInstalledVersion", but there were several other cases that had to be checked

* [JENKINS-56477] Added issue annotation to isPluginUpdateCompatible test

* [JENKINS-56477] Factored out getUpdateSite, init method used by 2 tests

Also removed the "sites" list from the init, since it seemed it was not being used, only using the specific site created from the external json

* [JENKINS-56477] Added a new option for plugin selection: "compatible"

Now users can select "All", "Compatible" or "None"

* [JENKINS-56477] checkPluginsWithoutWarnings also unchecks now

Useful if the user first clicks "Select All" and now wants to "Select Compatible" only.

* [JENKINS-56477] Added unit test for "UpdateSite.Plugin.isCompatible"

The UpdateSite class and its internal classes (e.g. Plugin) are a bit tricky to unit-test. Using some stubs to set the necessary context for the test to run

* [JENKINS-56477] "mock-maker-inline" incompatible w/ other tests

Had to remove the unit test checking "pluginUpdateNotCompatible. It needed "mock-maker-inline" config to mock/spy the Plugin class (which is final), but that mockito config caused conflicts with pre-existing tests.

* [JENKINS-56477] Simplifying condition to check the candidate checkbox

* [JENKINS-56477] Method overload with param should not be exported

* [JENKINS-56477] Javadoc for isCompatible(). Overloaded ver. restricted

Also switched the call in table.jelly to the overloaded version of isCompatible, since a "cache" var was available in the context (and was being already used by calls to the internal methods to show the warnings)

* Removed empty line.

Trivial change to force re-execution of pipeline.

* [JENKINS-56477] "isCompatible" set to @Restricted for now

This method is currently only being used by the Jenkins UI, so we are not being exposing it to plugins nor exporting it. If in the future that need emerges, this can be changed

* Created new getter method in AbstractCIBase and marked it as
`Restricted`

* Added suggested changes

* Added changes

* Suggested Changes Added

* Added new getter method with appropriate changes.

Co-Authored-By: Njsoref <jsoref@users.noreply.github.com>

Co-Authored-By: Njglick <jglick@cloudbees.com>

* [FIX JENKINS-43218] Fix Fingerprint.toString()

1. Fix Fingerprint.toString() method when
   variable usages = null .
Signed-off-by: NMit Naria <mit4dev@gmail.com>

* [FIX JENKINS-43218] Fix Fingerprint.toString()

1. Fix Fingerprint.toString() method when
   variable usages = null .

* [JENKINS-43218] - Retrigger the build after the Java 11 fixes on ci.jenkins.io

(cherry picked from commit 399c8ba4)

* Revert DownloadService TimeUnit mix on lastAttempt

Downloadable.lastAttempt is set in milliseconds but the PR-3913 change
the test to toMillis(millis+seconds)<millis.

Thank you @pzygielo for this catch.

* Fix DownloadService time unit usage

Thank you @daniel-beck
Co-Authored-By: Nalecharp <adrien.lecharpentier@gmail.com>

* Fix DownloadService missing import

Make use of covariant return types to return a String rather than an
Object.

* Add message to the build log when a build is running as SYSTEM

* Match previous log message

- avoid git-archeology to find when the interface was added

* [FIX JENKINS-43218] Fix Fingerprint.toString()

1. Fix Fingerprint.toString() method when
   variable usages = null .
Signed-off-by: NMit Naria <mit4dev@gmail.com>

* [FIX JENKINS-43218] Fix Fingerprint.toString()

1. Fix Fingerprint.toString() method when
   variable usages = null .

* [JENKINS-43218] - Retrigger the build after the Java 11 fixes on ci.jenkins.io