This fixes the issue when the project name
includes a character that can't be encoded
directly in UTF-8, e.g., surrogate pairs.

* [JENKINS-54772] Fix reported list of environment variables from agent

* Feedback incorporated

* Code moved to SlaveComputer class

* [JENKINS-58734] Use SHA-256 for crumbs
Signed-off-by: NMatt Sicker <boards@gmail.com>

* Use SHA-256 more consistently
Signed-off-by: NMatt Sicker <boards@gmail.com>

Signed-off-by: NMatt Sicker <boards@gmail.com>

This refactors usage of Charset::forName on common character sets that
now have an equivalent value in StandardCharsets.

* [58571] Check if name is editable on item before doing rename.

* [JENKINS-58571]Form failure when rename item with not editable name.

* [JENKINS-58571] Change to IOException when isNameEditable is false.

* [JENKINS-58571] Validate test harness furure version.

* [JENKINS-58571] Validate test harness 2.55.

* Batch up dynamic plugin installations from setup wizard.

* Reworked to thread the list of batched-up plugins properly and introduced CompleteBatchJob to force the setup wizard to wait.

* UpdateCenterPluginInstallTest.test_installKnownPlugins failure.

* @amuniz notes that an existing message could now be considered misleading.

* Introduced UpdateCenter.DownloadJob.getDisplayName for better consistency in logging, as suggested by @Vlatombe.

* Reducing log levels of messages from dynamicLoad which are not of great interest, as suggested by @Vlatombe.

* Reducing log level of another message of little interest.

* Adding classic UI for CompleteBatchJob.

* CompleteBatchJob should be used only when dynamicLoad.

* Null defense on UpdateCenterJob.site.
Otherwise can get:
java.lang.NullPointerException
	at hudson.model.UpdateCenter.getConnectionCheckJob(UpdateCenter.java:850)
	at hudson.model.UpdateCenter.addConnectionCheckJob(UpdateCenter.java:817)
	at hudson.model.UpdateCenter.addJob(UpdateCenter.java:804)
	at hudson.model.UpdateSite$Plugin.deploy(UpdateSite.java:1367)
	at hudson.PluginManager.install(PluginManager.java:1537)
	at hudson.PluginManager.install(PluginManager.java:1496)
	at hudson.PluginManager.doInstall(PluginManager.java:1445)
	at …

JENKINS-36720: Fixed some spotbugs findings (SE_NO_SERIALVERSIONID, CO_COMPARETO_INCORRECT_FLOATING, VA_FORMAT_STRING_USES_NEWLINE)

* InstallPluginCommand.name is unnecessary.

* Minor changes to error reporting requested by @oleg-nenashev.

[JENKINS-54854] Added a warning when cron trigger spent more than a threshold (30s) in its execution (#3802)

* [JENKINS-54854] Added a warning when cron trigger spent more than a threshold (30s) in its execution

* Added a test

* Fix based on feedback

* Added Admin monitor

* Cleanup

* Polishing

* Fix according the feedback provided by Oliver

* Added missing renamed admin monitor class

* Better Web layout

* Limit stacked messages to 10 by default

* Improved replacement

* Make SlowTriggerAdminMonitor#errors thread-safe

* Fixed as requested

* Admin monitor title changed

This change catches the exception and returns false, invalidating the user session. This behavior is sensible, because if we are unable to validate the user we must assume the session is invalid.
Catching the error at this point reportedly helps with some scenarios and shouldn't cause any further harm.

* Avoid nodeprovisioner delay after consulting strategies

* Try another aproach - rate limit the review every second

* Throttle NodeProvisioner#update every second

* Re-indent to limit diff

* Update lastSuggestedReview

* Fix prior merge

* Logging messages

* Supplier

* Ignore additional calls to suggestReviewNow if we have a queued review

This reverts commit a604ddc7.

Display a warning in the Installed tab if the admin is about to disable or uninstall a detached plugin (#4098)

* Display a warning in the Installed tab if the admin is about to disable or uninstall a detached plugin.

* @since
Co-Authored-By: NOleg Nenashev <o.v.nenashev@gmail.com>

* Proof of concept catching exceptions for java 11 removed classes

* Add ClassLoader to a lot of places. Backup

* Commenting out wip stuff, change packages, count hits findClass

* Improvements, sending and tests

* Removing the catcher from chain to make funcional tests work

* Removing ignored places and a bit of cleaning

* Cleaning unused code after removing the catcher from the chain

* Remove imports cleaning to avoid extra changes

* Cleaning and explaining comments

* Explaining comments

* fix javadoc

* [JENKINS-57223] Address feedback from Matt Sicker. Improve in concurrency

* [JENKINS-57223] Search on cause and suppressed exceptions and fix on name reported

* [JENKINS-57223] Add cycles control on exceptions and refactor reporting method

* [JENKINS-57223] Add trim to class name comparison

* [JENKINS-57223] Address Oleg's feedback and some improvements

* Avoid sending CNFE when ignored later in code
* Disable when running on Java 8 and a test
* Avoid sending empty events

* [JENKINS-57223] Polish assertion after printing all missing classes in logs

* [JENKINS-57223] Avoid extra if and add curly braces

* [JENKINS-57223] Better comment about time window check

Co-Authored-By: NWadeck Follonier <wadeck.follonier@gmail.com>

This fixes the remember me service to link the user seed to a
corresponding HTTP session. By doing so, this should significantly
reduce the number of calls to loadUserDetails().
Signed-off-by: NMatt Sicker <boards@gmail.com>

* [JENKINS-57515] update jna library to 5.3.1

This solves problems with loading native libraries of jna on AIX
platform when using openJDK or other JDKs that assume .so is the
extension for shared libraries

* Pointer.SIZE -> Native.POINTER_SIZE

* remove unnecessary import

* adjust to changed api

(cherry picked from commit ffa9abf6)

(cherry picked from commit b18b2e68)

[JENKINS-57993] Avoid printing stack traces for some common agent conditions

(cherry picked from commit dcc395b8)

[JENKINS-57528] - Load detached plugins which are implicit deps of other plugins at startup even w/o UC (#4000)

* Do not warn repeatedly of the same missing update site dependency.
This happens when locally testing split plugins (despite their presence in WEB-INF/detached-plugins/*.hpi).

(cherry picked from commit 918a0fd2211210a158279b2f19690c86801fe4a1)

* Detached plugins must be kept up to date with security advisories.

(cherry picked from commit e08d28a69897ff94811e02040255a9d266c44d0d)

* Load detached plugins which are implicit dependencies of other plugins at startup, even if the update center was not used.

(cherry picked from commit ad7a36001d30a6174b25e616fc3c215dd24919d1)

* Adjusted expected version after e08d28a69897ff94811e02040255a9d266c44d0d.

(cherry picked from commit 84f939cebd1a0d03633e7b7c01e71ac387fb6463)

* e08d28a69897ff94811e02040255a9d266c44d0d exposed tests which had been incorrectly storing plugins as *.hpi rather than *.jpi.

(cherry picked from commit a0abad7ec474b28d2d388f075bc54f961046b09a)

* Test failure after ad7a36001d30a6174b25e616fc3c215dd24919d1.

(cherry picked from commit 0084e8dbdddf93bb1353516c1fe20d807577631f)

* Another test failure after ad7a36001d30a6174b25e616fc3c215dd24919d1; fewer installDetachedPlugin calls are now required.

(cherry picked from commit b65bb54e9975a7c77103bf7cf4da82295498f308)
(cherry picked from commit 855ea2ee)

* IntelliJ/Java: Duplicate code -- Refactored as ExtensionFinder.getClassFromIndex

* Adding braces around throw new AssertionError

* Change getInstance() (deprecated) to get()

* Reverting modifications according review

* Changing for use the variable

Slave constructor wants implementations to use setters,
but AbstractCloudSlave has no corresponding constructor.

* Implied dependencies on detached plugins were not being marked optional despite being listed in optionalDependencies, confusing the calculation of optionalDependents in resolveDependentPlugins.

* Javadoc improvements based on code exploration.

* [JENKINS-33843] Do not consider optional dependencies for purposes of disabling plugins.

* PluginManagerInstalledGUITest updated to reflect new behavior.

* [JENKINS-57515] update jna library to 5.3.1

This solves problems with loading native libraries of jna on AIX
platform when using openJDK or other JDKs that assume .so is the
extension for shared libraries

* Pointer.SIZE -> Native.POINTER_SIZE

* remove unnecessary import

* adjust to changed api