- 16 12月, 2016 1 次提交
-
-
由 Damian Szczepanik 提交于
-
- 15 12月, 2016 3 次提交
-
-
由 Pavel Janousek 提交于
* [JENKINS-38903] Split Exception handling for node provision and adding to Jenkins * Defined new static helper methods that ensure exceptions are not propagated * Added onCommit and onRollback signals to CloudProvisioningListener Added the new signals to be able to notify the state after Jenkins.addNode(Node) All Listener's calls moved to an exception-tolerant static helpers * Added @Nonnull annotation Changed the method signature CloudProvisioningListener.onRollback() * Re-throw Error in the fireOnXXX() Removed re-thrown Throwable in the main try/catch block (an instance of the Error is handled separately) * Handling of Error changed * Fixed Error instance handling in NodeProvisioner.fireOnFailure()
-
由 kbrowder 提交于
[FIXED JENKINS-40286] - Delegate JnlpMac computation to SlaveComputers if possible
-
由 andrealaura 提交于
[FIX JENKINS-40053]: Use english as default-locale ResourceBundleUtilTest#test_unknown_locale (#2650) * [FIX JENKINS-40053]: Use english as default-locale, so the ResourceBundleUtilTest runs also on systems with other default os locales. * [FIX JENKINS-40053]: Cleanup Locale after test to avoid impact on other tests. * [FIX JENKINS-40053]: Use english as default-locale only in the required test method. * [FIX JENKINS-40053]: Cleanup unused imports.
-
- 12 12月, 2016 1 次提交
-
-
由 Stephen Connolly 提交于
-
- 11 12月, 2016 1 次提交
-
-
由 Daniel Beck 提交于
-
- 09 12月, 2016 4 次提交
-
-
由 Daniel Beck 提交于
-
由 andrealaura 提交于
* [FIX JENKINS-36044]: Added default locale to XMLUtilsTest so that it runs independent from the host OS locale. * [FIX JENKINS-36044]: Cleanup default-locale after test, to avoid impact to other tests. * [FIX JENKINS-36044]: Make test language indepedent. * [FIX JENKINS-36044]: Cleanup unused imports.
-
由 Jesse Glick 提交于
* Converted to JenkinsRule. * Improved messages from Node.canTake. * [FIXED JENKINS-38514] BuildableItem needs to retain information from JobOffer about why it is neither blocked nor building. * Converted to JenkinsRule. * Found an existing usage of BecauseNodeIsNotAcceptingTasks. * Original JENKINS-6598 test was checking behavior we want amended by JENKINS-38514. * Ensure that a BuildableItem which is simply waiting for a free executor reports that as its CauseOfBlockage. * Review comments from @oleg-nenashev.
-
由 Jesse Glick 提交于
-
- 07 12月, 2016 2 次提交
-
-
由 Stephen Connolly 提交于
- This means we can default the migration to enabled
-
由 Kanstantsin Shautsou 提交于
UserProperty may contain nested objects that depend on User. On User reconfiguration setUser(User) is called so it should be non-final to have ability override it and update references in nested objects. Signed-off-by: NKanstantsin Shautsou <kanstantsin.sha@gmail.com>
-
- 03 12月, 2016 1 次提交
-
-
由 Oleg Nenashev 提交于
[JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods (#2653) * [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods * [JENKINS-23271] - Also prevent the issue when the kill() command is the last call in the usage sequence
-
- 30 11月, 2016 1 次提交
-
-
由 Baptiste Mathus 提交于
I have to read it many times each time I need it. Hopefully it's a bit clearer with this addition.
-
- 29 11月, 2016 3 次提交
-
-
由 Jesse Glick 提交于
-
由 Alvaro Lobato 提交于
[JENKINS-28245] - Finish deadmoose's work to allow defining agent ping interval and ping timeout in seconds
-
由 David Hoover 提交于
* Allows customization in seconds, not minutes * Allows customization of the ping timeout (before, you could set a custom interval, but the timeout would always be PingThread's 4 minute default) This also drops the serialVersionUID from ChannelPinger.SetUpRemotePing; without one provided, the JVM will generate one on demand which is sufficient for the purposes here since these are never persisted and master & slave run the same compiled code. (And it demonstrably works since countless other MasterToSlaveCallables fail to specify their own custom IDs)
-
- 28 11月, 2016 1 次提交
-
-
由 mawinter69 提交于
-
- 27 11月, 2016 1 次提交
-
-
由 Jesse Glick 提交于
* Optimize Actionable.getAllActions. * Also need to invalidate the cache when new plugins are installed. * Various improvements to TransientActionFactory caching. · Move the cache code to TransientActionFactory itself, for better encapsulation. · Optimize getAction(Class) to not need to call getAllActions; avoids copying lists, and can avoid calling TransientActionFactory at all. · Ensure that we maintain a separate cache per ExtensionList instance, so that static state is not leaked across Jenkins restarts. * Updated TransientActionFactory to specify what kinds of actions it could produce. * It turns out that changing type parameters for an extension, while generally binary-compatible, breaks reflective code in Jenkins and so this is not an option. … hudson.ExtensionFinder$GuiceFinder$SezpozModule configure WARNING: Failed to load com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl java.lang.LinkageError: Failed to resolve class com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:489) at hudson.ExtensionFinder$GuiceFinder$SezpozModule.configure(ExtensionFinder.java:506) at … at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:280) at … at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:472) at hudson.ExtensionList.load(ExtensionList.java:349) at hudson.ExtensionList.ensureLoaded(ExtensionList.java:287) at hudson.ExtensionList.getComponents(ExtensionList.java:167) at jenkins.model.Jenkins$8.onInitMilestoneAttained(Jenkins.java:1082) at jenkins.InitReactorRunner$1.onAttained(InitReactorRunner.java:82) at org.jvnet.hudson.reactor.ReactorListener$Aggregator.onAttained(ReactorListener.java:104) at org.jvnet.hudson.reactor.Reactor$1.run(Reactor.java:176) at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.reflect.MalformedParameterizedTypeException at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.validateConstructorArguments(ParameterizedTypeImpl.java:58) at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.<init>(ParameterizedTypeImpl.java:51) at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.make(ParameterizedTypeImpl.java:92) at sun.reflect.generics.factory.CoreReflectionFactory.makeParameterizedType(CoreReflectionFactory.java:105) at sun.reflect.generics.visitor.Reifier.visitClassTypeSignature(Reifier.java:140) at sun.reflect.generics.tree.ClassTypeSignature.accept(ClassTypeSignature.java:49) at sun.reflect.generics.repository.ClassRepository.getSuperclass(ClassRepository.java:90) at java.lang.Class.getGenericSuperclass(Class.java:777) at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:470) ... 29 more * Remove actionType override to make for a simpler diff. * Strengthened test to cover accesses to unrelated context types. * Strengthening tests in a couple of ways. * Javadoc improvements suggested by @oleg-nenashev.
-
- 25 11月, 2016 2 次提交
-
-
由 Oliver Gondža 提交于
-
由 Baptiste Mathus 提交于
Some properties are more important than others. One may for example want to log a WARNING instead of the current default CONFIG when some property can not be found, or has an invalid format (like a string, when asking for an Integer).
-
- 20 11月, 2016 3 次提交
-
-
由 Oleg Nenashev 提交于
[JENKINS-23271] - Prevent early deallocation of the Proc instance by GC in ProcStarter#join() (#2635) * [JENKINS-23271] - Prevent the prelimimary deallocation of the Proc instance by GC It is a hackish way, which likely prevents a preliminary deallocation of the spawned RemoteProc instance, which we see in JENKINS-23271. Proc instance was not actually required in the original code since we were creating and using RemoteInvocationHandler wrapper only, and the theory discussed with @stephenc was that object gets removed by Java8 garbage collector before we get into join(). This fix enforces the persistency of ProcStarter#start() result by adding logging and the enforced volatile field (maybe the last one is not really required, but JIT compiler in Java implementations may be smart enough to skip unused loggers) This is a pretty old fix from August, which has been soak tested on my instance for several weeks (mid-August => Jenkins World). On the reference instance (just a small Jenkins instance with 4 agents and very frequent builds with CommandInterpreter steps) I saw 2 failures over the period. On the fixed instance - 0. It does not proof anything, but at least the fix was soak tested a bit * [JENKINS-23271] - Get rid of the procHolderForJoin field * [JENKINS-23271] - Also put the check into the finally statement as @stephenc proposed * Remove assert
-
由 Daniel Beck 提交于
-
由 Thorsten Scherler 提交于
[FIX JENKINS-39034] /i18n/resourceBundle should be conform to the w3c standard about locale negotiation (#2594) * [parseCountry] Extract region/country and variant from the language parameter in case it is bigger then 2 letters. Add tests for both cases. * [JENKINS-39034] remove debug system out * [JENKINS-39034] Only if we have 5 or more character we want to get the country - prevent NPE * [JENKINS-39034] use split since it is more general * [JENKINS-39034] Only override country and variant if not already set * [JENKINS-39034] better test cases to test whether the fallback and variant resolving work corret * [JENKINS-39034] remove duplicate tests and better name existing ones
-
- 19 11月, 2016 1 次提交
-
-
由 Damian Szczepanik 提交于
-
- 14 11月, 2016 2 次提交
-
-
由 Oleg Nenashev 提交于
[FIXED JENKINS-38721, JENKINS-37282] - NPE in "CauseOfInterruption.UserInterruption" when user is missing (#2630) * [FIXED JENKINS-38721] - Prevent NPE during rendering of "CauseOfInterruption.UserInterruption" when user is missing It is a regression introduced in JENKINS-36594 * [JENKINS-38721] - Fix typo
-
由 Jesse Glick 提交于
-
- 12 11月, 2016 1 次提交
-
-
由 Kohsuke Kawaguchi 提交于
This basically is a convenient version of https://github.com/jenkinsci-cert/SECURITY-218. During the course of discussing how to fix SECURITY-360, it was agreed by the CERT team that we provide this switch.
-
- 11 11月, 2016 2 次提交
-
-
由 Damian Szczepanik 提交于
-
由 Jesse Glick 提交于
* Work around SUREFIRE-1226 just like https://github.com/jenkinsci/plugin-pom/pull/33. * [JENKINS-39520] Implement ExtensionList.removeAll. * @oleg-nenashev suggests not notifying listeners unless we are actually removing something.
-
- 09 11月, 2016 3 次提交
-
-
由 Lee Lavery 提交于
* Add viewport meta tag Enables better responsiveness on mobile devices * fix: Use self-closing tag * Remove minimum-scale for best accessibility * Add viewport meta tag
-
由 Baptiste Mathus 提交于
-
由 Oleg Nenashev 提交于
[FIXED JENKINS-39604] - ResourceBundleUtil#getBundle() should report resource misses on the low level I propose the FINER level.
-
- 08 11月, 2016 2 次提交
-
-
由 Oleg Nenashev 提交于
* [JENKINS-39465] - Tweak processing of enabled and disabled protocols in Jenkins instance Due to whatever reason, without a definition of an array recipient field the data goes to the disk in the following way: ``` <enabledAgentProtocol>JNLP3-connect</enabledAgentProtocol> <enabledAgentProtocol>JNLP4-connect</enabledAgentProtocol> ``` It is supposed to processed by Implicit array correctly, but it does not actually happen. With a fix the data is being stored in another format: ``` <enabledAgentProtocols> <string>JNLP3-connect</string> <string>JNLP4-connect</string> </enabledAgentProtocols> ``` This data now works correctly and gets deserialized correctly. readResolve() just adds a fallback for the case when Implicit array handling starts behaving correctly (?). * [JENKINS-39465] - Add configuration roundtrip tests * [JENKINS-39465] - Jenkins#agentProtocols cache must be invalidated when we reload the configuration * [JENKINS-39465] - Remove obsolete comment from Tests
-
由 Sam Van Oort 提交于
* Coarse fix for JENKINS-39555 - don't do the actions initialization by helper method * Small cleanup of docs, import * Testcase * Review changes
-
- 06 11月, 2016 3 次提交
-
-
由 Akbashev Alexander 提交于
* Add some tests to current behaviour of getLog method * getLog(maxLines) reads only last maxLines lines now It should speed up and reduce memory consumption for some plugins (i.e. Email-ext Plugin). Also now this method could be used to get last lines of build output in efficient manner. * Fix issues from code review
-
由 Jesse Glick 提交于
[FIXED JENKINS-39454] Do not consider pendings when deciding whether a schedule result should be new or existing, as we have already taken a snapshot of actions. (#2609)
-
由 Oleg Nenashev 提交于
[FIXED JENKINS-38487] - Jenkins startup must not fail in the case of ComputerListener failure (#2610) Without this code Jenkinbs startup fails if EnvInject fails to find global property file on startup. Javadoc says "Exceptions will be recorded to the listener. Note that throwing an exception doesn't put the computer offline." regarding the listener method exception, hence we should not block Jenkins startup
-
- 04 11月, 2016 2 次提交
-
-
由 Stephen Connolly 提交于
-
由 Stephen Connolly 提交于
-