using invisible <TR> to improve the UI a bit.

(11:09:06 AM) dty: kohsuke, ping
(11:09:14 AM) kohsuke: hi
(11:09:40 AM) dty: qq about http://fisheye.hudson-ci.org/changelog/Hudson/trunk/hudson/main/core/src/main/resources/lib/form/descriptorRadioList.jelly?cs=34003 that you made a while ago
(11:10:05 AM) dty: The extra f:entry adds an empty row underneath each radio button in descriptor lists
(11:10:14 AM) dty: Can we just have a bare input element without the f:entry?
(11:10:48 AM) kohsuke: dty: no, because that would put <INPUT> among <TR>s
(11:11:05 AM) kohsuke: some browsers push such <INPUT> outside of the table, breaking the hierarchy
(11:11:21 AM) dty: Bleah. The extra space looks unsightly.
(11:11:32 AM) kohsuke: I think we can display:none
(11:13:07 AM) dty: I'm not familiar with that. Is it part of Hudson's taglib, or something else?
(11:13:30 AM) dty: Ah, css
(11:14:33 AM) dty: Would you put that on the entry tag globally, or just on the input element you added?
(11:23:54 AM) kohsuke: dty: probably just on this <f:entry>
(11:24:18 AM) kohsuke: or maybe it could be a distinct tag of its own

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@35529 71c3de6d-444a-0410-be80-ed276b4c234a

core/src/main/resources/hudson/model/Hudson/configure.jelly

@@ -131,9 +131,9 @@ THE SOFTWARE.
       <j:forEach var="p" items="${it.pluginManager.plugins}">
         <j:if test="${h.hasView(p.plugin,'config.jelly')}">
           <f:rowSet name="plugin">
-            <tr><td>
+            <f:invisibleEntry>
               <input type="hidden" name="name" value="${p.shortName}"/>
-            </td></tr>
+            </f:invisibleEntry>
             <st:include page="config.jelly" it="${p.plugin}" optional="true"/>
           </f:rowSet>
         </j:if>

core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly

@@ -55,9 +55,9 @@ THE SOFTWARE.
         <j:set var="descriptor" value="${d}"/>
         <j:set var="instance"
                value="${it.launcher.descriptor==d ? it.launcher : null}"/>
-        <tr><td>
+        <f:invisibleEntry>
           <input type="hidden" name="stapler-class" value="${d.clazz.name}" />
-        </td></tr>
+        </f:invisibleEntry>
         <st:include from="${d}" page="${d.configPage}" optional="true"/>
       </f:dropdownListBlock>
     </j:forEach>

core/src/main/resources/lib/form/descriptorRadioList.jelly

@@ -52,9 +52,9 @@ THE SOFTWARE.
         title="${d.displayName}" checked="${instance.descriptor==d}">
         <j:set var="descriptor" value="${d}" />
 	      <j:set var="instance" value="${instance.descriptor==d?instance:null}" />
-        <f:entry>
+        <f:invisibleEntry>
           <input type="hidden" name="stapler-class" value="${descriptor.clazz.name}"/>
-        </f:entry>
+        </f:invisibleEntry>
 	      <st:include from="${d}" page="${d.configPage}" optional="true" />
 	    </f:radioBlock>
 	  </j:forEach>

core/src/main/resources/lib/form/hetero-radio.jelly

@@ -46,9 +46,9 @@ THE SOFTWARE.
         <j:set var="instance" value="${currentDescriptor==d?currentInstance:null}" />
         <st:include from="${d}" page="${d.configPage}" optional="true" />
 
-        <f:block><!-- this tells Stapler which block is for which class -->
+        <f:invisibleEntry><!-- this tells Stapler which block is for which class -->
           <input type="hidden" name="stapler-class" value="${d.clazz.name}" />
-        </f:block>
+        </f:invisibleEntry>
       </f:radioBlock>
     </j:forEach>
   </table>

core/src/main/resources/lib/form/invisibleEntry.jelly

+<!--
+The MIT License
+
+Copyright (c) 2010, InfraDNA, Inc.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+-->
+
+<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
+  <st:documentation>
+    Invisible &lt;f:entry> type. Useful for adding hidden field values.
+  </st:documentation>
+  <tr style="display:none">
+    <td>
+      <d:invokeBody />
+    </td>
+  </tr>
+</j:jelly>
\ No newline at end of file