- 07 11月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
This makes sure to compile query values for rewrites/redirects as non-path items to prevent param like values e.g. `https://` from causing the destination to fail to compile. Fixes: https://github.com/vercel/next.js/issues/17440 x-ref: https://github.com/vercel/next.js/issues/18670
-
- 06 11月, 2020 1 次提交
-
-
由 Guy Bedford 提交于
This upgrades to ncc@0.25.0 and fixes the previous bugs including: * ncc not referenced correctly in build * Babel type errors * node-fetch, etag, chalk and raw-body dependencies not building with ncc - these have been "un-ncc'd" for now. As they are relatively small dependencies, this doesn't seem too much of an issue and we can follow up in the tracking ncc issue at https://github.com/vercel/ncc/issues/612. * `yarn dev` issues Took a lot of bisecting, but the overall diff isn't too bad here in the end.
-
- 05 11月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
This updates the GS(S)P redirect handling to make sure to handle redirects correctly when coming from the incremental-cache. Additional tests have been added to ensure the redirects work correctly after the cache is populated. Fixes: https://github.com/vercel/next.js/issues/18735 Fixes: https://github.com/vercel/next.js/issues/18783
-
- 03 11月, 2020 3 次提交
-
-
由 JJ Kasper 提交于
This ensures the `basePath` property works correctly when a multi-level value is defined (`/hello/world`) Fixes: https://github.com/vercel/next.js/issues/17889
-
由 JJ Kasper 提交于
When visiting a non-locale prefixed path (`/hello` instead of `/fr/hello`) we don't trigger locale redirects currently so if another locale is matched we need to ensure this is reset to the `defaultLocale` for rendering to prevent a mis-match on the client and the server. This also fixes hydration errors from occurring with `asPath` for `getServerSideProps` pages due to `normalizeLocalePath` expecting only a pathname and `asPath` containing `hash` and `query values also. Fixes: https://github.com/vercel/next.js/issues/18337 Fixes: https://github.com/vercel/next.js/issues/18510
-
由 JJ Kasper 提交于
This ensures we don't detect the locale from the header when `localeDetection` is set to `false` Fixes: https://github.com/vercel/next.js/issues/18482
-
- 27 10月, 2020 4 次提交
-
-
由 Joe Haddad 提交于
-
由 JJ Kasper 提交于
-
由 JJ Kasper 提交于
-
由 JJ Kasper 提交于
This is a follow-up to https://github.com/vercel/next.js/pull/17755 which adds support for returning `notFound` to `getServerSideProps` also
-
- 25 10月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
This ensures a custom `/404` page with `getStaticProps` works correctly when leveraging the new `unstable_notFound` support in `getStaticProps` Closes: https://github.com/vercel/next.js/issues/18196 x-ref: https://github.com/vercel/next.js/pull/17755
-
- 23 10月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
* Update redirect query encoding * Add additional tests
-
- 22 10月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
This updates the fallback 404 handling to render the correct 404 page on the client when a 404 is returned from fetching the data route on a fallback page on the client. This prevents us from having to rely on a cache to be updated by the time we reload the page to prevent non-stop reloading. This also adds handling in serverless mode to ensure the correct 404 page is rendered when leveraging fallback: 'blocking' mode. Additional tests for the fallback: 'blocking' 404 handling will be added in a follow-up where returning notFound from `getServerSideProps` is also added.
-
- 21 10月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
This makes sure the `locales` are passed to `getStaticPaths` and also disables the removing the default locale from the path when the default locale is the preferred header. It also updates tests to ensure the domain redirects are working as expected. x-ref: https://github.com/vercel/next.js/pull/17370
-
- 20 10月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
This makes sure that we detect the correct default locale for domain specific locales since a domain can have a different default locale residing at the root and we need to check this on the client for prerendered/auto-static pages. This also makes sure we disable the built-in redirect handling when on Vercel since it's handled already. Tests for this are tricky since we need to load the browser with a custom domain which requires editing the host file. Existing tests should ensure this doesn't break non-domain specific locale behavior though. This was also tested manually while testing https://github.com/vercel/vercel/pull/5298 x-ref: https://github.com/vercel/next.js/pull/17370
-
- 16 10月, 2020 3 次提交
- 15 10月, 2020 2 次提交
-
-
由 JJ Kasper 提交于
This adds the `locale` prop for `next/link` to allow transitioning between locales client-side and also allows passing the locale to `router.push/replace` via the transition options similar to `shallow` e.g. `router.push('/another', '/another, { locale: 'nl' })` x-ref: https://github.com/vercel/next.js/pull/17370
-
由 JJ Kasper 提交于
This updates to set the `NEXT_LOCALE` cookie to the default locale when the user prefers a different locale from the default in their `accept-language` header but visits the default locale path e.g. `/en-US` with a `accept-language` preferred header of `nl` will set the `NEXT_LOCALE=en-US` header and then redirect to `/` x-ref: https://github.com/vercel/next.js/pull/17370
-
- 14 10月, 2020 3 次提交
-
-
由 Alex Castle 提交于
Co-authored-by: NTim Neutkens <timneutkens@me.com> Co-authored-by: NTim Neutkens <tim@timneutkens.nl>
-
由 JJ Kasper 提交于
Co-authored-by: Nkodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
由 Jan Potoms 提交于
Co-authored-by: NJJ Kasper <jj@jjsweb.site> Co-authored-by: Nkodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
- 12 10月, 2020 2 次提交
-
-
由 JJ Kasper 提交于
While working on https://github.com/vercel/next.js/pull/17755 noticed a couple of cases that needed fixing and broke them out to this PR to make that one easier to review. One fix is for `ssgCacheKey` where it wasn't having the `locale` prefix stripped correctly due to the locales no longer being populated under the server instances `renderOpts` and the second fix is for the `asPath` not being set to `/` when the `locale` is the only part in the URL e.g. `/en` became an empty string `""` x-ref: https://github.com/vercel/next.js/pull/17370
-
由 JJ Kasper 提交于
Follow-up to https://github.com/vercel/next.js/pull/17370 this makes sure the locale detection is case-insensitive.
-
- 10 10月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
Follow-up to https://github.com/vercel/next.js/pull/17370 this adds mapping of locales to domains and handles default locales for specific domains also allowing specifying which locales can be visited for each domain. This PR also updates to output all statically generated pages under the locale prefix to make it easier to locate/lookup and to not redirect to the default locale prefixed path when no `accept-language` header is provided.
-
- 09 10月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
Follow-up PR to #17370 this adds generating auto-export, non-dynamic SSG, and fallback pages with all locales. Dynamic SSG pages still control which locales the pages are generated with using `getStaticPaths`. To further control which locales non-dynamic SSG pages will be prerendered with a follow-up PR adding handling for 404 behavior from `getStaticProps` will be needed. x-ref: https://github.com/vercel/next.js/issues/17110
-
- 08 10月, 2020 2 次提交
-
-
由 JJ Kasper 提交于
Follow-up PR to https://github.com/vercel/next.js/pull/17370 when the path is not prefixed with a locale and the default locale is the detected locale it doesn't redirect to locale prefixed variant. If the default locale path is visited and the default locale is visited this also redirects to the root removing the un-necessary locale in the URL. This also exposes the `defaultLocale` on the router since the RFC mentions `Setting a defaultLocale is required in every i18n library so it'd be useful for Next.js to provide it to the application.` although doesn't explicitly spec where we want to expose it. If we want to expose it differently this can be updated.
-
由 JJ Kasper 提交于
This adds the initial changes outlined in the [i18n routing RFC](https://github.com/vercel/next.js/discussions/17078). This currently treats the locale prefix on routes similar to how the basePath is treated in that the config doesn't require any changes to your pages directory and is automatically stripped/added based on the detected locale that should be used. Currently redirecting occurs on the `/` route if a locale is detected regardless of if an optional catch-all route would match the `/` route or not we may want to investigate whether we want to disable this redirection automatically if an `/index.js` file isn't present at root of the pages directory. TODO: - [x] ensure locale detection/populating works in serverless mode correctly - [x] add tests for locale handling in different modes, fallback/getStaticProps/getServerSideProps To be continued in fall-up PRs - [ ] add tests for revalidate, auto-export, basePath + i18n - [ ] add mapping of domains with locales - [ ] investigate detecting locale against non-index routes and populating the locale in a cookie x-ref: https://github.com/vercel/next.js/issues/17110
-
- 26 9月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
* Expose dotenv loading under separate package * Update pre-compiled * Rename package to @next/env * Update lint ignores * Update package.json Co-authored-by: NJoe Haddad <joe.haddad@zeit.co>
-
- 24 9月, 2020 1 次提交
-
-
由 Joe Haddad 提交于
Prior to this pull request, Next.js would immediately decode all URLs sent to its server (via `path-match`). This was rarely needed, and Next.js would typically re-encode the incoming request right away (see all the `encodeURIComponent`s removed in PR diff). This adds unnecessary performance overhead. Long term, this will also help prevent weird encoding edge-cases like #10004, #10022, #11371, et al. --- No new tests are necessary for this change because we've extensively tested these edge cases with existing tests. One test was updated to reflect that we skip decoding in a 404 scenario. Let's see if all the existing tests pass!
-
- 16 9月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
This makes sure we have the correct `asPath` value to prevent breaking hydration for `getServerSideProps` pages and doesn't re-use the `resolvedUrl` value for the `asPath` and instead creates a separate `resolvedAsPath` value that only removes the `_next/data` prefix from the path. Additional tests have been added in the `getServerSideProps` suite to ensure correct `asPath` with rewrites. Fixes: https://github.com/vercel/next.js/issues/17113
-
- 15 9月, 2020 2 次提交
-
-
由 JJ Kasper 提交于
This continues off of https://github.com/vercel/next.js/pull/17081 and provides this normalized `asPath` value in the context provided to `getServerSideProps` to provide the consistent value since the request URL can vary between direct visit and client transition and the alternative requires building the URL each time manually. Kept this change separate from https://github.com/vercel/next.js/pull/17081 since this is addressing a separate issue and allows discussion separately. Closes: https://github.com/vercel/next.js/issues/16407
-
由 JJ Kasper 提交于
This normalizes the `asPath` for `getServerSideProps` and `getStaticProps` pages to ensure it matches the value that would show on the client instead of a) the output pathname when revalidating or generating a fallback or b) the `_next/data` URL on client transition. Fixes: https://github.com/vercel/next.js/issues/16542
-
- 22 8月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
This fixes a client-side file not being transpiled correctly when rewrites are used. The cross browser tests have been updated to make sure there are rewrites so the related code is included and not dead-code eliminated' Closes: https://github.com/vercel/next.js/issues/16440
-
- 21 8月, 2020 1 次提交
-
-
由 Joe Haddad 提交于
We were accidentally allowing data requests to be rendered unconditionally. Instead, we should also check them against the staticPaths result and 404 when appropriate. --- Fixes #15383
-
- 20 8月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
This corrects the basePath being required check for filesystem routes to not consider the public folder catch-all route since it always matches even if the public file isn't present and instead moves the basePath check inside of the public-folder catch-all. Tests already exist that catch this by adding a public folder to the existing `basepath` test suite Fixes: https://github.com/vercel/next.js/issues/16332 Closes: https://github.com/vercel/next.js/pull/16350
-
- 13 8月, 2020 1 次提交
-
-
由 JJ Kasper 提交于
Co-authored-by: NTim Neutkens <timneutkens@me.com>
-
- 12 8月, 2020 1 次提交
-
-
由 Tim Neutkens 提交于
We no longer use tslint so these comments don't do anything.
-
- 11 8月, 2020 1 次提交
-
-
由 Prateek Bhatnagar 提交于
Co-authored-by: NTim Neutkens <tim@timneutkens.nl> Co-authored-by: NJoe Haddad <joe.haddad@zeit.co>
-