feat: make line bolder when line is in emphasis mode, designed by apache#12931.

90339963 · plainheart · 39bd739c · 90339963 · 90339963 · 90339963
Showing with 112 addition and 5 deletion

src/chart/line/LineSeries.ts src/chart/line/LineSeries.ts +6 -2

src/chart/line/LineView.ts src/chart/line/LineView.ts +13 -3

test/line-boldWhenHover.html test/line-boldWhenHover.html +93 -0

未找到文件。
--- a/src/chart/line/LineSeries.ts
+++ b/src/chart/line/LineSeries.ts
@@ -103,6 +103,8 @@ export interface LineSeriesOption extends SeriesOption<LineStateOption, ExtraSta
    showAllSymbol?: 'auto'

    data?: (LineDataValue | LineDataItemOption)[]
+
+    bolderWhenHover?: boolean
 }

 class LineSeriesModel extends SeriesModel<LineSeriesOption> {
@@ -182,10 +184,12 @@ class LineSeriesModel extends SeriesModel<LineSeriesOption> {

        // Disable progressive
        progressive: 0,
-        hoverLayerThreshold: Infinity
+        hoverLayerThreshold: Infinity,
+
+        bolderWhenHover: true
    };
 }

 SeriesModel.registerClass(LineSeriesModel);

-export default LineSeriesModel;
\ No newline at end of file
+export default LineSeriesModel;
--- a/src/chart/line/LineView.ts
+++ b/src/chart/line/LineView.ts
@@ -544,11 +544,21 @@ class LineView extends ChartView {
            {
                fill: 'none',
                stroke: visualColor,
-                lineJoin: 'bevel'
+                lineJoin: 'bevel' as CanvasLineJoin
            }
        ));

        setStatesStylesFromModel(polyline, seriesModel, 'lineStyle');
+
+        const bolderWhenHover = seriesModel.get('bolderWhenHover');
+        if (bolderWhenHover) {
+            const emphasisLineStyle = polyline.getState('emphasis').style;
+            // only bolder when `emphasis.lineStyle.width` is not specified
+            if (emphasisLineStyle.lineWidth == null) {
+                emphasisLineStyle.lineWidth = lineStyleModel.get('width') + 1;
+            }
+        }
+
        // Needs seriesIndex for focus
        graphic.getECData(polyline).seriesIndex = seriesModel.seriesIndex;
        enableHoverEmphasis(polyline, focus, blurScope);
@@ -569,7 +579,7 @@ class LineView extends ChartView {
                {
                    fill: visualColor,
                    opacity: 0.7,
-                    lineJoin: 'bevel'
+                    lineJoin: 'bevel' as CanvasLineJoin
                }
            ));

@@ -881,4 +891,4 @@ class LineView extends ChartView {

 ChartView.registerClass(LineView);

-export default ChartView;
\ No newline at end of file
+export default ChartView;
--- a/test/line-boldWhenHover.html
+++ b/test/line-boldWhenHover.html
+<!DOCTYPE html>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<html>
+
+<head>
+    <meta charset="utf-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    <script src="lib/esl.js"></script>
+    <script src="lib/config.js"></script>
+    <script src="lib/facePrint.js"></script>
+    <script src="lib/testHelper.js"></script>
+    <link rel="stylesheet" href="lib/reset.css" />
+</head>
+
+<body>
+    <div id="main0"></div>
+    <div></div>
+    <script>
+        var chart;
+        var myChart;
+
+        require([
+            'echarts'
+        ], function (echarts) {
+            var option = {
+                legend: {
+                    left: 'center',
+                    bottom: 'bottom'
+                },
+                xAxis: {
+                    type: 'category',
+                    data: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12],
+                },
+                yAxis: {
+                    type: 'value'
+                },
+                series: [
+                    {
+                        name: 'line series 1',
+                        type: 'line',
+                        data: [28.5, 70.5, 108.4, 129.2, 144.0, 176.0, 135.6, 148.5, 216.4, 194.1, 95.6, 54.4],
+                        symbolSize: 10,
+                        symbol: 'square',
+                        bolderWhenHover: false,
+                        emphasis: {
+                            focus: 'series',
+                            lineStyle: {
+                                width: 5
+                            }
+                        }
+                    },
+                    {
+                        name: 'line series 2',
+                        type: 'line',
+                        data: [226.9, 194.1, 95.6, 54.4, 29.9, 71.5, 106.4, 129.2, 144.0, 176.0, 135.6, 148.5],
+                        symbolSize: 10,
+                        symbol: 'circle',
+                        emphasis: {
+                            focus: 'series'
+                        }
+                    }
+                ]
+            };
+
+            chart = myChart = testHelper.create(echarts, 'main0', {
+                title: [
+                    'For lineThe line should be bolder when hover'
+                ],
+                option: option
+            });
+        });
+
+    </script>
+</body>
+
+</html>