Kapt: Handle parameter with Java names clashing with Java keywords properly (KT-18377)

plugins/kapt3/src/org/jetbrains/kotlin/kapt3/stubs/ClassFileToSourceStubConverter.kt

@@ -437,7 +437,7 @@ class ClassFileToSourceStubConverter(
                     info.visibleAnnotations,
                     info.invisibleAnnotations)
 
-            val name = treeMaker.name(getValidIdentifierName(info.name) ?: "p${index}_" + info.name.hashCode())
+            val name = treeMaker.name(getValidIdentifierName(info.name) ?: "p${index}_" + info.name.hashCode().ushr(1))
             val type = treeMaker.Type(info.type)
             treeMaker.VarDef(modifiers, name, type, null)
         }

plugins/kapt3/test/org/jetbrains/kotlin/kapt3/test/ClassFileToSourceStubConverterTestGenerated.java

@@ -180,6 +180,12 @@ public class ClassFileToSourceStubConverterTestGenerated extends AbstractClassFi
         doTest(fileName);
     }
 
+    @TestMetadata("kt18377.kt")
+    public void testKt18377() throws Exception {
+        String fileName = KotlinTestUtils.navigationMetadata("plugins/kapt3/testData/converter/kt18377.kt");
+        doTest(fileName);
+    }
+
     @TestMetadata("mapEntry.kt")
     public void testMapEntry() throws Exception {
         String fileName = KotlinTestUtils.navigationMetadata("plugins/kapt3/testData/converter/mapEntry.kt");

plugins/kapt3/testData/converter/kt18377.kt

+import java.util.Date
+
+fun Date(double: Double): Date = Date(double.times(1000).toLong())
\ No newline at end of file

plugins/kapt3/testData/converter/kt18377.txt

+@kotlin.Metadata()
+public final class Kt18377Kt {
+
+    public Kt18377Kt() {
+        super();
+    }
+
+    @org.jetbrains.annotations.NotNull()
+    public static final java.util.Date Date(double p0_1484504552) {
+        return null;
+    }
+}

plugins/kapt3/testData/converter/strangeIdentifiers.txt

@@ -50,7 +50,7 @@ public final class Test {
 
     public final void strangeFun4(@org.jetbrains.annotations.NotNull()
     java.lang.String a, @org.jetbrains.annotations.NotNull()
-    java.lang.String p1_1899121793) {
+    java.lang.String p1_949560896) {
     }
 
     public Test() {