提交 1216b335 编写于 作者: D Dmitriy Novozhilov 提交者: TeamCityServer

[Test] Move extracting JVM_TARGET to provideConfigurationKeys

上级 606ae45f
...@@ -323,10 +323,6 @@ class CodegenTestsOnAndroidGenerator private constructor(private val pathManager ...@@ -323,10 +323,6 @@ class CodegenTestsOnAndroidGenerator private constructor(private val pathManager
services.registerDependencyProvider(DependencyProviderImpl(services, moduleStructure.modules)) services.registerDependencyProvider(DependencyProviderImpl(services, moduleStructure.modules))
val keyConfiguration = CompilerConfiguration() val keyConfiguration = CompilerConfiguration()
module.directives.singleOrZeroValue(JvmEnvironmentConfigurationDirectives.JVM_TARGET)?.let {
keyConfiguration.put(JVMConfigurationKeys.JVM_TARGET, it)
}
val configuratorForFlags = JvmEnvironmentConfigurator(services) val configuratorForFlags = JvmEnvironmentConfigurator(services)
with(configuratorForFlags) { with(configuratorForFlags) {
val extractor = DirectiveToConfigurationKeyExtractor() val extractor = DirectiveToConfigurationKeyExtractor()
......
...@@ -27,10 +27,10 @@ abstract class EnvironmentConfigurator(protected val testServices: TestServices) ...@@ -27,10 +27,10 @@ abstract class EnvironmentConfigurator(protected val testServices: TestServices)
configuration: CompilerConfiguration, configuration: CompilerConfiguration,
module: TestModule, module: TestModule,
) { ) {
configureCompilerConfiguration(configuration, module)
val extractor = DirectiveToConfigurationKeyExtractor() val extractor = DirectiveToConfigurationKeyExtractor()
extractor.provideConfigurationKeys() extractor.provideConfigurationKeys()
extractor.configure(configuration, module.directives) extractor.configure(configuration, module.directives)
configureCompilerConfiguration(configuration, module)
} }
open fun DirectiveToConfigurationKeyExtractor.provideConfigurationKeys() {} open fun DirectiveToConfigurationKeyExtractor.provideConfigurationKeys() {}
......
...@@ -21,6 +21,7 @@ import org.jetbrains.kotlin.test.TestJdkKind ...@@ -21,6 +21,7 @@ import org.jetbrains.kotlin.test.TestJdkKind
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.ASSERTIONS_MODE import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.ASSERTIONS_MODE
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.CONSTRUCTOR_CALL_NORMALIZATION_MODE import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.CONSTRUCTOR_CALL_NORMALIZATION_MODE
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.JVM_TARGET
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.LAMBDAS import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.LAMBDAS
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.SAM_CONVERSIONS import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.SAM_CONVERSIONS
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.STRING_CONCAT import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.STRING_CONCAT
...@@ -34,7 +35,6 @@ import org.jetbrains.kotlin.test.directives.LanguageSettingsDirectives.NO_UNIFIE ...@@ -34,7 +35,6 @@ import org.jetbrains.kotlin.test.directives.LanguageSettingsDirectives.NO_UNIFIE
import org.jetbrains.kotlin.test.directives.LanguageSettingsDirectives.PARAMETERS_METADATA import org.jetbrains.kotlin.test.directives.LanguageSettingsDirectives.PARAMETERS_METADATA
import org.jetbrains.kotlin.test.directives.model.DirectivesContainer import org.jetbrains.kotlin.test.directives.model.DirectivesContainer
import org.jetbrains.kotlin.test.directives.model.RegisteredDirectives import org.jetbrains.kotlin.test.directives.model.RegisteredDirectives
import org.jetbrains.kotlin.test.directives.model.singleOrZeroValue
import org.jetbrains.kotlin.test.model.DependencyDescription import org.jetbrains.kotlin.test.model.DependencyDescription
import org.jetbrains.kotlin.test.model.DependencyKind import org.jetbrains.kotlin.test.model.DependencyKind
import org.jetbrains.kotlin.test.model.TestModule import org.jetbrains.kotlin.test.model.TestModule
...@@ -73,15 +73,13 @@ class JvmEnvironmentConfigurator(testServices: TestServices) : EnvironmentConfig ...@@ -73,15 +73,13 @@ class JvmEnvironmentConfigurator(testServices: TestServices) : EnvironmentConfig
register(DISABLE_CALL_ASSERTIONS, JVMConfigurationKeys.DISABLE_CALL_ASSERTIONS) register(DISABLE_CALL_ASSERTIONS, JVMConfigurationKeys.DISABLE_CALL_ASSERTIONS)
register(NO_UNIFIED_NULL_CHECKS, JVMConfigurationKeys.NO_UNIFIED_NULL_CHECKS) register(NO_UNIFIED_NULL_CHECKS, JVMConfigurationKeys.NO_UNIFIED_NULL_CHECKS)
register(PARAMETERS_METADATA, JVMConfigurationKeys.PARAMETERS_METADATA) register(PARAMETERS_METADATA, JVMConfigurationKeys.PARAMETERS_METADATA)
register(JVM_TARGET, JVMConfigurationKeys.JVM_TARGET)
} }
override fun configureCompilerConfiguration(configuration: CompilerConfiguration, module: TestModule) { override fun configureCompilerConfiguration(configuration: CompilerConfiguration, module: TestModule) {
if (module.targetPlatform !in JvmPlatforms.allJvmPlatforms) return if (module.targetPlatform !in JvmPlatforms.allJvmPlatforms) return
val registeredDirectives = module.directives
registeredDirectives.singleOrZeroValue(JvmEnvironmentConfigurationDirectives.JVM_TARGET)?.let {
configuration.put(JVMConfigurationKeys.JVM_TARGET, it)
}
configureDefaultJvmTarget(configuration) configureDefaultJvmTarget(configuration)
val registeredDirectives = module.directives
when (extractJdkKind(registeredDirectives)) { when (extractJdkKind(registeredDirectives)) {
TestJdkKind.MOCK_JDK -> { TestJdkKind.MOCK_JDK -> {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册