Skip to content

B
brakeman

社会瑞弟呀 / brakeman

通知 1
Star 0
Fork 0
B
brakeman

体验新版 GitCode，发现更多精彩内容 >>

提交 6d5bb6bd 编写于 作者: J Justin Collins
浏览文件
操作

Move Brakeman::Rescanner to its own file

上级 3f0b45e0
隐藏空白更改
内联 并排
Showing with 204 addition and 201 deletion
lib/brakeman.rb
浏览文件 @ 6d5bb6bd
......@@ -253,6 +253,8 @@ module Brakeman
end
def self.rescan tracker, files
require 'brakeman/rescanner'
Rescanner.new(tracker.options, tracker.processor, files).recheck
end
end
lib/brakeman/rescanner.rb 0 → 100644
浏览文件 @ 6d5bb6bd
require 'brakeman/scanner'
class Brakeman::Rescanner < Brakeman::Scanner
def initialize options, processor, files
super(options, processor)
@paths = files #Files to rescan
@old_results = tracker.checks #Old warnings from previous scan
@changes = nil #True if files had to be rescanned
end
def recheck
rescan if @changes.nil?
tracker.run_checks if @changes
Brakeman::RescanReport.new @old_results, tracker.checks
end
def rescan
tracker.template_cache.clear
@changes = false
@paths.each do |path|
if rescan_file path
@changes = true
end
end
index_call_sites
self
end
def rescan_file path
case file_type path
when :controller
rescan_controller path
when :template
rescan_template path
when :model
rescan_model path
when :lib
process_library path
when :config
process_config
when :initializer
process_initializer path
when :routes
# Routes affect which controller methods are treated as actions
# which affects which templates are rendered, so routes, controllers,
# and templates rendered from controllers must be rescanned
tracker.reset_routes
tracker.reset_templates :only_rendered => true
process_routes
process_controllers
when :gemfile
process_gems
else
return false #Nothing to do, file hopefully does not need to be rescanned
end
true
end
def rescan_controller path
#Process source
process_controller path
#Process data flow and template rendering
#from the controller
tracker.controllers.each do |name, controller|
if controller[:file] == path
tracker.templates.keys.each do |template_name|
if template_name.to_s.match /(.+)\.#{name}#/
tracker.templates.delete template_name
end
end
@processor.process_controller_alias controller[:src]
end
end
end
def rescan_template path
template_name = template_path_to_name(path)
tracker.reset_template template_name
process_template path
@processor.process_template_alias tracker.templates[template_name]
rescan = Set.new
rendered_from_controller = /^#{template_name}\.(.+Controller)#(.+)/
rendered_from_view = /^#{template_name}\.Template:(.+)/
#Search for processed template and process it.
#Search for rendered versions of template and re-render (if necessary)
tracker.templates.each do |name, template|
if template[:file] == path or template[:file].nil?
name = name.to_s
if name.match(rendered_from_controller)
#Rendered from controller, so reprocess controller
rescan << [:controller, $1.to_sym, $2.to_sym]
elsif name.match(rendered_from_view)
#Rendered from another template, so reprocess that template
rescan << [:template, $1.to_sym]
end
end
end
rescan.each do |r|
if r[0] == :controller
controller = tracker.controllers[r[1]]
if @paths.include? controller[:file]
rescan_controller controller[:file]
else
@processor.process_controller_alias controller[:src], r[2]
end
elsif r[0] == :template
template = tracker.templates[r[1]]
rescan_template template[:file]
end
end
end
def rescan_model path
num_models = tracker.models.length
tracker.reset_model path
process_model path if File.exists? path
#Only need to rescan other things if a model is added or removed
if num_models != tracker.models.length
process_templates
process_controllers
end
end
#Guess at what kind of file the path contains
def file_type path
case path
when /\/app\/controllers/
:controller
when /\/app\/views/
:template
when /\/app\/models/
:model
when /\/lib/
:lib
when /\/config\/initializers/
:initializer
when /config\/routes\.rb/
:routes
when /\/config/
:config
when /Gemfile/
:gemfile
else
:unknown
end
end
end
class Brakeman::RescanReport
attr_reader :old_results, :new_results
def initialize old_results, new_results
@old_results = old_results
@new_results = new_results
@diff = nil
end
#Returns an array of warnings which were in the old report but are not in the
#new report after rescanning
def fixed_warnings
diff[:fixed]
end
#Returns an array of warnings which were in the new report but were not in
#the old report
def new_warnings
diff[:new]
end
#Returns true if there are any new or fixed warnings
def warnings_changed?
not (diff[:new].empty? and diff[:fixed].empty?)
end
#Returns a hash of arrays for :new and :fixed warnings
def diff
@diff ||= @old_results.diff(@new_results)
end
end
lib/brakeman/scanner.rb
浏览文件 @ 6d5bb6bd
......@@ -361,207 +361,6 @@ class Brakeman::Scanner
end
end
class Brakeman::Rescanner < Brakeman::Scanner
def initialize options, processor, files
super(options, processor)
@paths = files #Files to rescan
@old_results = tracker.checks #Old warnings from previous scan
@changes = nil #True if files had to be rescanned
end
def recheck
rescan if @changes.nil?
tracker.run_checks if @changes
Brakeman::RescanReport.new @old_results, tracker.checks
end
def rescan
tracker.template_cache.clear
@changes = false
@paths.each do |path|
if rescan_file path
@changes = true
end
end
index_call_sites
self
end
def rescan_file path
case file_type path
when :controller
rescan_controller path
when :template
rescan_template path
when :model
rescan_model path
when :lib
process_library path
when :config
process_config
when :initializer
process_initializer path
when :routes
# Routes affect which controller methods are treated as actions
# which affects which templates are rendered, so routes, controllers,
# and templates rendered from controllers must be rescanned
tracker.reset_routes
tracker.reset_templates :only_rendered => true
process_routes
process_controllers
when :gemfile
process_gems
else
return false #Nothing to do, file hopefully does not need to be rescanned
end
true
end
def rescan_controller path
#Process source
process_controller path
#Process data flow and template rendering
#from the controller
tracker.controllers.each do |name, controller|
if controller[:file] == path
tracker.templates.keys.each do |template_name|
if template_name.to_s.match /(.+)\.#{name}#/
tracker.templates.delete template_name
end
end
@processor.process_controller_alias controller[:src]
end
end
end
def rescan_template path
template_name = template_path_to_name(path)
tracker.reset_template template_name
process_template path
@processor.process_template_alias tracker.templates[template_name]
rescan = Set.new
rendered_from_controller = /^#{template_name}\.(.+Controller)#(.+)/
rendered_from_view = /^#{template_name}\.Template:(.+)/
#Search for processed template and process it.
#Search for rendered versions of template and re-render (if necessary)
tracker.templates.each do |name, template|
if template[:file] == path or template[:file].nil?
name = name.to_s
if name.match(rendered_from_controller)
#Rendered from controller, so reprocess controller
rescan << [:controller, $1.to_sym, $2.to_sym]
elsif name.match(rendered_from_view)
#Rendered from another template, so reprocess that template
rescan << [:template, $1.to_sym]
end
end
end
rescan.each do |r|
if r[0] == :controller
controller = tracker.controllers[r[1]]
if @paths.include? controller[:file]
rescan_controller controller[:file]
else
@processor.process_controller_alias controller[:src], r[2]
end
elsif r[0] == :template
template = tracker.templates[r[1]]
rescan_template template[:file]
end
end
end
def rescan_model path
num_models = tracker.models.length
tracker.reset_model path
process_model path if File.exists? path
#Only need to rescan other things if a model is added or removed
if num_models != tracker.models.length
process_templates
process_controllers
end
end
#Guess at what kind of file the path contains
def file_type path
case path
when /\/app\/controllers/
:controller
when /\/app\/views/
:template
when /\/app\/models/
:model
when /\/lib/
:lib
when /\/config\/initializers/
:initializer
when /config\/routes\.rb/
:routes
when /\/config/
:config
when /Gemfile/
:gemfile
else
:unknown
end
end
end
class Brakeman::RescanReport
attr_reader :old_results, :new_results
def initialize old_results, new_results
@old_results = old_results
@new_results = new_results
@diff = nil
end
#Returns an array of warnings which were in the old report but are not in the
#new report after rescanning
def fixed_warnings
diff[:fixed]
end
#Returns an array of warnings which were in the new report but were not in
#the old report
def new_warnings
diff[:new]
end
#Returns true if there are any new or fixed warnings
def warnings_changed?
not (diff[:new].empty? and diff[:fixed].empty?)
end
#Returns a hash of arrays for :new and :fixed warnings
def diff
@diff ||= @old_results.diff(@new_results)
end
end
#This is from Rails 3 version of the Erubis handler
class Brakeman::RailsXSSErubis < ::Erubis::Eruby
......
Markdown is supported
0% 或 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑！
想要评论请 注册 或