Merge pull request #157 from presidentbeef/fix_single_arg_scopes

Fix scope calls with single arguments

README.md

@@ -153,10 +153,10 @@ The `-c` option can be used to specify a configuration file to use.
 
 The MIT License
 
-Copyright (c) 2010-2012, YELLOWPAGES.COM, LLC
-
 Copyright (c) 2012, Twitter, Inc.
 
+Copyright (c) 2010-2012, YELLOWPAGES.COM, LLC
+
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights

lib/brakeman/checks/check_sql.rb

@@ -72,6 +72,8 @@ class Brakeman::CheckSQL < Brakeman::BaseCheck
           model[:options][:scope].each do |args|
             second_arg = args[2]
 
+            next unless sexp? second_arg
+
             if second_arg.node_type == :iter and node_type? second_arg.block, :block, :call
               process_scope_with_block name, args
             elsif second_arg.node_type == :call

test/apps/rails2/app/models/account.rb

 class Account < ActiveRecord::Base
   validates_format_of :name, :with => /^[a-zA-Z]+$/
+
+  named_scope :all
 end

test/apps/rails3.1/app/models/user.rb

@@ -21,4 +21,6 @@ class User < ActiveRecord::Base
     something = something_helper
     where("something = #{something}")
   }
+
+  scope :all
 end