Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
社会瑞弟呀
brakeman
提交
41892e91
B
brakeman
项目概览
社会瑞弟呀
/
brakeman
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
B
brakeman
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
41892e91
编写于
4月 17, 2012
作者:
O
oreoshake
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
If there are no new warnings, there can't possibly be any line mismatches
上级
c7bb69d2
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
6 addition
and
3 deletion
+6
-3
lib/brakeman/differ.rb
lib/brakeman/differ.rb
+6
-3
未找到文件。
lib/brakeman/differ.rb
浏览文件 @
41892e91
...
...
@@ -11,7 +11,7 @@ class Brakeman::Differ
def
diff
# get the type of elements
return
DEFAULT_HASH
if
@
old_warnings
.
empty?
&&
@
new_warnings
.
empty?
return
DEFAULT_HASH
if
@new_warnings
.
empty?
warnings
=
{}
warnings
[
:new
]
=
@new_warnings
-
@old_warnings
...
...
@@ -20,14 +20,17 @@ class Brakeman::Differ
second_pass
(
warnings
)
end
# second pass to cleanup any vulns which have changed in line number only
# second pass to cleanup any vulns which have changed in line number only.
# Given a list of new warnings, delete pairs of new/fixed vulns that differ
# only by line number.
# Horrible O(n^2) performance. Keep n small :-/
def
second_pass
(
warnings
)
# keep track of the number of elements deleted because the index numbers
# won't update as the list is modified
elements_deleted_offset
=
0
# dup this list since we will be deleting from it and the iterator gets confused
# dup this list since we will be deleting from it and the iterator gets confused.
# use _with_index for fast deletion as opposed to .reject!{|obj| obj == *_warning}
warnings
[
:new
].
dup
.
each_with_index
do
|
new_warning
,
new_warning_id
|
warnings
[
:fixed
].
each_with_index
do
|
fixed_warning
,
fixed_warning_id
|
if
eql_except_line_number
new_warning
,
fixed_warning
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录