Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
社会瑞弟呀
brakeman
提交
119a5864
B
brakeman
项目概览
社会瑞弟呀
/
brakeman
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
B
brakeman
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
119a5864
编写于
8月 29, 2012
作者:
J
Justin
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #136 from oreoshake/warn_on_to_json
High confidence warnings on `to_json`
上级
a4fc0bbd
3259ef1b
变更
7
隐藏空白更改
内联
并排
Showing
7 changed file
with
93 addition
and
8 deletion
+93
-8
lib/brakeman/checks/check_cross_site_scripting.rb
lib/brakeman/checks/check_cross_site_scripting.rb
+29
-5
test/apps/rails2/app/controllers/home_controller.rb
test/apps/rails2/app/controllers/home_controller.rb
+6
-0
test/apps/rails2/app/views/home/test_to_json.html.erb
test/apps/rails2/app/views/home/test_to_json.html.erb
+14
-0
test/apps/rails_with_xss_plugin/app/controllers/users_controller.rb
...rails_with_xss_plugin/app/controllers/users_controller.rb
+4
-0
test/apps/rails_with_xss_plugin/app/views/users/to_json.html.erb
...ps/rails_with_xss_plugin/app/views/users/to_json.html.erb
+1
-0
test/tests/test_rails2.rb
test/tests/test_rails2.rb
+29
-2
test/tests/test_rails_with_xss_plugin.rb
test/tests/test_rails_with_xss_plugin.rb
+10
-1
未找到文件。
lib/brakeman/checks/check_cross_site_scripting.rb
浏览文件 @
119a5864
...
...
@@ -34,7 +34,7 @@ class Brakeman::CheckCrossSiteScripting < Brakeman::BaseCheck
FORM_BUILDER
=
Sexp
.
new
(
:call
,
Sexp
.
new
(
:const
,
:FormBuilder
),
:new
,
Sexp
.
new
(
:arglist
))
#Run check
def
run_check
def
run_check
@ignore_methods
=
Set
[
:button_to
,
:check_box
,
:content_tag
,
:escapeHTML
,
:escape_once
,
:field_field
,
:fields_for
,
:h
,
:hidden_field
,
:hidden_field
,
:hidden_field_tag
,
:image_tag
,
:label
,
...
...
@@ -58,6 +58,16 @@ class Brakeman::CheckCrossSiteScripting < Brakeman::BaseCheck
@known_dangerous
<<
:strip_tags
end
matches
=
tracker
.
check_initializers
:ActiveSupport
,
:escape_html_entities_in_json
=
json_escape_on
=
matches
.
detect
{
|
result
|
true
?
result
[
-
1
].
first_arg
}
if
!
json_escape_on
or
version_between?
"0.0.0"
,
"2.0.99"
@known_dangerous
<<
:
to_json
Brakeman
.
debug
(
"Automatic to_json escaping not enabled, consider to_json dangerous"
)
else
Brakeman
.
debug
(
"Automatic to_json escaping is enabled."
)
end
tracker
.
each_template
do
|
name
,
template
|
@current_template
=
template
template
[
:outputs
].
each
do
|
out
|
...
...
@@ -115,12 +125,20 @@ class Brakeman::CheckCrossSiteScripting < Brakeman::BaseCheck
confidence
=
CONFIDENCE
[
:med
]
end
message
=
"Unescaped model attribute"
link_path
=
"cross_site_scripting"
if
node_type?
(
out
,
:call
,
:attrasgn
)
&&
out
.
method
==
:to_json
message
+=
" in JSON hash"
link_path
+=
"_to_json"
end
code
=
find_chain
out
,
match
warn
:template
=>
@current_template
,
:warning_type
=>
"Cross Site Scripting"
,
:message
=>
"Unescaped model attribute"
,
:message
=>
message
,
:code
=>
code
,
:confidence
=>
confidence
:confidence
=>
confidence
,
:link_path
=>
link_path
end
else
...
...
@@ -173,8 +191,13 @@ class Brakeman::CheckCrossSiteScripting < Brakeman::BaseCheck
if
message
and
not
duplicate?
exp
add_result
exp
if
exp
.
target
.
nil?
and
@known_dangerous
.
include?
exp
.
method
link_path
=
"cross_site_scripting"
if
@known_dangerous
.
include?
exp
.
method
confidence
=
CONFIDENCE
[
:high
]
if
exp
.
method
==
:to_json
message
+=
" in JSON hash"
link_path
+=
"_to_json"
end
else
confidence
=
CONFIDENCE
[
:low
]
end
...
...
@@ -184,7 +207,8 @@ class Brakeman::CheckCrossSiteScripting < Brakeman::BaseCheck
:message
=>
message
,
:code
=>
exp
,
:user_input
=>
@matched
.
match
,
:confidence
=>
confidence
:confidence
=>
confidence
,
:link_path
=>
link_path
end
end
...
...
test/apps/rails2/app/controllers/home_controller.rb
浏览文件 @
119a5864
...
...
@@ -141,6 +141,12 @@ class HomeController < ApplicationController
@user
=
User
.
find
(
current_user
)
end
def
test_to_json
@model_json
=
User
.
find
(
current_user
).
to_json
@not_json
=
{
:thing
=>
params
[
:thing
]}
@json
=
{
:json_thing
=>
params
[
:json_thing
]}.
to_json
end
private
def
filter_it
...
...
test/apps/rails2/app/views/home/test_to_json.html.erb
0 → 100644
浏览文件 @
119a5864
Detection of to_json
<%=
@model_json
%>
In the view
<%=
@not_json
.
to_json
%>
In the controller
<%=
@json
%>
You would break the json formatting by doing this, but it's technically safe...
<%=
h
(
@json
)
%>
test/apps/rails_with_xss_plugin/app/controllers/users_controller.rb
浏览文件 @
119a5864
...
...
@@ -125,4 +125,8 @@ class UsersController < ApplicationController
def
results
@users
=
User
.
all
(
:conditions
=>
"display_name like '%
#{
params
[
:query
]
}
%'"
)
end
def
to_json
end
end
test/apps/rails_with_xss_plugin/app/views/users/to_json.html.erb
0 → 100644
浏览文件 @
119a5864
<%=
raw
({
:asdf
=>
params
[
:asdf
]}.
to_json
)
%>
\ No newline at end of file
test/tests/test_rails2.rb
浏览文件 @
119a5864
...
...
@@ -11,13 +11,13 @@ class Rails2Tests < Test::Unit::TestCase
@expected
||=
{
:controller
=>
1
,
:model
=>
2
,
:template
=>
3
3
,
:template
=>
3
6
,
:warning
=>
31
}
else
@expected
||=
{
:controller
=>
1
,
:model
=>
2
,
:template
=>
3
3
,
:template
=>
3
6
,
:warning
=>
32
}
end
end
...
...
@@ -691,5 +691,32 @@ class Rails2Tests < Test::Unit::TestCase
:confidence
=>
0
,
:file
=>
/test_strip_tags\.html\.erb/
end
def
test_to_json
assert_warning
:type
=>
:template
,
:warning_type
=>
"Cross Site Scripting"
,
:line
=>
3
,
:message
=>
/^Unescaped model attribute in JSON hash/
,
:confidence
=>
0
,
:file
=>
/test_to_json\.html\.erb/
assert_warning
:type
=>
:template
,
:warning_type
=>
"Cross Site Scripting"
,
:line
=>
7
,
:message
=>
/^Unescaped parameter value in JSON hash/
,
:confidence
=>
0
,
:file
=>
/test_to_json\.html\.erb/
assert_warning
:type
=>
:template
,
:warning_type
=>
"Cross Site Scripting"
,
:line
=>
11
,
:message
=>
/^Unescaped parameter value in JSON hash/
,
:confidence
=>
0
,
:file
=>
/test_to_json\.html\.erb/
assert_no_warning
:type
=>
:template
,
:warning_type
=>
"Cross Site Scripting"
,
:line
=>
14
,
:message
=>
/^Unescaped parameter value in JSON hash/
,
:confidence
=>
0
,
:file
=>
/test_to_json\.html\.erb/
end
end
test/tests/test_rails_with_xss_plugin.rb
浏览文件 @
119a5864
...
...
@@ -10,7 +10,7 @@ class RailsWithXssPluginTests < Test::Unit::TestCase
@expected
||=
{
:controller
=>
1
,
:model
=>
3
,
:template
=>
1
,
:template
=>
2
,
:warning
=>
14
}
end
...
...
@@ -257,4 +257,13 @@ class RailsWithXssPluginTests < Test::Unit::TestCase
:confidence
=>
0
,
:file
=>
/Gemfile/
end
def
test_to_json
assert_warning
:type
=>
:template
,
:warning_type
=>
"Cross Site Scripting"
,
:line
=>
1
,
:message
=>
/^Unescaped parameter value in JSON hash/
,
:confidence
=>
0
,
:file
=>
/users\/to_json\.html\.erb/
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录