AAE-944 remove information from the interface (#3095)

activiti-api/activiti-api-task-model/src/main/java/org/activiti/api/task/model/Task.java

@@ -16,11 +16,10 @@
 
 package org.activiti.api.task.model;
 
-import java.util.Date;
-import java.util.List;
-
 import org.activiti.api.model.shared.model.ApplicationElement;
 
+import java.util.Date;
+
 public interface Task extends ApplicationElement {
 
     enum TaskStatus {
@@ -38,10 +37,6 @@ public interface Task extends ApplicationElement {
 
     String getAssignee();
 
-    List<String> getCandidateUsers();
-
-    List<String> getCandidateGroups();
-
     String getName();
 
     String getDescription();

activiti-core/activiti-api-impl/activiti-api-task-model-impl/src/main/java/org/activiti/api/task/model/impl/TaskImpl.java

@@ -85,7 +85,6 @@ public class TaskImpl extends ApplicationElementImpl implements Task {
         this.assignee = assignee;
     }
 
-    @Override
     public List<String> getCandidateUsers(){
         return candidateUsers;
     }
@@ -94,7 +93,6 @@ public class TaskImpl extends ApplicationElementImpl implements Task {
         this.candidateUsers = candidateUsers;
     }
 
-    @Override
     public List<String> getCandidateGroups(){
         return candidateGroups;
     }

activiti-core/activiti-api-impl/activiti-api-task-runtime-impl/src/test/java/org/activiti/runtime/api/impl/TaskRuntimeImplTest.java

@@ -98,8 +98,8 @@ public class TaskRuntimeImplTest {
 
         Task task = taskRuntime.task(taskId);
 
-        assertThat(task.getCandidateUsers()).isEmpty();
-        assertThat(task.getCandidateGroups()).isEmpty();
+        assertThat(task).isNotInstanceOf(TaskImpl.class);
+        assertThat(task).isEqualTo(taskMock);
     }
 
     @Test
@@ -135,7 +135,7 @@ public class TaskRuntimeImplTest {
         given(identityLink.getGroupId())
                 .willReturn("group");
 
-        Task task = taskRuntime.task(taskId);
+        TaskImpl task = (TaskImpl) taskRuntime.task(taskId);
         assertThat(task.getCandidateUsers()).isNotNull();
         assertThat(task.getCandidateUsers()).containsExactly("user");
         assertThat(task.getCandidateGroups()).isNotNull();

activiti-core/activiti-spring-boot-starter/src/test/java/org/activiti/spring/boot/tasks/TaskRuntimeCandidatesTest.java

@@ -6,6 +6,7 @@ import java.util.List;
 
 import org.activiti.api.task.model.Task;
 import org.activiti.api.task.model.builders.TaskPayloadBuilder;
+import org.activiti.api.task.model.impl.TaskImpl;
 import org.activiti.api.task.runtime.TaskAdminRuntime;
 import org.activiti.api.task.runtime.TaskRuntime;
 import org.activiti.spring.boot.RuntimeTestConfiguration;
@@ -56,7 +57,7 @@ public class TaskRuntimeCandidatesTest {
         securityUtil.logInAs("dean");
 
         // the target user should be able to see the task as well
-        Task task = taskRuntime.task(createTask.getId());
+        TaskImpl task = (TaskImpl) taskRuntime.task(createTask.getId());
         assertThat(task.getAssignee()).isEqualTo("dean");
         assertThat(task.getStatus()).isEqualTo(Task.TaskStatus.ASSIGNED);
 
@@ -79,7 +80,7 @@ public class TaskRuntimeCandidatesTest {
         .extracting(event -> event.getEntity().getUserId())
         .contains("garth");
 
-        task = taskRuntime.task(createTask.getId());
+        task = (TaskImpl) taskRuntime.task(createTask.getId());
         userCandidatesOnTask = task.getCandidateUsers();
         assertThat(userCandidatesOnTask).isNotNull();
         assertThat(userCandidatesOnTask.size()).isEqualTo(0);
@@ -102,7 +103,7 @@ public class TaskRuntimeCandidatesTest {
         .contains("garth",
                   "garth");
 
-        task = taskRuntime.task(createTask.getId());
+        task = (TaskImpl) taskRuntime.task(createTask.getId());
         userCandidatesOnTask = task.getCandidateUsers();
         assertThat(userCandidatesOnTask).isNotNull();
         assertThat(userCandidatesOnTask.size()).isEqualTo(1);
@@ -138,7 +139,7 @@ public class TaskRuntimeCandidatesTest {
                 .extracting(event -> event.getEntity().getGroupId())
                 .contains("test");
 
-        Task task = taskRuntime.task(createTask.getId());
+        TaskImpl task = (TaskImpl) taskRuntime.task(createTask.getId());
         List<String> groupCandidatesOnTask = task.getCandidateGroups();
         assertThat(groupCandidatesOnTask).isNotNull();
         assertThat(groupCandidatesOnTask.size()).isEqualTo(1);
@@ -158,7 +159,7 @@ public class TaskRuntimeCandidatesTest {
                 .extracting(event -> event.getEntity().getGroupId())
                 .contains("test");
 
-        task = taskRuntime.task(createTask.getId());
+        task = (TaskImpl) taskRuntime.task(createTask.getId());
         groupCandidatesOnTask = task.getCandidateGroups();
         assertThat(groupCandidatesOnTask).isNotNull();
         assertThat(groupCandidatesOnTask.size()).isEqualTo(0);