1. 06 5月, 2019 1 次提交
  2. 26 4月, 2019 1 次提交
  3. 21 4月, 2019 1 次提交
  4. 17 4月, 2019 1 次提交
    • R
      LeakAwareDataBuffer related fixes · 375090bb
      Rossen Stoyanchev 提交于
      Following on 3ebbfa21 where the local
      refCount was removed in favor of using the internal refCount of the
      native data buffer, this commit ensures that LeakAwareDataBufferFactory
      uses a PooledDataBufferFactory delegate by default.
      
      There are also fixes for test issues with eager allocation uncovered by
      these changes in StringDecoder and ResourceDecoder.
      375090bb
  5. 11 4月, 2019 1 次提交
    • R
      Fix refCount issue in LeakAwareDataBuffer · 3ebbfa21
      Rossen Stoyanchev 提交于
      LeakAwareDataBuffer was keeping its own refCount rather than checking
      through the delegate. This leads to false leak reports in a sequence
      where an allocated buffer is retained and then sliced since it is not
      aware of the changes to the refCount through the slice.
      3ebbfa21
  6. 10 4月, 2019 1 次提交
  7. 09 4月, 2019 1 次提交
  8. 08 4月, 2019 2 次提交
  9. 06 4月, 2019 4 次提交
  10. 04 4月, 2019 3 次提交
  11. 03 4月, 2019 3 次提交
  12. 31 3月, 2019 1 次提交
  13. 29 3月, 2019 3 次提交
    • P
      Use RepeatableContainers.none() in AnnotationUtils · f273fa99
      Phillip Webb 提交于
      Update `AnnotationUtils` so that `RepeatableContainers.none()` is used
      when performing an exhaustive search for merged annotations. These
      parameters were accidentally removed in commit 210b1789 and weren't
      caught earlier because we were missing a test.
      
      Closes gh-22702
      f273fa99
    • P
      Ignore 'value' attribute in AnnotationTypeMapping · 800cbf25
      Phillip Webb 提交于
      Update `addConventionAnnotationValues` so that `value` attributes
      do not override existing annotation values. The aligns the new
      `MergedAnnotations` API with the previous `AnnotatedElementUtils`
      logic.
      
      Closes gh-22703
      800cbf25
    • R
      Uncomment buffer leak tests in DataBufferUtils · beae1fbb
      Rossen Stoyanchev 提交于
      Following a response on
      https://github.com/reactor/reactor-core/issues/1634 apparently
      FluxSink is respecting doOnDiscard but there is a race condition
      in DataBufferUtils with file reading.
      
      This commit makes two changes:
      1) Add more checks for onDispose to detect cancellation signals
      as well as to deal with potentially concurrent such signal.
      2) Do not close the channel through the Flux.using callback but
      rather allow the current I/O callback to take place and only then
      close the channel or else the buffer is left hanging.
      
      Despite this tests still can fail due to a suspected issue in Reactor
      itself with the doOnDiscard callback for FluxSink. That's tracked under
      the same issue https://github.com/reactor/reactor-core/issues/1634
      and for now the use of DefaultDataBufferFactory is enforced as a
      workaround until the issue is resolved.
      
      See gh-22107
      beae1fbb
  14. 28 3月, 2019 3 次提交
  15. 27 3月, 2019 2 次提交
    • J
      Refined retrieval of plain annotations through direct presence checks · c9857702
      Juergen Hoeller 提交于
      Shortcut checks apply for hasPlainJavaAnnotationsOnly types as well now.
      
      Closes gh-22685
      c9857702
    • R
      Buffer leak fixes · c5435578
      Rossen Stoyanchev 提交于
      Address issues where buffers are allocated (and cached somehow) at or
      before subscription, and before explicit demand.
      
      The commit adds tests proving the leaks and fixes. The common thread
      for all tests is a "zero demand" subscriber that subscribes  but does
      not request, and then cancels without consuming anything.
      
      Closes gh-22107
      c5435578
  16. 26 3月, 2019 3 次提交
    • J
      Polishing · 63530564
      Juergen Hoeller 提交于
      63530564
    • J
      Restore retrieval of plain annotations through direct presence checks · 210b1789
      Juergen Hoeller 提交于
      Includes deprecation of several AnnotationUtils methods and nullability refinements for passed-in function arguments at the MergedAnnotation API level... also, MergedAnnotation.getType() returns a Class now.
      
      Closes gh-22663
      Closes gh-22685
      210b1789
    • P
      Fix annotation value mapping regression · 0ace0be2
      Phillip Webb 提交于
      Refine `TypeMappedAnnotation.getValueFromMetaAnnotation` to correctly
      account for aliases when finding values from meta-annotations. Prior
      to this commit, only convention based mappings were considered when
      searching for values on meta-annotations. This meant that declared
      meta-annotations that used aliases could return the "default value"
      rather than the merged value.
      
      Closes gh-22654
      0ace0be2
  17. 25 3月, 2019 1 次提交
    • P
      Defensively copy array returned from forAnnotations · cb7f9979
      Phillip Webb 提交于
      Update the proxy used in `AnnotatedElementUtils.forAnnotations` so
      that it returns a cloned array for calls to `getDeclaredAnnotations`
      or `getAnnotations`. This matches the behavior of standard JDK
      `AnnotatedElement` implementations.
      
      Closes gh-22655
      cb7f9979
  18. 23 3月, 2019 8 次提交
    • S
      URL Cleanup · 540759ec
      Spring Operator 提交于
      This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
      
      # Fixed URLs
      
      ## Fixed Success
      These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.
      
      * [ ] http://www.apache.org/licenses/ with 1 occurrences migrated to:
        https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200).
      * [ ] http://www.apache.org/licenses/LICENSE-2.0 with 6515 occurrences migrated to:
        https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).
      540759ec
    • S
      URL Cleanup - update remaining license headers · 9b7215e6
      Sam Brannen 提交于
      See gh-22617 gh-22622 gh-22635
      9b7215e6
    • J
      Nullability refinements (no IntelliJ warnings, fewer null checks) · 5e15338a
      Juergen Hoeller 提交于
      Includes consistent ignoring of all java.lang (meta-)annotations.
      
      Closes gh-22586
      5e15338a
    • P
      Complete migration of annotation utility methods · 37255afc
      Phillip Webb 提交于
      Delete `InternalAnnotationUtils` and `InternalAnnotatedElementUtils` and
      migrate exclusively to the new `MergedAnnotations` API.
      
      Closes gh-22562
      37255afc
    • P
      Migrate and verify annotation utility methods · a14bfe9a
      Phillip Webb 提交于
      Migrate all possible `AnnotationUtils` and `AnnotatedElementUtils`
      method to the `MergedAnnotation` API, verify results against the old
      implementations.
      
      All migrated methods now call both the new API and the old version and
      ensure that the same results or exceptions are raised. A full build of
      both Spring Framework and Spring Boot has been executed to ensure, as
      much as possible, that the migration does not cause unexpected
      regressions.
      
      See gh-22562
      a14bfe9a
    • P
      Start migration annotation utility methods · b91ccf03
      Phillip Webb 提交于
      Create internal variants of the existing `AnnotationUtils` and
      `AnnotatedElementUtils` classes and migrate the existing classes to
      use them.
      
      The internal variants will be used to check that the same results are
      given as we migrate the utils methods to use the new `MergedAnnotations`
      API.
      
      See gh-22562
      b91ccf03
    • P
      Create a new API for handling merged annotations · 4972d85a
      Phillip Webb 提交于
      Add new `MergedAnnotations` and `MergedAnnotation` interfaces that
      attempt to provide a uniform way for dealing with merged annotations.
      
      Specifically, the new API provides alternatives for the static methods
      in `AnnotationUtils` and `AnnotatedElementUtils` and supports Spring's
      comprehensive annotation attribute `@AliasFor` features. The interfaces
      also open the possibility of the same API being exposed from the
      `AnnotationMetadata` interface.
      
      Additional utility classes for collecting, filtering and selecting
      annotations have also been added.
      
      Typical usage for the new API would be something like:
      
      	MergedAnnotations.from(Example.class)
      		.stream(MyAnnotation.class)
      		.map(a -> a.getString("value"))
      		.forEach(System.out::println);
      
      Closes gh-21697
      4972d85a
    • P
      Add AnnotationIntrospectionFailureTests · fdacda8b
      Phillip Webb 提交于
      Add a new test class to help cover annotation introspection failure
      handling. These tests were previously missing and are important to
      ensure that annotation util code changes don't introduce regressions.
      
      See gh-21697
      fdacda8b