Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
爱吃血肠
spring-framework
提交
6075c813
S
spring-framework
项目概览
爱吃血肠
/
spring-framework
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
S
spring-framework
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
6075c813
编写于
12月 15, 2016
作者:
J
Juergen Hoeller
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Consistent DeferredResultHandler invocation outside of result lock
Issue: SPR-14978 (cherry picked from commit
86614afb
)
上级
f473392a
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
68 addition
and
25 deletion
+68
-25
spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResult.java
...ngframework/web/context/request/async/DeferredResult.java
+68
-25
未找到文件。
spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResult.java
浏览文件 @
6075c813
/*
* Copyright 2002-201
5
the original author or authors.
* Copyright 2002-201
6
the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
...
...
@@ -43,6 +43,7 @@ import org.springframework.web.context.request.NativeWebRequest;
* is added to a {@link PriorityQueue} it is handled in the correct order.
*
* @author Rossen Stoyanchev
* @author Juergen Hoeller
* @author Rob Winch
* @since 3.2
*/
...
...
@@ -65,7 +66,7 @@ public class DeferredResult<T> {
private
volatile
Object
result
=
RESULT_NONE
;
private
volatile
boolean
expired
;
private
volatile
boolean
expired
=
false
;
/**
...
...
@@ -142,24 +143,39 @@ public class DeferredResult<T> {
*/
public
final
void
setResultHandler
(
DeferredResultHandler
resultHandler
)
{
Assert
.
notNull
(
resultHandler
,
"DeferredResultHandler is required"
);
// Immediate expiration check outside of the result lock
if
(
this
.
expired
)
{
return
;
}
Object
resultToHandle
;
synchronized
(
this
)
{
this
.
resultHandler
=
resultHandler
;
if
(
this
.
result
!=
RESULT_NONE
&&
!
this
.
expired
)
{
try
{
this
.
resultHandler
.
handleResult
(
this
.
result
);
}
catch
(
Throwable
ex
)
{
logger
.
trace
(
"DeferredResult not handled"
,
ex
);
}
// Got the lock in the meantime: double-check expiration status
if
(
this
.
expired
)
{
return
;
}
resultToHandle
=
this
.
result
;
if
(
resultToHandle
==
RESULT_NONE
)
{
// No result yet: store handler for processing once it comes in
this
.
resultHandler
=
resultHandler
;
return
;
}
}
// If we get here, we need to process an existing result object immediately.
// The decision is made within the result lock; just the handle call outside
// of it, avoiding any deadlock potential with Servlet container locks.
try
{
resultHandler
.
handleResult
(
resultToHandle
);
}
catch
(
Throwable
ex
)
{
logger
.
debug
(
"Failed to handle existing result"
,
ex
);
}
}
/**
* Set the value for the DeferredResult and handle it.
* @param result the value to set
* @return
"true"
if the result was set and passed on for handling;
*
"false"
if the result was already set or the async request expired
* @return
{@code true}
if the result was set and passed on for handling;
*
{@code false}
if the result was already set or the async request expired
* @see #isSetOrExpired()
*/
public
boolean
setResult
(
T
result
)
{
...
...
@@ -167,15 +183,32 @@ public class DeferredResult<T> {
}
private
boolean
setResultInternal
(
Object
result
)
{
// Immediate expiration check outside of the result lock
if
(
isSetOrExpired
())
{
return
false
;
}
DeferredResultHandler
resultHandlerToUse
;
synchronized
(
this
)
{
// Got the lock in the meantime: double-check expiration status
if
(
isSetOrExpired
())
{
return
false
;
}
// At this point, we got a new result to process
this
.
result
=
result
;
resultHandlerToUse
=
this
.
resultHandler
;
if
(
resultHandlerToUse
==
null
)
{
// No result handler set yet -> let the setResultHandler implementation
// pick up the result object and invoke the result handler for it.
return
true
;
}
// Result handler available -> let's clear the stored reference since
// we don't need it anymore.
this
.
resultHandler
=
null
;
}
if
(
this
.
resultHandler
!=
null
)
{
this
.
resultHandler
.
handleResult
(
this
.
result
);
}
// If we get here, we need to process an existing result object immediately.
// The decision is made within the result lock; just the handle call outside
// of it, avoiding any deadlock potential with Servlet container locks.
resultHandlerToUse
.
handleResult
(
result
);
return
true
;
}
...
...
@@ -184,8 +217,9 @@ public class DeferredResult<T> {
* The value may be an {@link Exception} or {@link Throwable} in which case
* it will be processed as if a handler raised the exception.
* @param result the error result value
* @return "true" if the result was set to the error value and passed on for
* handling; "false" if the result was already set or the async request expired
* @return {@code true} if the result was set to the error value and passed on
* for handling; {@code false} if the result was already set or the async
* request expired
* @see #isSetOrExpired()
*/
public
boolean
setErrorResult
(
Object
result
)
{
...
...
@@ -197,19 +231,28 @@ public class DeferredResult<T> {
return
new
DeferredResultProcessingInterceptorAdapter
()
{
@Override
public
<
S
>
boolean
handleTimeout
(
NativeWebRequest
request
,
DeferredResult
<
S
>
deferredResult
)
{
if
(
timeoutCallback
!=
null
)
{
timeoutCallback
.
run
();
boolean
continueProcessing
=
true
;
try
{
if
(
timeoutCallback
!=
null
)
{
timeoutCallback
.
run
();
}
}
if
(
DeferredResult
.
this
.
timeoutResult
!=
RESULT_NONE
)
{
setResultInternal
(
timeoutResult
);
finally
{
if
(
timeoutResult
!=
RESULT_NONE
)
{
continueProcessing
=
false
;
try
{
setResultInternal
(
timeoutResult
);
}
catch
(
Throwable
ex
)
{
logger
.
debug
(
"Failed to handle timeout result"
,
ex
);
}
}
}
return
true
;
return
continueProcessing
;
}
@Override
public
<
S
>
void
afterCompletion
(
NativeWebRequest
request
,
DeferredResult
<
S
>
deferredResult
)
{
synchronized
(
DeferredResult
.
this
)
{
expired
=
true
;
}
expired
=
true
;
if
(
completionCallback
!=
null
)
{
completionCallback
.
run
();
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录