Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
爱吃血肠
spring-framework
提交
3eee118b
S
spring-framework
项目概览
爱吃血肠
/
spring-framework
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
S
spring-framework
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
3eee118b
编写于
11月 26, 2018
作者:
R
Rossen Stoyanchev
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Polish
上级
959cf616
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
38 addition
and
73 deletion
+38
-73
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceUrlEncodingFilter.java
...ework/web/servlet/resource/ResourceUrlEncodingFilter.java
+8
-9
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceUrlEncodingFilterTests.java
.../web/servlet/resource/ResourceUrlEncodingFilterTests.java
+30
-64
未找到文件。
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceUrlEncodingFilter.java
浏览文件 @
3eee118b
...
...
@@ -126,17 +126,16 @@ public class ResourceUrlEncodingFilter extends GenericFilterBean {
return
null
;
}
private
int
getEndPathIndex
(
String
lookupP
ath
)
{
int
suffixIndex
=
lookupPath
.
length
(
);
int
queryIndex
=
lookupPath
.
indexOf
(
'?
'
);
if
(
queryIndex
>
0
)
{
suffixIndex
=
query
Index
;
private
int
getEndPathIndex
(
String
p
ath
)
{
int
end
=
path
.
indexOf
(
'?'
);
int
fragmentIndex
=
path
.
indexOf
(
'#
'
);
if
(
fragmentIndex
!=
-
1
&&
(
end
==
-
1
||
fragmentIndex
<
end
)
)
{
end
=
fragment
Index
;
}
int
hashIndex
=
lookupPath
.
indexOf
(
'#'
);
if
(
hashIndex
>
0
)
{
suffixIndex
=
Math
.
min
(
suffixIndex
,
hashIndex
);
if
(
end
==
-
1
)
{
end
=
path
.
length
();
}
return
suffixIndex
;
return
end
;
}
}
...
...
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceUrlEncodingFilterTests.java
浏览文件 @
3eee118b
...
...
@@ -15,9 +15,11 @@
*/
package
org.springframework.web.servlet.resource
;
import
java.io.IOException
;
import
java.util.ArrayList
;
import
java.util.Collections
;
import
java.util.List
;
import
javax.servlet.ServletException
;
import
javax.servlet.http.HttpServletResponse
;
import
org.junit.Before
;
...
...
@@ -68,27 +70,17 @@ public class ResourceUrlEncodingFilterTests {
@Test
public
void
encodeURL
()
throws
Exception
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"GET"
,
"/"
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
this
.
filter
.
doFilter
(
request
,
response
,
(
req
,
res
)
->
{
req
.
setAttribute
(
ResourceUrlProviderExposingInterceptor
.
RESOURCE_URL_PROVIDER_ATTR
,
this
.
urlProvider
);
String
result
=
((
HttpServletResponse
)
res
).
encodeURL
(
"/resources/bar.css"
);
assertEquals
(
"/resources/bar-11e16cf79faee7ac698c805cf28248d2.css"
,
result
);
});
testEncodeUrl
(
new
MockHttpServletRequest
(
"GET"
,
"/"
),
"/resources/bar.css"
,
"/resources/bar-11e16cf79faee7ac698c805cf28248d2.css"
);
}
@Test
public
void
encodeU
RL
WithContext
()
throws
Exception
{
public
void
encodeU
rl
WithContext
()
throws
Exception
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"GET"
,
"/context/foo"
);
request
.
setContextPath
(
"/context"
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
this
.
filter
.
doFilter
(
request
,
response
,
(
req
,
res
)
->
{
req
.
setAttribute
(
ResourceUrlProviderExposingInterceptor
.
RESOURCE_URL_PROVIDER_ATTR
,
this
.
urlProvider
);
String
result
=
((
HttpServletResponse
)
res
).
encodeURL
(
"/context/resources/bar.css"
);
assertEquals
(
"/context/resources/bar-11e16cf79faee7ac698c805cf28248d2.css"
,
result
);
});
testEncodeUrl
(
request
,
"/context/resources/bar.css"
,
"/context/resources/bar-11e16cf79faee7ac698c805cf28248d2.css"
);
}
...
...
@@ -96,9 +88,8 @@ public class ResourceUrlEncodingFilterTests {
public
void
encodeUrlWithContextAndForwardedRequest
()
throws
Exception
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"GET"
,
"/context/foo"
);
request
.
setContextPath
(
"/context"
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
this
.
filter
.
doFilter
(
request
,
response
,
(
req
,
res
)
->
{
this
.
filter
.
doFilter
(
request
,
new
MockHttpServletResponse
()
,
(
req
,
res
)
->
{
req
.
setAttribute
(
ResourceUrlProviderExposingInterceptor
.
RESOURCE_URL_PROVIDER_ATTR
,
this
.
urlProvider
);
request
.
setRequestURI
(
"/forwarded"
);
request
.
setContextPath
(
"/"
);
...
...
@@ -111,52 +102,35 @@ public class ResourceUrlEncodingFilterTests {
public
void
encodeContextPathUrlWithoutSuffix
()
throws
Exception
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"GET"
,
"/context"
);
request
.
setContextPath
(
"/context"
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
this
.
filter
.
doFilter
(
request
,
response
,
(
req
,
res
)
->
{
req
.
setAttribute
(
ResourceUrlProviderExposingInterceptor
.
RESOURCE_URL_PROVIDER_ATTR
,
this
.
urlProvider
);
String
result
=
((
HttpServletResponse
)
res
).
encodeURL
(
"/context/resources/bar.css"
);
assertEquals
(
"/context/resources/bar-11e16cf79faee7ac698c805cf28248d2.css"
,
result
);
});
testEncodeUrl
(
request
,
"/context/resources/bar.css"
,
"/context/resources/bar-11e16cf79faee7ac698c805cf28248d2.css"
);
}
@Test
public
void
encodeContextPathUrlWithSuffix
()
throws
Exception
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"GET"
,
"/context/"
);
request
.
setContextPath
(
"/context"
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
this
.
filter
.
doFilter
(
request
,
response
,
(
req
,
res
)
->
{
req
.
setAttribute
(
ResourceUrlProviderExposingInterceptor
.
RESOURCE_URL_PROVIDER_ATTR
,
this
.
urlProvider
);
String
result
=
((
HttpServletResponse
)
res
).
encodeURL
(
"/context/resources/bar.css"
);
assertEquals
(
"/context/resources/bar-11e16cf79faee7ac698c805cf28248d2.css"
,
result
);
});
testEncodeUrl
(
request
,
"/context/resources/bar.css"
,
"/context/resources/bar-11e16cf79faee7ac698c805cf28248d2.css"
);
}
@Test
// SPR-13018
public
void
encodeEmptyU
RL
WithContext
()
throws
Exception
{
public
void
encodeEmptyU
rl
WithContext
()
throws
Exception
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"GET"
,
"/context/foo"
);
request
.
setContextPath
(
"/context"
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
this
.
filter
.
doFilter
(
request
,
response
,
(
req
,
res
)
->
{
req
.
setAttribute
(
ResourceUrlProviderExposingInterceptor
.
RESOURCE_URL_PROVIDER_ATTR
,
this
.
urlProvider
);
String
result
=
((
HttpServletResponse
)
res
).
encodeURL
(
"?foo=1"
);
assertEquals
(
"?foo=1"
,
result
);
});
testEncodeUrl
(
request
,
"?foo=1"
,
"?foo=1"
);
}
@Test
// SPR-13374
public
void
encodeU
RL
WithRequestParams
()
throws
Exception
{
public
void
encodeU
rl
WithRequestParams
()
throws
Exception
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"GET"
,
"/foo"
);
request
.
setContextPath
(
"/"
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
this
.
filter
.
doFilter
(
request
,
response
,
(
req
,
res
)
->
{
req
.
setAttribute
(
ResourceUrlProviderExposingInterceptor
.
RESOURCE_URL_PROVIDER_ATTR
,
this
.
urlProvider
);
String
result
=
((
HttpServletResponse
)
res
).
encodeURL
(
"/resources/bar.css?foo=bar&url=http://example.org"
);
assertEquals
(
"/resources/bar-11e16cf79faee7ac698c805cf28248d2.css?foo=bar&url=http://example.org"
,
result
);
});
testEncodeUrl
(
request
,
"/resources/bar.css?foo=bar&url=http://example.org"
,
"/resources/bar-11e16cf79faee7ac698c805cf28248d2.css?foo=bar&url=http://example.org"
);
}
@Test
// SPR-13847
...
...
@@ -164,38 +138,30 @@ public class ResourceUrlEncodingFilterTests {
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"GET"
,
"/context-path/index"
);
request
.
setContextPath
(
"/context-path"
);
request
.
setServletPath
(
""
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
this
.
filter
.
doFilter
(
request
,
response
,
(
req
,
res
)
->
{
req
.
setAttribute
(
ResourceUrlProviderExposingInterceptor
.
RESOURCE_URL_PROVIDER_ATTR
,
this
.
urlProvider
);
String
result
=
((
HttpServletResponse
)
res
).
encodeURL
(
"index?key=value"
);
assertEquals
(
"index?key=value"
,
result
);
});
testEncodeUrl
(
request
,
"index?key=value"
,
"index?key=value"
);
}
@Test
// SPR-17535
public
void
encodeU
RLWit
Fragment
()
throws
Exception
{
public
void
encodeU
rlWith
Fragment
()
throws
Exception
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"GET"
,
"/foo"
);
request
.
setContextPath
(
"/"
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
this
.
filter
.
doFilter
(
request
,
response
,
(
req
,
res
)
->
{
req
.
setAttribute
(
ResourceUrlProviderExposingInterceptor
.
RESOURCE_URL_PROVIDER_ATTR
,
this
.
urlProvider
);
String
result
=
((
HttpServletResponse
)
res
).
encodeURL
(
"/resources/bar.css#something"
);
assertEquals
(
"/resources/bar-11e16cf79faee7ac698c805cf28248d2.css#something"
,
result
);
});
testEncodeUrl
(
request
,
"/resources/bar.css#something"
,
"/resources/bar-11e16cf79faee7ac698c805cf28248d2.css#something"
);
testEncodeUrl
(
request
,
"/resources/bar.css?foo=bar&url=http://example.org#something"
,
"/resources/bar-11e16cf79faee7ac698c805cf28248d2.css?foo=bar&url=http://example.org#something"
);
}
@Test
// SPR-13374 and SPR-17535 combined
public
void
encodeURLWitFragmentAndRequestParams
()
throws
Exception
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"GET"
,
"/foo"
);
request
.
setContextPath
(
"/"
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
private
void
testEncodeUrl
(
MockHttpServletRequest
request
,
String
url
,
String
expected
)
throws
ServletException
,
IOException
{
this
.
filter
.
doFilter
(
request
,
response
,
(
req
,
res
)
->
{
this
.
filter
.
doFilter
(
request
,
new
MockHttpServletResponse
()
,
(
req
,
res
)
->
{
req
.
setAttribute
(
ResourceUrlProviderExposingInterceptor
.
RESOURCE_URL_PROVIDER_ATTR
,
this
.
urlProvider
);
String
result
=
((
HttpServletResponse
)
res
).
encodeURL
(
"/resources/bar.css?foo=bar&url=http://example.org#something"
);
assertEquals
(
"/resources/bar-11e16cf79faee7ac698c805cf28248d2.css?foo=bar&url=http://example.org#something"
,
result
);
String
result
=
((
HttpServletResponse
)
res
).
encodeURL
(
url
);
assertEquals
(
expected
,
result
);
});
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录