Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
野花太放肆
jenkins
提交
f48249d9
J
jenkins
项目概览
野花太放肆
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f48249d9
编写于
8月 19, 2011
作者:
J
Jerome Lacoste
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Ignore global environment variables in maven builds instead of throwing exceptions.
上级
e48d3a0e
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
9 addition
and
5 deletion
+9
-5
changelog.html
changelog.html
+3
-0
maven-plugin/src/main/java/hudson/maven/AbstractMavenBuilder.java
...ugin/src/main/java/hudson/maven/AbstractMavenBuilder.java
+6
-5
未找到文件。
changelog.html
浏览文件 @
f48249d9
...
...
@@ -68,6 +68,9 @@ Upcoming changes</a>
<li
class=
rfe
>
go back to view page when job is deleted.
(
<a
href=
"https://issues.jenkins-ci.org/browse/JENKINS-10510"
>
issue 10510
</a>
)
<li
class=
rfe
>
A Global Environment variable with an empty key would fail maven builds since 1.424. Ignore these variables instead of failing the build.
(
<a
href=
"https://groups.google.com/forum/#!searchin/jenkinsci-users/timp/jenkinsci-users/YThhsdGBVwM/7_7GMYIYiRIJ"
>
report
</a>
)
</ul>
</div>
<!--=TRUNK-END=-->
...
...
maven-plugin/src/main/java/hudson/maven/AbstractMavenBuilder.java
浏览文件 @
f48249d9
...
...
@@ -74,17 +74,18 @@ public abstract class AbstractMavenBuilder implements DelegatingCallable<Result,
}
/**
* Add all the {@link #systemProps hudson defined system properties} into the {@link System#getProperties() system properties}
* @throws IllegalArgumentException if a {@link #systemProps hudson system property} has an empty key or null value
* Add all the {@link #systemProps jenkins environment variables} into the {@link System#getProperties() system properties}
* Ignores {@link #systemProps jenkins environment variables} with empty keys.
* @throws IllegalArgumentException if a {@link #systemProps jenkins environment variable} has null value
* as it blows up Maven.
* @see http
s://groups.google.com/forum/#!topic/jenkinsci-dev/hoxoNi7sNtk/discussion
* @see http
://jenkins.361315.n4.nabble.com/Upgrade-to-1-424-broke-our-Maven-builds-due-to-empty-system-property-key-td3726460.html
*/
protected
void
registerSystemProperties
()
{
for
(
Map
.
Entry
<
String
,
String
>
e
:
systemProps
.
entrySet
())
{
if
(
""
.
equals
(
e
.
getKey
()))
throw
new
IllegalArgumentException
(
"System property has an empty key"
)
;
continue
;
if
(
e
.
getValue
()==
null
)
throw
new
IllegalArgumentException
(
"
System property
"
+
e
.
getKey
()+
" has a null value"
);
throw
new
IllegalArgumentException
(
"
Global Environment Variable
"
+
e
.
getKey
()+
" has a null value"
);
System
.
getProperties
().
put
(
e
.
getKey
(),
e
.
getValue
());
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录